Re: [Xen-devel] [PATCH v7 08/12] arm: add ALL, QEMU, Rcar3 and MPSoC configs

2018-07-30 Thread Stefano Stabellini
On Mon, 30 Jul 2018, Julien Grall wrote: > Hi Stefano, > > On 28/07/18 00:30, Stefano Stabellini wrote: > > On Fri, 27 Jul 2018, Julien Grall wrote: > > > Hi Stefano, > > > Sorry for the top posting. > > > > > > I think Andrii made a good point. With your new code MPSOC will get built > > > on

Re: [Xen-devel] [PATCH v7 08/12] arm: add ALL, QEMU, Rcar3 and MPSoC configs

2018-07-30 Thread Andrii Anisov
Hello Stefano, > Ah, yes, I understand what you mean now. My point was to get the feature of minimal platform support right away. You are interested in Xilinx, so you make a minimal configuration for MPSOC. And stack  the rest into an *optional* all platforms support. So maintainers of other

Re: [Xen-devel] [PATCH v7 08/12] arm: add ALL, QEMU, Rcar3 and MPSoC configs

2018-07-30 Thread Julien Grall
Hi Stefano, On 28/07/18 00:30, Stefano Stabellini wrote: On Fri, 27 Jul 2018, Julien Grall wrote: Hi Stefano, Sorry for the top posting. I think Andrii made a good point. With your new code MPSOC will get built on Arm 32 bit as well. This was not the case before this patch. So I would like

Re: [Xen-devel] [PATCH v7 08/12] arm: add ALL, QEMU, Rcar3 and MPSoC configs

2018-07-27 Thread Stefano Stabellini
On Fri, 27 Jul 2018, Julien Grall wrote: > Hi Stefano, > Sorry for the top posting. > > I think Andrii made a good point. With your new code MPSOC will get built on > Arm 32 bit as well. > > This was not the case before this patch. > > So I would like at least that to be fixed before any

Re: [Xen-devel] [PATCH v7 08/12] arm: add ALL, QEMU, Rcar3 and MPSoC configs

2018-07-27 Thread Julien Grall
Hi Stefano, Sorry for the top posting. I think Andrii made a good point. With your new code MPSOC will get built on Arm 32 bit as well. This was not the case before this patch. So I would like at least that to be fixed before any commit. Cheers, On Fri, 27 Jul 2018, 22:38 Stefano Stabellini,

Re: [Xen-devel] [PATCH v7 08/12] arm: add ALL, QEMU, Rcar3 and MPSoC configs

2018-07-27 Thread Stefano Stabellini
On Fri, 27 Jul 2018, Andrii Anisov wrote: > Hello Stefano, > > On 27.07.18 20:11, Stefano Stabellini wrote: > > Yes, it does. > > > > Let's say that you chose ALL at the menu choice. MPSOC_PLATFORM gets > > selected, that trigger the build of the MPSOC platform file. > > > > If you do "make

Re: [Xen-devel] [PATCH v7 08/12] arm: add ALL, QEMU, Rcar3 and MPSoC configs

2018-07-27 Thread Andrii Anisov
Hello Stefano, On 27.07.18 20:11, Stefano Stabellini wrote: Yes, it does. Let's say that you chose ALL at the menu choice. MPSOC_PLATFORM gets selected, that trigger the build of the MPSOC platform file. If you do "make menuconfig" again and select RCAR3 instead, MPSOC_PLATFORM is removed

Re: [Xen-devel] [PATCH v7 08/12] arm: add ALL, QEMU, Rcar3 and MPSoC configs

2018-07-27 Thread Stefano Stabellini
On Fri, 27 Jul 2018, Andrii Anisov wrote: > On 27.07.18 01:46, Stefano Stabellini wrote: > > On Tue, 24 Jul 2018, Andrii Anisov wrote: > > > On 07.07.18 02:13, Stefano Stabellini wrote: > > > > Add a "Platform Support" choice with four kconfig options: QEMU, RCAR3, > > > > MPSOC and ALL. They

Re: [Xen-devel] [PATCH v7 08/12] arm: add ALL, QEMU, Rcar3 and MPSoC configs

2018-07-27 Thread Julien Grall
On 27/07/18 12:34, Andrii Anisov wrote: Hello Julien, On 27.07.18 14:27, Julien Grall wrote: There are no need for duplication. You can instead do something like: config ALL_64     default (ALL && ARM_64) config ALL_32     default (ALL && ARM_32) config MPSOC_PLATFORM     bool    

Re: [Xen-devel] [PATCH v7 08/12] arm: add ALL, QEMU, Rcar3 and MPSoC configs

2018-07-27 Thread Andrii Anisov
Hello Julien, On 27.07.18 14:27, Julien Grall wrote: There are no need for duplication. You can instead do something like: config ALL_64     default (ALL && ARM_64) config ALL_32     default (ALL && ARM_32) config MPSOC_PLATFORM     bool     default (ALL_64 || MPSOC) Yep, but then "config

Re: [Xen-devel] [PATCH v7 08/12] arm: add ALL, QEMU, Rcar3 and MPSoC configs

2018-07-27 Thread Julien Grall
Hi, On 27/07/18 12:21, Andrii Anisov wrote: I would suggest something like: diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index 06ba4a4..794f06e 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -218,6 +218,8 @@ config ARM64_HARDEN_BRANCH_PREDICTOR  config

Re: [Xen-devel] [PATCH v7 08/12] arm: add ALL, QEMU, Rcar3 and MPSoC configs

2018-07-27 Thread Andrii Anisov
I would suggest something like: diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index 06ba4a4..794f06e 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -218,6 +218,8 @@ config ARM64_HARDEN_BRANCH_PREDICTOR  config ARM32_HARDEN_BRANCH_PREDICTOR def_bool y if ARM_32 &&

Re: [Xen-devel] [PATCH v7 08/12] arm: add ALL, QEMU, Rcar3 and MPSoC configs

2018-07-27 Thread Julien Grall
Hi, On 27/07/18 11:30, Andrii Anisov wrote: On 27.07.18 01:46, Stefano Stabellini wrote: On 07.07.18 02:13, Stefano Stabellini wrote: Shouldn't MPSOC_PLATFORM be dependent on ARM64? Yes, and it is, see "config MPSOC" few lines above. Few lines above, only "config MPSOC" is dependent on ARM64.

Re: [Xen-devel] [PATCH v7 08/12] arm: add ALL, QEMU, Rcar3 and MPSoC configs

2018-07-27 Thread Andrii Anisov
Hello Stefano, On 27.07.18 01:46, Stefano Stabellini wrote: On Tue, 24 Jul 2018, Andrii Anisov wrote: On 07.07.18 02:13, Stefano Stabellini wrote: Add a "Platform Support" choice with four kconfig options: QEMU, RCAR3, MPSOC and ALL. They enable the required options for their hardware

Re: [Xen-devel] [PATCH v7 08/12] arm: add ALL, QEMU, Rcar3 and MPSoC configs

2018-07-26 Thread Stefano Stabellini
On Tue, 24 Jul 2018, Andrii Anisov wrote: > On 07.07.18 02:13, Stefano Stabellini wrote: > > Add a "Platform Support" choice with four kconfig options: QEMU, RCAR3, > > MPSOC and ALL. They enable the required options for their hardware > > platform. ALL enables all available platforms and it's the

Re: [Xen-devel] [PATCH v7 08/12] arm: add ALL, QEMU, Rcar3 and MPSoC configs

2018-07-24 Thread Stefano Stabellini
On Mon, 23 Jul 2018, Julien Grall wrote: > Hi Stefano, > > On 07/07/18 00:13, Stefano Stabellini wrote: > > +config QEMU_PLATFORM > > + bool > > + > > +config RCAR3_PLATFORM > > + bool > > Those 2 options do nothing. So I would prefer if they are removed. With that > fixed: > > Acked-by:

Re: [Xen-devel] [PATCH v7 08/12] arm: add ALL, QEMU, Rcar3 and MPSoC configs

2018-07-24 Thread Andrii Anisov
Hello Stefano, On 07.07.18 02:13, Stefano Stabellini wrote: Add a "Platform Support" choice with four kconfig options: QEMU, RCAR3, MPSOC and ALL. They enable the required options for their hardware platform. ALL enables all available platforms and it's the default. It doesn't automatically

Re: [Xen-devel] [PATCH v7 08/12] arm: add ALL, QEMU, Rcar3 and MPSoC configs

2018-07-23 Thread Julien Grall
Hi Stefano, On 07/07/18 00:13, Stefano Stabellini wrote: +config QEMU_PLATFORM + bool + +config RCAR3_PLATFORM + bool Those 2 options do nothing. So I would prefer if they are removed. With that fixed: Acked-by: Julien Grall Cheers, -- Julien Grall