Re: [Xen-devel] [RFC PATCH 09/49] ARM: VGIC: change to level-IRQ compatible IRQ injection interface

2018-02-13 Thread Julien Grall
Hi, On 12/02/18 14:24, Andre Przywara wrote: What would you expect the caller to do on error? Except printing an error message? I don't know either. Comparing this to hardware, an IRQ is usually fire-and-forget (separating the interrupt line from the interrupt state here), so a device doesn't

Re: [Xen-devel] [RFC PATCH 09/49] ARM: VGIC: change to level-IRQ compatible IRQ injection interface

2018-02-12 Thread Julien Grall
On 12/02/18 11:59, Andre Przywara wrote: Hi, Hi Andre, On 12/02/18 11:15, Julien Grall wrote: Hi Andre, On 09/02/18 14:38, Andre Przywara wrote: diff --git a/xen/arch/arm/vgic.c b/xen/arch/arm/vgic.c index 5f47aa84a9..2fc6e19625 100644 --- a/xen/arch/arm/vgic.c +++ b/xen/arch/arm/vgic.c

Re: [Xen-devel] [RFC PATCH 09/49] ARM: VGIC: change to level-IRQ compatible IRQ injection interface

2018-02-12 Thread Andre Przywara
Hi, On 12/02/18 11:15, Julien Grall wrote: > Hi Andre, > > On 09/02/18 14:38, Andre Przywara wrote: >> diff --git a/xen/arch/arm/vgic.c b/xen/arch/arm/vgic.c >> index 5f47aa84a9..2fc6e19625 100644 >> --- a/xen/arch/arm/vgic.c >> +++ b/xen/arch/arm/vgic.c >> @@ -285,7 +285,7 @@ bool

Re: [Xen-devel] [RFC PATCH 09/49] ARM: VGIC: change to level-IRQ compatible IRQ injection interface

2018-02-12 Thread Julien Grall
Hi Andre, On 09/02/18 14:38, Andre Przywara wrote: diff --git a/xen/arch/arm/vgic.c b/xen/arch/arm/vgic.c index 5f47aa84a9..2fc6e19625 100644 --- a/xen/arch/arm/vgic.c +++ b/xen/arch/arm/vgic.c @@ -285,7 +285,7 @@ bool vgic_migrate_irq(struct vcpu *old, struct vcpu *new, unsigned int irq)