Re: [Xen-devel] [RFC PATCH 71/84] x86/setup: start tearing down the direct map.

2019-09-27 Thread hongyax
On 27/09/2019 15:14, Jan Beulich wrote: On 27.09.2019 16:02, hong...@amazon.com wrote: But then why do the initial so many patches (inherited from Wei) convert from domheap to xenheap allocations at all? If your approach is to be at least an intermediate goal, then I think the order of changes

Re: [Xen-devel] [RFC PATCH 71/84] x86/setup: start tearing down the direct map.

2019-09-27 Thread hongyax
On 27/09/2019 15:14, Jan Beulich wrote: On 27.09.2019 16:02, hong...@amazon.com wrote: But then why do the initial so many patches (inherited from Wei) convert from domheap to xenheap allocations at all? If your approach is to be at least an intermediate goal, then I think the order of changes

Re: [Xen-devel] [RFC PATCH 71/84] x86/setup: start tearing down the direct map.

2019-09-27 Thread Jan Beulich
On 27.09.2019 16:02, hong...@amazon.com wrote: > On 27/09/2019 14:00, Jan Beulich wrote: >> On 27.09.2019 14:54, hong...@amazon.com wrote: >> >> Pre-populate? There's some conceptional question then: When the >> direct map is gone, are you mapping Xen heap pages into the place >> they'd have lived

Re: [Xen-devel] [RFC PATCH 71/84] x86/setup: start tearing down the direct map.

2019-09-27 Thread hongyax
On 27/09/2019 14:00, Jan Beulich wrote: On 27.09.2019 14:54, hong...@amazon.com wrote: Pre-populate? There's some conceptional question then: When the direct map is gone, are you mapping Xen heap pages into the place they'd have lived at in the direct map? I'm not convinced that's what we want.

Re: [Xen-devel] [RFC PATCH 71/84] x86/setup: start tearing down the direct map.

2019-09-27 Thread Julien Grall
Hi, On 27/09/2019 13:54, hong...@amazon.com wrote: On 26/09/2019 15:26, Wei Liu wrote: On Thu, Sep 26, 2019 at 10:46:34AM +0100, hong...@amazon.com wrote: From: Hongyan Xia Signed-off-by: Hongyan Xia ---   xen/arch/x86/setup.c    | 4 ++--   xen/common/page_alloc.c | 2 +-   2 files changed,

Re: [Xen-devel] [RFC PATCH 71/84] x86/setup: start tearing down the direct map.

2019-09-27 Thread Jan Beulich
On 27.09.2019 14:54, hong...@amazon.com wrote: > On 26/09/2019 15:26, Wei Liu wrote: >> On Thu, Sep 26, 2019 at 10:46:34AM +0100, hong...@amazon.com wrote: >>> --- a/xen/arch/x86/setup.c >>> +++ b/xen/arch/x86/setup.c >>> @@ -1367,7 +1367,7 @@ void __init noreturn __start_xen(unsigned long mbi_p)

Re: [Xen-devel] [RFC PATCH 71/84] x86/setup: start tearing down the direct map.

2019-09-27 Thread hongyax
On 26/09/2019 15:26, Wei Liu wrote: On Thu, Sep 26, 2019 at 10:46:34AM +0100, hong...@amazon.com wrote: From: Hongyan Xia Signed-off-by: Hongyan Xia --- xen/arch/x86/setup.c| 4 ++-- xen/common/page_alloc.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [Xen-devel] [RFC PATCH 71/84] x86/setup: start tearing down the direct map.

2019-09-26 Thread Wei Liu
On Thu, Sep 26, 2019 at 10:46:34AM +0100, hong...@amazon.com wrote: > From: Hongyan Xia > > Signed-off-by: Hongyan Xia > --- > xen/arch/x86/setup.c| 4 ++-- > xen/common/page_alloc.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/xen/arch/x86/setup.c

Re: [Xen-devel] [RFC PATCH 71/84] x86/setup: start tearing down the direct map.

2019-09-26 Thread Julien Grall
Hi, Title: Please remove the full stop. On 9/26/19 10:46 AM, hong...@amazon.com wrote: From: Hongyan Xia Please describe what the patch does and why. For instance, why you do you replace maddr_to_mfn(map_e) with INVALID_MFN? Why not just removing the complete call? Signed-off-by: