Re: [Xen-devel] automation: Creating a patchwork instance to improve pre-commit build testing - Summary of discussion so far

2018-07-25 Thread Lars Kurth
Hi all, given this was a fairly lengthy thread, I thought I'd summarize. Although I originally thought the proposal was uncontroversial, Jan has raised some concerns about extra e-mails that would be sent by the patch bot (aka 1 additional mail per series). From the discussion, I got the sense

Re: [Xen-devel] automation: Creating a patchwork instance to improve pre-commit build testing

2018-07-24 Thread Dario Faggioli
FWIW, On Tue, 2018-07-24 at 16:26 +0100, George Dunlap wrote: > On 07/24/2018 12:23 PM, Lars Kurth wrote: > > > > It seems to me there are a number of options we have and thus some > > decisions > > that need to be made. > > 2: Do we have an opt-in or op-out (e.g. through a tag, a specific > >

Re: [Xen-devel] automation: Creating a patchwork instance to improve pre-commit build testing

2018-07-24 Thread George Dunlap
On 07/24/2018 04:26 PM, George Dunlap wrote: > On 07/24/2018 12:23 PM, Lars Kurth wrote: >> >> On 24/07/2018, 11:50, "Julien Grall" wrote: >> >> Hi Lars, >> >> On 24/07/18 11:33, Lars Kurth wrote: >> > >> > On 24/07/2018, 11:19, "Wei Liu" wrote: >> > On Tue, Jul

Re: [Xen-devel] automation: Creating a patchwork instance to improve pre-commit build testing

2018-07-24 Thread George Dunlap
On 07/24/2018 12:23 PM, Lars Kurth wrote: > > On 24/07/2018, 11:50, "Julien Grall" wrote: > > Hi Lars, > > On 24/07/18 11:33, Lars Kurth wrote: > > > > On 24/07/2018, 11:19, "Wei Liu" wrote: > > On Tue, Jul 24, 2018 at 04:04:05AM -0600, Jan Beulich wrote: >

Re: [Xen-devel] automation: Creating a patchwork instance to improve pre-commit build testing

2018-07-24 Thread Doug Goldstein
On Tue, Jul 24, 2018 at 04:04:05AM -0600, Jan Beulich wrote: > >>> On 24.07.18 at 11:43, wrote: > > On Tue, Jul 24, 2018 at 03:34:51AM -0600, Jan Beulich wrote: > >> >>> On 24.07.18 at 11:24, wrote: > >> > On Tue, Jul 24, 2018 at 03:06:08AM -0600, Jan Beulich wrote: > >> >> >>> On 23.07.18 at

Re: [Xen-devel] automation: Creating a patchwork instance to improve pre-commit build testing

2018-07-24 Thread Doug Goldstein
On Tue, Jul 24, 2018 at 03:32:09PM +0100, George Dunlap wrote: > On 07/24/2018 10:34 AM, Jan Beulich wrote: > On 24.07.18 at 11:24, wrote: > >> On Tue, Jul 24, 2018 at 03:06:08AM -0600, Jan Beulich wrote: > >> On 23.07.18 at 18:40, wrote: > # How does this impact me? > The

Re: [Xen-devel] automation: Creating a patchwork instance to improve pre-commit build testing

2018-07-24 Thread George Dunlap
On 07/24/2018 10:34 AM, Jan Beulich wrote: On 24.07.18 at 11:24, wrote: >> On Tue, Jul 24, 2018 at 03:06:08AM -0600, Jan Beulich wrote: >> On 23.07.18 at 18:40, wrote: # How does this impact me? The contribution workflow is *not* impacted by this change, but once up and

Re: [Xen-devel] automation: Creating a patchwork instance to improve pre-commit build testing

2018-07-24 Thread Anthony PERARD
On Tue, Jul 24, 2018 at 11:23:34AM +, Lars Kurth wrote: > I am not quite sure what QEMU does. But I can't see any bot messages on their > list archives The bot from: is no-re...@patchew.org, for e.g.: - coding style: https://lists.nongnu.org/archive/html/qemu-devel/2018-07/msg01428.html -

Re: [Xen-devel] automation: Creating a patchwork instance to improve pre-commit build testing

2018-07-24 Thread Julien Grall
Hi Lars, On 24/07/18 11:33, Lars Kurth wrote: On 24/07/2018, 11:19, "Wei Liu" wrote: On Tue, Jul 24, 2018 at 04:04:05AM -0600, Jan Beulich wrote: > I'm afraid my personal bar for any such automation is pretty > high: There must not ever be any negative effect from such an

Re: [Xen-devel] automation: Creating a patchwork instance to improve pre-commit build testing

2018-07-24 Thread Lars Kurth
On 24/07/2018, 11:19, "Wei Liu" wrote: On Tue, Jul 24, 2018 at 04:04:05AM -0600, Jan Beulich wrote: > I'm afraid my personal bar for any such automation is pretty > high: There must not ever be any negative effect from such an > addition. Positive effects would of course be very

Re: [Xen-devel] automation: Creating a patchwork instance to improve pre-commit build testing

2018-07-24 Thread Wei Liu
On Tue, Jul 24, 2018 at 04:04:05AM -0600, Jan Beulich wrote: > >>> On 24.07.18 at 11:43, wrote: > > On Tue, Jul 24, 2018 at 03:34:51AM -0600, Jan Beulich wrote: > >> >>> On 24.07.18 at 11:24, wrote: > >> > On Tue, Jul 24, 2018 at 03:06:08AM -0600, Jan Beulich wrote: > >> >> >>> On 23.07.18 at

Re: [Xen-devel] automation: Creating a patchwork instance to improve pre-commit build testing

2018-07-24 Thread Lars Kurth
On 24/07/2018, 10:34, "Jan Beulich" wrote: >>> On 24.07.18 at 11:24, wrote: > On Tue, Jul 24, 2018 at 03:06:08AM -0600, Jan Beulich wrote: >> >>> On 23.07.18 at 18:40, wrote: >> > # How does this impact me? >> > The contribution workflow is *not* impacted by this change,

Re: [Xen-devel] automation: Creating a patchwork instance to improve pre-commit build testing

2018-07-24 Thread Jan Beulich
>>> On 24.07.18 at 11:43, wrote: > On Tue, Jul 24, 2018 at 03:34:51AM -0600, Jan Beulich wrote: >> >>> On 24.07.18 at 11:24, wrote: >> > On Tue, Jul 24, 2018 at 03:06:08AM -0600, Jan Beulich wrote: >> >> >>> On 23.07.18 at 18:40, wrote: >> >> > # How does this impact me? >> >> > The

Re: [Xen-devel] automation: Creating a patchwork instance to improve pre-commit build testing

2018-07-24 Thread Wei Liu
On Tue, Jul 24, 2018 at 03:34:51AM -0600, Jan Beulich wrote: > >>> On 24.07.18 at 11:24, wrote: > > On Tue, Jul 24, 2018 at 03:06:08AM -0600, Jan Beulich wrote: > >> >>> On 23.07.18 at 18:40, wrote: > >> > # How does this impact me? > >> > The contribution workflow is *not* impacted by this

Re: [Xen-devel] automation: Creating a patchwork instance to improve pre-commit build testing

2018-07-24 Thread Jan Beulich
>>> On 24.07.18 at 11:24, wrote: > On Tue, Jul 24, 2018 at 03:06:08AM -0600, Jan Beulich wrote: >> >>> On 23.07.18 at 18:40, wrote: >> > # How does this impact me? >> > The contribution workflow is *not* impacted by this change, but once up >> > and > >> > running the following will happen

Re: [Xen-devel] automation: Creating a patchwork instance to improve pre-commit build testing

2018-07-24 Thread Jan Beulich
>>> On 24.07.18 at 11:14, wrote: > On 24/07/18 10:06, Jan Beulich wrote: > On 23.07.18 at 18:40, wrote: >>> # How does this impact me? >>> The contribution workflow is *not* impacted by this change, but once up and >>> running the following will happen once you post a patch or patch series

Re: [Xen-devel] automation: Creating a patchwork instance to improve pre-commit build testing

2018-07-24 Thread Lars Kurth
On 24/07/2018, 10:06, "Jan Beulich" wrote: >>> On 23.07.18 at 18:40, wrote: > This does mean though that series which do not build or show other issues, > will likely not be reviewed until the tests pass. This would lessen the > burden on reviewers, as they will know

Re: [Xen-devel] automation: Creating a patchwork instance to improve pre-commit build testing

2018-07-24 Thread Wei Liu
On Tue, Jul 24, 2018 at 03:06:08AM -0600, Jan Beulich wrote: > >>> On 23.07.18 at 18:40, wrote: > > # How does this impact me? > > The contribution workflow is *not* impacted by this change, but once up and > > running the following will happen once you post a patch or patch series to > >

Re: [Xen-devel] automation: Creating a patchwork instance to improve pre-commit build testing

2018-07-24 Thread Andrew Cooper
On 24/07/18 10:06, Jan Beulich wrote: On 23.07.18 at 18:40, wrote: >> # How does this impact me? >> The contribution workflow is *not* impacted by this change, but once up and >> running the following will happen once you post a patch or patch series to >> xen-devel: >> * Patchwork will

Re: [Xen-devel] automation: Creating a patchwork instance to improve pre-commit build testing

2018-07-24 Thread Jan Beulich
>>> On 23.07.18 at 18:40, wrote: > # How does this impact me? > The contribution workflow is *not* impacted by this change, but once up and > running the following will happen once you post a patch or patch series to > xen-devel: > * Patchwork will take patch series from the mailing list and