Re: Report in downstream Debian: mpt3sas broken with xen dom0 with update to 5.10.149 in 5.10.y.

2023-03-14 Thread Joost Roeleveld
Hi Andrew, On Tue, Mar 14, 2023 at 11:41:08AM +, Andrew Cooper wrote: On 14/03/2023 11:23 am, Juergen Gross wrote: > On 14.03.23 12:17, Joost Roeleveld wrote: >>> On Mon, Oct 24, 2022 at 05:28:05PM +, Andrew Cooper wrote: I don't know exactly how this translates to Linux internals,

Re: Report in downstream Debian: mpt3sas broken with xen dom0 with update to 5.10.149 in 5.10.y.

2023-03-14 Thread Salvatore Bonaccorso
Hi Andrew, On Tue, Mar 14, 2023 at 11:41:08AM +, Andrew Cooper wrote: > On 14/03/2023 11:23 am, Juergen Gross wrote: > > On 14.03.23 12:17, Joost Roeleveld wrote: > >>> On Mon, Oct 24, 2022 at 05:28:05PM +, Andrew Cooper wrote: > I don't know exactly how this translates to Linux

Re: Report in downstream Debian: mpt3sas broken with xen dom0 with update to 5.10.149 in 5.10.y.

2023-03-14 Thread Andrew Cooper
On 14/03/2023 11:23 am, Juergen Gross wrote: > On 14.03.23 12:17, Joost Roeleveld wrote: >>> On Mon, Oct 24, 2022 at 05:28:05PM +, Andrew Cooper wrote: I don't know exactly how this translates to Linux internals, but most devices are fine and it's routinely the mpt2/3sas drivers

Re: Report in downstream Debian: mpt3sas broken with xen dom0 with update to 5.10.149 in 5.10.y.

2023-03-14 Thread Juergen Gross
On 14.03.23 12:17, Joost Roeleveld wrote: On Mon, Oct 24, 2022 at 05:28:05PM +, Andrew Cooper wrote: I don't know exactly how this translates to Linux internals, but most devices are fine and it's routinely the mpt2/3sas drivers which encounter problems.  It would be lovely if we could get

Re: Report in downstream Debian: mpt3sas broken with xen dom0 with update to 5.10.149 in 5.10.y.

2023-03-14 Thread Joost Roeleveld
On Mon, Oct 24, 2022 at 05:28:05PM +, Andrew Cooper wrote: I don't know exactly how this translates to Linux internals, but most devices are fine and it's routinely the mpt2/3sas drivers which encounter problems. It would be lovely if we could get to the bottom of this for once and for all.

Re: Report in downstream Debian: mpt3sas broken with xen dom0 with update to 5.10.149 in 5.10.y.

2022-10-25 Thread Juergen Gross
On 24.10.22 14:55, Juergen Gross wrote: On 24.10.22 13:56, Sreekanth Reddy wrote: On Sun, Oct 23, 2022 at 6:57 AM Bart Van Assche wrote: On 10/21/22 02:22, Salvatore Bonaccorso wrote: We got the following report in Debian after an update from 5.10.140 to the current 5.10.149. Full quoting

Re: Report in downstream Debian: mpt3sas broken with xen dom0 with update to 5.10.149 in 5.10.y.

2022-10-24 Thread Juergen Gross
On 24.10.22 20:50, James Bottomley wrote: On Mon, 2022-10-24 at 14:55 +0200, Juergen Gross wrote: [...] Please recheck the backported patch in 5.10.y. It is _wrong_. The backport has: --- a/drivers/scsi/mpt3sas/mpt3sas_base.c +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c @@ -2993,7 +2993,7 @@

Re: Report in downstream Debian: mpt3sas broken with xen dom0 with update to 5.10.149 in 5.10.y.

2022-10-24 Thread James Bottomley
On Mon, 2022-10-24 at 14:55 +0200, Juergen Gross wrote: [...] > Please recheck the backported patch in 5.10.y. It is _wrong_. The > backport > has: > > --- a/drivers/scsi/mpt3sas/mpt3sas_base.c > +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c > @@ -2993,7 +2993,7 @@ _base_config_dma_addressing(struct

Re: Report in downstream Debian: mpt3sas broken with xen dom0 with update to 5.10.149 in 5.10.y.

2022-10-24 Thread Christoph Hellwig
On Mon, Oct 24, 2022 at 05:28:05PM +, Andrew Cooper wrote: > I don't know exactly how this translates to Linux internals, but most > devices are fine and it's routinely the mpt2/3sas drivers which > encounter problems.  It would be lovely if we could get to the bottom of > this for once and

Re: Report in downstream Debian: mpt3sas broken with xen dom0 with update to 5.10.149 in 5.10.y.

2022-10-24 Thread Christoph Hellwig
On Mon, Oct 24, 2022 at 05:26:44PM +0530, Sreekanth Reddy wrote: > This issue is getting observed after having the below patch changes, > 2b9aba0c5d58e141e32bb1bb4c7cd91d19f075b8 scsi: mpt3sas: Fix return > value check of dma_get_required_mask() Looking at this commit it seems odd.

Re: Report in downstream Debian: mpt3sas broken with xen dom0 with update to 5.10.149 in 5.10.y.

2022-10-24 Thread Andrew Cooper
On 24/10/2022 17:58, Christoph Hellwig wrote: > On Mon, Oct 24, 2022 at 03:20:43PM +0200, Juergen Gross wrote: >> Dom0 is (normally) a PV domain, so the physical memory can be still above >> 4 GB even with dom0_mem set to 4GB. > Which means that we need to ensure the DMA ops for Xen-PV (which is >

Re: Report in downstream Debian: mpt3sas broken with xen dom0 with update to 5.10.149 in 5.10.y.

2022-10-24 Thread Christoph Hellwig
On Mon, Oct 24, 2022 at 03:20:43PM +0200, Juergen Gross wrote: > Dom0 is (normally) a PV domain, so the physical memory can be still above > 4 GB even with dom0_mem set to 4GB. Which means that we need to ensure the DMA ops for Xen-PV (which is always xen-swiotlb I think?) need to return

Re: Report in downstream Debian: mpt3sas broken with xen dom0 with update to 5.10.149 in 5.10.y.

2022-10-24 Thread Adi Kriegisch
Hi, On Mon, Oct 24, 2022 at 05:26:44PM +0530, Sreekanth Reddy wrote: > On Sun, Oct 23, 2022 at 6:57 AM Bart Van Assche wrote: > > > > On 10/21/22 02:22, Salvatore Bonaccorso wrote: > > > We got the following report in Debian after an update from 5.10.140 to > > > the current 5.10.149. Full

Re: Report in downstream Debian: mpt3sas broken with xen dom0 with update to 5.10.149 in 5.10.y.

2022-10-24 Thread Juergen Gross
On 24.10.22 14:51, James Bottomley wrote: On Mon, 2022-10-24 at 17:26 +0530, Sreekanth Reddy wrote: On Sun, Oct 23, 2022 at 6:57 AM Bart Van Assche wrote: On 10/21/22 02:22, Salvatore Bonaccorso wrote: We got the following report in Debian after an update from 5.10.140 to the current

Re: Report in downstream Debian: mpt3sas broken with xen dom0 with update to 5.10.149 in 5.10.y.

2022-10-24 Thread James Bottomley
On Mon, 2022-10-24 at 17:26 +0530, Sreekanth Reddy wrote: > On Sun, Oct 23, 2022 at 6:57 AM Bart Van Assche > wrote: > > On 10/21/22 02:22, Salvatore Bonaccorso wrote: > > > We got the following report in Debian after an update from > > > 5.10.140 to > > > the current 5.10.149. Full quoting below

Re: Report in downstream Debian: mpt3sas broken with xen dom0 with update to 5.10.149 in 5.10.y.

2022-10-24 Thread Juergen Gross
On 24.10.22 13:56, Sreekanth Reddy wrote: On Sun, Oct 23, 2022 at 6:57 AM Bart Van Assche wrote: On 10/21/22 02:22, Salvatore Bonaccorso wrote: We got the following report in Debian after an update from 5.10.140 to the current 5.10.149. Full quoting below (from

Re: Report in downstream Debian: mpt3sas broken with xen dom0 with update to 5.10.149 in 5.10.y.

2022-10-24 Thread Sreekanth Reddy
On Sun, Oct 23, 2022 at 6:57 AM Bart Van Assche wrote: > > On 10/21/22 02:22, Salvatore Bonaccorso wrote: > > We got the following report in Debian after an update from 5.10.140 to > > the current 5.10.149. Full quoting below (from > > https://bugs.debian.org/1022126). Does this ring some bell

Re: Report in downstream Debian: mpt3sas broken with xen dom0 with update to 5.10.149 in 5.10.y.

2022-10-22 Thread Bart Van Assche
On 10/21/22 02:22, Salvatore Bonaccorso wrote: We got the following report in Debian after an update from 5.10.140 to the current 5.10.149. Full quoting below (from https://bugs.debian.org/1022126). Does this ring some bell about known regressions? Only three mpt3sas changes are new in