Re: [Xen-devel] [PATCH v9 0/9] xen/x86: various XPTI speedups

2018-05-04 Thread Wei Liu
On Thu, Apr 26, 2018 at 01:33:09PM +0200, Juergen Gross wrote: > Juergen Gross (9): > x86/xpti: avoid copying L4 page table contents when possible > xen/x86: add a function for modifying cr3 > xen/x86: support per-domain flag for xpti > xen/x86: use invpcid for flushing the TLB >

Re: [Xen-devel] [PATCH v3 0/2] SVM: guest state handling adjustments

2018-05-04 Thread Boris Ostrovsky
On 05/04/2018 11:07 AM, Jan Beulich wrote: > Only patch 1 is clearly meant for 4.11. The second patch, however, eliminates > a (theoretical) window the first patch still leaves, so should at least be > considered. > Furthermore previous discussion suggests that it might even be desirable to >

Re: [Xen-devel] [PATCH for-4.11] x86/pv: Unconditionally hide EFER.SVME from PV guests

2018-05-04 Thread Andrew Cooper
On 04/05/18 19:45, Boris Ostrovsky wrote: > On 05/04/2018 01:28 PM, Andrew Cooper wrote: >> --- a/xen/include/asm-x86/msr-index.h >> +++ b/xen/include/asm-x86/msr-index.h >> @@ -31,6 +31,9 @@ >> #define EFER_LMSLE (1<<_EFER_LMSLE) >> #define EFER_FFXSE (1<<_EFER_FFXSE) >> >>

Re: [Xen-devel] [Votel] Graduation Review: Windows PV Driver

2018-05-04 Thread Wei Liu
+1 from me. Wei. ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v9 3/9] xen/x86: support per-domain flag for xpti

2018-05-04 Thread Wei Liu
On Fri, Apr 27, 2018 at 02:15:25AM -0600, Jan Beulich wrote: > >>> On 27.04.18 at 09:59, wrote: > > On 27/04/18 09:55, Sergey Dyasli wrote: > >> On Thu, 2018-04-26 at 13:33 +0200, Juergen Gross wrote: > >>> index b353352adf..220d1ba020 100644 > >>> ---

[Xen-devel] [PATCH v3 0/2] SVM: guest state handling adjustments

2018-05-04 Thread Jan Beulich
Only patch 1 is clearly meant for 4.11. The second patch, however, eliminates a (theoretical) window the first patch still leaves, so should at least be considered. Furthermore previous discussion suggests that it might even be desirable to fold both patches into one (or swap their order). 1:

Re: [Xen-devel] [PATCH RFC 2/7] xen/x86: Manually build PE header

2018-05-04 Thread Jan Beulich
>>> On 08.07.17 at 23:53, wrote: > This is the first step to get: > - one binary which can be loaded by the EFI loader, > Multiboot and Multiboot2 protocols, > - if we wish, in the future we can drop xen/xen.gz > and build xen.efi only, If anything, generate

[Xen-devel] [PATCH v3 2/2] SVM: introduce a VM entry helper

2018-05-04 Thread Jan Beulich
Neither the register values copying nor the trace entry generation need doing in assembly. The VMLOAD invocation can also be further deferred (and centralized). Therefore replace the svm_asid_handle_vmrun() invocation with one of the new helper. Similarly move the VM exit side register value

Re: [Xen-devel] [PATCH v2 7/8] xen_disk: use a single entry iovec

2018-05-04 Thread Paul Durrant
> -Original Message- > From: Paul Durrant [mailto:paul.durr...@citrix.com] > Sent: 04 May 2018 14:56 > To: xen-devel@lists.xenproject.org; qemu-bl...@nongnu.org; qemu- > de...@nongnu.org > Cc: Paul Durrant ; Stefano Stabellini > ; Anthony

Re: [Xen-devel] [PATCH RFC 3/7] xen/x86: Add some addresses to the Multiboot header

2018-05-04 Thread Jan Beulich
>>> On 08.07.17 at 23:53, wrote: > In comparison to ELF the PE format is not supported by the Multiboot > protocol. So, if we wish to load xen.efi using this protocol we have > to put header_addr, load_addr, load_end_addr, bss_end_addr and > entry_addr data into Multiboot

[Xen-devel] [PATCH v3 1/2] SVM: re-work VMCB sync-ing

2018-05-04 Thread Jan Beulich
While the main problem to be addressed here is the issue of what so far was named "vmcb_in_sync" starting out with the wrong value (should have been true instead of false, to prevent performing a VMSAVE without ever having VMLOADed the vCPU's state), go a step further and make the sync-ed state a

Re: [Xen-devel] [PATCH RFC 6/7] xen/x86/efi: Verify dom0 kernel with SHIM_LOCK protocol in efi_multiboot2()

2018-05-04 Thread Jan Beulich
>>> On 08.07.17 at 23:53, wrote: > --- a/xen/arch/x86/boot/head.S > +++ b/xen/arch/x86/boot/head.S > @@ -383,9 +383,13 @@ __efi64_mb2_start: > jmp x86_32_switch > > .Lefi_multiboot2_proto: > -/* Zero EFI SystemTable and EFI ImageHandle addresses.

Re: [Xen-devel] [PATCH for-4.11 v3 1/1] Add new add_maintainers.pl script to optimise the workflow when using git format-patch with get_maintainer.pl

2018-05-04 Thread Ian Jackson
Thanks. This is much better :-). I have reviewed this for style, obvious bugs, and the semantics in the doc comment. I haven't tried to follow the algorithm in detail, but I reckon it's probably OK. I have reordered the patch (and hence the file) to make the grouping of my comments make more

Re: [Xen-devel] [Votel] Graduation Review: Windows PV Driver

2018-05-04 Thread Jan Beulich
>>> On 04.05.18 at 16:51, wrote: > A bit more than a week ago, I put out for initial review the proposal for > “Graduation Review: Windows PV Driver” at > https://xen.markmail.org/thread/vcbvln7aa3ocikx4 +1 Jan ___

Re: [Xen-devel] [PATCH] docs: fix xpti command line option doc

2018-05-04 Thread Jan Beulich
>>> On 04.05.18 at 17:09, wrote: > Signed-off-by: Wei Liu I don't think a change like this really needs an ack, but here you go: Acked-by: Jan Beulich Jan ___ Xen-devel mailing list

[Xen-devel] [PATCH] docs: fix xpti command line option doc

2018-05-04 Thread Wei Liu
Signed-off-by: Wei Liu --- docs/misc/xen-command-line.markdown | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/misc/xen-command-line.markdown b/docs/misc/xen-command-line.markdown index e7a8bd66e7..616dc9d34c 100644 ---

[Xen-devel] [PATCH for-4.11] x86/pv: Unconditionally hide EFER.SVME from PV guests

2018-05-04 Thread Andrew Cooper
We don't advertise SVM in CPUID so a PV guest shouldn't be under the impression that it can use SVM functionality, but despite this, it really shouldn't see SVME set when reading EFER. Introduce EFER_KNOWN_MASK to whitelist the features Xen knows about, and use this to clamp the guests view.

Re: [Xen-devel] [PATCH v3 0/2] SVM: guest state handling adjustments

2018-05-04 Thread Andrew Cooper
On 04/05/18 16:07, Jan Beulich wrote: > Only patch 1 is clearly meant for 4.11. The second patch, however, eliminates > a (theoretical) window the first patch still leaves, so should at least be > considered. > Furthermore previous discussion suggests that it might even be desirable to > fold >

Re: [Xen-devel] [PATCH for-4.11] x86/pv: Unconditionally hide EFER.SVME from PV guests

2018-05-04 Thread Boris Ostrovsky
On 05/04/2018 01:28 PM, Andrew Cooper wrote: > --- a/xen/include/asm-x86/msr-index.h > +++ b/xen/include/asm-x86/msr-index.h > @@ -31,6 +31,9 @@ > #define EFER_LMSLE (1<<_EFER_LMSLE) > #define EFER_FFXSE (1<<_EFER_FFXSE) > > +#define EFER_KNOWN_MASK (EFER_SCE |

[Xen-devel] [xen-unstable baseline-only test] 74673: regressions - FAIL

2018-05-04 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 74673 xen-unstable real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/74673/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-win7-amd64 16

[Xen-devel] [xen-unstable-smoke test] 122604: trouble: blocked/broken/pass

2018-05-04 Thread osstest service owner
flight 122604 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/122604/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm broken

Re: [Xen-devel] reboot driver domain, vifX.Y = NO-CARRIER?

2018-05-04 Thread Marek Marczykowski-Górecki
On Fri, May 04, 2018 at 06:13:25PM -0400, Rich Persaud wrote: > > On May 1, 2018, at 08:53, Jason Cooper wrote: > > > > add the link to xen-users thread of me talking to myself. :-)) > > > >> On Tue, May 01, 2018 at 12:37:51PM +, Jason Cooper wrote: > >> When I was

[Xen-devel] [xen-unstable-smoke test] 122607: trouble: blocked/broken/pass

2018-05-04 Thread osstest service owner
flight 122607 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/122607/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm broken

[Xen-devel] [xen-4.10-testing test] 122592: regressions - trouble: blocked/broken/fail/pass

2018-05-04 Thread osstest service owner
flight 122592 xen-4.10-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/122592/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64 broken build-arm64-xsm

[Xen-devel] [xen-4.7-testing test] 122589: trouble: broken/fail/pass

2018-05-04 Thread osstest service owner
flight 122589 xen-4.7-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/122589/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-debianhvm-amd64 broken

[Xen-devel] [PATCH v3 1/8] xen_backend: add grant table helpers

2018-05-04 Thread Paul Durrant
This patch adds grant table helper functions to the xen_backend code to localize error reporting and use of xen_domid. The patch also defers the call to xengnttab_open() until just before the initialise method in XenDevOps is invoked. This method is responsible for mapping the shared ring. No

[Xen-devel] [PATCH v3 5/8] xen_disk: remove use of grant map/unmap

2018-05-04 Thread Paul Durrant
Now that the (native or emulated) xen_be_copy_grant_refs() helper is always available, the xen_disk code can be significantly simplified by removing direct use of grant map and unmap operations. Signed-off-by: Paul Durrant --- Cc: Stefano Stabellini

[Xen-devel] [PATCH v3 6/8] xen_backend: make the xen_feature_grant_copy flag private

2018-05-04 Thread Paul Durrant
There is no longer any use of this flag outside of the xen_backend code. Signed-off-by: Paul Durrant --- Cc: Stefano Stabellini Cc: Anthony Perard v2: - New in v2 --- hw/xen/xen_backend.c | 2 +-

Re: [Xen-devel] [PATCH 0/3] Document intent for supported build platforms and bump min glib to 2.42

2018-05-04 Thread Daniel P . Berrangé
CC'ing xen-devel in case Xen maintainers have a need for something that will that conflict with this proposal wrt supported build platforms. On Fri, May 04, 2018 at 05:00:23PM +0100, Daniel P. Berrangé wrote: > This short series is a followup the discussions around min glib version > when Olaf

Re: [Xen-devel] reboot driver domain, vifX.Y = NO-CARRIER?

2018-05-04 Thread Rich Persaud
> On May 1, 2018, at 08:53, Jason Cooper wrote: > > add the link to xen-users thread of me talking to myself. :-)) > >> On Tue, May 01, 2018 at 12:37:51PM +, Jason Cooper wrote: >> When I was first digging into this, I started a thread on xen-users [1], >> I've

[Xen-devel] [PATCH v3 8/8] xen_disk: be consistent with use of xendev and blkdev->xendev

2018-05-04 Thread Paul Durrant
Certain functions in xen_disk are called with a pointer to xendev (struct XenDevice *). They then use continer_of() to acces the surrounding blkdev (struct XenBlkDev) but then in various places use >xendev when use of the original xendev pointer is shorter to express and clearly equivalent. This

[Xen-devel] [PATCH v3 7/8] xen_disk: use a single entry iovec

2018-05-04 Thread Paul Durrant
Since xen_disk now always copies data to and from a guest there is no need to maintain a vector entry corresponding to every page of a request. This means there is less per-request state to maintain so the ioreq structure can shrink significantly. Signed-off-by: Paul Durrant

[Xen-devel] [PATCH v3 2/8] xen_disk: remove open-coded use of libxengnttab

2018-05-04 Thread Paul Durrant
Now that helpers are present in xen_backend, this patch removes open-coded calls to libxengnttab from the xen_disk code. This patch also fixes one whitspace error in the assignment of the XenDevOps initialise method. Signed-off-by: Paul Durrant --- Cc: Stefano

[Xen-devel] [PATCH v3 3/8] xen: remove other open-coded use of libxengnttab

2018-05-04 Thread Paul Durrant
Now that helpers are available in xen_backend, use them throughout all Xen PV backends. Signed-off-by: Paul Durrant --- Cc: Stefano Stabellini Cc: Anthony Perard Cc: Greg Kurz Cc: Paolo Bonzini

[Xen-devel] [PATCH v3 4/8] xen_backend: add an emulation of grant copy

2018-05-04 Thread Paul Durrant
Not all Xen environments support the xengnttab_grant_copy() operation. E.g. where the OS is FreeBSD or Xen is older than 4.8.0. This patch introduces an emulation of that operation using xengnttab_map_domain_grant_refs() and memcpy() for those environments. Signed-off-by: Paul Durrant

[Xen-devel] [PATCH v3 0/8] xen_disk: legacy code removal and cleanup

2018-05-04 Thread Paul Durrant
The grant copy operation was added to libxengnttab in Xen 4.8.0 (released nearly 18 months ago) but the xen_disk PV backend QEMU is still carrying a significant amount of code purely to remain compatible with older versions of Xen. As can be inferred from the diff stats below, removing this

[Xen-devel] [xen-unstable-smoke test] 122602: trouble: broken/pass

2018-05-04 Thread osstest service owner
flight 122602 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/122602/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-xsm broken

[Xen-devel] [distros-debian-jessie test] 74672: tolerable FAIL

2018-05-04 Thread Platform Team regression test user
flight 74672 distros-debian-jessie real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/74672/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-armhf-jessie-netboot-pygrub 10 debian-di-install fail like 74644 baseline version:

[Xen-devel] [GIT PULL] xen: one cleanup for 4.17-rc4

2018-05-04 Thread Juergen Gross
Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-4.17-rc4-tag xen: one cleanup for 4.17-rc4 It contains one cleanup to remove VLAs from the kernel. Thanks. Juergen arch/x86/xen/enlighten_pv.c | 86

[Xen-devel] [PATCH for-4.11 v3 1/1] Add new add_maintainers.pl script to optimise the workflow when using git format-patch with get_maintainer.pl

2018-05-04 Thread Lars Kurth
The tool covers step 2 of the following workflow Step 1: git format-patch ... -o ... Step 2: ./scripts/add_maintainers.pl -d This overwrites *.patch files in Step 3: git send-email -to xen-devel@lists.xenproject.org /*.patchxm I manually tested all options and the most common

[Xen-devel] [PATCH for-4.11 v3 0/1] Add new add_maintainers.pl script to optimise the workflow when using git format-patch with get_maintainer.pl

2018-05-04 Thread Lars Kurth
This version of this series addresses all comments on the mailing list, as well as some feedback I got in various personal conversations and/or on IRC. For the people who asked for specific features/workflows: Ian Jackson: use ./scripts/add_maintainers.pl -p none [-c top] Reads CCs from

[Xen-devel] [linux-linus test] 122578: regressions - FAIL

2018-05-04 Thread osstest service owner
flight 122578 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/122578/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt-raw 10 debian-di-installfail REGR. vs. 118324

Re: [Xen-devel] [PATCH RESEND v1 6/7] x86: Implement Intel Processor Trace MSRs read/write

2018-05-04 Thread Jan Beulich
>>> On 04.05.18 at 05:53, wrote: >> > Thanks for your clarification. Please correct me if I have >> > something wrong. Guest may execute an instruction and this instruction >> > may produce an PT packet save in PT output buffer. An EPT violation >> > will be generated

Re: [Xen-devel] 答复: [PATCH v3] x86/cpu: Add supports for zhaoxin x86 platform

2018-05-04 Thread Jan Beulich
>>> On 04.05.18 at 04:54, wrote: > 发件人: Jan Beulich > 发送时间: 2018年5月3日 23:09 >> +if ( cpu_has(c, X86_FEATURE_ITSC) ) >> +{ >> +__set_bit(X86_FEATURE_CONSTANT_TSC, c->x86_capability); >> +__set_bit(X86_FEATURE_NONSTOP_TSC,

[Xen-devel] [PATCH v2 5/8] xen_disk: remove use of grant map/unmap

2018-05-04 Thread Paul Durrant
Now that the (native or emulated) xen_be_copy_grant_refs() helper is always available, the xen_disk code can be significantly simplified by removing direct use of grant map and unmap operations. Signed-off-by: Paul Durrant --- Cc: Stefano Stabellini

[Xen-devel] [PATCH v2 8/8] xen_disk: be consistent with use of xendev and blkdev->xendev

2018-05-04 Thread Paul Durrant
Certain functions in xen_disk are called with a pointer to xendev (struct XenDevice *). They then use continer_of() to acces the surrounding blkdev (struct XenBlkDev) but then in various places use >xendev when use of the original xendev pointer is shorter to express and clearly equivalent. This

[Xen-devel] [PATCH v2 1/8] xen_backend: add grant table helpers

2018-05-04 Thread Paul Durrant
This patch adds grant table helper functions to the xen_backend code to localize error reporting and use of xen_domid. The patch also defers the call to xengnttab_open() until just before the initialise method in XenDevOps is invoked. This method is responsible for mapping the shared ring. No

[Xen-devel] [PATCH v2 0/8] xen_disk: legacy code removal and cleanup

2018-05-04 Thread Paul Durrant
The grant copy operation was added to libxengnttab in Xen 4.8.0 (released nearly 18 months ago) but the xen_disk PV backend QEMU is still carrying a significant amount of code purely to remain compatible with older versions of Xen. As can be inferred from the diff stats below, removing this

[Xen-devel] [PATCH v2 7/8] xen_disk: use a single entry iovec

2018-05-04 Thread Paul Durrant
Since xen_disk now always copies data to and from a guest there is no need to maintain a vector entry corresponding to every page of a request. This means there is less per-request state to maintain so the ioreq structure can shrink significantly. Signed-off-by: Paul Durrant

[Xen-devel] [PATCH v2 3/8] xen: remove other open-coded use of libxengnttab

2018-05-04 Thread Paul Durrant
Now that helpers are available in xen_backend, use them throughout all Xen PV backends. Signed-off-by: Paul Durrant --- Cc: Stefano Stabellini Cc: Anthony Perard Cc: Greg Kurz Cc: Paolo Bonzini

[Xen-devel] [PATCH v2 6/8] xen_backend: make the xen_feature_grant_copy flag private

2018-05-04 Thread Paul Durrant
There is no longer any use of this flag outside of the xen_backend code. Signed-off-by: Paul Durrant --- Cc: Stefano Stabellini Cc: Anthony Perard v2: - New in v2 --- hw/xen/xen_backend.c | 2 +-

[Xen-devel] [PATCH v2 4/8] xen_backend: add an emulation of grant copy

2018-05-04 Thread Paul Durrant
Not all Xen environments support the xengnttab_grant_copy() operation. E.g. where the OS is FreeBSD or Xen is older than 4.8.0. This patch introduces an emulation of that operation using xengnttab_map_domain_grant_refs() and memcpy() for those environments. Signed-off-by: Paul Durrant

[Xen-devel] [PATCH v2 2/8] xen_disk: remove open-coded use of libxengnttab

2018-05-04 Thread Paul Durrant
Now that helpers are present in xen_backend, this patch removes open-coded calls to libxengnttab from the xen_disk code. This patch also fixes one whitspace error in the assignment of the XenDevOps initialise method. Signed-off-by: Paul Durrant --- Cc: Stefano

[Xen-devel] [xen-unstable test] 122580: tolerable FAIL - PUSHED

2018-05-04 Thread osstest service owner
flight 122580 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/122580/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stopfail like 122493

[Xen-devel] Xen 4.11 RC3

2018-05-04 Thread Juergen Gross
Hi all, Xen 4.11 rc3 is tagged. You can check that out from xen.git: git://xenbits.xen.org/xen.git 4.11.0-rc3 For your convenience there is also a tarball at: https://downloads.xenproject.org/release/xen/4.11.0-rc3/xen-4.11.0-rc3.tar.gz And the signature is at:

[Xen-devel] [Votel] Graduation Review: Windows PV Driver

2018-05-04 Thread Lars Kurth
Hi all, A bit more than a week ago, I put out for initial review the proposal for “Graduation Review: Windows PV Driver” at https://xen.markmail.org/thread/vcbvln7aa3ocikx4 There has not been feedback, except for two recorded votes from the Xen Project Hypervisor Team by Ian Jackson and

Re: [Xen-devel] [Votel] Graduation Review: Windows PV Driver

2018-05-04 Thread Andrew Cooper
On 04/05/18 15:51, Lars Kurth wrote: > Hi all, > > A bit more than a week ago, I put out for initial review the proposal for > “Graduation Review: Windows PV Driver” at > https://xen.markmail.org/thread/vcbvln7aa3ocikx4 > There has not been feedback, except for two recorded votes from the Xen

[Xen-devel] [xen-unstable baseline-only test] 74668: regressions - FAIL

2018-05-04 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 74668 xen-unstable real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/74668/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-freebsd10-i386 22