Re: [Xen-devel] [PATCH 13/13] xen/arm: Avoid to use current everywhere in enter_hypervisor_head

2018-05-24 Thread Julien Grall
Hi Stefano, On 24/05/18 00:47, Stefano Stabellini wrote: On Tue, 22 May 2018, Julien Grall wrote: Using current is fairly expensive, so save up into a variable. Signed-off-by: Julien Grall Good idea. I am curious to know actually how much this patch would save but I

Re: [Xen-devel] MSR_SPEC_CTRL intercept

2018-05-24 Thread Jan Beulich
>>> On 24.05.18 at 12:13, wrote: > On 24/05/18 09:13, Jan Beulich wrote: > On 24.05.18 at 00:09, wrote: >>> It is, as documented, not completely strictly true (according to the >>> latest revision of the spec), but is there deliberately

Re: [Xen-devel] MSR_SPEC_CTRL intercept

2018-05-24 Thread Andrew Cooper
On 24/05/18 09:13, Jan Beulich wrote: On 24.05.18 at 00:09, wrote: >> It is, as documented, not completely strictly true (according to the >> latest revision of the spec), but is there deliberately to simply so we >> don't give the guest implausible configurations.

Re: [Xen-devel] [PATCH 06/13] xen/arm: Add ARCH_WORKAROUND_2 support for guests

2018-05-24 Thread Julien Grall
Hi Stefano, On 24/05/18 01:40, Stefano Stabellini wrote: On Wed, 23 May 2018, Stefano Stabellini wrote: On Tue, 22 May 2018, Julien Grall wrote: In order to offer ARCH_WORKAROUND_2 support to guests, we need to track the state of the workaround per-vCPU. The field 'pad' in cpu_info is now

Re: [Xen-devel] [PATCH 05/13] xen/arm: Add command line option to control SSBD mitigation

2018-05-24 Thread Julien Grall
Hi Stefano, On 24/05/18 00:23, Stefano Stabellini wrote: On Tue, 22 May 2018, Julien Grall wrote: +extern enum ssbd_state ssbd_state; + +static inline enum ssbd_state get_ssbd_state(void) +{ +return ssbd_state; +} + DECLARE_PER_CPU(register_t, ssbd_callback_required); static inline

Re: [Xen-devel] [PATCH v3 18/27] xen: Adapt assembly for PIE support

2018-05-24 Thread Juergen Gross
On 23/05/18 21:54, Thomas Garnier wrote: > Change the assembly code to use the new _ASM_MOVABS macro which get a > symbol reference while being PIE compatible. Adapt the relocation tool > to ignore 32-bit Xen code. > > Position Independent Executable (PIE) support will allow to extended the >

Re: [Xen-devel] [v2 1/6] Port WARN_ON_ONCE() from Linux

2018-05-24 Thread Jan Beulich
>>> On 24.05.18 at 02:46, wrote: > Port WARN_ON_ONCE macro from Linux. In such a case you should justify adjustments you've made: > --- a/xen/include/xen/lib.h > +++ b/xen/include/xen/lib.h > @@ -11,6 +11,19 @@ > #define BUG_ON(p) do { if (unlikely(p)) BUG(); } while

Re: [Xen-devel] MSR_SPEC_CTRL intercept

2018-05-24 Thread Jan Beulich
>>> On 24.05.18 at 00:09, wrote: > It is, as documented, not completely strictly true (according to the > latest revision of the spec), but is there deliberately to simply so we > don't give the guest implausible configurations. There is not a > processor with STIBP

Re: [Xen-devel] [PATCH v3 07/10] arm: make it possible to disable the SMMU driver

2018-05-24 Thread Andrii Anisov
Hello Stefano, On 23.05.18 22:16, Stefano Stabellini wrote: I meant "default y" because I am only trying to introduce the options in this patch series, I am not trying to change the defaults (yet). In any case, even with "default y" it works as intended if you start from tiny.config. 1) cp

Re: [Xen-devel] [v2 6/6] xen/smmu: Add a new config define for legacy SMMU

2018-05-24 Thread Jan Beulich
>>> On 24.05.18 at 02:46, wrote: > --- a/xen/drivers/passthrough/arm/Makefile > +++ b/xen/drivers/passthrough/arm/Makefile > @@ -1,3 +1,3 @@ > obj-y += iommu.o > -obj-y += smmu.o > +obj-$(CONFIG_ARM_SMMU) += smmu.o > obj-$(CONFIG_ARM_SMMU_v3) += smmu-v3.o Same question

Re: [Xen-devel] [v2 5/6] drivers/passthrough/arm: Refactor code for arm smmu drivers

2018-05-24 Thread Jan Beulich
>>> On 24.05.18 at 02:46, wrote: > Pull common defines for SMMU drives in a local header. > > Signed-off-by: Sameer Goel > --- > xen/drivers/passthrough/arm/arm_smmu.h | 125 + This being a local header - why the arm_

Re: [Xen-devel] [PATCH v2 10/10] xen: add cloc target

2018-05-24 Thread Jan Beulich
>>> On 23.05.18 at 20:21, wrote: > On Wed, 23 May 2018, Jan Beulich wrote: >> >>> On 22.05.18 at 22:08, wrote: >> > On Tue, 22 May 2018, Jan Beulich wrote: >> >> >>> On 22.05.18 at 02:53, wrote: >> >> > + $(eval

[Xen-devel] [xen-unstable test] 123058: regressions - FAIL

2018-05-24 Thread osstest service owner
flight 123058 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/123058/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-debianhvm-amd64-xsm 16 guest-localmigrate/x10 fail REGR. vs. 122804

Re: [Xen-devel] [PATCH] x86: suppress sync when XPTI is disabled for a domain

2018-05-24 Thread Jan Beulich
>>> On 23.05.18 at 16:24, wrote: > Now that we have a per-domain flag we can and should control sync-ing in > a more fine grained manner: Only domains having XPTI enabled need the > sync to occur. > > Signed-off-by: Jan Beulich > > --- a/xen/arch/x86/mm.c

<    1   2