Re: [Xen-devel] [PATCH] net: xenbus: remove redundant condition check before debugfs_remove_recursive

2018-09-12 Thread David Miller
From: zhong jiang Date: Sat, 8 Sep 2018 21:35:06 +0800 > debugfs_remove_recursive has taken the IS_ERR_OR_NULL into account. Just > remove the unnecessary condition check. > > Signed-off-by: zhong jiang Applied to net-next. ___ Xen-devel mailing

Re: [Xen-devel] [PATCH v2 1/1] cameraif: add ABI for para-virtual camera

2018-09-12 Thread Hans Verkuil
On 09/11/2018 10:29 AM, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > This is the ABI for the two halves of a para-virtualized > camera driver which extends Xen's reach multimedia capabilities even > farther enabling it for video conferencing, In-Vehicle Infotainment, > high

Re: [Xen-devel] [PATCH 2/6] xen/sched: Use %*pb[l] instead of cpumask_scn{, list}printf()

2018-09-12 Thread Dario Faggioli
On Fri, 2018-09-07 at 15:42 +0100, George Dunlap wrote: > On 09/06/2018 01:08 PM, Andrew Cooper wrote: > > This removes all use of keyhandler_scratch as a bounce-buffer for > > the rendered > > string. In some cases, collapse combine adjacent printk()'s which > > are writing > > parts of the same

Re: [Xen-devel] [PATCH 5/6] xen/bitmap: Drop all bitmap_scn{, list}printf() infrastructure

2018-09-12 Thread Dario Faggioli
On Thu, 2018-09-06 at 13:08 +0100, Andrew Cooper wrote: > All callers have been convered to using %*pb[l]. In the unlikely > case that > future code wants to retain this functionaly, it can be replicated in > a more > convenient fashon with snprintf(). > > Signed-off-by: Andrew Cooper >

Re: [Xen-devel] [PATCH 5/5] formats: print time values as decimals

2018-09-12 Thread Dario Faggioli
On Tue, 2018-09-11 at 11:33 +0100, George Dunlap wrote: > On 09/10/2018 05:41 PM, Andrii Anisov wrote: > > From: Andrii Anisov > > > > For convinience, print RTDS budget and deadline values as decimals. > > I agree, this is a lot better. > > Signed-off-by: Andrii Anisov > > Acked-by: George

[Xen-devel] [libvirt test] 127524: regressions - FAIL

2018-09-12 Thread osstest service owner
flight 127524 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/127524/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 123814 build-amd64-libvirt

Re: [Xen-devel] [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops

2018-09-12 Thread Jan Beulich
>>> On 12.09.18 at 10:31, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 07 September 2018 12:11 >> >> >>> On 23.08.18 at 11:47, wrote: >> > This patch adds a new method to the VT-d IOMMU implementation to find >> the >> > MFN currently mapped by the specified BFN along with a

Re: [Xen-devel] [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops

2018-09-12 Thread Paul Durrant
> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf > Of Paul Durrant > Sent: 12 September 2018 09:45 > To: 'Jan Beulich' > Cc: xen-devel ; Kevin Tian > ; George Dunlap > Subject: Re: [Xen-devel] [PATCH v6 08/14] vtd: add lookup_page method to

Re: [Xen-devel] [PATCH v6 13/14] x86: add iommu_ops to modify and flush IOMMU mappings

2018-09-12 Thread Jan Beulich
>>> On 23.08.18 at 11:47, wrote: > +static int iommuop_map(struct xen_iommu_op_map *op) > +{ > +struct domain *d, *currd = current->domain; > +struct domain_iommu *iommu = dom_iommu(currd); > +bool readonly = op->flags & XEN_IOMMUOP_map_readonly; > +bfn_t bfn = _bfn(op->bfn); > +

Re: [Xen-devel] Xen 4.12 Development Update

2018-09-12 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 12 September 2018 09:21 > To: Paul Durrant ; Juergen Gross > > Cc: xen-devel > Subject: Re: Xen 4.12 Development Update > > >>> On 12.09.18 at 08:54, wrote: > > === x86 === > > > > * guest resource mapping

Re: [Xen-devel] Xen 4.12 Development Update

2018-09-12 Thread Jan Beulich
>>> On 12.09.18 at 08:54, wrote: > === x86 === > > * guest resource mapping (v18) > - Paul Durrant That's all gone in by now? Paul? > * hypervisor x86 instruction emulator additions (v4) > - Jan Beulich Where's this "v4" coming from? The presently relevant series is at v2 right now,

Re: [Xen-devel] [PATCH v6 13/14] x86: add iommu_ops to modify and flush IOMMU mappings

2018-09-12 Thread Jan Beulich
>>> On 12.09.18 at 10:02, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 12 September 2018 08:04 >> >> >>> On 23.08.18 at 11:47, wrote: >> > +static int iommuop_map(struct xen_iommu_op_map *op) >> > +{ >> > +struct domain *d, *currd = current->domain; >> > +struct

Re: [Xen-devel] [PATCH v2 3/4] x86/HVM: implement memory read caching

2018-09-12 Thread Jan Beulich
>>> On 11.09.18 at 18:20, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 11 September 2018 14:15 >> >> @@ -2664,9 +2685,35 @@ void hvm_dump_emulation_state(const char >> hvmemul_ctxt->insn_buf); >> } >> >> +struct hvmemul_cache *hvmemul_cache_init(unsigned int

[Xen-devel] [PATCH] x86/HVM: correct hvmemul_map_linear_addr() for multi-page case

2018-09-12 Thread Jan Beulich
The function does two translations in one go for a single guest access. Any failure of the first translation step (guest linear -> guest physical), resulting in #PF, ought to take precedence over any failure of the second step (guest physical -> host physical). Bail out of the loop early solely

Re: [Xen-devel] [PATCH] drivers/block/xen-blkback/common.h: use DIV_ROUND_UP instead of reimplementing its function

2018-09-12 Thread Roger Pau Monné
Adding Julien how did the work to support XEN_PAGE_SIZE != PAGE_SIZE. On Wed, Sep 12, 2018 at 02:14:26AM -0600, Jan Beulich wrote: > >>> On 12.09.18 at 07:45, wrote: > > --- a/drivers/block/xen-blkback/common.h > > +++ b/drivers/block/xen-blkback/common.h > > @@ -65,7 +65,7 @@ > >

Re: [Xen-devel] [PATCH] drivers/block/xen-blkback/common.h: use DIV_ROUND_UP instead of reimplementing its function

2018-09-12 Thread Jan Beulich
>>> On 12.09.18 at 07:45, wrote: > --- a/drivers/block/xen-blkback/common.h > +++ b/drivers/block/xen-blkback/common.h > @@ -65,7 +65,7 @@ > (XEN_PAGES_PER_INDIRECT_FRAME / XEN_PAGES_PER_SEGMENT) > > #define MAX_INDIRECT_PAGES \ > - ((MAX_INDIRECT_SEGMENTS + SEGS_PER_INDIRECT_FRAME -

Re: [Xen-devel] [PATCH v3 2/3] x86/viridan: Clean up Viridian MSR infrastructure

2018-09-12 Thread Sergey Dyasli
On Tue, 2018-09-11 at 19:56 +0100, Andrew Cooper wrote: > Rename the functions to guest_{rd,wr}msr_viridian() for consistency, and > because the _regs() suffix isn't very appropriate. > > Update them to take a vcpu pointer rather than presuming that they act on > current, which is safe for all

Re: [Xen-devel] [PATCH v8 1/6] iommu: rename iommu_dom0_strict and iommu_passthrough

2018-09-12 Thread Roger Pau Monné
On Fri, Sep 07, 2018 at 11:07:34AM +0200, Roger Pau Monne wrote: > To iommu_hwdom_strict and iommu_hwdom_passthrough which is more > descriptive of their usage. Also change their type from bool_t to > bool. > > No functional change. > > Signed-off-by: Roger Pau Monné > Reviewed-by: Jan Beulich

Re: [Xen-devel] [PATCH v2 3/4] x86/HVM: implement memory read caching

2018-09-12 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 12 September 2018 09:38 > To: Paul Durrant > Cc: Andrew Cooper ; George Dunlap > ; Wei Liu ; xen-devel > > Subject: RE: [PATCH v2 3/4] x86/HVM: implement memory read caching > > >>> On 11.09.18 at 18:20, wrote:

Re: [Xen-devel] [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops

2018-09-12 Thread Paul Durrant
> -Original Message- > From: Paul Durrant > Sent: 12 September 2018 09:52 > To: Paul Durrant ; 'Jan Beulich' > > Cc: xen-devel ; Kevin Tian > ; George Dunlap > Subject: RE: [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops > > > -Original Message- > > From: Xen-devel

Re: [Xen-devel] [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops

2018-09-12 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 12 September 2018 10:03 > To: Paul Durrant > Cc: George Dunlap ; Kevin Tian > ; xen-devel > Subject: RE: [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops > > >>> On 12.09.18 at 10:53, wrote: > >> From:

Re: [Xen-devel] [PATCH v3 3/3] x86: Clean up the Xen MSR infrastructure

2018-09-12 Thread Andrew Cooper
On 12/09/18 09:29, Sergey Dyasli wrote: > On Tue, 2018-09-11 at 19:56 +0100, Andrew Cooper wrote: >> Rename them to guest_{rd,wr}msr_xen() for consistency, and because the _regs >> suffix isn't very appropriate. >> >> Update them to take a vcpu pointer rather than presuming that they act on >>

Re: [Xen-devel] [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops

2018-09-12 Thread Jan Beulich
>>> On 12.09.18 at 11:05, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 12 September 2018 10:03 >> >> A HVM guest using the PV IOMMU is quite fine, but it shouldn't talk to >> it in terms of MFNs. >> > > Well, it has to talk MFNs at some level, surely? The output of the IOMMU

Re: [Xen-devel] [PATCH] xen-netback: remove unecessary condition check before debugfs_remove_recursive

2018-09-12 Thread David Miller
From: zhong jiang Date: Sat, 8 Sep 2018 21:53:42 +0800 > debugfs_remove_recursive has taken IS_ERR_OR_NULL into account. So just > remove the condition check before debugfs_remove_recursive. > > Signed-off-by: zhong jiang Applied to net-next. ___

Re: [Xen-devel] [PATCH v6 10/14] mm / iommu: split need_iommu() into has_iommu_pt() and need_iommu_pt_sync()

2018-09-12 Thread Jan Beulich
>>> On 11.09.18 at 17:40, wrote: >> From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf >> Of Jan Beulich >> Sent: 11 September 2018 15:31 >> >> >>> On 23.08.18 at 11:47, wrote: >> > --- a/xen/arch/x86/x86_64/mm.c >> > +++ b/xen/arch/x86/x86_64/mm.c >> > @@ -1426,7 +1426,8

Re: [Xen-devel] [RFC PATCH 1/2] xen/arm: Add Amlogic S905 SoC early printk support

2018-09-12 Thread Amit Tomer
Hello, > I am trying to understand why Linux is doing it. Do you expect all > U-Boot version to do it? It's because Linux doesn't really trust u-boot and initializes every thing again ? Mainline U-boot does it but that may also not required since ATF does it for us. Thanks -Amit

Re: [Xen-devel] [PATCH v6 10/14] mm / iommu: split need_iommu() into has_iommu_pt() and need_iommu_pt_sync()

2018-09-12 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 12 September 2018 07:45 > To: Paul Durrant > Cc: Brian Woods ; Suravee Suthikulpanit > ; Julien Grall ; > Razvan Cojocaru ; Andrew Cooper > ; George Dunlap > ; Ian Jackson ; Wei Liu > ; Jun Nakajima ; Kevin Tian >

Re: [Xen-devel] [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops

2018-09-12 Thread Jan Beulich
>>> On 12.09.18 at 10:45, wrote: >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 12 September 2018 09:44 >> To: Paul Durrant >> Cc: George Dunlap ; Kevin Tian >> ; xen-devel >> Subject: RE: [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops >> >>

Re: [Xen-devel] [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops

2018-09-12 Thread Jan Beulich
>>> On 12.09.18 at 10:53, wrote: >> From: Paul Durrant >> Sent: 12 September 2018 09:52 >> >> > From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On >> Behalf >> > Of Paul Durrant >> > Sent: 12 September 2018 09:45 >> > >> > > From: Jan Beulich [mailto:jbeul...@suse.com] >> > >

Re: [Xen-devel] [PATCH v3] xen:arm: Populate arm64 image header

2018-09-12 Thread Andre Przywara
Hi, On 11/09/2018 17:48, Amit Singh Tomar wrote: > This patch adds image size and flags to XEN image header. It uses > those fields according to the updated Linux kernel image definition. > > With this patch bootloader can now place XEN image anywhere in system > RAM at 2MB aligned address

Re: [Xen-devel] [PATCH v6 12/14] memory: add get_paged_gfn() as a wrapper...

2018-09-12 Thread Jan Beulich
>>> On 12.09.18 at 11:10, wrote: >> From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf >> Of Jan Beulich >> Sent: 11 September 2018 15:56 >> >> >>> On 23.08.18 at 11:47, wrote: >> > ...for some uses of get_page_from_gfn(). >> > >> > There are many occurences of the

Re: [Xen-devel] [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops

2018-09-12 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 12 September 2018 10:13 > To: Paul Durrant > Cc: George Dunlap ; Kevin Tian > ; xen-devel > Subject: RE: [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops > > >>> On 12.09.18 at 11:05, wrote: > >> From:

Re: [Xen-devel] [PATCH v6 11/14] x86: add iommu_op to enable modification of IOMMU mappings

2018-09-12 Thread Jan Beulich
>>> On 11.09.18 at 17:52, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 11 September 2018 15:48 >> >> >>> On 23.08.18 at 11:47, wrote: >> > This patch adds an iommu_op which checks whether it is possible or >> > safe for a domain to modify its own IOMMU mappings and, if so,

[Xen-devel] Xen 4.12 Development Update

2018-09-12 Thread Juergen Gross
This email only tracks big items for xen.git tree. Please reply for items you would like to see in 4.12 so that people have an idea what is going on and prioritise accordingly. You're welcome to provide description and use cases of the feature you're working on. = Timeline = We now adopt a

Re: [Xen-devel] [PATCH 1/5] xentrace_format: print timestamps in nanoseconds

2018-09-12 Thread Dario Faggioli
On Tue, 2018-09-11 at 16:54 +0100, George Dunlap wrote: > On 09/11/2018 04:19 PM, Andrii Anisov wrote: > > > > On 11.09.18 13:44, George Dunlap wrote: > > > What I do in xenalyze is to have the timestamps in seconds, but > > > always > > > print down to the nanosecond. (For this I actually break

[Xen-devel] [ovmf test] 127522: all pass - PUSHED

2018-09-12 Thread osstest service owner
flight 127522 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/127522/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 5c9ac43f47865bb9b13608fd7ae1d39ab73ef397 baseline version: ovmf

Re: [Xen-devel] [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops

2018-09-12 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 07 September 2018 12:11 > To: Paul Durrant > Cc: George Dunlap ; Kevin Tian > ; xen-devel > Subject: Re: [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops > > >>> On 23.08.18 at 11:47, wrote: > > This

Re: [Xen-devel] [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops

2018-09-12 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 12 September 2018 09:44 > To: Paul Durrant > Cc: George Dunlap ; Kevin Tian > ; xen-devel > Subject: RE: [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops > > >>> On 12.09.18 at 10:31, wrote: > >> From:

Re: [Xen-devel] [RFC PATCH 1/2] xen/arm: Add Amlogic S905 SoC early printk support

2018-09-12 Thread Julien Grall
On 09/12/2018 07:43 AM, Amit Tomer wrote: Hello, I am trying to understand why Linux is doing it. Do you expect all U-Boot version to do it? It's because Linux doesn't really trust u-boot and initializes every thing again ? You don't know the state of the UART once you left U-boot. For

Re: [Xen-devel] [PATCH v6 12/14] memory: add get_paged_gfn() as a wrapper...

2018-09-12 Thread Paul Durrant
> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf > Of Jan Beulich > Sent: 11 September 2018 15:56 > To: Paul Durrant > Cc: Stefano Stabellini ; Wei Liu > ; Konrad Rzeszutek Wilk ; > George Dunlap ; Andrew Cooper > ; Ian Jackson ; Tim >

Re: [Xen-devel] [PATCH v2 1/1] cameraif: add ABI for para-virtual camera

2018-09-12 Thread Hans Verkuil
On 09/11/18 10:29, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > This is the ABI for the two halves of a para-virtualized > camera driver which extends Xen's reach multimedia capabilities even > farther enabling it for video conferencing, In-Vehicle Infotainment, > high

Re: [Xen-devel] BUG: sched=credit2 crashes system when using cpupools

2018-09-12 Thread Steven Haigh
On Thursday, 13 September 2018 1:11:20 AM AEST Dario Faggioli wrote: > On Thu, 2018-08-30 at 18:49 +1000, Steven Haigh wrote: > > On 2018-08-30 18:33, Jan Beulich wrote: > > > Anyway - as Jürgen says, something for the scheduler > > > maintainers to look into. > > Ok, I'm back. > > > Yep - I

[Xen-devel] [xen-unstable-smoke test] 127542: tolerable all pass - PUSHED

2018-09-12 Thread osstest service owner
flight 127542 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/127542/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

[Xen-devel] [PATCH v4 1/2] Created tools/shared directory containing MD5 files

2018-09-12 Thread Joshua Perrett
MD5 code is originally from the public domain (written by Colin Plumb in 1993), files taken from xen/tools/blktap2/drivers/. They have been modified slightly (useful functions made public). Signed-off-by: Joshua perrett --- tools/Makefile| 1 + tools/Rules.mk| 1 +

[Xen-devel] [PATCH v4 2/2] libxl: made vm mac address assignment deterministic

2018-09-12 Thread Joshua Perrett
Uses MD5 on a host mac address, the vm name and vif index to generate the last three bytes of the vm mac address (for each vm). It uses the vif index to account for multiple vifs. Reported-by: George Dunlap Signed-off-by: Joshua Perrett --- tools/libxl/Makefile | 2 +-

[Xen-devel] [PATCH] x86/xen: disable cpu0 hotplug for xen pv

2018-09-12 Thread Juergen Gross
Xen pv guests don't allow cpu0 hotplug, so disable it. Signed-off-by: Juergen Gross --- arch/x86/kernel/topology.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/x86/kernel/topology.c b/arch/x86/kernel/topology.c index 12cbe2b88c0f..738bf42b0218 100644 ---

Re: [Xen-devel] [PATCH v2] xen/vcpu: Rework sanity checks in vcpu_create()

2018-09-12 Thread Jan Beulich
>>> On 11.09.18 at 18:46, wrote: > Poisoning idle_vcpu[0] with the sanity debug value isn't actually a clever > idea, because it passes a NULL pointer check but isn't a usable vcpu. It is > also the reason for the (!is_idle_domain(d) || vcpu_id) part of the existing > sanity BUG_ON(). But you

Re: [Xen-devel] BUG: sched=credit2 crashes system when using cpupools

2018-09-12 Thread Dario Faggioli
On Thu, 2018-08-30 at 18:49 +1000, Steven Haigh wrote: > On 2018-08-30 18:33, Jan Beulich wrote: > > > > > > > Anyway - as Jürgen says, something for the scheduler > > maintainers to look into. > Ok, I'm back. > Yep - I just want to confirm that we tested this in BOTH NUMA > configurations -

Re: [Xen-devel] [PATCH 1/5] xentrace_format: print timestamps in nanoseconds

2018-09-12 Thread Andrii Anisov
Hello George, On 11.09.18 18:54, George Dunlap wrote: FYI, I never use xentrace_format; as far as I'm concerned it's been made obsolete by xenalyze, and if it were up to me I'd remove it from the tree. Lots of people seem to find it useful, so I review patches. But I really care very little

Re: [Xen-devel] [PATCH v6 14/14] x86: extend the map and unmap iommu_ops to support grant references

2018-09-12 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 12 September 2018 15:13 > To: Paul Durrant > Cc: Julien Grall ; Andrew Cooper > ; Wei Liu ; George > Dunlap ; Ian Jackson ; > Stefano Stabellini ; xen-devel de...@lists.xenproject.org>; Konrad Rzeszutek Wilk > ;

Re: [Xen-devel] [PATCH v2] Change a time printout representation for keyhandlers

2018-09-12 Thread Andrii Anisov
On 12.09.18 19:47, Dario Faggioli wrote: Right. But am I missing something, or you forgot dump_domains() in xen/common/keyhandler.c ? You are OK. I've missed it :( -- *Andrii Anisov* ___ Xen-devel mailing list Xen-devel@lists.xenproject.org

Re: [Xen-devel] [PATCH 5/5] formats: print time values as decimals

2018-09-12 Thread Andrii Anisov
On 12.09.18 10:54, Dario Faggioli wrote: Reviewed-by: Dario Faggioli Thank you. Andrii, if you decide to make the patch that turns timestamps into secs.nsecs, can we also convert these to such format (again, in case we have MHz)? I plan to do the patch. I'll keep this mind. Or, in

Re: [Xen-devel] [PATCH v2] schedule: move last_run_time to the credit scheduler privates

2018-09-12 Thread Dario Faggioli
On Wed, 2018-09-12 at 17:47 +0300, Andrii Anisov wrote: > From: Andrii Anisov > > The structure member last_run_time is used by credit scheduler only. > So move it from a generic vcpu sctructure to the credit scheduler > private > vcpu definition. > > Signed-off-by: Andrii Anisov > --- >

Re: [Xen-devel] [PATCH 5/5] formats: print time values as decimals

2018-09-12 Thread Dario Faggioli
On Wed, 2018-09-12 at 20:28 +0300, Andrii Anisov wrote: > On 12.09.18 10:54, Dario Faggioli wrote: > > > > Or, in general, what I think would be useful, is to have the > > timestamps > > and the scheduling parameters in the same domain (when possible). > > As I understand, now we do have among

[Xen-devel] [PATCH v4 0/2] libxl: deterministic mac addresses

2018-09-12 Thread Joshua Perrett
The patch has now been split into two parts. One adds the MD5 files to a shared directory in tools, so that it can potentially be reused. The second patch makes mac addresses deterministic. It still uses a host mac address, seeing as gethostid() won't work (as George explained). The code should

Re: [Xen-devel] [PATCH 1/5] xentrace_format: print timestamps in nanoseconds

2018-09-12 Thread Andrii Anisov
Hello Dario, On 12.09.18 10:42, Dario Faggioli wrote: Sorry, I'm not sure I'm getting this properly. When you say "with the current formula", do you mean before or after this series? I did mean the formula existing before this series. IAC, changing the default format file that we ship so

Re: [Xen-devel] [PATCH v2] xen/domain: Remove trailing whitespace

2018-09-12 Thread Andrii Anisov
Hello Andrew, On 11.09.18 18:38, Andrew Cooper wrote: Acked-by: Andrew Cooper Thank you. -- *Andrii Anisov* ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] RFE: Detect NUMA misconfigurations and prevent machine freezes

2018-09-12 Thread Dario Faggioli
On Thu, 2018-08-30 at 14:01 +1000, Steven Haigh wrote: > On 2018-08-29 15:49, Juergen Gross wrote: > > > > RAM placement should not matter here. As the name already suggests > > cpupools do assignment of cpus. RAM allocated will be preferred > > taken > > from a local node, but this shouldn't be

[Xen-devel] [PATCH v2] Change a time printout representation for keyhandlers

2018-09-12 Thread Andrii Anisov
From: Andrii Anisov For different keyhandlers, replace a hex with delimiter representation of time to PRI_stime which is decimal ns currently. Signed-off-by: Andrii Anisov --- Changes in v2: - Time representation change propagated to all keyhandlers as agreed here [1] - Title and

Re: [Xen-devel] [PATCH v2] Change a time printout representation for keyhandlers

2018-09-12 Thread Dario Faggioli
On Wed, 2018-09-12 at 18:58 +0300, Andrii Anisov wrote: > From: Andrii Anisov > > For different keyhandlers, replace a hex with delimiter > representation > of time to PRI_stime which is decimal ns currently. > > Signed-off-by: Andrii Anisov > --- > > Changes in v2: > - Time

[Xen-devel] [linux-linus bisection] complete test-amd64-i386-xl

2018-09-12 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-i386-xl testid guest-start Tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git

[Xen-devel] [PATCH v3] Change timestamps representation for keyhandlers

2018-09-12 Thread Andrii Anisov
From: Andrii Anisov For different keyhandlers, replace a hex with delimiter representation of time to PRI_stime which is decimal ns currently. Signed-off-by: Andrii Anisov --- Changes in v3: - patch a missed dump_domains() keyhandler Changes in v2: - Time representation change

[Xen-devel] PXE boot with e1000 using OVMF

2018-09-12 Thread Tamas K Lengyel
HI all, I'm experimenting with OVMF and I checked to see if OVMF can do PXE boot out-of-the box with a e1000 emulated network interface and was surprised to find that it does not. After reading some of the prior discussions on the topic (https://lists.gt.net/xen/devel/382432 and

[Xen-devel] [linux-next test] 127531: regressions - FAIL

2018-09-12 Thread osstest service owner
flight 127531 linux-next real [real] http://logs.test-lab.xenproject.org/osstest/logs/127531/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-boot fail REGR. vs. 127516

Re: [Xen-devel] [PATCH v2] schedule: move last_run_time to the credit scheduler privates

2018-09-12 Thread Andrii Anisov
On 12.09.18 20:27, Dario Faggioli wrote: On Wed, 2018-09-12 at 17:47 +0300, Andrii Anisov wrote: From: Andrii Anisov The structure member last_run_time is used by credit scheduler only. So move it from a generic vcpu sctructure to the credit scheduler private vcpu definition. Signed-off-by:

[Xen-devel] [ovmf baseline-only test] 75207: trouble: blocked/broken

2018-09-12 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 75207 ovmf real [real] http://osstest.xensource.com/osstest/logs/75207/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm

[Xen-devel] [linux-linus test] 127535: regressions - FAIL

2018-09-12 Thread osstest service owner
flight 127535 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/127535/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 10 debian-hvm-install fail REGR. vs. 125898

[Xen-devel] null scheduler bug

2018-09-12 Thread Stefano Stabellini
Hi Dario, Milan has just found a bug in the null scheduler: apparently it is not possible to start a VM again after it has been destroyed. My initial suspicion was that the VM wasn't properly destroyed, but I asked Milan to double check with xl list, and the VM doesn't show in the list anymore.

[Xen-devel] [xen-unstable test] 127541: tolerable FAIL - PUSHED

2018-09-12 Thread osstest service owner
flight 127541 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/127541/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-xtf-amd64-amd64-4 104 leak-check/check fail in 127520 pass in 127541 test-amd64-i386-rumprun-i386 17

[Xen-devel] [ovmf test] 127554: all pass - PUSHED

2018-09-12 Thread osstest service owner
flight 127554 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/127554/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 7c41b8135de692ea45334747b73936ea6804622f baseline version: ovmf

Re: [Xen-devel] [PATCH] xen: fix GCC warning and remove duplicate EVTCHN_ROW/EVTCHN_COL usage

2018-09-12 Thread Juergen Gross
On 13/09/18 03:13, Josh Abraham wrote: > This patch removes duplicate macro useage in events_base.c. > > It also fixes gcc warning: > variable ‘col’ set but not used [-Wunused-but-set-variable] > > Signed-off-by: Joshua Abraham Reviewed-by: Juergen Gross Juergen

Re: [Xen-devel] [PATCH] pass-through: adjust pIRQ migration

2018-09-12 Thread Tian, Kevin
> From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Monday, September 10, 2018 9:59 PM > > For one it is quite pointless to iterate over all pIRQ-s the domain has > when just one is being adjusted. Introduce hvm_migrate_pirq(). it's migrate_pirq being introduced here. > > Additionally it is

[Xen-devel] [PATCH] xen: fix GCC warning and remove duplicate EVTCHN_ROW/EVTCHN_COL usage

2018-09-12 Thread Josh Abraham
This patch removes duplicate macro useage in events_base.c. It also fixes gcc warning: variable ‘col’ set but not used [-Wunused-but-set-variable] Signed-off-by: Joshua Abraham --- drivers/xen/events/events_base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Xen-devel] [PATCH v2 1/1] cameraif: add ABI for para-virtual camera

2018-09-12 Thread Oleksandr Andrushchenko
On 09/12/2018 05:38 PM, Hans Verkuil wrote: On 09/12/18 16:15, Oleksandr Andrushchenko wrote: On 09/12/2018 04:38 PM, Hans Verkuil wrote: On 09/12/18 15:02, Oleksandr Andrushchenko wrote: On 09/12/2018 03:25 PM, Hans Verkuil wrote: + * formats + * Values: + * + * Formats

Re: [Xen-devel] [PATCH 3/5] xentrace_format: combine 64-bit LE values from traces

2018-09-12 Thread Dario Faggioli
On Tue, 2018-09-11 at 15:23 +0300, Andrii Anisov wrote: > Hello George, > > > On 11.09.18 13:48, George Dunlap wrote: > > I like the idea; but what does 'LE' mean in this context? > > Little endian. Most significant 32bit word is at a higher index in > the > array. > I did get it, but it took

Re: [Xen-devel] [PATCH v2 2/4] x86/mm: use optional cache in guest_walk_tables()

2018-09-12 Thread Jan Beulich
>>> On 11.09.18 at 18:17, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 11 September 2018 14:15 >> >> --- a/xen/arch/x86/mm/guest_walk.c >> +++ b/xen/arch/x86/mm/guest_walk.c >> @@ -92,8 +92,13 @@ guest_walk_tables(struct vcpu *v, struct >> #if GUEST_PAGING_LEVELS >= 4 /*

Re: [Xen-devel] [PATCH v3 3/3] x86: Clean up the Xen MSR infrastructure

2018-09-12 Thread Sergey Dyasli
On Tue, 2018-09-11 at 19:56 +0100, Andrew Cooper wrote: > Rename them to guest_{rd,wr}msr_xen() for consistency, and because the _regs > suffix isn't very appropriate. > > Update them to take a vcpu pointer rather than presuming that they act on > current, and switch to using X86EMUL_* return

Re: [Xen-devel] Xen 4.12 Development Update

2018-09-12 Thread Juergen Gross
On 12/09/18 10:20, Jan Beulich wrote: On 12.09.18 at 08:54, wrote: >> === x86 === >> >> * guest resource mapping (v18) >> - Paul Durrant > > That's all gone in by now? Paul? > >> * hypervisor x86 instruction emulator additions (v4) >> - Jan Beulich > > Where's this "v4" coming

Re: [Xen-devel] Xen 4.12 Development Update

2018-09-12 Thread Jan Beulich
>>> On 12.09.18 at 10:30, wrote: > On 12/09/18 10:20, Jan Beulich wrote: > On 12.09.18 at 08:54, wrote: >>> === x86 === >>> >>> * guest resource mapping (v18) >>> - Paul Durrant >> >> That's all gone in by now? Paul? >> >>> * hypervisor x86 instruction emulator additions (v4) >>> -

Re: [Xen-devel] [PATCH v7 1/6] iommu: introduce the concept of DFN...

2018-09-12 Thread Andrew Cooper
On 12/09/18 12:30, Paul Durrant wrote: > diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h > index e35d941f3c..19d5d55d79 100644 > --- a/xen/include/xen/iommu.h > +++ b/xen/include/xen/iommu.h > @@ -23,11 +23,37 @@ > #include > #include > #include > +#include > #include >

Re: [Xen-devel] v4.19-rc3, wrong pageflags in dom0

2018-09-12 Thread Juergen Gross
On 10/09/18 17:03, Olaf Hering wrote: > Am Mon, 10 Sep 2018 14:49:07 +0200 > schrieb Olaf Hering : > >> After reboot I tried to start my HVM domU, this is what I get in dom0: >> [ 223.019451] page:ea007bed9040 count:1 mapcount:-1 >> mapping: index:0x0 > > this also happens

Re: [Xen-devel] [PATCH v8 1/6] iommu: rename iommu_dom0_strict and iommu_passthrough

2018-09-12 Thread Suravee Suthikulpanit
Roger, On 9/7/18 4:07 PM, Roger Pau Monne wrote: To iommu_hwdom_strict and iommu_hwdom_passthrough which is more descriptive of their usage. Also change their type from bool_t to bool. No functional change. Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich Reviewed-by: Kevin Tian

Re: [Xen-devel] [PATCH v8 3/6] iommu: make iommu_inclusive_mapping a suboption of dom0-iommu

2018-09-12 Thread Suravee Suthikulpanit
On 9/7/18 4:07 PM, Roger Pau Monne wrote: Introduce a new dom0-iommu=map-inclusive generic option that supersedes iommu_inclusive_mapping. The previous behavior is preserved and the option should only be enabled by default on Intel hardware. Signed-off-by: Roger Pau Monné Reviewed-by: Paul

Re: [Xen-devel] [PATCH v8 6/6] x86/iommu: add map-reserved dom0-iommu option to map reserved memory ranges

2018-09-12 Thread Suravee Suthikulpanit
On 9/7/18 4:07 PM, Roger Pau Monne wrote: Several people have reported hardware issues (malfunctioning USB controllers) due to iommu page faults on Intel hardware. Those faults are caused by missing RMRR (VTd) entries in the ACPI tables. Those can be worked around on VTd hardware by manually

Re: [Xen-devel] [PATCH v3 3/3] x86: Clean up the Xen MSR infrastructure

2018-09-12 Thread Andrew Cooper
On 12/09/18 11:05, Jan Beulich wrote: On 12.09.18 at 11:24, wrote: >> On 12/09/18 10:17, Jan Beulich wrote: >> On 12.09.18 at 11:12, wrote: On 12/09/18 09:29, Sergey Dyasli wrote: > On Tue, 2018-09-11 at 19:56 +0100, Andrew Cooper wrote: >> @@ -822,13 +818,13 @@ int

Re: [Xen-devel] [PATCH] x86/HVM: correct hvmemul_map_linear_addr() for multi-page case

2018-09-12 Thread Jan Beulich
>>> On 12.09.18 at 13:51, wrote: >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 12 September 2018 10:10 >> To: xen-devel >> Cc: Andrew Cooper ; Paul Durrant >> >> Subject: [PATCH] x86/HVM: correct hvmemul_map_linear_addr() for multi- >> page case >> >>

[Xen-devel] [PATCH v7 2/6] iommu: make use of type-safe DFN and MFN in exported functions

2018-09-12 Thread Paul Durrant
This patch modifies the declaration of the entry points to the IOMMU sub-system to use dfn_t and mfn_t in place of unsigned long. A subsequent patch will similarly modify the methods in the iommu_ops structure. Signed-off-by: Paul Durrant Reviewed-by: Wei Liu Reviewed-by: Kevin Tian Acked-by:

[Xen-devel] [PATCH v7 3/6] iommu: push use of type-safe DFN and MFN into iommu_ops

2018-09-12 Thread Paul Durrant
This patch modifies the methods in struct iommu_ops to use type-safe DFN and MFN. This follows on from the prior patch that modified the functions exported in xen/iommu.h. Signed-off-by: Paul Durrant Reviewed-by: Wei Liu Reviewed-by: Kevin Tian Acked-by: Jan Beulich --- Cc: Suravee

[Xen-devel] [PATCH v7 1/6] iommu: introduce the concept of DFN...

2018-09-12 Thread Paul Durrant
...meaning 'device DMA frame number' i.e. a frame number mapped in the IOMMU (rather than the MMU) and hence used for DMA address translation. This patch is a largely cosmetic change that substitutes the terms 'gfn' and 'gaddr' for 'dfn' and 'daddr' in all the places where the frame number or

[Xen-devel] [PATCH v7 5/6] memory: add check_get_page_from_gfn() as a wrapper...

2018-09-12 Thread Paul Durrant
...for some uses of get_page_from_gfn(). There are many occurences of the following pattern in the code: q = ? P2M_ALLOC : P2M_UNSHARE; page = get_page_from_gfn(d, gfn, , q); if ( p2m_is_paging(p2mt) ) { if ( page ) put_page(page);

[Xen-devel] [PATCH v7 0/6] paravirtual IOMMU pre-requisites and clean-up

2018-09-12 Thread Paul Durrant
This series contains pre-requisites and clean-up needed for paravirtual IOMMU support. I have separated these patches to avoid further delaying their application whilst I re-work the implementation of paravirtual IOMMU after review of v6 of the series. Several of them already have all necessary

[Xen-devel] [PATCH v7 6/6] vtd: add lookup_page method to iommu_ops

2018-09-12 Thread Paul Durrant
This patch adds a new method to the VT-d IOMMU implementation to find the MFN currently mapped by the specified DFN along with a wrapper function in generic IOMMU code to call the implementation if it exists. This patch also cleans up the initializers in intel_iommu_map_page() and uses

[Xen-devel] [PATCH v7 4/6] iommu: don't domain_crash() inside iommu_map/unmap_page()

2018-09-12 Thread Paul Durrant
This patch removes the implicit domain_crash() from iommu_map(), unmap_page() and iommu_iotlb_flush() and turns them into straightforward wrappers that check the existence of the relevant iommu_op and call through to it. This makes them usable by PV IOMMU code to be delivered in future patches.

Re: [Xen-devel] [PATCH v2] xen/vcpu: Rework sanity checks in vcpu_create()

2018-09-12 Thread Jason Andryuk
On Tue, Sep 11, 2018 at 12:48 PM Andrew Cooper wrote: > > Poisoning idle_vcpu[0] with the sanity debug value isn't actually a clever > idea, because it passes a NULL pointer check but isn't a usable vcpu. It is > also the reason for the (!is_idle_domain(d) || vcpu_id) part of the existing >

[Xen-devel] [distros-debian-squeeze test] 75204: trouble: blocked/broken

2018-09-12 Thread Platform Team regression test user
flight 75204 distros-debian-squeeze real [real] http://osstest.xensource.com/osstest/logs/75204/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-pvopsbroken build-i386

Re: [Xen-devel] [PATCH] x86/HVM: correct hvmemul_map_linear_addr() for multi-page case

2018-09-12 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 12 September 2018 10:10 > To: xen-devel > Cc: Andrew Cooper ; Paul Durrant > > Subject: [PATCH] x86/HVM: correct hvmemul_map_linear_addr() for multi- > page case > > The function does two translations in one go

[Xen-devel] [PATCH v4 1/3] x86/msr: Dispatch Xen and Viridian MSRs from guest_{wr, rd}msr()

2018-09-12 Thread Andrew Cooper
Despite the complicated diff in {svm,vmx}_msr_write_intercept(), it is just the 0 case losing one level of indentation, as part of removing the call to wrmsr_hypervisor_regs(). The case blocks in guest_{wr,rd}msr() use raw numbers, partly for consistency with the CPUID side of things, but mainly

Re: [Xen-devel] [PATCH v7 1/6] iommu: introduce the concept of DFN...

2018-09-12 Thread Paul Durrant
> -Original Message- > From: Andrew Cooper > Sent: 12 September 2018 12:49 > To: Paul Durrant ; xen-devel@lists.xenproject.org > Cc: Kevin Tian ; Stefano Stabellini > ; Wei Liu ; Suravee > Suthikulpanit ; Julien Grall > ; Jan Beulich > Subject: Re: [Xen-devel] [PATCH v7 1/6] iommu:

Re: [Xen-devel] [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops

2018-09-12 Thread Jan Beulich
>>> On 12.09.18 at 12:09, wrote: >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 12 September 2018 11:08 >> To: Paul Durrant >> Cc: George Dunlap ; Kevin Tian >> ; xen-devel >> Subject: RE: [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops >> >>

Re: [Xen-devel] [PATCH v7 1/6] iommu: introduce the concept of DFN...

2018-09-12 Thread Roger Pau Monné
On Wed, Sep 12, 2018 at 12:30:23PM +0100, Paul Durrant wrote: > diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h > index e35d941f3c..19d5d55d79 100644 > --- a/xen/include/xen/iommu.h > +++ b/xen/include/xen/iommu.h > @@ -23,11 +23,37 @@ > #include > #include > #include >

  1   2   >