Re: [Xen-devel] [PATCH 0/4] automation: QEMU-based smoke test

2018-11-19 Thread Wei Liu
On Mon, Nov 19, 2018 at 09:30:58PM +, Wei Liu wrote: > See https://gitlab.com/xen-project/people/liuw/xen/pipelines/37173009 > > A pipeline while I was developing this series. A (still in progress as of now) full pipeline https://gitlab.com/xen-project/people/liuw/xen/pipelines/37175006

[Xen-devel] [xen-4.7-testing test] 130495: trouble: blocked/broken/fail/pass

2018-11-19 Thread osstest service owner
flight 130495 xen-4.7-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/130495/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64 broken build-arm64-xsm

[Xen-devel] [PATCH 0/4] automation: QEMU-based smoke test

2018-11-19 Thread Wei Liu
See https://gitlab.com/xen-project/people/liuw/xen/pipelines/37173009 A pipeline while I was developing this series. Wei Liu (4): automation: introduce CONTAINER_NO_PULL for containerize automation: stash default config file for artifact extraction automation: also specify xen binary as

[Xen-devel] [PATCH 3/4] automation: also specify xen binary as artifact on x86_64

2018-11-19 Thread Wei Liu
... so that it can be passed on to test stage. Note that xen is only extracted for x86_64 build since others may not have that. Use a directory to account for possibly different file names on Arm. Signed-off-by: Wei Liu --- .gitlab-ci.yml | 1 + automation/scripts/build | 4 2

[Xen-devel] [PATCH 4/4] automation: add qemu smoke test

2018-11-19 Thread Wei Liu
This patch introduces a new test stage into the pipeline and provides a simple QEMU based smoke test. Signed-off-by: Wei Liu --- .gitlab-ci.yml | 19 +++ automation/scripts/qemu-smoke-x86-64.sh | 23 +++ 2 files changed, 42

[Xen-devel] [PATCH 2/4] automation: stash default config file for artifact extraction

2018-11-19 Thread Wei Liu
Signed-off-by: Wei Liu --- .gitlab-ci.yml | 2 +- automation/scripts/build | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 5678b552c4..28152e906d 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -8,7 +8,7 @@ stages: -

[Xen-devel] [PATCH 1/4] automation: introduce CONTAINER_NO_PULL for containerize

2018-11-19 Thread Wei Liu
Signed-off-by: Wei Liu --- automation/build/README.md | 3 +++ automation/scripts/containerize | 8 +--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/automation/build/README.md b/automation/build/README.md index f6cfd46f1e..d8c8a18e33 100644 ---

[Xen-devel] [xen-unstable-smoke test] 130552: trouble: blocked/broken/pass

2018-11-19 Thread osstest service owner
flight 130552 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/130552/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm broken

[Xen-devel] [linux-next test] 130493: regressions - trouble: blocked/broken/fail/pass

2018-11-19 Thread osstest service owner
flight 130493 linux-next real [real] http://logs.test-lab.xenproject.org/osstest/logs/130493/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64 broken build-arm64-xsm

[Xen-devel] [xtf test] 130526: tolerable all pass - PUSHED

2018-11-19 Thread osstest service owner
flight 130526 xtf real [real] http://logs.test-lab.xenproject.org/osstest/logs/130526/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-xtf-amd64-amd64-4 69 xtf/test-hvm64-xsa-278 fail never pass test-xtf-amd64-amd64-2 69

[Xen-devel] [PATCH 2/2] x86/acpi, x86/boot: Take RSDP address from boot params if available

2018-11-19 Thread Juergen Gross
In case the RSDP address in struct boot_params is specified don't try to find the table by searching, but take the address directly as set by the boot loader. Signed-off-by: Juergen Gross --- arch/x86/include/uapi/asm/bootparam.h | 3 ++- arch/x86/kernel/acpi/boot.c | 2 +- 2 files

[Xen-devel] [PATCH 0/2] Move RSDP address out of setup_header

2018-11-19 Thread Juergen Gross
Resend with Daniel's mailo address corrected Instead of passing the RSDP address for Xen PVH guests from grub2 to the kernel in setup_header move it into the non-legacy part of the boot_params structure. This patch series should be applied rather sooner than later in order to avoid shipping

[Xen-devel] [PATCH 1/2] x86/boot: revert commit ae7e1238e68f2a (Add ACPI RSDP address to setup_header)

2018-11-19 Thread Juergen Gross
Peter Anvin pointed out that commit ae7e1238e68f2a ("x86/boot: Add ACPI RSDP address to setup_header") should be reverted as setup_header should contain only items set by legacy BIOS. So revert said commit. Instead of fully reverting the depending commit e7b66d16fe4172 ("x86/acpi, x86/boot: Take

[Xen-devel] [xen-unstable-smoke test] 130576: trouble: blocked/broken/pass

2018-11-19 Thread osstest service owner
flight 130576 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/130576/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm broken

[Xen-devel] [xen-unstable baseline-only test] 75614: regressions - FAIL

2018-11-19 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 75614 xen-unstable real [real] http://osstest.xensource.com/osstest/logs/75614/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-pygrub 22 leak-check/check

[Xen-devel] Xen make grub error

2018-11-19 Thread Chen, Farrah
Hi, When we make grub with xen, we met below error, do you have any advice? cd grub ./autogen.sh ./configure --target=amd64 --with-platform=xen --prefix=${PWD}/../pvgrub2 make . loader/i386/xen.c: In function 'grub_cmd_xen': loader/i386/xen.c:650:10: error: too few arguments to function

[Xen-devel] [PATCH 1/2] x86/boot: revert commit ae7e1238e68f2a (Add ACPI RSDP address to setup_header)

2018-11-19 Thread Juergen Gross
Peter Anvin pointed out that commit ae7e1238e68f2a ("x86/boot: Add ACPI RSDP address to setup_header") should be reverted as setup_header should contain only items set by legacy BIOS. So revert said commit. Instead of fully reverting the depending commit e7b66d16fe4172 ("x86/acpi, x86/boot: Take

[Xen-devel] [PATCH 0/2] Move RSDP address out of setup_header

2018-11-19 Thread Juergen Gross
Instead of passing the RSDP address for Xen PVH guests from grub2 to the kernel in setup_header move it into the non-legacy part of the boot_params structure. This patch series should be applied rather sooner than later in order to avoid shipping linux 4.20 with a corky boot protocol. Juergen

[Xen-devel] [PATCH 2/2] x86/acpi, x86/boot: Take RSDP address from boot params if available

2018-11-19 Thread Juergen Gross
In case the RSDP address in struct boot_params is specified don't try to find the table by searching, but take the address directly as set by the boot loader. Signed-off-by: Juergen Gross --- arch/x86/include/uapi/asm/bootparam.h | 3 ++- arch/x86/kernel/acpi/boot.c | 2 +- 2 files

[Xen-devel] [xen-unstable-smoke test] 130562: trouble: blocked/broken/pass

2018-11-19 Thread osstest service owner
flight 130562 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/130562/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm broken

[Xen-devel] [ovmf test] 130531: regressions - FAIL

2018-11-19 Thread osstest service owner
flight 130531 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/130531/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm6 xen-buildfail REGR. vs. 129475 build-i386

Re: [Xen-devel] [PATCH v5 1/2] memory_hotplug: Free pages as higher order

2018-11-19 Thread Wei Yang
On Thu, Oct 11, 2018 at 6:05 PM Vlastimil Babka wrote: > > On 10/10/18 6:56 PM, Arun KS wrote: > > On 2018-10-10 21:00, Vlastimil Babka wrote: > >> On 10/5/18 10:10 AM, Arun KS wrote: > >>> When free pages are done with higher order, time spend on > >>> coalescing pages by buddy allocator can be

Re: [Xen-devel] PLEASE REVERT URGENTLY: Re: [PATCH v5 2/3] x86/boot: add acpi rsdp address to setup_header

2018-11-19 Thread Konrad Rzeszutek Wilk
On Sun, Nov 11, 2018 at 10:49:39AM -0800, H. Peter Anvin wrote: > On 11/10/18 1:03 AM, Juergen Gross wrote: > > > > How would that help? The garabge data written could have the correct > > terminal sentinel value by chance. > > > > That's why I re-used an existing field in setup_header (the

Re: [Xen-devel] [PATCH V6 4/4] x86/altp2m: fix display frozen when switching to a new view early

2018-11-19 Thread George Dunlap
On 11/19/18 4:17 PM, Razvan Cojocaru wrote: > On 11/19/18 5:58 PM, George Dunlap wrote: >> On 11/17/18 6:58 PM, Razvan Cojocaru wrote: >>> On 11/16/18 9:50 PM, Razvan Cojocaru wrote: On 11/16/18 7:59 PM, George Dunlap wrote: > On the other hand, we want the logdirty rangesets to actually

Re: [Xen-devel] [OSSTEST PATCH 1/3] ts-depriv-audit-qemu: Create complete /run/user in appropriate root

2018-11-19 Thread Ian Jackson
George Dunlap writes ("Re: [OSSTEST PATCH 1/3] ts-depriv-audit-qemu: Create complete /run/user in appropriate root"): > On 11/19/18 4:27 PM, Ian Jackson wrote: > > CC: George Dunlap > > Signed-off-by: Ian Jackson > > It doesn't look like this does an `rm -rf $qroot` afterwards. If on > this

[Xen-devel] [PATCH V7 4/5] p2m: Always use hostp2m when clipping rangesets

2018-11-19 Thread Razvan Cojocaru
The logdirty rangesets of the altp2ms need to be kept in sync with the hostp2m. This means when iterating through the altp2ms, we need to use the host p2m to clip the rangeset, not the indiviual altp2m's value. This change also: - Documents that the end is non-inclusive - Calculates an

Re: [Xen-devel] [PATCH 1/9] mm: Introduce new vm_insert_range API

2018-11-19 Thread Souptick Joarder
On Mon, Nov 19, 2018 at 9:56 PM Mike Rapoport wrote: > > On Mon, Nov 19, 2018 at 08:43:09PM +0530, Souptick Joarder wrote: > > Hi Mike, > > > > On Sat, Nov 17, 2018 at 8:07 PM Matthew Wilcox wrote: > > > > > > On Sat, Nov 17, 2018 at 12:26:38PM +0530, Souptick Joarder wrote: > > > > On Fri, Nov

Re: [Xen-devel] [Qemu-devel] [PATCH v5 00/24] ACPI reorganization for hardware-reduced API addition

2018-11-19 Thread Paolo Bonzini
On 19/11/18 16:31, Igor Mammedov wrote: > I've tried to give suggestions how to restructure series > on per patch basis. In my opinion it quite possible to split > series in several smaller ones and it should really help with > making series cleaner and easier/faster to review/amend/merge > vs

Re: [Xen-devel] [OSSTEST PATCH 1/3] ts-depriv-audit-qemu: Create complete /run/user in appropriate root

2018-11-19 Thread Wei Liu
On Mon, Nov 19, 2018 at 04:27:39PM +, Ian Jackson wrote: > * Use mkdir -p, rather than trying to only create /run/user/$uid. > That helps if /run and/or /run/user do not exist, as they do in > libxl-made chroots with recent libxl (which gets qemu to chroot). > > * Do all of this in the

Re: [Xen-devel] (no subject)

2018-11-19 Thread Razvan Cojocaru
Apologies, the subject should have been, of course, "[PATCH V7 0/5] Fix VGA logdirty related display freezes with altp2m", which I did paste in, but ommited to uncomment. Sorry, Razvan ___ Xen-devel mailing list Xen-devel@lists.xenproject.org

[Xen-devel] [libvirt test] 130430: regressions - trouble: blocked/broken/fail/pass

2018-11-19 Thread osstest service owner
flight 130430 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/130430/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64 broken build-arm64-pvops

Re: [Xen-devel] [OSSTEST PATCH 1/3] ts-depriv-audit-qemu: Create complete /run/user in appropriate root

2018-11-19 Thread George Dunlap
On 11/19/18 4:53 PM, Ian Jackson wrote: > George Dunlap writes ("Re: [OSSTEST PATCH 1/3] ts-depriv-audit-qemu: Create > complete /run/user in appropriate root"): >> On 11/19/18 4:27 PM, Ian Jackson wrote: >>> CC: George Dunlap >>> Signed-off-by: Ian Jackson >> >> It doesn't look like this does

Re: [Xen-devel] [OSSTEST PATCH 1/3] ts-depriv-audit-qemu: Create complete /run/user in appropriate root

2018-11-19 Thread Ian Jackson
George Dunlap writes ("Re: [OSSTEST PATCH 1/3] ts-depriv-audit-qemu: Create complete /run/user in appropriate root"): > Implementing `rm -rf` in C is a reasonably large faff; and given that > qemu shouldn't be able to write to it anyway, I figured simply doing an > `rmdir` and failing if it

[Xen-devel] [PATCH V7 5/5] p2m: change_range_type: Only invalidate mapped gfns

2018-11-19 Thread Razvan Cojocaru
change_range_type() invalidates gfn ranges to lazily change the type of a range of gfns, and also modifies the logdirty rangesets of that p2m. At the moment, it clips both down by the hostp2m. While this will result in correct behavior, it's not entirely efficient, since invalidated entries

[Xen-devel] [PATCH V7 1/5] x86/mm: introduce p2m_{init, free}_logdirty()

2018-11-19 Thread Razvan Cojocaru
Add logdirty_ranges allocator / deallocator helpers. p2m_init_logdirty() will not re-allocate if p2m->logdirty ranges has already been allocated. Move the rangeset deallocation call from p2m_teardown_hostp2m() to p2m_free_one() - we will want this to apply to altp2ms as well. Signed-off-by:

[Xen-devel] (no subject)

2018-11-19 Thread Razvan Cojocaru
This series aims to prevent the display from freezing when enabling altp2m and switching to a new view (and assorted problems when resizing the display). The first patch introduces p2m_{init,free}_logdirty(), the second allocates a new logdirty rangeset for each new altp2m, and the fourth

[Xen-devel] [PATCH V7 3/5] x86/altp2m: fix display frozen when switching to a new view early

2018-11-19 Thread Razvan Cojocaru
When an new altp2m view is created very early on guest boot, the display will freeze (although the guest will run normally). This may also happen on resizing the display. The reason is the way Xen currently (mis)handles logdirty VGA: it intentionally misconfigures VGA pages so that they will

[Xen-devel] [PATCH V7 2/5] x86/mm: allocate logdirty_ranges for altp2ms

2018-11-19 Thread Razvan Cojocaru
For now, only do allocation/deallocation; keeping them in sync will be done in subsequent patches. Logdirty synchronization will only be done for active altp2ms; so allocate logdirty rangesets (copying the host logdirty rangeset) when an altp2m is activated, and free it when deactivated. Write a

[Xen-devel] [xen-unstable-smoke test] 130530: trouble: blocked/broken/pass

2018-11-19 Thread osstest service owner
flight 130530 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/130530/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm broken

[Xen-devel] [qemu-mainline test] 130482: trouble: blocked/broken/fail/pass

2018-11-19 Thread osstest service owner
flight 130482 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/130482/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64 broken build-arm64-xsm

[Xen-devel] [linux-3.18 test] 130468: regressions - trouble: blocked/broken/fail/pass

2018-11-19 Thread osstest service owner
flight 130468 linux-3.18 real [real] http://logs.test-lab.xenproject.org/osstest/logs/130468/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-pvopsbroken build-arm64-xsm

Re: [Xen-devel] [PATCH v5 14/47] x86emul: support AVX512{F, BW} packed integer compare insns

2018-11-19 Thread Andrew Cooper
On 19/11/2018 10:21, Jan Beulich wrote: > Include VPTEST{,N}M{B,D,Q,W} as once again possibly used by the compiler > for comparison against all-zero vectors. > > Also table entries for a few more insns get their .d8s field set right > away, again in order to not split and later re-combine the

Re: [Xen-devel] [PATCH v5 15/47] x86emul: support AVX512{F, BW} packed integer arithmetic insns

2018-11-19 Thread Andrew Cooper
On 19/11/2018 10:21, Jan Beulich wrote: > Note: vpadd* / vpsub* et al are put at seemingly the wrong slot of the > big switch(). This is in anticipation of adding e.g. vpunpck* to those > groups (see the legacy/VEX encoded case labels nearby to support this). > > Signed-off-by: Jan Beulich

Re: [Xen-devel] [PATCH v5 16/47] x86emul: use simd_128 also for legacy vector shift insns

2018-11-19 Thread Andrew Cooper
On 19/11/2018 10:22, Jan Beulich wrote: > @@ -3344,7 +3344,8 @@ x86_decode( > break; > > case simd_128: > -op_bytes = 16; > +/* The special case here are MMX shift insns. */ "special case here is the MMX" or "special cases here are". Otherwise, Acked-by: Andrew

Re: [Xen-devel] [PATCH 0/3] Assorted Gitlab CI improvements

2018-11-19 Thread Doug Goldstein
On Fri, Nov 16, 2018 at 01:12:27PM +, Wei Liu wrote: > Wei Liu (3): > automation: refactor gitlab-ci.yaml > automation: introduce some RANDCONFIG tests > automation: properly tag x86 jobs in Gitlab CI > > .gitlab-ci.yml | 309 > ++---

Re: [Xen-devel] [PATCH 1/4] xen/arm: gic: Ensure we have an ISB between ack and do_IRQ()

2018-11-19 Thread Julien Grall
On Mon, 19 Nov 2018, 15:57 Andrii Anisov, wrote: > Julien, > > > It's me again about your patch:) > > I've found this patch useful and even can give a motivation to have it > in the mainline. The patch ensures that vgic_sync_from_lrs is performed > on guest to hyp switch prior to any IRQ

Re: [Xen-devel] [OSSTEST PATCH 1/3] ts-depriv-audit-qemu: Create complete /run/user in appropriate root

2018-11-19 Thread George Dunlap
On 11/19/18 4:27 PM, Ian Jackson wrote: > * Use mkdir -p, rather than trying to only create /run/user/$uid. > That helps if /run and/or /run/user do not exist, as they do in > libxl-made chroots with recent libxl (which gets qemu to chroot). > > * Do all of this in the root directory of the

Re: [Xen-devel] [PATCH v3] iommu / p2m: add a page_order parameter to iommu_map/unmap_page()...

2018-11-19 Thread George Dunlap
On 10/31/18 3:21 PM, Paul Durrant wrote: > ...and re-name them to iommu_map/unmap() since they no longer necessarily > operate on a single page. > > The P2M code currently contains many loops to deal with the fact that, > while it may be require to handle page orders greater than 0, the > IOMMU

Re: [Xen-devel] [PATCH v5 19/24] hw: acpi: Retrieve the PCI bus from AcpiPciHpState

2018-11-19 Thread Boeuf, Sebastien
On Mon, 2018-11-19 at 16:37 +0100, Igor Mammedov wrote: > On Fri, 16 Nov 2018 19:42:08 + > "Boeuf, Sebastien" wrote: > > > > > Hi Igor, > > > > On Fri, 2018-11-16 at 10:39 +0100, Igor Mammedov wrote: > > > > > > On Mon,  5 Nov 2018 02:40:42 +0100 > > > Samuel Ortiz wrote: > > >    > > >

Re: [Xen-devel] [PATCH v7 0/7] KVM: x86: Allow Qemu/KVM to use PVH entry point

2018-11-19 Thread Paolo Bonzini
On 16/11/18 18:17, Maran Wilson wrote: > On 11/16/2018 2:46 AM, Paolo Bonzini wrote: >> On 17/04/18 01:09, Maran Wilson wrote: >>> For certain applications it is desirable to rapidly boot a KVM virtual >>> machine. In cases where legacy hardware and software support within the >>> guest is not

Re: [Xen-devel] [PATCH v5 05/24] hw: acpi: Implement XSDT support for RSDP

2018-11-19 Thread Michael S. Tsirkin
On Thu, Nov 08, 2018 at 03:16:23PM +0100, Igor Mammedov wrote: > On Mon, 5 Nov 2018 02:40:28 +0100 > Samuel Ortiz wrote: > > > XSDT is the 64-bit version of the legacy ACPI RSDT (Root System > > Description Table). RSDT only allow for 32-bit addressses and have thus > > been deprecated. Since

Re: [Xen-devel] [PATCH v5 12/47] x86emul: support AVX512{F, DQ} FP broadcast insns

2018-11-19 Thread Andrew Cooper
On 19/11/2018 10:19, Jan Beulich wrote: > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [PATCH] CONTRIBUTING: Clarifications on how to handle license deviations

2018-11-19 Thread Lars Kurth
This patch makes a few clarifications which were discussed on IRC recently. Specifically: - Highlight the principle that license deviations should be brought to the attention of maintainers - Add a requirement for GPLv2 compatibility - Restructure the document toghlight use-cases for

Re: [Xen-devel] [PATCH v5 01/47] x86emul: introduce IMPOSSIBLE()

2018-11-19 Thread Andrew Cooper
On 19/11/2018 10:13, Jan Beulich wrote: > @@ -8828,12 +8837,7 @@ x86_emulate( > dst.type = OP_NONE; > break; > default: > -if ( (d & DstMask) != DstMem ) > -{ > -ASSERT_UNREACHABLE(); > -

Re: [Xen-devel] [Qemu-devel] [PATCH v5 00/24] ACPI reorganization for hardware-reduced API addition

2018-11-19 Thread Michael S. Tsirkin
On Mon, Nov 19, 2018 at 06:14:26PM +0100, Paolo Bonzini wrote: > On 19/11/18 16:31, Igor Mammedov wrote: > > I've tried to give suggestions how to restructure series > > on per patch basis. In my opinion it quite possible to split > > series in several smaller ones and it should really help with >

Re: [Xen-devel] [PATCH 0/2] automation: Add 32bit Jessie

2018-11-19 Thread Andrew Cooper
On 19/11/2018 16:01, Andrew Cooper wrote: > Sample run available here: > > https://gitlab.com/xen-project/people/andyhhp/xen/pipelines/37138805 > > Note that the failure is due to missing "libx86: Work around GCC being unable > to spill the PIC hard register" which was the trigger for doing this

Re: [Xen-devel] [PATCH v5 02/47] x86emul: support basic AVX512 moves

2018-11-19 Thread Andrew Cooper
On 19/11/2018 10:13, Jan Beulich wrote: > Note: SDM Vol 2 rev 067 is not really consistent about EVEX.L'L for LIG > insns - the only place where this is made explicit is a table in > the section titled "Vector Length Orthogonality": While they > tolerate 0, 1, and 2, a value of 3

Re: [Xen-devel] [PATCH v5 03/47] x86emul: test for correct EVEX Disp8 scaling

2018-11-19 Thread Andrew Cooper
On 19/11/2018 10:14, Jan Beulich wrote: > Besides the already existing tests (which are going to be extended once > respective ISA extension support is complete), let's also ensure for > every individual insn that their Disp8 scaling (and memory access width) > are correct. > > Signed-off-by: Jan

Re: [Xen-devel] [PATCH v5 04/47] x86emul: also allow running the 32-bit harness on a 64-bit distro

2018-11-19 Thread Andrew Cooper
On 19/11/2018 10:14, Jan Beulich wrote: > In order to be able to verify the 32-bit variant builds and runs, > introduce a respective target (and the necessary other adjustments). > > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper This seems to all work fine now.

Re: [Xen-devel] [PATCH V6 4/4] x86/altp2m: fix display frozen when switching to a new view early

2018-11-19 Thread Razvan Cojocaru
On 11/19/18 5:58 PM, George Dunlap wrote: > On 11/17/18 6:58 PM, Razvan Cojocaru wrote: >> On 11/16/18 9:50 PM, Razvan Cojocaru wrote: >>> On 11/16/18 7:59 PM, George Dunlap wrote: On the other hand, we want the logdirty rangesets to actually match the host's rangesets; using

Re: [Xen-devel] [PATCH 1/9] mm: Introduce new vm_insert_range API

2018-11-19 Thread Mike Rapoport
On Mon, Nov 19, 2018 at 08:43:09PM +0530, Souptick Joarder wrote: > Hi Mike, > > On Sat, Nov 17, 2018 at 8:07 PM Matthew Wilcox wrote: > > > > On Sat, Nov 17, 2018 at 12:26:38PM +0530, Souptick Joarder wrote: > > > On Fri, Nov 16, 2018 at 11:59 PM Mike Rapoport wrote: > > > > > + *

[Xen-devel] [PATCH for-3.1] hw/xen/xen_pt_graphics: Don't trust the BIOS ROM contents so much

2018-11-19 Thread Peter Maydell
Coverity (CID 796599) points out that xen_pt_setup_vga() trusts the rom->size field in the BIOS ROM from a PCI passthrough VGA device, and uses it as an index into the memory which contains the BIOS image. A corrupt BIOS ROM could therefore cause us to index off the end of the buffer. Check that

[Xen-devel] [OSSTEST PATCH 3/3] productionc-config*: Update to fishdescriptor with chroot bugfix

2018-11-19 Thread Ian Jackson
Deployment note: I have copied this binary to the images directory in Cambridge and Massachusetts. The corresponding patch to chiark-utils is on its way to my upstream hat. CC: George Dunlap Signed-off-by: Ian Jackson --- production-config | 2 +- production-config-cambridge | 2 +-

[Xen-devel] [OSSTEST PATCH 2/3] ts-depriv-audit-qemu: chmod +x qemu's chroot

2018-11-19 Thread Ian Jackson
libxl creates this directory with mode 0. That prevents fishdescriptor from working. chmod it. This is OK for testing. CC: George Dunlap Signed-off-by: Ian Jackson --- ts-depriv-audit-qemu | 1 + 1 file changed, 1 insertion(+) diff --git a/ts-depriv-audit-qemu b/ts-depriv-audit-qemu index

Re: [Xen-devel] [PATCH 1/2] automation: Add a 32bit Debian Jessie dockerfile

2018-11-19 Thread Wei Liu
On Mon, Nov 19, 2018 at 04:01:20PM +, Andrew Cooper wrote: > Signed-off-by: Andrew Cooper Acked-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] x86: fix efi.lds dependency generation

2018-11-19 Thread Jan Beulich
>>> On 18.11.18 at 14:14, wrote: > RANDCONFIG builds discover efi.lds is not updated when autogenerated > headers are updated. > > Upon inspection, the generated .d file contains xen.lds.o as target, > not the once thought efi.lds.o. That's because gcc disregards the > output object name

Re: [Xen-devel] [PATCH v3 5/5] xen/keyhandler: Drop keyhandler_scratch

2018-11-19 Thread Jan Beulich
>>> On 16.11.18 at 18:45, wrote: > With almost all users of keyhandler_scratch gone, clean up the 3 remaining > users and drop the buffer. > > Signed-off-by: Andrew Cooper > Reviewed-by: Wei Liu Reviewed-by: Jan Beulich ___ Xen-devel mailing

Re: [Xen-devel] [PATCH v4 1/5] vpci: fix updating the command register

2018-11-19 Thread Jan Beulich
>>> On 16.11.18 at 15:32, wrote: > On Fri, Nov 16, 2018 at 05:00:29AM -0700, Jan Beulich wrote: >> >>> On 14.11.18 at 12:57, wrote: >> > @@ -413,7 +412,7 @@ static void rom_write(const struct pci_dev *pdev, >> > unsigned int reg, >> > header->rom_enabled = new_enabled; >> >

Re: [Xen-devel] [PATCH v4 2/5] vpci: fix deferral of long operations

2018-11-19 Thread Jan Beulich
>>> On 16.11.18 at 15:57, wrote: > On Fri, Nov 16, 2018 at 05:11:39AM -0700, Jan Beulich wrote: >> >>> On 14.11.18 at 12:57, wrote: >> > @@ -182,6 +185,7 @@ static void defer_map(struct domain *d, struct pci_dev >> > *pdev, >> > curr->vpci.mem = mem; >> > curr->vpci.cmd = cmd; >> >

Re: [Xen-devel] [PATCH 0/4] x86: Drop PVRDTSCP and fix MSR_TSC_AUX handling for guests

2018-11-19 Thread Jan Beulich
>>> On 16.11.18 at 18:43, wrote: > On 16/11/2018 10:11, Jan Beulich wrote: > On 15.11.18 at 22:47, wrote: >>> Boris has confirmed that noone appears to be using PVRDTSCP any more, and in >>> the decade since it was introduced, guest kernel / hardware support has >>> provided a better

[Xen-devel] [ovmf test] 130483: regressions - FAIL

2018-11-19 Thread osstest service owner
flight 130483 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/130483/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 129475 build-amd64-xsm

Re: [Xen-devel] Guest soft lockups with "xen: make xen_qlock_wait() nestable"

2018-11-19 Thread David Woodhouse
On Mon, 2018-11-19 at 08:05 +0100, Juergen Gross wrote: > On 15/11/2018 00:22, David Woodhouse wrote: > > On Thu, 2018-11-08 at 11:18 +0100, Juergen Gross wrote: > > > Oh, sorry. Of course it does. Dereferencing a percpu variable > > > directly can't work. How silly of me. > > > > > > The

[Xen-devel] [xen-4.7-testing test] 130385: trouble: blocked/broken/fail/pass

2018-11-19 Thread osstest service owner
flight 130385 xen-4.7-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/130385/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-pvopsbroken build-arm64-xsm

Re: [Xen-devel] Guest soft lockups with "xen: make xen_qlock_wait() nestable"

2018-11-19 Thread Juergen Gross
On 19/11/2018 10:39, David Woodhouse wrote: > On Mon, 2018-11-19 at 08:05 +0100, Juergen Gross wrote: >> On 15/11/2018 00:22, David Woodhouse wrote: >>> On Thu, 2018-11-08 at 11:18 +0100, Juergen Gross wrote: Oh, sorry. Of course it does. Dereferencing a percpu variable directly can't

Re: [Xen-devel] [PATCH 5/9] drm/xen/xen_drm_front_gem.c: Convert to use vm_insert_range

2018-11-19 Thread Oleksandr Andrushchenko
On 11/15/18 5:49 PM, Souptick Joarder wrote: Convert to use vm_insert_range() to map range of kernel memory to user vma. Signed-off-by: Souptick Joarder Reviewed-by: Matthew Wilcox --- drivers/gpu/drm/xen/xen_drm_front_gem.c | 20 ++-- 1 file changed, 6 insertions(+), 14

[Xen-devel] [PATCH v5 00/47] x86emul: fair parts of AVX512 support

2018-11-19 Thread Jan Beulich
01: introduce IMPOSSIBLE() 02: support basic AVX512 moves 03: test for correct EVEX Disp8 scaling 04: also allow running the 32-bit harness on a 64-bit distro 05: use AVX512 logic for emulating V{,P}MASKMOV* 06: support AVX512F legacy-equivalent arithmetic FP insns 07: support AVX512DQ logic FP

[Xen-devel] [PATCH v5 01/47] x86emul: introduce IMPOSSIBLE()

2018-11-19 Thread Jan Beulich
This abstracts away the debug/release coverage using both ASSERT_UNREACHABLE() and a return value of X86EMUL_UNHANDLEABLE. Signed-off-by: Jan Beulich --- v5: New. --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -1017,6 +1017,15 @@ do { if ( rc )

[Xen-devel] [PATCH v5 02/47] x86emul: support basic AVX512 moves

2018-11-19 Thread Jan Beulich
Note: SDM Vol 2 rev 067 is not really consistent about EVEX.L'L for LIG insns - the only place where this is made explicit is a table in the section titled "Vector Length Orthogonality": While they tolerate 0, 1, and 2, a value of 3 uniformly leads to #UD. Signed-off-by: Jan

[Xen-devel] [PATCH v5 03/47] x86emul: test for correct EVEX Disp8 scaling

2018-11-19 Thread Jan Beulich
Besides the already existing tests (which are going to be extended once respective ISA extension support is complete), let's also ensure for every individual insn that their Disp8 scaling (and memory access width) are correct. Signed-off-by: Jan Beulich --- v5: Fix upper bound of first access

[Xen-devel] [PATCH v5 04/47] x86emul: also allow running the 32-bit harness on a 64-bit distro

2018-11-19 Thread Jan Beulich
In order to be able to verify the 32-bit variant builds and runs, introduce a respective target (and the necessary other adjustments). Signed-off-by: Jan Beulich --- v5: Use vpath directive instead of VPATH variable. Use ?= instead of ifeq(). Don't have clean32 depend on generated headers.

[Xen-devel] [PATCH v5 05/47] x86emul: use AVX512 logic for emulating V{, P}MASKMOV*

2018-11-19 Thread Jan Beulich
The more generic AVX512 implementation allows quite a bit of insn- specific code to be dropped/shared. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -439,8 +439,8 @@ static const struct

[Xen-devel] [PATCH v5 06/47] x86emul: support AVX512F legacy-equivalent arithmetic FP insns

2018-11-19 Thread Jan Beulich
Signed-off-by: Jan Beulich Acked-by: Andrew Cooper --- v3: New. --- a/tools/tests/x86_emulator/evex-disp8.c +++ b/tools/tests/x86_emulator/evex-disp8.c @@ -104,6 +104,10 @@ enum esz { INSN_SFP(m, sp, o) static const struct test avx512f_all[] = { +INSN_FP(add, 0f, 58), +

[Xen-devel] [PATCH v1 1/8] mm: balloon: update comment about isolation/migration/compaction

2018-11-19 Thread David Hildenbrand
Commit b1123ea6d3b3 ("mm: balloon: use general non-lru movable page feature") reworked balloon handling to make use of the general non-lru movable page feature. The big comment block in balloon_compaction.h contains quite some outdated information. Let's fix this. Cc: Andrew Morton Cc: Matthew

[Xen-devel] [PATCH v1 2/8] mm: convert PG_balloon to PG_offline

2018-11-19 Thread David Hildenbrand
PG_balloon was introduced to implement page migration/compaction for pages inflated in virtio-balloon. Nowadays, it is only a marker that a page is part of virtio-balloon and therefore logically offline. We also want to make use of this flag in other balloon drivers - for inflated pages or when

[Xen-devel] [PATCH v1 5/8] hv_balloon: mark inflated pages PG_offline

2018-11-19 Thread David Hildenbrand
Mark inflated and never onlined pages PG_offline, to tell the world that the content is stale and should not be dumped. Cc: "K. Y. Srinivasan" Cc: Haiyang Zhang Cc: Stephen Hemminger Cc: Kairui Song Cc: Vitaly Kuznetsov Cc: Andrew Morton Cc: Matthew Wilcox Cc: Michal Hocko Cc: "Michael S.

[Xen-devel] [PATCH v5 08/47] x86emul: support basic AVX512F FP compare insns

2018-11-19 Thread Jan Beulich
V{,U}COMIS{S,D} to follow later. Also correct the AVX counterpart's comment. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper --- v5: Adjust title. v3: New. --- a/tools/tests/x86_emulator/evex-disp8.c +++ b/tools/tests/x86_emulator/evex-disp8.c @@ -105,6 +105,7 @@ enum esz { static const

[Xen-devel] [PATCH v1 7/8] PM / Hibernate: use pfn_to_online_page()

2018-11-19 Thread David Hildenbrand
Let's use pfn_to_online_page() instead of pfn_to_page() when checking for saveable pages to not save/restore offline memory sections. Cc: "Rafael J. Wysocki" Cc: Pavel Machek Cc: Len Brown Cc: Andrew Morton Cc: Matthew Wilcox Cc: Michal Hocko Cc: "Michael S. Tsirkin" Suggested-by: Michal

[Xen-devel] [PATCH v1 4/8] xen/balloon: mark inflated pages PG_offline

2018-11-19 Thread David Hildenbrand
Mark inflated and never onlined pages PG_offline, to tell the world that the content is stale and should not be dumped. Cc: Boris Ostrovsky Cc: Juergen Gross Cc: Stefano Stabellini Cc: Andrew Morton Cc: Matthew Wilcox Cc: Michal Hocko Cc: "Michael S. Tsirkin" Signed-off-by: David

[Xen-devel] [PATCH v1 6/8] vmw_balloon: mark inflated pages PG_offline

2018-11-19 Thread David Hildenbrand
Mark inflated and never onlined pages PG_offline, to tell the world that the content is stale and should not be dumped. Cc: Xavier Deguillard Cc: Nadav Amit Cc: Arnd Bergmann Cc: Greg Kroah-Hartman Cc: Julien Freche Cc: Andrew Morton Cc: Matthew Wilcox Cc: Michal Hocko Cc: "Michael S.

[Xen-devel] [PATCH v1 3/8] kexec: export PG_offline to VMCOREINFO

2018-11-19 Thread David Hildenbrand
Right now, pages inflated as part of a balloon driver will be dumped by dump tools like makedumpfile. While XEN is able to check in the crash kernel whether a certain pfn is actuall backed by memory in the hypervisor (see xen_oldmem_pfn_is_ram) and optimize this case, dumps of other balloon

[Xen-devel] [PATCH v1 0/8] mm/kdump: allow to exclude pages that are logically offline

2018-11-19 Thread David Hildenbrand
Right now, pages inflated as part of a balloon driver will be dumped by dump tools like makedumpfile. While XEN is able to check in the crash kernel whether a certain pfn is actuall backed by memory in the hypervisor (see xen_oldmem_pfn_is_ram) and optimize this case, dumps of virtio-balloon,

[Xen-devel] [PATCH v5 07/47] x86emul: support AVX512DQ logic FP insns

2018-11-19 Thread Jan Beulich
Signed-off-by: Jan Beulich Acked-by: Andrew Cooper --- v3: New. --- a/tools/tests/x86_emulator/evex-disp8.c +++ b/tools/tests/x86_emulator/evex-disp8.c @@ -144,6 +144,13 @@ static const struct test avx512bw_all[] INSN(movdqu16,f2, 0f, 7f,vl,w, vl), }; +static const struct

[Xen-devel] [PATCH v5 09/47] x86emul: support AVX512F misc legacy-equivalent FP insns

2018-11-19 Thread Jan Beulich
Also correct an AVX counterpart's comment. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper --- v3: New. --- a/tools/tests/x86_emulator/evex-disp8.c +++ b/tools/tests/x86_emulator/evex-disp8.c @@ -127,8 +127,11 @@ static const struct test avx512f_all[] = INSN_PFP_NB(movu,0f,

[Xen-devel] [PATCH v1 8/8] PM / Hibernate: exclude all PageOffline() pages

2018-11-19 Thread David Hildenbrand
The content of pages that are marked PG_offline is not of interest (e.g. inflated by a balloon driver), let's skip these pages. Cc: "Rafael J. Wysocki" Cc: Pavel Machek Cc: Len Brown Cc: Andrew Morton Cc: Matthew Wilcox Cc: Michal Hocko Cc: "Michael S. Tsirkin" Acked-by: Pavel Machek

[Xen-devel] [ovmf test] 130491: regressions - FAIL

2018-11-19 Thread osstest service owner
flight 130491 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/130491/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 129475 build-amd64-xsm

[Xen-devel] [PATCH v5 10/47] x86emul: support AVX512F fused-multiply-add insns

2018-11-19 Thread Jan Beulich
Signed-off-by: Jan Beulich Acked-by: Andrew Cooper --- v3: New. --- a/tools/tests/x86_emulator/evex-disp8.c +++ b/tools/tests/x86_emulator/evex-disp8.c @@ -107,6 +107,36 @@ static const struct test avx512f_all[] = INSN_FP(add, 0f, 58), INSN_FP(cmp, 0f, c2),

[Xen-devel] [PATCH v5 11/47] x86emul: support AVX512F legacy-equivalent logic insns

2018-11-19 Thread Jan Beulich
Plus vpternlog{d,q} as being extensively used by the compiler, in order to facilitate test enabling in the harness as soon as possible. Also the twobyte_table[] entries for a few more insns get their .d8s field set right away, in order to not split and later re-combine the groups. Signed-off-by:

[Xen-devel] [PATCH v1] makedumpfile: exclude pages that are logically offline

2018-11-19 Thread David Hildenbrand
Linux marks pages that are logically offline via a page flag (map count). Such pages e.g. include pages infated as part of a balloon driver or pages that were not actually onlined when onlining the whole section. While the hypervisor usually allows to read such inflated memory, we basically read

[Xen-devel] [PATCH v5 12/47] x86emul: support AVX512{F, DQ} FP broadcast insns

2018-11-19 Thread Jan Beulich
Signed-off-by: Jan Beulich --- v5: Use IMPOSSIBLE() to guard against division by zero. v3: New. --- a/tools/tests/x86_emulator/evex-disp8.c +++ b/tools/tests/x86_emulator/evex-disp8.c @@ -105,6 +105,7 @@ enum esz { static const struct test avx512f_all[] = { INSN_FP(add, 0f,

[Xen-devel] [PATCH v5 13/47] x86emul: support AVX512F v{, u}comis{d, s} insns

2018-11-19 Thread Jan Beulich
Signed-off-by: Jan Beulich Acked-by: Andrew Cooper --- v4: Add missing avx512_vlen_check(). v3: New. --- a/tools/tests/x86_emulator/evex-disp8.c +++ b/tools/tests/x86_emulator/evex-disp8.c @@ -107,6 +107,8 @@ static const struct test avx512f_all[] = INSN_FP(add, 0f, 58),

  1   2   >