Re: [Xen-devel] [PATCH v1 8/8] PM / Hibernate: exclude all PageOffline() pages

2018-11-20 Thread Rafael J. Wysocki
On Monday, November 19, 2018 11:16:16 AM CET David Hildenbrand wrote: > The content of pages that are marked PG_offline is not of interest > (e.g. inflated by a balloon driver), let's skip these pages. > > Cc: "Rafael J. Wysocki" > Cc: Pavel Machek > Cc: Len Brown > Cc: Andrew Morton > Cc:

Re: [Xen-devel] [PATCH 1/4] xen/arm: gic: Ensure we have an ISB between ack and do_IRQ()

2018-11-20 Thread Julien Grall
On 20/11/2018 18:10, Andrii Anisov wrote: Hello Julien, On 19.11.18 18:42, Julien Grall wrote: There are no issue about processing IRQs before the syncs. It is the same as if an IRQ was raised from ila different pCPUs. So why do you need that? From my understanding of gic-vgic code (old

[Xen-devel] [linux-3.18 bisection] complete test-amd64-i386-freebsd10-amd64

2018-11-20 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-i386-freebsd10-amd64 testid freebsd-install Tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu

Re: [Xen-devel] [PATCH v1 7/8] PM / Hibernate: use pfn_to_online_page()

2018-11-20 Thread Rafael J. Wysocki
On Monday, November 19, 2018 11:16:15 AM CET David Hildenbrand wrote: > Let's use pfn_to_online_page() instead of pfn_to_page() when checking > for saveable pages to not save/restore offline memory sections. > > Cc: "Rafael J. Wysocki" > Cc: Pavel Machek > Cc: Len Brown > Cc: Andrew Morton >

[Xen-devel] [ovmf test] 130580: regressions - FAIL

2018-11-20 Thread osstest service owner
flight 130580 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/130580/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm6 xen-buildfail REGR. vs. 129475 build-i386

[Xen-devel] [libvirt test] 130599: regressions - trouble: blocked/broken/fail/pass

2018-11-20 Thread osstest service owner
flight 130599 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/130599/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64 broken build-arm64-pvops

[Xen-devel] [xen-unstable-smoke test] 130625: regressions - trouble: blocked/broken/fail/pass

2018-11-20 Thread osstest service owner
flight 130625 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/130625/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm broken build-amd64 6

Re: [Xen-devel] [Qemu-devel] [PATCH v5 00/24] ACPI reorganization for hardware-reduced API addition

2018-11-20 Thread Paolo Bonzini
On 20/11/18 13:57, Igor Mammedov wrote: > On Mon, 19 Nov 2018 18:14:26 +0100 > Paolo Bonzini wrote: > >> On 19/11/18 16:31, Igor Mammedov wrote: >>> I've tried to give suggestions how to restructure series >>> on per patch basis. In my opinion it quite possible to split >>> series in several

Re: [Xen-devel] [Qemu-devel] [PATCH v5 00/24] ACPI reorganization for hardware-reduced API addition

2018-11-20 Thread Paolo Bonzini
On 19/11/18 19:14, Michael S. Tsirkin wrote: > On Mon, Nov 19, 2018 at 06:14:26PM +0100, Paolo Bonzini wrote: >> On 19/11/18 16:31, Igor Mammedov wrote: >>> I've tried to give suggestions how to restructure series >>> on per patch basis. In my opinion it quite possible to split >>> series in

Re: [Xen-devel] [PATCH v5 6/6] amd/iommu: skip bridge devices when updating IOMMU page tables

2018-11-20 Thread Woods, Brian
On Tue, Nov 20, 2018 at 09:45:13AM -0700, Jan Beulich wrote: > >>> On 20.11.18 at 17:01, wrote: > > Bridges are not behind an IOMMU, and are already special cased and > > skipped in amd_iommu_add_device. Apply the same special casing when > > updating page tables. > > > > This is required or

Re: [Xen-devel] [PATCH] x86/mem_access: move p2m_mem_access_sanity_check() from header

2018-11-20 Thread Tamas K Lengyel
On Tue, Nov 20, 2018 at 11:05 AM Razvan Cojocaru wrote: > > Move p2m_mem_access_sanity_check() from the asm-x86/mem_access.h > header, where it currently is declared inline, to > arch/x86/mm/mem_access.c. This allows source code that includes it > directly, or indirectly (such as

Re: [Xen-devel] [PATCH v1 3/8] kexec: export PG_offline to VMCOREINFO

2018-11-20 Thread Michael S. Tsirkin
On Mon, Nov 19, 2018 at 11:16:11AM +0100, David Hildenbrand wrote: > Right now, pages inflated as part of a balloon driver will be dumped > by dump tools like makedumpfile. While XEN is able to check in the > crash kernel whether a certain pfn is actuall backed by memory in the > hypervisor (see

Re: [Xen-devel] [PATCH v1 3/8] kexec: export PG_offline to VMCOREINFO

2018-11-20 Thread Dave Young
On 11/19/18 at 11:16am, David Hildenbrand wrote: > Right now, pages inflated as part of a balloon driver will be dumped > by dump tools like makedumpfile. While XEN is able to check in the > crash kernel whether a certain pfn is actuall backed by memory in the > hypervisor (see

Re: [Xen-devel] [PATCH v1 5/8] hv_balloon: mark inflated pages PG_offline

2018-11-20 Thread Pankaj Gupta
> > >> --- > > >> drivers/hv/hv_balloon.c | 14 -- > > >> 1 file changed, 12 insertions(+), 2 deletions(-) > > >> > > >> diff --git a/drivers/hv/hv_balloon.c b/drivers/hv/hv_balloon.c > > >> index 211f3fe3a038..47719862e57f 100644 > > >> --- a/drivers/hv/hv_balloon.c > > >> +++

Re: [Xen-devel] [PATCH v1 1/8] mm: balloon: update comment about isolation/migration/compaction

2018-11-20 Thread Michael S. Tsirkin
On Mon, Nov 19, 2018 at 11:16:09AM +0100, David Hildenbrand wrote: > Commit b1123ea6d3b3 ("mm: balloon: use general non-lru movable page > feature") reworked balloon handling to make use of the general > non-lru movable page feature. The big comment block in > balloon_compaction.h contains quite

[Xen-devel] [xen-unstable-smoke test] 130633: regressions - trouble: blocked/broken/fail/pass

2018-11-20 Thread osstest service owner
flight 130633 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/130633/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm broken build-amd64 6

Re: [Xen-devel] [PATCH v1 2/8] mm: convert PG_balloon to PG_offline

2018-11-20 Thread Pankaj Gupta
> > PG_balloon was introduced to implement page migration/compaction for pages > inflated in virtio-balloon. Nowadays, it is only a marker that a page is > part of virtio-balloon and therefore logically offline. > > We also want to make use of this flag in other balloon drivers - for > inflated

[Xen-devel] [linux-4.19 test] 130520: regressions - trouble: blocked/broken/fail/pass

2018-11-20 Thread osstest service owner
flight 130520 linux-4.19 real [real] http://logs.test-lab.xenproject.org/osstest/logs/130520/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64 broken build-arm64-pvops

Re: [Xen-devel] [PATCH v1 6/8] vmw_balloon: mark inflated pages PG_offline

2018-11-20 Thread Nadav Amit
Thanks for this patch! > On Nov 19, 2018, at 2:16 AM, David Hildenbrand wrote: > > Mark inflated and never onlined pages PG_offline, to tell the world that > the content is stale and should not be dumped. > > Cc: Xavier Deguillard > Cc: Nadav Amit > Cc: Arnd Bergmann > Cc: Greg

[Xen-devel] [xen-unstable-smoke test] 130629: regressions - trouble: blocked/broken/fail/pass

2018-11-20 Thread osstest service owner
flight 130629 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/130629/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm broken build-amd64 6

[Xen-devel] [xen-4.7-testing test] 130564: trouble: blocked/broken/fail/pass

2018-11-20 Thread osstest service owner
flight 130564 xen-4.7-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/130564/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-pvopsbroken build-arm64-xsm

Re: [Xen-devel] [PATCH v1 2/8] mm: convert PG_balloon to PG_offline

2018-11-20 Thread Michael S. Tsirkin
On Mon, Nov 19, 2018 at 11:16:10AM +0100, David Hildenbrand wrote: > PG_balloon was introduced to implement page migration/compaction for pages > inflated in virtio-balloon. Nowadays, it is only a marker that a page is > part of virtio-balloon and therefore logically offline. > > We also want to

Re: [Xen-devel] [PATCH 2/4] x86: correct instances of PGC_allocated clearing

2018-11-20 Thread Tamas K Lengyel
On Tue, Nov 20, 2018 at 10:12 AM Jan Beulich wrote: > > >>> On 20.11.18 at 17:59, wrote: > > On 20/11/2018 16:18, Jan Beulich wrote: > >> For domain heap pages assigned to a domain dropping the page reference > >> tied to PGC_allocated may not drop the last reference, as otherwise the > >>

Re: [Xen-devel] [PATCH 2/4] x86/pv: Remove deferred RDTSC{, P} handling in pv_emulate_privileged_op()

2018-11-20 Thread Jan Beulich
>>> On 15.11.18 at 22:47, wrote: > As noted in c/s 4999bf3e8b "x86/PV: use generic emulator for privileged > instruction handling", these hoops are jumped through to retain the older > behaviour, along with a note suggesting that we should reconsider things. > > It does not matter exactly when

Re: [Xen-devel] [PATCH v1 5/8] hv_balloon: mark inflated pages PG_offline

2018-11-20 Thread Pankaj Gupta
Hi David, > > Mark inflated and never onlined pages PG_offline, to tell the world that > the content is stale and should not be dumped. > > Cc: "K. Y. Srinivasan" > Cc: Haiyang Zhang > Cc: Stephen Hemminger > Cc: Kairui Song > Cc: Vitaly Kuznetsov > Cc: Andrew Morton > Cc: Matthew Wilcox

Re: [Xen-devel] [PATCH v5 05/24] hw: acpi: Implement XSDT support for RSDP

2018-11-20 Thread Igor Mammedov
On Mon, 19 Nov 2018 13:27:14 -0500 "Michael S. Tsirkin" wrote: > On Thu, Nov 08, 2018 at 03:16:23PM +0100, Igor Mammedov wrote: > > On Mon, 5 Nov 2018 02:40:28 +0100 > > Samuel Ortiz wrote: > > > > > XSDT is the 64-bit version of the legacy ACPI RSDT (Root System > > > Description Table).

Re: [Xen-devel] [PATCH v1 5/8] hv_balloon: mark inflated pages PG_offline

2018-11-20 Thread David Hildenbrand
On 20.11.18 09:45, Pankaj Gupta wrote: > > Hi David, > >> >> Mark inflated and never onlined pages PG_offline, to tell the world that >> the content is stale and should not be dumped. >> >> Cc: "K. Y. Srinivasan" >> Cc: Haiyang Zhang >> Cc: Stephen Hemminger >> Cc: Kairui Song >> Cc: Vitaly

Re: [Xen-devel] [PATCH V7 2/5] x86/mm: allocate logdirty_ranges for altp2ms

2018-11-20 Thread Jan Beulich
>>> On 19.11.18 at 18:26, wrote: > For now, only do allocation/deallocation; keeping them in sync > will be done in subsequent patches. > > Logdirty synchronization will only be done for active altp2ms; > so allocate logdirty rangesets (copying the host logdirty > rangeset) when an altp2m is

Re: [Xen-devel] [PATCH v5 01/47] x86emul: introduce IMPOSSIBLE()

2018-11-20 Thread Jan Beulich
>>> On 19.11.18 at 19:11, wrote: > On 19/11/2018 10:13, Jan Beulich wrote: >> @@ -8828,12 +8837,7 @@ x86_emulate( >> dst.type = OP_NONE; >> break; >> default: >> -if ( (d & DstMask) != DstMem ) >> -{ >> -

[Xen-devel] [xen-unstable bisection] complete test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict

2018-11-20 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict testid depriv-audit-qemu/create Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu

Re: [Xen-devel] [PATCH v5 19/24] hw: acpi: Retrieve the PCI bus from AcpiPciHpState

2018-11-20 Thread Igor Mammedov
On Mon, 19 Nov 2018 18:02:53 + "Boeuf, Sebastien" wrote: > On Mon, 2018-11-19 at 16:37 +0100, Igor Mammedov wrote: > > On Fri, 16 Nov 2018 19:42:08 + > > "Boeuf, Sebastien" wrote: > > > > > > > > Hi Igor, > > > > > > On Fri, 2018-11-16 at 10:39 +0100, Igor Mammedov wrote: > > > >

[Xen-devel] [xen-unstable-smoke test] 130585: trouble: blocked/broken/pass

2018-11-20 Thread osstest service owner
flight 130585 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/130585/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm broken

Re: [Xen-devel] [PATCH v3] tools: set Dom0 UUID if requested

2018-11-20 Thread Juergen Gross
On 20/11/2018 19:09, Wei Liu wrote: > Introduce XEN_DOM0_UUID in Xen's global configuration file. Make > xen-init-dom0 accept an extra argument for UUID. > > Signed-off-by: Wei Liu Reviewed-by: Juergen Gross Juergen ___ Xen-devel mailing list

Re: [Xen-devel] [PATCH v1 3/8] kexec: export PG_offline to VMCOREINFO

2018-11-20 Thread Baoquan He
On 11/19/18 at 11:16am, David Hildenbrand wrote: > diff --git a/kernel/crash_core.c b/kernel/crash_core.c > index 933cb3e45b98..093c9f917ed0 100644 > --- a/kernel/crash_core.c > +++ b/kernel/crash_core.c > @@ -464,6 +464,8 @@ static int __init crash_save_vmcoreinfo_init(void) >

Re: [Xen-devel] [PATCH 0/9] Use vm_insert_range

2018-11-20 Thread Souptick Joarder
On Thu, Nov 15, 2018 at 9:09 PM Souptick Joarder wrote: > > Previouly drivers have their own way of mapping range of > kernel pages/memory into user vma and this was done by > invoking vm_insert_page() within a loop. > > As this pattern is common across different drivers, it can > be generalized

[Xen-devel] [xen-unstable-smoke test] 130638: regressions - trouble: blocked/broken/fail/pass

2018-11-20 Thread osstest service owner
flight 130638 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/130638/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm broken build-amd64 6

[Xen-devel] [xen-unstable-smoke test] 130617: regressions - trouble: blocked/broken/fail/pass

2018-11-20 Thread osstest service owner
flight 130617 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/130617/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm broken build-arm64-xsm 4

Re: [Xen-devel] [Qemu-devel] [PATCH for-3.2 v3 02/14] qom: make interface types abstract

2018-11-20 Thread Laszlo Ersek
On 11/20/18 17:33, Igor Mammedov wrote: > On Wed, 7 Nov 2018 16:36:40 +0400 > Marc-André Lureau wrote: > >> Interfaces don't have instance, let's make the interface type really >> abstract to avoid confusion. >> >> Signed-off-by: Marc-André Lureau >> --- >>

[Xen-devel] [libvirt bisection] complete build-armhf-libvirt

2018-11-20 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job build-armhf-libvirt testid libvirt-build Tree: libvirt git://libvirt.org/libvirt.git Tree: libvirt_gnulib https://git.savannah.gnu.org/git/gnulib.git/ Tree: libvirt_keycodemapdb https://gitlab.com/keycodemap/keycodemapdb.git Tree: qemuu

[Xen-devel] Xen Security Advisory 275 v2 - insufficient TLB flushing / improper large page mappings with AMD IOMMUs

2018-11-20 Thread Xen . org security team
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory XSA-275 version 2 insufficient TLB flushing / improper large page mappings with AMD IOMMUs UPDATES IN VERSION 2 Public release. ISSUE DESCRIPTION

[Xen-devel] Xen Security Advisory 277 v2 - x86: incorrect error handling for guest p2m page removals

2018-11-20 Thread Xen . org security team
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory XSA-277 version 2 x86: incorrect error handling for guest p2m page removals UPDATES IN VERSION 2 Public release. ISSUE DESCRIPTION

[Xen-devel] Xen Security Advisory 279 v2 - x86: DoS from attempting to use INVPCID with a non-canonical addresses

2018-11-20 Thread Xen . org security team
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory XSA-279 version 2 x86: DoS from attempting to use INVPCID with a non-canonical addresses UPDATES IN VERSION 2 Public release. ISSUE DESCRIPTION

Re: [Xen-devel] [PATCH 1/4] x86: Begin to remove TSC mode PVRDTSCP

2018-11-20 Thread Andrew Cooper
On 19/11/2018 15:25, Jan Beulich wrote: On 15.11.18 at 22:47, wrote: >> For more historical context, see >> c/s c17b36d5dc792cfdf59b6de0213b168bec0af8e8 >> c/s 04656384a1b9714e43db850c51431008e23450d8 >> >> PVRDTSCP was an attempt to provide Xen-aware userspace with a stable >>

[Xen-devel] [xen-unstable-smoke test] 130591: trouble: blocked/broken/pass

2018-11-20 Thread osstest service owner
flight 130591 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/130591/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm broken

Re: [Xen-devel] [PATCH 4/4] x86/pv: Expose RDTSCP to PV guests

2018-11-20 Thread Andrew Cooper
On 20/11/2018 11:06, Jan Beulich wrote: On 15.11.18 at 22:47, wrote: >> The final remnanat of PVRDTSCP is that we would emulate RDTSCP even on >> hardware which lacked the instruction. RDTSCP is available on almost all >> 64-bit x86 hardware. >> >> Remove this emulation, drop the

[Xen-devel] [distros-debian-snapshot test] 75615: tolerable FAIL

2018-11-20 Thread Platform Team regression test user
flight 75615 distros-debian-snapshot real [real] http://osstest.xensource.com/osstest/logs/75615/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-amd64-current-netinst-pygrub 10 debian-di-install fail like 75591

Re: [Xen-devel] [Qemu-devel] [PATCH v5 00/24] ACPI reorganization for hardware-reduced API addition

2018-11-20 Thread Igor Mammedov
On Mon, 19 Nov 2018 18:14:26 +0100 Paolo Bonzini wrote: > On 19/11/18 16:31, Igor Mammedov wrote: > > I've tried to give suggestions how to restructure series > > on per patch basis. In my opinion it quite possible to split > > series in several smaller ones and it should really help with > >

[Xen-devel] Xen Security Advisory 276 v2 - resource accounting issues in x86 IOREQ server handling

2018-11-20 Thread Xen . org security team
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory XSA-276 version 2 resource accounting issues in x86 IOREQ server handling UPDATES IN VERSION 2 Public release. ISSUE DESCRIPTION

[Xen-devel] Xen Security Advisory 280 v2 - Fix for XSA-240 conflicts with shadow paging

2018-11-20 Thread Xen . org security team
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory XSA-280 version 2 Fix for XSA-240 conflicts with shadow paging UPDATES IN VERSION 2 Public release. ISSUE DESCRIPTION =

[Xen-devel] [xen-unstable-smoke test] 130601: trouble: blocked/broken/pass

2018-11-20 Thread osstest service owner
flight 130601 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/130601/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm broken

Re: [Xen-devel] [PATCH v4 10/19] xen: setup hypercall page for PVH

2018-11-20 Thread Juergen Gross
On 15/11/2018 09:33, Roger Pau Monné wrote: > On Fri, Nov 02, 2018 at 01:37:29PM +0100, Juergen Gross wrote: >> Add the needed code to setup the hypercall page for calling into the >> Xen hypervisor. >> >> Signed-off-by: Juergen Gross > > Thanks, LGTM, just one suggestion and one question. > >>

Re: [Xen-devel] [PATCH V7 3/5] x86/altp2m: fix display frozen when switching to a new view early

2018-11-20 Thread George Dunlap
> On Nov 20, 2018, at 9:12 AM, Jan Beulich wrote: > On 19.11.18 at 18:26, wrote: >> When an new altp2m view is created very early on guest boot, the >> display will freeze (although the guest will run normally). This >> may also happen on resizing the display. The reason is the way >>

Re: [Xen-devel] [PATCH v4 10/19] xen: setup hypercall page for PVH

2018-11-20 Thread Juergen Gross
On 09/11/2018 19:12, Daniel Kiper wrote: > On Fri, Nov 02, 2018 at 01:37:29PM +0100, Juergen Gross wrote: >> Add the needed code to setup the hypercall page for calling into the >> Xen hypervisor. >> >> Signed-off-by: Juergen Gross >> --- >> V3: grub_xen_early_halt->grub_xen_panic (Roger Pau

Re: [Xen-devel] [PATCH V7 2/5] x86/mm: allocate logdirty_ranges for altp2ms

2018-11-20 Thread Razvan Cojocaru
On 11/20/18 11:05 AM, Jan Beulich wrote: On 19.11.18 at 18:26, wrote: >> For now, only do allocation/deallocation; keeping them in sync >> will be done in subsequent patches. >> >> Logdirty synchronization will only be done for active altp2ms; >> so allocate logdirty rangesets (copying the

Re: [Xen-devel] [PATCH V7 2/5] x86/mm: allocate logdirty_ranges for altp2ms

2018-11-20 Thread Razvan Cojocaru
On 11/20/18 12:27 PM, Jan Beulich wrote: On 20.11.18 at 11:02, wrote: >> On 11/20/18 11:05 AM, Jan Beulich wrote: >> On 19.11.18 at 18:26, wrote: For now, only do allocation/deallocation; keeping them in sync will be done in subsequent patches. Logdirty

Re: [Xen-devel] [PATCH V7 3/5] x86/altp2m: fix display frozen when switching to a new view early

2018-11-20 Thread Razvan Cojocaru
On 11/20/18 11:12 AM, Jan Beulich wrote: On 19.11.18 at 18:26, wrote: >> When an new altp2m view is created very early on guest boot, the >> display will freeze (although the guest will run normally). This >> may also happen on resizing the display. The reason is the way >> Xen currently

Re: [Xen-devel] [PATCH v1 5/8] hv_balloon: mark inflated pages PG_offline

2018-11-20 Thread Pankaj Gupta
> >> --- > >> drivers/hv/hv_balloon.c | 14 -- > >> 1 file changed, 12 insertions(+), 2 deletions(-) > >> > >> diff --git a/drivers/hv/hv_balloon.c b/drivers/hv/hv_balloon.c > >> index 211f3fe3a038..47719862e57f 100644 > >> --- a/drivers/hv/hv_balloon.c > >> +++

Re: [Xen-devel] [PATCH V7 2/5] x86/mm: allocate logdirty_ranges for altp2ms

2018-11-20 Thread Jan Beulich
>>> On 20.11.18 at 11:02, wrote: > On 11/20/18 11:05 AM, Jan Beulich wrote: > On 19.11.18 at 18:26, wrote: >>> For now, only do allocation/deallocation; keeping them in sync >>> will be done in subsequent patches. >>> >>> Logdirty synchronization will only be done for active altp2ms; >>> so

Re: [Xen-devel] [PATCH 3/4] x86/msr: Handle MSR_TSC_AUX consistently for PV and HVM guests

2018-11-20 Thread Jan Beulich
>>> On 15.11.18 at 22:47, wrote: > @@ -1040,7 +1040,10 @@ static int hvm_load_cpu_ctxt(struct domain *d, > hvm_domain_context_t *h) > if ( hvm_funcs.tsc_scaling.setup ) > hvm_funcs.tsc_scaling.setup(v); > > -v->arch.hvm.msr_tsc_aux = ctxt.msr_tsc_aux; > +if (

Re: [Xen-devel] [PATCH] gic:vgic: avoid excessive conversions

2018-11-20 Thread Andrii Anisov
Hello Andre, I'm going to change "gic_raise_guest_irq()" function interface. Could you please comment my understanding of vgic-v3-its.c code below? So that I could fix it alongside the function interface change. On 16.11.18 18:45, Andrii Anisov wrote: diff --git

Re: [Xen-devel] [PATCH v1] bump XEN_DOMCTL_INTERFACE_VERSION

2018-11-20 Thread Jan Beulich
>>> On 20.11.18 at 11:56, wrote: > Without this change valgrind can not decide what variant of > xen_domctl_createdomain is provided as input. > > Fixes commit 4a83497635 ("xen/domctl: Merge set_max_evtchn into createdomain") > Fixes commit a903bf5233 ("tools: Pass grant table limits to >

[Xen-devel] [OSSTEST PATCH v2 3/3] production-config*: Update to fishdescriptor with chroot bugfix

2018-11-20 Thread Ian Jackson
Deployment note: I have copied this binary to the images directory in Cambridge and Massachusetts. The corresponding patch to chiark-utils is on its way to my upstream hat. CC: George Dunlap Signed-off-by: Ian Jackson --- production-config | 2 +- production-config-cambridge | 2 +-

[Xen-devel] [OSSTEST PATCH v2 2/3] ts-depriv-audit-qemu: chmod +x qemu's chroot

2018-11-20 Thread Ian Jackson
libxl creates this directory with mode 0. That prevents fishdescriptor from working. chmod it. This is OK for testing. CC: George Dunlap Signed-off-by: Ian Jackson --- ts-depriv-audit-qemu | 1 + 1 file changed, 1 insertion(+) diff --git a/ts-depriv-audit-qemu b/ts-depriv-audit-qemu index

[Xen-devel] [OSSTEST PATCH v2 1/3] ts-depriv-audit-qemu: Create complete /run/user in appropriate root

2018-11-20 Thread Ian Jackson
* Use mkdir -p, rather than trying to only create /run/user/$uid. That helps if /run and/or /run/user do not exist, as they do in libxl-made chroots with recent libxl (which gets qemu to chroot). * Do all of this in the root directory of the qemu process, not our own root directory. So it

Re: [Xen-devel] [PATCH V7 3/5] x86/altp2m: fix display frozen when switching to a new view early

2018-11-20 Thread Jan Beulich
>>> On 20.11.18 at 10:43, wrote: > >> On Nov 20, 2018, at 9:12 AM, Jan Beulich wrote: >> > On 19.11.18 at 18:26, wrote: >>> When an new altp2m view is created very early on guest boot, the >>> display will freeze (although the guest will run normally). This >>> may also happen on

Re: [Xen-devel] [PATCH V7 3/5] x86/altp2m: fix display frozen when switching to a new view early

2018-11-20 Thread Jan Beulich
>>> On 19.11.18 at 18:26, wrote: > When an new altp2m view is created very early on guest boot, the > display will freeze (although the guest will run normally). This > may also happen on resizing the display. The reason is the way > Xen currently (mis)handles logdirty VGA: it intentionally >

Re: [Xen-devel] Xen optimization

2018-11-20 Thread Andrii Anisov
Hello Stefano, On 01.11.18 22:20, Stefano Stabellini wrote: No, I haven't had any time. Aside from the Xen version, another difference is the interrupt source. I used the physical timer for testing. Could you share your approach for interrupts latency measurement? Are you using any HW

Re: [Xen-devel] [PATCH v4 3/5] vpci/msix: carve p2m hole for MSIX MMIO regions

2018-11-20 Thread Roger Pau Monné
On Mon, Nov 19, 2018 at 07:56:18AM -0700, Jan Beulich wrote: > >>> On 14.11.18 at 12:57, wrote: > > Make sure the MSIX MMIO regions don't have p2m entries setup, so that > > accesses to them trap into the hypervisor and can be handled by vpci. > > > > Commit 042678762 ("x86/iommu: add

Re: [Xen-devel] [PATCH] automation: fix debian-{stretch, unstable}-32-gcc-debug

2018-11-20 Thread Andrew Cooper
On 20/11/2018 14:10, Wei Liu wrote: > They should have used .gcc-x86-32-build-debug in the first place. > > Signed-off-by: Wei Liu Oops yes - Acked-by: Andrew Cooper > --- > This patch is trivial so I intend to commit it as soon as possible to > fix Gitlab CI. > --- > .gitlab-ci.yml | 4 ++--

Re: [Xen-devel] [PATCH 1/3] tools: update examples/README

2018-11-20 Thread Ian Jackson
Wei Liu writes ("[PATCH 1/3] tools: update examples/README"): > This file gets installed to the host system. > > This patch cleans it up: 1. remove things that don't exist anymore; 2. > change xm to xl; 3. fix xen-devel list address; 4. add things that are > missing. Acked-by: Ian Jackson

Re: [Xen-devel] [PATCH 2/3] tools/helpers: make gen_stub_json_config accept an UUID argument

2018-11-20 Thread Ian Jackson
Wei Liu writes ("[PATCH 2/3] tools/helpers: make gen_stub_json_config accept an UUID argument"): > If that's set, the stub is going to contain that UUID. Acked-by: Ian Jackson ___ Xen-devel mailing list Xen-devel@lists.xenproject.org

[Xen-devel] [PATCH] x86/vendor: Renumber the X86_VENDOR_ constants

2018-11-20 Thread Andrew Cooper
Make X86_VENDOR_UNKNOWN have the value 0 so a piece of zeroed memory can't get confused with X86_VENDOR_INTEL. No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monné --- xen/include/asm-x86/x86-vendors.h | 12 ++-- 1 file changed, 6

Re: [Xen-devel] [Qemu-devel] [PATCH for-3.2 v3 01/14] tests: qdev_prop_check_globals() doesn't return "all_used"

2018-11-20 Thread Igor Mammedov
On Wed, 7 Nov 2018 16:36:39 +0400 Marc-André Lureau wrote: > Instead, it returns 1 if an error was detected, which is the case for: > > /qdev/properties/dynamic/global/subprocess: > warning: global dynamic-prop-type-bad.prop3 has invalid class name > warning: global nohotplug-type.prop5=105

[Xen-devel] [PATCH] automation: fix debian-{stretch, unstable}-32-gcc-debug

2018-11-20 Thread Wei Liu
They should have used .gcc-x86-32-build-debug in the first place. Signed-off-by: Wei Liu --- This patch is trivial so I intend to commit it as soon as possible to fix Gitlab CI. --- .gitlab-ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.gitlab-ci.yml

Re: [Xen-devel] [PATCH] automation: fix debian-{stretch, unstable}-32-gcc-debug

2018-11-20 Thread Doug Goldstein
On Tue, Nov 20, 2018 at 02:10:02PM +, Wei Liu wrote: > They should have used .gcc-x86-32-build-debug in the first place. > > Signed-off-by: Wei Liu > --- > This patch is trivial so I intend to commit it as soon as possible to > fix Gitlab CI. Agreed. Acked-by: Doug Goldstein

[Xen-devel] [qemu-mainline test] 130548: regressions - trouble: blocked/broken/fail/pass

2018-11-20 Thread osstest service owner
flight 130548 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/130548/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64 broken build-arm64-pvops

Re: [Xen-devel] [PATCH 4/4] x86/pv: Expose RDTSCP to PV guests

2018-11-20 Thread Jan Beulich
>>> On 20.11.18 at 12:29, wrote: > On 20/11/2018 11:06, Jan Beulich wrote: > On 15.11.18 at 22:47, wrote: >>> The final remnanat of PVRDTSCP is that we would emulate RDTSCP even on >>> hardware which lacked the instruction. RDTSCP is available on almost all >>> 64-bit x86 hardware. >>> >>>

Re: [Xen-devel] [PATCH 4/8] xen/arm: Add support for read-only foreign mappings

2018-11-20 Thread Andrii Anisov
Hello Julien, It is me again. On 15.11.18 17:05, Julien Grall wrote: On 11/15/18 1:19 PM, Andrii Anisov wrote: So I would prefer to stick with _t which is quite common within the p2m code base so far. I've found a similar code only in one place - p2m_get_entry() function. And it is, at

Re: [Xen-devel] [PATCH 3/3] xen-init-dom0: set Dom0 UUID if requested

2018-11-20 Thread Ian Jackson
Wei Liu writes ("[PATCH 3/3] xen-init-dom0: set Dom0 UUID if requested"): > Read from XEN_CONFIG_DIR/dom0-uuid. If it contains a valid UUID, set > it for Dom0. I approve of the basic principle of this change. Thanks. However, I am not particularly keen on the details of the config

[Xen-devel] [PATCH v2 0/5] x86: Drop PVRDTSCP and fix MSR_TSC_AUX handling for guests

2018-11-20 Thread Andrew Cooper
Boris has confirmed that noone appears to be using PVRDTSCP any more, and in the decade since it was introduced, guest kernel / hardware support has provided a better alternative. For changes, see individual patches. Andrew Cooper (5): x86/time: Alter tsc_set_info() to return an error value

[Xen-devel] [PATCH v2 5/5] x86/pv: Expose RDTSCP to PV guests

2018-11-20 Thread Andrew Cooper
The final remnanat of PVRDTSCP is that we would emulate RDTSCP even on hardware which lacked the instruction. RDTSCP is available on almost all 64-bit x86 hardware. Remove this emulation, drop the TSC_MODE_PVRDTSCP constant, and allow RDTSCP in a PV guest's CPUID policy. Signed-off-by: Andrew

[Xen-devel] [PATCH v2 3/5] x86/pv: Remove deferred RDTSC{, P} handling in pv_emulate_privileged_op()

2018-11-20 Thread Andrew Cooper
As noted in c/s 4999bf3e8b "x86/PV: use generic emulator for privileged instruction handling", these hoops are jumped through to retain the older behaviour, along with a note suggesting that we should reconsider things. Part of the reason for retention of the old behaviour was removed by c/s

[Xen-devel] [PATCH v2 4/5] x86/msr: Handle MSR_TSC_AUX consistently for PV and HVM guests

2018-11-20 Thread Andrew Cooper
With PVRDTSCP mode removed, handling of MSR_TSC_AUX can move into the common code. Move its storage into struct vcpu_msrs (dropping the HVM-specific msr_tsc_aux), and add an RDPID feature check as this bit also enumerates the presence of the MSR. Introduce cpu_has_rdpid along with the

[Xen-devel] [PATCH v2 2/5] x86: Begin to remove TSC mode PVRDTSCP

2018-11-20 Thread Andrew Cooper
For more historical context, see c/s c17b36d5dc792cfdf59b6de0213b168bec0af8e8 c/s 04656384a1b9714e43db850c51431008e23450d8 PVRDTSCP was an attempt to provide Xen-aware userspace with a stable monotonic clock, and enough information for said userspace to cope with frequency changes across

[Xen-devel] [PATCH v2 1/5] x86/time: Alter tsc_set_info() to return an error value

2018-11-20 Thread Andrew Cooper
Currently, tsc_set_info() performs no parameter checking, and an invalid tsc_mode goes largely unnoticed. Fix it to reject invalid tsc_modes with -EINVAL, and update the callers to check the return value. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monné v2:

Re: [Xen-devel] [Qemu-devel] [PATCH 20/22] xen_backend: Convert sysbus init function to realize function

2018-11-20 Thread Peter Maydell
On 19 November 2018 at 12:08, Mao Zhongyi wrote: > Use DeviceClass rather than SysBusDeviceClass in > xen_sysdev_class_init(). > > Cc: sstabell...@kernel.org > Cc: anthony.per...@citrix.com > Cc: xen-devel@lists.xenproject.org > > Signed-off-by: Mao Zhongyi > Signed-off-by: Zhang Shengju > ---

[Xen-devel] [faster-by-no-jump-table] retpoline: disable jump tables

2018-11-20 Thread Norbert Manthey
To mitigate Meltdown, Xen has been fixed with a software fix, namely using retpoline sequences generated by the compiler. This way, indirect branches are protected against the attack. However, the retpoline sequence comes with a slow down. To make up for this, we propose to avoid jump tables in

[Xen-devel] [PATCH v5 2/6] vpci: fix deferral of long operations

2018-11-20 Thread Roger Pau Monne
Current logic to handle long running operations is flawed because it doesn't prevent the guest vcpu from running. Fix this by raising a scheduler softirq when preemption is required, so that the do_softirq call in the guest entry path performs a rescheduling. Also move the call to

[Xen-devel] [PATCH v5 4/6] pci: add a segment parameter to pci_hide_device

2018-11-20 Thread Roger Pau Monne
No functional change expected. Signed-off-by: Roger Pau Monné --- Cc: Andrew Cooper Cc: George Dunlap Cc: Ian Jackson Cc: Jan Beulich Cc: Julien Grall Cc: Konrad Rzeszutek Wilk Cc: Stefano Stabellini Cc: Tim Deegan Cc: Wei Liu --- Changes since v4: - New in this version. ---

[Xen-devel] [PATCH 0/4] XSA-276 follow-up

2018-11-20 Thread Jan Beulich
A few things I had run into while working on that issue: 1: mm: disallow MEMF_no_refcount to be passed for domain-owned allocations 2: x86: correct instances of PGC_allocated clearing 3: x86: reduce code duplication in guest_remove_page() 4: make domain_adjust_tot_pages() __must_check They don't

[Xen-devel] [PATCH 2/4] x86: correct instances of PGC_allocated clearing

2018-11-20 Thread Jan Beulich
For domain heap pages assigned to a domain dropping the page reference tied to PGC_allocated may not drop the last reference, as otherwise the test_and_clear_bit() might already act on an unowned page. Work around this where possible, but the need to acquire extra page references is a fair hint

[Xen-devel] [PATCH 3/4] x86: reduce code duplication in guest_remove_page()

2018-11-20 Thread Jan Beulich
Quite a bit of duplicate code has accumulated on the "paging" types special case path. Re-use what can be re-used from the common path. Since it needs touching anyway, slightly re-format and extend the gdprintk() on the common path as well. Signed-off-by: Jan Beulich --- a/xen/common/memory.c

Re: [Xen-devel] [PATCH v2 4/5] x86/msr: Handle MSR_TSC_AUX consistently for PV and HVM guests

2018-11-20 Thread Jan Beulich
>>> On 20.11.18 at 15:37, wrote: > With PVRDTSCP mode removed, handling of MSR_TSC_AUX can move into the common > code. Move its storage into struct vcpu_msrs (dropping the HVM-specific > msr_tsc_aux), and add an RDPID feature check as this bit also enumerates the > presence of the MSR. > >

Re: [Xen-devel] [Qemu-devel] [PATCH for-3.2 v3 02/14] qom: make interface types abstract

2018-11-20 Thread Igor Mammedov
On Wed, 7 Nov 2018 16:36:40 +0400 Marc-André Lureau wrote: > Interfaces don't have instance, let's make the interface type really > abstract to avoid confusion. > > Signed-off-by: Marc-André Lureau > --- > include/hw/acpi/acpi_dev_interface.h | 6 +- > include/hw/arm/linux-boot-if.h

Re: [Xen-devel] [PATCH 1/4] automation: introduce CONTAINER_NO_PULL for containerize

2018-11-20 Thread Doug Goldstein
On Mon, Nov 19, 2018 at 09:30:59PM +, Wei Liu wrote: > Signed-off-by: Wei Liu > --- > automation/build/README.md | 3 +++ > automation/scripts/containerize | 8 +--- > 2 files changed, 8 insertions(+), 3 deletions(-) > > diff --git a/automation/build/README.md

Re: [Xen-devel] [PATCH 2/4] automation: stash default config file for artifact extraction

2018-11-20 Thread Doug Goldstein
On Mon, Nov 19, 2018 at 09:31:00PM +, Wei Liu wrote: > Signed-off-by: Wei Liu > --- > .gitlab-ci.yml | 2 +- > automation/scripts/build | 3 +++ > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml > index 5678b552c4..28152e906d 100644

Re: [Xen-devel] [PATCH 3/4] automation: also specify xen binary as artifact on x86_64

2018-11-20 Thread Doug Goldstein
On Mon, Nov 19, 2018 at 09:31:01PM +, Wei Liu wrote: > ... so that it can be passed on to test stage. > > Note that xen is only extracted for x86_64 build since others may not > have that. Use a directory to account for possibly different file > names on Arm. > > Signed-off-by: Wei Liu

Re: [Xen-devel] [PATCH] x86/shadow: un-hide "full" auditing code

2018-11-20 Thread Andrew Cooper
On 20/11/2018 15:59, Jan Beulich wrote: > In particular sh_oos_audit() has become stale due to changes elsewhere, > and the need for adjustment was not noticed because both "full audit" > flags are off in both release and debug builds. Switch away from pre- > processsor conditionals, thus exposing

Re: [Xen-devel] [PATCH 1/4] mm: disallow MEMF_no_refcount to be passed for domain-owned allocations

2018-11-20 Thread Andrew Cooper
On 20/11/2018 16:17, Jan Beulich wrote: > When such pages get assigned to domains (and hence their ->tot_pages > not incremented accordingly) we would otherwise also need to suppress > decrementing the count when freeing those pages. > > Signed-off-by: Jan Beulich > > ---

Re: [Xen-devel] [PATCH 2/4] x86: correct instances of PGC_allocated clearing

2018-11-20 Thread Andrew Cooper
On 20/11/2018 16:18, Jan Beulich wrote: > For domain heap pages assigned to a domain dropping the page reference > tied to PGC_allocated may not drop the last reference, as otherwise the > test_and_clear_bit() might already act on an unowned page. > > Work around this where possible, but the need

  1   2   >