Re: [Xen-devel] [PATCH] xen: use struct_size() helper in kzalloc()

2019-04-03 Thread Juergen Gross
On 03/04/2019 07:26, Andrea Righi wrote: > struct privcmd_buf_vma_private has a zero-sized array at the end > (pages), use the new struct_size() helper to determine the proper > allocation size and avoid potential type mistakes. > > Signed-off-by: Andrea Righi Reviewed-by: Juergen Gross

[Xen-devel] [qemu-mainline test] 134240: regressions - trouble: blocked/broken/fail/pass

2019-04-03 Thread osstest service owner
flight 134240 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/134240/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64 broken build-arm64-pvops

[Xen-devel] [xen-unstable-smoke test] 134320: trouble: blocked/broken/pass

2019-04-03 Thread osstest service owner
flight 134320 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/134320/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm broken

Re: [Xen-devel] Performance Monitor and Profiling tools for ARM64

2019-04-03 Thread Diego Alejandro Parra Guzman
Hello Julien Grall thank you for your replied, you have clarified many of my doubts. I have been implementing some basic functionality for the PMU : Here small description: - getpmuinfo_attr : /* @brief get PMU info, including number of Counters, and control

[Xen-devel] [qemu-upstream-4.11-testing test] 134270: trouble: blocked/broken/fail/pass

2019-04-03 Thread osstest service owner
flight 134270 qemu-upstream-4.11-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/134270/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-pvopsbroken

Re: [Xen-devel] [PATCH] xen/tools: Fix symbols segfaults

2019-04-03 Thread Jan Beulich
>>> On 03.04.19 at 09:56, wrote: > The symbols tool is outdated and has a bug in it leading to crashes. > The tool is derived from linux kernel where this bug has been already > fixed. Thanks for noticing this omission of ours. > Original linux kernel commit: > e0a04b11e4059cab033469617

Re: [Xen-devel] [PATCH v4 01/15] x86/cpu: Create Hygon Dhyana architecture support file

2019-04-03 Thread Jan Beulich
>>> On 30.03.19 at 11:42, wrote: > +static void init_hygon(struct cpuinfo_x86 *c) > +{ > + unsigned long long value; > + > + /* Attempt to set LFENCE to be Dispatch Serialising. */ > + if (rdmsr_safe(MSR_AMD64_DE_CFG, value)) > + /* Unable to read. Assume the safer

Re: [Xen-devel] [PATCH 1/3] xen/cpu: Distinguish "cpu already in that state" in cpu_{up, down}()

2019-04-03 Thread Jan Beulich
>>> On 02.04.19 at 21:57, wrote: > All methods of querying the online state of a CPU are racy without the hotplug > lock held, which can lead to a TOCTOU race trying to online or offline CPUs. > > Distinguish this case with -EEXIST rather than -EINVAL, so the caller can take > other actions if

Re: [Xen-devel] [PATCH v2] public/io/blkif.h: try to fix the semantics of sector based quantities

2019-04-03 Thread Julien Grall
(+ Juergen as he maintains the PV I/O with Konrad) On 02/04/2019 17:58, Paul Durrant wrote: This is actually v2 of the patch posted in [1]. Please see the thread starting there for more context... Should not this belong after ---? The semantics of sector based quanties, such as first_sect

Re: [Xen-devel] [PATCH] xen/tools: Fix symbols segfaults

2019-04-03 Thread Wieczorkiewicz, Pawel
On 3. Apr 2019, at 10:10, Jan Beulich mailto:jbeul...@suse.com>> wrote: On 03.04.19 at 09:56, mailto:wipa...@amazon.de>> wrote: The symbols tool is outdated and has a bug in it leading to crashes. The tool is derived from linux kernel where this bug has been already fixed. Thanks for noticing

Re: [Xen-devel] [PATCH 2/3] x86/sysctl: Clean up XEN_SYSCTL_cpu_hotplug

2019-04-03 Thread Jan Beulich
>>> On 03.04.19 at 11:06, wrote: > On 03/04/2019 09:53, Jan Beulich wrote: > On 02.04.19 at 21:57, wrote: >>> --- a/xen/arch/x86/sysctl.c >>> +++ b/xen/arch/x86/sysctl.c >>> @@ -137,27 +137,35 @@ long arch_do_sysctl( >>> case XEN_SYSCTL_cpu_hotplug: >>> { >>> unsigned int

[Xen-devel] [PATCH] xen/tools: Fix symbols segfaults

2019-04-03 Thread Pawel Wieczorkiewicz
The symbols tool is outdated and has a bug in it leading to crashes. The tool is derived from linux kernel where this bug has been already fixed. Original linux kernel commit: e0a04b11e4059cab033469617 scripts/kallsyms.c: fix potential segfault Signed-off-by: Pawel Wieczorkiewicz Reviewed-by:

[Xen-devel] Ping: [PATCH v2] x86emul: avoid speculative out of bounds accesses

2019-04-03 Thread Jan Beulich
>>> On 07.02.19 at 12:42, wrote: > There are a few array accesses here the indexes of which are (at least > indirectly) driven by the guest. Use array_access_nospec() to bound > such accesses. In the {,_}decode_gpr() cases replace existing guarding > constructs. > > To deal with an otherwise

Re: [Xen-devel] [PATCH] xen/tools: Fix symbols segfaults

2019-04-03 Thread Wei Liu
On Wed, Apr 03, 2019 at 09:07:50AM +, Wieczorkiewicz, Pawel wrote: > I'm btw also confused by the Cc list you've used: You should > have Cc-ed THE REST, not just the tool stack maintainers. > > You’re right. My bad. Sorry. > ./scripts/get_maintainers.pl is your friend. :-) Wei.

[Xen-devel] [xen-4.8-testing test] 134268: regressions - trouble: blocked/broken/fail/pass

2019-04-03 Thread osstest service owner
flight 134268 xen-4.8-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/134268/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-pvopsbroken build-arm64-xsm

Re: [Xen-devel] [PATCH 2/4] xen/console: Don't treat NUL character as the end of the buffer

2019-04-03 Thread Jan Beulich
>>> On 02.04.19 at 19:49, wrote: > On 02/04/2019 17:42, Julien Grall wrote: >> diff --git a/xen/arch/arm/early_printk.c b/xen/arch/arm/early_printk.c >> index 97466a12b1..35a47c7229 100644 >> --- a/xen/arch/arm/early_printk.c >> +++ b/xen/arch/arm/early_printk.c >> @@ -17,9 +17,10 @@ >> void

Re: [Xen-devel] [PATCH 2/3] x86/sysctl: Clean up XEN_SYSCTL_cpu_hotplug

2019-04-03 Thread Jan Beulich
>>> On 02.04.19 at 21:57, wrote: > --- a/xen/arch/x86/sysctl.c > +++ b/xen/arch/x86/sysctl.c > @@ -137,27 +137,35 @@ long arch_do_sysctl( > case XEN_SYSCTL_cpu_hotplug: > { > unsigned int cpu = sysctl->u.cpu_hotplug.cpu; > +bool plug; > +long (*fn)(void *) =

Re: [Xen-devel] [PATCH 2/3] x86/sysctl: Clean up XEN_SYSCTL_cpu_hotplug

2019-04-03 Thread Andrew Cooper
On 03/04/2019 09:53, Jan Beulich wrote: On 02.04.19 at 21:57, wrote: >> --- a/xen/arch/x86/sysctl.c >> +++ b/xen/arch/x86/sysctl.c >> @@ -137,27 +137,35 @@ long arch_do_sysctl( >> case XEN_SYSCTL_cpu_hotplug: >> { >> unsigned int cpu = sysctl->u.cpu_hotplug.cpu; >> +

[Xen-devel] [xen-unstable-coverity test] 134335: regressions - ALL FAIL

2019-04-03 Thread osstest service owner
flight 134335 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/134335/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: coverity-amd647 coverity-upload fail REGR. vs. 133615 version

[Xen-devel] [PATCH] x86/altp2m: treat view 0 as the hostp2m in p2m_get_mem_access()

2019-04-03 Thread Razvan Cojocaru
p2m_set_mem_access() (and other places) treat view 0 as the hostp2m, but p2m_get_mem_access() does not. Correct that inconsistency. Signed-off-by: Razvan Cojocaru --- xen/arch/x86/mm/mem_access.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/mm/mem_access.c

Re: [Xen-devel] [PATCH v2] public/io/blkif.h: try to fix the semantics of sector based quantities

2019-04-03 Thread Paul Durrant
> -Original Message- > From: Julien Grall [mailto:julien.gr...@arm.com] > Sent: 03 April 2019 10:08 > To: Paul Durrant ; xen-devel@lists.xenproject.org > Cc: Konrad Rzeszutek Wilk ; Roger Pau Monne > ; Anthony > Perard ; Andrew Cooper > ; George Dunlap > ; Ian Jackson ; Jan Beulich > ;

[Xen-devel] [qemu-upstream-4.10-testing test] 134271: regressions - trouble: blocked/broken/fail/pass

2019-04-03 Thread osstest service owner
flight 134271 qemu-upstream-4.10-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/134271/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm broken build-arm64-pvops

Re: [Xen-devel] [PATCH 3/3] x86/smt: Support for enabling/disabling SMT at runtime

2019-04-03 Thread Jan Beulich
>>> On 02.04.19 at 21:57, wrote: > Currently, a user can in combine the output of `xl info -n`, the APCI tables, > and some manual CPUID data to figure out which CPU numbers to feed into > `xen-hptool cpu-offline` to effectively disable SMT at runtime. > > A more convenient option is to teach

Re: [Xen-devel] [PATCH 3/3] x86/smt: Support for enabling/disabling SMT at runtime

2019-04-03 Thread Jan Beulich
>>> On 03.04.19 at 12:17, wrote: > On 03/04/2019 10:33, Jan Beulich wrote: > On 02.04.19 at 21:57, wrote: >>> Slightly RFC. I'm not very happy with the contination situation, but -EBUSY >>> is the preexisting style and it seems like it is the only option from >>> tasklet >>> context. >>

Re: [Xen-devel] [PATCH v4 01/15] x86/cpu: Create Hygon Dhyana architecture support file

2019-04-03 Thread Pu Wen
On 2019/4/3 16:43, Jan Beulich wrote: On 30.03.19 at 11:42, wrote: +static void init_hygon(struct cpuinfo_x86 *c) +{ + unsigned long long value; + + /* Attempt to set LFENCE to be Dispatch Serialising. */ + if (rdmsr_safe(MSR_AMD64_DE_CFG, value)) + /* Unable to

[Xen-devel] Ping: [PATCH 0/5] x86: more power-efficient CPU parking

2019-04-03 Thread Jan Beulich
>>> On 01.08.18 at 16:22, wrote: > When putting CPUs to sleep permanently, we should try to put them into > the most power conserving state possible. For now it is unclear whether, > especially in a deep C-state, the P-state also matters, so this series only > arranges for the C-state side of

Re: [Xen-devel] [PATCH 3/3] x86/smt: Support for enabling/disabling SMT at runtime

2019-04-03 Thread Andrew Cooper
On 03/04/2019 10:33, Jan Beulich wrote: On 02.04.19 at 21:57, wrote: >> Currently, a user can in combine the output of `xl info -n`, the APCI tables, >> and some manual CPUID data to figure out which CPU numbers to feed into >> `xen-hptool cpu-offline` to effectively disable SMT at runtime.

[Xen-devel] [distros-debian-squeeze test] 83863: trouble: blocked/broken

2019-04-03 Thread Platform Team regression test user
flight 83863 distros-debian-squeeze real [real] http://osstest.xensource.com/osstest/logs/83863/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-pvopsbroken build-i386

Re: [Xen-devel] Ping: [PATCH 0/5] x86: more power-efficient CPU parking

2019-04-03 Thread Andrew Cooper
On 03/04/2019 11:12, Jan Beulich wrote: On 01.08.18 at 16:22, wrote: >> When putting CPUs to sleep permanently, we should try to put them into >> the most power conserving state possible. For now it is unclear whether, >> especially in a deep C-state, the P-state also matters, so this series

Re: [Xen-devel] [PATCH v2 1/1] treewide: Switch printk users from %pf and %pF to %ps and %pS, respectively

2019-04-03 Thread Sakari Ailus
Ping. On Tue, Mar 26, 2019 at 02:35:10PM +0100, Petr Mladek wrote: > Linus, > > On Mon 2019-03-25 21:32:28, Sakari Ailus wrote: > > %pF and %pf are functionally equivalent to %pS and %ps conversion > > specifiers. The former are deprecated, therefore switch the current users > > to use the

Re: [Xen-devel] [PATCH 3/3] x86/smt: Support for enabling/disabling SMT at runtime

2019-04-03 Thread Andrew Cooper
On 03/04/2019 11:44, Jan Beulich wrote: On 03.04.19 at 12:17, wrote: >> On 03/04/2019 10:33, Jan Beulich wrote: >> On 02.04.19 at 21:57, wrote: Slightly RFC. I'm not very happy with the contination situation, but -EBUSY is the preexisting style and it seems like it is

Re: [Xen-devel] [PATCH 4/4] xen/console: Simplify domU console handling in guest_console_write

2019-04-03 Thread Wei Liu
On Tue, Apr 02, 2019 at 05:42:38PM +0100, Julien Grall wrote: > 2 paths in the domU console handling are now the same. So they can be > merged to make the code simpler. > > Signed-off-by: Julien Grall Acked-by: Wei Liu (This obviously is dependent on the acceptance of patch 2)

Re: [Xen-devel] Problems with qemu when building with --enable-githttp

2019-04-03 Thread Wei Liu
On Mon, Apr 01, 2019 at 10:27:42AM -0600, Tamas K Lengyel wrote: > Hi all, > I'm trying to compile RELEASE-4.12.0 branch with --enable-githttp on a > network that blocks normal git accesses and I encountered the > following failures: > > fatal: clone of 'git://git.qemu.org/capstone.git' into

Re: [Xen-devel] soft reset support on Arm (Was: Re: 回复:回复:Re: Xen ARM Fault recovery for automotive use case)

2019-04-03 Thread Wei Liu
On Thu, Mar 21, 2019 at 06:20:42PM +, Julien Grall wrote: > (+ Stefano, Wei and Ian) > > Hello, > > Apologies for the late answer. > > First of all, please avoid sending e-mail using HTML encoding. E-mail on > mailing should only be plain text. > > On 3/20/19 9:28 AM, rambl...@sina.com

Re: [Xen-devel] [PATCH v4 01/15] x86/cpu: Create Hygon Dhyana architecture support file

2019-04-03 Thread Jan Beulich
>>> On 03.04.19 at 12:05, wrote: > On 2019/4/3 16:43, Jan Beulich wrote: >> On 30.03.19 at 11:42, wrote: >>> +static void init_hygon(struct cpuinfo_x86 *c) >>> +{ >>> + unsigned long long value; >>> + >>> + /* Attempt to set LFENCE to be Dispatch Serialising. */ >>> + if

Re: [Xen-devel] [PATCH 1/4] xen/console: Properly buffer domU output when using CONSOLEIO_write

2019-04-03 Thread Wei Liu
On Tue, Apr 02, 2019 at 05:42:35PM +0100, Julien Grall wrote: > The output will be buffered if the buffer provided by the DomU does not > contain a newline. This can also happen if buffer provided by DomU is > split in multiple part (Xen can only process 127 characters at the time). > > As Xen

Re: [Xen-devel] [PATCH 3/4] xen/public: Document HYPERCALL_console_io()

2019-04-03 Thread Wei Liu
On Tue, Apr 02, 2019 at 05:42:37PM +0100, Julien Grall wrote: > Currently, OS developpers will have to look at Xen code in order to know > the parameters of an hypercall and how it is meant to work. > > This is not a trivial task as you may need to have a deep understanding > of Xen internal. >

Re: [Xen-devel] [PATCH v1] Fix p2m_set_suppress_ve

2019-04-03 Thread Razvan Cojocaru
On 4/3/19 5:58 PM, Jan Beulich wrote: On 03.04.19 at 16:29, wrote: --- a/xen/arch/x86/mm/p2m.c +++ b/xen/arch/x86/mm/p2m.c @@ -3011,8 +3011,16 @@ int p2m_set_suppress_ve(struct domain *d, gfn_t gfn, bool suppress_ve, mfn = p2m->get_entry(p2m, gfn, , , 0, NULL, NULL); if (

Re: [Xen-devel] [PATCH] automation: Add a Arch Linux dockerfile

2019-04-03 Thread Wei Liu
On Wed, Apr 03, 2019 at 05:05:17PM +0100, Anthony PERARD wrote: > Signed-off-by: Anthony PERARD Have you pushed the container to xen project's registry? If so, can you confirm it runs ok? Wei. ___ Xen-devel mailing list Xen-devel@lists.xenproject.org

[Xen-devel] [PATCH] x86/pv: Drop redundant CONFIG_PV ifdefary

2019-04-03 Thread Andrew Cooper
These were made redundant by c/s 23058e7b3 "x86/shadow: put PV L1TF functions under CONFIG_PV" but makes the code read as if outside of the ifdef. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monné --- xen/include/asm-x86/shadow.h | 4 ++-- 1 file changed, 2

[Xen-devel] [ovmf baseline-only test] 83865: trouble: blocked/broken

2019-04-03 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 83865 ovmf real [real] http://osstest.xensource.com/osstest/logs/83865/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm

[Xen-devel] [xen-unstable-smoke test] 134354: trouble: blocked/broken/pass

2019-04-03 Thread osstest service owner
flight 134354 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/134354/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm broken

[Xen-devel] [linux-4.9 test] 134279: regressions - trouble: blocked/broken/fail/pass

2019-04-03 Thread osstest service owner
flight 134279 linux-4.9 real [real] http://logs.test-lab.xenproject.org/osstest/logs/134279/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-pvopsbroken build-arm64-xsm

Re: [Xen-devel] [PATCH 1/4] x86: suppress XPTI-related TLB flushes when possible

2019-04-03 Thread Andrew Cooper
On 13/03/2019 12:38, Jan Beulich wrote: > When there's no XPTI-enabled PV domain at all, there's no need to issue > respective TLB flushes. Hardwire opt_xpti_* to false when !PV, and > record the creation of PV domains by bumping opt_xpti_* accordingly. > > Signed-off-by: Jan Beulich > --- > TBD:

Re: [Xen-devel] Ping: [PATCH 0/5] x86: more power-efficient CPU parking

2019-04-03 Thread Jan Beulich
>>> On 03.04.19 at 16:44, wrote: > On 03/04/2019 13:43, Jan Beulich wrote: > On 03.04.19 at 13:14, wrote: >>> On 03/04/2019 11:12, Jan Beulich wrote: >>> On 01.08.18 at 16:22, wrote: > When putting CPUs to sleep permanently, we should try to put them into > the most power

Re: [Xen-devel] [PATCH v4 00/15] Add support for Hygon Dhyana Family 18h processor

2019-04-03 Thread Pu Wen
On 2019/4/3 0:15, Jan Beulich wrote: > On 02.04.19 at 18:00, wrote: >> On 2019/4/2 23:14, Andrew Cooper wrote: >>> On 30/03/2019 10:40, Pu Wen wrote: This patch series have been applied and tested successfully on Hygon Dhyana processor, also been tested on AMD EPYC (family 17h)

Re: [Xen-devel] [PATCH v1] Fix p2m_set_suppress_ve

2019-04-03 Thread Jan Beulich
>>> On 03.04.19 at 17:17, wrote: > On 4/3/19 5:58 PM, Jan Beulich wrote: > On 03.04.19 at 16:29, wrote: >>> --- a/xen/arch/x86/mm/p2m.c >>> +++ b/xen/arch/x86/mm/p2m.c >>> @@ -3011,8 +3011,16 @@ int p2m_set_suppress_ve(struct domain *d, gfn_t gfn, >>> bool suppress_ve, >>> mfn =

[Xen-devel] Suspicious code in p2m_set_altp2m_mem_access

2019-04-03 Thread Alexandru Stefan ISAILA
Hi all, I came across some code in the p2m_set_altp2m_mem_access() that does not seem right. On the invalid mfn branch there is a try to set_entry() and if that is not successful then the function does not return and calls set_entry again for PAGE_ORDER_4K even if there was a check that page

[Xen-devel] [PATCH] automation: Add a Arch Linux dockerfile

2019-04-03 Thread Anthony PERARD
Signed-off-by: Anthony PERARD --- automation/build/archlinux/current.dockerfile | 52 +++ 1 file changed, 52 insertions(+) create mode 100644 automation/build/archlinux/current.dockerfile diff --git a/automation/build/archlinux/current.dockerfile

Re: [Xen-devel] [PATCH v1] Fix p2m_set_suppress_ve

2019-04-03 Thread Jan Beulich
>>> On 03.04.19 at 17:48, wrote: > On 4/3/19 6:30 PM, Jan Beulich wrote: > On 03.04.19 at 17:17, wrote: >>> Changes to the hostp2m (also known as altp2m view 0) propagate to all >>> existing altp2ms, but they do so in a lazy manner, and also that won't >>> happen for altp2ms created after a

Re: [Xen-devel] [PATCH v1] Fix p2m_set_suppress_ve

2019-04-03 Thread Tamas K Lengyel
On Wed, Apr 3, 2019 at 10:06 AM Jan Beulich wrote: > > >>> On 03.04.19 at 17:48, wrote: > > On 4/3/19 6:30 PM, Jan Beulich wrote: > > On 03.04.19 at 17:17, wrote: > >>> Changes to the hostp2m (also known as altp2m view 0) propagate to all > >>> existing altp2ms, but they do so in a lazy

Re: [Xen-devel] [PATCH] automation: Add a Arch Linux dockerfile

2019-04-03 Thread Anthony PERARD
On Wed, Apr 03, 2019 at 05:19:10PM +0100, Wei Liu wrote: > On Wed, Apr 03, 2019 at 05:05:17PM +0100, Anthony PERARD wrote: > > Signed-off-by: Anthony PERARD > > Have you pushed the container to xen project's registry? If so, can you I haven't, no. > confirm it runs ok? It works for me :-).

Re: [Xen-devel] [PATCH v1] Fix p2m_set_suppress_ve

2019-04-03 Thread Tamas K Lengyel
On Wed, Apr 3, 2019 at 11:08 AM Razvan Cojocaru wrote: > > On 4/3/19 7:16 PM, Tamas K Lengyel wrote: > > It is right to fully populate a slot when for example we want > > different mem_access permissions in different altp2m views. We can't > > wait for the domain to on-demand populate the altp2m

Re: [Xen-devel] Suspicious code in p2m_set_altp2m_mem_access

2019-04-03 Thread George Dunlap
> On Apr 3, 2019, at 3:52 PM, Alexandru Stefan ISAILA > wrote: > > Hi all, > > I came across some code in the p2m_set_altp2m_mem_access() that does not > seem right. On the invalid mfn branch there is a try to set_entry() and > if that is not successful then the function does not return

Re: [Xen-devel] [PATCH v4 01/15] x86/cpu: Create Hygon Dhyana architecture support file

2019-04-03 Thread Pu Wen
On 2019/4/3 18:22, Jan Beulich wrote: On 03.04.19 at 12:05, wrote: I'm a little confused about which style to follow? In v3 series I followed the style of the derived code. But in other patch you told me to follow the Xen coding style, so in v4 series I changed the style to match the bracing

Re: [Xen-devel] [PATCH v1] Fix p2m_set_suppress_ve

2019-04-03 Thread Razvan Cojocaru
On 4/3/19 6:30 PM, Jan Beulich wrote: On 03.04.19 at 17:17, wrote: Changes to the hostp2m (also known as altp2m view 0) propagate to all existing altp2ms, but they do so in a lazy manner, and also that won't happen for altp2ms created after a while. So altp2ms will not necessarily know about a

[Xen-devel] [xen-unstable-smoke test] 134327: trouble: blocked/broken/pass

2019-04-03 Thread osstest service owner
flight 134327 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/134327/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm broken

Re: [Xen-devel] [PATCH 2/4] x86: relax a few get_gfn() invocations

2019-04-03 Thread Andrew Cooper
On 13/03/2019 12:38, Jan Beulich wrote: > In a few cases only a query is intended, i.e. without populating a > possible PoD or paged out entry, when the intention is to replace the > current entry anyway. Use get_gfn_query() there instead. > > Signed-off-by: Jan Beulich Reviewed-by: Andrew

Re: [Xen-devel] [PATCH 3/4] x86/mm: drop redundant local variable from _get_page_type()

2019-04-03 Thread Andrew Cooper
On 13/03/2019 12:38, Jan Beulich wrote: > Instead of the separate iommu_ret, the general rc can be used even for > the IOMMU operations. > > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper ___ Xen-devel mailing list

Re: [Xen-devel] Ping: [PATCH 0/5] x86: more power-efficient CPU parking

2019-04-03 Thread Andrew Cooper
On 03/04/2019 13:43, Jan Beulich wrote: On 03.04.19 at 13:14, wrote: >> On 03/04/2019 11:12, Jan Beulich wrote: >> On 01.08.18 at 16:22, wrote: When putting CPUs to sleep permanently, we should try to put them into the most power conserving state possible. For now it is

Re: [Xen-devel] [PATCH v1] Fix p2m_set_suppress_ve

2019-04-03 Thread Jan Beulich
>>> On 03.04.19 at 16:29, wrote: > --- a/xen/arch/x86/mm/p2m.c > +++ b/xen/arch/x86/mm/p2m.c > @@ -3011,8 +3011,16 @@ int p2m_set_suppress_ve(struct domain *d, gfn_t gfn, > bool suppress_ve, > mfn = p2m->get_entry(p2m, gfn, , , 0, NULL, NULL); > if ( !mfn_valid(mfn) ) > { > -

Re: [Xen-devel] [PATCH v4 00/15] Add support for Hygon Dhyana Family 18h processor

2019-04-03 Thread Jan Beulich
>>> On 03.04.19 at 17:21, wrote: > On 2019/4/3 0:15, Jan Beulich wrote: >> On 02.04.19 at 18:00, wrote: >>> On 2019/4/2 23:14, Andrew Cooper wrote: On 30/03/2019 10:40, Pu Wen wrote: > This patch series have been applied and tested successfully on Hygon > Dhyana processor, also been

Re: [Xen-devel] [PATCH v1] Fix p2m_set_suppress_ve

2019-04-03 Thread Razvan Cojocaru
On 4/3/19 7:04 PM, Jan Beulich wrote: On 03.04.19 at 17:48, wrote: >> On 4/3/19 6:30 PM, Jan Beulich wrote: >> On 03.04.19 at 17:17, wrote: Changes to the hostp2m (also known as altp2m view 0) propagate to all existing altp2ms, but they do so in a lazy manner, and also that

[Xen-devel] [PATCH v2] automation: Add Arch Linux container and build jobs

2019-04-03 Thread Anthony PERARD
One particularity of Arch Linux, /usr/bin/python is python3. Signed-off-by: Anthony PERARD --- Notes: v2: - Add the gitlab build stuff - update containerize with new shortcut - This time, the container is already pushed to the registry one pipeline with the archlinux-* jobs:

[Xen-devel] [PATCH] amd-iommu: Fix Guest CR3 Table following c/s 3a7947b6901

2019-04-03 Thread Andrew Cooper
"amd-iommu: use a bitfield for DTE" renamed iommu_dte_set_guest_cr3()'s gcr3 parameter to gcr3_mfn but ended up with an off-by-PAGE_SIZE error when extracting bits from the address. First of all, get_guest_cr3_from_dte() and iommu_dte_set_guest_cr3() are (almost) getters and setters for the same

[Xen-devel] [PATCH 0/2] docs: Improve coverage docs

2019-04-03 Thread Andrew Cooper
This was identified IRL at the safety summit, so I took the opportunity to improve things. The result of this series, and some other in-development bits, can be found at: https://andrewcoop-xen.readthedocs.io/en/docs-devel/index.html Andrew Cooper (2): docs/sphinx: Introduce a hypervisor

[Xen-devel] [PATCH 1/2] docs/sphinx: Introduce a hypervisor guide section

2019-04-03 Thread Andrew Cooper
Include (and retrofit to the user guide) an introductory paragraph describing the intended audience. Signed-off-by: Andrew Cooper --- CC: George Dunlap CC: Ian Jackson CC: Jan Beulich CC: Konrad Rzeszutek Wilk CC: Stefano Stabellini CC: Tim Deegan CC: Wei Liu CC: Julien Grall ---

Re: [Xen-devel] [PATCH] automation: Add a Arch Linux dockerfile

2019-04-03 Thread Wei Liu
On Wed, Apr 03, 2019 at 05:26:45PM +0100, Anthony PERARD wrote: > On Wed, Apr 03, 2019 at 05:19:10PM +0100, Wei Liu wrote: > > On Wed, Apr 03, 2019 at 05:05:17PM +0100, Anthony PERARD wrote: > > > Signed-off-by: Anthony PERARD > > > > Have you pushed the container to xen project's registry? If

[Xen-devel] [PATCH v1] Fix p2m_set_suppress_ve

2019-04-03 Thread Alexandru Stefan ISAILA
On a new altp2m view the p2m_set_suppress_ve() func will fail with invalid mfn from p2m->get_entry() if the p2m->set_entry() was not called before. This patch solves the problem by getting the mfn from __get_gfn_type_access() and then returning error if the mfn is invalid. Signed-off-by:

[Xen-devel] [PATCH 2/2] docs/hypervisor-guide: Code Coverage

2019-04-03 Thread Andrew Cooper
During a discussion in person, it was identified that Coverage doesn't currently work for ARM yet. Also, there are a number of errors with the existing coverage document. Take the opportunity to rewrite it in RST, making it easier to follow for a non-expert user. Signed-off-by: Andrew Cooper

Re: [Xen-devel] [PATCH v1] Fix p2m_set_suppress_ve

2019-04-03 Thread Razvan Cojocaru
On 4/3/19 7:16 PM, Tamas K Lengyel wrote: > It is right to fully populate a slot when for example we want > different mem_access permissions in different altp2m views. We can't > wait for the domain to on-demand populate the altp2m view because we > don't know when (and if) that will actually

Re: [Xen-devel] [PATCH 4/4] x86/PV: remove unnecessary toggle_guest_pt() overhead

2019-04-03 Thread Andrew Cooper
On 13/03/2019 12:39, Jan Beulich wrote: > While the mere updating of ->pv_cr3 and ->root_pgt_changed aren't overly > expensive (but still needed only for the toggle_guest_mode() path), the > effect of the latter on the exit-to-guest path is not insignificant. > Move the logic into

[Xen-devel] [linux-linus test] 134286: regressions - trouble: blocked/broken/fail/pass

2019-04-03 Thread osstest service owner
flight 134286 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/134286/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm broken build-arm64

Re: [Xen-devel] [PATCH v2] automation: Add Arch Linux container and build jobs

2019-04-03 Thread Doug Goldstein
> On Apr 3, 2019, at 12:33 PM, Anthony PERARD wrote: > > One particularity of Arch Linux, /usr/bin/python is python3. > > Signed-off-by: Anthony PERARD Acked-by: Doug Goldstein ___ Xen-devel mailing list Xen-devel@lists.xenproject.org

[Xen-devel] [xen-unstable-smoke test] 134360: trouble: blocked/broken/pass

2019-04-03 Thread osstest service owner
flight 134360 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/134360/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm broken

[Xen-devel] [xen-unstable-smoke test] 134368: trouble: blocked/broken/pass

2019-04-03 Thread osstest service owner
flight 134368 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/134368/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm broken

[Xen-devel] [libvirt test] 134252: trouble: blocked/broken/pass

2019-04-03 Thread osstest service owner
flight 134252 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/134252/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-pvopsbroken build-arm64

[Xen-devel] [xen-unstable test] 134248: regressions - trouble: blocked/broken/fail/pass

2019-04-03 Thread osstest service owner
flight 134248 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/134248/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm broken build-arm64-pvops

[Xen-devel] [linux-3.18 bisection] complete test-amd64-i386-examine

2019-04-03 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-i386-examine testid reboot Tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git

[Xen-devel] [xen-4.9-testing test] 134283: regressions - trouble: blocked/broken/fail/pass

2019-04-03 Thread osstest service owner
flight 134283 xen-4.9-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/134283/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm broken build-arm64-pvops

[Xen-devel] [ovmf test] 134282: all pass - PUSHED

2019-04-03 Thread osstest service owner
flight 134282 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/134282/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf b02873340b2de5c2fe8325d22214cd3a5b21c5e5 baseline version: ovmf

Re: [Xen-devel] [PATCH 3/3] x86/smt: Support for enabling/disabling SMT at runtime

2019-04-03 Thread Jan Beulich
>>> On 03.04.19 at 13:33, wrote: > On 03/04/2019 11:44, Jan Beulich wrote: > On 03.04.19 at 12:17, wrote: >>> On 03/04/2019 10:33, Jan Beulich wrote: >>> On 02.04.19 at 21:57, wrote: > Slightly RFC. I'm not very happy with the contination situation, but > -EBUSY > is the

Re: [Xen-devel] [PATCH 3/4] xen/public: Document HYPERCALL_console_io()

2019-04-03 Thread Jan Beulich
>>> On 02.04.19 at 18:42, wrote: > --- a/xen/include/public/xen.h > +++ b/xen/include/public/xen.h > @@ -97,6 +97,7 @@ DEFINE_XEN_GUEST_HANDLE(xen_ulong_t); > #define __HYPERVISOR_set_timer_op 15 > #define __HYPERVISOR_event_channel_op_compat 16 /* compat since 0x00030202 */ > #define

Re: [Xen-devel] Ping: [PATCH 0/5] x86: more power-efficient CPU parking

2019-04-03 Thread Jan Beulich
>>> On 03.04.19 at 13:14, wrote: > On 03/04/2019 11:12, Jan Beulich wrote: > On 01.08.18 at 16:22, wrote: >>> When putting CPUs to sleep permanently, we should try to put them into >>> the most power conserving state possible. For now it is unclear whether, >>> especially in a deep C-state,

Re: [Xen-devel] [PATCH] x86/altp2m: treat view 0 as the hostp2m in p2m_get_mem_access()

2019-04-03 Thread Tamas K Lengyel
On Wed, Apr 3, 2019 at 2:56 AM Razvan Cojocaru wrote: > > p2m_set_mem_access() (and other places) treat view 0 as the > hostp2m, but p2m_get_mem_access() does not. Correct that > inconsistency. > > Signed-off-by: Razvan Cojocaru Acked-by: Tamas K Lengyel