[Xen-devel] [linux-linus test] 142539: regressions - FAIL

2019-10-11 Thread osstest service owner
flight 142539 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/142539/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-freebsd10-i386 7 xen-boot fail REGR. vs. 133580

Re: [Xen-devel] [RFC] Documentation formats, licenses and file system structure

2019-10-11 Thread Jan Beulich
On 10.10.2019 20:30, Lars Kurth wrote: > On 10/10/2019, 18:05, "Andrew Cooper" wrote: > On 10/10/2019 13:34, Lars Kurth wrote: > > Existing formats and licenses > > * Hypercall ABI Documentation generated from Xen public headers > > Format: kerndoc > > License: typically

Re: [Xen-devel] [PATCH v2 1/2] x2APIC: translate IO-APIC entries when enabling the IOMMU

2019-10-11 Thread Jan Beulich
On 10.10.2019 17:19, Roger Pau Monné wrote: > On Thu, Oct 10, 2019 at 03:46:45PM +0200, Jan Beulich wrote: >> On 10.10.2019 15:12, Roger Pau Monné wrote: >>> On Thu, Oct 10, 2019 at 02:55:02PM +0200, Jan Beulich wrote: On 10.10.2019 14:13, Roger Pau Monné wrote: > On Thu, Oct 10, 2019

Re: [Xen-devel] [XEN PATCH for-4.13 v2 9/9] libxl/xl: Overhaul passthrough setting logic

2019-10-11 Thread Wei Liu
On Thu, Oct 10, 2019 at 04:11:11PM +0100, Ian Jackson wrote: > LIBXL_PASSTHROUGH_UNKNOWN (aka "ENABLED" in an earlier uncommitted > version of this code) is doing double duty. We actually need all of > the following to be specificable: > * default ("unknown"): enable PT iff we have devices to >

Re: [Xen-devel] [XEN PATCH for-4.13 v2 8/9] libxl: create: setdefault: Move physinfo into config_setdefault

2019-10-11 Thread Wei Liu
On Thu, Oct 10, 2019 at 04:11:10PM +0100, Ian Jackson wrote: > No functional change. This will let us refer to it in code we are > about to add to this function. > > Signed-off-by: Ian Jackson Acked-by: Wei Liu ___ Xen-devel mailing list

Re: [Xen-devel] [XEN PATCH for-4.13 v2 7/9] libxl: create: setdefault: Make libxl_physinfo info[1]

2019-10-11 Thread Wei Liu
On Thu, Oct 10, 2019 at 04:11:09PM +0100, Ian Jackson wrote: > No functional change. This will let us make it into a pointer without > textual change other than to the definition. > > While we are here, fix some style errors (missing { }). > > Signed-off-by: Ian Jackson Acked-by: Wei Liu

Re: [Xen-devel] [PATCH v2 1/2] x2APIC: translate IO-APIC entries when enabling the IOMMU

2019-10-11 Thread Roger Pau Monné
On Fri, Oct 11, 2019 at 09:52:35AM +0200, Jan Beulich wrote: > On 10.10.2019 17:19, Roger Pau Monné wrote: > > On Thu, Oct 10, 2019 at 03:46:45PM +0200, Jan Beulich wrote: > >> On 10.10.2019 15:12, Roger Pau Monné wrote: > >>> On Thu, Oct 10, 2019 at 02:55:02PM +0200, Jan Beulich wrote: >

Re: [Xen-devel] [PATCH v1 2/2] libxl: add removing XS backend path for PV devices on domain destroy

2019-10-11 Thread Ian Jackson
Oleksandr Grytsov writes ("[PATCH v1 2/2] libxl: add removing XS backend path for PV devices on domain destroy"): > From: Oleksandr Grytsov > > Currently backend path is remove for specific devices: VBD, VIF, QDISK. > This commit adds removing backend path for: VDISPL, VSND, VINPUT. Thanks for

Re: [Xen-devel] [XEN PATCH v1] libxl: Add DTB compatible list to config file

2019-10-11 Thread Ian Jackson
Oleksandr Grytsov writes ("[PATCH v1] libxl: Add DTB compatible list to config file"): > From: Oleksandr Grytsov > > Some platforms need more compatible property values in device > tree root node in addition to "xen,xenvm-%d.%d" and "xen,xenvm" > values that are given by Xen by default. >

Re: [Xen-devel] [XEN PATCH v1] libxl: Add DTB compatible list to config file

2019-10-11 Thread Julien Grall
Hi, On 11/10/2019 16:23, Ian Jackson wrote: Oleksandr Grytsov writes ("[PATCH v1] libxl: Add DTB compatible list to config file"): From: Oleksandr Grytsov Some platforms need more compatible property values in device tree root node in addition to "xen,xenvm-%d.%d" and "xen,xenvm" values

Re: [Xen-devel] [PATCH] xen/arm: add warning if memory modules overlap

2019-10-11 Thread Julien Grall
Hi, On 10/11/19 5:43 PM, Brian Woods wrote: On Thu, Oct 10, 2019 at 04:39:07PM +0100, Julien Grall wrote: Hi Brian, Thank you for the patch. On 10/9/19 8:47 PM, Brian Woods wrote: It's possible for a misconfigured device tree to cause Xen to crash when there are overlapping addresses in the

Re: [Xen-devel] [[PATCH for-4.13]] xen/arm: mm: Allow generic xen page-tables helpers to be called early

2019-10-11 Thread Stefano Stabellini
On Fri, 11 Oct 2019, Julien Grall wrote: > On 11/10/2019 01:32, Stefano Stabellini wrote: > > On Thu, 10 Oct 2019, Julien Grall wrote: > > > On 08/10/2019 23:24, Stefano Stabellini wrote: > > > > On Tue, 8 Oct 2019, Julien Grall wrote: > > > > > On 10/8/19 1:18 AM, Stefano Stabellini wrote: > > >

Re: [Xen-devel] [PATCH] xen/arm: add warning if memory modules overlap

2019-10-11 Thread Brian Woods
On Fri, Oct 11, 2019 at 07:17:29PM +0100, Julien Grall wrote: > Hi, > > On 10/11/19 7:06 PM, Brian Woods wrote: > >On Fri, Oct 11, 2019 at 05:58:35PM +0100, Julien Grall wrote: > >For that, you'd need to either check the start and end of the added > >module or the start of both. So something

Re: [Xen-devel] [[PATCH for-4.13]] xen/arm: mm: Allow generic xen page-tables helpers to be called early

2019-10-11 Thread Julien Grall
On 10/11/19 8:01 PM, Stefano Stabellini wrote: On Fri, 11 Oct 2019, Julien Grall wrote: Hi Stefano, On 10/11/19 6:11 PM, Stefano Stabellini wrote: This is not pretty, but I don't view this as critical to fix for Xen 4.13. So I am thinking to defer this post 4.13. If the issue doesn't

Re: [Xen-devel] [[PATCH for-4.13]] xen/arm: mm: Allow generic xen page-tables helpers to be called early

2019-10-11 Thread Stefano Stabellini
On Fri, 11 Oct 2019, Julien Grall wrote: > Hi Stefano, > > On 10/11/19 6:11 PM, Stefano Stabellini wrote: > > > This is not pretty, but I don't view this as critical to fix for Xen 4.13. > > > So > > > I am thinking to defer this post 4.13. > > > > If the issue doesn't trigger on 4.13, then I

[Xen-devel] [linux-linus test] 142588: regressions - FAIL

2019-10-11 Thread osstest service owner
flight 142588 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/142588/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-freebsd10-i386 7 xen-boot fail REGR. vs. 133580

Re: [Xen-devel] [PATCH] xen/arm: add warning if memory modules overlap

2019-10-11 Thread Julien Grall
Hi, On 10/11/19 7:06 PM, Brian Woods wrote: On Fri, Oct 11, 2019 at 05:58:35PM +0100, Julien Grall wrote: For that, you'd need to either check the start and end of the added module or the start of both. So something like: if ( ((mod->start >= start) && (mod->start < (start + size))) ||

Re: [Xen-devel] [PATCH] xen/arm: add warning if memory modules overlap

2019-10-11 Thread Brian Woods
On Fri, Oct 11, 2019 at 05:58:35PM +0100, Julien Grall wrote: > Hi, > > Please at least remove the signature in the e-mail you reply to. The best > would be to trim the e-mail and answer right below the specific paragraph. > > > > >To make sure the module is going to get added, you'd need to do

Re: [Xen-devel] [PATCH v3 1/3] x86/boot: Introduce the kernel_info

2019-10-11 Thread Konrad Rzeszutek Wilk
> >>> +be prefixed with header/magic and its size, e.g.: > >>> + > >>> + kernel_info: > >>> + .ascii "LToP" /* Header, Linux top (structure). */ > >>> + .long kernel_info_var_len_data - kernel_info > >>> + .long kernel_info_end - kernel_info > >>> +

[Xen-devel] [RFC v5 031/126] xen: introduce ERRP_AUTO_PROPAGATE

2019-10-11 Thread Vladimir Sementsov-Ogievskiy
If we want to add some info to errp (by error_prepend() or error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. Otherwise, this info will not be added when errp == _err (the program will exit prior to the error_append_hint() or error_prepend() call). Fix such cases. If we want to

Re: [Xen-devel] [PATCH] xen/arm: add warning if memory modules overlap

2019-10-11 Thread Brian Woods
On Thu, Oct 10, 2019 at 04:39:07PM +0100, Julien Grall wrote: > Hi Brian, > > Thank you for the patch. > > On 10/9/19 8:47 PM, Brian Woods wrote: > >It's possible for a misconfigured device tree to cause Xen to crash when > >there are overlapping addresses in the memory modules. Add a warning >

Re: [Xen-devel] [RFC] Documentation formats, licenses and file system structure

2019-10-11 Thread Stefano Stabellini
On Fri, 11 Oct 2019, Lars Kurth wrote: > On 11/10/2019, 02:24, "Stefano Stabellini" wrote: > > On Thu, 10 Oct 2019, Lars Kurth wrote: > > * Would we ever include API docs generated from GPLv2 code? E.g. for > safety use-cases? > > @Stefano, @Artem: I guess this one is for you. >

[Xen-devel] [qemu-mainline test] 142586: regressions - FAIL

2019-10-11 Thread osstest service owner
flight 142586 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/142586/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ovmf-amd64 10 debian-hvm-install fail REGR. vs. 140282

[Xen-devel] [PATCH for-4.13] x86/VT-d: Drop unhelpful information in diagnostics

2019-10-11 Thread Andrew Cooper
The virtual address of the base of the IOMMU's regsters is not useful for diagnostic purposes, and is quite voluminous. The PCI coordinates is by far the most useful piece of identifying information. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monné CC: Jun

Re: [Xen-devel] [XEN PATCH for-4.13 v1] Reset iomem's gfn to LIBXL_INVALID_GFN on reboot

2019-10-11 Thread Ian Jackson
Oleksandr Grytsov writes ("[PATCH v1] Reset iomem's gfn to LIBXL_INVALID_GFN on reboot"): > During domain reboot its configuration is partially reused > to re-create a new domain, but iomem's GFN field for the > iomem is only restored for those memory ranges, which are > configured in form of

Re: [Xen-devel] [PATCH for-4.13] x86/VT-d: Drop unhelpful information in diagnostics

2019-10-11 Thread Roger Pau Monné
On Fri, Oct 11, 2019 at 04:02:53PM +0100, Andrew Cooper wrote: > The virtual address of the base of the IOMMU's regsters is not useful for > diagnostic purposes, and is quite voluminous. The PCI coordinates is by far > the most useful piece of identifying information. > > Signed-off-by: Andrew

Re: [Xen-devel] [XEN PATCH for-4.13 v2 9/9] libxl/xl: Overhaul passthrough setting logic

2019-10-11 Thread Ian Jackson
Jürgen Groß writes ("Re: [Xen-devel] [XEN PATCH for-4.13 v2 9/9] libxl/xl: Overhaul passthrough setting logic"): > On 11.10.19 15:31, Ian Jackson wrote: > > I do not have a strong opinion about this. I would be happy with > > "auto" (or "default" maybe). > > "unspecified"? That is IMO the best

[Xen-devel] [XEN PATCH for-4.13 v3 00/10] libxl memkb & pt defaulting

2019-10-11 Thread Ian Jackson
This is v3 of my series to sort out the shadow/iommu memory and pci passthrough situation. It is also available here: https://xenbits.xen.org/gitweb/?p=people/iwj/xen.git;a=summary wip.libxl-memkb-ptcfg.v3 Thanks to Andrew Cooper and Julien Grall for comments about the PT mode setting,

[Xen-devel] [XEN PATCH for-4.13 v3 05/10] libxl: Move shadow_memkb and iommu_memkb defaulting into libxl

2019-10-11 Thread Ian Jackson
Defaulting is supposed to be done by libxl. So these calculations should be here in libxl. libxl__domain_config_setdefault has all the necessary information including the values of max_memkb and max_vcpus. The overall functional effect depends on the caller: For xl, no change. The code moves

[Xen-devel] [XEN PATCH for-4.13 v3 10/10] libxl/xl: Overhaul passthrough setting logic

2019-10-11 Thread Ian Jackson
LIBXL_PASSTHROUGH_UNKNOWN (aka "ENABLED" in an earlier uncommitted version of this code) is doing double duty. We actually need all of the following to be specificable: * default ("unspecified"): enable PT iff we have devices to pass through specified in the initial config file. *

[Xen-devel] [XEN PATCH for-4.13 v3 08/10] libxl: create: setdefault: Move physinfo into config_setdefault

2019-10-11 Thread Ian Jackson
No functional change. This will let us refer to it in code we are about to add to this function. Signed-off-by: Ian Jackson Acked-by: Wei Liu --- v2: New patch in this version of the series. --- tools/libxl/libxl_create.c | 17 - tools/libxl/libxl_dm.c | 7 ++-

[Xen-devel] [XEN PATCH for-4.13 v3 09/10] libxl: Move domain_create_info_setdefault earlier

2019-10-11 Thread Ian Jackson
We need this before we start to figure out the passthrough mode. I have checked that nothing in libxl__domain_create_info_setdefault nor the two implementations of ..._arch_... accesses anything else, other than (i) the domain type (which this function is responsible for setting and nothing

[Xen-devel] [XEN PATCH for-4.13 v3 06/10] libxl: Remove/deprecate libxl_get_required_*_memory from the API

2019-10-11 Thread Ian Jackson
These are now redundant because shadow_memkb and iommu_memkb are now defaulted automatically by libxl_domain_need_memory and libxl_domain_create etc. Callers should not now call these; instead, they should just let libxl take care of it. libxl_get_required_shadow_memory was introduced in

[Xen-devel] [XEN PATCH for-4.13 v3 07/10] libxl: create: setdefault: Make libxl_physinfo info[1]

2019-10-11 Thread Ian Jackson
No functional change. This will let us make it into a pointer without textual change other than to the definition. While we are here, fix some style errors (missing { }). Signed-off-by: Ian Jackson Acked-by: Wei Liu --- v2: New patch in this version of the series. ---

Re: [Xen-devel] [RFC] Documentation formats, licenses and file system structure

2019-10-11 Thread Stefano Stabellini
On Fri, 11 Oct 2019, Lars Kurth wrote: > On 11/10/2019, 09:32, "Jan Beulich" wrote: > > On 10.10.2019 20:30, Lars Kurth wrote: > > On 10/10/2019, 18:05, "Andrew Cooper" wrote: > > On 10/10/2019 13:34, Lars Kurth wrote: > > > Existing formats and licenses > > > *

Re: [Xen-devel] [PATCH v1 2/2] libxl: add removing XS backend path for PV devices on domain destroy

2019-10-11 Thread Roger Pau Monné
On Fri, Oct 11, 2019 at 04:07:11PM +0100, Ian Jackson wrote: > Oleksandr Grytsov writes ("[PATCH v1 2/2] libxl: add removing XS backend path > for PV devices on domain destroy"): > > From: Oleksandr Grytsov > > > > Currently backend path is remove for specific devices: VBD, VIF, QDISK. > > This

Re: [Xen-devel] [PATCH v1 1/2] libxl: introduce new backend type VINPUT

2019-10-11 Thread Ian Jackson
Oleksandr Grytsov writes ("Re: [PATCH v1 1/2] libxl: introduce new backend type VINPUT"): > On Fri, Oct 11, 2019 at 5:58 PM Ian Jackson wrote: > > I think it was a48e00f14a2d "libxl: add backend type and id to vkb" > > which introduced what you are calling "user space" backends. It > > appears

Re: [Xen-devel] [PATCH v1 1/2] libxl: introduce new backend type VINPUT

2019-10-11 Thread Oleksandr Grytsov
On Fri, Oct 11, 2019 at 5:58 PM Ian Jackson wrote: > > Oleksandr Grytsov writes ("[PATCH v1 1/2] libxl: introduce new backend type > VINPUT"): > > From: Oleksandr Grytsov > > > > There are two kind of VKBD devices: with QEMU backend and user space > > backend. In current implementation they

Re: [Xen-devel] [PATCH v1 1/2] libxl: introduce new backend type VINPUT

2019-10-11 Thread Ian Jackson
Oleksandr Grytsov writes ("[PATCH v1 1/2] libxl: introduce new backend type VINPUT"): > From: Oleksandr Grytsov > > There are two kind of VKBD devices: with QEMU backend and user space > backend. In current implementation they can't be distinguished as both use > VKBD backend type. As result,

Re: [Xen-devel] [PATCH v1 2/2] libxl: add removing XS backend path for PV devices on domain destroy

2019-10-11 Thread Ian Jackson
Roger Pau Monne writes ("Re: [PATCH v1 2/2] libxl: add removing XS backend path for PV devices on domain destroy"): > When this code was added (devd) those where the only backends handled > by libxl. VDISPL, VSND, VINPUT didn't exist at that point, so I think > the issue is that when support for

[Xen-devel] [freebsd-master test] 142595: regressions - trouble: blocked/fail

2019-10-11 Thread osstest service owner
flight 142595 freebsd-master real [real] http://logs.test-lab.xenproject.org/osstest/logs/142595/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-freebsd 7 freebsd-buildfail REGR. vs. 141501 Tests which did

Re: [Xen-devel] [XEN PATCH v1] libxl: Add DTB compatible list to config file

2019-10-11 Thread Stefano Stabellini
On Fri, 11 Oct 2019, Julien Grall wrote: > Hi, > > On 11/10/2019 16:23, Ian Jackson wrote: > > Oleksandr Grytsov writes ("[PATCH v1] libxl: Add DTB compatible list to > > config file"): > > > From: Oleksandr Grytsov > > > > > > Some platforms need more compatible property values in device > > >

Re: [Xen-devel] [[PATCH for-4.13]] xen/arm: mm: Allow generic xen page-tables helpers to be called early

2019-10-11 Thread Julien Grall
Hi Stefano, On 10/11/19 6:11 PM, Stefano Stabellini wrote: This is not pretty, but I don't view this as critical to fix for Xen 4.13. So I am thinking to defer this post 4.13. If the issue doesn't trigger on 4.13, then I agree we shouldn't try to fix it (badly) at this stage. But we do have

[Xen-devel] [qemu-mainline bisection] complete test-amd64-amd64-qemuu-nested-intel

2019-10-11 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-amd64-qemuu-nested-intel testid debian-hvm-install Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu

[Xen-devel] [RFC v5 026/126] python: add commit-per-subsystem.py

2019-10-11 Thread Vladimir Sementsov-Ogievskiy
Add script to automatically commit tree-wide changes per-subsystem. Signed-off-by: Vladimir Sementsov-Ogievskiy --- CC: Gerd Hoffmann CC: "Gonglei (Arei)" CC: Eduardo Habkost CC: Igor Mammedov CC: Laurent Vivier CC: Amit Shah CC: Kevin Wolf CC: Max Reitz CC: John Snow CC: Ari Sundholm

[Xen-devel] [RFC v5 000/126] error: auto propagated local_err

2019-10-11 Thread Vladimir Sementsov-Ogievskiy
Hi all! At the request of Markus: full version of errp propagation. Let's look at it. Cover as much as possible, except inserting macro invocation where it's not necessary. It's huge, and so it's an RFC. In v5 I've added a lot more preparation cleanups: 01-23 are preparation cleanups 01: not

Re: [Xen-devel] [RFC v5 025/126] scripts: add coccinelle script to use auto propagated errp

2019-10-11 Thread Eric Blake
On 10/11/19 12:12 PM, Eric Blake wrote: On 10/11/19 11:04 AM, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy --- +@@ +identifier rule1.fn; +identifier rule1.local_err; +@@ + + fn(...) + { + <... +( +-    error_free(local_err); +-    local_err = NULL; ++ 

Re: [Xen-devel] [RFC v5 025/126] scripts: add coccinelle script to use auto propagated errp

2019-10-11 Thread Eric Blake
On 10/11/19 11:04 AM, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy --- scripts/coccinelle/auto-propagated-errp.cocci | 118 ++ 1 file changed, 118 insertions(+) create mode 100644 scripts/coccinelle/auto-propagated-errp.cocci diff

Re: [Xen-devel] [RFC v5 000/126] error: auto propagated local_err

2019-10-11 Thread Eric Blake
On 10/11/19 11:03 AM, Vladimir Sementsov-Ogievskiy wrote: Hi all! At the request of Markus: full version of errp propagation. Let's look at it. Cover as much as possible, except inserting macro invocation where it's not necessary. It's huge, and so it's an RFC. Is there a repo containing

[Xen-devel] [RFC v5 025/126] scripts: add coccinelle script to use auto propagated errp

2019-10-11 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- CC: Gerd Hoffmann CC: "Gonglei (Arei)" CC: Eduardo Habkost CC: Igor Mammedov CC: Laurent Vivier CC: Amit Shah CC: Kevin Wolf CC: Max Reitz CC: John Snow CC: Ari Sundholm CC: Pavel Dovgalyuk CC: Paolo Bonzini CC: Stefan Hajnoczi CC: Fam

[Xen-devel] [RFC v5 024/126] error: auto propagated local_err

2019-10-11 Thread Vladimir Sementsov-Ogievskiy
Here is introduced ERRP_AUTO_PROPAGATE macro, to be used at start of functions with errp OUT parameter. It has three goals: 1. Fix issue with error_fatal & error_prepend/error_append_hint: user can't see this additional information, because exit() happens in error_setg earlier than information

[Xen-devel] [xen-unstable test] 142598: regressions - FAIL

2019-10-11 Thread osstest service owner
flight 142598 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/142598/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-qemut-rhel6hvm-intel 7 xen-boot fail REGR. vs. 141822

[Xen-devel] [ovmf test] 142599: regressions - FAIL

2019-10-11 Thread osstest service owner
flight 142599 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/142599/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 10 debian-hvm-install fail REGR. vs. 142423

[Xen-devel] [linux-next test] 142594: tolerable FAIL

2019-10-11 Thread osstest service owner
flight 142594 linux-next real [real] http://logs.test-lab.xenproject.org/osstest/logs/142594/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-examine 8 reboot fail like 142539 test-amd64-i386-libvirt-pair 10

Re: [Xen-devel] [XEN PATCH for-4.13 v2 9/9] libxl/xl: Overhaul passthrough setting logic

2019-10-11 Thread Ian Jackson
Andrew Cooper writes ("Re: [XEN PATCH for-4.13 v2 9/9] libxl/xl: Overhaul passthrough setting logic"): > On 10/10/2019 16:11, Ian Jackson wrote: > > +if (c_info->passthrough == LIBXL_PASSTHROUGH_DISABLED && need_pt) { > > +LOGD(ERROR, domid, > > + "passthrough disabled but

[Xen-devel] [PATCH v9 23/28] x86_64/asm: Change all ENTRY+END to SYM_CODE_*

2019-10-11 Thread Jiri Slaby
Here, all assembly code which is marked using END (and not ENDPROC) is changed. All these are switched to appropriate new markings SYM_CODE_START and SYM_CODE_END. Signed-off-by: Jiri Slaby Reviewed-by: Boris Ostrovsky [xen bits] Cc: Borislav Petkov Cc: Thomas Gleixner Cc: Ingo Molnar Cc:

[Xen-devel] [PATCH v9 14/28] xen/pvh: Annotate data appropriately

2019-10-11 Thread Jiri Slaby
Use the new SYM_DATA_START_LOCAL, and SYM_DATA_END* macros to have: 8 OBJECT LOCAL DEFAULT6 gdt 000832 OBJECT LOCAL DEFAULT6 gdt_start 0028 0 OBJECT LOCAL DEFAULT6 gdt_end 0028 256 OBJECT LOCAL DEFAULT6 early_stack 0128 0 OBJECT LOCAL

[Xen-devel] [PATCH v9 24/28] x86_64/asm: Change all ENTRY+ENDPROC to SYM_FUNC_*

2019-10-11 Thread Jiri Slaby
These are all functions which are invoked from elsewhere, so annotate them as global using the new SYM_FUNC_START. And their ENDPROC's by SYM_FUNC_END. And make sure ENTRY/ENDPROC is not defined on X86_64, given these were the last users. Signed-off-by: Jiri Slaby Reviewed-by: Rafael J. Wysocki

[Xen-devel] [PATCH v9 09/28] x86/asm: Annotate aliases

2019-10-11 Thread Jiri Slaby
_key_expansion_128 is an alias to _key_expansion_256a, __memcpy to memcpy, xen_syscall32_target to xen_sysenter_target, and so on. Annotate them all using the new SYM_FUNC_START_ALIAS, SYM_FUNC_START_LOCAL_ALIAS, and SYM_FUNC_END_ALIAS. This will make the tools generating the debuginfo happy as it

[Xen-devel] [PATCH v9 22/28] x86_64/asm: Add ENDs to some functions and relabel with SYM_CODE_*

2019-10-11 Thread Jiri Slaby
All these are functions which are invoked from elsewhere, but they are not typical C functions. So they are annotated using the new SYM_CODE_START. All these were not balanced with any END, so mark their ends by SYM_CODE_END appropriately too. Signed-off-by: Jiri Slaby Reviewed-by: Boris

[Xen-devel] [PATCH v9 25/28] x86_32/asm: Add ENDs to some functions and relabel with SYM_CODE_*

2019-10-11 Thread Jiri Slaby
All these are functions which are invoked from elsewhere, but they are not typical C functions. So they are annotated using the new SYM_CODE_START. All these were not balanced with any END, so mark their ends by SYM_CODE_END, appropriately. Signed-off-by: Jiri Slaby Reviewed-by: Boris Ostrovsky

[Xen-devel] [linux-4.4 test] 142571: regressions - FAIL

2019-10-11 Thread osstest service owner
flight 142571 linux-4.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/142571/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-pvshim 20 guest-start/debian.repeat fail in 142521 REGR. vs. 139698 Tests

Re: [Xen-devel] [PATCH v2 1/2] x2APIC: translate IO-APIC entries when enabling the IOMMU

2019-10-11 Thread Jan Beulich
On 11.10.2019 11:28, Roger Pau Monné wrote: > On Fri, Oct 11, 2019 at 09:52:35AM +0200, Jan Beulich wrote: >> On 10.10.2019 17:19, Roger Pau Monné wrote: >>> On Thu, Oct 10, 2019 at 03:46:45PM +0200, Jan Beulich wrote: On 10.10.2019 15:12, Roger Pau Monné wrote: > On Thu, Oct 10, 2019

Re: [Xen-devel] [XEN PATCH for-4.13 v2 9/9] libxl/xl: Overhaul passthrough setting logic

2019-10-11 Thread Julien Grall
Hi, On 11/10/2019 10:47, Andrew Cooper wrote: On 10/10/2019 16:11, Ian Jackson wrote: diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c index 69971c97b6..fccb6a6271 100644 --- a/tools/libxl/libxl_create.c +++ b/tools/libxl/libxl_create.c @@ -968,6 +957,50 @@ int

[Xen-devel] [ovmf bisection] complete test-amd64-i386-xl-qemuu-ovmf-amd64

2019-10-11 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-i386-xl-qemuu-ovmf-amd64 testid debian-hvm-install Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf https://github.com/tianocore/edk2.git Tree: qemu

Re: [Xen-devel] [XEN PATCH for-4.13 v2 9/9] libxl/xl: Overhaul passthrough setting logic

2019-10-11 Thread Jürgen Groß
On 11.10.19 15:31, Ian Jackson wrote: George Dunlap writes ("Re: [Xen-devel] [XEN PATCH for-4.13 v2 9/9] libxl/xl: Overhaul passthrough setting logic"): On Thu, Oct 10, 2019 at 4:12 PM Ian Jackson wrote: LIBXL_PASSTHROUGH_UNKNOWN (aka "ENABLED" in an earlier uncommitted version of this code)

Re: [Xen-devel] [RFC] Documentation formats, licenses and file system structure

2019-10-11 Thread Lars Kurth
On 11/10/2019, 02:24, "Stefano Stabellini" wrote: On Thu, 10 Oct 2019, Lars Kurth wrote: > * Would we ever include API docs generated from GPLv2 code? E.g. for safety use-cases? > @Stefano, @Artem: I guess this one is for you. > I suppose if we would have a similar issue for

Re: [Xen-devel] [PATCH for-4.13] xen/arm: mm: Allow generic xen page-tables helpers to be called early

2019-10-11 Thread Julien Grall
Hi Stefano, On 11/10/2019 01:27, Stefano Stabellini wrote: On Thu, 10 Oct 2019, Julien Grall wrote: The current implementations of xen_{map, unmap}_table() expect {map, unmap}_domain_page() to be usable. Those helpers are used to map/unmap page tables while update Xen page-tables. Since

[Xen-devel] [PATCH v9 01/28] linkage: Introduce new macros for assembler symbols

2019-10-11 Thread Jiri Slaby
Introduce new C macros for annotations of functions and data in assembly. There is a long-standing mess in macros like ENTRY, END, ENDPROC and similar. They are used in different manners and sometimes incorrectly. So introduce macros with clear use to annotate assembly as follows: a) Support

[Xen-devel] [PATCH v9 20/28] x86/asm: Make some functions local

2019-10-11 Thread Jiri Slaby
There is a couple of assembly functions, which are invoked only locally in the file they are defined. In C, they are marked "static". In assembly, annotate them using SYM_{FUNC,CODE}_START_LOCAL (and switch their ENDPROC to SYM_{FUNC,CODE}_END too). Whether FUNC or CODE is used, depends on whether

Re: [Xen-devel] [XEN PATCH for-4.13 v2 9/9] libxl/xl: Overhaul passthrough setting logic

2019-10-11 Thread Andrew Cooper
On 10/10/2019 16:11, Ian Jackson wrote: > diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c > index 69971c97b6..fccb6a6271 100644 > --- a/tools/libxl/libxl_create.c > +++ b/tools/libxl/libxl_create.c > @@ -968,6 +957,50 @@ int libxl__domain_config_setdefault(libxl__gc *gc, >

Re: [Xen-devel] [[PATCH for-4.13]] xen/arm: mm: Allow generic xen page-tables helpers to be called early

2019-10-11 Thread Julien Grall
Hi, On 11/10/2019 01:32, Stefano Stabellini wrote: On Thu, 10 Oct 2019, Julien Grall wrote: On 08/10/2019 23:24, Stefano Stabellini wrote: On Tue, 8 Oct 2019, Julien Grall wrote: On 10/8/19 1:18 AM, Stefano Stabellini wrote: On Mon, 7 Oct 2019, Julien Grall wrote: Hi, On 03/10/2019 02:02,

Re: [Xen-devel] [PATCH v2 1/2] x2APIC: translate IO-APIC entries when enabling the IOMMU

2019-10-11 Thread Roger Pau Monné
On Fri, Oct 11, 2019 at 12:01:36PM +0200, Jan Beulich wrote: > On 11.10.2019 11:28, Roger Pau Monné wrote: > > On Fri, Oct 11, 2019 at 09:52:35AM +0200, Jan Beulich wrote: > >> On 10.10.2019 17:19, Roger Pau Monné wrote: > >>> On Thu, Oct 10, 2019 at 03:46:45PM +0200, Jan Beulich wrote: >

[Xen-devel] [xen-unstable test] 142563: regressions - FAIL

2019-10-11 Thread osstest service owner
flight 142563 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/142563/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-pair 22 guest-migrate/src_host/dst_host fail REGR. vs. 141822

Re: [Xen-devel] [XEN PATCH for-4.13 v2 9/9] libxl/xl: Overhaul passthrough setting logic

2019-10-11 Thread Ian Jackson
Julien Grall writes ("Re: [Xen-devel] [XEN PATCH for-4.13 v2 9/9] libxl/xl: Overhaul passthrough setting logic"): > libxl treats Arm guest as PVH now. Note that we seamlessly convert > PV to PVH in libxl__arch_domain_{build, create}_info_setdefault(). > > So as long as this is called after any

Re: [Xen-devel] [PATCH for-4.13] xen/arm: mm: Allow generic xen page-tables helpers to be called early

2019-10-11 Thread Julien Grall
(+ Andrew and Jan) Hi, On 11/10/2019 01:27, Stefano Stabellini wrote: On Thu, 10 Oct 2019, Julien Grall wrote: diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index be23acfe26..a6637ce347 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -964,11 +964,40 @@ static int

[Xen-devel] [libvirt test] 142584: tolerable all pass - PUSHED

2019-10-11 Thread osstest service owner
flight 142584 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/142584/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 14 saverestore-support-checkfail like 142252 test-armhf-armhf-libvirt-raw 13

Re: [Xen-devel] [RFC] Documentation formats, licenses and file system structure

2019-10-11 Thread Artem Mygaiev
Hi Lars On Thu, 2019-10-10 at 12:34 +, Lars Kurth wrote: > * Possibly stuff such as > https://urldefense.com/v3/__https://xenbits.xen.org/docs/unstable/support-matrix.html__;!K6dmGCEab4ueJg!lwAwYJi7cUkbX7CUXnOD9i7laj_9xcyafF714u6PO04tu0CYUKDHWBHAy2XD0mvEiA$ > (which is currently GPL-2, >

[Xen-devel] [ovmf test] 142567: regressions - FAIL

2019-10-11 Thread osstest service owner
flight 142567 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/142567/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 10 debian-hvm-install fail REGR. vs. 142423

Re: [Xen-devel] [XEN PATCH for-4.13 v2 9/9] libxl/xl: Overhaul passthrough setting logic

2019-10-11 Thread George Dunlap
On Thu, Oct 10, 2019 at 4:12 PM Ian Jackson wrote: > > LIBXL_PASSTHROUGH_UNKNOWN (aka "ENABLED" in an earlier uncommitted > version of this code) is doing double duty. We actually need all of > the following to be specificable: > * default ("unknown"): enable PT iff we have devices to >

Re: [Xen-devel] [RFC] Documentation formats, licenses and file system structure

2019-10-11 Thread Lars Kurth
On 11/10/2019, 09:32, "Jan Beulich" wrote: On 10.10.2019 20:30, Lars Kurth wrote: > On 10/10/2019, 18:05, "Andrew Cooper" wrote: > On 10/10/2019 13:34, Lars Kurth wrote: > > Existing formats and licenses > > * Hypercall ABI Documentation generated from Xen

Re: [Xen-devel] [[PATCH for-4.13]] xen/arm: mm: Allow generic xen page-tables helpers to be called early

2019-10-11 Thread Xia, Hongyan
Not commenting on the patch, but I had exactly the same problem when removing the direct map in x86. map_domain_page has to be usable without the direct map and even before alloc_boot_pages can be used (so that I can map the bootmem_regions_list, although I have made it statically allocated now).

Re: [Xen-devel] [XEN PATCH for-4.13 v2 9/9] libxl/xl: Overhaul passthrough setting logic

2019-10-11 Thread Ian Jackson
George Dunlap writes ("Re: [Xen-devel] [XEN PATCH for-4.13 v2 9/9] libxl/xl: Overhaul passthrough setting logic"): > On Thu, Oct 10, 2019 at 4:12 PM Ian Jackson wrote: > > LIBXL_PASSTHROUGH_UNKNOWN (aka "ENABLED" in an earlier uncommitted > > version of this code) is doing double duty. We