Re: [Xen-devel] [PATCH for-4.13 v2] xen/arm: Don't use _end in is_xen_fixed_mfn()

2019-10-16 Thread Stefano Stabellini
On Wed, 16 Oct 2019, Julien Grall wrote: > virt_to_maddr() is using the hardware page-table walk instructions to > translate a virtual address to physical address. The function should > only be called on virtual address mapped. > > _end points past the end of Xen binary and may not be mapped when

Re: [Xen-devel] [PATCH for-4.13] xen/arm: Don't use _end in is_xen_fixed_mfn()

2019-10-16 Thread Stefano Stabellini
On Wed, 16 Oct 2019, Ian Jackson wrote: > Stefano Stabellini writes ("Re: [PATCH for-4.13] xen/arm: Don't use _end in > is_xen_fixed_mfn()"): > > My suggestion is going to work: "the compiler sees through casts" > > referred to comparisons between pointers, where we temporarily casted > > both

[Xen-devel] [qemu-mainline test] 142783: regressions - trouble: fail/pass/starved

2019-10-16 Thread osstest service owner
flight 142783 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/142783/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ovmf-amd64 10 debian-hvm-install fail REGR. vs. 140282

Re: [Xen-devel] How PV frontend and backend initializes?

2019-10-16 Thread tosher 1
Anthony and Roger, thanks for your informative responses. It helped a lot. > I'm however unsure by what you mean with instance, so you might have > to clarify exactly what you mean in order to get a more concise > reply. Let's say there are two DomU's, and their respective network interfaces

Re: [Xen-devel] [PATCH hmm 08/15] xen/gntdev: Use select for DMA_SHARED_BUFFER

2019-10-16 Thread Oleksandr Andrushchenko
On 10/16/19 8:11 AM, Jürgen Groß wrote: > On 15.10.19 20:12, Jason Gunthorpe wrote: >> From: Jason Gunthorpe >> >> DMA_SHARED_BUFFER can not be enabled by the user (it represents a >> library >> set in the kernel). The kconfig convention is to use select for such >> symbols so they are turned on

[Xen-devel] [linux-4.4 test] 142762: regressions - trouble: fail/pass/starved

2019-10-16 Thread osstest service owner
flight 142762 linux-4.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/142762/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-pvshim 20 guest-start/debian.repeat fail in 142736 REGR. vs. 139698 Tests

Re: [Xen-devel] [PATCH v9 24/28] x86_64/asm: Change all ENTRY+ENDPROC to SYM_FUNC_*

2019-10-16 Thread Borislav Petkov
Hi, On Fri, Oct 11, 2019 at 01:51:04PM +0200, Jiri Slaby wrote: > These are all functions which are invoked from elsewhere, so annotate > them as global using the new SYM_FUNC_START. And their ENDPROC's by > SYM_FUNC_END. > > And make sure ENTRY/ENDPROC is not defined on X86_64, given these were

Re: [Xen-devel] [PATCH for-4.13] xen/arm: Don't use _end in is_xen_fixed_mfn()

2019-10-16 Thread George Dunlap
On 10/16/19 11:31 AM, Julien Grall wrote: > Hi George, > > On 16/10/2019 11:22, George Dunlap wrote: >> On 10/16/19 11:18 AM, Ian Jackson wrote: >>> Stefano Stabellini writes ("Re: [PATCH for-4.13] xen/arm: Don't use >>> _end in is_xen_fixed_mfn()"): My suggestion is going to work: "the

Re: [Xen-devel] [PATCH v1 2/2] libxl: add removing XS backend path for PV devices on domain destroy

2019-10-16 Thread Oleksandr Grytsov
On Tue, Oct 15, 2019 at 6:39 PM Roger Pau Monné wrote: > > On Fri, Oct 11, 2019 at 04:55:32PM +0100, Ian Jackson wrote: > > Roger Pau Monne writes ("Re: [PATCH v1 2/2] libxl: add removing XS backend > > path for PV devices on domain destroy"): > > > When this code was added (devd) those where

Re: [Xen-devel] [PATCH for-4.13] xen/arm: Don't use _end in is_xen_fixed_mfn()

2019-10-16 Thread Julien Grall
Hi, On 16/10/2019 11:18, Ian Jackson wrote: Stefano Stabellini writes ("Re: [PATCH for-4.13] xen/arm: Don't use _end in is_xen_fixed_mfn()"): My suggestion is going to work: "the compiler sees through casts" referred to comparisons between pointers, where we temporarily casted both pointers

Re: [Xen-devel] [RESEND][PATCH for-4.13] xen/arm: mm: Clear boot pagetables before bringing-up each secondary CPU

2019-10-16 Thread Jürgen Groß
On 16.10.19 13:19, Julien Grall wrote: Hi, Argh forgot again. Maybe the 3rd will be better? Yes! You made it! ;-) Sorry for the noise. Cheers, On 15/10/2019 17:36, Julien Grall wrote: Hi, I actually forgot to CC Juergen. No wonder why I had no answer :(. Cheers, On 10/10/19 3:51 PM,

Re: [Xen-devel] [PATCH for-4.13] xen/arm: Don't use _end in is_xen_fixed_mfn()

2019-10-16 Thread George Dunlap
On 10/16/19 11:41 AM, Jürgen Groß wrote: > On 16.10.19 12:38, George Dunlap wrote: >> On 10/16/19 11:31 AM, Julien Grall wrote: >>> Hi George, >>> >>> On 16/10/2019 11:22, George Dunlap wrote: On 10/16/19 11:18 AM, Ian Jackson wrote: > Stefano Stabellini writes ("Re: [PATCH for-4.13]

[Xen-devel] [PATCH for-4.13 v2] xen/arm: Don't use _end in is_xen_fixed_mfn()

2019-10-16 Thread Julien Grall
virt_to_maddr() is using the hardware page-table walk instructions to translate a virtual address to physical address. The function should only be called on virtual address mapped. _end points past the end of Xen binary and may not be mapped when the binary size is page-aligned. This means

Re: [Xen-devel] [PATCH 27/32] hw/pci-host/piix: Define and use the PIIX IRQ Route Control Registers

2019-10-16 Thread Paul Durrant
On Tue, 15 Oct 2019 at 17:34, Philippe Mathieu-Daudé wrote: > > The IRQ Route Control registers definitions belong to the PIIX > chipset. We were only defining the 'A' register. Define the other > B, C and D registers, and use them. > > Signed-off-by: Philippe Mathieu-Daudé Xen change...

Re: [Xen-devel] [PATCH for-4.13] xen/arm: Don't use _end in is_xen_fixed_mfn()

2019-10-16 Thread Jürgen Groß
On 16.10.19 12:38, George Dunlap wrote: On 10/16/19 11:31 AM, Julien Grall wrote: Hi George, On 16/10/2019 11:22, George Dunlap wrote: On 10/16/19 11:18 AM, Ian Jackson wrote: Stefano Stabellini writes ("Re: [PATCH for-4.13] xen/arm: Don't use _end in is_xen_fixed_mfn()"): My suggestion is

[Xen-devel] [PATCH for-4.13] xen/arm: setup: Calculate correctly the size of Xen

2019-10-16 Thread Julien Grall
The current size of Xen is computed using _end - _start + 1. However, _end is pointing one past the end of Xen, so the size of Xen is off-by-one. Signed-off-by: Julien Grall --- xen/arch/arm/setup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/setup.c

Re: [Xen-devel] [PATCH for-4.13] xen/arm: setup: Calculate correctly the size of Xen

2019-10-16 Thread Jürgen Groß
On 16.10.19 13:12, Julien Grall wrote: The current size of Xen is computed using _end - _start + 1. However, _end is pointing one past the end of Xen, so the size of Xen is off-by-one. Signed-off-by: Julien Grall Release-acked-by: Juergen Gross Juergen

Re: [Xen-devel] [PATCH for-4.13] xen/arm: Don't use _end in is_xen_fixed_mfn()

2019-10-16 Thread George Dunlap
On 10/16/19 11:18 AM, Ian Jackson wrote: > Stefano Stabellini writes ("Re: [PATCH for-4.13] xen/arm: Don't use _end in > is_xen_fixed_mfn()"): >> My suggestion is going to work: "the compiler sees through casts" >> referred to comparisons between pointers, where we temporarily casted >> both

Re: [Xen-devel] [PATCH for-4.13] xen/arm: Don't use _end in is_xen_fixed_mfn()

2019-10-16 Thread Julien Grall
Hi George, On 16/10/2019 11:38, George Dunlap wrote: On 10/16/19 11:31 AM, Julien Grall wrote: On 16/10/2019 11:22, George Dunlap wrote: On 10/16/19 11:18 AM, Ian Jackson wrote: Stefano Stabellini writes ("Re: [PATCH for-4.13] xen/arm: Don't use _end in is_xen_fixed_mfn()"): My suggestion

Re: [Xen-devel] [RESEND][PATCH for-4.13] xen/arm: mm: Clear boot pagetables before bringing-up each secondary CPU

2019-10-16 Thread Julien Grall
Hi, Argh forgot again. Maybe the 3rd will be better? Sorry for the noise. Cheers, On 15/10/2019 17:36, Julien Grall wrote: Hi, I actually forgot to CC Juergen. No wonder why I had no answer :(. Cheers, On 10/10/19 3:51 PM, Julien Grall wrote: +Juergen On 03/10/2019 02:22, Stefano

[Xen-devel] [PATCH for-4.13 v3] xen/arm: domain_build: Don't expose IOMMU specific properties to hwdom

2019-10-16 Thread Oleksandr Tyshchenko
From: Oleksandr Tyshchenko We always skip the IOMMU device when creating DT for hwdom if there is an appropriate driver for it in Xen (device_get_class(iommu_node) returns DEVICE_IOMMU). So, even if it is not used by Xen it will be skipped. We should also skip the IOMMU specific properties of

Re: [Xen-devel] Xen-unstable 4.13.0-rc0 problem starting guest while trying to passthrough multiple pci devices

2019-10-16 Thread Anthony PERARD
CC libxl maintainers On Tue, Oct 15, 2019 at 06:02:33PM +0200, Sander Eikelenboom wrote: > Hi Anthony, > > While testing xen-unstable 4.13.0-rc0 I ran in to the following issue: > > When passing through all 8 functions of a pci(e) device I can't start the > guest anymore, note that the trouble

Re: [Xen-devel] [PATCH for-4.13] xen/arm: Don't use _end in is_xen_fixed_mfn()

2019-10-16 Thread Ian Jackson
Stefano Stabellini writes ("Re: [PATCH for-4.13] xen/arm: Don't use _end in is_xen_fixed_mfn()"): > My suggestion is going to work: "the compiler sees through casts" > referred to comparisons between pointers, where we temporarily casted > both pointers to integers and back to pointers via a

Re: [Xen-devel] [PATCH for-4.13] xen/arm: Don't use _end in is_xen_fixed_mfn()

2019-10-16 Thread Julien Grall
Hi George, On 16/10/2019 11:22, George Dunlap wrote: On 10/16/19 11:18 AM, Ian Jackson wrote: Stefano Stabellini writes ("Re: [PATCH for-4.13] xen/arm: Don't use _end in is_xen_fixed_mfn()"): My suggestion is going to work: "the compiler sees through casts" referred to comparisons between

Re: [Xen-devel] [PATCH v3 0/3] x86/boot: Introduce the kernel_info et consortes

2019-10-16 Thread Daniel Kiper
On Wed, Oct 09, 2019 at 12:53:55PM +0200, Daniel Kiper wrote: > Hi, > > Due to very limited space in the setup_header this patch series introduces new > kernel_info struct which will be used to convey information from the kernel to > the bootloader. This way the boot protocol can be extended

Re: [Xen-devel] [PATCH v1 1/2] libxl: introduce new backend type VINPUT

2019-10-16 Thread Oleksandr Grytsov
On Fri, Oct 11, 2019 at 8:04 PM Ian Jackson wrote: > > Oleksandr Grytsov writes ("Re: [PATCH v1 1/2] libxl: introduce new backend > type VINPUT"): > > On Fri, Oct 11, 2019 at 5:58 PM Ian Jackson wrote: > > > I think it was a48e00f14a2d "libxl: add backend type and id to vkb" > > > which

Re: [Xen-devel] [XEN PATCH v1] libxl: Add DTB compatible list to config file

2019-10-16 Thread Julien Grall
Hi Oleksandr, On 16/10/2019 15:04, Oleksandr Grytsov wrote: On Fri, Oct 11, 2019 at 8:21 PM Stefano Stabellini wrote: On Fri, 11 Oct 2019, Julien Grall wrote: Hi, On 11/10/2019 16:23, Ian Jackson wrote: Oleksandr Grytsov writes ("[PATCH v1] libxl: Add DTB compatible list to config file"):

[Xen-devel] [xen-unstable test] 142777: regressions - FAIL

2019-10-16 Thread osstest service owner
flight 142777 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/142777/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-qemut-rhel6hvm-amd 12 guest-start/redhat.repeat fail REGR. vs. 142750

Re: [Xen-devel] [[PATCH for-4.13]] xen/arm: mm: Allow generic xen page-tables helpers to be called early

2019-10-16 Thread Julien Grall
Hi Hongyan, On 11/10/2019 10:53, Xia, Hongyan wrote: Not commenting on the patch, but I had exactly the same problem when removing the direct map in x86. map_domain_page has to be usable without the direct map and even before alloc_boot_pages can be used (so that I can map the

[Xen-devel] [xen-unstable-coverity test] 142802: all pass - PUSHED

2019-10-16 Thread osstest service owner
flight 142802 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/142802/ Perfect :-) All tests in this flight passed as required version targeted for testing: xen 55ab292c42db41b05cfdba012680bf1e0ea02f7a baseline version: xen

Re: [Xen-devel] [[PATCH for-4.13]] xen/arm: mm: Allow generic xen page-tables helpers to be called early

2019-10-16 Thread Xia, Hongyan
Hi Julien, Sure. You should be able to find it on directnonmap-v2.3 branch at https://xenbits.xen.org/git-http/people/hx242/xen.git. Commit: a4fef31b99388524d3f7748967c5d04a924cb7e3 x86: add Persistent Map (PMAP) infrastructure One thing to note is that the PMAP structure is really

Re: [Xen-devel] [XEN PATCH v1] libxl: Add DTB compatible list to config file

2019-10-16 Thread Oleksandr Grytsov
On Fri, Oct 11, 2019 at 8:21 PM Stefano Stabellini wrote: > > On Fri, 11 Oct 2019, Julien Grall wrote: > > Hi, > > > > On 11/10/2019 16:23, Ian Jackson wrote: > > > Oleksandr Grytsov writes ("[PATCH v1] libxl: Add DTB compatible list to > > > config file"): > > > > From: Oleksandr Grytsov > > >

Re: [Xen-devel] [XEN PATCH v1] libxl: Add DTB compatible list to config file

2019-10-16 Thread Oleksandr Grytsov
On Wed, Oct 16, 2019 at 5:12 PM Julien Grall wrote: > > Hi Oleksandr, > > On 16/10/2019 15:04, Oleksandr Grytsov wrote: > > On Fri, Oct 11, 2019 at 8:21 PM Stefano Stabellini > > wrote: > >> > >> On Fri, 11 Oct 2019, Julien Grall wrote: > >>> Hi, > >>> > >>> On 11/10/2019 16:23, Ian Jackson

Re: [Xen-devel] [XEN PATCH for-4.13 v1] Reset iomem's gfn to LIBXL_INVALID_GFN on reboot

2019-10-16 Thread Oleksandr Grytsov
On Mon, Oct 14, 2019 at 12:28 PM Julien Grall wrote: > > Hi Ian, > > On 11/10/2019 16:14, Ian Jackson wrote: > > Oleksandr Grytsov writes ("[PATCH v1] Reset iomem's gfn to > > LIBXL_INVALID_GFN on reboot"): > >> During domain reboot its configuration is partially reused > >> to re-create a new

[Xen-devel] Please Welcome Julien Grall as new Security Team Member

2019-10-16 Thread Lars Kurth
Dear Community members, I am pleased to announce that Julien Grallh has been nominated and voted to become a new member of the Xen Project security team. Julien has made significant contributions to the Xen Project over the years and has been a maintainer and project leadership team member

[Xen-devel] [freebsd-master test] 142803: regressions - trouble: blocked/fail

2019-10-16 Thread osstest service owner
flight 142803 freebsd-master real [real] http://logs.test-lab.xenproject.org/osstest/logs/142803/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-freebsd 7 freebsd-buildfail REGR. vs. 141501 Tests which did

Re: [Xen-devel] [PATCH -tip v4 0/4] x86: kprobes: Prohibit kprobes on Xen/KVM emulate prefixes

2019-10-16 Thread Masami Hiramatsu
Hi Peter, On Wed, 9 Oct 2019 14:31:06 +0200 Peter Zijlstra wrote: > On Tue, Sep 17, 2019 at 03:14:03PM +0900, Masami Hiramatsu wrote: > > Hi Peter, > > > > Could you review this version? > > These look good to me; shall I merge them or what was the plan? Thanks for the review, yes, could you

Re: [Xen-devel] [XEN PATCH v1] libxl: Add DTB compatible list to config file

2019-10-16 Thread Julien Grall
Hi, On 16/10/2019 15:34, Oleksandr Grytsov wrote: On Wed, Oct 16, 2019 at 5:12 PM Julien Grall wrote: Hi Oleksandr, On 16/10/2019 15:04, Oleksandr Grytsov wrote: On Fri, Oct 11, 2019 at 8:21 PM Stefano Stabellini wrote: On Fri, 11 Oct 2019, Julien Grall wrote: Hi, On 11/10/2019 16:23,

Re: [Xen-devel] [PATCH for-4.13] xen/arm: setup: Calculate correctly the size of Xen

2019-10-16 Thread Stefano Stabellini
On Wed, 16 Oct 2019, Julien Grall wrote: > The current size of Xen is computed using _end - _start + 1. However, > _end is pointing one past the end of Xen, so the size of Xen is > off-by-one. > > Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini > --- > xen/arch/arm/setup.c | 2

Re: [Xen-devel] [RFC] Documentation formats, licenses and file system structure

2019-10-16 Thread Rich Persaud
> On Oct 15, 2019, at 08:27, Lars Kurth wrote: > Hi Rich, > On 15 Oct 2019, at 02:58, Rich Persaud wrote: > On Oct 11, 2019, at 07:11, Lars Kurth wrote: >>> On 11/10/2019, 02:24, "Stefano Stabellini" wrote: On Thu, 10 Oct 2019, Lars Kurth wrote: @Stefano: as you and I