Re: [PATCH 07/17] xen/x86: traps: Convert __page_fault_type() to use typesafe MFN

2020-04-18 Thread Julien Grall
On 18/04/2020 12:01, Julien Grall wrote: On 26/03/2020 15:54, Jan Beulich wrote: On 22.03.2020 17:14, jul...@xen.org wrote: From: Julien Grall Note that the code is now using cr3_to_mfn() to get the MFN. This is slightly different as the top 12-bits will now be masked. And here I agree

Re: [PATCH 00/10] x86: mm (mainly shadow) adjustments

2020-04-18 Thread Tim Deegan
At 16:23 +0200 on 17 Apr (1587140581), Jan Beulich wrote: > Large parts of this series are to further isolate pieces which > are needed for HVM only, and hence would better not be built > with HVM=n. But there are also a few other items which I've > noticed along the road. Acked-by: Tim Deegan

Re: [PATCH 07/10] x86/shadow: the guess_wrmap() hook is needed for HVM only

2020-04-18 Thread Tim Deegan
At 16:28 +0200 on 17 Apr (1587140897), Jan Beulich wrote: > sh_remove_write_access() bails early for !external guests, and hence its > building and thus the need for the hook can be suppressed altogether in > !HVM configs. > > Signed-off-by: Jan Beulich > @@ -366,6 +367,14 @@ int

Re: [PATCH 6/6] x86/mem-paging: consistently use gfn_t

2020-04-18 Thread Julien Grall
Hi Jan, On 16/04/2020 16:48, Jan Beulich wrote: --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -2151,16 +2151,17 @@ static int mod_l1_entry(l1_pgentry_t *pl paging_mode_translate(pg_dom) ) { p2m_type_t p2mt; +unsigned long gfn =

Re: [PATCH 04/10] x86/shadow: sh_update_linear_entries() is a no-op for PV

2020-04-18 Thread Tim Deegan
At 16:26 +0200 on 17 Apr (1587140817), Jan Beulich wrote: > Consolidate the shadow_mode_external() in here: Check this once at the > start of the function. > > Signed-off-by: Jan Beulich > > --- a/xen/arch/x86/mm/shadow/multi.c > +++ b/xen/arch/x86/mm/shadow/multi.c > @@ -3707,34 +3707,30 @@

Re: [PATCH 07/17] xen/x86: traps: Convert __page_fault_type() to use typesafe MFN

2020-04-18 Thread Julien Grall
On 26/03/2020 15:54, Jan Beulich wrote: On 22.03.2020 17:14, jul...@xen.org wrote: From: Julien Grall Note that the code is now using cr3_to_mfn() to get the MFN. This is slightly different as the top 12-bits will now be masked. And here I agree with the change. Hence it is even more so

Re: [PATCH v3] Introduce a description of the Backport and Fixes tags

2020-04-18 Thread Wei Liu
On Fri, Apr 17, 2020 at 03:24:30PM -0700, Stefano Stabellini wrote: > Create a new document under docs/process to describe our special tags. > Add a description of the Fixes tag and the new Backport tag. Also > clarify that lines with tags should not be split. > > Signed-off-by: Stefano

[linux-linus test] 149703: tolerable FAIL - PUSHED

2020-04-18 Thread osstest service owner
flight 149703 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/149703/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-examine4 memdisk-try-append fail in 149697 pass in 149703

Re: [PATCH][RESEND] xen/arm: vgic-v3: fix GICD_ISACTIVER range

2020-04-18 Thread Julien Grall
Hi, On 18/04/2020 00:12, Stefano Stabellini wrote: On Fri, 17 Apr 2020, Julien Grall wrote: Hi, The title claim this is a resend, but this is actually not the latest version of this patch. Can you explain why you decided to use v1 rather than v2? Because v2 added a printk for every read,

Re: [PATCH 05/17] xen/x86: Remove the non-typesafe version of pagetable_* helpers

2020-04-18 Thread Julien Grall
Hi, On 30/03/2020 08:52, Jan Beulich wrote: On 28.03.2020 11:52, Julien Grall wrote: On 26/03/2020 15:39, Jan Beulich wrote: On 22.03.2020 17:14, jul...@xen.org wrote: @@ -3116,24 +3116,24 @@ int vcpu_destroy_pagetables(struct vcpu *v)     /* Free that page if non-zero */   do { -  

Re: [PATCH 06/17] xen/x86: mm: Fix the comment on top put_page_from_l2e() to use 'mfn'

2020-04-18 Thread Julien Grall
Hi Jan, On 26/03/2020 15:51, Jan Beulich wrote: On 22.03.2020 17:14, jul...@xen.org wrote: From: Julien Grall We are using the 'mfn' to refer to machine frame. As this function deal with 'mfn', replace 'pfn' with 'mfn'. Signed-off-by: Julien Grall --- I am not entirely sure to understand

Re: [PATCH 0/3] x86/pv: Start to trim 32bit support

2020-04-18 Thread Wei Liu
On Fri, Apr 17, 2020 at 04:50:01PM +0100, Andrew Cooper wrote: > Downstreams may want this for either security or performance reasons. Offer > some options, and take advantage of some of the very low hanging fruit it > offers. > > There is plenty more incremental cleanup which can be done at a