[xen-unstable test] 150234: regressions - FAIL

2020-05-19 Thread osstest service owner
flight 150234 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/150234/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 150227

[PATCH v10 11/12] tools/libxc: remove xc_set_parameters()

2020-05-19 Thread Juergen Gross
There is no user of xc_set_parameters() left, so remove it. Signed-off-by: Juergen Gross --- V6: - new patch --- tools/libxc/include/xenctrl.h | 1 - tools/libxc/xc_misc.c | 21 - 2 files changed, 22 deletions(-) diff --git a/tools/libxc/include/xenctrl.h

[PATCH v10 12/12] xen: remove XEN_SYSCTL_set_parameter support

2020-05-19 Thread Juergen Gross
The functionality of XEN_SYSCTL_set_parameter is available via hypfs now, so it can be removed. This allows to remove the kernel_param structure for runtime parameters by putting the now only used structure element into the hypfs node structure of the runtime parameters. Signed-off-by: Juergen

[PATCH v10 07/12] xen: provide version information in hypfs

2020-05-19 Thread Juergen Gross
Provide version and compile information in /buildinfo/ node of the Xen hypervisor file system. As this information is accessible by dom0 only no additional security problem arises. Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich --- V3: - new patch V4: - add __read_mostly annotations

[PATCH v10 02/12] xen: add a generic way to include binary files as variables

2020-05-19 Thread Juergen Gross
Add a new script xen/tools/binfile for including a binary file at build time being usable via a pointer and a size variable in the hypervisor. Make use of that generic tool in xsm. Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich Reviewed-by: Wei Liu --- V3: - new patch V4: - add

[PATCH v10 04/12] xen: add basic hypervisor filesystem support

2020-05-19 Thread Juergen Gross
Add the infrastructure for the hypervisor filesystem. This includes the hypercall interface and the base functions for entry creation, deletion and modification. In order not to have to repeat the same pattern multiple times in case adding a new node should BUG_ON() failure, the helpers for

[PATCH v10 08/12] xen: add /buildinfo/config entry to hypervisor filesystem

2020-05-19 Thread Juergen Gross
Add the /buildinfo/config entry to the hypervisor filesystem. This entry contains the .config file used to build the hypervisor. Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich --- V3: - store data in gzip format - use binfile mechanism to create data file - move code to kernel.c V6: -

[PATCH v10 09/12] xen: add runtime parameter access support to hypfs

2020-05-19 Thread Juergen Gross
Add support to read and modify values of hypervisor runtime parameters via the hypervisor file system. As runtime parameters can be modified via a sysctl, too, this path has to take the hypfs rw_lock as writer. For custom runtime parameters the connection between the parameter value and the file

[PATCH v10 03/12] docs: add feature document for Xen hypervisor sysfs-like support

2020-05-19 Thread Juergen Gross
On the 2019 Xen developer summit there was agreement that the Xen hypervisor should gain support for a hierarchical name-value store similar to the Linux kernel's sysfs. In the beginning there should only be basic support: entries can be added from the hypervisor itself only, there is a simple

[PATCH v10 05/12] libs: add libxenhypfs

2020-05-19 Thread Juergen Gross
Add the new library libxenhypfs for access to the hypervisor filesystem. Signed-off-by: Juergen Gross Acked-by: Wei Liu --- V1: - rename to libxenhypfs - add xenhypfs_write() V3: - major rework due to new hypervisor interface - add decompression capability V4: - add dependency to libz in

[PATCH v10 06/12] tools: add xenfs tool

2020-05-19 Thread Juergen Gross
Add the xenfs tool for accessing the hypervisor filesystem. Signed-off-by: Juergen Gross Acked-by: Wei Liu --- V1: - rename to xenhypfs - don't use "--" for subcommands - add write support V2: - escape non-printable characters per default with cat subcommand (Ian Jackson) - add -b option to

[PATCH v10 00/12] Add hypervisor sysfs-like support

2020-05-19 Thread Juergen Gross
On the 2019 Xen developer summit there was agreement that the Xen hypervisor should gain support for a hierarchical name-value store similar to the Linux kernel's sysfs. This is a first implementation of that idea adding the basic functionality to hypervisor and tools side. The interface to any

[PATCH v10 01/12] xen/vmx: let opt_ept_ad always reflect the current setting

2020-05-19 Thread Juergen Gross
In case opt_ept_ad has not been set explicitly by the user via command line or runtime parameter, it is treated as "no" on Avoton cpus. Change that handling by setting opt_ept_ad to 0 for this cpu type explicitly if no user value has been set. By putting this into the (renamed) boot time

[PATCH v10 10/12] tools/libxl: use libxenhypfs for setting xen runtime parameters

2020-05-19 Thread Juergen Gross
Instead of xc_set_parameters() use xenhypfs_write() for setting parameters of the hypervisor. Signed-off-by: Juergen Gross --- V6: - new patch --- tools/Rules.mk | 2 +- tools/libxl/Makefile | 3 +- tools/libxl/libxl.c | 53

[libvirt test] 150237: regressions - FAIL

2020-05-19 Thread osstest service owner
flight 150237 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/150237/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 146182 build-i386-libvirt

Re: [PATCH v10 02/12] xen: add a generic way to include binary files as variables

2020-05-19 Thread Jürgen Groß
On 19.05.20 09:47, Jan Beulich wrote: On 19.05.2020 09:20, Juergen Gross wrote: --- a/xen/xsm/flask/Makefile +++ b/xen/xsm/flask/Makefile @@ -39,6 +39,9 @@ $(subst include/,%/,$(AV_H_FILES)): $(AV_H_DEPEND) $(mkaccess) FORCE obj-bin-$(CONFIG_XSM_FLASK_POLICY) += flask-policy.o

Re: [PATCH v3 1/5] x86: suppress XPTI-related TLB flushes when possible

2020-05-19 Thread Jan Beulich
On 18.05.2020 19:09, Roger Pau Monné wrote: > On Wed, Sep 25, 2019 at 05:23:11PM +0200, Jan Beulich wrote: >> @@ -310,7 +313,16 @@ int pv_domain_initialise(struct domain * >> /* 64-bit PV guest by default. */ >> d->arch.is_32bit_pv = d->arch.has_32bit_shinfo = 0; >> >> -

RE: [PATCH v10 00/12] Add hypervisor sysfs-like support

2020-05-19 Thread Paul Durrant
> -Original Message- > From: Jan Beulich > Sent: 19 May 2020 08:45 > To: Jürgen Groß ; Kevin Tian ; Julien > Grall ; > Jun Nakajima ; Wei Liu ; Ian Jackson > ; > Daniel De Graaf ; Paul Durrant > Cc: xen-devel@lists.xenproject.org; Stefano Stabellini > ; Andrew Cooper > ; George Dunlap

Re: [PATCH v10 02/12] xen: add a generic way to include binary files as variables

2020-05-19 Thread Jürgen Groß
On 19.05.20 09:58, Jan Beulich wrote: On 19.05.2020 09:52, Jürgen Groß wrote: On 19.05.20 09:47, Jan Beulich wrote: On 19.05.2020 09:20, Juergen Gross wrote: --- a/xen/xsm/flask/Makefile +++ b/xen/xsm/flask/Makefile @@ -39,6 +39,9 @@ $(subst include/,%/,$(AV_H_FILES)): $(AV_H_DEPEND)

Re: IOCTL_PRIVCMD_MMAPBATCH on Xen 4.13.0

2020-05-19 Thread Manuel Bouyer
On Tue, May 19, 2020 at 09:34:30AM +0200, Jan Beulich wrote: > On 18.05.2020 19:31, Manuel Bouyer wrote: > > From what I found it seems that all unallocated memory is tagged > > p2m_mmio_dm, > > is it right ? > > Yes. For many years there has been a plan to better separate this from >

Re: [PATCH v3 1/5] x86: suppress XPTI-related TLB flushes when possible

2020-05-19 Thread Roger Pau Monné
On Tue, May 19, 2020 at 09:55:38AM +0200, Jan Beulich wrote: > On 18.05.2020 19:09, Roger Pau Monné wrote: > > On Wed, Sep 25, 2019 at 05:23:11PM +0200, Jan Beulich wrote: > >> @@ -310,7 +313,16 @@ int pv_domain_initialise(struct domain * > >> /* 64-bit PV guest by default. */ > >>

Re: [PATCH v10 00/12] Add hypervisor sysfs-like support

2020-05-19 Thread Jürgen Groß
On 19.05.20 09:20, Juergen Gross wrote: On the 2019 Xen developer summit there was agreement that the Xen hypervisor should gain support for a hierarchical name-value store similar to the Linux kernel's sysfs. This is a first implementation of that idea adding the basic functionality to

Re: [PATCH v10 00/12] Add hypervisor sysfs-like support

2020-05-19 Thread Jan Beulich
On 19.05.2020 09:30, Jürgen Groß wrote: > On 19.05.20 09:20, Juergen Gross wrote: >> >> Juergen Gross (12): >>xen/vmx: let opt_ept_ad always reflect the current setting >>xen: add a generic way to include binary files as variables >>docs: add feature document for Xen hypervisor

Re: [PATCH v10 02/12] xen: add a generic way to include binary files as variables

2020-05-19 Thread Jan Beulich
On 19.05.2020 09:20, Juergen Gross wrote: > --- a/xen/xsm/flask/Makefile > +++ b/xen/xsm/flask/Makefile > @@ -39,6 +39,9 @@ $(subst include/,%/,$(AV_H_FILES)): $(AV_H_DEPEND) > $(mkaccess) FORCE > obj-bin-$(CONFIG_XSM_FLASK_POLICY) += flask-policy.o > flask-policy.o: policy.bin > >

Re: [PATCH v10 11/12] tools/libxc: remove xc_set_parameters()

2020-05-19 Thread Wei Liu
On Tue, May 19, 2020 at 09:21:05AM +0200, Juergen Gross wrote: > There is no user of xc_set_parameters() left, so remove it. > > Signed-off-by: Juergen Gross Acked-by: Wei Liu

Re: [PATCH v10 10/12] tools/libxl: use libxenhypfs for setting xen runtime parameters

2020-05-19 Thread Wei Liu
On Tue, May 19, 2020 at 09:21:04AM +0200, Juergen Gross wrote: > Instead of xc_set_parameters() use xenhypfs_write() for setting > parameters of the hypervisor. > > Signed-off-by: Juergen Gross > --- > V6: > - new patch > --- > tools/Rules.mk | 2 +- > tools/libxl/Makefile

Re: [PATCH] x86/traps: Rework #PF[Rsvd] bit handling

2020-05-19 Thread Jan Beulich
On 18.05.2020 17:38, Andrew Cooper wrote: > @@ -1439,6 +1418,18 @@ void do_page_fault(struct cpu_user_regs *regs) > if ( unlikely(fixup_page_fault(addr, regs) != 0) ) > return; > > +/* > + * Xen have reserved bits in its pagetables, nor do we permit PV guests > to > +

Re: [PATCH v2 1/3] x86: relax GDT check in arch_set_info_guest()

2020-05-19 Thread Roger Pau Monné
On Fri, Dec 20, 2019 at 02:49:48PM +0100, Jan Beulich wrote: > It is wrong for us to check frames beyond the guest specified limit > (in the native case, other than in the compat one). Wouldn't this result in arch_set_info_guest failing if gdt_ents was smaller than the maximum? Or all callers

Re: [PATCH 02/16] x86/traps: Clean up printing in do_reserved_trap()/fatal_trap()

2020-05-19 Thread Jan Beulich
On 18.05.2020 18:54, Andrew Cooper wrote: > On 11/05/2020 16:09, Jan Beulich wrote: >> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments >> unless you have verified the sender and know the content is safe. >> >> On 11.05.2020 17:01, Andrew Cooper wrote: >>> On 04/05/2020

Re: [XEN PATCH 2/2] tools: Use INSTALL_PYTHON_PROG

2020-05-19 Thread Wei Liu
On Wed, Mar 11, 2020 at 05:59:33PM +, Anthony PERARD wrote: > Whenever python scripts are install, have the shebang be modified to use > whatever PYTHON_PATH is. This is useful for system where python isn't > available, or > where the package build tools prevent unversioned shebang. > >

Re: [XEN PATCH 1/2] tools/python: Fix install-wrap

2020-05-19 Thread Wei Liu
On Wed, Mar 11, 2020 at 05:59:32PM +, Anthony PERARD wrote: > This allows to use install-wrap when the source scripts is in a > subdirectory. > > Signed-off-by: Anthony PERARD > --- > tools/python/install-wrap | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH v2 1/3] x86: relax GDT check in arch_set_info_guest()

2020-05-19 Thread Jan Beulich
On 19.05.2020 10:42, Roger Pau Monné wrote: > On Fri, Dec 20, 2019 at 02:49:48PM +0100, Jan Beulich wrote: >> It is wrong for us to check frames beyond the guest specified limit >> (in the native case, other than in the compat one). > > Wouldn't this result in arch_set_info_guest failing if

Re: [PATCH v10 02/12] xen: add a generic way to include binary files as variables

2020-05-19 Thread Jan Beulich
On 19.05.2020 09:52, Jürgen Groß wrote: > On 19.05.20 09:47, Jan Beulich wrote: >> On 19.05.2020 09:20, Juergen Gross wrote: >>> --- a/xen/xsm/flask/Makefile >>> +++ b/xen/xsm/flask/Makefile >>> @@ -39,6 +39,9 @@ $(subst include/,%/,$(AV_H_FILES)): $(AV_H_DEPEND) >>> $(mkaccess) FORCE >>>

Re: [PATCH] x86/traps: Rework #PF[Rsvd] bit handling

2020-05-19 Thread Jan Beulich
On 18.05.2020 17:38, Andrew Cooper wrote: > The reserved_bit_page_fault() paths effectively turn reserved bit faults into > a warning, but in the light of L1TF, the real impact is far more serious. > > Xen does not have any reserved bits set in its pagetables, nor do we permit PV > guests to

Re: [PATCH v7 00/19] Add support for qemu-xen runnning in a Linux-based stubdomain

2020-05-19 Thread Wei Liu
I have queued up the first 5 patches for committing today. Wei.

Re: IOCTL_PRIVCMD_MMAPBATCH on Xen 4.13.0

2020-05-19 Thread Jan Beulich
On 19.05.2020 10:46, Manuel Bouyer wrote: > Note that I'm using the 4.13.0 release sources, not the top of branch. > Is it something that could have been fixed after the release ? I don't recall anything, but switching to 4.13.1 would still seem like a helpful thing for you to do. Jan

Re: [PATCH v2 2/3] x86: relax LDT check in arch_set_info_guest()

2020-05-19 Thread Roger Pau Monné
On Tue, May 19, 2020 at 11:12:49AM +0200, Jan Beulich wrote: > On 19.05.2020 11:02, Roger Pau Monné wrote: > > On Fri, Dec 20, 2019 at 02:50:06PM +0100, Jan Beulich wrote: > >> It is wrong for us to check the base address when there's no LDT in the > >> first place. Once we don't do this check

Re: IOCTL_PRIVCMD_MMAPBATCH on Xen 4.13.0

2020-05-19 Thread Jan Beulich
On 18.05.2020 19:31, Manuel Bouyer wrote: > From what I found it seems that all unallocated memory is tagged p2m_mmio_dm, > is it right ? Yes. For many years there has been a plan to better separate this from p2m_invalid ... Jan

Re: [PATCH v2 2/3] x86: relax LDT check in arch_set_info_guest()

2020-05-19 Thread Roger Pau Monné
On Fri, Dec 20, 2019 at 02:50:06PM +0100, Jan Beulich wrote: > It is wrong for us to check the base address when there's no LDT in the > first place. Once we don't do this check anymore we can also set the > base address to a non-canonical value when the LDT is empty. > > Signed-off-by: Jan

Re: [PATCH v2 2/3] x86: relax LDT check in arch_set_info_guest()

2020-05-19 Thread Jan Beulich
On 19.05.2020 11:02, Roger Pau Monné wrote: > On Fri, Dec 20, 2019 at 02:50:06PM +0100, Jan Beulich wrote: >> It is wrong for us to check the base address when there's no LDT in the >> first place. Once we don't do this check anymore we can also set the >> base address to a non-canonical value

Re: [PATCH v3 1/5] x86: suppress XPTI-related TLB flushes when possible

2020-05-19 Thread Jan Beulich
On 19.05.2020 11:15, Roger Pau Monné wrote: > On Tue, May 19, 2020 at 09:55:38AM +0200, Jan Beulich wrote: >> On 18.05.2020 19:09, Roger Pau Monné wrote: >>> On Wed, Sep 25, 2019 at 05:23:11PM +0200, Jan Beulich wrote: @@ -310,7 +313,16 @@ int pv_domain_initialise(struct domain * /*

Re: [PATCH] changelog: add relevant changes during 4.14 development window

2020-05-19 Thread Roger Pau Monné
On Mon, May 11, 2020 at 03:10:07PM +0200, Jan Beulich wrote: > [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments > unless you have verified the sender and know the content is safe. > > On 11.05.2020 12:31, Roger Pau Monne wrote: > > Add entries for the relevant changes

Re: [XEN PATCH 1/2] tools/python: Fix install-wrap

2020-05-19 Thread Anthony PERARD
On Tue, May 19, 2020 at 09:58:15AM +0100, Wei Liu wrote: > [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments > unless you have verified the sender and know the content is safe. > > On Wed, Mar 11, 2020 at 05:59:32PM +, Anthony PERARD wrote: > > This allows to use

Re: [PATCH] changelog: add relevant changes during 4.14 development window

2020-05-19 Thread Jan Beulich
On 19.05.2020 11:43, Roger Pau Monné wrote: > On Mon, May 11, 2020 at 03:10:07PM +0200, Jan Beulich wrote: >> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments >> unless you have verified the sender and know the content is safe. >> >> On 11.05.2020 12:31, Roger Pau Monne

Re: IOCTL_PRIVCMD_MMAPBATCH on Xen 4.13.0

2020-05-19 Thread Roger Pau Monné
On Sun, May 17, 2020 at 07:56:07PM +0200, Manuel Bouyer wrote: > On Sun, May 17, 2020 at 07:32:59PM +0200, Manuel Bouyer wrote: > > I've been looking a bit deeper in the Xen kernel. > > The mapping is failed in ./arch/x86/mm/p2m.c:p2m_get_page_from_gfn(), > > /* Error path: not a suitable

Re: [XEN PATCH 1/2] tools/python: Fix install-wrap

2020-05-19 Thread Wei Liu
On Tue, May 19, 2020 at 10:42:22AM +0100, Anthony PERARD wrote: > On Tue, May 19, 2020 at 09:58:15AM +0100, Wei Liu wrote: > > [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments > > unless you have verified the sender and know the content is safe. > > Haha :-) > > On

Re: IOCTL_PRIVCMD_MMAPBATCH on Xen 4.13.0

2020-05-19 Thread Manuel Bouyer
On Tue, May 19, 2020 at 11:54:07AM +0200, Roger Pau Monné wrote: > FWIW, FreeBSD doesn't have osdep_xenforeignmemory_map_resource > implemented and still works fine with 4.13.0 (is able to create HVM > guests), but that's a PVH dom0, not a PV one. Yes, FreeBSD is PVH-nnly. This implies different

Re: [PATCH] xen: fix build without pci passthrough

2020-05-19 Thread Roger Pau Monné
On Mon, May 11, 2020 at 02:40:43PM +0100, Anthony PERARD wrote: > On Mon, May 04, 2020 at 12:14:43PM +0200, Roger Pau Monne wrote: > > diff --git a/hw/xen/xen_pt.h b/hw/xen/xen_pt.h > > index 179775db7b..660dd8a008 100644 > > --- a/hw/xen/xen_pt.h > > +++ b/hw/xen/xen_pt.h > > @@ -1,6 +1,7 @@ > >

[linux-linus test] 150236: regressions - FAIL

2020-05-19 Thread osstest service owner
flight 150236 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/150236/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-vhd 11 guest-start fail REGR. vs. 150230 Tests which did

Re: [PATCH] xen: fix build without pci passthrough

2020-05-19 Thread Peter Maydell
On Tue, 19 May 2020 at 12:28, Roger Pau Monné wrote: > > On Mon, May 11, 2020 at 02:40:43PM +0100, Anthony PERARD wrote: > > On Mon, May 04, 2020 at 12:14:43PM +0200, Roger Pau Monne wrote: > > > diff --git a/hw/xen/xen_pt.h b/hw/xen/xen_pt.h > > > index 179775db7b..660dd8a008 100644 > > > ---

[xen-unstable-smoke test] 150242: tolerable all pass - PUSHED

2020-05-19 Thread osstest service owner
flight 150242 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/150242/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [PATCH v3 1/5] xen/common: introduce a new framework for save/restore of 'domain' context

2020-05-19 Thread Jan Beulich
On 14.05.2020 12:44, Paul Durrant wrote: > --- /dev/null > +++ b/xen/common/save.c > @@ -0,0 +1,313 @@ > +/* > + * save.c: Save and restore PV guest state common to all domain types. > + * > + * Copyright Amazon.com Inc. or its affiliates. > + * > + * This program is free software; you can

RE: [PATCH v3 1/5] xen/common: introduce a new framework for save/restore of 'domain' context

2020-05-19 Thread Paul Durrant
> -Original Message- > From: Jan Beulich > Sent: 19 May 2020 14:04 > To: Paul Durrant > Cc: xen-devel@lists.xenproject.org; Paul Durrant ; > Andrew Cooper > ; George Dunlap ; Ian > Jackson > ; Julien Grall ; Stefano Stabellini > ; Wei Liu ; Volodymyr Babchuk > ; Roger > Pau Monné >

Re: [PATCH] x86/traps: Rework #PF[Rsvd] bit handling

2020-05-19 Thread Andrew Cooper
On 19/05/2020 09:14, Jan Beulich wrote: > On 18.05.2020 17:38, Andrew Cooper wrote: >> The reserved_bit_page_fault() paths effectively turn reserved bit faults into >> a warning, but in the light of L1TF, the real impact is far more serious. >> >> Xen does not have any reserved bits set in its

Re: [PATCH] x86/traps: Rework #PF[Rsvd] bit handling

2020-05-19 Thread Jan Beulich
On 19.05.2020 16:29, Andrew Cooper wrote: > On 19/05/2020 09:14, Jan Beulich wrote: >> On 18.05.2020 17:38, Andrew Cooper wrote: >>> The reserved_bit_page_fault() paths effectively turn reserved bit faults >>> into >>> a warning, but in the light of L1TF, the real impact is far more serious. >>>

Re: [PATCH v3 1/5] xen/common: introduce a new framework for save/restore of 'domain' context

2020-05-19 Thread Jan Beulich
On 19.05.2020 17:10, Paul Durrant wrote: >> From: Jan Beulich >> Sent: 19 May 2020 15:24 >> >> On 19.05.2020 16:04, Paul Durrant wrote: From: Jan Beulich Sent: 19 May 2020 14:04 On 14.05.2020 12:44, Paul Durrant wrote: > +/* > + * Register save and restore handlers.

[PATCH] x86/mem-paging: further adjustments to p2m_mem_paging_prep()'s error handling

2020-05-19 Thread Jan Beulich
Address late comments on ecb913be4aaa ("x86/mem-paging: correct p2m_mem_paging_prep()'s error handling"): - insert a gprintk() ahead of domain_crash(), - add a comment. Requested-by: Andrew Cooper Signed-off-by: Jan Beulich --- a/xen/arch/x86/mm/mem_paging.c +++ b/xen/arch/x86/mm/mem_paging.c

Re: [PATCH] x86/traps: Rework #PF[Rsvd] bit handling

2020-05-19 Thread Andrew Cooper
On 19/05/2020 15:55, Jan Beulich wrote: > On 19.05.2020 16:29, Andrew Cooper wrote: >> On 19/05/2020 09:14, Jan Beulich wrote: >>> On 18.05.2020 17:38, Andrew Cooper wrote: The reserved_bit_page_fault() paths effectively turn reserved bit faults into a warning, but in the light of

[xen-unstable-smoke test] 150245: tolerable all pass - PUSHED

2020-05-19 Thread osstest service owner
flight 150245 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/150245/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [PATCH 6/7] xen/guest_access: Consolidate guest access helpers in xen/guest_access.h

2020-05-19 Thread Ian Jackson
Hi. My attention was drawn to this thread. As I understand it, everyone is agreed that deduplicating the implementation is good (I also agree). The debate is only between: 1. Put it in xen/ until an arch comes along that needs something different, at which point maybe introduce an

Re: [PATCH v7 07/19] libxl: write qemu arguments into separate xenstore keys

2020-05-19 Thread Wei Liu
On Tue, May 19, 2020 at 04:10:09PM +0100, Ian Jackson wrote: > Jason Andryuk writes ("[PATCH v7 07/19] libxl: write qemu arguments into > separate xenstore keys"): > > From: Marek Marczykowski-Górecki > > > > This allows using arguments with spaces, like -append, without > > nominating any

RE: [PATCH v3 4/5] common/domain: add a domain context record for shared_info...

2020-05-19 Thread Paul Durrant
> -Original Message- > From: Jan Beulich > Sent: 19 May 2020 15:08 > To: Paul Durrant > Cc: xen-devel@lists.xenproject.org; Paul Durrant ; Ian > Jackson > ; Wei Liu ; Andrew Cooper > ; George > Dunlap ; Julien Grall ; Stefano > Stabellini > > Subject: Re: [PATCH v3 4/5]

Re: [PATCH v3 2/5] xen/common/domctl: introduce XEN_DOMCTL_get/setdomaincontext

2020-05-19 Thread Jan Beulich
On 14.05.2020 12:44, Paul Durrant wrote: > --- a/xen/include/public/domctl.h > +++ b/xen/include/public/domctl.h > @@ -1129,6 +1129,43 @@ struct xen_domctl_vuart_op { > */ > }; > > +/* > + * XEN_DOMCTL_getdomaincontext > + * --- > + * >

[PATCH v2] xen: fix build without pci passthrough

2020-05-19 Thread Roger Pau Monne
has_igd_gfx_passthru is only available when QEMU is built with CONFIG_XEN_PCI_PASSTHROUGH, and hence shouldn't be used in common code without checking if it's available. Fixes: 46472d82322d0 ('xen: convert "-machine igd-passthru" to an accelerator property') Signed-off-by: Roger Pau Monné ---

Re: [PATCH] x86/traps: Rework #PF[Rsvd] bit handling

2020-05-19 Thread Jan Beulich
On 19.05.2020 16:11, Andrew Cooper wrote: > On 19/05/2020 09:34, Jan Beulich wrote: >> On 18.05.2020 17:38, Andrew Cooper wrote: >>> @@ -1439,6 +1418,18 @@ void do_page_fault(struct cpu_user_regs *regs) >>> if ( unlikely(fixup_page_fault(addr, regs) != 0) ) >>> return; >>> >>> +

RE: [PATCH v3 1/5] xen/common: introduce a new framework for save/restore of 'domain' context

2020-05-19 Thread Paul Durrant
> -Original Message- > From: Jan Beulich > Sent: 19 May 2020 15:24 > To: p...@xen.org > Cc: xen-devel@lists.xenproject.org; 'Paul Durrant' ; > 'Andrew Cooper' > ; 'George Dunlap' ; 'Ian > Jackson' > ; 'Julien Grall' ; 'Stefano > Stabellini' > ; 'Wei Liu' ; 'Volodymyr Babchuk' > ; >

Re: [PATCH v7 07/19] libxl: write qemu arguments into separate xenstore keys

2020-05-19 Thread Ian Jackson
Jason Andryuk writes ("[PATCH v7 07/19] libxl: write qemu arguments into separate xenstore keys"): > From: Marek Marczykowski-Górecki > > This allows using arguments with spaces, like -append, without > nominating any special "separator" character. > > Signed-off-by: Marek Marczykowski-Górecki

Re: [PATCH] x86/mem-paging: further adjustments to p2m_mem_paging_prep()'s error handling

2020-05-19 Thread Andrew Cooper
On 19/05/2020 16:28, Jan Beulich wrote: > Address late comments on ecb913be4aaa ("x86/mem-paging: correct > p2m_mem_paging_prep()'s error handling"): > - insert a gprintk() ahead of domain_crash(), > - add a comment. > > Requested-by: Andrew Cooper > Signed-off-by: Jan Beulich Reviewed-by:

RE: [PATCH v3 1/5] xen/common: introduce a new framework for save/restore of 'domain' context

2020-05-19 Thread Paul Durrant
> -Original Message- > From: Jan Beulich > Sent: 19 May 2020 16:18 > To: p...@xen.org > Cc: xen-devel@lists.xenproject.org; 'Paul Durrant' ; > 'Andrew Cooper' > ; 'George Dunlap' ; 'Ian > Jackson' > ; 'Julien Grall' ; 'Stefano > Stabellini' > ; 'Wei Liu' ; 'Volodymyr Babchuk' > ; >

Re: [PATCH v2] xen: fix build without pci passthrough

2020-05-19 Thread Anthony PERARD
On Tue, May 19, 2020 at 04:31:01PM +0200, Roger Pau Monne wrote: > has_igd_gfx_passthru is only available when QEMU is built with > CONFIG_XEN_PCI_PASSTHROUGH, and hence shouldn't be used in common > code without checking if it's available. > > Fixes: 46472d82322d0 ('xen: convert "-machine

Re: [PATCH for-4.14 2/3] xen/arm: Take into account the DMA width when allocating Dom0 memory banks

2020-05-19 Thread Julien Grall
On 18/05/2020 21:34, Volodymyr Babchuk wrote: Hi Julien, Hi Volodymyr, Thank you for the review. On Mon, 2020-05-18 at 12:30 +0100, Julien Grall wrote: From: Julien Grall At the moment, Xen is assuming that all the devices are at least 32-bit DMA capable. However, some SoCs have

Re: [PATCH] xen: fix build without pci passthrough

2020-05-19 Thread Roger Pau Monné
On Tue, May 19, 2020 at 01:20:51PM +0100, Peter Maydell wrote: > On Tue, 19 May 2020 at 12:28, Roger Pau Monné wrote: > > > > On Mon, May 11, 2020 at 02:40:43PM +0100, Anthony PERARD wrote: > > > On Mon, May 04, 2020 at 12:14:43PM +0200, Roger Pau Monne wrote: > > > > diff --git a/hw/xen/xen_pt.h

RE: [PATCH v3 1/5] xen/common: introduce a new framework for save/restore of 'domain' context

2020-05-19 Thread Paul Durrant
> -Original Message- > From: Jan Beulich > Sent: 19 May 2020 16:37 > To: p...@xen.org > Cc: xen-devel@lists.xenproject.org; 'Paul Durrant' ; > 'Andrew Cooper' > ; 'George Dunlap' ; 'Ian > Jackson' > ; 'Julien Grall' ; 'Stefano > Stabellini' > ; 'Wei Liu' ; 'Volodymyr Babchuk' > ; >

[xen-unstable test] 150238: regressions - FAIL

2020-05-19 Thread osstest service owner
flight 150238 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/150238/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-examine 4 memdisk-try-append fail REGR. vs. 150227 Tests which did

Re: [PATCH v3 4/5] common/domain: add a domain context record for shared_info...

2020-05-19 Thread Jan Beulich
On 14.05.2020 12:44, Paul Durrant wrote: > @@ -61,6 +62,76 @@ static void dump_header(void) > > } > > +static void print_binary(const char *prefix, void *val, size_t size, const also for val? > + const char *suffix) > +{ > +printf("%s", prefix); > + > +while

Re: [PATCH v3 1/5] xen/common: introduce a new framework for save/restore of 'domain' context

2020-05-19 Thread Jan Beulich
On 19.05.2020 16:04, Paul Durrant wrote: >> From: Jan Beulich >> Sent: 19 May 2020 14:04 >> >> On 14.05.2020 12:44, Paul Durrant wrote: >>> --- /dev/null >>> +++ b/xen/include/xen/save.h >>> @@ -0,0 +1,165 @@ >>> +/* >>> + * save.h: support routines for save/restore >>> + * >>> + * Copyright

Re: [PATCH v7 06/19] libxl: Use libxl__xs_* in libxl__write_stub_dmargs

2020-05-19 Thread Ian Jackson
Jason Andryuk writes ("[PATCH v7 06/19] libxl: Use libxl__xs_* in libxl__write_stub_dmargs"): > Re-work libxl__write_stub_dmargs to use libxl_xs_* functions in a loop. Cool, thank you! Acked-by: Ian Jackson

Re: [PATCH v3 4/5] common/domain: add a domain context record for shared_info...

2020-05-19 Thread Jan Beulich
On 19.05.2020 17:21, Paul Durrant wrote: >> From: Jan Beulich >> Sent: 19 May 2020 15:08 >> >> On 14.05.2020 12:44, Paul Durrant wrote: >>> --- a/xen/include/public/save.h >>> +++ b/xen/include/public/save.h >>> @@ -73,7 +73,16 @@ struct domain_save_header { >>> }; >>>

Re: [PATCH v7 07/19] libxl: write qemu arguments into separate xenstore keys

2020-05-19 Thread Jason Andryuk
On Tue, May 19, 2020 at 11:21 AM Wei Liu wrote: > > On Tue, May 19, 2020 at 04:10:09PM +0100, Ian Jackson wrote: > > Jason Andryuk writes ("[PATCH v7 07/19] libxl: write qemu arguments into > > separate xenstore keys"): > > > From: Marek Marczykowski-Górecki > > > > > > This allows using

Re: [PATCH] x86/traps: Rework #PF[Rsvd] bit handling

2020-05-19 Thread Andrew Cooper
On 19/05/2020 15:48, Jan Beulich wrote: > On 19.05.2020 16:11, Andrew Cooper wrote: >> On 19/05/2020 09:34, Jan Beulich wrote: >>> On 18.05.2020 17:38, Andrew Cooper wrote: @@ -1439,6 +1418,18 @@ void do_page_fault(struct cpu_user_regs *regs) if ( unlikely(fixup_page_fault(addr,

Re: [PATCH] x86/traps: Rework #PF[Rsvd] bit handling

2020-05-19 Thread Jan Beulich
On 19.05.2020 17:33, Andrew Cooper wrote: > On 19/05/2020 15:48, Jan Beulich wrote: >> On 19.05.2020 16:11, Andrew Cooper wrote: >>> Given that shadow frames are limited to 44 bits anyway (and not yet >>> levelled safely in the migration stream), my suggestion for fixing this >>> was just to use

Re: [PATCH] x86/traps: Rework #PF[Rsvd] bit handling

2020-05-19 Thread Andrew Cooper
On 19/05/2020 09:34, Jan Beulich wrote: > On 18.05.2020 17:38, Andrew Cooper wrote: >> @@ -1439,6 +1418,18 @@ void do_page_fault(struct cpu_user_regs *regs) >> if ( unlikely(fixup_page_fault(addr, regs) != 0) ) >> return; >> >> +/* >> + * Xen have reserved bits in its

RE: [PATCH v3 2/5] xen/common/domctl: introduce XEN_DOMCTL_get/setdomaincontext

2020-05-19 Thread Paul Durrant
> -Original Message- > From: Jan Beulich > Sent: 19 May 2020 14:49 > To: Paul Durrant > Cc: xen-devel@lists.xenproject.org; Paul Durrant ; > Daniel De Graaf > ; Ian Jackson ; Wei Liu > ; Andrew Cooper > ; George Dunlap ; Julien > Grall ; > Stefano Stabellini > Subject: Re: [PATCH v3

RE: [PATCH v3 4/5] common/domain: add a domain context record for shared_info...

2020-05-19 Thread Paul Durrant
> -Original Message- > From: Jan Beulich > Sent: 19 May 2020 16:34 > To: p...@xen.org > Cc: xen-devel@lists.xenproject.org; 'Paul Durrant' ; > 'Ian Jackson' > ; 'Wei Liu' ; 'Andrew Cooper' > ; > 'George Dunlap' ; 'Julien Grall' ; > 'Stefano Stabellini' > > Subject: Re: [PATCH v3 4/5]

Re: [PATCH v3 1/5] xen/common: introduce a new framework for save/restore of 'domain' context

2020-05-19 Thread Jan Beulich
On 19.05.2020 17:32, Paul Durrant wrote: >> -Original Message- >> From: Jan Beulich >> Sent: 19 May 2020 16:18 >> To: p...@xen.org >> Cc: xen-devel@lists.xenproject.org; 'Paul Durrant' ; >> 'Andrew Cooper' >> ; 'George Dunlap' ; >> 'Ian Jackson' >> ; 'Julien Grall' ; 'Stefano >>

[PATCH v2 for-4.14 0/3] Remove the 1GB limitation on Rasberry Pi 4

2020-05-19 Thread Julien Grall
From: Julien Grall Hi all, At the moment, a user who wants to boot Xen on the Raspberry Pi 4 can only use the first GB of memory. This is because several devices cannot DMA above 1GB but Xen doesn't necessarily allocate memory for Dom0 below 1GB. This small series is trying to address the

[PATCH v2 for-4.14 2/3] xen/arm: Take into account the DMA width when allocating Dom0 memory banks

2020-05-19 Thread Julien Grall
From: Julien Grall At the moment, Xen is assuming that all the devices are at least 32-bit DMA capable. However, some SoCs have devices that may be able to access a much restricted range. For instance, the Raspberry PI 4 has devices that can only access the first GB of RAM. The function

[PATCH v2 for-4.14 1/3] xen/arm: Allow a platform to override the DMA width

2020-05-19 Thread Julien Grall
From: Julien Grall At the moment, Xen is assuming that all the devices are at least 32-bit DMA capable. However, some SoC have devices that may be able to access a much restricted range. For instance, the RPI has devices that can only access the first 1GB of RAM. The structure platform_desc is

[PATCH v2 for-4.14 3/3] xen/arm: plat: Allocate as much as possible memory below 1GB for dom0 for RPI

2020-05-19 Thread Julien Grall
From: Julien Grall The raspberry PI 4 has devices that can only DMA into the first GB of the RAM. Therefore we want allocate as much as possible memory below 1GB for dom0. Use the recently introduced dma_bitsize field to specify the DMA width supported. Signed-off-by: Julien Grall

[qemu-mainline test] 150243: tolerable FAIL - PUSHED

2020-05-19 Thread osstest service owner
flight 150243 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/150243/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-rtds 18 guest-localmigrate/x10 fail like 150235

Re: [PATCH for-4.14 3/3] xen/arm: plat: Allocate as much as possible memory below 1GB for dom0 for RPI

2020-05-19 Thread Julien Grall
On 18/05/2020 21:36, Volodymyr Babchuk wrote: Hi Julien, Hi, On Mon, 2020-05-18 at 12:30 +0100, Julien Grall wrote: From: Julien Grall The raspberry PI 4 has devices that can only DMA into the first GB of the RAM. Therefore we want allocate as much as possible memory below 1GB for

Re: [PATCH for-4.14 3/3] xen/arm: plat: Allocate as much as possible memory below 1GB for dom0 for RPI

2020-05-19 Thread Julien Grall
Hi Corey, On 19/05/2020 01:02, Corey Minyard wrote: On Mon, May 18, 2020 at 08:36:08PM +, Volodymyr Babchuk wrote: Hi Julien, On Mon, 2020-05-18 at 12:30 +0100, Julien Grall wrote: From: Julien Grall The raspberry PI 4 has devices that can only DMA into the first GB of the RAM.

[OSSTEST PATCH 35/38] buster: setupboot_grub2: Note what files exist in /boot

2020-05-19 Thread Ian Jackson
Nothing uses this yet. Signed-off-by: Ian Jackson --- Osstest/Debian.pm | 5 + 1 file changed, 5 insertions(+) diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm index 151677ed..c0b669c9 100644 --- a/Osstest/Debian.pm +++ b/Osstest/Debian.pm @@ -448,6 +448,11 @@ sub setupboot_grub2 ()

[OSSTEST PATCH 32/38] buster: chiark-scripts: Install a new version on buster too

2020-05-19 Thread Ian Jackson
We need various fixes that are not in buster, sadly. Signed-off-by: Ian Jackson --- production-config | 1 + 1 file changed, 1 insertion(+) diff --git a/production-config b/production-config index f0ddc132..e3870d47 100644 --- a/production-config +++ b/production-config @@ -107,6 +107,7 @@

[OSSTEST PATCH 34/38] buster: grub, arm64: extend chainloading workaround

2020-05-19 Thread Ian Jackson
multiboot[2] isn't supported. Also link to the bug report. CC: Julien Grall CC: Stefano Stabellini Signed-off-by: Ian Jackson --- Osstest/Debian.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm index 77508d19..151677ed 100644 ---

[OSSTEST PATCH 29/38] mg-debian-installer-update: support overlay-intramfs-SUITE

2020-05-19 Thread Ian Jackson
This lets us patch the installer more easily. No uses yet. Signed-off-by: Ian Jackson --- mg-debian-installer-update | 20 1 file changed, 20 insertions(+) diff --git a/mg-debian-installer-update b/mg-debian-installer-update index f1e682f9..fb4fe2ab 100755 ---

[OSSTEST PATCH 21/38] buster: Extend ARM clock workaround

2020-05-19 Thread Ian Jackson
CC: Julien Grall CC: Stefano Stabellini Signed-off-by: Ian Jackson --- Osstest/Debian.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm index bec72788..6fed0b75 100644 --- a/Osstest/Debian.pm +++ b/Osstest/Debian.pm @@ -248,7 +248,7 @@

[OSSTEST PATCH 17/38] buster: ts-host-install: Extend net.ifnames workaround

2020-05-19 Thread Ian Jackson
Really we should fix this by making a .deb in Debian that we could install. But this is a longer-term project. Signed-off-by: Ian Jackson --- ts-host-install | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ts-host-install b/ts-host-install index 7a72a867..fe26f70f 100755

[OSSTEST PATCH 37/38] buster: Extend workaround for dhcpd EROFS bug

2020-05-19 Thread Ian Jackson
Signed-off-by: Ian Jackson --- Osstest/Debian.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm index 6c289cc7..e1ce757e 100644 --- a/Osstest/Debian.pm +++ b/Osstest/Debian.pm @@ -1617,7 +1617,7 @@ sub debian_dhcp_rofs_fix ($$) { #

[OSSTEST PATCH 00/38] Upgrade most hosts/guests to buster

2020-05-19 Thread Ian Jackson
buster is Debian stable right now. We don't want to be using oldstable because Debian have a history of breaking it. Paul: we should have a conversation about whether this should be pushed soon, or deferred until after the Xen 4.14 release. I have yet to do a final full formal retest of this

  1   2   >