RE: [PATCH v4 1/9] xen/dt: dt_property_read_string should return -ENODATA on !length

2022-04-01 Thread Henry Wang
Hi Stefano, > -Original Message- > From: Xen-devel On Behalf Of > Stefano Stabellini > Sent: Friday, April 1, 2022 8:39 AM > To: xen-devel@lists.xenproject.org > Cc: sstabell...@kernel.org; jgr...@suse.com; Bertrand Marquis > ; jul...@xen.org; > volodymyr_babc...@epam.com; Stefano Stabell

Re: [PATCH v3 3/5] xen/arm: configure dom0less domain for enabling xenstore after boot

2022-04-01 Thread Julien Grall
Hi Stefano, On 01/04/2022 01:34, Stefano Stabellini wrote: Because (as you noted as a comment to the following patch) as soon as d->arch.hvm.params[HVM_PARAM_STORE_PFN] is set the guest can continue with the initialization and will expect the right data to be set on the page. I think you misun

[xen-unstable test] 169063: tolerable FAIL

2022-04-01 Thread osstest service owner
flight 169063 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/169063/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 169003 test-armhf-armhf-libvirt 16 save

[xen-4.14-testing bisection] complete test-amd64-i386-livepatch

2022-04-01 Thread osstest service owner
branch xen-4.14-testing xenbranch xen-4.14-testing job test-amd64-i386-livepatch testid livepatch-run Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu git://xenbits.xe

Re: [PATCH v3 5/5] tools: add example application to initialize dom0less PV drivers

2022-04-01 Thread Julien Grall
Hi Stefano, On 01/04/2022 01:35, Stefano Stabellini wrote: + +/* Alloc magic pages */ +if (alloc_magic_pages(info, &dom) != 0) { +printf("Error on alloc magic pages\n"); +return 1; +} + +xc_dom_gnttab_init(&dom); This call as the risk to break the guest if the d

Re: [PATCH v4 3/8] x86/EFI: retrieve EDID

2022-04-01 Thread Luca Fancellu
> On 31 Mar 2022, at 10:45, Jan Beulich wrote: > > When booting directly from EFI, obtaining this information from EFI is > the only possible way. And even when booting with a boot loader > interposed, it's more clean not to use legacy BIOS calls for this > purpose. (The downside being that th

Re: [PATCH v4 8/9] tools: add example application to initialize dom0less PV drivers

2022-04-01 Thread Julien Grall
Hi, I have posted some comments in v3 after you sent this version. Please have a look. On 01/04/2022 01:38, Stefano Stabellini wrote: +static int init_domain(struct xs_handle *xsh, libxl_dominfo *info) +{ +struct xc_interface_core *xch; +libxl_uuid uuid; +uint64_t xenstore_evtchn,

Re: [PATCH v3 5/5] tools: add example application to initialize dom0less PV drivers

2022-04-01 Thread Julien Grall
On 01/04/2022 11:02, Julien Grall wrote: Hi Stefano, On 01/04/2022 01:35, Stefano Stabellini wrote: + +    /* Alloc magic pages */ +    if (alloc_magic_pages(info, &dom) != 0) { +    printf("Error on alloc magic pages\n"); +    return 1; +    } + +    xc_dom_gnttab_init(&dom); This

Re: [PATCH v3 5/5] tools: add example application to initialize dom0less PV drivers

2022-04-01 Thread Juergen Gross
On 01.04.22 12:02, Julien Grall wrote: Hi Stefano, On 01/04/2022 01:35, Stefano Stabellini wrote: + +    /* Alloc magic pages */ +    if (alloc_magic_pages(info, &dom) != 0) { +    printf("Error on alloc magic pages\n"); +    return 1; +    } + +    xc_dom_gnttab_init(&dom); This call

Re: [PATCH v4 8/9] tools: add example application to initialize dom0less PV drivers

2022-04-01 Thread Juergen Gross
On 01.04.22 12:21, Julien Grall wrote: Hi, I have posted some comments in v3 after you sent this version. Please have a look. On 01/04/2022 01:38, Stefano Stabellini wrote: +static int init_domain(struct xs_handle *xsh, libxl_dominfo *info) +{ +    struct xc_interface_core *xch; +    libxl_uu

[PATCH v9 2/2] x86/xen: Allow per-domain usage of hardware virtualized APIC

2022-04-01 Thread Jane Malalane
Introduce a new per-domain creation x86 specific flag to select whether hardware assisted virtualization should be used for x{2}APIC. A per-domain option is added to xl in order to select the usage of x{2}APIC hardware assisted virtualization, as well as a global configuration option. Having all

[PATCH v9 0/2] xen: Report and use hardware APIC virtualization capabilities

2022-04-01 Thread Jane Malalane
Jane Malalane (2): xen+tools: Report Interrupt Controller Virtualization capabilities on x86 x86/xen: Allow per-domain usage of hardware virtualized APIC docs/man/xl.cfg.5.pod.in | 15 ++ docs/man/xl.conf.5.pod.in | 12 +++ tools/golang/xenligh

[PATCH v9 1/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86

2022-04-01 Thread Jane Malalane
Add XEN_SYSCTL_PHYSCAP_X86_ASSISTED_XAPIC and XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X2APIC to report accelerated xAPIC and x2APIC, on x86 hardware. This is so that xAPIC and x2APIC virtualization can subsequently be enabled on a per-domain basis. No such features are currently implemented on AMD hardware

Re: [PATCH v4 9/9] docs: document dom0less + PV drivers

2022-04-01 Thread Luca Fancellu
> On 1 Apr 2022, at 01:38, Stefano Stabellini wrote: > > From: Stefano Stabellini > > Document how to use the feature and how the implementation works. > > Signed-off-by: Stefano Stabellini Hi Stefano, Reviewed-by: Luca Fancellu

Re: [PATCH v2 01/14] x86/P2M: rename p2m_remove_page()

2022-04-01 Thread George Dunlap
> On Feb 23, 2022, at 3:57 PM, Jan Beulich wrote: > > This is in preparation to re-using the original name. > > Signed-off-by: Jan Beulich Reviewed-by: George Dunlap signature.asc Description: Message signed with OpenPGP

Re: [PATCH v2 02/14] x86/P2M: introduce p2m_{add,remove}_page()

2022-04-01 Thread George Dunlap
> On Feb 23, 2022, at 3:58 PM, Jan Beulich wrote: > > Rename guest_physmap_add_entry() to p2m_add_page(); make > guest_physmap_remove_page() a trivial wrapper around p2m_remove_page(). > This way callers can use suitable pairs of functions (previously > violated by hvm/grant_table.c). > > In H

Re: [PATCH v2 04/14] x86/mm: split set_identity_p2m_entry() into PV and HVM parts

2022-04-01 Thread George Dunlap
> On Feb 23, 2022, at 3:59 PM, Jan Beulich wrote: > > ..., moving the former into the new physmap.c. Also call the new > functions directly from arch_iommu_hwdom_init() and > vpci_make_msix_hole(), as the PV/HVM split is explicit there. > > Signed-off-by: Jan Beulich > Reviewed-by: George Dun

Re: [PATCH v2 06/14] x86/P2M: PoD, altp2m, and nested-p2m are HVM-only

2022-04-01 Thread George Dunlap
> On Feb 23, 2022, at 4:01 PM, Jan Beulich wrote: > > There's no need to initialize respective data for PV domains. Note that > p2m_teardown_{alt,nested}p2m() will handle the lack-of-initialization > case fine. > > As a result, despite PV domains having a host P2M associated with them > and he

Re: [PATCH v2 00/14] x86/mm: large parts of P2M code and struct p2m_domain are HVM-only

2022-04-01 Thread George Dunlap
> On Feb 23, 2022, at 3:55 PM, Jan Beulich wrote: > > The primary goal of this series is to leave p2m.c with, as its leading > comment suggests, just code for "physical-to-machine mappings for > automatically-translated domains". This requires splitting a few > functions, with their non-HVM par

Re: [PATCH v4 7/9] xenstored: send an evtchn notification on introduce_domain

2022-04-01 Thread Juergen Gross
On 01.04.22 02:38, Stefano Stabellini wrote: From: Luca Miccio When xs_introduce_domain is called, send out a notification on the xenstore event channel so that any (dom0less) domain waiting for the xenstore interface to be ready can continue with the initialization. The extra notification is

Re: [XEN PATCH] tools/libs/light/libxl_pci.c: explicitly grant access to Intel IGD opregion

2022-04-01 Thread Chuck Zmudzinski
On 3/30/22 2:45 PM, Jason Andryuk wrote: On Fri, Mar 18, 2022 at 4:13 AM Jan Beulich wrote: On 14.03.2022 04:41, Chuck Zmudzinski wrote: When gfx_passthru is enabled for the Intel IGD, hvmloader maps the IGD opregion to the guest but libxl does not grant the guest permission to access the mapp

[qemu-mainline test] 169072: tolerable FAIL - PUSHED

2022-04-01 Thread osstest service owner
flight 169072 qemu-mainline real [real] flight 169109 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/169072/ http://logs.test-lab.xenproject.org/osstest/logs/169109/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-am

Re: [PATCH v4 8/9] tools: add example application to initialize dom0less PV drivers

2022-04-01 Thread Julien Grall
Hi Juergen, On 01/04/2022 11:46, Juergen Gross wrote: On 01.04.22 12:21, Julien Grall wrote: Hi, I have posted some comments in v3 after you sent this version. Please have a look. On 01/04/2022 01:38, Stefano Stabellini wrote: +static int init_domain(struct xs_handle *xsh, libxl_dominfo *i

Re: [XEN PATCH] tools/libs/light/libxl_pci.c: explicitly grant access to Intel IGD opregion

2022-04-01 Thread Chuck Zmudzinski
On 4/1/22 9:21 AM, Chuck Zmudzinski wrote: On 3/30/22 2:45 PM, Jason Andryuk wrote: On Fri, Mar 18, 2022 at 4:13 AM Jan Beulich wrote: On 14.03.2022 04:41, Chuck Zmudzinski wrote: When gfx_passthru is enabled for the Intel IGD, hvmloader maps the IGD opregion to the guest but libxl does not g

Re: preparations for 4.14.5 ?

2022-04-01 Thread Marek Marczykowski-Górecki
On Wed, Mar 30, 2022 at 12:16:00PM +0200, Jan Beulich wrote: > All, > > while 4.14's general support period ended in January, we're considering > to cut an out-of-band release due to the relatively large number of > security relevant backports which has accumulated in just 2 months. By > doing thi

Re: [XEN PATCH] tools/libs/light/libxl_pci.c: explicitly grant access to Intel IGD opregion

2022-04-01 Thread Jason Andryuk
On Fri, Apr 1, 2022 at 9:41 AM Chuck Zmudzinski wrote: > > On 4/1/22 9:21 AM, Chuck Zmudzinski wrote: > > On 3/30/22 2:45 PM, Jason Andryuk wrote: > >> On Fri, Mar 18, 2022 at 4:13 AM Jan Beulich wrote: > >>> On 14.03.2022 04:41, Chuck Zmudzinski wrote: > When gfx_passthru is enabled for the

Re: [PATCH v4 8/9] tools: add example application to initialize dom0less PV drivers

2022-04-01 Thread Juergen Gross
On 01.04.22 15:35, Julien Grall wrote: Hi Juergen, On 01/04/2022 11:46, Juergen Gross wrote: On 01.04.22 12:21, Julien Grall wrote: Hi, I have posted some comments in v3 after you sent this version. Please have a look. On 01/04/2022 01:38, Stefano Stabellini wrote: +static int init_domain

Re: [PATCH v4 2/9] xen/arm: implement domU extended regions

2022-04-01 Thread Luca Fancellu
Hi Stefano, > +#define ALIGN_UP_TO_2MB(x) (((x) + MB(2) - 1) & (~(MB(2) - 1))) > + > +static int __init find_domU_holes(const struct kernel_info *kinfo, > + struct meminfo *ext_regions) > +{ > +unsigned int i; > +uint64_t bankend[GUEST_RAM_BANKS]; > +

Re: [PATCH v4 8/9] tools: add example application to initialize dom0less PV drivers

2022-04-01 Thread Julien Grall
Hi Juergen, On 01/04/2022 14:52, Juergen Gross wrote: On 01.04.22 15:35, Julien Grall wrote: Hi Juergen, On 01/04/2022 11:46, Juergen Gross wrote: On 01.04.22 12:21, Julien Grall wrote: Hi, I have posted some comments in v3 after you sent this version. Please have a look. On 01/04/2022 0

Re: [PATCH v4 8/9] tools: add example application to initialize dom0less PV drivers

2022-04-01 Thread Juergen Gross
On 01.04.22 16:04, Julien Grall wrote: Hi Juergen, On 01/04/2022 14:52, Juergen Gross wrote: On 01.04.22 15:35, Julien Grall wrote: Hi Juergen, On 01/04/2022 11:46, Juergen Gross wrote: On 01.04.22 12:21, Julien Grall wrote: Hi, I have posted some comments in v3 after you sent this version

[PATCH AUTOSEL 5.17 137/149] xen/usb: harden xen_hcd against malicious backends

2022-04-01 Thread Sasha Levin
From: Juergen Gross [ Upstream commit aff477cb8f94613f501d386d10f20019e294bc35 ] Make sure a malicious backend can't cause any harm other than wrong I/O data. Missing are verification of the request id in a response, sanitizing the reported actual I/O length, and protection against interrupt st

[PATCH v2] libxl: Don't segfault on soft-reset failure

2022-04-01 Thread Jason Andryuk
If domain_soft_reset_cb can't rename the save file, it doesn't call initiate_domain_create() and calls domcreate_complete(). Skipping initiate_domain_create() means dcs->console_wait is uninitialized and all 0s. We have: domcreate_complete() libxl__xswait_stop() libxl__ev_xswatch_dere

[PATCH v2] libxl: Re-scope qmp_proxy_spawn.ao usage

2022-04-01 Thread Jason Andryuk
I've observed this failed assertion: libxl_event.c:2057: libxl__ao_inprogress_gc: Assertion `ao' failed. AFAICT, this is happening in qmp_proxy_spawn_outcome where sdss->qmp_proxy_spawn.ao is NULL. The out label of spawn_stub_launch_dm() calls qmp_proxy_spawn_outcome(), but it is only in the succ

Re: [PATCH v4 2/9] xen/arm: implement domU extended regions

2022-04-01 Thread Julien Grall
Hi, On 01/04/2022 01:38, Stefano Stabellini wrote: From: Stefano Stabellini Implement extended regions for dom0less domUs. The implementation is based on the libxl implementation. Signed-off-by: Stefano Stabellini --- xen/arch/arm/domain_build.c | 42 ++---

[PATCH 0/2] firmware: build fixes with gcc-11

2022-04-01 Thread Roger Pau Monne
Hello, The following fixes some firmware build issues with gcc-11. Note that dropping of .note.gnu.property section could likely be done in the linker script in the hvmloader case, but rombios has no linker script and such note is causing a non-working image. Other options could be using objcopy t

[PATCH 2/2] tools/firmware: do not add a .note.gnu.property section

2022-04-01 Thread Roger Pau Monne
Prevent the assembler from creating a .note.gnu.property section on the output objects, as it's not useful for firmware related binaries, and breaks the resulting rombios image. This requires modifying the cc-option Makefile macro so it can test assembler options (by replacing the usage of the -S

[PATCH 1/2] tools/firmware: fix setting of fcf-protection=none

2022-04-01 Thread Roger Pau Monne
Setting the fcf-protection=none option in EMBEDDED_EXTRA_CFLAGS in the Makefile doesn't get it propagated to the subdirectories, so instead set the flag in firmware/Rules.mk, like it's done for other compiler flags. Fixes: 3667f7f8f7 ('x86: Introduce support for CET-IBT') Signed-off-by: Roger Pau

Re: [PATCH v2] libxl: Re-scope qmp_proxy_spawn.ao usage

2022-04-01 Thread Anthony PERARD
On Fri, Apr 01, 2022 at 10:33:10AM -0400, Jason Andryuk wrote: > I've observed this failed assertion: > libxl_event.c:2057: libxl__ao_inprogress_gc: Assertion `ao' failed. > > AFAICT, this is happening in qmp_proxy_spawn_outcome where > sdss->qmp_proxy_spawn.ao is NULL. > > The out label of spawn

Re: [PATCH v2] libxl: Don't segfault on soft-reset failure

2022-04-01 Thread Anthony PERARD
On Fri, Apr 01, 2022 at 10:32:56AM -0400, Jason Andryuk wrote: > If domain_soft_reset_cb can't rename the save file, it doesn't call > initiate_domain_create() and calls domcreate_complete(). > > Skipping initiate_domain_create() means dcs->console_wait is > uninitialized and all 0s. > > We have:

Re: [PATCH 1/2] tools/firmware: fix setting of fcf-protection=none

2022-04-01 Thread Andrew Cooper
On 01/04/2022 15:37, Roger Pau Monne wrote: > Setting the fcf-protection=none option in EMBEDDED_EXTRA_CFLAGS in the > Makefile doesn't get it propagated to the subdirectories, so instead > set the flag in firmware/Rules.mk, like it's done for other compiler > flags. > > Fixes: 3667f7f8f7 ('x86: In

Re: [PATCH 1/2] tools/firmware: fix setting of fcf-protection=none

2022-04-01 Thread Anthony PERARD
On Fri, Apr 01, 2022 at 04:37:18PM +0200, Roger Pau Monne wrote: > Setting the fcf-protection=none option in EMBEDDED_EXTRA_CFLAGS in the > Makefile doesn't get it propagated to the subdirectories, so instead > set the flag in firmware/Rules.mk, like it's done for other compiler > flags. > > Fixes

Re: [PATCH 2/2] tools/firmware: do not add a .note.gnu.property section

2022-04-01 Thread Andrew Cooper
On 01/04/2022 15:37, Roger Pau Monne wrote: > Prevent the assembler from creating a .note.gnu.property section on > the output objects, as it's not useful for firmware related binaries, > and breaks the resulting rombios image. > > This requires modifying the cc-option Makefile macro so it can test

Re: [PATCH] of: of_property_read_string return -ENODATA when !length

2022-04-01 Thread Rob Herring
On Thu, Mar 31, 2022 at 7:46 PM Stefano Stabellini wrote: > > From: Stefano Stabellini > > When the length of the string is zero of_property_read_string should > return -ENODATA according to the description of the function. Perhaps it is a difference of: prop; vs. prop = ""; Both are 0 lengt

Re: [PATCH 1/2] tools/firmware: fix setting of fcf-protection=none

2022-04-01 Thread Andrew Cooper
On 01/04/2022 15:50, Anthony PERARD wrote: > On Fri, Apr 01, 2022 at 04:37:18PM +0200, Roger Pau Monne wrote: >> Setting the fcf-protection=none option in EMBEDDED_EXTRA_CFLAGS in the >> Makefile doesn't get it propagated to the subdirectories, so instead >> set the flag in firmware/Rules.mk, like

Re: [PATCH 1/2] tools/firmware: fix setting of fcf-protection=none

2022-04-01 Thread Andrew Cooper
On 01/04/2022 15:48, Andrew Cooper wrote: > On 01/04/2022 15:37, Roger Pau Monne wrote: >> Setting the fcf-protection=none option in EMBEDDED_EXTRA_CFLAGS in the >> Makefile doesn't get it propagated to the subdirectories, so instead >> set the flag in firmware/Rules.mk, like it's done for other co

Re: [PATCH 1/2] tools/firmware: fix setting of fcf-protection=none

2022-04-01 Thread Anthony PERARD
On Fri, Apr 01, 2022 at 03:04:44PM +, Andrew Cooper wrote: > On 01/04/2022 15:50, Anthony PERARD wrote: > > On Fri, Apr 01, 2022 at 04:37:18PM +0200, Roger Pau Monne wrote: > >> +EMBEDDED_EXTRA_CFLAGS += -fcf-protection=none > >> + > > I think making modification to $(EMBEDDED_EXTRA_CFLAGS) out

[xen-4.14-testing test] 169074: regressions - FAIL

2022-04-01 Thread osstest service owner
flight 169074 xen-4.14-testing real [real] flight 169111 xen-4.14-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/169074/ http://logs.test-lab.xenproject.org/osstest/logs/169111/ Regressions :-( Tests which did not succeed and are blocking, including tests which could

Re: [PATCH v12] xen/arm64: io: Handle data abort due to cache maintenance instructions

2022-04-01 Thread Julien Grall
Hi Ayan, On 24/03/2022 13:37, Ayan Kumar Halder wrote: /* * At this point, we know that the instruction is either valid or has been * decoded successfully. Thus, Xen should be allowed to execute the diff --git a/xen/arch/arm/ioreq.c b/xen/arch/arm/ioreq.c index 54167aebcb..87

Re: [PATCH v4 3/9] xen/arm: temporarily elevate idle_domain privileged during create_domUs

2022-04-01 Thread Julien Grall
Hi, On 01/04/2022 01:38, Stefano Stabellini wrote: From: Stefano Stabellini create_domUs might call functions that perform XSM checks on the current domain, which is idle_domain at this time. Temporarily elevate idle_domain privileges in create_domUs. Signed-off-by: Stefano Stabellini ---

[xen-4.15-testing test] 169079: regressions - FAIL

2022-04-01 Thread osstest service owner
flight 169079 xen-4.15-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/169079/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-livepatch13 livepatch-runfail REGR. vs. 168502 test-amd64-amd

Re: [PATCH 1/2] xsm: add ability to elevate a domain to privileged

2022-04-01 Thread Julien Grall
Hi, On 31/03/2022 13:36, Roger Pau Monné wrote: On Wed, Mar 30, 2022 at 07:05:48PM -0400, Daniel P. Smith wrote: There are now instances where internal hypervisor logic needs to make resource allocation calls that are protected by XSM checks. The internal hypervisor logic is represented a numbe

Re: [PATCH 1/2] xsm: add ability to elevate a domain to privileged

2022-04-01 Thread Julien Grall
Hi Daniel, On 31/03/2022 00:05, Daniel P. Smith wrote: There are now instances where internal hypervisor logic needs to make resource allocation calls that are protected by XSM checks. The internal hypervisor logic is represented a number of system domains which by designed are represented by no

Re: [PATCH v1 1/5] xen/arm: field "flags" to cover all internal CDF_XXX

2022-04-01 Thread Julien Grall
Hi Penny, On 30/03/2022 10:36, Penny Zheng wrote: With more and more CDF_xxx internal flags in and to save the space, this commit introduces a new field "flags" to store CDF_* internal flags directly. Another new CDF_xxx will be introduced in the next patch. Signed-off-by: Penny Zheng --- x

Re: [PATCH v1 2/5] xen/arm: introduce CDF_staticmem

2022-04-01 Thread Julien Grall
Hi Penny, On 30/03/2022 10:36, Penny Zheng wrote: In order to have an easy and quick way to find out whether this domain is on static allocation, this commit introduces a new flag CDF_staticmem and a new helper is_domain_on_static_allocation. Signed-off-by: Penny Zheng --- xen/arch/arm/domai

Re: [PATCH v1 3/5] xen/arm: unpopulate memory when domain on static allocation

2022-04-01 Thread Julien Grall
Hi Jan, On 30/03/2022 10:52, Jan Beulich wrote: On 30.03.2022 11:36, Penny Zheng wrote: --- a/xen/common/memory.c +++ b/xen/common/memory.c @@ -35,6 +35,10 @@ #include #endif +#ifndef is_domain_on_static_allocation +#define is_domain_on_static_allocation(d) 0 Nit: "false", not "0".

Re: [PATCH v1 3/5] xen/arm: unpopulate memory when domain on static allocation

2022-04-01 Thread Julien Grall
Hi Penny, On 31/03/2022 11:30, Penny Zheng wrote: Another reason I want to keep page allocated is that if putting pages in resv_page_list upon dropping the last ref, we need to do a lot things on pages to totally let it free, like set its owner to NULL, changing page state from in_use to free, e

[libvirt test] 169098: regressions - FAIL

2022-04-01 Thread osstest service owner
flight 169098 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/169098/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-amd64-libvirt

[ovmf test] 169102: regressions - FAIL

2022-04-01 Thread osstest service owner
flight 169102 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169102/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 168254 build-amd64-xsm

Re: [PATCH] of: of_property_read_string return -ENODATA when !length

2022-04-01 Thread Stefano Stabellini
On Fri, 1 Apr 2022, Rob Herring wrote: > On Thu, Mar 31, 2022 at 7:46 PM Stefano Stabellini > wrote: > > > > From: Stefano Stabellini > > > > When the length of the string is zero of_property_read_string should > > return -ENODATA according to the description of the function. > > Perhaps it is a

[xen-unstable-smoke test] 169114: tolerable all pass - PUSHED

2022-04-01 Thread osstest service owner
flight 169114 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/169114/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[xen-4.16-testing test] 169086: regressions - FAIL

2022-04-01 Thread osstest service owner
flight 169086 xen-4.16-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/169086/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 168513 test-amd64-i38

Re: [PATCH] of: of_property_read_string return -ENODATA when !length

2022-04-01 Thread Rob Herring
On Fri, Apr 1, 2022 at 3:49 PM Stefano Stabellini wrote: > > On Fri, 1 Apr 2022, Rob Herring wrote: > > On Thu, Mar 31, 2022 at 7:46 PM Stefano Stabellini > > wrote: > > > > > > From: Stefano Stabellini > > > > > > When the length of the string is zero of_property_read_string should > > > return

Re: [PATCH] of: of_property_read_string return -ENODATA when !length

2022-04-01 Thread Stefano Stabellini
On Fri, 1 Apr 2022, Rob Herring wrote: > On Fri, Apr 1, 2022 at 3:49 PM Stefano Stabellini > wrote: > > > > On Fri, 1 Apr 2022, Rob Herring wrote: > > > On Thu, Mar 31, 2022 at 7:46 PM Stefano Stabellini > > > wrote: > > > > > > > > From: Stefano Stabellini > > > > > > > > When the length of the

[PATCH v2] Grab the EFI System Resource Table and check it

2022-04-01 Thread Demi Marie Obenour
The EFI System Resource Table (ESRT) is necessary for fwupd to identify firmware updates to install. According to the UEFI specification §23.4, the table shall be stored in memory of type EfiBootServicesData. Therefore, Xen must avoid reusing that memory for other purposes, so that Linux can acces

Re: [PATCH v3 04/19] xen/arm: mm: Allow other mapping size in xen_pt_update_entry()

2022-04-01 Thread Stefano Stabellini
On Mon, 21 Feb 2022, Julien Grall wrote: > From: Julien Grall > > At the moment, xen_pt_update_entry() only supports mapping at level 3 > (i.e 4KB mapping). While this is fine for most of the runtime helper, > the boot code will require to use superpage mapping. > > We don't want to allow superp

Re: [PATCH v3 05/19] xen/arm: mm: Add support for the contiguous bit

2022-04-01 Thread Stefano Stabellini
On Mon, 21 Feb 2022, Julien Grall wrote: > From: Julien Grall > > In follow-up patches, we will use xen_pt_update() (or its callers) > to handle large mappings (e.g. frametable, xenheap). They are also > not going to be modified once created. > > The page-table entries have an hint to indicate t

Re: [PATCH v3 06/19] xen/arm: mm: Avoid flushing the TLBs when mapping are inserted

2022-04-01 Thread Stefano Stabellini
On Mon, 21 Feb 2022, Julien Grall wrote: > From: Julien Grall > > Currently, the function xen_pt_update() will flush the TLBs even when > the mappings are inserted. This is a bit wasteful because we don't > allow mapping replacement. Even if we were, the flush would need to > happen earlier becau

Re: [PATCH v3 07/19] xen/arm: mm: Don't open-code Xen PT update in remove_early_mappings()

2022-04-01 Thread Stefano Stabellini
On Mon, 21 Feb 2022, Julien Grall wrote: > From: Julien Grall > > Now that xen_pt_update_entry() is able to deal with different mapping > size, we can replace the open-coding of the page-tables update by a call > to modify_xen_mappings(). > > As the function is not meant to fail, a BUG_ON() is a

Re: [PATCH v3 08/19] xen/arm: mm: Re-implement early_fdt_map() using map_pages_to_xen()

2022-04-01 Thread Stefano Stabellini
On Mon, 21 Feb 2022, Julien Grall wrote: > From: Julien Grall > > Now that map_pages_to_xen() has been extended to support 2MB mappings, > we can replace the create_mappings() calls by map_pages_to_xen() calls. > > The mapping can also be marked read-only has Xen as no business to > modify the h

Re: [PATCH v3 10/19] xen/arm32: mm: Re-implement setup_xenheap_mappings() using map_pages_to_xen()

2022-04-01 Thread Stefano Stabellini
On Mon, 21 Feb 2022, Julien Grall wrote: > From: Julien Grall > > Now that map_pages_to_xen() has been extended to support 2MB mappings, > we can replace the create_mappings() call by map_pages_to_xen() call. > > Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini > --- > Change

[linux-linus test] 169100: tolerable FAIL - PUSHED

2022-04-01 Thread osstest service owner
flight 169100 linux-linus real [real] flight 169121 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/169100/ http://logs.test-lab.xenproject.org/osstest/logs/169121/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-

[xen-unstable test] 169106: tolerable FAIL - PUSHED

2022-04-01 Thread osstest service owner
flight 169106 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/169106/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 14 guest-start fail REGR. vs. 169063 Tests which did not succeed

[PATCH V2 0/2] xen/arm: add i.MX lpuart and i.MX8QM initial support

2022-04-01 Thread Peng Fan (OSS)
From: Peng Fan V2: Per Julien's comments, fix coding style issue, drop unneeded code Add i.MX lpuart driver and i.MX8QM platform support. - lpuart is the uart IP used in i.MX8QM/QXP/93. - Very basic i.MX8QM platform support. Peng Fan (2): xen/arm: Add i.MX lpuart driver xen/arm: Add i.MX

[PATCH V2 2/2] xen/arm: Add i.MX lpuart early printk support

2022-04-01 Thread Peng Fan (OSS)
From: Peng Fan Signed-off-by: Peng Fan --- xen/arch/arm/Kconfig.debug | 14 +++ xen/arch/arm/arm64/debug-imx-lpuart.inc | 52 + 2 files changed, 66 insertions(+) create mode 100644 xen/arch/arm/arm64/debug-imx-lpuart.inc diff --git a/xen/arch/arm/Kconf

[PATCH V2 1/2] xen/arm: Add i.MX lpuart driver

2022-04-01 Thread Peng Fan (OSS)
From: Peng Fan The i.MX LPUART Documentation: https://www.nxp.com/webapp/Download?colCode=IMX8QMIEC Chatper 13.6 Low Power Universal Asynchronous Receiver/ Transmitter (LPUART) Signed-off-by: Peng Fan --- xen/drivers/char/Kconfig | 8 + xen/drivers/char/Makefile | 1 + xen/drivers

RE: [PATCH V2 1/2] xen/arm: Add i.MX lpuart driver

2022-04-01 Thread Henry Wang
Hi Peng, > -Original Message- > From: Xen-devel On Behalf Of > Peng Fan (OSS) > Sent: Saturday, April 2, 2022 1:42 PM > To: sstabell...@kernel.org; jul...@xen.org; volodymyr_babc...@epam.com; > Bertrand Marquis > Cc: andrew.coop...@citrix.com; george.dun...@citrix.com; > jbeul...@suse.co