Re: [PATCH v4] x86/HVM: support emulated UMIP

2023-03-20 Thread Jan Beulich
On 17.03.2023 17:09, Roger Pau Monné wrote: > On Fri, Mar 17, 2023 at 04:01:59PM +0100, Jan Beulich wrote: >> On 17.03.2023 15:29, Roger Pau Monné wrote: >>> On Thu, Apr 15, 2021 at 11:47:42AM +0200, Jan Beulich wrote: There are three noteworthy drawbacks: 1) The intercepts we need to

Re: [PATCH] Fix PCI hotplug AML

2023-03-20 Thread Paul Durrant
On 17/03/2023 10:32, David Woodhouse wrote: From: David Woodhouse The emulated PIIX3 uses a nybble for the status of each PCI function, so the status for e.g. slot 0 functions 0 and 1 respectively can be read as (\_GPE.PH00 & 0x0F), and (\_GPE.PH00 >> 0x04). The AML that Xen gives to a guest

Re: [PATCH v3 02/10] xen/arm: add SVE vector length field to the domain

2023-03-20 Thread Jan Beulich
On 17.03.2023 14:19, Luca Fancellu wrote: > @@ -744,6 +773,9 @@ int arch_domain_create(struct domain *d, > if ( (rc = domain_vpci_init(d)) != 0 ) > goto fail; > > +/* Copy and decode sve_vl from the domain configuration */ > +d->arch.sve_vl_bits =

Re: [PATCH v2] x86: use POPCNT for hweight() when available

2023-03-20 Thread Jan Beulich
On 17.03.2023 13:26, Andrew Cooper wrote: > On 17/03/2023 11:22 am, Roger Pau Monné wrote: >> On Mon, Jul 15, 2019 at 02:39:04PM +, Jan Beulich wrote: >>> This is faster than using the software implementation, and the insn is >>> available on all half-way recent hardware. Therefore convert >>>

Re: [PATCH v3 08/10] tools: add physinfo arch_capabilities handling for Arm

2023-03-20 Thread George Dunlap
On Fri, Mar 17, 2023 at 1:20 PM Luca Fancellu wrote: > On Arm, the SVE vector length is encoded in arch_capabilities field > of struct xen_sysctl_physinfo, make use of this field in the tools > when building for arm. > > Signed-off-by: Luca Fancellu > Golang bits: Acked-by: George Dunlap

Re: [PATCH] Fix PCI hotplug AML

2023-03-20 Thread Jan Beulich
On 20.03.2023 10:04, Paul Durrant wrote: > On 17/03/2023 10:32, David Woodhouse wrote: >> From: David Woodhouse >> >> The emulated PIIX3 uses a nybble for the status of each PCI function, >> so the status for e.g. slot 0 functions 0 and 1 respectively can be >> read as (\_GPE.PH00 & 0x0F), and

Re: [PATCH] Fix PCI hotplug AML

2023-03-20 Thread Paul Durrant
On 20/03/2023 10:34, Jan Beulich wrote: On 20.03.2023 10:04, Paul Durrant wrote: On 17/03/2023 10:32, David Woodhouse wrote: From: David Woodhouse The emulated PIIX3 uses a nybble for the status of each PCI function, so the status for e.g. slot 0 functions 0 and 1 respectively can be read as

Re: [PATCH v5 0/5] Stop using insecure transports

2023-03-20 Thread George Dunlap
On Mon, Mar 20, 2023 at 11:14 AM Anthony PERARD wrote: > Hi, > > I believe all the containers that needed to be updated in our GitLab CI > to be able to access HTTPS URLs have now been updated. > > So I guess the series is good to go if it's reviewed. > Has it run and passed Gitlab-CI with the

Re: [PATCH v8 1/5] xen: introduce CONFIG_GENERIC_BUG_FRAME

2023-03-20 Thread Oleksii
On Fri, 2023-03-17 at 15:59 +0100, Jan Beulich wrote: > On 17.03.2023 10:23, Oleksii wrote: > > On Thu, 2023-03-16 at 12:26 +0100, Jan Beulich wrote: > > > On 15.03.2023 18:21, Oleksii Kurochko wrote: > > > > --- /dev/null > > > > +++ b/xen/common/bug.c > > > > @@ -0,0 +1,108 @@ > > > > +#include

Re: [PATCH v3 08/10] tools: add physinfo arch_capabilities handling for Arm

2023-03-20 Thread Christian Lindig
> On 17 Mar 2023, at 13:19, Luca Fancellu wrote: > > > arch_cap_flags = caml_alloc_small(1, arch_cap_flags_tag); > Store_field(arch_cap_flags, 0, arch_cap_list); > Store_field(physinfo, 10, arch_cap_flags); > +#elif defined(__aarch64__) > + Store_field(physinfo, 10,

Re: [PATCH] x86/Xen: make use of IBPB controlling VM assist

2023-03-20 Thread Jan Beulich
On 17.03.2023 14:56, Juergen Gross wrote: > On 15.02.23 09:31, Jan Beulich wrote: >> Eventually yes. But I would prefer to sort the above question first >> (which I'm sure would have been raised by them, in perhaps more >> harsh a way), hence the initially limited exposure. > > I'd rather add

Re: [PATCH] x86/Xen: make use of IBPB controlling VM assist

2023-03-20 Thread Jan Beulich
On 17.03.2023 15:21, Andrew Cooper wrote: > On 17/03/2023 1:56 pm, Juergen Gross wrote: >> --- a/arch/x86/xen/enlighten_pv.c >> +++ b/arch/x86/xen/enlighten_pv.c >> @@ -1476,6 +1476,23 @@ static uint32_t __init xen_platform_pv(void) >>     return 0; >>  } >> >> +int __init

Re: [PATCH] Fix PCI hotplug AML

2023-03-20 Thread Jan Beulich
On 17.03.2023 11:32, David Woodhouse wrote: > From: David Woodhouse > > The emulated PIIX3 uses a nybble for the status of each PCI function, > so the status for e.g. slot 0 functions 0 and 1 respectively can be > read as (\_GPE.PH00 & 0x0F), and (\_GPE.PH00 >> 0x04). > > The AML that Xen gives

Re: [XEN PATCH v3] x86/monitor: Add new monitor event to catch I/O instructions

2023-03-20 Thread Jan Beulich
On 17.03.2023 13:01, Dmitry Isaykin wrote: > --- a/xen/arch/x86/hvm/monitor.c > +++ b/xen/arch/x86/hvm/monitor.c > @@ -346,6 +346,27 @@ int hvm_monitor_vmexit(unsigned long exit_reason, > return monitor_traps(curr, ad->monitor.vmexit_sync, ); > } > > +int hvm_monitor_io(uint16_t port,

Re: Aw: Re: Re: Re: [help] Xen 4.14.5 on Devuan 4.0 Chimaera, regression from Xen 4.0.1

2023-03-20 Thread Andrew Cooper
On 19/03/2023 7:38 pm, Denis wrote: > On 14.03.2023 16:11, Andrew Cooper wrote: >> On 14/03/2023 2:53 pm, Denis wrote: >>> On 14.03.2023 07:37; Jan Beulich wrote: On 14.03.2023 02:15, Denis wrote: > On 13.03.2023 10:36, Jan wrote >> On 10.03.2023 21:50, Denis wrote: >>> Should I

Re: [PATCH v5 0/5] Stop using insecure transports

2023-03-20 Thread Anthony PERARD
Hi, I believe all the containers that needed to be updated in our GitLab CI to be able to access HTTPS URLs have now been updated. So I guess the series is good to go if it's reviewed. Cheers, -- Anthony PERARD

Re: [PATCH v3] xen/console: Skip switching serial input to non existing domains

2023-03-20 Thread Jan Beulich
On 20.03.2023 09:19, Michal Orzel wrote: > @@ -483,15 +485,34 @@ struct domain *console_input_domain(void) > > static void switch_serial_input(void) > { > -if ( console_rx == max_init_domid + 1 ) > -{ > -console_rx = 0; > -printk("*** Serial input to Xen"); > -} > -

Re: [PATCH v5 2/5] Change remaining xenbits.xen.org links to HTTPS

2023-03-20 Thread George Dunlap
On Mon, Feb 27, 2023 at 6:46 PM Demi Marie Obenour < d...@invisiblethingslab.com> wrote: > On Mon, Feb 27, 2023 at 09:35:51AM +0100, Jan Beulich wrote: > > On 25.02.2023 21:37, Demi Marie Obenour wrote: > > > --- a/Config.mk > > > +++ b/Config.mk > > > @@ -191,7 +191,7 @@ APPEND_CFLAGS +=

Re: [PATCH v2 2/2] x86/APIC: modify error_interrupt() to output using single printk()

2023-03-20 Thread Elliott Mitchell
On Mon, Mar 20, 2023 at 04:39:48PM +0100, Jan Beulich wrote: > On 20.03.2023 15:29, Elliott Mitchell wrote: > > > > There are several minor issues here which may be best handled during > > commit as they're very small items about how precisely you want this to > > look. > > > > First, I later

Re: [RFC XEN PATCH 0/6] Introduce VirtIO GPU and Passthrough GPU support on Xen PVH dom0

2023-03-20 Thread Huang Rui
Hi Jan, Roger, Stefano, Andrew, Sorry to late response, I was fully occupied by another problem last week. And I will give the reply one by one in the mail tomorrow. Thanks for your patience. :-) Thanks, Ray On Sun, Mar 12, 2023 at 03:54:49PM +0800, Huang, Ray wrote: > Hi all, > > In graphic

[qemu-mainline test] 179802: regressions - trouble: fail/pass/starved

2023-03-20 Thread osstest service owner
flight 179802 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/179802/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt 14 guest-start fail REGR. vs. 179518

Re: [XEN PATCH v3] x86/monitor: Add new monitor event to catch I/O instructions

2023-03-20 Thread Julien Grall
Hi, On 17/03/2023 12:01, Dmitry Isaykin wrote: diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h index 51be28c3de..7280e9f968 100644 --- a/xen/include/public/domctl.h +++ b/xen/include/public/domctl.h @@ -1063,6 +1063,7 @@ struct xen_domctl_psr_cmt_op { /* Enabled by

Re: [XEN PATCH v3] x86/monitor: Add new monitor event to catch I/O instructions

2023-03-20 Thread Tamas K Lengyel
> Are you actually sure you want to tie the vm-event interface to the ioreq > one (this is also a question to you, Tamas)? It would look slightly better > to me if this was a simple boolean named after its purpose (e.g. "write" > or "out" when it's meant to be set for OUT / OUTS and clear for IN /

Re: [PATCH v2 1/3] xen/riscv: introduce setup_initial_pages

2023-03-20 Thread Jan Beulich
On 16.03.2023 17:43, Oleksii Kurochko wrote: > --- /dev/null > +++ b/xen/arch/riscv/include/asm/mm.h > @@ -0,0 +1,8 @@ > +#ifndef _ASM_RISCV_MM_H > +#define _ASM_RISCV_MM_H > + > +void setup_initial_pagetables(void); > + > +extern void enable_mmu(void); Nit: At least within a single header you

Re: [PATCH v4] acpi/processor: fix evaluating _PDC method when running as Xen dom0

2023-03-20 Thread Rafael J. Wysocki
On Fri, Mar 17, 2023 at 1:42 PM Juergen Gross wrote: > > On 16.03.23 17:42, Roger Pau Monne wrote: > > In ACPI systems, the OS can direct power management, as opposed to the > > firmware. This OS-directed Power Management is called OSPM. Part of > > telling the firmware that the OS going to

[PATCH] x86/vmx: Provide named fields for IO exit qualification

2023-03-20 Thread Andrew Cooper
This removes most of the opencoded bit logic on the exit qualification. Unfortunately, size is 1-based not 0-based, so need adjusting in a separate variable. No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Kevin Tian ---

Re: [PATCH v2 3/4] xen/arm: Defer GICv2 CPU interface mapping until the first access

2023-03-20 Thread Julien Grall
Hi Henry, On 30/01/2023 04:06, Henry Wang wrote: Currently, the mapping of the GICv2 CPU interface is created in arch_domain_create(). This causes some troubles in populating and freeing of the domain P2M pages pool. For example, a default 16 P2M pages are required in p2m_init() to cope with

Re: [XEN PATCH v1 1/1] x86/domctl: add gva_to_gfn command

2023-03-20 Thread Andrew Cooper
On 20/03/2023 7:22 pm, Ковалёв Сергей wrote: > > 21.03.2023 1:51, Tamas K Lengyel wrote: >> On Mon, Mar 20, 2023 at 12:32 PM Ковалёв Сергей > > wrote: >>  > >>  > gva_to_gfn command used for fast address translation in LibVMI >> project. >>  > With such a command it is

Re: [BUG] x2apic broken with current AMD hardware

2023-03-20 Thread Andrew Cooper
On 20/03/2023 8:28 am, Jan Beulich wrote: > On 20.03.2023 09:14, Jan Beulich wrote: >> On 17.03.2023 18:26, Elliott Mitchell wrote: >>> On Fri, Mar 17, 2023 at 09:22:09AM +0100, Jan Beulich wrote: On 16.03.2023 23:03, Elliott Mitchell wrote: > On Mon, Mar 13, 2023 at 08:01:02AM +0100, Jan

Re: [PATCH] xen: Fix host pci for stubdom

2023-03-20 Thread Bernhard Beschow
Am 20. März 2023 00:05:54 UTC schrieb Jason Andryuk : >PCI passthrough for an HVM with a stubdom is PV PCI passthrough from >dom0 to the stubdom, and then QEMU passthrough of the PCI device inside >the stubdom. xen-pciback has boolean module param passthrough which >controls "how to export PCI

[xen-unstable-smoke test] 179814: tolerable trouble: pass/starved - PUSHED

2023-03-20 Thread osstest service owner
flight 179814 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/179814/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [PATCH 2/2] automation: add a suspend test on an Alder Lake system

2023-03-20 Thread Marek Marczykowski-Górecki
On Mon, Mar 20, 2023 at 01:08:42PM -0700, Stefano Stabellini wrote: > On Sat, 18 Mar 2023, Marek Marczykowski-Górecki wrote: > > On Fri, Mar 17, 2023 at 04:10:22PM -0700, Stefano Stabellini wrote: > > > On Fri, 17 Mar 2023, Marek Marczykowski-Górecki wrote: > > > > +fakeroot -s ../fakeroot-save

[XEN PATCH v1 1/1] x86/domctl: add gva_to_gfn command

2023-03-20 Thread Ковалёв Сергей
gva_to_gfn command used for fast address translation in LibVMI project. With such a command it is possible to perform address translation in single call instead of series of queries to get every page table. Thanks to Dmitry Isaykin for involvement. Signed-off-by: Sergey Kovalev --- Cc: Jan

Re: [PATCH 1/2] tools/xl: allow split_string_into_pair() to trim values

2023-03-20 Thread Jason Andryuk
On Fri, Mar 17, 2023 at 7:16 AM Juergen Gross wrote: > > Most use cases of split_string_into_pair() are requiring the returned > strings to be white space trimmed. > > In order to avoid the same code pattern multiple times, add a predicate > parameter to split_string_into_pair() which can be

[linux-linus test] 179805: regressions - trouble: blocked/fail/pass/starved

2023-03-20 Thread osstest service owner
flight 179805 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/179805/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit1 20 guest-localmigrate/x10 fail REGR. vs. 178042

Re: [PATCH v2 2/3] xen/riscv: setup initial pagetables

2023-03-20 Thread Jan Beulich
On 16.03.2023 17:43, Oleksii Kurochko wrote: > Signed-off-by: Oleksii Kurochko > --- > Changes in V2: > * Update the commit message Odd: It's empty. Since it's not part of the title, you could at least say that you're also enabling the MMU. (Most of the time entirely empty descriptions are

Re: [XEN PATCH v1 1/1] x86/domctl: add gva_to_gfn command

2023-03-20 Thread Tamas K Lengyel
On Mon, Mar 20, 2023 at 12:32 PM Ковалёв Сергей wrote: > > gva_to_gfn command used for fast address translation in LibVMI project. > With such a command it is possible to perform address translation in > single call instead of series of queries to get every page table. You have a couple

Re: [XEN PATCH v1 1/1] x86/domctl: add gva_to_gfn command

2023-03-20 Thread Andrew Cooper
On 20/03/2023 4:32 pm, Ковалёв Сергей wrote: > gva_to_gfn command used for fast address translation in LibVMI project. > With such a command it is possible to perform address translation in > single call instead of series of queries to get every page table. > > Thanks to Dmitry Isaykin for

Re: [XEN PATCH v1 1/1] x86/domctl: add gva_to_gfn command

2023-03-20 Thread Ковалёв Сергей
21.03.2023 1:51, Tamas K Lengyel wrote: On Mon, Mar 20, 2023 at 12:32 PM Ковалёв Сергей > wrote: > > gva_to_gfn command used for fast address translation in LibVMI project. > With such a command it is possible to perform address translation in > single call

Re: [PATCH v2 2/4] xen/arm: Rename vgic_cpu_base and vgic_dist_base for new vGIC

2023-03-20 Thread Julien Grall
Hi Henry, On 30/01/2023 04:06, Henry Wang wrote: In the follow-up patch from this series, the GICv2 CPU interface mapping will be deferred until the first access in the stage-2 data abort trap handling code. Since the data abort trap handling code is common for the current and the new vGIC

Re: [XEN PATCH v1 1/1] x86/domctl: add gva_to_gfn command

2023-03-20 Thread Andrew Cooper
On 20/03/2023 7:35 pm, Ковалёв Сергей wrote: > 20.03.2023 22:07, Andrew Cooper пишет: >> >> More generally, issuing the hypercall under vcpu0 isn't necessarily >> correct.  It is common for all vCPUs to have equivalent paging settings, >> but e.g. Xen transiently disables CR4.CET and CR0.WP in

Re: [ImageBuilder][PATCH v3 2/2] uboot-script-gen: add support for static shared memory

2023-03-20 Thread Stefano Stabellini
On Mon, 20 Mar 2023, jiamei.xie wrote: > Introduce support for creating shared-mem node for dom0less domUs in > the device tree. Add the following option: > - DOMU_SHARED_MEM[number]="SHM-ID HPA GPA size" > if specified, indicate the unique identifier of the shared memory > region is SHM-ID,

Re: [PATCH 2/2] automation: add a suspend test on an Alder Lake system

2023-03-20 Thread Stefano Stabellini
On Mon, 20 Mar 2023, Marek Marczykowski-Górecki wrote: > On Mon, Mar 20, 2023 at 01:41:45PM -0700, Stefano Stabellini wrote: > > On Mon, 20 Mar 2023, Marek Marczykowski-Górecki wrote: > > > On Mon, Mar 20, 2023 at 01:08:42PM -0700, Stefano Stabellini wrote: > > > > On Sat, 18 Mar 2023, Marek

Re: [PATCH v2 2/2] x86/APIC: modify error_interrupt() to output using single printk()

2023-03-20 Thread Jan Beulich
On 20.03.2023 16:54, Elliott Mitchell wrote: > On Mon, Mar 20, 2023 at 04:39:48PM +0100, Jan Beulich wrote: >> On 20.03.2023 15:29, Elliott Mitchell wrote: >>> >>> There are several minor issues here which may be best handled during >>> commit as they're very small items about how precisely you

Re: [PATCH 2/2] automation: add a suspend test on an Alder Lake system

2023-03-20 Thread Stefano Stabellini
On Sat, 18 Mar 2023, Marek Marczykowski-Górecki wrote: > On Fri, Mar 17, 2023 at 04:10:22PM -0700, Stefano Stabellini wrote: > > On Fri, 17 Mar 2023, Marek Marczykowski-Górecki wrote: > > > This is a first test using Qubes OS CI infra. The gitlab-runner has > > > access to ssh-based control

Re: [PATCH 2/2] automation: add a suspend test on an Alder Lake system

2023-03-20 Thread Marek Marczykowski-Górecki
On Mon, Mar 20, 2023 at 01:41:45PM -0700, Stefano Stabellini wrote: > On Mon, 20 Mar 2023, Marek Marczykowski-Górecki wrote: > > On Mon, Mar 20, 2023 at 01:08:42PM -0700, Stefano Stabellini wrote: > > > On Sat, 18 Mar 2023, Marek Marczykowski-Górecki wrote: > > > > On Fri, Mar 17, 2023 at

Re: [PATCH] xen: Fix host pci for stubdom

2023-03-20 Thread Jason Andryuk
On Mon, Mar 20, 2023 at 2:41 PM Bernhard Beschow wrote: > > > > Am 20. März 2023 00:05:54 UTC schrieb Jason Andryuk : > >PCI passthrough for an HVM with a stubdom is PV PCI passthrough from > >dom0 to the stubdom, and then QEMU passthrough of the PCI device inside > >the stubdom. xen-pciback has

Re: [RFC XEN PATCH 6/6] tools/libs/light: pci: translate irq to gsi

2023-03-20 Thread Roger Pau Monné
On Mon, Mar 20, 2023 at 04:29:25PM +0100, Jan Beulich wrote: > On 20.03.2023 16:16, Roger Pau Monné wrote: > > @@ -244,12 +242,18 @@ static void vioapic_write_redirent( > > } > > else > > { > > +int ret; > > + > > unmasked = ent.fields.mask; > > /* Remote

Re: [PATCH 2/2] tools/xl: rework p9 config parsing

2023-03-20 Thread Jason Andryuk
On Fri, Mar 17, 2023 at 7:16 AM Juergen Gross wrote: > > Rework the config parsing of a p9 device to use the > split_string_into_pair() function instead of open coding it. > > Signed-off-by: Juergen Gross > --- > tools/xl/xl_parse.c | 72 ++--- > 1 file

Re: [XEN PATCH v1 1/1] x86/domctl: add gva_to_gfn command

2023-03-20 Thread Ковалёв Сергей
20.03.2023 22:07, Andrew Cooper пишет: On 20/03/2023 4:32 pm, Ковалёв Сергей wrote: gva_to_gfn command used for fast address translation in LibVMI project. With such a command it is possible to perform address translation in single call instead of series of queries to get every page table.

Re: [PATCH 2/2] automation: add a suspend test on an Alder Lake system

2023-03-20 Thread Stefano Stabellini
On Mon, 20 Mar 2023, Marek Marczykowski-Górecki wrote: > On Mon, Mar 20, 2023 at 01:08:42PM -0700, Stefano Stabellini wrote: > > On Sat, 18 Mar 2023, Marek Marczykowski-Górecki wrote: > > > On Fri, Mar 17, 2023 at 04:10:22PM -0700, Stefano Stabellini wrote: > > > > On Fri, 17 Mar 2023, Marek

Re: [XEN PATCH v1 1/1] x86/domctl: add gva_to_gfn command

2023-03-20 Thread Tamas K Lengyel
On Mon, Mar 20, 2023 at 3:23 PM Ковалёв Сергей wrote: > > > > 21.03.2023 1:51, Tamas K Lengyel wrote: > > > > > > On Mon, Mar 20, 2023 at 12:32 PM Ковалёв Сергей > > wrote: > > > > > > gva_to_gfn command used for fast address translation in LibVMI project. > > > With

[qemu-mainline test] 179816: regressions - trouble: fail/pass/starved

2023-03-20 Thread osstest service owner
flight 179816 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/179816/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt 14 guest-start fail REGR. vs. 179518

Re: [BUG] x2apic broken with current AMD hardware

2023-03-20 Thread Elliott Mitchell
On Mon, Mar 20, 2023 at 09:28:20AM +0100, Jan Beulich wrote: > On 20.03.2023 09:14, Jan Beulich wrote: > > On 17.03.2023 18:26, Elliott Mitchell wrote: > >> On Fri, Mar 17, 2023 at 09:22:09AM +0100, Jan Beulich wrote: > >>> On 16.03.2023 23:03, Elliott Mitchell wrote: > On Mon, Mar 13, 2023

Re: [PATCH 2/2] tools/xl: rework p9 config parsing

2023-03-20 Thread Juergen Gross
On 20.03.23 18:12, Jason Andryuk wrote: On Fri, Mar 17, 2023 at 7:16 AM Juergen Gross wrote: Rework the config parsing of a p9 device to use the split_string_into_pair() function instead of open coding it. Signed-off-by: Juergen Gross --- tools/xl/xl_parse.c | 72

[XEN PATCH v4] x86/monitor: Add new monitor event to catch I/O instructions

2023-03-20 Thread Dmitry Isaykin
Adds monitor support for I/O instructions. Signed-off-by: Dmitry Isaykin Signed-off-by: Anton Belousov --- Changes in v4: * Avoid the use of fixed-width types * Document vm_event_io structure fields * Untie vm-event interface from ioreq one Changes in v3: * Rebase on staging * Refactor

[linux-linus test] 179818: regressions - trouble: fail/pass/starved

2023-03-20 Thread osstest service owner
flight 179818 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/179818/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-xsm 18 guest-localmigrate fail REGR. vs. 178042

Re: [XEN PATCH v1 1/1] x86/domctl: add gva_to_gfn command

2023-03-20 Thread Tamas K Lengyel
On Mon, Mar 20, 2023 at 3:34 PM Andrew Cooper wrote: > > On 20/03/2023 7:22 pm, Ковалёв Сергей wrote: > > > > 21.03.2023 1:51, Tamas K Lengyel wrote: > >> On Mon, Mar 20, 2023 at 12:32 PM Ковалёв Сергей >> > wrote: > >> > > >> > gva_to_gfn command used for fast address

RE: [PATCH v2 3/4] xen/arm: Defer GICv2 CPU interface mapping until the first access

2023-03-20 Thread Henry Wang
Hi Julien, Thanks very much for your time and review :) > -Original Message- > From: Julien Grall > Subject: Re: [PATCH v2 3/4] xen/arm: Defer GICv2 CPU interface mapping until > the first access > > Hi Henry, > > On 30/01/2023 04:06, Henry Wang wrote: > > Since the hardware domain

[xen-unstable-smoke test] 179826: tolerable trouble: pass/starved - PUSHED

2023-03-20 Thread osstest service owner
flight 179826 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/179826/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

RE: [PATCH v2 3/4] xen/arm: Defer GICv2 CPU interface mapping until the first access

2023-03-20 Thread Henry Wang
Hi, > Considering that the CPU interface is continuous (I suppose), I have two > ways of rewriting the gfn check, we can do either: > > gfn_eq(gfn, gaddr_to_gfn(d->arch.vgic.cbase)) || > gfn_eq(gfn, gfn_add(gaddr_to_gfn(d->arch.vgic.cbase), 1)) > > or > > gfn_to_gaddr(gfn) >=

Re: [BUG] x2apic broken with current AMD hardware

2023-03-20 Thread Jan Beulich
On 17.03.2023 18:26, Elliott Mitchell wrote: > On Fri, Mar 17, 2023 at 09:22:09AM +0100, Jan Beulich wrote: >> On 16.03.2023 23:03, Elliott Mitchell wrote: >>> On Mon, Mar 13, 2023 at 08:01:02AM +0100, Jan Beulich wrote: On 11.03.2023 01:09, Elliott Mitchell wrote: > On Thu, Mar 09, 2023

[linux-linus test] 179797: regressions - trouble: fail/pass/starved

2023-03-20 Thread osstest service owner
flight 179797 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/179797/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit1 17 guest-saverestorefail REGR. vs. 178042

Re: [PATCH v3 06/10] xen/arm: enable Dom0 to use SVE feature

2023-03-20 Thread Jan Beulich
On 17.03.2023 14:19, Luca Fancellu wrote: > --- a/docs/misc/xen-command-line.pandoc > +++ b/docs/misc/xen-command-line.pandoc > @@ -1005,6 +1005,19 @@ restrictions set up here. Note that the values to be > specified here are > ACPI PXM ones, not Xen internal node numbers. `relaxed` sets up vCPU

Re: [PATCH v2 2/2] x86/APIC: modify error_interrupt() to output using single printk()

2023-03-20 Thread Jan Beulich
On 17.03.2023 20:53, Elliott Mitchell wrote: > This takes care of the issue of APIC errors tending to occur on multiple > cores at one. In turn this tends to causes the error messages to be Nit: "at once"? > merged together, making understanding them difficult. > > Signed-off-by: Elliott

[ImageBuilder][PATCH v3 2/2] uboot-script-gen: add support for static shared memory

2023-03-20 Thread jiamei.xie
Introduce support for creating shared-mem node for dom0less domUs in the device tree. Add the following option: - DOMU_SHARED_MEM[number]="SHM-ID HPA GPA size" if specified, indicate the unique identifier of the shared memory region is SHM-ID, the host physical address HPA will get mapped at

[ImageBuilder][PATCH v3 1/2] uboot-script-gen: Add XEN_STATIC_HEAP

2023-03-20 Thread jiamei.xie
From: jiamei Xie Add a new config parameter to configure Xen static heap. XEN_STATIC_HEAP="baseaddr1 size1 ... baseaddrN sizeN" if specified, indicates the host physical address regions [baseaddr, baseaddr + size) to be reserved as Xen static heap. For instance, XEN_STATIC_HEAP="0x5000

[ImageBuilder][PATCH v3 0/2] uboot-script-gen: Add support for static heap and shared memory

2023-03-20 Thread jiamei.xie
Hi all, This patch series is to enable to set the device tree for static heap and static shared memory by uboot-script-gen Changes from v2: - Remove "domid" parameter - Use lower capital letters for local variables - add Reviewed-by and Acked-by in XEN_STATIC_HEAP commit message Changes from

[PATCH v3] xen/console: Skip switching serial input to non existing domains

2023-03-20 Thread Michal Orzel
At the moment, we direct serial input to hardware domain by default. This does not make any sense when running in true dom0less mode, since such domain does not exist. As a result, users wishing to write to an emulated UART of a domU are always forced to execute CTRL-AAA first. The same issue is

Re: [BUG] x2apic broken with current AMD hardware

2023-03-20 Thread Jan Beulich
On 20.03.2023 09:14, Jan Beulich wrote: > On 17.03.2023 18:26, Elliott Mitchell wrote: >> On Fri, Mar 17, 2023 at 09:22:09AM +0100, Jan Beulich wrote: >>> On 16.03.2023 23:03, Elliott Mitchell wrote: On Mon, Mar 13, 2023 at 08:01:02AM +0100, Jan Beulich wrote: > On 11.03.2023 01:09,

[PATCH v4] x86: detect CMOS aliasing on ports other than 0x70/0x71

2023-03-20 Thread Jan Beulich
... in order to also intercept Dom0 accesses through the alias ports. Also stop intercepting accesses to the CMOS ports if we won't ourselves use the CMOS RTC. Signed-off-by: Jan Beulich --- v4: Also conditionally mask top bit for guest index port accesses. Add missing adjustments to

Re: [PATCH v2 1/2] x86/APIC: include full string with error_interrupt() error messages

2023-03-20 Thread Jan Beulich
On 17.03.2023 20:45, Elliott Mitchell wrote: > Rather than adding ", " with each printf(), simply include them in the > string initially. Why is this better? You're now using more space in .rodata. (I haven't looked at patch 2 yet to see whether there's a possible reason there for the change

Re: [PATCH] x86: extend coverage of HLE "bad page" workaround

2023-03-20 Thread Jan Beulich
On 17.03.2023 12:39, Roger Pau Monné wrote: > On Tue, May 26, 2020 at 06:40:16PM +0200, Jan Beulich wrote: >> On 26.05.2020 17:01, Andrew Cooper wrote: >>> On 26/05/2020 14:35, Jan Beulich wrote: On 26.05.2020 13:17, Andrew Cooper wrote: > On 26/05/2020 07:49, Jan Beulich wrote: >>

Re: [PATCH v4] x86/HVM: support emulated UMIP

2023-03-20 Thread Jan Beulich
On 17.03.2023 17:30, Andrew Cooper wrote: > On 17/03/2023 2:29 pm, Roger Pau Monné wrote: >> On Thu, Apr 15, 2021 at 11:47:42AM +0200, Jan Beulich wrote: >>> There are three noteworthy drawbacks: >>> 1) The intercepts we need to enable here are CPL-independent, i.e. we >>>now have to emulate

Re: [PATCH v3] xen/console: Skip switching serial input to non existing domains

2023-03-20 Thread Jan Beulich
On 20.03.2023 13:07, Michal Orzel wrote: > On 20/03/2023 12:17, Jan Beulich wrote: >> One other transformation for you to consider is to switch to a base >> layout like >> >> unsigned int next_rx = console_rx; >> while ( next_rx++ <= max_console_rx ) >> { >> ... >> } >> >>

[xen-unstable test] 179799: tolerable trouble: fail/pass/starved

2023-03-20 Thread osstest service owner
flight 179799 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/179799/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail in 179770 pass in 179799

[PATCH v6 1/4] PCI: Introduce pci_dev_for_each_resource()

2023-03-20 Thread Andy Shevchenko
From: Mika Westerberg Instead of open-coding it everywhere introduce a tiny helper that can be used to iterate over each resource of a PCI device, and convert the most obvious users into it. While at it drop doubled empty line before pdev_sort_resources(). No functional changes intended.

[PATCH v6 2/4] PCI: Split pci_bus_for_each_resource_p() out of pci_bus_for_each_resource()

2023-03-20 Thread Andy Shevchenko
Refactor pci_bus_for_each_resource() in the same way as it's done in pci_dev_for_each_resource() case. This will allow to hide iterator inside the loop, where it's not used otherwise. No functional changes intended. Signed-off-by: Andy Shevchenko Reviewed-by: Krzysztof Wilczyński ---

[PATCH v6 4/4] pcmcia: Convert to use pci_bus_for_each_resource_p()

2023-03-20 Thread Andy Shevchenko
The pci_bus_for_each_resource_p() hides the iterator loop since it may be not used otherwise. With this, we may drop that iterator variable definition. Signed-off-by: Andy Shevchenko Reviewed-by: Krzysztof Wilczyński Acked-by: Dominik Brodowski --- drivers/pcmcia/rsrc_nonstatic.c | 9

[PATCH v6 3/4] EISA: Convert to use pci_bus_for_each_resource_p()

2023-03-20 Thread Andy Shevchenko
The pci_bus_for_each_resource_p() hides the iterator loop since it may be not used otherwise. With this, we may drop that iterator variable definition. Signed-off-by: Andy Shevchenko Reviewed-by: Krzysztof Wilczyński --- drivers/eisa/pci_eisa.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[ovmf test] 179808: all pass - PUSHED

2023-03-20 Thread osstest service owner
flight 179808 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/179808/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf b7a8264ae4704f781e70cc44dafdf07e4e5e690a baseline version: ovmf

Re: [PATCH-for-8.1 4/5] bulk: Do not declare function prototypes using extern keyword

2023-03-20 Thread Daniel P . Berrangé
On Mon, Mar 20, 2023 at 02:42:18PM +0100, Philippe Mathieu-Daudé wrote: > By default, C function prototypes declared in headers are visible, > so there is no need to declare them as 'extern' functions. > Remove this redundancy in a single bulk commit; do not modify: > > - meson.build (used to

Re: [PATCH v2] vpci/msix: handle accesses adjacent to the MSI-X table

2023-03-20 Thread Jan Beulich
On 16.03.2023 13:07, Roger Pau Monne wrote: > --- a/xen/drivers/vpci/msix.c > +++ b/xen/drivers/vpci/msix.c > @@ -27,6 +27,11 @@ > ((addr) >= vmsix_table_addr(vpci, nr) && \ > (addr) < vmsix_table_addr(vpci, nr) + vmsix_table_size(vpci, nr)) > > +#define

[PATCH v4] xen/console: Skip switching serial input to non existing domains

2023-03-20 Thread Michal Orzel
At the moment, we direct serial input to hardware domain by default. This does not make any sense when running in true dom0less mode, since such domain does not exist. As a result, users wishing to write to an emulated UART of a domU are always forced to execute CTRL-AAA first. The same issue is

Re: [PATCH] x86/Xen: make use of IBPB controlling VM assist

2023-03-20 Thread Juergen Gross
On 20.03.23 14:17, Jan Beulich wrote: On 20.03.2023 14:02, Juergen Gross wrote: On 20.03.23 11:19, Jan Beulich wrote: On 17.03.2023 14:56, Juergen Gross wrote: +void __init xen_pv_fix_mitigations(void) +{ + if (!xen_vm_assist_ibpb(true)) +

Re: [PATCH v3] xen/console: Skip switching serial input to non existing domains

2023-03-20 Thread Michal Orzel
On 20/03/2023 12:17, Jan Beulich wrote: > > > On 20.03.2023 09:19, Michal Orzel wrote: >> @@ -483,15 +485,34 @@ struct domain *console_input_domain(void) >> >> static void switch_serial_input(void) >> { >> -if ( console_rx == max_init_domid + 1 ) >> -{ >> -console_rx = 0; >>

Re: [help] Xen 4.14.5 on Devuan 4.0 Chimaera, regression from Xen 4.0.1

2023-03-20 Thread Denis
On 20.03.2023 12:01, Andrew Cooper wrote: > On 19/03/2023 7:38 pm, Denis wrote: > > On 14.03.2023 16:11, Andrew Cooper wrote: > >> On 14/03/2023 2:53 pm, Denis wrote: > >>> On 14.03.2023 07:37; Jan Beulich wrote: > On 14.03.2023 02:15, Denis wrote: > > On 13.03.2023 10:36, Jan wrote >

Re: [PATCH] x86/Xen: make use of IBPB controlling VM assist

2023-03-20 Thread Juergen Gross
On 20.03.23 11:19, Jan Beulich wrote: On 17.03.2023 14:56, Juergen Gross wrote: On 15.02.23 09:31, Jan Beulich wrote: Eventually yes. But I would prefer to sort the above question first (which I'm sure would have been raised by them, in perhaps more harsh a way), hence the initially limited

[PATCH v6 0/4] Add pci_dev_for_each_resource() helper and update users

2023-03-20 Thread Andy Shevchenko
Provide two new helper macros to iterate over PCI device resources and convert users. Looking at it, refactor existing pci_bus_for_each_resource() and convert users accordingly. Changelog v6: - dropped unused variable in PPC code (LKP) Changelog v5: - renamed loop variable to minimize the clash

Re: [PATCH] x86/Xen: make use of IBPB controlling VM assist

2023-03-20 Thread Jan Beulich
On 20.03.2023 14:02, Juergen Gross wrote: > On 20.03.23 11:19, Jan Beulich wrote: >> On 17.03.2023 14:56, Juergen Gross wrote: >>> +void __init xen_pv_fix_mitigations(void) >>> +{ >>> + if (!xen_vm_assist_ibpb(true)) >>> + setup_clear_cpu_cap(X86_FEATURE_ENTRY_IBPB); >> >> ...

[PATCH-for-8.1 4/5] bulk: Do not declare function prototypes using extern keyword

2023-03-20 Thread Philippe Mathieu-Daudé
By default, C function prototypes declared in headers are visible, so there is no need to declare them as 'extern' functions. Remove this redundancy in a single bulk commit; do not modify: - meson.build (used to check function availability at runtime) - pc-bios - libdecnumber - *.c

[XEN PATCH v2] build: detect compiler change to rerun kconfig

2023-03-20 Thread Anthony PERARD
This simple comment allows to detect when $(CC) changes version. Kconfig will be rerun in this case. (Rerun is forced by include/config/auto.conf.cmd which detects changes of CC_VERSION_TEXT value). Signed-off-by: Anthony PERARD --- Technically, it was acked by Andrew:

Re: [RFC XEN PATCH 6/6] tools/libs/light: pci: translate irq to gsi

2023-03-20 Thread Jan Beulich
On 20.03.2023 16:16, Roger Pau Monné wrote: > @@ -244,12 +242,18 @@ static void vioapic_write_redirent( > } > else > { > +int ret; > + > unmasked = ent.fields.mask; > /* Remote IRR and Delivery Status are read-only. */ > ent.bits = ((ent.bits >>

Re: [BUG] x2apic broken with current AMD hardware

2023-03-20 Thread Elliott Mitchell
On Mon, Mar 20, 2023 at 09:14:17AM +0100, Jan Beulich wrote: > On 17.03.2023 18:26, Elliott Mitchell wrote: > > On Fri, Mar 17, 2023 at 09:22:09AM +0100, Jan Beulich wrote: > >> On 16.03.2023 23:03, Elliott Mitchell wrote: > >>> On Mon, Mar 13, 2023 at 08:01:02AM +0100, Jan Beulich wrote: >

Re: [PATCH v2 2/2] x86/APIC: modify error_interrupt() to output using single printk()

2023-03-20 Thread Jan Beulich
On 20.03.2023 15:29, Elliott Mitchell wrote: > On Mon, Mar 20, 2023 at 09:56:54AM +0100, Jan Beulich wrote: >> On 17.03.2023 20:53, Elliott Mitchell wrote: >>> This takes care of the issue of APIC errors tending to occur on multiple >>> cores at one. In turn this tends to causes the error

Re: [BUG] x2apic broken with current AMD hardware

2023-03-20 Thread Jan Beulich
On 20.03.2023 16:37, Elliott Mitchell wrote: > On Mon, Mar 20, 2023 at 09:14:17AM +0100, Jan Beulich wrote: >> On 17.03.2023 18:26, Elliott Mitchell wrote: >>> I'm tempted to propose allowing _Static_assert() since it is valuable >>> functionality for preventing issues. >> >> How does

Re: [PATCH v2 1/2] x86/APIC: include full string with error_interrupt() error messages

2023-03-20 Thread Elliott Mitchell
On Mon, Mar 20, 2023 at 09:49:14AM +0100, Jan Beulich wrote: > On 17.03.2023 20:45, Elliott Mitchell wrote: > > Rather than adding ", " with each printf(), simply include them in the > > string initially. > > Why is this better? You're now using more space in .rodata. (I haven't > looked at patch

Re: [PATCH-for-8.1 4/5] bulk: Do not declare function prototypes using extern keyword

2023-03-20 Thread Philippe Mathieu-Daudé
On 20/3/23 14:48, Daniel P. Berrangé wrote: On Mon, Mar 20, 2023 at 02:42:18PM +0100, Philippe Mathieu-Daudé wrote: By default, C function prototypes declared in headers are visible, so there is no need to declare them as 'extern' functions. Remove this redundancy in a single bulk commit; do

Re: [help] Xen 4.14.5 on Devuan 4.0 Chimaera, regression from Xen 4.0.1

2023-03-20 Thread Jan Beulich
On 20.03.2023 13:46, Denis wrote: > On 20.03.2023 12:01, Andrew Cooper wrote: >> On 19/03/2023 7:38 pm, Denis wrote: >>> As you suspected, there are a few IO page faults at the end of the boot >>> process >>> (from my limited understanding it's maybe related to >>> "00:14.0 SMBus: Advanced Micro

Re: [PATCH v2 2/2] x86/APIC: modify error_interrupt() to output using single printk()

2023-03-20 Thread Elliott Mitchell
On Mon, Mar 20, 2023 at 09:56:54AM +0100, Jan Beulich wrote: > On 17.03.2023 20:53, Elliott Mitchell wrote: > > This takes care of the issue of APIC errors tending to occur on multiple > > cores at one. In turn this tends to causes the error messages to be > > Nit: "at once"?

  1   2   >