Re: [PATCH 3/3] xen/misra: xen-analysis.py: use the relative path from the ...

2023-05-19 Thread Michal Orzel
Hi Luca, On 17/05/2023 02:44, Stefano Stabellini wrote: > > > On Thu, 4 May 2023, Luca Fancellu wrote: >> repository in the reports >> >> Currently the cppcheck report entries shows the relative file path >> from the /xen folder of the repository instead of the base folder. >> In order to ease

Re: [PATCH 3/3] xen/misra: xen-analysis.py: use the relative path from the ...

2023-05-19 Thread Michal Orzel
On 19/05/2023 09:12, Luca Fancellu wrote: > > >> On 19 May 2023, at 08:08, Michal Orzel wrote: >> >> Hi Luca, >> >> On 17/05/2023 02:44, Stefano Stabellini wrote: >>> >>> >>> On Thu, 4 May 2023, Luca Fancellu wrote: repository in the reports Currently the cppcheck report

Re: PVH Dom0 related UART failure

2023-05-19 Thread Jan Beulich
On 18.05.2023 12:34, Roger Pau Monné wrote: > On Wed, May 17, 2023 at 05:59:31PM -0700, Stefano Stabellini wrote: >> I have run into another PVH Dom0 issue. I am trying to enable a PVH Dom0 >> test with the brand new gitlab-ci runner offered by Qubes. It is an AMD >> Zen3 system and we already

Re: [PATCH 4/4] x86/spec-ctrl: Remove opencoded MSR_ARCH_CAPS check

2023-05-19 Thread Jan Beulich
On 17.05.2023 18:35, Andrew Cooper wrote: > On 17/05/2023 3:47 pm, Jan Beulich wrote: >> On 16.05.2023 16:53, Andrew Cooper wrote: >>> @@ -401,6 +400,8 @@ static void __init print_details(enum ind_thunk thunk, >>> uint64_t caps) >>> cpuid_count(7, 2, , , , &_7d2); >>> if (

Re: [PATCH RFC] xen: Enable -Wwrite-strings

2023-05-19 Thread Jan Beulich
On 17.05.2023 19:00, Andrew Cooper wrote: > On 17/05/2023 11:34 am, Jan Beulich wrote: >> On 16.05.2023 22:34, Andrew Cooper wrote: >>> Following on from the MISRA discussions. >>> >>> On x86, most are trivial. The two slightly suspect cases are __hvm_copy() >>> where constness is dependent on

[xen-unstable test] 180701: regressions - FAIL

2023-05-19 Thread osstest service owner
flight 180701 xen-unstable real [real] flight 180719 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180701/ http://logs.test-lab.xenproject.org/osstest/logs/180719/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be

Re: PVH Dom0 related UART failure

2023-05-19 Thread Roger Pau Monné
On Fri, May 19, 2023 at 09:22:58AM +0200, Jan Beulich wrote: > On 18.05.2023 12:34, Roger Pau Monné wrote: > > On Wed, May 17, 2023 at 05:59:31PM -0700, Stefano Stabellini wrote: > >> I have run into another PVH Dom0 issue. I am trying to enable a PVH Dom0 > >> test with the brand new gitlab-ci

Re: [PATCH] x86: do away with HAVE_AS_NEGATIVE_TRUE

2023-05-19 Thread Jan Beulich
On 17.05.2023 19:05, Andrew Cooper wrote: > On 17/05/2023 3:22 pm, Jan Beulich wrote: >> There's no real need for the associated probing - we can easily convert >> to a uniform value without knowing the specific behavior (note also that >> the respective comments weren't fully correct and have

Re: PVH Dom0 related UART failure

2023-05-19 Thread Jan Beulich
On 19.05.2023 09:38, Roger Pau Monné wrote: > On Fri, May 19, 2023 at 09:22:58AM +0200, Jan Beulich wrote: >> On 18.05.2023 12:34, Roger Pau Monné wrote: >>> On Wed, May 17, 2023 at 05:59:31PM -0700, Stefano Stabellini wrote: I have run into another PVH Dom0 issue. I am trying to enable a PVH

[qemu-mainline test] 180704: regressions - FAIL

2023-05-19 Thread osstest service owner
flight 180704 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/180704/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 180691 build-amd64

Re: [PATCH 3/3] xen/misra: xen-analysis.py: use the relative path from the ...

2023-05-19 Thread Luca Fancellu
> On 19 May 2023, at 08:08, Michal Orzel wrote: > > Hi Luca, > > On 17/05/2023 02:44, Stefano Stabellini wrote: >> >> >> On Thu, 4 May 2023, Luca Fancellu wrote: >>> repository in the reports >>> >>> Currently the cppcheck report entries shows the relative file path >>> from the /xen

Re: PVH Dom0 related UART failure

2023-05-19 Thread Roger Pau Monné
On Thu, May 18, 2023 at 06:46:52PM -0700, Stefano Stabellini wrote: > On Thu, 18 May 2023, Roger Pau Monné wrote: > > On Wed, May 17, 2023 at 05:59:31PM -0700, Stefano Stabellini wrote: > > > Hi all, > > > > > > I have run into another PVH Dom0 issue. I am trying to enable a PVH Dom0 > > > test

Re: [PATCH 4/4] x86/spec-ctrl: Remove opencoded MSR_ARCH_CAPS check

2023-05-19 Thread Andrew Cooper
On 19/05/2023 7:00 am, Jan Beulich wrote: > On 17.05.2023 18:35, Andrew Cooper wrote: >> On 17/05/2023 3:47 pm, Jan Beulich wrote: >>> On 16.05.2023 16:53, Andrew Cooper wrote: @@ -401,6 +400,8 @@ static void __init print_details(enum ind_thunk thunk, uint64_t caps)

Re: [PATCH v6 01/12] xen/arm: enable SVE extension for Xen

2023-05-19 Thread Luca Fancellu
> On 19 May 2023, at 15:46, Julien Grall wrote: > > Hi Luca, > > On 19/05/2023 15:26, Luca Fancellu wrote: >>> On 18 May 2023, at 10:35, Julien Grall wrote: /* * Comment from Linux: * Userspace may perform DC ZVA instructions. Mismatched block sizes diff --git

Re: [PATCH 3/6] x86/cpu-policy: Infrastructure for MSR_ARCH_CAPS

2023-05-19 Thread Andrew Cooper
On 16/05/2023 1:02 pm, Jan Beulich wrote: > On 15.05.2023 16:42, Andrew Cooper wrote: >> Bits through 24 are already defined, meaning that we're not far off needing >> the second word. Put both in right away. >> >> The bool bitfield names in the arch_caps union are unused, and somewhat out >> of

Re: [PATCH 6/6] x86/boot: Expose MSR_ARCH_CAPS data in guest max policies

2023-05-19 Thread Andrew Cooper
On 16/05/2023 3:58 pm, Jan Beulich wrote: > On 15.05.2023 16:42, Andrew Cooper wrote: >> --- a/xen/arch/x86/cpu-policy.c >> +++ b/xen/arch/x86/cpu-policy.c >> @@ -408,6 +408,25 @@ static void __init calculate_host_policy(void) >> p->platform_info.cpuid_faulting = cpu_has_cpuid_faulting; >> }

Re: [PATCH 6/6] x86/boot: Expose MSR_ARCH_CAPS data in guest max policies

2023-05-19 Thread Andrew Cooper
On 17/05/2023 10:20 am, Jan Beulich wrote: > On 16.05.2023 21:31, Andrew Cooper wrote: >> On 16/05/2023 3:53 pm, Jan Beulich wrote: >>> I guess that's no >>> different from other max-only features with dependents, but I wonder >>> whether that's good behavior. >> It's not really something you get

Re: [PATCH] tools/xendomains: Only save/restore/migrate if supported by xenlight

2023-05-19 Thread Anthony PERARD
On Thu, Apr 06, 2023 at 03:57:12PM +0100, Peter Hoyes wrote: > On 04/04/2023 17:28, Anthony PERARD wrote: > > On Wed, Mar 22, 2023 at 01:58:00PM +, Peter Hoyes wrote: > > > From: Peter Hoyes > > > > > > Saving, restoring and migrating domains are not currently supported on > > > arm and

[qemu-mainline test] 180742: regressions - FAIL

2023-05-19 Thread osstest service owner
flight 180742 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/180742/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 180691 build-amd64

[XEN PATCH] tools/xendomains: Don't auto save/restore/migrate on Arm*

2023-05-19 Thread Anthony PERARD
Saving, restoring and migrating domains are not currently supported on arm and arm64 platforms, so xendomains prints the warning: An error occurred while saving domain: command not implemented when attempting to run `xendomains stop`. It otherwise continues to shut down the domains cleanly,

Re: [PATCH v6 01/12] xen/arm: enable SVE extension for Xen

2023-05-19 Thread Julien Grall
Hi Luca, On 19/05/2023 15:26, Luca Fancellu wrote: On 18 May 2023, at 10:35, Julien Grall wrote: /* * Comment from Linux: * Userspace may perform DC ZVA instructions. Mismatched block sizes diff --git a/xen/arch/arm/arm64/sve-asm.S b/xen/arch/arm/arm64/sve-asm.S new file mode

Re: [PATCH v6 01/12] xen/arm: enable SVE extension for Xen

2023-05-19 Thread Luca Fancellu
> On 19 May 2023, at 16:00, Julien Grall wrote: > > > > On 19/05/2023 15:51, Luca Fancellu wrote: >> /* Control Registers */ >> /* >> * CPTR_EL2 needs to be written before calling vfp_restore_state, a >> * synchronization instruction is expected after the write (isb) >> */ >>

Re: [PATCH v6 01/12] xen/arm: enable SVE extension for Xen

2023-05-19 Thread Julien Grall
Hi, On 19/05/2023 16:13, Luca Fancellu wrote: On 19/05/2023 15:51, Luca Fancellu wrote: /* Control Registers */ /* * CPTR_EL2 needs to be written before calling vfp_restore_state, a * synchronization instruction is expected after the write (isb) */ WRITE_SYSREG(n->arch.cptr_el2, CPTR_EL2);

Re: [patch V4 36/37] x86/smpboot: Support parallel startup of secondary CPUs

2023-05-19 Thread Andrew Cooper
On 19/05/2023 5:28 pm, Jeffrey Hugo wrote: >   DESCEND objtool >   INSTALL libsubcmd_headers >   CALL    scripts/checksyscalls.sh >   AS  arch/x86/kernel/head_64.o > arch/x86/kernel/head_64.S: Assembler messages: > arch/x86/kernel/head_64.S:261: Error: missing ')' >

Re: [PATCH v7 1/5] xen/riscv: add VM space layout

2023-05-19 Thread Jan Beulich
On 17.05.2023 17:56, Oleksii wrote: > On Tue, 2023-05-16 at 17:42 +0200, Jan Beulich wrote: >> On 11.05.2023 19:09, Oleksii Kurochko wrote: >>> === >>> = >>> + *    Start addr    |   End addr    |  Size  | Slot   >>>

[PATCH] [v2] x86: xen: add missing prototypes

2023-05-19 Thread Arnd Bergmann
From: Arnd Bergmann These function are all called from assembler files, or from inline assembler, so there is no immediate need for a prototype in a header, but if -Wmissing-prototypes is enabled, the compiler warns about them: arch/x86/xen/efi.c:130:13: error: no previous prototype for

[PATCH 2/2] xen/misra: diff-report.py: add report patching feature

2023-05-19 Thread Luca Fancellu
Add a feature to the diff-report.py script that improves the comparison between two analysis report, one from a baseline codebase and the other from the changes applied to the baseline. The comparison between reports of different codebase is an issue because entries in the baseline could have

[PATCH 1/2] xen/misra: add diff-report.py tool

2023-05-19 Thread Luca Fancellu
Add a new tool, diff-report.py that can be used to make diff between reports generated by xen-analysis.py tool. Currently this tool supports the Xen cppcheck text report format in its operations. The tool prints every finding that is in the report passed with -r (check report) which is not in the

[PATCH v2 0/2] diff-report.py tool

2023-05-19 Thread Luca Fancellu
This serie is dependent on this patch, in case cppcheck report are generated using xen-analysis.py that calls the makefile with in-tree build:

Re: [PATCH 00/20] x86: address -Wmissing-prototype warnings

2023-05-19 Thread Andy Shevchenko
On Fri, May 19, 2023 at 12:56 AM Dave Hansen wrote: > On 5/16/23 12:35, Arnd Bergmann wrote: > I picked up the ones that were blatantly obvious, but left out 03, 04, > 10, 12 and 19 for the moment. Btw, there is series that went unnoticed

Re: [PATCH 1/2] xen/misra: add diff-report.py tool

2023-05-19 Thread Luca Fancellu
> On 19 May 2023, at 11:53, Jan Beulich wrote: > > On 19.05.2023 11:46, Luca Fancellu wrote: >> Add a new tool, diff-report.py that can be used to make diff between >> reports generated by xen-analysis.py tool. >> Currently this tool supports the Xen cppcheck text report format in >> its

[PATCH] maintainers: add regex matching for xsm

2023-05-19 Thread Daniel P. Smith
XSM is a subsystem where it is equally important of how and where its hooks are called as is the implementation of the hooks. The people best suited for evaluating the how and where are the XSM maintainers and reviewers. This creates a challenge as the hooks are used throughout the hypervisor for

[linux-linus test] 180706: regressions - FAIL

2023-05-19 Thread osstest service owner
flight 180706 linux-linus real [real] flight 180734 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180706/ http://logs.test-lab.xenproject.org/osstest/logs/180734/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be

[qemu-mainline test] 180721: regressions - FAIL

2023-05-19 Thread osstest service owner
flight 180721 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/180721/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 180691 build-amd64

Re: xen cache colors in ARM

2023-05-19 Thread Michal Orzel
Hi Oleg, On 19/05/2023 15:38, Oleg Nikitenko wrote: > > > > Hello, > > Thanks Michal. > > Then the next question. Now it is more related to the integration than to the > development. > A license for the xen in 4.17 revision at branch xlnx_rebase_4.17 xilinx repo > has changed. > I

Re: [PATCH] x86: do away with HAVE_AS_NEGATIVE_TRUE

2023-05-19 Thread Jan Beulich
On 19.05.2023 08:15, Jan Beulich wrote: > On 17.05.2023 19:05, Andrew Cooper wrote: >> On 17/05/2023 3:22 pm, Jan Beulich wrote: >>> There's no real need for the associated probing - we can easily convert >>> to a uniform value without knowing the specific behavior (note also that >>> the

Re: [PATCH v6 01/12] xen/arm: enable SVE extension for Xen

2023-05-19 Thread Luca Fancellu
> On 18 May 2023, at 10:35, Julien Grall wrote: > > Hi Luca, > > Sorry for jumping late in the review. Hi Julien, Thank you for taking the time to review, >> >> /* >>* Comment from Linux: >>* Userspace may perform DC ZVA instructions. Mismatched block sizes >> diff --git

Re: [PATCH v3 3/6] iommu/arm: Introduce iommu_add_dt_pci_sideband_ids API

2023-05-19 Thread Stewart Hildebrand
On 5/19/23 04:45, Jan Beulich wrote: > On 18.05.2023 23:06, Stewart Hildebrand wrote: >> --- a/xen/include/xen/iommu.h >> +++ b/xen/include/xen/iommu.h >> @@ -26,6 +26,7 @@ >> #include >> #include >> #include >> +#include >> #include > > I view this as problematic: It'll require all

[libvirt test] 180714: tolerable all pass - PUSHED

2023-05-19 Thread osstest service owner
flight 180714 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/180714/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-raw 15 saverestore-support-checkfail like 180698 test-armhf-armhf-libvirt-qcow2 15

Re: [PATCH v6 01/12] xen/arm: enable SVE extension for Xen

2023-05-19 Thread Julien Grall
On 19/05/2023 15:51, Luca Fancellu wrote: /* Control Registers */ /* * CPTR_EL2 needs to be written before calling vfp_restore_state, a * synchronization instruction is expected after the write (isb) */ WRITE_SYSREG(n->arch.cptr_el2, CPTR_EL2); WRITE_SYSREG(n->arch.cpacr, CPACR_EL1); /* *

Re: [PATCH 1/4] x86/cpufeature: Rework {boot_,}cpu_has()

2023-05-19 Thread Andrew Cooper
On 17/05/2023 3:01 pm, Jan Beulich wrote: > On 16.05.2023 16:53, Andrew Cooper wrote: >> --- a/xen/arch/x86/include/asm/cpufeature.h >> +++ b/xen/arch/x86/include/asm/cpufeature.h >> @@ -7,6 +7,7 @@ >> #define __ASM_I386_CPUFEATURE_H >> >> #include >> +#include >> #include > This isn't

Re: [PATCH v1] xen/sched/null: avoid crash after failed domU creation

2023-05-19 Thread Jan Beulich
On 18.05.2023 23:27, Stewart Hildebrand wrote: > On 5/5/23 01:59, Juergen Gross wrote: >> On 01.05.23 22:30, Stewart Hildebrand wrote: >>> When creating a domU, but the creation fails, there is a corner case that >>> may >>> lead to a crash in the null scheduler when running a debug build of Xen.

Re: [PATCH 3/6] block/blkio: convert to blk_io_plug_call() API

2023-05-19 Thread Stefano Garzarella
On Wed, May 17, 2023 at 06:10:19PM -0400, Stefan Hajnoczi wrote: Stop using the .bdrv_co_io_plug() API because it is not multi-queue block layer friendly. Use the new blk_io_plug_call() API to batch I/O submission instead. Signed-off-by: Stefan Hajnoczi --- block/blkio.c | 40

Re: [PATCH 2/6] block/nvme: convert to blk_io_plug_call() API

2023-05-19 Thread Stefano Garzarella
On Wed, May 17, 2023 at 06:10:18PM -0400, Stefan Hajnoczi wrote: Stop using the .bdrv_co_io_plug() API because it is not multi-queue block layer friendly. Use the new blk_io_plug_call() API to batch I/O submission instead. Signed-off-by: Stefan Hajnoczi --- block/nvme.c | 44

Re: PVH Dom0 related UART failure

2023-05-19 Thread Jan Beulich
On 19.05.2023 10:55, Roger Pau Monné wrote: > On Fri, May 19, 2023 at 10:20:24AM +0200, Jan Beulich wrote: >> On 19.05.2023 09:38, Roger Pau Monné wrote: >>> On Fri, May 19, 2023 at 09:22:58AM +0200, Jan Beulich wrote: On 18.05.2023 12:34, Roger Pau Monné wrote: > On Wed, May 17, 2023 at

Re: [PATCH 3/3] xen/misra: xen-analysis.py: use the relative path from the ...

2023-05-19 Thread Luca Fancellu
> On 19 May 2023, at 08:25, Michal Orzel wrote: > > > On 19/05/2023 09:12, Luca Fancellu wrote: >> >> >>> On 19 May 2023, at 08:08, Michal Orzel wrote: >>> >>> Hi Luca, >>> >>> On 17/05/2023 02:44, Stefano Stabellini wrote: On Thu, 4 May 2023, Luca Fancellu wrote: >

Re: [PATCH 00/20] x86: address -Wmissing-prototype warnings

2023-05-19 Thread Arnd Bergmann
On Thu, May 18, 2023, at 23:56, Dave Hansen wrote: > On 5/16/23 12:35, Arnd Bergmann wrote: >> >> All of the warnings have to be addressed in some form before the warning >> can be enabled by default. > > I picked up the ones that were blatantly obvious, but left out 03, 04, > 10, 12 and 19 for

Re: [PATCH 1/6] block: add blk_io_plug_call() API

2023-05-19 Thread Stefano Garzarella
On Wed, May 17, 2023 at 06:10:17PM -0400, Stefan Hajnoczi wrote: Introduce a new API for thread-local blk_io_plug() that does not traverse the block graph. The goal is to make blk_io_plug() multi-queue friendly. Instead of having block drivers track whether or not we're in a plugged section,

Re: [PATCH v3 3/6] iommu/arm: Introduce iommu_add_dt_pci_sideband_ids API

2023-05-19 Thread Jan Beulich
On 18.05.2023 23:06, Stewart Hildebrand wrote: > --- a/xen/include/xen/iommu.h > +++ b/xen/include/xen/iommu.h > @@ -26,6 +26,7 @@ > #include > #include > #include > +#include > #include I view this as problematic: It'll require all architectures with an IOMMU implementation to have an

Re: [PATCH 2/4] x86: always initialize xen-swiotlb when xen-pcifront is enabling

2023-05-19 Thread Marek Marczykowski-Górecki
On Fri, May 19, 2023 at 06:04:05AM +0200, Christoph Hellwig wrote: > On Thu, May 18, 2023 at 08:18:39PM +0200, Marek Marczykowski-Górecki wrote: > > On Thu, May 18, 2023 at 03:42:51PM +0200, Christoph Hellwig wrote: > > > Remove the dangerous late initialization of xen-swiotlb in > > >

Re: [PATCH 1/2] xen/misra: add diff-report.py tool

2023-05-19 Thread Jan Beulich
On 19.05.2023 13:10, Luca Fancellu wrote: > > >> On 19 May 2023, at 11:53, Jan Beulich wrote: >> >> On 19.05.2023 11:46, Luca Fancellu wrote: >>> Add a new tool, diff-report.py that can be used to make diff between >>> reports generated by xen-analysis.py tool. >>> Currently this tool supports

Re: [PATCH 1/2] xen/misra: add diff-report.py tool

2023-05-19 Thread Jan Beulich
On 19.05.2023 11:46, Luca Fancellu wrote: > Add a new tool, diff-report.py that can be used to make diff between > reports generated by xen-analysis.py tool. > Currently this tool supports the Xen cppcheck text report format in > its operations. > > The tool prints every finding that is in the

Re: [PATCH v3 08/14 RESEND] libxc: Include hwp_para in definitions

2023-05-19 Thread Anthony PERARD
On Mon, May 01, 2023 at 03:30:28PM -0400, Jason Andryuk wrote: > Expose the hwp_para fields through libxc. > > Signed-off-by: Jason Andryuk Acked-by: Anthony PERARD Thanks, -- Anthony PERARD

Re: [PATCH] pci: fix pci_get_pdev() to always account for the segment

2023-05-19 Thread Jan Beulich
On 18.05.2023 12:57, Roger Pau Monne wrote: > When a domain parameter is provided to pci_get_pdev() the search > function would match against the bdf, without taking the segment into > account. > > Fix this and also account for the passed segment. > > Fixes: 8cf6e0738906 ('PCI: simplify (and

Re: [XEN v7 08/11] xen/arm: Introduce choice to enable 64/32 bit physical addressing

2023-05-19 Thread Michal Orzel
Hi Ayan, On 18/05/2023 16:39, Ayan Kumar Halder wrote: > Some Arm based hardware platforms which does not support LPAE > (eg Cortex-R52), uses 32 bit physical addresses. > Also, users may choose to use 32 bits to represent physical addresses > for optimization. > > To support the above use

[PATCH 2/3] xen/misra: xen-analysis.py: Fix latent bug

2023-05-19 Thread Luca Fancellu
Currenly there is a latent bug that is not triggered because the function cppcheck_merge_txt_fragments is called with the parameter strip_paths having a list of only one element. The bug is that the split function should not be in the loop for strip_paths, but one level before, fix it. Fixes:

[PATCH 3/3] xen/misra: xen-analysis.py: Fix cppcheck report relative paths

2023-05-19 Thread Luca Fancellu
Fix the generation of the relative path from the repo, for cppcheck reports, when the script is launching make with in-tree build. Fixes: b046f7e37489 ("xen/misra: xen-analysis.py: use the relative path from the ...") Reported-by: Michal Orzel Signed-off-by: Luca Fancellu ---

[PATCH 1/3] xen/misra: xen-analysis.py: Improve the cppcheck version check

2023-05-19 Thread Luca Fancellu
Use tuple comparison to check the cppcheck version. Take the occasion to harden the regex, escaping the dots so that we check for them instead of generic characters. Suggested-by: Andrew Cooper Signed-off-by: Luca Fancellu --- xen/scripts/xen_analysis/cppcheck_analysis.py | 13 -

[PATCH 0/3] Fix and improvements to xen-analysis.py - Pt.2

2023-05-19 Thread Luca Fancellu
This serie includes one improvement suggested by Andrew Cooper, and two bug fix for the xen-analysis.py tool. Luca Fancellu (3): xen/misra: xen-analysis.py: Improve the cppcheck version check xen/misra: xen-analysis.py: Fix latent bug xen/misra: xen-analysis.py: Fix cppcheck report relative

Re: [PATCH 10/20] x86: xen: add missing prototypes

2023-05-19 Thread Arnd Bergmann
On Thu, May 18, 2023, at 19:28, Dave Hansen wrote: > On 5/16/23 12:35, Arnd Bergmann wrote: >> >> arch/x86/xen/enlighten_pv.c:1233:34: error: no previous prototype for >> 'xen_start_kernel' [-Werror=missing-prototypes] >> arch/x86/xen/irq.c:22:14: error: no previous prototype for >>

Re: [XEN v7 07/11] xen/arm: p2m: Use the pa_range_info table to support ARM_32 and ARM_64

2023-05-19 Thread Michal Orzel
Hi Ayan, On 18/05/2023 16:39, Ayan Kumar Halder wrote: > Restructure the code so that one can use pa_range_info[] table for both > ARM_32 as well as ARM_64. > > Also, removed the hardcoding for P2M_ROOT_ORDER and P2M_ROOT_LEVEL as > p2m_root_order can be obtained from the

Re: PVH Dom0 related UART failure

2023-05-19 Thread Roger Pau Monné
On Fri, May 19, 2023 at 10:20:24AM +0200, Jan Beulich wrote: > On 19.05.2023 09:38, Roger Pau Monné wrote: > > On Fri, May 19, 2023 at 09:22:58AM +0200, Jan Beulich wrote: > >> On 18.05.2023 12:34, Roger Pau Monné wrote: > >>> On Wed, May 17, 2023 at 05:59:31PM -0700, Stefano Stabellini wrote: >

Re: [PATCH 2/4] x86: always initialize xen-swiotlb when xen-pcifront is enabling

2023-05-19 Thread Christoph Hellwig
On Fri, May 19, 2023 at 12:10:26PM +0200, Marek Marczykowski-Górecki wrote: > While I would say PCI passthrough is not very common for PV guests, can > the decision about xen-swiotlb be delayed until you can enumerate > xenstore to check if there are any PCI devices connected (and not > allocate

Re: [PATCH v3 11/14 RESEND] libxc: Add xc_set_cpufreq_hwp

2023-05-19 Thread Anthony PERARD
On Mon, May 01, 2023 at 03:30:31PM -0400, Jason Andryuk wrote: > Add xc_set_cpufreq_hwp to allow calling xen_systctl_pm_op > SET_CPUFREQ_HWP. > > Signed-off-by: Jason Andryuk Acked-by: Anthony PERARD Thanks, -- Anthony PERARD

Re: [PATCH 2/2] xen/misra: diff-report.py: add report patching feature

2023-05-19 Thread Luca Fancellu
> On 19 May 2023, at 10:46, Luca Fancellu wrote: > > Add a feature to the diff-report.py script that improves the comparison > between two analysis report, one from a baseline codebase and the other > from the changes applied to the baseline. > > The comparison between reports of different

Re: [PATCH 2/4] x86: always initialize xen-swiotlb when xen-pcifront is enabling

2023-05-19 Thread Andrew Cooper
On 19/05/2023 1:41 pm, Christoph Hellwig wrote: > On Fri, May 19, 2023 at 12:10:26PM +0200, Marek Marczykowski-Górecki wrote: >> While I would say PCI passthrough is not very common for PV guests, can >> the decision about xen-swiotlb be delayed until you can enumerate >> xenstore to check if

Re: [PATCH 2/4] x86: always initialize xen-swiotlb when xen-pcifront is enabling

2023-05-19 Thread Christoph Hellwig
On Fri, May 19, 2023 at 01:49:46PM +0100, Andrew Cooper wrote: > > The alternative would be to finally merge swiotlb-xen into swiotlb, in > > which case we might be able to do this later. Let me see what I can > > do there. > > If that is an option, it would be great to reduce the

Removing Linux memory hotplug limitations

2023-05-19 Thread Demi Marie Obenour
Qubes OS is trying to switch from relying on populate-on-demand to memory hotplug for Linux guests. However, this runs into a problem, which is that only a limited amount of memory can be hotplugged. My experiments with Qubes OS’s build of Linux 6.3.2 reveal: - The more memory a guest starts

Re: [PATCH v6 05/12] arm/sve: save/restore SVE context switch

2023-05-19 Thread Julien Grall
Hi, On 19/05/2023 18:35, Luca Fancellu wrote: On 18 May 2023, at 19:27, Julien Grall wrote: Hi Luca, On 24/04/2023 07:02, Luca Fancellu wrote: Save/restore context switch for SVE, allocate memory to contain the Z0-31 registers whose length is maximum 2048 bits each and FFR who can be

[qemu-mainline bisection] complete build-amd64-xsm

2023-05-19 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job build-amd64-xsm testid xen-build Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu https://gitlab.com/qemu-project/qemu.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git

[qemu-mainline bisection] complete build-amd64

2023-05-19 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job build-amd64 testid xen-build Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu https://gitlab.com/qemu-project/qemu.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git

Re: PVH Dom0 related UART failure

2023-05-19 Thread Marek Marczykowski-Górecki
On Fri, May 19, 2023 at 05:02:21PM -0700, Stefano Stabellini wrote: > On Fri, 19 May 2023, Roger Pau Monné wrote: > > On Thu, May 18, 2023 at 06:46:52PM -0700, Stefano Stabellini wrote: > > > On Thu, 18 May 2023, Roger Pau Monné wrote: > > > > On Wed, May 17, 2023 at 05:59:31PM -0700, Stefano

[linux-linus test] 180738: regressions - FAIL

2023-05-19 Thread osstest service owner
flight 180738 linux-linus real [real] flight 180776 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180738/ http://logs.test-lab.xenproject.org/osstest/logs/180776/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be

[qemu-mainline test] 180753: regressions - FAIL

2023-05-19 Thread osstest service owner
flight 180753 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/180753/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 180691 build-amd64

Re: [PATCH] [v2] x86: xen: add missing prototypes

2023-05-19 Thread Boris Ostrovsky
On 5/19/23 5:28 AM, Arnd Bergmann wrote: diff --git a/arch/x86/xen/smp.h b/arch/x86/xen/smp.h index 22fb982ff971..81a7821dd07f 100644 --- a/arch/x86/xen/smp.h +++ b/arch/x86/xen/smp.h @@ -1,7 +1,11 @@ /* SPDX-License-Identifier: GPL-2.0 */ #ifndef _XEN_SMP_H +void

Re: PVH Dom0 related UART failure

2023-05-19 Thread Stefano Stabellini
On Fri, 19 May 2023, Jan Beulich wrote: > On 18.05.2023 12:34, Roger Pau Monné wrote: > > On Wed, May 17, 2023 at 05:59:31PM -0700, Stefano Stabellini wrote: > >> I have run into another PVH Dom0 issue. I am trying to enable a PVH Dom0 > >> test with the brand new gitlab-ci runner offered by

Re: PVH Dom0 related UART failure

2023-05-19 Thread Stefano Stabellini
On Fri, 19 May 2023, Roger Pau Monné wrote: > On Thu, May 18, 2023 at 06:46:52PM -0700, Stefano Stabellini wrote: > > On Thu, 18 May 2023, Roger Pau Monné wrote: > > > On Wed, May 17, 2023 at 05:59:31PM -0700, Stefano Stabellini wrote: > > > > Hi all, > > > > > > > > I have run into another PVH

Re: [PATCH v6 05/12] arm/sve: save/restore SVE context switch

2023-05-19 Thread Luca Fancellu
> On 18 May 2023, at 19:27, Julien Grall wrote: > > Hi Luca, > > On 24/04/2023 07:02, Luca Fancellu wrote: >> Save/restore context switch for SVE, allocate memory to contain >> the Z0-31 registers whose length is maximum 2048 bits each and >> FFR who can be maximum 256 bits, the allocated

[xen-unstable test] 180726: regressions - FAIL

2023-05-19 Thread osstest service owner
flight 180726 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/180726/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail REGR. vs. 180696 Tests which are

[qemu-mainline bisection] complete build-i386-xsm

2023-05-19 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job build-i386-xsm testid xen-build Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu https://gitlab.com/qemu-project/qemu.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git