[Xen-devel] [linux-linus test] 118775: regressions - FAIL
flight 118775 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/118775/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-debianhvm-amd64-xsm 7 xen-boot fail REGR. vs. 118324 test-amd64-i386-libvirt 7 xen-boot fail REGR. vs. 118324 test-amd64-i386-xl-xsm7 xen-boot fail REGR. vs. 118324 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-boot fail REGR. vs. 118324 test-amd64-i386-freebsd10-amd64 7 xen-boot fail REGR. vs. 118324 test-amd64-i386-xl-qemuu-win10-i386 7 xen-boot fail REGR. vs. 118324 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-boot fail REGR. vs. 118324 test-amd64-amd64-qemuu-nested-intel 7 xen-boot fail REGR. vs. 118324 test-amd64-amd64-libvirt 7 xen-boot fail REGR. vs. 118324 test-amd64-amd64-i386-pvgrub 7 xen-boot fail REGR. vs. 118324 test-amd64-amd64-xl 7 xen-boot fail REGR. vs. 118324 test-amd64-amd64-xl-qemut-win7-amd64 7 xen-boot fail REGR. vs. 118324 test-amd64-i386-xl-qemut-win7-amd64 7 xen-boot fail REGR. vs. 118324 test-amd64-amd64-xl-multivcpu 7 xen-bootfail REGR. vs. 118324 test-amd64-amd64-xl-qemut-debianhvm-amd64 7 xen-bootfail REGR. vs. 118324 test-amd64-amd64-xl-qemuu-debianhvm-amd64-xsm 7 xen-boot fail REGR. vs. 118324 test-amd64-amd64-xl-qemut-win10-i386 7 xen-boot fail REGR. vs. 118324 test-amd64-i386-xl-qemuu-debianhvm-amd64-xsm 7 xen-boot fail REGR. vs. 118324 test-amd64-amd64-rumprun-amd64 7 xen-boot fail REGR. vs. 118324 test-amd64-amd64-xl-pvhv2-intel 7 xen-boot fail REGR. vs. 118324 test-amd64-amd64-qemuu-nested-amd 7 xen-bootfail REGR. vs. 118324 test-amd64-amd64-xl-pvhv2-amd 7 xen-bootfail REGR. vs. 118324 test-amd64-amd64-xl-qemuu-win10-i386 7 xen-boot fail REGR. vs. 118324 test-amd64-amd64-amd64-pvgrub 7 xen-bootfail REGR. vs. 118324 test-amd64-amd64-xl-qcow2 7 xen-boot fail REGR. vs. 118324 test-amd64-amd64-pygrub 7 xen-boot fail REGR. vs. 118324 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-boot fail REGR. vs. 118324 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-boot fail REGR. vs. 118324 test-amd64-i386-xl-raw7 xen-boot fail REGR. vs. 118324 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-boot fail REGR. vs. 118324 test-amd64-amd64-xl-qemut-ws16-amd64 7 xen-boot fail REGR. vs. 118324 test-amd64-amd64-xl-xsm 7 xen-boot fail REGR. vs. 118324 test-amd64-amd64-libvirt-pair 10 xen-boot/src_host fail REGR. vs. 118324 test-amd64-amd64-libvirt-pair 11 xen-boot/dst_host fail REGR. vs. 118324 test-amd64-amd64-pair10 xen-boot/src_hostfail REGR. vs. 118324 test-amd64-amd64-pair11 xen-boot/dst_hostfail REGR. vs. 118324 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-boot fail REGR. vs. 118324 test-amd64-i386-examine 8 reboot fail REGR. vs. 118324 test-amd64-amd64-xl-qemuu-debianhvm-amd64 7 xen-bootfail REGR. vs. 118324 test-amd64-amd64-xl-qemuu-win7-amd64 7 xen-boot fail REGR. vs. 118324 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-boot fail REGR. vs. 118324 test-amd64-amd64-libvirt-xsm 7 xen-boot fail REGR. vs. 118324 test-amd64-amd64-libvirt-vhd 7 xen-boot fail REGR. vs. 118324 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-boot fail REGR. vs. 118324 test-amd64-i386-libvirt-pair 10 xen-boot/src_hostfail REGR. vs. 118324 test-amd64-i386-libvirt-pair 11 xen-boot/dst_hostfail REGR. vs. 118324 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-boot fail REGR. vs. 118324 test-amd64-i386-pair 10 xen-boot/src_hostfail REGR. vs. 118324 test-amd64-i386-pair 11 xen-boot/dst_hostfail REGR. vs. 118324 test-amd64-i386-rumprun-i386 7 xen-boot fail REGR. vs. 118324 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-boot fail REGR. vs. 118324 test-amd64-i386-xl-qemut-win10-i386 7 xen-boot fail REGR. vs. 118324 test-amd64-amd64-xl-qemuu-ws16-amd64 7 xen-boot fail REGR. vs. 118324 test-amd64-i386-freebsd10-i386 7 xen-boot fail REGR. vs. 118324 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-boot fail REGR. vs. 118324 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-boot fail REGR. vs. 118324 test-amd64-i386-libvirt-xsm 7 xen-boot fail REGR. vs. 118324 test-amd64-i386-xl7 xen-boot fail REGR. vs. 118324 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-boot fail REGR. vs. 118324 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7
Re: [Xen-devel] [PATCH v4 11/28] x86/vvtd: Process interrupt remapping request
On Fri, Feb 09, 2018 at 05:44:17PM +, Roger Pau Monné wrote: >On Fri, Nov 17, 2017 at 02:22:18PM +0800, Chao Gao wrote: >> When a remapping interrupt request arrives, remapping hardware computes the >> interrupt_index per the algorithm described in VTD spec >> "Interrupt Remapping Table", interprets the IRTE and generates a remapped >> interrupt request. >> >> This patch introduces viommu_handle_irq_request() to emulate the process how >> remapping hardware handles a remapping interrupt request. This patch >> also introduces a counter inflight_intr, which is used to count the number >> of interrupt are being handled. The reason why we should have this >> counter is VT-d hardware should drain in-flight interrups before setting >> flags to show that some operations are completed. These operations >> include enabling interrupt remapping and performing a kind of invalidation >> requests. In vvtd, we also try to drain in-flight interrupts by waiting >> the inflight_intr is decreased to 0. >> >> Signed-off-by: Chao Gao>> Signed-off-by: Lan Tianyu >> >> --- >> v4: >> - use "#define" to define interrupt remapping transition faults >> rather than using an enum >> - use switch-case rather than if-else in irq_remapping_request_index() >> and vvtd_irq_request_sanity_check() >> - introduce a counter inflight_intr >> >> v3: >> - Encode map_guest_page()'s error into void* to avoid using another >> parameter >> --- >> xen/drivers/passthrough/vtd/iommu.h | 15 +++ >> xen/drivers/passthrough/vtd/vvtd.c | 219 >> >> 2 files changed, 234 insertions(+) >> >> diff --git a/xen/drivers/passthrough/vtd/iommu.h >> b/xen/drivers/passthrough/vtd/iommu.h >> index 9c59aeb..82edd2a 100644 >> --- a/xen/drivers/passthrough/vtd/iommu.h >> +++ b/xen/drivers/passthrough/vtd/iommu.h >> @@ -216,6 +216,15 @@ >> #define dma_frcd_source_id(c) (c & 0x) >> #define dma_frcd_page_addr(d) (d & (((u64)-1) << 12)) /* low 64 bit */ >> >> +/* Interrupt remapping transition faults */ >> +#define VTD_FR_IR_REQ_RSVD 0x20 >> +#define VTD_FR_IR_INDEX_OVER0x21 >> +#define VTD_FR_IR_ENTRY_P 0x22 >> +#define VTD_FR_IR_ROOT_INVAL0x23 >> +#define VTD_FR_IR_IRTE_RSVD 0x24 >> +#define VTD_FR_IR_REQ_COMPAT0x25 >> +#define VTD_FR_IR_SID_ERR 0x26 >> + >> /* >> * 0: Present >> * 1-11: Reserved >> @@ -356,6 +365,12 @@ struct iremap_entry { >> }; >> >> /* >> + * When VT-d doesn't enable extended interrupt mode, hardware interprets >> + * 8-bits ([15:8]) of Destination-ID field in the IRTEs. >> + */ >> +#define IRTE_xAPIC_DEST_MASK 0xff00 >> + >> +/* >> * Posted-interrupt descriptor address is 64 bits with 64-byte aligned, only >> * the upper 26 bits of lest significiant 32 bits is available. >> */ >> diff --git a/xen/drivers/passthrough/vtd/vvtd.c >> b/xen/drivers/passthrough/vtd/vvtd.c >> index 06e522a..927e715 100644 >> --- a/xen/drivers/passthrough/vtd/vvtd.c >> +++ b/xen/drivers/passthrough/vtd/vvtd.c >> @@ -22,11 +22,15 @@ >> #include >> #include >> #include >> +#include >> #include >> +#include >> +#include >> #include >> #include >> >> #include "iommu.h" >> +#include "vtd.h" >> >> /* Supported capabilities by vvtd */ >> #define VVTD_MAX_CAPS VIOMMU_CAP_IRQ_REMAPPING >> @@ -52,6 +56,8 @@ struct vvtd { >> uint64_t base_addr; >> /* Point back to the owner domain */ >> struct domain *domain; >> +/* # of in-flight interrupts */ >> +atomic_t inflight_intr; >> >> struct hvm_hw_vvtd hw; >> void *irt_base; >> @@ -181,6 +187,109 @@ static void unmap_guest_pages(void *va, uint32_t nr) >> put_page_and_type(mfn_to_page(mfn[i])); >> } >> >> +static int vvtd_delivery(struct domain *d, uint8_t vector, >> + uint32_t dest, bool dest_mode, >> + uint8_t delivery_mode, uint8_t trig_mode) >> +{ >> +struct vlapic *target; >> +struct vcpu *v; >> + >> +switch ( delivery_mode ) >> +{ >> +case dest_LowestPrio: >> +target = vlapic_lowest_prio(d, NULL, 0, dest, dest_mode); >> +if ( target != NULL ) >> +{ >> +vvtd_debug("d%d: dest=v%d dlm=%x vector=%d trig_mode=%d\n", >> + vlapic_domain(target)->domain_id, >> + vlapic_vcpu(target)->vcpu_id, >> + delivery_mode, vector, trig_mode); >> +vlapic_set_irq(target, vector, trig_mode); >> +break; >> +} >> +vvtd_debug("d%d: null round robin: vector=%02x\n", >> + d->domain_id, vector); >> +break; >> + >> +case dest_Fixed: >> +for_each_vcpu ( d, v ) >> +if ( vlapic_match_dest(vcpu_vlapic(v), NULL, 0, dest, >> dest_mode) ) >> +{ >> +vvtd_debug("d%d: dest=v%d dlm=%x vector=%d trig_mode=%d\n", >> + v->domain->domain_id,
Re: [Xen-devel] [PATCH v4 10/28] x86/vvtd: Enable Interrupt Remapping through GCMD
On Fri, Feb 09, 2018 at 05:15:17PM +, Roger Pau Monné wrote: >On Fri, Nov 17, 2017 at 02:22:17PM +0800, Chao Gao wrote: >> Software writes this field to enable/disable interrupt reampping. This >> patch emulate IRES field of GCMD. Currently, Guest's whole IRT are >> mapped to Xen permanently for the latency of delivering interrupt. And >> the old mapping is undone if present when trying to set up a new one. >> >> Signed-off-by: Chao Gao>> Signed-off-by: Lan Tianyu >> --- >> v4: >> - map guest's interrupt reampping table to Xen permanently rather than >> mapping one specific page on demand. >> --- >> xen/drivers/passthrough/vtd/iommu.h | 3 +- >> xen/drivers/passthrough/vtd/vvtd.c | 98 >> + >> 2 files changed, 100 insertions(+), 1 deletion(-) >> >> diff --git a/xen/drivers/passthrough/vtd/iommu.h >> b/xen/drivers/passthrough/vtd/iommu.h >> index 8579843..9c59aeb 100644 >> --- a/xen/drivers/passthrough/vtd/iommu.h >> +++ b/xen/drivers/passthrough/vtd/iommu.h >> @@ -161,9 +161,10 @@ >> #define DMA_GSTS_AFLS (((u64)1) << 28) >> #define DMA_GSTS_WBFS (((u64)1) << 27) >> #define DMA_GSTS_QIES (((u64)1) <<26) >> +#define DMA_GSTS_IRES_SHIFT 25 >> +#define DMA_GSTS_IRES (((u64)1) << DMA_GSTS_IRES_SHIFT) > >We are trying to avoid more use-cases of u64. Also, didn't you clean >that file in a previous patch? Why was this not properly adjusted to >use UL or uint64_t there? Yes. I did. I will do some cleanup and put all cleanup in one patch. > >> #define DMA_GSTS_SIRTPS_SHIFT 24 >> #define DMA_GSTS_SIRTPS (((u64)1) << DMA_GSTS_SIRTPS_SHIFT) >> -#define DMA_GSTS_IRES (((u64)1) <<25) >> #define DMA_GSTS_CFIS (((u64)1) <<23) >> >> /* IRTA_REG */ >> diff --git a/xen/drivers/passthrough/vtd/vvtd.c >> b/xen/drivers/passthrough/vtd/vvtd.c >> index f0476fe..06e522a 100644 >> --- a/xen/drivers/passthrough/vtd/vvtd.c >> +++ b/xen/drivers/passthrough/vtd/vvtd.c >> @@ -24,6 +24,7 @@ >> #include >> #include >> #include >> +#include >> >> #include "iommu.h" >> >> @@ -37,6 +38,7 @@ >> >> struct hvm_hw_vvtd { >> bool eim_enabled; >> +bool intremap_enabled; >> >> /* Interrupt remapping table base gfn and the max of entries */ >> uint16_t irt_max_entry; >> @@ -52,6 +54,7 @@ struct vvtd { >> struct domain *domain; >> >> struct hvm_hw_vvtd hw; >> +void *irt_base; >> }; >> >> /* Setting viommu_verbose enables debugging messages of vIOMMU */ >> @@ -118,6 +121,77 @@ static void *domain_vvtd(const struct domain *d) >> return NULL; >> } >> >> +static void *map_guest_pages(struct domain *d, uint64_t gfn, uint32_t nr) > ^ gfn_t > >Also, this function and unmap_guest_pages look generic enough to be >placed somewhere else, like p2m.c maybe? Ok. will do. > >> +{ >> +mfn_t *mfn = xmalloc_array(mfn_t, nr); >> +void* ret; >> +int i; >> + >> +if ( !mfn ) >> +return NULL; >> + >> +for ( i = 0; i < nr; i++) >> +{ >> +struct page_info *p = get_page_from_gfn(d, gfn + i, NULL, >> P2M_ALLOC); >> + >> +if ( !p || !get_page_type(p, PGT_writable_page) ) >> +{ >> +if ( p ) >> +put_page(p); >> +goto undo; >> +} >> + >> +mfn[i] = _mfn(page_to_mfn(p)); > >Please use the type-safe version of page_to_mfn, by adding the >following at the top of the file: > >/* Override macros from asm/mm.h to make them work with mfn_t */ >#undef mfn_to_page >#define mfn_to_page(mfn) __mfn_to_page(mfn_x(mfn)) >#undef page_to_mfn >#define page_to_mfn(pg) _mfn(__page_to_mfn(pg)) > >> +} >> + >> +ret = vmap(mfn, nr); >> +if ( ret == NULL ) >> +goto undo; >> +xfree(mfn); > >You can move the xfree(mfn) before the check, and then you can remove >it from the undo label. > >And since the undo label is just used once, what about doing > >ret = vmap(mfn, nr); >xfree(mfn); >if ( !ret ) >{ >while ( i-- ) >put_page_and_type(mfn_to_page(mfn_x(mfn[i]))); > Good suggestion. > >> + >> +return ret; >> + >> + undo: >> +for ( ; --i >= 0; ) >> +put_page_and_type(mfn_to_page(mfn_x(mfn[i]))); >> +xfree(mfn); >> +gprintk(XENLOG_ERR, "Failed to map guest pages %lx nr %x\n", gfn, nr); >> + >> +return NULL; >> +} >> + >> +static void unmap_guest_pages(void *va, uint32_t nr) >unsigned long please. > >> +{ >> +unsigned long *mfn = xmalloc_array(unsigned long, nr); >> +int i; >> +void *va_copy = va; >> + >> +if ( !mfn ) >> +{ >> +printk("%s %d: No free memory\n", __FILE__, __LINE__); >> +return; >> +} >> + >> +for ( i = 0; i < nr; i++, va += PAGE_SIZE) >> +mfn[i] = domain_page_map_to_mfn(va); >> + >> +vunmap(va_copy); >> + >> +for ( i = 0; i < nr; i++) >> +put_page_and_type(mfn_to_page(mfn[i]));
[Xen-devel] [xen-4.9-testing test] 118784: tolerable FAIL - PUSHED
flight 118784 xen-4.9-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/118784/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-xsm 5 host-ping-check-native fail in 118683 pass in 118784 test-amd64-amd64-xl-qemut-win7-amd64 16 guest-localmigrate/x10 fail in 118683 pass in 118784 test-armhf-armhf-xl-credit2 12 guest-start fail in 118683 pass in 118784 test-amd64-amd64-xl-qemut-ws16-amd64 16 guest-localmigrate/x10 fail in 118683 pass in 118784 test-amd64-i386-xl-qemut-ws16-amd64 16 guest-localmigrate/x10 fail pass in 118683 Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemut-win7-amd64 17 guest-stop fail in 118683 like 118487 test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail in 118683 like 118524 test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stop fail in 118683 like 118524 test-amd64-i386-xl-qemut-ws16-amd64 17 guest-stop fail in 118683 like 118524 test-armhf-armhf-xl-rtds13 migrate-support-check fail in 118683 never pass test-armhf-armhf-xl-rtds 14 saverestore-support-check fail in 118683 never pass test-amd64-i386-xl-qemuu-win7-amd64 16 guest-localmigrate/x10 fail like 118347 test-armhf-armhf-xl-rtds 12 guest-start fail like 118416 test-amd64-amd64-xl-qemuu-ws16-amd64 16 guest-localmigrate/x10 fail like 118416 test-amd64-amd64-xl-qemuu-win7-amd64 16 guest-localmigrate/x10 fail like 118487 test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stopfail like 118524 test-amd64-i386-xl-qemut-win7-amd64 16 guest-localmigrate/x10 fail like 118524 test-amd64-amd64-xl-qemut-ws16-amd64 17 guest-stopfail like 118524 test-amd64-i386-xl-qemuu-ws16-amd64 16 guest-localmigrate/x10 fail like 118524 test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-amd64-amd64-libvirt-xsm 13 migrate-support-checkfail never pass test-amd64-i386-libvirt-xsm 13 migrate-support-checkfail never pass test-amd64-i386-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-credit2 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 13 migrate-support-checkfail never pass test-arm64-arm64-xl-credit2 14 saverestore-support-checkfail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-checkfail never pass test-arm64-arm64-libvirt-xsm 13 migrate-support-checkfail never pass test-arm64-arm64-libvirt-xsm 14 saverestore-support-checkfail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 13 migrate-support-checkfail never pass test-armhf-armhf-xl-arndale 14 saverestore-support-checkfail never pass test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2 fail never pass test-amd64-amd64-libvirt-vhd 12 migrate-support-checkfail never pass test-armhf-armhf-xl 13 migrate-support-checkfail never pass test-armhf-armhf-xl 14 saverestore-support-checkfail never pass test-armhf-armhf-xl-xsm 13 migrate-support-checkfail never pass test-armhf-armhf-xl-xsm 14 saverestore-support-checkfail never pass test-armhf-armhf-xl-cubietruck 13 migrate-support-checkfail never pass test-armhf-armhf-xl-cubietruck 14 saverestore-support-checkfail never pass test-armhf-armhf-libvirt 13 migrate-support-checkfail never pass test-armhf-armhf-libvirt-xsm 13 migrate-support-checkfail never pass test-armhf-armhf-libvirt 14 saverestore-support-checkfail never pass test-armhf-armhf-libvirt-xsm 14 saverestore-support-checkfail never pass test-armhf-armhf-xl-credit2 13 migrate-support-checkfail never pass test-armhf-armhf-xl-credit2 14 saverestore-support-checkfail never pass test-armhf-armhf-xl-multivcpu 13 migrate-support-checkfail never pass test-armhf-armhf-xl-multivcpu 14 saverestore-support-checkfail never pass test-arm64-arm64-xl 13 migrate-support-checkfail never pass test-arm64-arm64-xl 14 saverestore-support-checkfail never pass test-armhf-armhf-xl-vhd 12 migrate-support-checkfail never pass test-armhf-armhf-xl-vhd 13 saverestore-support-checkfail never pass test-armhf-armhf-libvirt-raw 12 migrate-support-checkfail never pass test-armhf-armhf-libvirt-raw 13 saverestore-support-checkfail never pass test-amd64-amd64-xl-qemut-win10-i386 10 windows-installfail never pass test-amd64-i386-xl-qemuu-win10-i386 10 windows-install fail never pass test-amd64-amd64-xl-qemuu-win10-i386 10 windows-installfail never pass test-amd64-i386-xl-qemut-win10-i386 10
Re: [Xen-devel] [PATCH v4 09/28] x86/vvtd: Set Interrupt Remapping Table Pointer through GCMD
On Fri, Feb 09, 2018 at 04:59:11PM +, Roger Pau Monné wrote: >On Fri, Nov 17, 2017 at 02:22:16PM +0800, Chao Gao wrote: >> Software sets SIRTP field of GCMD to set/update the interrupt remapping >> table pointer used by hardware. The interrupt remapping table pointer is >> specified through the Interrupt Remapping Table Address (IRTA_REG) >> register. >> >> This patch emulates this operation and adds some new fields in VVTD to track >> info (e.g. the table's gfn and max supported entries) of interrupt remapping >> table. >> >> Signed-off-by: Chao Gao>> Signed-off-by: Lan Tianyu >> >> --- >> v4: >> - declare eim_enabled as bool and irt as gfn_t >> - rename vvtd_handle_gcmd_sirtp() to write_gcmd_sirtp() >> >> v3: >> - ignore unaligned r/w of vt-d hardware registers and return X86EMUL_OK >> --- >> xen/drivers/passthrough/vtd/iommu.h | 16 ++- >> xen/drivers/passthrough/vtd/vvtd.c | 86 >> + >> 2 files changed, 100 insertions(+), 2 deletions(-) >> >> diff --git a/xen/drivers/passthrough/vtd/iommu.h >> b/xen/drivers/passthrough/vtd/iommu.h >> index f2ef3dd..8579843 100644 >> --- a/xen/drivers/passthrough/vtd/iommu.h >> +++ b/xen/drivers/passthrough/vtd/iommu.h >> @@ -48,7 +48,8 @@ >> #define DMAR_IQT_REG0x88 /* invalidation queue tail */ >> #define DMAR_IQA_REG0x90 /* invalidation queue addr */ >> #define DMAR_IECTL_REG 0xa0 /* invalidation event control register >> */ >> -#define DMAR_IRTA_REG 0xb8 /* intr remap */ >> +#define DMAR_IRTA_REG 0xb8 /* base address of intr remap table */ >> +#define DMAR_IRTUA_REG 0xbc /* upper address of intr remap table */ >> >> #define OFFSET_STRIDE(9) >> #define dmar_readl(dmar, reg) readl((dmar) + (reg)) >> @@ -150,6 +151,9 @@ >> #define DMA_GCMD_SIRTP (((u64)1) << 24) >> #define DMA_GCMD_CFI(((u64)1) << 23) >> >> +/* mask of one-shot bits */ >> +#define DMA_GCMD_ONE_SHOT_MASK 0x96ff >> + >> /* GSTS_REG */ >> #define DMA_GSTS_TES(((u64)1) << 31) >> #define DMA_GSTS_RTPS (((u64)1) << 30) >> @@ -157,10 +161,18 @@ >> #define DMA_GSTS_AFLS (((u64)1) << 28) >> #define DMA_GSTS_WBFS (((u64)1) << 27) >> #define DMA_GSTS_QIES (((u64)1) <<26) >> +#define DMA_GSTS_SIRTPS_SHIFT 24 >> +#define DMA_GSTS_SIRTPS (((u64)1) << DMA_GSTS_SIRTPS_SHIFT) >> #define DMA_GSTS_IRES (((u64)1) <<25) >> -#define DMA_GSTS_SIRTPS (((u64)1) << 24) >> #define DMA_GSTS_CFIS (((u64)1) <<23) >> >> +/* IRTA_REG */ >> +/* The base of 4KB aligned interrupt remapping table */ >> +#define DMA_IRTA_ADDR(val) ((val) & ~0xfffULL) >> +/* The size of remapping table is 2^(x+1), where x is the size field in >> IRTA */ >> +#define DMA_IRTA_S(val) (val & 0xf) >> +#define DMA_IRTA_SIZE(val) (1UL << (DMA_IRTA_S(val) + 1)) >> + >> /* PMEN_REG */ >> #define DMA_PMEN_EPM(((u32)1) << 31) >> #define DMA_PMEN_PRS(((u32)1) << 0) >> diff --git a/xen/drivers/passthrough/vtd/vvtd.c >> b/xen/drivers/passthrough/vtd/vvtd.c >> index d78d878..f0476fe 100644 >> --- a/xen/drivers/passthrough/vtd/vvtd.c >> +++ b/xen/drivers/passthrough/vtd/vvtd.c >> @@ -36,6 +36,12 @@ >> #define VVTD_MAX_OFFSET VVTD_FRCD_END >> >> struct hvm_hw_vvtd { >> +bool eim_enabled; >> + >> +/* Interrupt remapping table base gfn and the max of entries */ >> +uint16_t irt_max_entry; >> +gfn_t irt; >> + >> uint32_t regs[VVTD_MAX_OFFSET/sizeof(uint32_t)]; >> }; >> >> @@ -73,6 +79,16 @@ boolean_runtime_param("viommu_verbose", viommu_verbose); >> >> #define VVTD_REG_POS(vvtd, offset) &(vvtd->hw.regs[offset/sizeof(uint32_t)]) >> >> +static inline void vvtd_set_bit(struct vvtd *vvtd, uint32_t reg, int nr) >> +{ >> +__set_bit(nr, VVTD_REG_POS(vvtd, reg)); >> +} >> + >> +static inline void vvtd_clear_bit(struct vvtd *vvtd, uint32_t reg, int nr) >> +{ >> +__clear_bit(nr, VVTD_REG_POS(vvtd, reg)); >> +} >> + >> static inline void vvtd_set_reg(struct vvtd *vvtd, uint32_t reg, uint32_t >> value) >> { >> *VVTD_REG_POS(vvtd, reg) = value; >> @@ -102,6 +118,52 @@ static void *domain_vvtd(const struct domain *d) >> return NULL; >> } >> >> +static void write_gcmd_sirtp(struct vvtd *vvtd, uint32_t val) >> +{ >> +uint64_t irta = vvtd_get_reg_quad(vvtd, DMAR_IRTA_REG); >> + >> +if ( !(val & DMA_GCMD_SIRTP) ) > >I think you likely want to do put_gfn here (see my comment below). > >> +return; >> + >> +/* >> + * Hardware clears this bit when software sets the SIRTPS field in >> + * the Global Command register and sets it when hardware completes >> + * the 'Set Interrupt Remap Table Pointer' operation. >> + */ >> +vvtd_clear_bit(vvtd, DMAR_GSTS_REG, DMA_GSTS_SIRTPS_SHIFT); >> + >> +if ( gfn_x(vvtd->hw.irt) != PFN_DOWN(DMA_IRTA_ADDR(irta)) || >> + vvtd->hw.irt_max_entry != DMA_IRTA_SIZE(irta) ) >> +{ >> +vvtd->hw.irt =
Re: [Xen-devel] [PATCH 2/2] xen: xenbus: WARN_ON XS_TRANSACTION_{START, END} misuse
Boris Ostrovsky: > On 02/07/2018 05:22 PM, Simon Gaiser wrote: >> +users_old = xs_state_users; >> xs_state_users--; >> if ((req->type == XS_TRANSACTION_START && req->msg.type == XS_ERROR) || >> req->type == XS_TRANSACTION_END) >> xs_state_users--; >> +if (WARN_ON(xs_state_users > users_old)) > > > WARN_ON_ONCE()? Since we "fix" the wrong decrement by clamping at zero it should not happen immediately again. But if you prefer _ONCE I can change it. signature.asc Description: OpenPGP digital signature ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
[Xen-devel] [xen-4.10-testing test] 118771: tolerable FAIL - PUSHED
flight 118771 xen-4.10-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/118771/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-pvhv2-intel 12 guest-start fail never pass test-amd64-amd64-xl-pvhv2-amd 12 guest-start fail never pass test-amd64-amd64-libvirt-xsm 13 migrate-support-checkfail never pass test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-amd64-i386-libvirt-xsm 13 migrate-support-checkfail never pass test-amd64-i386-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-credit2 13 migrate-support-checkfail never pass test-arm64-arm64-xl-credit2 14 saverestore-support-checkfail never pass test-arm64-arm64-xl-xsm 13 migrate-support-checkfail never pass test-arm64-arm64-libvirt-xsm 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-checkfail never pass test-arm64-arm64-libvirt-xsm 14 saverestore-support-checkfail never pass test-arm64-arm64-xl 13 migrate-support-checkfail never pass test-arm64-arm64-xl 14 saverestore-support-checkfail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 13 migrate-support-checkfail never pass test-armhf-armhf-xl-arndale 14 saverestore-support-checkfail never pass test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2 fail never pass test-amd64-amd64-libvirt-vhd 12 migrate-support-checkfail never pass test-armhf-armhf-xl-credit2 13 migrate-support-checkfail never pass test-armhf-armhf-xl-credit2 14 saverestore-support-checkfail never pass test-armhf-armhf-xl-rtds 13 migrate-support-checkfail never pass test-armhf-armhf-xl-rtds 14 saverestore-support-checkfail never pass test-armhf-armhf-xl-cubietruck 13 migrate-support-checkfail never pass test-armhf-armhf-xl-cubietruck 14 saverestore-support-checkfail never pass test-armhf-armhf-xl 13 migrate-support-checkfail never pass test-armhf-armhf-xl 14 saverestore-support-checkfail never pass test-armhf-armhf-xl-xsm 13 migrate-support-checkfail never pass test-armhf-armhf-xl-xsm 14 saverestore-support-checkfail never pass test-armhf-armhf-libvirt-xsm 13 migrate-support-checkfail never pass test-armhf-armhf-libvirt 13 migrate-support-checkfail never pass test-armhf-armhf-libvirt-xsm 14 saverestore-support-checkfail never pass test-armhf-armhf-libvirt 14 saverestore-support-checkfail never pass test-armhf-armhf-xl-multivcpu 13 migrate-support-checkfail never pass test-armhf-armhf-xl-multivcpu 14 saverestore-support-checkfail never pass test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stop fail never pass test-amd64-i386-xl-qemut-win7-amd64 17 guest-stop fail never pass test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stop fail never pass test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stop fail never pass test-armhf-armhf-libvirt-raw 12 migrate-support-checkfail never pass test-armhf-armhf-libvirt-raw 13 saverestore-support-checkfail never pass test-armhf-armhf-xl-vhd 12 migrate-support-checkfail never pass test-armhf-armhf-xl-vhd 13 saverestore-support-checkfail never pass test-amd64-i386-xl-qemut-ws16-amd64 17 guest-stop fail never pass test-amd64-amd64-xl-qemut-ws16-amd64 17 guest-stop fail never pass test-amd64-i386-xl-qemuu-ws16-amd64 17 guest-stop fail never pass test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail never pass test-amd64-amd64-xl-qemut-win10-i386 10 windows-installfail never pass test-amd64-amd64-xl-qemuu-win10-i386 10 windows-installfail never pass test-amd64-i386-xl-qemut-win10-i386 10 windows-install fail never pass test-amd64-i386-xl-qemuu-win10-i386 10 windows-install fail never pass version targeted for testing: xen 3921128fcb3501318f5233ac32a398b1acacb2cc baseline version: xen f379b706096f1266b6239645236ca54dfa1d9daf Last test of basis 118529 2018-02-02 03:47:21 Z8 days Failing since118657 2018-02-07 16:43:11 Z3 days3 attempts Testing same since 118771 2018-02-09 16:23:21 Z1 days1 attempts People who touched revisions under test: Andrew CooperJan Beulich Julien Grall Marc Zyngier
Re: [Xen-devel] [PATCH v2 3/4] hvm/svm: Enable MSR events
(Resending too. Something was wrong with my client) On 02/10/2018 11:33 AM, Boris Ostrovsky wrote: On 02/08/2018 10:25 AM, Alexandru Isaila wrote: This commit enables MSR events for svm. Signed-off-by: Alexandru IsailaReviewed-by: Boris Ostrovsky ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
[Xen-devel] [qemu-mainline test] 118751: regressions - FAIL
flight 118751 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/118751/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit2 16 guest-start/debian.repeat fail REGR. vs. 118670 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-xsm 14 saverestore-support-checkfail like 118670 test-armhf-armhf-libvirt 14 saverestore-support-checkfail like 118670 test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stopfail like 118670 test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stop fail like 118670 test-armhf-armhf-libvirt-raw 13 saverestore-support-checkfail like 118670 test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stopfail like 118670 test-amd64-amd64-xl-pvhv2-intel 12 guest-start fail never pass test-amd64-amd64-xl-pvhv2-amd 12 guest-start fail never pass test-amd64-i386-libvirt-xsm 13 migrate-support-checkfail never pass test-amd64-i386-libvirt 13 migrate-support-checkfail never pass test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-amd64-amd64-libvirt-xsm 13 migrate-support-checkfail never pass test-arm64-arm64-xl 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 13 migrate-support-checkfail never pass test-arm64-arm64-xl 14 saverestore-support-checkfail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-checkfail never pass test-arm64-arm64-xl-credit2 13 migrate-support-checkfail never pass test-arm64-arm64-xl-credit2 14 saverestore-support-checkfail never pass test-arm64-arm64-libvirt-xsm 13 migrate-support-checkfail never pass test-arm64-arm64-libvirt-xsm 14 saverestore-support-checkfail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2 fail never pass test-amd64-amd64-libvirt-vhd 12 migrate-support-checkfail never pass test-armhf-armhf-xl-credit2 13 migrate-support-checkfail never pass test-armhf-armhf-xl-credit2 14 saverestore-support-checkfail never pass test-armhf-armhf-libvirt-xsm 13 migrate-support-checkfail never pass test-armhf-armhf-xl-xsm 13 migrate-support-checkfail never pass test-armhf-armhf-xl-multivcpu 13 migrate-support-checkfail never pass test-armhf-armhf-xl-cubietruck 13 migrate-support-checkfail never pass test-armhf-armhf-xl-multivcpu 14 saverestore-support-checkfail never pass test-armhf-armhf-xl-xsm 14 saverestore-support-checkfail never pass test-armhf-armhf-xl-cubietruck 14 saverestore-support-checkfail never pass test-armhf-armhf-libvirt 13 migrate-support-checkfail never pass test-armhf-armhf-xl-rtds 13 migrate-support-checkfail never pass test-armhf-armhf-xl-rtds 14 saverestore-support-checkfail never pass test-armhf-armhf-libvirt-raw 12 migrate-support-checkfail never pass test-armhf-armhf-xl-arndale 13 migrate-support-checkfail never pass test-armhf-armhf-xl-arndale 14 saverestore-support-checkfail never pass test-armhf-armhf-xl-vhd 12 migrate-support-checkfail never pass test-armhf-armhf-xl-vhd 13 saverestore-support-checkfail never pass test-armhf-armhf-xl 13 migrate-support-checkfail never pass test-armhf-armhf-xl 14 saverestore-support-checkfail never pass test-amd64-i386-xl-qemuu-ws16-amd64 17 guest-stop fail never pass test-amd64-amd64-xl-qemuu-win10-i386 10 windows-installfail never pass test-amd64-i386-xl-qemuu-win10-i386 10 windows-install fail never pass version targeted for testing: qemuu04bb7fe2bf55bdf66d5b7a5a719b40bbb4048178 baseline version: qemuu7b213bb4755dc99e447c19c532768ef5105b9771 Last test of basis 118670 2018-02-08 07:29:43 Z2 days Testing same since 118751 2018-02-09 10:36:09 Z1 days1 attempts People who touched revisions under test: Anton NefedovFam Zheng John Snow Liang Li Paolo Bonzini Peter Maydell Richard Henderson Weiping Zhang jobs: build-amd64-xsm pass build-arm64-xsm pass build-armhf-xsm pass
Re: [Xen-devel] [PATCH 2/2] xen: xenbus: WARN_ON XS_TRANSACTION_{START, END} misuse
On 02/07/2018 05:22 PM, Simon Gaiser wrote: As the previous commit shows it's quite easy to confuse the transaction reference counting by ending a transaction twice. So at least try to detect and report it. Signed-off-by: Simon Gaiser--- drivers/xen/xenbus/xenbus_xs.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/xen/xenbus/xenbus_xs.c b/drivers/xen/xenbus/xenbus_xs.c index 3e59590c7254..aed954b09b9b 100644 --- a/drivers/xen/xenbus/xenbus_xs.c +++ b/drivers/xen/xenbus/xenbus_xs.c @@ -137,11 +137,20 @@ static uint32_t xs_request_enter(struct xb_req_data *req) void xs_request_exit(struct xb_req_data *req) { + unsigned int users_old; + spin_lock(_state_lock); + users_old = xs_state_users; xs_state_users--; if ((req->type == XS_TRANSACTION_START && req->msg.type == XS_ERROR) || req->type == XS_TRANSACTION_END) xs_state_users--; + if (WARN_ON(xs_state_users > users_old)) WARN_ON_ONCE()? -boris + /* +* Someone misused XS_TRANSACTION_{START,END}. Reset the +* reference counter so we might survive. +*/ + xs_state_users = 0; spin_unlock(_state_lock); if (xs_suspend_active && !xs_state_users) ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] [PATCH 1/2] xen: xenbus_dev_frontend: Fix XS_TRANSACTION_END handling
On 02/07/2018 05:22 PM, Simon Gaiser wrote: Commit fd8aa9095a95 ("xen: optimize xenbus driver for multiple concurrent xenstore accesses") made a subtle change to the semantic of xenbus_dev_request_and_reply() and xenbus_transaction_end(). Before on an error response to XS_TRANSACTION_END xenbus_dev_request_and_reply() would not decrement the active transaction counter. But xenbus_transaction_end() has always counted the transaction as finished regardless of the response. The new behavior is that xenbus_dev_request_and_reply() and xenbus_transaction_end() will always count the transaction as finished regardless the response code (handled in xs_request_exit()). But xenbus_dev_frontend tries to end a transaction on closing of the device if the XS_TRANSACTION_END failed before. Trying to close the transaction twice corrupts the reference count. So fix this by also considering a transaction closed if we have sent XS_TRANSACTION_END once regardless of the return code. Cc:# 4.11 Fixes: fd8aa9095a95 ("xen: optimize xenbus driver for multiple concurrent xenstore accesses") Signed-off-by: Simon Gaiser Reviewed-by: Boris Ostrovsky (although I'd prefer Juergen to also take a look at this) --- drivers/xen/xenbus/xenbus_dev_frontend.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/xen/xenbus/xenbus_dev_frontend.c b/drivers/xen/xenbus/xenbus_dev_frontend.c index f3b089b7c0b6..d2edbc79384a 100644 --- a/drivers/xen/xenbus/xenbus_dev_frontend.c +++ b/drivers/xen/xenbus/xenbus_dev_frontend.c @@ -365,7 +365,7 @@ void xenbus_dev_queue_reply(struct xb_req_data *req) if (WARN_ON(rc)) goto out; } - } else if (req->msg.type == XS_TRANSACTION_END) { + } else if (req->type == XS_TRANSACTION_END) { trans = xenbus_get_transaction(u, req->msg.tx_id); if (WARN_ON(!trans)) goto out; ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] [PATCH v2 2/4] hvm/svm: Enable Breakpoint events
On 02/08/2018 10:25 AM, Alexandru Isaila wrote: + + rc = hvm_monitor_debug(regs->rip, + HVM_MONITOR_SOFTWARE_BREAKPOINT, + X86_EVENTTYPE_SW_EXCEPTION, + inst_len); + if ( rc < 0 ) + goto unexpected_exit_type; + if ( !rc ) + svm_propagate_intr(v, inst_len); There is a comment in vmx_vmexit_handler() where this call is made a couple of times that explains hvm_moonitor_debug()'s return values. Can you move that comment to hvm_monitor_debug() definition so people can look there to understand how to deal with return values instead of searching for call sites? -boris ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
[Xen-devel] [linux-next test] 118748: regressions - trouble: broken/fail/pass
flight 118748 linux-next real [real] http://logs.test-lab.xenproject.org/osstest/logs/118748/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-freebsd10-amd64 broken test-amd64-i386-freebsd10-amd64 4 host-install(4) broken REGR. vs. 118638 test-armhf-armhf-libvirt 10 debian-install fail REGR. vs. 118638 test-armhf-armhf-xl-multivcpu 10 debian-install fail REGR. vs. 118638 test-armhf-armhf-xl-xsm 10 debian-install fail REGR. vs. 118638 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-pvhv2-amd 12 guest-startfail blocked in 118638 test-amd64-amd64-xl-pvhv2-intel 12 guest-start fail blocked in 118638 test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stop fail blocked in 118638 test-armhf-armhf-libvirt-xsm 14 saverestore-support-check fail blocked in 118638 test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail blocked in 118638 test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stop fail blocked in 118638 test-amd64-amd64-xl-qemut-ws16-amd64 17 guest-stop fail blocked in 118638 test-amd64-i386-examine 8 reboot fail like 118638 test-amd64-i386-xl-qemuu-win10-i386 7 xen-boot fail like 118638 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-boot fail like 118638 test-amd64-i386-pair 10 xen-boot/src_hostfail like 118638 test-amd64-i386-pair 11 xen-boot/dst_hostfail like 118638 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-boot fail like 118638 test-amd64-i386-xl7 xen-boot fail like 118638 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-boot fail like 118638 test-amd64-i386-rumprun-i386 7 xen-boot fail like 118638 test-amd64-i386-xl-qemut-win10-i386 7 xen-boot fail like 118638 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-boot fail like 118638 test-amd64-i386-libvirt-xsm 7 xen-boot fail like 118638 test-amd64-i386-libvirt-pair 10 xen-boot/src_hostfail like 118638 test-amd64-i386-libvirt-pair 11 xen-boot/dst_hostfail like 118638 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-boot fail like 118638 test-amd64-i386-xl-qemut-debianhvm-amd64-xsm 7 xen-boot fail like 118638 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-boot fail like 118638 test-amd64-i386-xl-xsm7 xen-boot fail like 118638 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-boot fail like 118638 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-bootfail like 118638 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-boot fail like 118638 test-amd64-i386-xl-raw7 xen-boot fail like 118638 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-boot fail like 118638 test-amd64-i386-libvirt 7 xen-boot fail like 118638 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-boot fail like 118638 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-bootfail like 118638 test-amd64-i386-xl-qemuu-debianhvm-amd64-xsm 7 xen-boot fail like 118638 test-amd64-i386-xl-qemut-win7-amd64 7 xen-boot fail like 118638 test-amd64-i386-freebsd10-i386 7 xen-bootfail like 118638 test-armhf-armhf-libvirt-raw 13 saverestore-support-checkfail like 118638 test-amd64-amd64-libvirt-xsm 13 migrate-support-checkfail never pass test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-checkfail never pass test-arm64-arm64-xl 13 migrate-support-checkfail never pass test-arm64-arm64-xl 14 saverestore-support-checkfail never pass test-arm64-arm64-libvirt-xsm 13 migrate-support-checkfail never pass test-arm64-arm64-libvirt-xsm 14 saverestore-support-checkfail never pass test-arm64-arm64-xl-credit2 13 migrate-support-checkfail never pass test-arm64-arm64-xl-credit2 14 saverestore-support-checkfail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 13 migrate-support-checkfail never pass test-armhf-armhf-xl-arndale 14 saverestore-support-checkfail never pass test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2 fail never pass test-amd64-amd64-libvirt-vhd 12 migrate-support-checkfail never pass test-armhf-armhf-xl 13 migrate-support-checkfail never pass test-armhf-armhf-xl 14 saverestore-support-checkfail never pass
[Xen-devel] [seabios test] 118737: regressions - FAIL
flight 118737 seabios real [real] http://logs.test-lab.xenproject.org/osstest/logs/118737/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail REGR. vs. 115539 Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-ws16-amd64 10 windows-install fail pass in 118668 Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-ws16-amd64 17 guest-stop fail in 118668 like 115539 test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stop fail like 115539 test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stopfail like 115539 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2 fail never pass test-amd64-amd64-xl-qemuu-win10-i386 10 windows-installfail never pass test-amd64-i386-xl-qemuu-win10-i386 10 windows-install fail never pass version targeted for testing: seabios 4a6dbcea3e412fe12effa2f812f50dd7eae90955 baseline version: seabios 0ca6d6277dfafc671a5b3718cbeb5c78e2a888ea Last test of basis 115539 2017-11-03 20:48:58 Z 98 days Failing since115733 2017-11-10 17:19:59 Z 91 days 114 attempts Testing same since 118668 2018-02-08 04:50:43 Z2 days2 attempts People who touched revisions under test: Kevin O'ConnorMarcel Apfelbaum Michael S. Tsirkin Nikolay Nikolov Paul Menzel Stefan Berger jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvopspass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsmpass test-amd64-amd64-xl-qemuu-debianhvm-amd64-xsmpass test-amd64-i386-xl-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-qemuu-nested-amdfail test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-qemuu-win10-i386 fail test-amd64-i386-xl-qemuu-win10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. commit 4a6dbcea3e412fe12effa2f812f50dd7eae90955 Author: Nikolay Nikolov Date: Sun Feb 4 17:27:01 2018 +0200 floppy: Use timer_check() in floppy_wait_irq() Use timer_check() instead of using floppy_motor_counter in BDA for the timeout check in floppy_wait_irq(). The problem with using floppy_motor_counter was that, after it reaches 0, it immediately stops the floppy motors, which is not what is supposed to happen on real hardware. Instead, after a timeout (like in the end of every floppy operation, regardless of the result - success, timeout or error), the floppy motors must be kept spinning for additional 2 seconds (the FLOPPY_MOTOR_TICKS). So, now the floppy_motor_counter is
[Xen-devel] [linux-3.18 test] 118730: tolerable FAIL - PUSHED
flight 118730 linux-3.18 real [real] http://logs.test-lab.xenproject.org/osstest/logs/118730/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-libvirt-raw 9 leak-check/basis(9) fail in 118666 pass in 118730 test-amd64-amd64-rumprun-amd64 17 rumprun-demo-xenstorels/xenstorels.repeat fail pass in 118666 test-amd64-i386-xl-qemuu-ovmf-amd64 16 guest-localmigrate/x10 fail pass in 118666 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 16 guest-localmigrate/x10 fail pass in 118666 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-examine 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 14 saverestore-support-checkfail like 118488 test-armhf-armhf-libvirt-xsm 14 saverestore-support-checkfail like 118488 test-armhf-armhf-libvirt-raw 13 saverestore-support-checkfail like 118488 test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stopfail like 118488 test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stop fail like 118488 test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stopfail like 118488 test-amd64-i386-xl-qemut-win7-amd64 17 guest-stop fail like 118488 test-amd64-amd64-xl-pvhv2-intel 12 guest-start fail never pass test-amd64-amd64-xl-pvhv2-amd 12 guest-start fail never pass test-amd64-i386-libvirt 13 migrate-support-checkfail never pass test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-amd64-amd64-libvirt-xsm 13 migrate-support-checkfail never pass test-amd64-i386-libvirt-xsm 13 migrate-support-checkfail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 13 migrate-support-checkfail never pass test-armhf-armhf-xl-arndale 14 saverestore-support-checkfail never pass test-armhf-armhf-libvirt 13 migrate-support-checkfail never pass test-armhf-armhf-xl-rtds 13 migrate-support-checkfail never pass test-armhf-armhf-xl-rtds 14 saverestore-support-checkfail never pass test-amd64-amd64-libvirt-vhd 12 migrate-support-checkfail never pass test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2 fail never pass test-armhf-armhf-xl-multivcpu 13 migrate-support-checkfail never pass test-armhf-armhf-xl-multivcpu 14 saverestore-support-checkfail never pass test-armhf-armhf-xl-cubietruck 13 migrate-support-checkfail never pass test-armhf-armhf-xl-cubietruck 14 saverestore-support-checkfail never pass test-armhf-armhf-xl-xsm 13 migrate-support-checkfail never pass test-armhf-armhf-xl-xsm 14 saverestore-support-checkfail never pass test-armhf-armhf-libvirt-xsm 13 migrate-support-checkfail never pass test-armhf-armhf-libvirt-raw 12 migrate-support-checkfail never pass build-arm64-pvops 6 kernel-build fail never pass test-armhf-armhf-xl 13 migrate-support-checkfail never pass test-armhf-armhf-xl 14 saverestore-support-checkfail never pass test-amd64-i386-xl-qemut-ws16-amd64 17 guest-stop fail never pass test-armhf-armhf-xl-vhd 12 migrate-support-checkfail never pass test-armhf-armhf-xl-vhd 13 saverestore-support-checkfail never pass test-armhf-armhf-xl-credit2 13 migrate-support-checkfail never pass test-armhf-armhf-xl-credit2 14 saverestore-support-checkfail never pass test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail never pass test-amd64-i386-xl-qemuu-ws16-amd64 17 guest-stop fail never pass test-amd64-amd64-xl-qemut-ws16-amd64 17 guest-stop fail never pass test-amd64-i386-xl-qemuu-win10-i386 10 windows-install fail never pass test-amd64-i386-xl-qemut-win10-i386 10 windows-install fail never pass test-amd64-amd64-xl-qemuu-win10-i386 10 windows-installfail never pass test-amd64-amd64-xl-qemut-win10-i386 10 windows-installfail never pass version targeted for testing: linuxcde3537bd1098cd4df322c397ef016015890913c baseline version: linux90aaf2f25609f99b63fcbed280716f80b4bc5f56 Last test of basis 118488 2018-01-31 14:16:23 Z9 days Testing same since 118666 2018-02-07 21:47:22 Z2 days2 attempts People who touched
[Xen-devel] [libvirt test] 118735: tolerable all pass - PUSHED
flight 118735 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/118735/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 14 saverestore-support-checkfail like 118667 test-armhf-armhf-libvirt-xsm 14 saverestore-support-checkfail like 118667 test-armhf-armhf-libvirt-raw 13 saverestore-support-checkfail like 118667 test-amd64-amd64-libvirt-xsm 13 migrate-support-checkfail never pass test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-amd64-i386-libvirt-xsm 13 migrate-support-checkfail never pass test-amd64-i386-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-libvirt 14 saverestore-support-checkfail never pass test-arm64-arm64-libvirt-xsm 13 migrate-support-checkfail never pass test-arm64-arm64-libvirt-xsm 14 saverestore-support-checkfail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 12 migrate-support-checkfail never pass test-arm64-arm64-libvirt-qcow2 13 saverestore-support-checkfail never pass test-amd64-amd64-libvirt-vhd 12 migrate-support-checkfail never pass test-armhf-armhf-libvirt 13 migrate-support-checkfail never pass test-armhf-armhf-libvirt-xsm 13 migrate-support-checkfail never pass test-armhf-armhf-libvirt-raw 12 migrate-support-checkfail never pass version targeted for testing: libvirt d0a60771abf16f285ae19bf0397dece7f9fd70fa baseline version: libvirt 6ce3acc129bfdbe7fd02bcb8bbe8af6d13903684 Last test of basis 118667 2018-02-08 04:30:22 Z2 days Testing same since 118735 2018-02-09 06:04:56 Z1 days1 attempts People who touched revisions under test: Christian EhrhardtTiago M. Vieira jobs: build-amd64-xsm pass build-arm64-xsm pass build-armhf-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvopspass build-arm64-pvopspass build-armhf-pvopspass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsmpass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-armhf-armhf-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pairpass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at