Re: [Xen-devel] [PATCH] x86/alt: Fix wrong usage of as_max in OLDINSTR_2

2018-03-27 Thread Jan Beulich
>>> Zhenzhong Duan 03/28/18 4:03 AM >>> >When ALTERNATIVE_2 is used, we see below error during build. >"error: macro "as_max" requires 2 arguments, but only 1 given" > >Signed-off-by: Zhenzhong Duan See "[PATCH v2 2/6] x86: fix OLDINSTR_2()"

Re: [Xen-devel] [PATCH v2 02/17] arm64: vgic-v3: Add ICV_BPR1_EL1 handler

2018-03-27 Thread Manish Jaggi
On 03/27/2018 05:08 PM, Marc Zyngier wrote: On 27/03/18 12:27, Manish Jaggi wrote: On 03/27/2018 04:55 PM, Marc Zyngier wrote: On 27/03/18 12:15, Manish Jaggi wrote: On 03/27/2018 04:41 PM, Marc Zyngier wrote: On 27/03/18 12:07, Manish Jaggi wrote: On 03/27/2018 04:35 PM, Marc Zyngier

Re: [Xen-devel] [PATCH v2 01/17] arm: Placeholder for handling Group0/1 traps

2018-03-27 Thread Manish Jaggi
On 03/28/2018 06:18 AM, Julien Grall wrote: Hi, Sorry for the formatting. On Wed, 28 Mar 2018, 04:18 Stefano Stabellini, > wrote: On Tue, 27 Mar 2018, Marc Zyngier wrote: > On 27/03/18 11:10, Manish Jaggi wrote: > > >

[Xen-devel] [linux-3.18 test] 121303: regressions - FAIL

2018-03-27 Thread osstest service owner
flight 121303 linux-3.18 real [real] http://logs.test-lab.xenproject.org/osstest/logs/121303/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt broken in 121268 build-armhf-libvirt 6

[Xen-devel] [PATCH] x86/alt: Fix wrong usage of as_max in OLDINSTR_2

2018-03-27 Thread Zhenzhong Duan
When ALTERNATIVE_2 is used, we see below error during build. "error: macro "as_max" requires 2 arguments, but only 1 given" Signed-off-by: Zhenzhong Duan --- xen/include/asm-x86/alternative.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git

[Xen-devel] [xen-unstable-smoke test] 121319: tolerable all pass - PUSHED

2018-03-27 Thread osstest service owner
flight 121319 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/121319/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [Xen-devel] [PATCH v2 01/17] arm: Placeholder for handling Group0/1 traps

2018-03-27 Thread Julien Grall
Hi, Sorry for the formatting. On Wed, 28 Mar 2018, 04:18 Stefano Stabellini, wrote: > On Tue, 27 Mar 2018, Marc Zyngier wrote: > > On 27/03/18 11:10, Manish Jaggi wrote: > > > > > > > > > On 03/27/2018 03:31 PM, Marc Zyngier wrote: > > >> On 27/03/18 10:07, Manish Jaggi

[Xen-devel] [seabios test] 121294: regressions - FAIL

2018-03-27 Thread osstest service owner
flight 121294 seabios real [real] http://logs.test-lab.xenproject.org/osstest/logs/121294/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail REGR. vs. 115539 Tests which did not

Re: [Xen-devel] [PATCH v3 36/39] ARM: new VGIC: vgic-init: implement vgic_init

2018-03-27 Thread Stefano Stabellini
On Tue, 27 Mar 2018, Stefano Stabellini wrote: > > +static void vgic_vcpu_early_init(struct vcpu *vcpu) > > +{ > > +struct vgic_cpu *vgic_cpu = >arch.vgic; > > +unsigned int i; > > + > > +INIT_LIST_HEAD(_cpu->ap_list_head); > > +spin_lock_init(_cpu->ap_list_lock); > > + > > +/*

Re: [Xen-devel] [PATCH v3 06/39] ARM: evtchn: Handle level triggered IRQs correctly

2018-03-27 Thread Stefano Stabellini
On Wed, 21 Mar 2018, Andre Przywara wrote: > The event channel IRQ has level triggered semantics, however the current > VGIC treats everything as edge triggered. > To correctly process those IRQs, we have to lower the (virtual) IRQ line > at some point in time, depending on whether ther interrupt

Re: [Xen-devel] [PATCH 1/1] xen-netback: process malformed sk_buff correctly to avoid BUG_ON()

2018-03-27 Thread Dongli Zhang
Below is the sample kernel module used to reproduce the issue on purpose with "vif1.0" hard coded: #include #include #include #include #include static int __init test_skb_init(void) { struct sk_buff *skb; struct skb_shared_info *si; struct net_device *dev;

[Xen-devel] [PATCH 1/1] xen-netback: process malformed sk_buff correctly to avoid BUG_ON()

2018-03-27 Thread Dongli Zhang
The "BUG_ON(!frag_iter)" in function xenvif_rx_next_chunk() is triggered if the received sk_buff is malformed, that is, when the sk_buff has pattern (skb->data_len && !skb_shinfo(skb)->nr_frags). Below is a sample call stack: [ 438.652658] [ cut here ] [ 438.652660]

Re: [Xen-devel] Request for Xen SeaBIOS git head / branch to follow or include Xen staging tag

2018-03-27 Thread John Thomson
Thanks Wei, On Wed, 28 Mar 2018, at 02:16, Wei Liu wrote: > cron job to push all branches and tags from upstream to our repository > now it has become a full mirror of the upstream one. That works for me. > What do you expect from that repository? I was mainly looking for a branch that was not

Re: [Xen-devel] [PATCH v3 36/39] ARM: new VGIC: vgic-init: implement vgic_init

2018-03-27 Thread Stefano Stabellini
On Wed, 21 Mar 2018, Andre Przywara wrote: > This patch allocates and initializes the data structures used to model > the vgic distributor and virtual cpu interfaces. At that stage the > number of IRQs and number of virtual CPUs is frozen. > Implement the various functions that the Xen arch code

Re: [Xen-devel] [PATCH v3 37/39] ARM: new VGIC: vgic-init: implement map_resources

2018-03-27 Thread Stefano Stabellini
On Wed, 21 Mar 2018, Andre Przywara wrote: > map_resources is the last initialization step needed before the first > VCPU is run. At that stage the code stores the MMIO base addresses used. > Also it registers the respective register frames with the MMIO framework. > > This is based on Linux

Re: [Xen-devel] [PATCH v3 38/39] ARM: new VGIC: Allocate two pages for struct vcpu

2018-03-27 Thread Stefano Stabellini
On Thu, 22 Mar 2018, Julien Grall wrote: > Hi Andre, > > On 03/21/2018 04:32 PM, Andre Przywara wrote: > > At the moment we allocate exactly one page for struct vcpu on ARM, also > > have a check in place to prevent it growing beyond 4KB. > > As the struct includes the state of all 32 private

Re: [Xen-devel] [PATCH v3a 39/39] ARM: VGIC: wire new VGIC(-v2) files into Xen build system

2018-03-27 Thread Stefano Stabellini
On Thu, 22 Mar 2018, Andre Przywara wrote: > Now that we have both the old VGIC prepared to cope with a sibling and > the code for the new VGIC in place, lets add a Kconfig option to enable > the new code and wire it into the Xen build system. > This will add a compile time option to use either

Re: [Xen-devel] [PATCH v3 35/39] ARM: new VGIC: Add vgic_v2_enable

2018-03-27 Thread Stefano Stabellini
On Wed, 21 Mar 2018, Andre Przywara wrote: > Enable the VGIC operation by properly initialising the registers > in the hypervisor GIC interface. > > This is based on Linux commit f7b6985cc3d0, written by Eric Auger. > > Signed-off-by: Andre Przywara > Acked-by: Julien

Re: [Xen-devel] [PATCH v3 34/39] ARM: new VGIC: vgic-init: register VGIC

2018-03-27 Thread Stefano Stabellini
On Thu, 22 Mar 2018, Julien Grall wrote: > Hi Andre, > > On 03/21/2018 04:32 PM, Andre Przywara wrote: > > This patch implements the function which is called by Xen when it wants > > to register the virtual GIC. > > This also implements vgic_max_vcpus() for the new VGIC, which reports > > back

Re: [Xen-devel] [PATCH v3 33/39] ARM: new VGIC: Add preliminary stub implementation

2018-03-27 Thread Stefano Stabellini
On Wed, 21 Mar 2018, Andre Przywara wrote: > The ARM arch code requires an interrupt controller emulation to implement > vgic_clear_pending_irqs(), although it is suspected that it is actually > not necessary. Go with a stub for now to make the linker happy. > > Signed-off-by: Andre Przywara

Re: [Xen-devel] [PATCH v3 31/39] ARM: new VGIC: Provide system register emulation stub

2018-03-27 Thread Stefano Stabellini
On Wed, 21 Mar 2018, Andre Przywara wrote: > The Xen arch code traps system registers writes from the guest and will > relay anything GIC related to the VGIC. > Since this affects only GICv3 (which we don't yet emulate), provide a > stub implementation of vgic_emulate() for now. > >

Re: [Xen-devel] [PATCH v3 30/39] ARM: new VGIC: Dump virtual IRQ info

2018-03-27 Thread Stefano Stabellini
On Wed, 21 Mar 2018, Andre Przywara wrote: > When we dump guest state on the Xen console, we also print the state of > IRQs that are on a VCPU. > Add the code to dump the state of an IRQ handled by the new VGIC. > > Signed-off-by: Andre Przywara > Acked-by: Julien

Re: [Xen-devel] [PATCH v3a 14/39] ARM: new VGIC: Add GICv2 world switch backend

2018-03-27 Thread André Przywara
On 27/03/18 20:41, Stefano Stabellini wrote: > On Tue, 27 Mar 2018, Andre Przywara wrote: >> Hi, >> >> On 27/03/18 00:22, Stefano Stabellini wrote: >>> On Thu, 22 Mar 2018, Andre Przywara wrote: Processing maintenance interrupts and accessing the list registers are dependent on the

Re: [Xen-devel] [PATCH v3 29/39] ARM: new VGIC: Handle virtual IRQ allocation/reservation

2018-03-27 Thread Stefano Stabellini
On Wed, 21 Mar 2018, Andre Przywara wrote: > To find an unused virtual IRQ number Xen uses a scheme to track used > virtual IRQs. > Implement this interface in the new VGIC to make the Xen core/arch code > happy. > This is actually somewhat VGIC agnostic, so is mostly a copy of the code > from the

Re: [Xen-devel] [PATCH v3 27/39] ARM: new VGIC: Handle hardware mapped IRQs

2018-03-27 Thread Stefano Stabellini
On Wed, 21 Mar 2018, Andre Przywara wrote: > The VGIC supports virtual IRQs to be connected to a hardware IRQ, so > when a guest EOIs the virtual interrupt, it affects the state of that > corresponding interrupt on the hardware side at the same time. > Implement the interface that the Xen

Re: [Xen-devel] [PATCH v3 26/39] ARM: new VGIC: Add SGIPENDR register handlers

2018-03-27 Thread Stefano Stabellini
On Wed, 21 Mar 2018, Andre Przywara wrote: > As this register is v2 specific, its implementation lives entirely > in vgic-mmio-v2.c. > This register allows setting the source mask of an IPI. > > This is based on Linux commit ed40213ef9b0, written by Andre Przywara. > > Signed-off-by: Andre

Re: [Xen-devel] [PATCH v3 25/39] ARM: new VGIC: Add SGIR register handler

2018-03-27 Thread Stefano Stabellini
On Wed, 21 Mar 2018, Andre Przywara wrote: > Triggering an IPI via this register is v2 specific, so the > implementation lives entirely in vgic-mmio-v2.c. > > This is based on Linux commit 55cc01fb9004, written by Andre Przywara. > > Signed-off-by: Andre Przywara

Re: [Xen-devel] [PATCH v3 13/39] ARM: new VGIC: Add IRQ sync/flush framework

2018-03-27 Thread André Przywara
On 27/03/18 20:20, Stefano Stabellini wrote: > On Tue, 27 Mar 2018, Stefano Stabellini wrote: >> On Tue, 27 Mar 2018, Andre Przywara wrote: >>> Hi, >>> >>> On 26/03/18 22:30, Stefano Stabellini wrote: On Wed, 21 Mar 2018, Andre Przywara wrote: > Implement the framework for syncing IRQs

[Xen-devel] [xen-unstable-smoke test] 121317: tolerable all pass - PUSHED

2018-03-27 Thread osstest service owner
flight 121317 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/121317/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

[Xen-devel] [xen-4.8-testing test] 121291: regressions - FAIL

2018-03-27 Thread osstest service owner
flight 121291 xen-4.8-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/121291/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-pairbroken in 121083 test-xtf-amd64-amd64-5 50

Re: [Xen-devel] [PATCH v3 23/39] ARM: new VGIC: Add CONFIG registers handlers

2018-03-27 Thread Stefano Stabellini
On Wed, 21 Mar 2018, Andre Przywara wrote: > The config register handlers are shared between the v2 and v3 emulation, > so their implementation goes into vgic-mmio.c, to be easily referenced > from the v3 emulation as well later. > > This is based on Linux commit 79717e4ac09c, written by Andre

Re: [Xen-devel] [PATCH v3 21/39] ARM: new VGIC: Add ACTIVE registers handlers

2018-03-27 Thread Stefano Stabellini
On Wed, 21 Mar 2018, Andre Przywara wrote: > The active register handlers are shared between the v2 and v3 emulation, > so their implementation goes into vgic-mmio.c, to be easily referenced > from the v3 emulation as well later. > Since activation/deactivation of an interrupt may happen entirely

Re: [Xen-devel] [PATCH v3 20/39] ARM: new VGIC: Add PENDING registers handlers

2018-03-27 Thread Stefano Stabellini
On Wed, 21 Mar 2018, Andre Przywara wrote: > The pending register handlers are shared between the v2 and v3 > emulation, so their implementation goes into vgic-mmio.c, to be easily > referenced from the v3 emulation as well later. > For level triggered interrupts the real line level is unaffected

Re: [Xen-devel] [PATCH v3 18/39] ARM: new VGIC: Add CTLR, TYPER and IIDR handlers

2018-03-27 Thread Stefano Stabellini
On Wed, 21 Mar 2018, Andre Przywara wrote: > Those three registers are v2 emulation specific, so their implementation > lives entirely in vgic-mmio-v2.c. Also they are handled in one function, > as their implementation is pretty simple. > We choose to piggy-back on the existing KVM identification

Re: [Xen-devel] [PATCH v3 17/39] ARM: new VGIC: Add GICv2 MMIO handling framework

2018-03-27 Thread Stefano Stabellini
On Wed, 21 Mar 2018, Andre Przywara wrote: > Create vgic-mmio-v2.c to describe GICv2 emulation specific handlers > using the initializer macros provided by the VGIC MMIO framework. > Provide a function to register the GICv2 distributor registers to > the Xen MMIO framework. > The actual handler

Re: [Xen-devel] [PATCH v2 01/17] arm: Placeholder for handling Group0/1 traps

2018-03-27 Thread Stefano Stabellini
On Tue, 27 Mar 2018, Marc Zyngier wrote: > On 27/03/18 11:10, Manish Jaggi wrote: > > > > > > On 03/27/2018 03:31 PM, Marc Zyngier wrote: > >> On 27/03/18 10:07, Manish Jaggi wrote: > >>> The errata will require to emulate the GIC virtual CPU interface in Xen. > >>> Because the hypervisor will

Re: [Xen-devel] [PATCH v3 16/39] ARM: new VGIC: Add MMIO handling framework

2018-03-27 Thread Stefano Stabellini
On Wed, 21 Mar 2018, Andre Przywara wrote: > Add an MMIO handling framework to the VGIC emulation: > Each register is described by its offset, size (or number of bits per > IRQ, if applicable) and the read/write handler functions. We provide > initialization macros to describe each GIC register

Re: [Xen-devel] [PATCH v3a 14/39] ARM: new VGIC: Add GICv2 world switch backend

2018-03-27 Thread Stefano Stabellini
On Tue, 27 Mar 2018, Andre Przywara wrote: > Hi, > > On 27/03/18 00:22, Stefano Stabellini wrote: > > On Thu, 22 Mar 2018, Andre Przywara wrote: > >> Processing maintenance interrupts and accessing the list registers > >> are dependent on the host's GIC version. > >> Introduce vgic-v2.c to

Re: [Xen-devel] [PATCH v3 13/39] ARM: new VGIC: Add IRQ sync/flush framework

2018-03-27 Thread Stefano Stabellini
On Tue, 27 Mar 2018, Stefano Stabellini wrote: > On Tue, 27 Mar 2018, Andre Przywara wrote: > > Hi, > > > > On 26/03/18 22:30, Stefano Stabellini wrote: > > > On Wed, 21 Mar 2018, Andre Przywara wrote: > > >> Implement the framework for syncing IRQs between our emulation and the > > >> list

Re: [Xen-devel] [PATCH v3 13/39] ARM: new VGIC: Add IRQ sync/flush framework

2018-03-27 Thread Stefano Stabellini
On Tue, 27 Mar 2018, Andre Przywara wrote: > Hi, > > On 26/03/18 22:30, Stefano Stabellini wrote: > > On Wed, 21 Mar 2018, Andre Przywara wrote: > >> Implement the framework for syncing IRQs between our emulation and the > >> list registers, which represent the guest's view of IRQs. > >> This is

[Xen-devel] [PATCH] Config.mk: remove CONFIG_TESTS

2018-03-27 Thread Wei Liu
It only controls whether two "tests" directories are built or not, but doesn't actually run any test. Remove it and always build the tests. Signed-off-by: Wei Liu --- Config.mk| 5 - tools/Makefile | 2 +- tools/ocaml/Makefile | 3 --- 3 files

[Xen-devel] [xen-unstable-smoke test] 121316: tolerable all pass - PUSHED

2018-03-27 Thread osstest service owner
flight 121316 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/121316/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [Xen-devel] [PATCH v3 05/39] ARM: timer: Handle level triggered IRQs correctly

2018-03-27 Thread Stefano Stabellini
On Tue, 27 Mar 2018, Andre Przywara wrote: > Hi, > > On 26/03/18 21:28, Stefano Stabellini wrote: > > On Wed, 21 Mar 2018, Andre Przywara wrote: > >> The ARM Generic Timer uses a level-sensitive interrupt semantic. We > >> easily catch when the line goes high, as this triggers the hardware IRQ. >

[Xen-devel] [linux-next test] 121290: regressions - FAIL

2018-03-27 Thread osstest service owner
flight 121290 linux-next real [real] http://logs.test-lab.xenproject.org/osstest/logs/121290/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-examine 8 reboot fail REGR. vs. 121012

Re: [Xen-devel] [RFC 4/4] HACK libxl_exec: Check QEMU status via QMP instead of xenstore

2018-03-27 Thread Anthony PERARD
On Tue, Mar 27, 2018 at 03:48:29PM +0100, Ian Jackson wrote: > Anthony PERARD writes ("Re: [Xen-devel] [RFC 4/4] HACK libxl_exec: Check QEMU > status via QMP instead of xenstore"): > > On Tue, Mar 27, 2018 at 02:43:22PM +0100, Ian Jackson wrote: > > > Right, but doesn't one still have to poll on

Re: [Xen-devel] [PATCH v2] SUPPORT.md: add PVH Dom0 status

2018-03-27 Thread George Dunlap
On 03/23/2018 12:08 PM, Roger Pau Monne wrote: > Also fix x86/HVM to spell out that only DomU HVM mode is supported and > remove the 'guest' from the ARM section, ARM supports both Dom0/DomU > using the same mode. > > Signed-off-by: Roger Pau Monné Acked-by: George Dunlap

Re: [Xen-devel] [PATCH v2] SUPPORT.md: add PVH Dom0 status

2018-03-27 Thread George Dunlap
On 03/23/2018 12:08 PM, Roger Pau Monne wrote: > Also fix x86/HVM to spell out that only DomU HVM mode is supported and > remove the 'guest' from the ARM section, ARM supports both Dom0/DomU > using the same mode. > > Signed-off-by: Roger Pau Monné Acked-by: George Dunlap

Re: [Xen-devel] [PATCH] libxl_dm: Replace deprecated -drive if=scsi

2018-03-27 Thread Ian Jackson
Anthony PERARD writes ("Re: [PATCH] libxl_dm: Replace deprecated -drive if=scsi"): > As far as I can tell, the new syntax is not new. It as always been > available. We already use "-device", and both "scsi-disk" and "lsi.." > have been available and used internally by QEMU before 1.0. And

Re: [Xen-devel] [PATCH for-4.11] tools: set DEBUG_DIR from configure

2018-03-27 Thread Doug Goldstein
On 3/27/18 11:28 AM, Roger Pau Monné wrote: > On Tue, Mar 27, 2018 at 05:20:57PM +0100, Roger Pau Monné wrote: >> On Tue, Mar 27, 2018 at 06:18:08PM +0200, Olaf Hering wrote: >>> On Tue, Mar 27, Roger Pau Monne wrote: >>> +AC_ARG_WITH([debugdir], +

Re: [Xen-devel] [PATCH for-4.11] tools: set DEBUG_DIR from configure

2018-03-27 Thread Roger Pau Monné
On Tue, Mar 27, 2018 at 05:20:57PM +0100, Roger Pau Monné wrote: > On Tue, Mar 27, 2018 at 06:18:08PM +0200, Olaf Hering wrote: > > On Tue, Mar 27, Roger Pau Monne wrote: > > > > > +AC_ARG_WITH([debugdir], > > > +AS_HELP_STRING([--with-debugdir=DIR], > > > +[Path to directory for debug

Re: [Xen-devel] Request for Xen SeaBIOS git head / branch to follow or include Xen staging tag

2018-03-27 Thread Wei Liu
On Tue, Mar 27, 2018 at 04:13:36PM +0100, Wei Liu wrote: > On Fri, Mar 16, 2018 at 12:16:44PM +1000, John Thomson wrote: > > Hi, > > > > Could there please be a branch of the Xen SeaBIOS repository to track or > > include the latest tag used by Xen staging? > > Just for ease of use. All the

Re: [Xen-devel] [PATCH for-4.11] tools: set DEBUG_DIR from configure

2018-03-27 Thread Olaf Hering
On Tue, Mar 27, Roger Pau Monne wrote: > +AC_ARG_WITH([debugdir], > +AS_HELP_STRING([--with-debugdir=DIR], > +[Path to directory for debug symbols. [PREFIX/usr/lib/debug]]), > +[debugdir_path=$withval], > +[debugdir_path=$prefix/usr/lib/debug]) Would that create

[Xen-devel] [PATCH for-4.11] tools: set DEBUG_DIR from configure

2018-03-27 Thread Roger Pau Monne
Allow the path to be set from a configure command line option. Signed-off-by: Roger Pau Monné --- Cc: Ian Jackson Cc: Wei Liu Cc: Olaf Hering Cc: Jan Beulich --- config/Paths.mk.in | 1 +

Re: [Xen-devel] [PATCH v2 for-4.11] kconfig: don't select VPCI if building a shim-only binary

2018-03-27 Thread Roger Pau Monné
On Tue, Mar 27, 2018 at 09:36:09AM -0600, Jan Beulich wrote: > >>> On 27.03.18 at 17:30, wrote: > > Add dummy replacements for some functions used outside of the vpci > > code, and also a guard in vmsi.c to prevent vpci arch specific helpers > > from being compiled if the

Re: [Xen-devel] [PATCH] libxl_dm: Replace deprecated -drive if=scsi

2018-03-27 Thread Anthony PERARD
On Tue, Mar 27, 2018 at 03:57:32PM +0100, Ian Jackson wrote: > Anthony PERARD writes ("[PATCH] libxl_dm: Replace deprecated -drive if=scsi"): > > .. by -drive if=none,.. -device scsi-disk,... > > > > The use of if=scsi in QEMU is deprecated and has been removed in 2.12 by > > 1454509726 scsi:

Re: [Xen-devel] [PATCH v2 for-4.11] kconfig: don't select VPCI if building a shim-only binary

2018-03-27 Thread Wei Liu
On Tue, Mar 27, 2018 at 04:30:26PM +0100, Roger Pau Monne wrote: > Add dummy replacements for some functions used outside of the vpci > code, and also a guard in vmsi.c to prevent vpci arch specific helpers > from being compiled if the option is not selected. > > Reported-by: Wei Liu

Re: [Xen-devel] [RFC PATCH 07/12] hvmloader: allocate MMCONFIG area in the MMIO hole + minor code refactoring

2018-03-27 Thread Alexey G
On Tue, 27 Mar 2018 09:45:30 +0100 Roger Pau Monné wrote: >On Tue, Mar 27, 2018 at 05:42:11AM +1000, Alexey G wrote: >> On Mon, 26 Mar 2018 10:24:38 +0100 >> Roger Pau Monné wrote: >> >> >On Sat, Mar 24, 2018 at 08:32:44AM +1000, Alexey G wrote:

Re: [Xen-devel] [PATCH v2 for-4.11] kconfig: don't select VPCI if building a shim-only binary

2018-03-27 Thread Jan Beulich
>>> On 27.03.18 at 17:30, wrote: > Add dummy replacements for some functions used outside of the vpci > code, and also a guard in vmsi.c to prevent vpci arch specific helpers > from being compiled if the option is not selected. > > Reported-by: Wei Liu

Re: [Xen-devel] [PATCH v3a 14/39] ARM: new VGIC: Add GICv2 world switch backend

2018-03-27 Thread Andre Przywara
Hi, On 27/03/18 00:22, Stefano Stabellini wrote: > On Thu, 22 Mar 2018, Andre Przywara wrote: >> Processing maintenance interrupts and accessing the list registers >> are dependent on the host's GIC version. >> Introduce vgic-v2.c to contain GICv2 specific functions. >> Implement the GICv2

[Xen-devel] [PATCH v2 for-4.11] kconfig: don't select VPCI if building a shim-only binary

2018-03-27 Thread Roger Pau Monne
Add dummy replacements for some functions used outside of the vpci code, and also a guard in vmsi.c to prevent vpci arch specific helpers from being compiled if the option is not selected. Reported-by: Wei Liu Signed-off-by: Roger Pau Monné --- Cc: Jan

[Xen-devel] [linux-linus test] 121284: regressions - FAIL

2018-03-27 Thread osstest service owner
flight 121284 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/121284/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt 7 xen-boot fail REGR. vs. 118324

Re: [Xen-devel] Request for Xen SeaBIOS git head / branch to follow or include Xen staging tag

2018-03-27 Thread Wei Liu
On Fri, Mar 16, 2018 at 12:16:44PM +1000, John Thomson wrote: > Hi, > > Could there please be a branch of the Xen SeaBIOS repository to track or > include the latest tag used by Xen staging? > Just for ease of use. All the other Xen dependency repositories do this. > > Xen staging currently

Re: [Xen-devel] [PATCH for-4.11] kconfig: don't select VPCI if building a shim-only binary

2018-03-27 Thread Jan Beulich
>>> On 27.03.18 at 16:56, wrote: > Reported-by: Wei Liu > Signed-off-by: Roger Pau Monné Acked-by: Jan Beulich (on the assumption that the shim then still builds) Jan

Re: [Xen-devel] [PATCH for-4.11] kconfig: don't select VPCI if building a shim-only binary

2018-03-27 Thread Roger Pau Monné
On Tue, Mar 27, 2018 at 03:56:22PM +0100, Roger Pau Monne wrote: > Reported-by: Wei Liu > Signed-off-by: Roger Pau Monné Oh, this needs a further fix, will send v2. ___ Xen-devel mailing list

Re: [Xen-devel] [OSSTEST PATCH] README.dev: Say to use mg-force-push for force pushes

2018-03-27 Thread Wei Liu
On Tue, Mar 27, 2018 at 04:01:07PM +0100, Ian Jackson wrote: > Reported-by: Wei Liu > Signed-off-by: Ian Jackson Reviewed-by: Wei Liu ___ Xen-devel mailing list

[Xen-devel] [OSSTEST PATCH] README.dev: Say to use mg-force-push for force pushes

2018-03-27 Thread Ian Jackson
Reported-by: Wei Liu Signed-off-by: Ian Jackson --- README.dev | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/README.dev b/README.dev index 37e2953..95fc66c 100644 --- a/README.dev +++ b/README.dev @@ -199,13 +199,13

Re: [Xen-devel] [PATCH] libxl_dm: Replace deprecated -drive if=scsi

2018-03-27 Thread Ian Jackson
Anthony PERARD writes ("[PATCH] libxl_dm: Replace deprecated -drive if=scsi"): > .. by -drive if=none,.. -device scsi-disk,... > > The use of if=scsi in QEMU is deprecated and has been removed in 2.12 by > 1454509726 scsi: Remove automatic creation of SCSI controllers with -drive > if=scsi

[Xen-devel] [PATCH for-4.11] kconfig: don't select VPCI if building a shim-only binary

2018-03-27 Thread Roger Pau Monne
Reported-by: Wei Liu Signed-off-by: Roger Pau Monné --- Cc: Jan Beulich Cc: Andrew Cooper Cc: Wei Liu --- xen/arch/x86/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Xen-devel] osstest planned outage consultation

2018-03-27 Thread Ian Jackson
We are now planning to do this work on April 19th-21st. osstest will be shut down some time on the 17th/18th to let it drain its queue. Ian. ___ Xen-devel mailing list Xen-devel@lists.xenproject.org

Re: [Xen-devel] [RFC 4/4] HACK libxl_exec: Check QEMU status via QMP instead of xenstore

2018-03-27 Thread Ian Jackson
Anthony PERARD writes ("Re: [Xen-devel] [RFC 4/4] HACK libxl_exec: Check QEMU status via QMP instead of xenstore"): > On Tue, Mar 27, 2018 at 02:43:22PM +0100, Ian Jackson wrote: > > Right, but doesn't one still have to poll on connect() ? > > Yes, we need to poll on connect(). > > libvirt

Re: [Xen-devel] [PATCH] docs/qemu-deprivilege: Revise and update with status and future plans

2018-03-27 Thread George Dunlap
On 03/27/2018 03:37 PM, Ian Jackson wrote: > George Dunlap writes ("Re: [PATCH] docs/qemu-deprivilege: Revise and update > with status and future plans"): >> The alternate would be to have yet another UID range, to that we could >> have a "target ID" (i.e., QEMU) and a "reaper ID" for each

Re: [Xen-devel] [PATCH] shim: update config after vpci patches

2018-03-27 Thread Wei Liu
On Tue, Mar 27, 2018 at 03:41:57PM +0100, Roger Pau Monné wrote: > On Tue, Mar 27, 2018 at 03:12:35PM +0100, Wei Liu wrote: > > On Tue, Mar 27, 2018 at 03:09:42PM +0100, Roger Pau Monné wrote: > > > On Tue, Mar 27, 2018 at 02:58:13PM +0100, Wei Liu wrote: > > > > Signed-off-by: Wei Liu

Re: [Xen-devel] [PATCH] docs/qemu-deprivilege: Revise and update with status and future plans

2018-03-27 Thread Ian Jackson
George Dunlap writes ("Re: [PATCH] docs/qemu-deprivilege: Revise and update with status and future plans"): > The alternate would be to have yet another UID range, to that we could > have a "target ID" (i.e., QEMU) and a "reaper ID" for each domain. I > think that should mean any races should be

Re: [Xen-devel] [PATCH] docs/qemu-deprivilege: Revise and update with status and future plans

2018-03-27 Thread George Dunlap
On 03/27/2018 03:15 PM, George Dunlap wrote: > On 03/27/2018 02:33 PM, Ian Jackson wrote: > +### Namespaces for unused functionality >> ... > +unshare(CLONE_NEWNS | CLONE_NEWIPC) This would mean we would have to pass qemu fds for both the network tap devices and any vnc

Re: [Xen-devel] [PATCH] shim: update config after vpci patches

2018-03-27 Thread Wei Liu
On Tue, Mar 27, 2018 at 03:09:42PM +0100, Roger Pau Monné wrote: > On Tue, Mar 27, 2018 at 02:58:13PM +0100, Wei Liu wrote: > > Signed-off-by: Wei Liu > > --- > > tools/firmware/xen-dir/shim.config | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git

[Xen-devel] [PATCH] shim: update config after vpci patches

2018-03-27 Thread Wei Liu
Signed-off-by: Wei Liu --- tools/firmware/xen-dir/shim.config | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/firmware/xen-dir/shim.config b/tools/firmware/xen-dir/shim.config index 4d5630f87a..05071bf436 100644 --- a/tools/firmware/xen-dir/shim.config +++

Re: [Xen-devel] [PATCH] docs/qemu-deprivilege: Revise and update with status and future plans

2018-03-27 Thread Ian Jackson
George Dunlap writes ("Re: [PATCH] docs/qemu-deprivilege: Revise and update with status and future plans"): > Actually I think most of the user-facing stuff already in xl.cfg is > inappropriate for that man page. It might make sense to have a separate > man page for it. I wouldn't object to

Re: [Xen-devel] [PATCH v3 13/39] ARM: new VGIC: Add IRQ sync/flush framework

2018-03-27 Thread Andre Przywara
Hi, On 26/03/18 22:30, Stefano Stabellini wrote: > On Wed, 21 Mar 2018, Andre Przywara wrote: >> Implement the framework for syncing IRQs between our emulation and the >> list registers, which represent the guest's view of IRQs. >> This is done in vgic_sync_from_lrs() and vgic_sync_to_lrs(),

Re: [Xen-devel] [PATCH v3 05/39] ARM: timer: Handle level triggered IRQs correctly

2018-03-27 Thread Andre Przywara
Hi, On 26/03/18 21:28, Stefano Stabellini wrote: > On Wed, 21 Mar 2018, Andre Przywara wrote: >> The ARM Generic Timer uses a level-sensitive interrupt semantic. We >> easily catch when the line goes high, as this triggers the hardware IRQ. >> However we also have to keep track of when the line

Re: [Xen-devel] [RFC 1/4] libxl: Learned to send FD through QMP to QEMU

2018-03-27 Thread Anthony PERARD
On Tue, Mar 27, 2018 at 11:58:45AM +0100, George Dunlap wrote: > On 03/27/2018 11:29 AM, Ian Jackson wrote: > > This 2nd patch looks reasonable, but it prompted to notice two new > > kinds of hazard introduced by the deprivileging design goal: > > > >> int libxl__qmp_save(libxl__gc *gc, int

Re: [Xen-devel] [PATCH] x86/vpci: validate data first in register_vpci_mmcfg_handler

2018-03-27 Thread Jan Beulich
>>> On 27.03.18 at 13:09, wrote: > On Tue, Mar 27, 2018 at 12:04:20PM +0100, Wei Liu wrote: >> Avoid the need to deallocate memory when the data is invalid. It has >> the benefit to not fragment memory in Xen. >> >> Signed-off-by: Wei Liu > >

Re: [Xen-devel] [PATCH v2] x86/boot: Disable IBRS in intr/nmi exit path at bootup stage

2018-03-27 Thread Jan Beulich
>>> On 27.03.18 at 13:03, wrote: > On 2018/3/27 16:52, Jan Beulich wrote: > On 27.03.18 at 06:52, wrote: >>> --- a/xen/include/asm-x86/spec_ctrl.h >>> +++ b/xen/include/asm-x86/spec_ctrl.h >>> @@ -32,8 +32,22 @@ extern uint8_t

Re: [Xen-devel] [PATCH v2 02/17] arm64: vgic-v3: Add ICV_BPR1_EL1 handler

2018-03-27 Thread Marc Zyngier
On 27/03/18 12:27, Manish Jaggi wrote: > > > On 03/27/2018 04:55 PM, Marc Zyngier wrote: >> On 27/03/18 12:15, Manish Jaggi wrote: >>> >>> On 03/27/2018 04:41 PM, Marc Zyngier wrote: On 27/03/18 12:07, Manish Jaggi wrote: > On 03/27/2018 04:35 PM, Marc Zyngier wrote: >> On 27/03/18

Re: [Xen-devel] [PATCH v2 02/17] arm64: vgic-v3: Add ICV_BPR1_EL1 handler

2018-03-27 Thread Manish Jaggi
On 03/27/2018 04:55 PM, Marc Zyngier wrote: On 27/03/18 12:15, Manish Jaggi wrote: On 03/27/2018 04:41 PM, Marc Zyngier wrote: On 27/03/18 12:07, Manish Jaggi wrote: On 03/27/2018 04:35 PM, Marc Zyngier wrote: On 27/03/18 11:56, Manish Jaggi wrote: On 03/27/2018 04:15 PM, Marc Zyngier

Re: [Xen-devel] [PATCH v2 02/17] arm64: vgic-v3: Add ICV_BPR1_EL1 handler

2018-03-27 Thread Marc Zyngier
On 27/03/18 12:15, Manish Jaggi wrote: > > > On 03/27/2018 04:41 PM, Marc Zyngier wrote: >> On 27/03/18 12:07, Manish Jaggi wrote: >>> >>> On 03/27/2018 04:35 PM, Marc Zyngier wrote: On 27/03/18 11:56, Manish Jaggi wrote: > On 03/27/2018 04:15 PM, Marc Zyngier wrote: >> On 27/03/18

Re: [Xen-devel] [PATCH] docs/qemu-deprivilege: Revise and update with status and future plans

2018-03-27 Thread George Dunlap
On 03/27/2018 11:20 AM, George Dunlap wrote: >>> +### Further RLIMITs >>> + >>> +RLIMIT_AS limits the total amount of memory; but this includes the >>> +virtual memory which QEMU uses as a mapcache. xen-mapcache.c already >>> +fiddles with this; it would be straightforward to make it *set* the

Re: [Xen-devel] [PATCH v2 02/17] arm64: vgic-v3: Add ICV_BPR1_EL1 handler

2018-03-27 Thread Manish Jaggi
On 03/27/2018 04:41 PM, Marc Zyngier wrote: On 27/03/18 12:07, Manish Jaggi wrote: On 03/27/2018 04:35 PM, Marc Zyngier wrote: On 27/03/18 11:56, Manish Jaggi wrote: On 03/27/2018 04:15 PM, Marc Zyngier wrote: On 27/03/18 11:35, Manish Jaggi wrote: On 03/27/2018 04:00 PM, Marc Zyngier

Re: [Xen-devel] [RFC 4/4] HACK libxl_exec: Check QEMU status via QMP instead of xenstore

2018-03-27 Thread Anthony PERARD
On Tue, Mar 27, 2018 at 11:36:00AM +0100, Ian Jackson wrote: > Anthony PERARD writes ("[RFC 4/4] HACK libxl_exec: Check QEMU status via QMP > instead of xenstore"): > > This path is more of a prof of concept reather than a patch as this > > would break qemu-trad. > ... > > For libxl, the only way

Re: [Xen-devel] [PATCH v2 02/17] arm64: vgic-v3: Add ICV_BPR1_EL1 handler

2018-03-27 Thread Marc Zyngier
On 27/03/18 12:07, Manish Jaggi wrote: > > > On 03/27/2018 04:35 PM, Marc Zyngier wrote: >> On 27/03/18 11:56, Manish Jaggi wrote: >>> >>> On 03/27/2018 04:15 PM, Marc Zyngier wrote: On 27/03/18 11:35, Manish Jaggi wrote: > On 03/27/2018 04:00 PM, Marc Zyngier wrote: >> On 27/03/18

Re: [Xen-devel] [PATCH] x86/vpci: validate data first in register_vpci_mmcfg_handler

2018-03-27 Thread Roger Pau Monné
On Tue, Mar 27, 2018 at 12:04:20PM +0100, Wei Liu wrote: > Avoid the need to deallocate memory when the data is invalid. It has > the benefit to not fragment memory in Xen. > > Signed-off-by: Wei Liu Reviewed-by: Roger Pau Monné > --- > Found by code

[Xen-devel] [xen-unstable-smoke test] 121312: tolerable all pass - PUSHED

2018-03-27 Thread osstest service owner
flight 121312 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/121312/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [Xen-devel] [PATCH v2 02/17] arm64: vgic-v3: Add ICV_BPR1_EL1 handler

2018-03-27 Thread Manish Jaggi
On 03/27/2018 04:35 PM, Marc Zyngier wrote: On 27/03/18 11:56, Manish Jaggi wrote: On 03/27/2018 04:15 PM, Marc Zyngier wrote: On 27/03/18 11:35, Manish Jaggi wrote: On 03/27/2018 04:00 PM, Marc Zyngier wrote: On 27/03/18 10:07, Manish Jaggi wrote: This patch is ported to xen from linux

Re: [Xen-devel] [PATCH v2 02/17] arm64: vgic-v3: Add ICV_BPR1_EL1 handler

2018-03-27 Thread Marc Zyngier
On 27/03/18 11:56, Manish Jaggi wrote: > > > On 03/27/2018 04:15 PM, Marc Zyngier wrote: >> On 27/03/18 11:35, Manish Jaggi wrote: >>> >>> On 03/27/2018 04:00 PM, Marc Zyngier wrote: On 27/03/18 10:07, Manish Jaggi wrote: > This patch is ported to xen from linux commit >

[Xen-devel] [PATCH] x86/vpci: validate data first in register_vpci_mmcfg_handler

2018-03-27 Thread Wei Liu
Avoid the need to deallocate memory when the data is invalid. It has the benefit to not fragment memory in Xen. Signed-off-by: Wei Liu --- Found by code inspection. There shouldn't be any practical difference in our current setup because the function is hardware domain only.

Re: [Xen-devel] [PATCH v2] x86/boot: Disable IBRS in intr/nmi exit path at bootup stage

2018-03-27 Thread Zhenzhong Duan
On 2018/3/27 16:52, Jan Beulich wrote: On 27.03.18 at 06:52, wrote: After reset, IBRS is disabled by processor, but a coming intr/nmi leave IBRS enabled after their exit. It's not necessory for bootup code to run in low performance with IBRS enabled. On ORACLE

Re: [Xen-devel] [PATCH v2 09/17] arm64: vgic-v3: Add ICV_HPPIR1_EL1 handler

2018-03-27 Thread Manish Jaggi
On 03/27/2018 04:26 PM, Marc Zyngier wrote: On 27/03/18 10:07, Manish Jaggi wrote: This patch is ported from linux to xen commit: 2724c11a1df4b22ee966c04809ea0e808f66b04e (KVM: arm64: vgic-v3: Add ICV_HPPIR1_EL1 handler) Add a handler for reading the guest's view of the ICV_HPPIR1_EL1

Re: [Xen-devel] [PATCH v2 12/17] arm64: vgic-v3: Add misc Group-0 handlers

2018-03-27 Thread Manish Jaggi
On 03/27/2018 04:28 PM, Marc Zyngier wrote: On 27/03/18 10:07, Manish Jaggi wrote: This patch is ported to xen from linux commit: eab0b2dc4f6f34147e3d10da49ab8032e15dbea0 (KVM: arm64: vgic-v3: Add misc Group-0 handlers) A number of Group-0 registers can be handled by the same accessors as

Re: [Xen-devel] [RFC 1/4] libxl: Learned to send FD through QMP to QEMU

2018-03-27 Thread George Dunlap
On 03/27/2018 11:29 AM, Ian Jackson wrote: > (George, CC'ing you wrt your depriv doc patch - see below.) > > Anthony PERARD writes ("[RFC 1/4] libxl: Learned to send FD through QMP to > QEMU"): >> Adding the ability to send a file descriptor from libxl to QEMU via the >> QMP interface. This will

Re: [Xen-devel] [PATCH v2 12/17] arm64: vgic-v3: Add misc Group-0 handlers

2018-03-27 Thread Marc Zyngier
On 27/03/18 10:07, Manish Jaggi wrote: > This patch is ported to xen from linux commit: > eab0b2dc4f6f34147e3d10da49ab8032e15dbea0 > (KVM: arm64: vgic-v3: Add misc Group-0 handlers) > > A number of Group-0 registers can be handled by the same accessors > as that of Group-1, so let's add the

Re: [Xen-devel] [PATCH v2 02/17] arm64: vgic-v3: Add ICV_BPR1_EL1 handler

2018-03-27 Thread Manish Jaggi
On 03/27/2018 04:15 PM, Marc Zyngier wrote: On 27/03/18 11:35, Manish Jaggi wrote: On 03/27/2018 04:00 PM, Marc Zyngier wrote: On 27/03/18 10:07, Manish Jaggi wrote: This patch is ported to xen from linux commit d70c7b31a60f2458f35c226131f2a01a7a98b6cf KVM: arm64: vgic-v3: Add ICV_BPR1_EL1

  1   2   >