Re: [Xen-devel] [PATCH] xen: Add RING_COPY_RESPONSE()

2018-05-01 Thread Oleksandr Andrushchenko
On 05/01/2018 12:54 AM, Marek Marczykowski-Górecki wrote: Using RING_GET_RESPONSE() on a shared ring is easy to use incorrectly (i.e., by not considering that the other end may alter the data in the shared ring while it is being inspected). Safe usage of a response generally requires taking a

[Xen-devel] [linux-3.18 baseline-only test] 74655: tolerable FAIL

2018-05-01 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 74655 linux-3.18 real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/74655/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win10-i386 10 windows-install fail

Re: [Xen-devel] [PATCH 2/6] xen-netfront: copy response out of shared buffer before accessing it

2018-05-01 Thread Oleksandr Andrushchenko
On 05/01/2018 12:01 AM, Marek Marczykowski-Górecki wrote: Make local copy of the response, otherwise backend might modify it while frontend is already processing it - leading to time of check / time of use issue. This is complementary to XSA155. Cc: sta...@vger.kernel.org Signed-off-by: Marek

[Xen-devel] Patch "x86/xen: Add pvh specific rsdp address retrieval function" has been added to the 4.16-stable tree

2018-05-01 Thread gregkh
This is a note to let you know that I've just added the patch titled x86/xen: Add pvh specific rsdp address retrieval function to the 4.16-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

[Xen-devel] [xen-4.9-testing baseline-only test] 74654: tolerable FAIL

2018-05-01 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 74654 xen-4.9-testing real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/74654/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemut-win10-i386 10 windows-install fail

[Xen-devel] [ovmf test] 122532: all pass - PUSHED

2018-05-01 Thread osstest service owner
flight 122532 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/122532/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf f9dff90289507191f299331e44601c5ef83c1948 baseline version: ovmf

Re: [Xen-devel] 4.11.0 RC1 panic

2018-05-01 Thread Manuel Bouyer
On Mon, Apr 30, 2018 at 07:31:28AM -0600, Jan Beulich wrote: > >>> On 25.04.18 at 16:42, wrote: > > On Wed, Apr 25, 2018 at 12:42:42PM +0200, Manuel Bouyer wrote: > >> > Without line numbers associated with at least the top stack trace entry > >> > I can only guess what it

Re: [Xen-devel] [PATCH for-4.11 v2 2/2] Add new add_maintainers.pl script to optimise the workflow when using git format-patch with get_maintainer.pl

2018-05-01 Thread Ian Jackson
Lars Kurth writes ("Re: [PATCH for-4.11 v2 2/2] Add new add_maintainers.pl script to optimise the workflow when using git format-patch with get_maintainer.pl"): > Maybe the best way to approach this is > to have two options that control how CCs are inserted into the cover > letter and a

Re: [Xen-devel] [PATCH for-4.11 v2 2/2] Add new add_maintainers.pl script to optimise the workflow when using git format-patch with get_maintainer.pl

2018-05-01 Thread Lars Kurth
On 01/05/2018, 16:16, "Ian Jackson" wrote: Lars Kurth writes ("Re: [PATCH for-4.11 v2 2/2] Add new add_maintainers.pl script to optimise the workflow when using git format-patch with get_maintainer.pl"): > In the cover letter, the tool always insert at the

Re: [Xen-devel] Should PV frontend drivers trust the backends?

2018-05-01 Thread Paul Durrant
> -Original Message- [snip] > > So what happens if the backend servicing the VM's boot disk fails? Is it > better to: > > > > a) BUG()/BSOD with some meaningful stack and code such that it's obvious > that happened, so > > b) cover up and wait until something further up the storage stack

[Xen-devel] x86 Community Call - Wed May 9, 14:00 - 15:00 UTC - Call for agenda items

2018-05-01 Thread Lars Kurth
Hi all, please find attached a) Meeting details (just a link with timezones) – the meeting invite will follow when we have an agenda    Gotomeeting, phone bridge details and slack channel will be sent with the meeting invite == Meeting Details == Wed May 9, 14:00 - 15:00 UTC Wed May 9, 15:00

Re: [Xen-devel] [PATCH for-4.11 v2 2/2] Add new add_maintainers.pl script to optimise the workflow when using git format-patch with get_maintainer.pl

2018-05-01 Thread Ian Jackson
Lars Kurth writes ("Re: [PATCH for-4.11 v2 2/2] Add new add_maintainers.pl script to optimise the workflow when using git format-patch with get_maintainer.pl"): > In the cover letter, the tool always insert at the top as it is a transient > thing that does not end up in git. > > On 01/05/2018,

Re: [Xen-devel] Should PV frontend drivers trust the backends?

2018-05-01 Thread 'Marek Marczykowski-Górecki'
On Tue, May 01, 2018 at 07:55:39AM +, Paul Durrant wrote: > > -Original Message- > > From: Marek Marczykowski-Górecki > > [mailto:marma...@invisiblethingslab.com] > > Sent: 30 April 2018 18:33 > > To: Oleksandr Andrushchenko > > Cc: Paul Durrant

[Xen-devel] [xen-unstable-smoke test] 122553: tolerable all pass - PUSHED

2018-05-01 Thread osstest service owner
flight 122553 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/122553/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [Xen-devel] [PATCH for-4.11 v2 2/2] Add new add_maintainers.pl script to optimise the workflow when using git format-patch with get_maintainer.pl

2018-05-01 Thread Lars Kurth
On 01/05/2018, 13:52, "Ian Jackson" wrote: Lars Kurth writes ("Re: [PATCH for-4.11 v2 2/2] Add new add_maintainers.pl script to optimise the workflow when using git format-patch with get_maintainer.pl"): > On 30/04/2018, 17:21, "Ian Jackson"

[Xen-devel] [linux-linus test] 122521: regressions - FAIL

2018-05-01 Thread osstest service owner
flight 122521 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/122521/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-debianhvm-amd64-xsm 16 guest-localmigrate/x10 fail REGR. vs. 118324

[Xen-devel] [xen-4.8-testing baseline-only test] 74653: tolerable FAIL

2018-05-01 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 74653 xen-4.8-testing real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/74653/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-xsm 12 guest-start fail

[Xen-devel] [libvirt test] 122527: tolerable all pass - PUSHED

2018-05-01 Thread osstest service owner
flight 122527 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/122527/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 14 saverestore-support-checkfail like 122455 test-armhf-armhf-libvirt-xsm 14

Re: [Xen-devel] where can I find the 'address translation' code in Xen?

2018-05-01 Thread Minjun Hong
On Mon, Apr 30, 2018 at 10:13 PM, Andrew Cooper wrote: > On 29/04/18 11:11, Minjun Hong wrote: > > Hi. > > I'm looking for a point where address translation (guest virtual > > address to machine address) occurs in Xen. > > Of course, I mean when TLB miss has occured. >

Re: [Xen-devel] reboot driver domain, vifX.Y = NO-CARRIER?

2018-05-01 Thread Jason Cooper
add the link to xen-users thread of me talking to myself. :-)) On Tue, May 01, 2018 at 12:37:51PM +, Jason Cooper wrote: > When I was first digging into this, I started a thread on xen-users [1], > I've attached my xl-reboot.sh script here so you can see exactly what > I'm attempting to do:

Re: [Xen-devel] [PATCH for-4.11 2/2] Replace http: with https: in MAINTAINERs file

2018-05-01 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH for-4.11 2/2] Replace http: with https: in MAINTAINERs file"): > On Tue, May 01, 2018 at 01:34:01PM +0100, Lars Kurth wrote: > > Requested by Ian Jackson, see > > https://lists.xenproject.org/archives/html/xen-devel/2018-04/msg02286.html > > > > The patch also fixes

Re: [Xen-devel] [PATCH for-4.11 v2 2/2] Add new add_maintainers.pl script to optimise the workflow when using git format-patch with get_maintainer.pl

2018-05-01 Thread Ian Jackson
Lars Kurth writes ("Re: [PATCH for-4.11 v2 2/2] Add new add_maintainers.pl script to optimise the workflow when using git format-patch with get_maintainer.pl"): > On 30/04/2018, 17:21, "Ian Jackson" wrote: > > When I do this, there is nothing that gets the CC for

Re: [Xen-devel] [PATCH for-4.11 2/2] Replace http: with https: in MAINTAINERs file

2018-05-01 Thread Wei Liu
On Tue, May 01, 2018 at 01:34:01PM +0100, Lars Kurth wrote: > Requested by Ian Jackson, see > https://lists.xenproject.org/archives/html/xen-devel/2018-04/msg02286.html > > The patch also fixes the location of linux-2.6.18-xen.hg (it is currently > pointing to an alias) While at it do we want

Re: [Xen-devel] [PATCH for-4.11 2/2] Replace http: with https: in MAINTAINERs file

2018-05-01 Thread Ian Jackson
Lars Kurth writes ("[PATCH for-4.11 2/2] Replace http: with https: in MAINTAINERs file"): > Requested by Ian Jackson, see > https://lists.xenproject.org/archives/html/xen-devel/2018-04/msg02286.html > > The patch also fixes the location of linux-2.6.18-xen.hg (it is currently > pointing to an

Re: [Xen-devel] [PATCH for-4.11 v3 0/2] Add Designated Reviewer (R:) to MAINTAINERS (plus a test case)

2018-05-01 Thread Ian Jackson
Lars Kurth writes ("[PATCH for-4.11 v3 0/2] Add Designated Reviewer (R:) to MAINTAINERS (plus a test case)"): > This follows up from a conversation after the April x86 community call, in > which I had > the following action: Lars to propose fixing CC issue in xen.git:MAINTAINERS > copying >

Re: [Xen-devel] [PATCH 1/4] xen/PVH: Replace GDT_ENTRY with explicit constant

2018-05-01 Thread Boris Ostrovsky
On 05/01/2018 07:31 AM, David Laight wrote: From: Boris Ostrovsky Sent: 30 April 2018 17:24 To: linux-ker...@vger.kernel.org; xen-devel@lists.xenproject.org Cc: jgr...@suse.com; Boris Ostrovsky; sta...@vger.kernel.org Subject: [PATCH 1/4] xen/PVH: Replace GDT_ENTRY with explicit constant

Re: [Xen-devel] reboot driver domain, vifX.Y = NO-CARRIER?

2018-05-01 Thread Jason Cooper
Morning George, On Tue, May 01, 2018 at 11:25:06AM +0100, George Dunlap wrote: > On Mon, Apr 30, 2018 at 7:17 PM, Jason Cooper wrote: > > On Mon, Apr 30, 2018 at 05:38:55PM +0100, George Dunlap wrote: > >> On Mon, Apr 30, 2018 at 5:16 PM, Jason Cooper

Re: [Xen-devel] [PATCH 4/4] xen/PVH: Remove reserved entry in PVH GDT

2018-05-01 Thread Boris Ostrovsky
On 05/01/2018 04:00 AM, Roger Pau Monné wrote: On Mon, Apr 30, 2018 at 12:23:39PM -0400, Boris Ostrovsky wrote: And without it we can't use _BOOT_XX macros any longer so define new ones. Not being that familiar with Linux internals I'm not sure I see the benefit of this. Isn't there a risk

[Xen-devel] [PATCH for-4.11 0/2] MAINTAINERS cleanup

2018-05-01 Thread Lars Kurth
Patches cleaning up the MAINTAINERs file - Replace xen.org with xenproject.org in URLs - Replace http: with https: in URLs - Also fixes the location of linux-2.6.18-xen.hg This was formerly part of https://lists.xenproject.org/archives/html/xen-devel/2018-04/threads.html#02230 Lars Kurth (2):

[Xen-devel] [PATCH for-4.11 1/2] Replace occurances of xen.org with xenproject.org

2018-05-01 Thread Lars Kurth
This is a general clean-up activity. It also avoids mails being sent to xen-devel@lists.xenproject.org and xen-de...@lists.xen.org when used with add_maintainers.pl/git send-email Cc: Andrew Cooper Cc: George Dunlap Cc: Ian Jackson

[Xen-devel] [PATCH for-4.11 2/2] Replace http: with https: in MAINTAINERs file

2018-05-01 Thread Lars Kurth
Requested by Ian Jackson, see https://lists.xenproject.org/archives/html/xen-devel/2018-04/msg02286.html The patch also fixes the location of linux-2.6.18-xen.hg (it is currently pointing to an alias) Cc: Andrew Cooper Cc: George Dunlap

Re: [Xen-devel] [PATCH 1/4] xen/PVH: Replace GDT_ENTRY with explicit constant

2018-05-01 Thread Boris Ostrovsky
On 05/01/2018 03:53 AM, Roger Pau Monné wrote: On Mon, Apr 30, 2018 at 02:07:43PM -0400, Boris Ostrovsky wrote: On 04/30/2018 12:57 PM, Roger Pau Monné wrote: On Mon, Apr 30, 2018 at 12:23:36PM -0400, Boris Ostrovsky wrote: Latest binutils release (2.29.1) will no longer allow proper

Re: [Xen-devel] [For knowledge-sake] Understanding of couple of things under the hood

2018-05-01 Thread Ajay Garg
Thanks a ton Julien, that was mighty useful !! On Tue, May 1, 2018 at 4:44 PM, Julien Grall wrote: > > > On 01/05/18 11:27, Ajay Garg wrote: >> >> Hi All. > > > Hello, > > >> I have been able to bring up xen on cubieboard2, using the following >> script gathered from google

Re: [Xen-devel] reboot driver domain, vifX.Y = NO-CARRIER?

2018-05-01 Thread Wei Liu
On Mon, Apr 30, 2018 at 04:16:09PM +, Jason Cooper wrote: > Hi Ian, > > On Mon, Apr 30, 2018 at 04:22:30PM +0100, Ian Jackson wrote: > > Wei Liu writes ("Re: [Xen-devel] reboot driver domain, vifX.Y = > > NO-CARRIER?"): > > > To implement reuse_domid in a sane way, either the toolstack needs

Re: [Xen-devel] [PATCH 1/4] xen/PVH: Replace GDT_ENTRY with explicit constant

2018-05-01 Thread David Laight
From: Boris Ostrovsky > Sent: 30 April 2018 17:24 > To: linux-ker...@vger.kernel.org; xen-devel@lists.xenproject.org > Cc: jgr...@suse.com; Boris Ostrovsky; sta...@vger.kernel.org > Subject: [PATCH 1/4] xen/PVH: Replace GDT_ENTRY with explicit constant > > Latest binutils release (2.29.1) will no

Re: [Xen-devel] reboot driver domain, vifX.Y = NO-CARRIER?

2018-05-01 Thread Wei Liu
On Fri, Apr 27, 2018 at 05:27:29PM +, Jason Cooper wrote: > Hi Wei Liu, > > On Fri, Apr 27, 2018 at 05:58:17PM +0100, Wei Liu wrote: > > On Fri, Apr 27, 2018 at 04:14:16PM +, Jason Cooper wrote: > > > On Fri, Apr 27, 2018 at 04:52:57PM +0100, Andrew Cooper wrote: > ... > > > >

Re: [Xen-devel] reboot driver domain, vifX.Y = NO-CARRIER?

2018-05-01 Thread Wei Liu
On Mon, Apr 30, 2018 at 06:14:15PM +, Jason Cooper wrote: > On Mon, Apr 30, 2018 at 05:26:38PM +0100, Ian Jackson wrote: > > Jason Cooper writes ("Re: [Xen-devel] reboot driver domain, vifX.Y = > > NO-CARRIER?"): > > > On Mon, Apr 30, 2018 at 04:22:30PM +0100, Ian Jackson wrote: > ... > > >

Re: [Xen-devel] [For knowledge-sake] Understanding of couple of things under the hood

2018-05-01 Thread Julien Grall
On 01/05/18 11:27, Ajay Garg wrote: Hi All. Hello, I have been able to bring up xen on cubieboard2, using the following script gathered from google : ### # SUNXI Xen Boot Script # Arch Linux ARM adaption of the cmd file which

Re: [Xen-devel] [PATCH 2/4] block/xen_disk: remove use of grant map/unmap

2018-05-01 Thread Paul Durrant
> -Original Message- > From: Wei Liu [mailto:wei.l...@citrix.com] > Sent: 01 May 2018 11:30 > To: Paul Durrant > Cc: Roger Pau Monne ; Kevin Wolf > ; Stefano Stabellini ; qemu- > bl...@nongnu.org;

[Xen-devel] [For knowledge-sake] Understanding of couple of things under the hood

2018-05-01 Thread Ajay Garg
Hi All. I have been able to bring up xen on cubieboard2, using the following script gathered from google : ### # SUNXI Xen Boot Script # Arch Linux ARM adaption of the cmd file which can be found at

Re: [Xen-devel] [PATCH] xen: Add RING_COPY_RESPONSE()

2018-05-01 Thread Wei Liu
On Mon, Apr 30, 2018 at 11:54:36PM +0200, Marek Marczykowski-Górecki wrote: > Using RING_GET_RESPONSE() on a shared ring is easy to use incorrectly > (i.e., by not considering that the other end may alter the data in the > shared ring while it is being inspected). Safe usage of a response >

Re: [Xen-devel] [PATCH 0/6] Fix XSA-155-like bugs in frontend drivers

2018-05-01 Thread Wei Liu
(Drop Linux lists and people) On Mon, Apr 30, 2018 at 11:01:44PM +0200, Marek Marczykowski-Górecki wrote: > Patches in original Xen Security Advisory 155 cared only about backend drivers > while leaving frontend patches to be "developed and released (publicly) after > the embargo date". This is

Re: [Xen-devel] [PATCH 4/6] xen-netfront: add range check for Tx response id

2018-05-01 Thread Wei Liu
On Mon, Apr 30, 2018 at 11:01:48PM +0200, Marek Marczykowski-Górecki wrote: > Tx response ID is fetched from shared page, so make sure it is sane > before using it as an array index. > > CC: sta...@vger.kernel.org > Signed-off-by: Marek Marczykowski-Górecki > ---

[Xen-devel] [linux-4.9 test] 122519: tolerable FAIL - PUSHED

2018-05-01 Thread osstest service owner
flight 122519 linux-4.9 real [real] http://logs.test-lab.xenproject.org/osstest/logs/122519/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stopfail like 122398 test-amd64-i386-xl-qemut-win7-amd64 17

Re: [Xen-devel] [PATCH v9 0/9] xen/x86: various XPTI speedups

2018-05-01 Thread Andrew Cooper
On 26/04/18 12:33, Juergen Gross wrote: > This patch series aims at reducing the overhead of the XPTI Meltdown > mitigation. With just the first 3 patches of this series (in a bisection attempt), on a XenServer build based off staging, XenRT finds the following: (XEN) Assertion 'first_dirty !=

Re: [Xen-devel] [PATCH 6/6] xen-blkfront: prepare request locally, only then put it on the shared ring

2018-05-01 Thread Roger Pau Monné
On Tue, May 01, 2018 at 09:22:31AM +0100, Roger Pau Monné wrote: > On Mon, Apr 30, 2018 at 11:01:50PM +0200, Marek Marczykowski-Górecki wrote: > > struct request *req, > > - struct blkif_request **ring_req) > > +

Re: [Xen-devel] [PATCH 6/6] xen-blkfront: prepare request locally, only then put it on the shared ring

2018-05-01 Thread Roger Pau Monné
On Mon, Apr 30, 2018 at 11:01:50PM +0200, Marek Marczykowski-Górecki wrote: > Do not reuse data which theoretically might be already modified by the > backend. This is mostly about private copy of the request > (info->shadow[id].req) - make sure the request saved there is really the > one just

Re: [Xen-devel] [PATCH v2] x86/microcode: Synchronize late microcode loading

2018-05-01 Thread Chao Gao
On Mon, Apr 30, 2018 at 09:25:26AM -0600, Jan Beulich wrote: On 25.04.18 at 13:46, wrote: >> @@ -281,24 +288,56 @@ static int microcode_update_cpu(const void *buf, >> size_t size) >> return err; >> } >> >> -static long do_microcode_update(void *_info) >> +/* Wait

[Xen-devel] [PATCH for-4.11 v3 0/2] Add Designated Reviewer (R:) to MAINTAINERS (plus a test case)

2018-05-01 Thread Lars Kurth
This follows up from a conversation after the April x86 community call, in which I had the following action: Lars to propose fixing CC issue in xen.git:MAINTAINERS copying the R section entries from Linux.git:MAINTAINERS (will need changes to get_maintainers.pl also) On 27/4/18 Juergen gave a

[Xen-devel] [PATCH for-4.11 v3 1/2] Add Designated Reviewer (R:) to MAINTAINERS file and add support for it in get_maintainer.pl

2018-05-01 Thread Lars Kurth
The syntax has been copied from the Linux Maintainers file. I moved the following Linux get_maintainer.pl patches to Xen, fixing up some merge issues (and a bug). The get_maintainer.pl changes were based on the following git commits *

[Xen-devel] [PATCH for-4.11 v3 2/2] Add Brian Woods as Designated reviewer to AMD IOMMU and AMD SVM

2018-05-01 Thread Lars Kurth
This was discussed in an IRC discussion post the April x86 meeting. On 27/4/18 Juergen gave a RAB via IRC Cc: Lars Kurth Cc: Andrew Cooper Cc: George Dunlap Cc: Ian Jackson Cc: Jan

Re: [Xen-devel] [PATCH 4/4] xen/PVH: Remove reserved entry in PVH GDT

2018-05-01 Thread Roger Pau Monné
On Mon, Apr 30, 2018 at 12:23:39PM -0400, Boris Ostrovsky wrote: > And without it we can't use _BOOT_XX macros any longer so define new ones. Not being that familiar with Linux internals I'm not sure I see the benefit of this. Isn't there a risk that some other code is going to use the __BOOT_XX

Re: [Xen-devel] Should PV frontend drivers trust the backends?

2018-05-01 Thread Paul Durrant
> -Original Message- > From: Marek Marczykowski-Górecki > [mailto:marma...@invisiblethingslab.com] > Sent: 30 April 2018 18:33 > To: Oleksandr Andrushchenko > Cc: Paul Durrant ; 'Juergen Gross' > ; xen-devel

Re: [Xen-devel] [PATCH 1/4] xen/PVH: Replace GDT_ENTRY with explicit constant

2018-05-01 Thread Roger Pau Monné
On Mon, Apr 30, 2018 at 02:07:43PM -0400, Boris Ostrovsky wrote: > On 04/30/2018 12:57 PM, Roger Pau Monné wrote: > > On Mon, Apr 30, 2018 at 12:23:36PM -0400, Boris Ostrovsky wrote: > >> Latest binutils release (2.29.1) will no longer allow proper computation > >> of GDT entries on 32-bits, with

[Xen-devel] [qemu-mainline test] 122516: regressions - FAIL

2018-05-01 Thread osstest service owner
flight 122516 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/122516/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 16 guest-localmigrate/x10 fail REGR. vs.