[Xen-devel] [xen-4.6-testing test] 124881: tolerable FAIL - PUSHED

2018-07-02 Thread osstest service owner
flight 124881 xen-4.6-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/124881/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-xtf-amd64-amd64-1 50 xtf/test-hvm64-lbr-tsx-vmentry fail like 124292 test-xtf-amd64-amd64-5 50

[Xen-devel] [PATCH 1/2] xen/xsm: Introduce new boot parameter xsm

2018-07-02 Thread Xin Li
Introduce new boot parameter xsm to choose which xsm module is enabled, and set default to dummy. Signed-off-by: Xin Li --- CC: Daniel De Graaf CC: George Dunlap CC: Jan Beulich CC: Konrad Rzeszutek Wilk CC: Stefano Stabellini CC: Tim Deegan CC: Wei Liu CC: Sergey Dyasli CC: Andrew

[Xen-devel] [PATCH 2/2] xen/xsm: Add new SILO mode for XSM

2018-07-02 Thread Xin Li
When SILO is enabled, there would be no page-sharing or event notifications between unprivileged VMs (no grant tables or event channels). Signed-off-by: Xin Li --- CC: Daniel De Graaf CC: George Dunlap CC: Jan Beulich CC: Konrad Rzeszutek Wilk CC: Stefano Stabellini CC: Tim Deegan CC: Wei

[Xen-devel] [xen-4.7-testing test] 124880: regressions - FAIL

2018-07-02 Thread osstest service owner
flight 124880 xen-4.7-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/124880/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-xtf-amd64-amd64-5 50 xtf/test-hvm64-lbr-tsx-vmentry fail REGR. vs. 124203 Tests which

Re: [Xen-devel] [PATCH v6 11/13] xen: support the Null scheduler

2018-07-02 Thread Stefano Stabellini
On Mon, 2 Jul 2018, Julien Grall wrote: > Hi, > > On 02/07/2018 19:24, Stefano Stabellini wrote: > > On Mon, 2 Jul 2018, Julien Grall wrote: > > > Hi Stefano, > > > > > > On 06/29/2018 07:38 PM, Stefano Stabellini wrote: > > > > On Thu, 28 Jun 2018, Roger Pau Monné wrote: > > > > > On Thu, Jun

Re: [Xen-devel] [PATCH RFC 02/15] xen/arm: move a few guest related #defines to public/arch-arm.h

2018-07-02 Thread Stefano Stabellini
On Mon, 2 Jul 2018, Julien Grall wrote: > Hi, > > On 02/07/2018 21:37, Stefano Stabellini wrote: > > On Fri, 15 Jun 2018, Julien Grall wrote: > > > Hi Stefano, > > > > > > On 06/14/2018 10:15 PM, Stefano Stabellini wrote: > > > > On Thu, 14 Jun 2018, Julien Grall wrote: > > > > > On 13/06/18

Re: [Xen-devel] [PATCH RFC 03/15] xen/arm: extend device tree based multiboot protocol

2018-07-02 Thread Stefano Stabellini
On Thu, 14 Jun 2018, Julien Grall wrote: > Hi Stefano, > > On 13/06/18 23:15, Stefano Stabellini wrote: > > Extend the existing device tree based multiboot protocol to include > > information regarding other domUs to boot. > > > > Signed-off-by: Stefano Stabellini > > --- > >

Re: [Xen-devel] [PATCH RFC 02/15] xen/arm: move a few guest related #defines to public/arch-arm.h

2018-07-02 Thread Julien Grall
Hi, On 02/07/2018 21:37, Stefano Stabellini wrote: On Fri, 15 Jun 2018, Julien Grall wrote: Hi Stefano, On 06/14/2018 10:15 PM, Stefano Stabellini wrote: On Thu, 14 Jun 2018, Julien Grall wrote: On 13/06/18 23:15, Stefano Stabellini wrote: Move a few constants defined by libxl_arm.c to

Re: [Xen-devel] [PATCH v6 11/13] xen: support the Null scheduler

2018-07-02 Thread Julien Grall
Hi, On 02/07/2018 19:24, Stefano Stabellini wrote: On Mon, 2 Jul 2018, Julien Grall wrote: Hi Stefano, On 06/29/2018 07:38 PM, Stefano Stabellini wrote: On Thu, 28 Jun 2018, Roger Pau Monné wrote: On Thu, Jun 28, 2018 at 09:27:08AM +0200, Dario Faggioli wrote: On Thu, 2018-06-14 at 13:20

Re: [Xen-devel] [PATCH] console: avoid printing no or null time stamps

2018-07-02 Thread Doug Goldstein
On Mon, Jul 02, 2018 at 02:47:42PM +0100, Julien Grall wrote: > On 06/26/2018 10:03 AM, Jan Beulich wrote: > > > > > On 26.06.18 at 10:43, wrote: > > > On 26/06/18 08:24, Jan Beulich wrote: > > > > @@ -698,26 +701,30 @@ static void printk_start_of_line(const c > > > >case TSM_DATE_MS: > >

[Xen-devel] [adhoc test] 124915: tolerable all pass

2018-07-02 Thread iwj
[adhoc adhoc] <2testing.git master /dev/pts/2> harness c14980b: Debian preseed: Disable security archive for jessie a... 124915: tolerable all pass flight 124915 xen-unstable adhoc [adhoc] http://logs.test-lab.xenproject.org/osstest/logs/124915/ Failures :-/ but no regressions. Tests which did

Re: [Xen-devel] [PATCH v6 11/13] xen: support the Null scheduler

2018-07-02 Thread Stefano Stabellini
On Mon, 2 Jul 2018, Julien Grall wrote: > Hi Stefano, > > On 06/29/2018 07:38 PM, Stefano Stabellini wrote: > > On Thu, 28 Jun 2018, Roger Pau Monné wrote: > > > On Thu, Jun 28, 2018 at 09:27:08AM +0200, Dario Faggioli wrote: > > > > On Thu, 2018-06-14 at 13:20 -0700, Stefano Stabellini wrote: >

Re: [Xen-devel] [Notes for xen summit 2018 design session] Process changes: is the 6 monthly release Cadence too short, Security Process, ...

2018-07-02 Thread Lars Kurth
Non-html version: apologies Lars From: Lars Kurth Date: Monday, 2 July 2018 at 19:00 To: xen-devel Cc: "committ...@xenproject.org" , Rich Persaud , Doug Goldstein , "advisory-bo...@lists.xenproject.org" Subject: [Notes for xen summit 2018 design session] Process changes: is the 6 monthly

[Xen-devel] [Notes for xen summit 2018 design session] Process changes: is the 6 monthly release Cadence too short, Security Process, ...

2018-07-02 Thread Lars Kurth
# Topics to discuss ### Release Cadence 2 years ago, we moved to a 6 monthly release cadence. The idea was to help companies getting features into Xen in a more predictable way. This appears not to have worked. At the same time, the number of releases is creating problems for the security

Re: [Xen-devel] [PATCH v12 09/11] x86/tsc: prepare for early sched_clock

2018-07-02 Thread Konrad Rzeszutek Wilk
On Fri, Jun 29, 2018 at 09:30:10AM +0200, Thomas Gleixner wrote: > On Thu, 28 Jun 2018, Pavel Tatashin wrote: > > On Thu, Jun 28, 2018 at 11:23 AM Thomas Gleixner wrote: > > Hi Thomas, > > > > In addition to above, we have xen hvm: > > > > setup_arch() > > ... > >

Re: [Xen-devel] [PATCH RFC] tools/libxl: Switch Arm guest type to PVH

2018-07-02 Thread Stefano Stabellini
On Mon, 2 Jul 2018, Julien Grall wrote: > On 06/26/2018 07:49 AM, Roger Pau Monné wrote: > > On Mon, Jun 25, 2018 at 05:39:12PM +0100, Ian Jackson wrote: > > > Roger Pau Monné writes ("Re: [PATCH RFC] tools/libxl: Switch Arm guest > > > type to PVH"): > > > > IMO I would remove the 'type' option

[Xen-devel] [linux-4.9 test] 124877: regressions - trouble: blocked/broken/fail/pass

2018-07-02 Thread osstest service owner
flight 124877 linux-4.9 real [real] http://logs.test-lab.xenproject.org/osstest/logs/124877/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl broken test-arm64-arm64-xl 4

[Xen-devel] [OSSTEST PATCH 6/5] PDU::ipmi_try: New method

2018-07-02 Thread Ian Jackson
For power on, this is just like ipmi. For power off, it doesn't mind errors (although it has three attempts). This is useful when combined with pdu power: if the chassis power is already off, ipmi will fail. If the ipmi operation does fail, then the chassing pdu power operation will do the job.

[Xen-devel] [OSSTEST PATCH 4/5] PowerMethod: New pause functionality

2018-07-02 Thread Ian Jackson
And, an abbreviation for invoking it: just writing numbers (or / pair of numbers). Signed-off-by: Ian Jackson --- Osstest/PDU/pause.pm | 49 + Osstest/TestSupport.pm | 3 +++ 2 files changed, 52 insertions(+) create mode 100644

[Xen-devel] [OSSTEST PATCH 1/5] PDU::ipmi: Do not return until the power state has changed

2018-07-02 Thread Ian Jackson
Signed-off-by: Ian Jackson --- Osstest/PDU/ipmi.pm | 26 ++ 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/Osstest/PDU/ipmi.pm b/Osstest/PDU/ipmi.pm index bff1143..0cbc5b9 100644 --- a/Osstest/PDU/ipmi.pm +++ b/Osstest/PDU/ipmi.pm @@ -49,19 +49,29 @@ sub

[Xen-devel] [OSSTEST PATCH 3/5] PowerMethod: New "nest" psuedo-method

2018-07-02 Thread Ian Jackson
If specified as the first method, it means to reverse the order when powering off. There don't seem to be any docs for PowerMethod, so I have not documented this right now. Signed-off-by: Ian Jackson --- Osstest/TestSupport.pm | 13 +++-- 1 file changed, 11 insertions(+), 2

[Xen-devel] [OSSTEST PATCH 2/5] PDU::ipmi: Better username/password configuration

2018-07-02 Thread Ian Jackson
This can now come from host properties, or failing that we use ADMIN/ADMIN which seems common. No functional change with working existing configs. Signed-off-by: Ian Jackson --- Osstest/PDU/ipmi.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Osstest/PDU/ipmi.pm b/Osstest/PDU/ipmi.pm

[Xen-devel] [OSSTEST PATCH 0/5] Support for PDU *and* IPMI

2018-07-02 Thread Ian Jackson
From: Ian Jackson We have been having trouble with our PDU ports: relays are getting stuck. This is affecting a distressing variety of machines and both our PDUs. We have a theory the relays will work a lot better if we do not open and close them under the load of the main system. Deployment

[Xen-devel] [qemu-upstream-4.10-testing test] 124889: trouble: blocked/broken/fail/pass

2018-07-02 Thread osstest service owner
flight 124889 qemu-upstream-4.10-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/124889/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-pvopsbroken

Re: [Xen-devel] [PATCH v3 5/6] vpt: add support for level interrupts

2018-07-02 Thread Roger Pau Monné
On Mon, Jul 02, 2018 at 09:09:31AM -0600, Jan Beulich wrote: > >>> On 02.07.18 at 16:54, wrote: > > Ping? > > I don't understand: There's no open question in the quoted mail. It's more of a refute of your argument about assert of level triggered interrupts not being meaningful if the interrupt

[Xen-devel] [PATCH v2 7/7] xen/arm: setup: Move in init code only used at boot in setup.c

2018-07-02 Thread Julien Grall
Some of the functions implemented in setup.c are only used at boot but not yet marked as such. Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini --- Changes in v2: - Add Stefano's reviewed-by --- xen/arch/arm/setup.c | 10 +- 1 file changed, 5 insertions(+), 5

[Xen-devel] [PATCH v2 5/7] xen: Don't build libelf for Arm

2018-07-02 Thread Julien Grall
Now that ELF support has been dropped to boot Dom0, no-one is using libelf within the hypervisor. Introduce a config option to select libelf on x86 and keep unselected for Arm. Signed-off-by: Julien Grall --- Changes in v2: - Rename HAS_ELF to NEEDS_LIBELF --- xen/arch/x86/Kconfig

[Xen-devel] [PATCH v2 2/7] xen/arm: domain_build: Move in init all code/data of domain_build.c

2018-07-02 Thread Julien Grall
The file domain_build.c only contains code/data used during the initialization. So move everything to init and mark the file as such. Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini --- Changes in v2: - Add Stefano's reviewed-by --- xen/arch/arm/Makefile | 2 +-

[Xen-devel] [PATCH v2 1/7] xen/arm: Remove the variable dom0_11_mapping and open-code the value

2018-07-02 Thread Julien Grall
Dom0 (aka hardware domain on Arm) is always direct mapped. Rather than using a global variable to store a const, directly open-code it or replace the use with is_domain_direct_mapped(...) macros. This will also help a follow-up patch to move all domain_build.c in init. Signed-off-by: Julien

[Xen-devel] [PATCH v2 4/7] xen/arm: Drop support for loading ELF Dom0 kernel

2018-07-02 Thread Julien Grall
The code has been around since the beginning of Xen Arm. However, I am not aware of any user and the code is pretty bogus: 1) It is assuming virtual address == physical address. 2) The cache is not cleaned after the Image is loaded but the Image is started with Cache disabled. 3)

[Xen-devel] [PATCH v2 3/7] xen/arm: kernel: Move in init all the code/data of kernel.c

2018-07-02 Thread Julien Grall
The file kernel.c only contains code/data used during the initialization. So move everything to init and mark the file as such. Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini --- Changes in v2: - Add Stefano's reviewed-by --- xen/arch/arm/Makefile | 2 +-

[Xen-devel] [PATCH v2 0/7] xen/arm: Shrink down Xen on Arm

2018-07-02 Thread Julien Grall
Hi all, This series removes unused code from Xen and also move some part under __init if only used during boot. The major change of this series is removing support for libelf in Xen (see patch #4 and #5). Cheers, Julien Grall (7): xen/arm: Remove the variable dom0_11_mapping and open-code

Re: [Xen-devel] [PATCH for-4.11 0/2] MAINTAINERS cleanup

2018-07-02 Thread Julien Grall
Hi Lars, It looks like this series has never been merged. Do you know that state of it? The first patch is going to avoid contributors to CC both xen.org and xenproject.org if they follow the script add_maintainers.pl. This was pointed out by Jan on one of the series I sent. Cheers, On

Re: [Xen-devel] [PATCH RFC] tools/libxl: Switch Arm guest type to PVH

2018-07-02 Thread Wei Liu
On Mon, Jul 02, 2018 at 03:13:38PM +0100, Julien Grall wrote: > > > On 06/26/2018 07:49 AM, Roger Pau Monné wrote: > > On Mon, Jun 25, 2018 at 05:39:12PM +0100, Ian Jackson wrote: > > > Roger Pau Monné writes ("Re: [PATCH RFC] tools/libxl: Switch Arm guest > > > type to PVH"): > > > > IMO I

[Xen-devel] [ovmf test] 124891: regressions - FAIL

2018-07-02 Thread osstest service owner
flight 124891 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/124891/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 124618 version targeted for

Re: [Xen-devel] [PATCH v3 5/6] vpt: add support for level interrupts

2018-07-02 Thread Jan Beulich
>>> On 02.07.18 at 16:54, wrote: > Ping? I don't understand: There's no open question in the quoted mail. Jan > On Mon, Jun 25, 2018 at 01:19:19PM +0200, Roger Pau Monné wrote: >> On Fri, Jun 22, 2018 at 08:23:02AM -0600, Jan Beulich wrote: >> > >>> On 08.06.18 at 17:07, wrote: >> > > @@

Re: [Xen-devel] [PATCH 5/7] xen: Don't build libelf for Arm

2018-07-02 Thread Julien Grall
Hi Jan, On 06/06/2018 10:06 AM, Jan Beulich wrote: On 05.06.18 at 19:12, wrote: --- a/xen/common/Kconfig +++ b/xen/common/Kconfig @@ -17,6 +17,9 @@ config HAS_ALTERNATIVE config HAS_DEVICE_TREE bool +config HAS_ELF +bool + HAS_LIBELF (or NEEDS_LIBELF) would seem better to

Re: [Xen-devel] [Notes for xen summit 2018 design session] PCI pass-through with de-privileged QEMU

2018-07-02 Thread Konrad Rzeszutek Wilk
On Mon, Jul 02, 2018 at 02:04:45PM +, Lars Kurth wrote: > This is a session hosted by Xin Li from Citrix on PCI-passthrough in a > deprivleged QEMU. Including Elena as she did a patch for this (so that any PCI operation does not require root access). > > (Went over key points of QEMU

Re: [Xen-devel] [PATCH v3 5/6] vpt: add support for level interrupts

2018-07-02 Thread Roger Pau Monné
Ping? On Mon, Jun 25, 2018 at 01:19:19PM +0200, Roger Pau Monné wrote: > On Fri, Jun 22, 2018 at 08:23:02AM -0600, Jan Beulich wrote: > > >>> On 08.06.18 at 17:07, wrote: > > > @@ -316,7 +317,9 @@ int pt_update_irq(struct vcpu *v) > > > if ( pt->pending_intr_nr ) > > > { > > >

[Xen-devel] [xen-unstable-smoke test] 124916: tolerable all pass - PUSHED

2018-07-02 Thread osstest service owner
flight 124916 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/124916/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [Xen-devel] [PATCH 06/10] vpci/header: add teardown cleanup

2018-07-02 Thread Roger Pau Monné
On Mon, Jul 02, 2018 at 03:30:19PM +0100, Wei Liu wrote: > On Mon, Jul 02, 2018 at 10:04:30AM +0200, Roger Pau Monné wrote: > > On Fri, Jun 29, 2018 at 12:15:34PM +0100, Wei Liu wrote: > > > On Wed, Jun 20, 2018 at 04:42:30PM +0200, Roger Pau Monne wrote: > > > > In order to unmap the BARs > > > >

Re: [Xen-devel] [PATCH] x86/Xen: further refine add_preferred_console() invocations

2018-07-02 Thread Juergen Gross
On 25/06/18 12:45, Jan Beulich wrote: > As the sequence of invocations matters, add "tty" only after "hvc" when > a VGA console is available (which is often the case for Dom0, but hardly > ever for DomU). > > Signed-off-by: Jan Beulich Reviewed-by: Juergen Gross Juergen

Re: [Xen-devel] [PATCH 06/10] vpci/header: add teardown cleanup

2018-07-02 Thread Wei Liu
On Mon, Jul 02, 2018 at 10:04:30AM +0200, Roger Pau Monné wrote: > On Fri, Jun 29, 2018 at 12:15:34PM +0100, Wei Liu wrote: > > On Wed, Jun 20, 2018 at 04:42:30PM +0200, Roger Pau Monne wrote: > > > In order to unmap the BARs > > > > > > Signed-off-by: Roger Pau Monné > > > --- > > > Cc: Andrew

Re: [Xen-devel] PCI Pass-through / Config Space emulation for ARM64

2018-07-02 Thread Roger Pau Monné
On Mon, Jul 02, 2018 at 04:16:05PM +0530, Manish Jaggi wrote: > Hi All, > > PCI-PT and PCI config space emulation have been in discussion for quite a > long time. > We had started some work on this in past and in LEG-XEN but that didnt go > far and the group is closed. > > I believe that PCI-PT

[Xen-devel] [Notes for xen summit 2018 design session] Reworking x86 Xen, current status and future plan

2018-07-02 Thread Lars Kurth
Thank you to Florian from NEC for writing these up. They are incomplete,  because we only realized after some time that we didn't have anybody  taking notes. If anyone remembers the earlier parts, please augment ## PV shim got accelerated because of meltdown. was considered for short time to be 

Re: [Xen-devel] [PATCH RFC] tools/libxl: Switch Arm guest type to PVH

2018-07-02 Thread Julien Grall
On 06/26/2018 07:49 AM, Roger Pau Monné wrote: On Mon, Jun 25, 2018 at 05:39:12PM +0100, Ian Jackson wrote: Roger Pau Monné writes ("Re: [PATCH RFC] tools/libxl: Switch Arm guest type to PVH"): IMO I would remove the 'type' option from xl.cfg (so that it's basically ignored) in the ARM case

Re: [Xen-devel] [PATCH 04/10] vpci/msix: add teardown cleanup

2018-07-02 Thread Roger Pau Monné
On Mon, Jul 02, 2018 at 03:07:56PM +0100, Wei Liu wrote: > On Mon, Jul 02, 2018 at 04:02:44PM +0200, Roger Pau Monné wrote: > > I'm not sure I understand the question. You cannot free specific > > entries, they are part of the msix struct (you have to free the whole > > struct, not specific

Re: [Xen-devel] [PATCH 04/10] vpci/msix: add teardown cleanup

2018-07-02 Thread Wei Liu
On Mon, Jul 02, 2018 at 04:02:44PM +0200, Roger Pau Monné wrote: > On Mon, Jul 02, 2018 at 02:55:37PM +0100, Wei Liu wrote: > > On Mon, Jul 02, 2018 at 09:54:20AM +0200, Roger Pau Monné wrote: > > > On Fri, Jun 29, 2018 at 11:52:07AM +0100, Wei Liu wrote: > > > > On Wed, Jun 20, 2018 at 04:42:28PM

[Xen-devel] [Notes for xen summit 2018 design session] PCI pass-through with de-privileged QEMU

2018-07-02 Thread Lars Kurth
This is a session hosted by Xin Li from Citrix on PCI-passthrough in a deprivleged QEMU. (Went over key points of QEMU de-priv talk - see https://www.slideshare.net/xen_com_mgr/xpdds18-qemu-and-xen-reducing-the-attack-surface-paul-durrant-citrix) Problem is syses nodes need to be opened.

Re: [Xen-devel] [PATCH 04/10] vpci/msix: add teardown cleanup

2018-07-02 Thread Roger Pau Monné
On Mon, Jul 02, 2018 at 02:55:37PM +0100, Wei Liu wrote: > On Mon, Jul 02, 2018 at 09:54:20AM +0200, Roger Pau Monné wrote: > > On Fri, Jun 29, 2018 at 11:52:07AM +0100, Wei Liu wrote: > > > On Wed, Jun 20, 2018 at 04:42:28PM +0200, Roger Pau Monne wrote: > > > > So that interrupts are properly

Re: [Xen-devel] [PATCH] compat-ioctl/Xen: support at least some IOCTLs of evtchn and privcmd

2018-07-02 Thread Juergen Gross
On 25/06/18 12:41, Jan Beulich wrote: > While this is only a start (IOCTL_PRIVCMD_MMAP* and IOCTL_PRIVCMD_DM_OP > require more work), it at least allows some simple operations (like > "xl dmesg") which have always been available on XenoLinux to work again > with a 64-bit kernel underneath a 32-bit

Re: [Xen-devel] [PATCH] console: avoid printing no or null time stamps

2018-07-02 Thread Julien Grall
Hi, On 07/02/2018 02:47 PM, Julien Grall wrote: On 06/26/2018 10:03 AM, Jan Beulich wrote: On 26.06.18 at 10:43, wrote: On 26/06/18 08:24, Jan Beulich wrote: During early boot timestamps aren't very useful, as they're all zero (in "boot" mode) or absent altogether (in "date" and "datems"

[Xen-devel] [Notes for xen summit 2018 design session ] Testing/Building with Docker/GitLab

2018-07-02 Thread Lars Kurth
The notes were taken by Florian Schmidt of NEC. Thank you This has some actions on: Lars K, Xudong H, Doug G, Andrew C and Andrii A (who was not present) We should certainly try and make progress on this as it has the potential to make life for code reviewers easier: it may be worth to organize

Re: [Xen-devel] [PATCH 04/10] vpci/msix: add teardown cleanup

2018-07-02 Thread Wei Liu
On Mon, Jul 02, 2018 at 09:54:20AM +0200, Roger Pau Monné wrote: > On Fri, Jun 29, 2018 at 11:52:07AM +0100, Wei Liu wrote: > > On Wed, Jun 20, 2018 at 04:42:28PM +0200, Roger Pau Monne wrote: > > > So that interrupts are properly freed. > > > > > > Signed-off-by: Roger Pau Monné > > > --- > > >

Re: [Xen-devel] [PATCH] x86/Xen: mark xen_setup_gdt() __init

2018-07-02 Thread Juergen Gross
On 25/06/18 12:34, Jan Beulich wrote: > Its only caller is __init, so to avoid section mismatch warnings when a > compiler decides to not inline the function marke this function so as > well. Take the opportunity and also make the function actually use its > argument: The sole caller passes in

Re: [Xen-devel] [PATCH RESEND] xen/mcelog: eliminate redundant setting of interface version

2018-07-02 Thread Juergen Gross
On 25/06/18 12:19, Jan Beulich wrote: > This already gets done in HYPERVISOR_mca(). > > Signed-off-by: Jan Beulich Reviewed-by: Juergen Gross Juergen ___ Xen-devel mailing list Xen-devel@lists.xenproject.org

Re: [Xen-devel] [PATCH] console: avoid printing no or null time stamps

2018-07-02 Thread Julien Grall
On 06/26/2018 10:03 AM, Jan Beulich wrote: On 26.06.18 at 10:43, wrote: On 26/06/18 08:24, Jan Beulich wrote: During early boot timestamps aren't very useful, as they're all zero (in "boot" mode) or absent altogether (in "date" and "datems" modes). Log "boot" format timestamps when the date

Re: [Xen-devel] [PATCH 1/3] tools/libxc: Drop xc_cpuid_to_str()

2018-07-02 Thread Roger Pau Monné
On Mon, Jul 02, 2018 at 03:36:42PM +0200, Roger Pau Monné wrote: > On Mon, Jul 02, 2018 at 01:15:10PM +0100, Andrew Cooper wrote: > > On 02/07/18 11:41, Roger Pau Monné wrote: > > > On Mon, Jul 02, 2018 at 10:57:25AM +0100, Andrew Cooper wrote: > > >> This helper appears to have been introduced 10

Re: [Xen-devel] [PATCH 1/3] tools/libxc: Drop xc_cpuid_to_str()

2018-07-02 Thread Roger Pau Monné
On Mon, Jul 02, 2018 at 01:15:10PM +0100, Andrew Cooper wrote: > On 02/07/18 11:41, Roger Pau Monné wrote: > > On Mon, Jul 02, 2018 at 10:57:25AM +0100, Andrew Cooper wrote: > >> This helper appears to have been introduced 10 years ago by c/s 5f14a87ceb > >> "x86, hvm: Guest CPUID configuration"

Re: [Xen-devel] [PATCH v9 07/11] x86/hvm: Introduce viridian_save_vcpu_ctxt_one() func

2018-07-02 Thread Jan Beulich
>>> On 02.07.18 at 15:15, wrote: > On Lu, 2018-07-02 at 09:38 +, Paul Durrant wrote: >> > From: Alexandru Isaila [mailto:aisa...@bitdefender.com] >> > Sent: 28 June 2018 10:26 >> > --- a/xen/arch/x86/hvm/viridian.c >> > +++ b/xen/arch/x86/hvm/viridian.c >> > @@ -1026,20 +1026,30 @@ static int

Re: [Xen-devel] [PATCH v9 07/11] x86/hvm: Introduce viridian_save_vcpu_ctxt_one() func

2018-07-02 Thread Alexandru Stefan ISAILA
On Lu, 2018-07-02 at 09:38 +, Paul Durrant wrote: > > > > -Original Message- > > From: Alexandru Isaila [mailto:aisa...@bitdefender.com] > > Sent: 28 June 2018 10:26 > > To: xen-de...@lists.xen.org > > Cc: Ian Jackson ; Wei Liu > com>; > > jbeul...@suse.com; Andrew Cooper ; Paul > >

Re: [Xen-devel] [PATCH v4 0/9] xen: dma-buf support for grant device

2018-07-02 Thread Oleksandr Andrushchenko
On 07/02/2018 11:20 AM, Juergen Gross wrote: On 02/07/18 09:10, Oleksandr Andrushchenko wrote: Hello, Boris, Juergen! Do you think I can re-base the series (which already has all required R-b's from Xen community) onto the latest kernel with API changes to patches 5 (of_dma_configure) and 8

Re: [Xen-devel] [PATCH v2 0/6] libxl: create standalone vkb device

2018-07-02 Thread Oleksandr Grytsov
On Tue, Jun 12, 2018 at 4:31 PM, Oleksandr Grytsov wrote: > From: Oleksandr Grytsov > > Changes since initial: > * id field is changed to unique_id in libxl_device_vkb to be comply >with protocol; > * use XENKBD_FIELD_... defines from protocol to address xen store entries >and fields

Re: [Xen-devel] [PATCH 0/1] libxl/xl: rename id to unique-id in vdispl xen store

2018-07-02 Thread Oleksandr Grytsov
On Tue, Jun 12, 2018 at 6:40 PM, Oleksandr Grytsov wrote: > From: Oleksandr Grytsov > > As new version of the display protocol introduces unique-id variable, it > needs > to be changed in libxl/xl. This patchset renames it in the xen store and in > display device structures. Also it uses

Re: [Xen-devel] [PATCH v3 0/5] libxl: add PV sound device

2018-07-02 Thread Oleksandr Grytsov
On Fri, Jun 15, 2018 at 1:15 PM, Oleksandr Grytsov wrote: > From: Oleksandr Grytsov > > This patch set adds PV sound device support to xl.cfg and xl. > See sndif.h for protocol implementation details. > > Changes since v2: > * address comments > * rename libxl_vsnd_stream.id ->

Re: [Xen-devel] [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-07-02 Thread Michal Hocko
On Mon 02-07-18 14:39:50, Christian König wrote: [...] > Not wanting to block something as important as this, so feel free to add an > Acked-by: Christian König to the patch. Thanks a lot! > Let's rather face the next topic: Any idea how to runtime test this? This is a good question indeed.

[Xen-devel] [PATCH v3] x86/mm: Add mem access rights to NPT

2018-07-02 Thread Alexandru Isaila
From: Isaila Alexandru This patch adds access rights for the NPT pages. The access rights are saved in a radix tree with the root saved in p2m_domain. The rights are manipulated through p2m_set_access() and p2m_get_access() functions. The patch follows the ept logic. Note: It was tested with

[Xen-devel] [PATCH v2 2/3] x86/msr: Drop {MISC_ENABLES, PLATFORM_INFO}.available

2018-07-02 Thread Andrew Cooper
These MSRs are non-architectural and the available booleans were used in lieu of an architectural signal of availability. However, in hindsight, the additional booleans make toolstack MSR interactions more complicated. The MSRs are unconditionally available to HVM guests, but currently for PV

Re: [Xen-devel] [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-07-02 Thread Christian König
Am 02.07.2018 um 14:35 schrieb Michal Hocko: On Mon 02-07-18 14:24:29, Christian König wrote: Am 02.07.2018 um 14:20 schrieb Michal Hocko: On Mon 02-07-18 14:13:42, Christian König wrote: Am 02.07.2018 um 13:54 schrieb Michal Hocko: On Mon 02-07-18 11:14:58, Christian König wrote: Am

Re: [Xen-devel] [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-07-02 Thread Michal Hocko
On Mon 02-07-18 14:24:29, Christian König wrote: > Am 02.07.2018 um 14:20 schrieb Michal Hocko: > > On Mon 02-07-18 14:13:42, Christian König wrote: > > > Am 02.07.2018 um 13:54 schrieb Michal Hocko: > > > > On Mon 02-07-18 11:14:58, Christian König wrote: > > > > > Am 27.06.2018 um 09:44 schrieb

Re: [Xen-devel] [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-07-02 Thread Christian König
Am 02.07.2018 um 14:20 schrieb Michal Hocko: On Mon 02-07-18 14:13:42, Christian König wrote: Am 02.07.2018 um 13:54 schrieb Michal Hocko: On Mon 02-07-18 11:14:58, Christian König wrote: Am 27.06.2018 um 09:44 schrieb Michal Hocko: This is the v2 of RFC based on the feedback I've received

Re: [Xen-devel] [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-07-02 Thread Michal Hocko
On Mon 02-07-18 14:13:42, Christian König wrote: > Am 02.07.2018 um 13:54 schrieb Michal Hocko: > > On Mon 02-07-18 11:14:58, Christian König wrote: > > > Am 27.06.2018 um 09:44 schrieb Michal Hocko: > > > > This is the v2 of RFC based on the feedback I've received so far. The > > > > code even

Re: [Xen-devel] [PATCH 1/3] tools/libxc: Drop xc_cpuid_to_str()

2018-07-02 Thread Andrew Cooper
On 02/07/18 11:41, Roger Pau Monné wrote: > On Mon, Jul 02, 2018 at 10:57:25AM +0100, Andrew Cooper wrote: >> This helper appears to have been introduced 10 years ago by c/s 5f14a87ceb >> "x86, hvm: Guest CPUID configuration" and never had any users at all. >> >> alloc_str() is actually an

Re: [Xen-devel] [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-07-02 Thread Christian König
Am 02.07.2018 um 13:54 schrieb Michal Hocko: On Mon 02-07-18 11:14:58, Christian König wrote: Am 27.06.2018 um 09:44 schrieb Michal Hocko: This is the v2 of RFC based on the feedback I've received so far. The code even compiles as a bonus ;) I haven't runtime tested it yet, mostly because I

Re: [Xen-devel] [PATCH 2/3] x86/msr: Drop {MISC_ENABLES, PLATFORM_INFO}.available

2018-07-02 Thread Roger Pau Monné
On Mon, Jul 02, 2018 at 10:57:26AM +0100, Andrew Cooper wrote: > These MSRs are non-architectural and the available booleans were used in lieu > of an architectural signal of availability. The MSRs are unconditionally > available to HVM guests, but currently for PV guests, are hidden when CPUID >

Re: [Xen-devel] [PATCH 2/3] x86/msr: Drop {MISC_ENABLES, PLATFORM_INFO}.available

2018-07-02 Thread Andrew Cooper
On 02/07/18 12:27, Jan Beulich wrote: On 02.07.18 at 11:57, wrote: >> These MSRs are non-architectural and the available booleans were used in lieu >> of an architectural signal of availability. The MSRs are unconditionally >> available to HVM guests, but currently for PV guests, are hidden

Re: [Xen-devel] [PATCH v6 11/13] xen: support the Null scheduler

2018-07-02 Thread Julien Grall
Hi Stefano, On 06/29/2018 07:38 PM, Stefano Stabellini wrote: On Thu, 28 Jun 2018, Roger Pau Monné wrote: On Thu, Jun 28, 2018 at 09:27:08AM +0200, Dario Faggioli wrote: On Thu, 2018-06-14 at 13:20 -0700, Stefano Stabellini wrote: On Thu, 14 Jun 2018, Andrew Cooper wrote: On 14/06/18 14:40,

Re: [Xen-devel] [PATCH 3/3] x86/msr: Use the architectural layout for MSR_{MISC_ENABLES, PLATFORM_INFO}

2018-07-02 Thread Jan Beulich
>>> On 02.07.18 at 12:46, wrote: > On Mon, 2018-07-02 at 10:57 +0100, Andrew Cooper wrote: >> This simplifies future interactions with the toolstack, by removing the need >> for per-MSR custom accessors when shuffling data in/out of a policy. >> >> Use a 32bit raw backing integer (for

Re: [Xen-devel] [PATCH] xen: setup pv irq ops vector earlier

2018-07-02 Thread Juergen Gross
On 02/07/18 13:18, Jan Beulich wrote: On 02.07.18 at 12:00, wrote: >> --- a/arch/x86/xen/enlighten_pv.c >> +++ b/arch/x86/xen/enlighten_pv.c >> @@ -1213,6 +1213,7 @@ asmlinkage __visible void __init xen_start_kernel(void) >> pv_info = xen_info; >> pv_init_ops.patch =

[Xen-devel] [xen-4.11-testing test] 124876: trouble: blocked/broken/fail/pass

2018-07-02 Thread osstest service owner
flight 124876 xen-4.11-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/124876/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken Tests which did

Re: [Xen-devel] [PATCH] x86/altp2m: Add a subop for obtaining the mem access of a page

2018-07-02 Thread Razvan Cojocaru
On 07/02/2018 09:34 AM, Jan Beulich wrote: On 29.06.18 at 18:39, wrote: >> On 06/29/2018 06:38 PM, Jan Beulich wrote: >> On 28.06.18 at 15:00, wrote: @@ -4666,6 +4667,23 @@ static int do_altp2m_op( } break; +case

Re: [Xen-devel] [PATCH 3/3] x86/msr: Use the architectural layout for MSR_{MISC_ENABLES, PLATFORM_INFO}

2018-07-02 Thread Sergey Dyasli
On Mon, 2018-07-02 at 10:57 +0100, Andrew Cooper wrote: > This simplifies future interactions with the toolstack, by removing the need > for per-MSR custom accessors when shuffling data in/out of a policy. > > Use a 32bit raw backing integer (for simplicity), and use a bitfield to move > the

[Xen-devel] PCI Pass-through / Config Space emulation for ARM64

2018-07-02 Thread Manish Jaggi
Hi All, PCI-PT and PCI config space emulation have been in discussion for quite a long time. We had started some work on this in past and in LEG-XEN but that didnt go far and the group is closed. I believe that PCI-PT is a feature which would be suitable for not only for servers but for

Re: [Xen-devel] [PATCH 1/3] tools/libxc: Drop xc_cpuid_to_str()

2018-07-02 Thread Roger Pau Monné
On Mon, Jul 02, 2018 at 10:57:25AM +0100, Andrew Cooper wrote: > This helper appears to have been introduced 10 years ago by c/s 5f14a87ceb > "x86, hvm: Guest CPUID configuration" and never had any users at all. > > alloc_str() is actually an opencoded calloc(), and now only has a single >

Re: [Xen-devel] [PATCH 2/3] x86/msr: Drop {MISC_ENABLES, PLATFORM_INFO}.available

2018-07-02 Thread Sergey Dyasli
On Mon, 2018-07-02 at 10:57 +0100, Andrew Cooper wrote: > These MSRs are non-architectural and the available booleans were used in lieu > of an architectural signal of availability. The MSRs are unconditionally > available to HVM guests, but currently for PV guests, are hidden when CPUID >

Re: [Xen-devel] [PATCH 1/4] firmware/seabios: fix build on systems with non GNU toolchains

2018-07-02 Thread Roger Pau Monné
On Mon, Jul 02, 2018 at 10:42:44AM +0100, Wei Liu wrote: > On Mon, Jul 02, 2018 at 11:36:28AM +0200, Roger Pau Monné wrote: > > On Mon, Jul 02, 2018 at 10:32:15AM +0100, Wei Liu wrote: > > > On Mon, Jul 02, 2018 at 10:28:23AM +0200, Roger Pau Monne wrote: > > > [...] > > > > > > > >

Re: [Xen-devel] [PATCH] xen: Plumb an is_priv boolean into domain_create()

2018-07-02 Thread Julien Grall
Hi, On 07/02/2018 10:44 AM, Andrew Cooper wrote: The current mechanism of setting dom0->is_privileged after construction means that the is_control_domain() predicate returns false during construction. In particular, this means that the CPUID Faulting special case in init_domain_msr_policy()

Re: [Xen-devel] [PATCH] xen: Plumb an is_priv boolean into domain_create()

2018-07-02 Thread Roger Pau Monné
On Mon, Jul 02, 2018 at 10:44:47AM +0100, Andrew Cooper wrote: > The current mechanism of setting dom0->is_privileged after construction means > that the is_control_domain() predicate returns false during construction. > > In particular, this means that the CPUID Faulting special case in >

Re: [Xen-devel] [PATCH] xen: Plumb an is_priv boolean into domain_create()

2018-07-02 Thread Andrew Cooper
On 02/07/18 10:57, Jan Beulich wrote: On 02.07.18 at 11:44, wrote: >> The current mechanism of setting dom0->is_privileged after construction means >> that the is_control_domain() predicate returns false during construction. >> >> In particular, this means that the CPUID Faulting special

Re: [Xen-devel] [PATCH] xen: Plumb an is_priv boolean into domain_create()

2018-07-02 Thread Wei Liu
On Mon, Jul 02, 2018 at 10:44:47AM +0100, Andrew Cooper wrote: > The current mechanism of setting dom0->is_privileged after construction means > that the is_control_domain() predicate returns false during construction. > > In particular, this means that the CPUID Faulting special case in >

Re: [Xen-devel] [PATCH 1/3] tools/libxc: Drop xc_cpuid_to_str()

2018-07-02 Thread Wei Liu
On Mon, Jul 02, 2018 at 10:57:25AM +0100, Andrew Cooper wrote: > This helper appears to have been introduced 10 years ago by c/s 5f14a87ceb > "x86, hvm: Guest CPUID configuration" and never had any users at all. > > alloc_str() is actually an opencoded calloc(), and now only has a single >

[Xen-devel] [PATCH] xen: setup pv irq ops vector earlier

2018-07-02 Thread Juergen Gross
Setting pv_irq_ops for Xen PV domains should be done as early as possible in order to support e.g. very early printk() usage. Remove the no longer necessary conditional in xen_init_irq_ops() from PVH V1 times to make clear this is a PV only function. Cc: # 4.14 Signed-off-by: Juergen Gross ---

[Xen-devel] [PATCH] xen: remove global bit from __default_kernel_pte_mask for pv guests

2018-07-02 Thread Juergen Gross
When removing the global bit from __supported_pte_mask do the same for __default_kernel_pte_mask in order to avoid the WARN_ONCE() in check_pgprot() when setting a kernel pte before having called init_mem_mapping(). Cc: # 4.17 Reported-by: Michael Young Signed-off-by: Juergen Gross ---

[Xen-devel] [PATCH 3/3] x86/msr: Use the architectural layout for MSR_{MISC_ENABLES, PLATFORM_INFO}

2018-07-02 Thread Andrew Cooper
This simplifies future interactions with the toolstack, by removing the need for per-MSR custom accessors when shuffling data in/out of a policy. Use a 32bit raw backing integer (for simplicity), and use a bitfield to move the cpuid_faulting field to its appropriate position. Signed-off-by:

Re: [Xen-devel] [PATCH] xen: Plumb an is_priv boolean into domain_create()

2018-07-02 Thread Jan Beulich
>>> On 02.07.18 at 11:44, wrote: > The current mechanism of setting dom0->is_privileged after construction means > that the is_control_domain() predicate returns false during construction. > > In particular, this means that the CPUID Faulting special case in > init_domain_msr_policy() fails to

[Xen-devel] [PATCH 0/3] x86: Further CPUID/MSR cleanup

2018-07-02 Thread Andrew Cooper
This is further cleanup work to help the forthcoming toolstack CPUID/MSR work. Andrew Cooper (3): tools/libxc: Drop xc_cpuid_to_str() x86/msr: Drop {MISC_ENABLES,PLATFORM_INFO}.available x86/msr: Use the architectural layout for MSR_{MISC_ENABLES,PLATFORM_INFO}

[Xen-devel] [PATCH 2/3] x86/msr: Drop {MISC_ENABLES, PLATFORM_INFO}.available

2018-07-02 Thread Andrew Cooper
These MSRs are non-architectural and the available booleans were used in lieu of an architectural signal of availability. The MSRs are unconditionally available to HVM guests, but currently for PV guests, are hidden when CPUID faulting is unavailable. However, in hindsight, the additional

[Xen-devel] [PATCH 1/3] tools/libxc: Drop xc_cpuid_to_str()

2018-07-02 Thread Andrew Cooper
This helper appears to have been introduced 10 years ago by c/s 5f14a87ceb "x86, hvm: Guest CPUID configuration" and never had any users at all. alloc_str() is actually an opencoded calloc(), and now only has a single caller. Use calloc() directly and drop alloc_str(). Signed-off-by: Andrew

[Xen-devel] [distros-debian-sid test] 74929: tolerable FAIL

2018-07-02 Thread Platform Team regression test user
flight 74929 distros-debian-sid real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/74929/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-i386-sid-netboot-pvgrub 10 debian-di-install fail blocked in 74906

[Xen-devel] [PATCH] xen: Plumb an is_priv boolean into domain_create()

2018-07-02 Thread Andrew Cooper
The current mechanism of setting dom0->is_privileged after construction means that the is_control_domain() predicate returns false during construction. In particular, this means that the CPUID Faulting special case in init_domain_msr_policy() fails to take effect. (In actual fact, faulting

  1   2   >