[Xen-devel] [xen-unstable test] 126346: regressions - FAIL

2018-08-22 Thread osstest service owner
flight 126346 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/126346/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 16 guest-start/debianhvm.repeat fail REGR. vs.

[Xen-devel] [linux-4.9 test] 126345: regressions - FAIL

2018-08-22 Thread osstest service owner
flight 126345 linux-4.9 real [real] http://logs.test-lab.xenproject.org/osstest/logs/126345/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-rumprun-amd64 12 guest-startfail REGR. vs. 125183 test-amd64-amd64-xl

Re: [Xen-devel] [PATCH] x86/xen: enable early use of set_fixmap in 32-bit Xen PV guest

2018-08-22 Thread Pasha Tatashin
On Fri, Aug 17, 2018 at 9:41 AM Juergen Gross wrote: > > Commit 7b25b9cb0dad83 ("x86/xen/time: Initialize pv xen time in > init_hypervisor_platform()") moved the mapping of the shared info area > before pagetable_init(). This breaks booting as 32-bit PV guest as the > use of set_fixmap isn't

[Xen-devel] [ovmf baseline-only test] 75106: tolerable FAIL

2018-08-22 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 75106 ovmf real [real] http://osstest.xensource.com/osstest/logs/75106/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-ovmf-amd64 10 debian-hvm-install fail like 75102

[Xen-devel] [distros-debian-squeeze test] 75105: tolerable FAIL

2018-08-22 Thread Platform Team regression test user
flight 75105 distros-debian-squeeze real [real] http://osstest.xensource.com/osstest/logs/75105/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-i386-squeeze-netboot-pygrub 10 debian-di-install fail like 75071

[Xen-devel] [xen-4.10-testing baseline-only test] 75104: regressions - FAIL

2018-08-22 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 75104 xen-4.10-testing real [real] http://osstest.xensource.com/osstest/logs/75104/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-qemut-rhel6hvm-intel 10

[Xen-devel] [linux-linus bisection] complete test-amd64-i386-xl-qemuu-win10-i386

2018-08-22 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-i386-xl-qemuu-win10-i386 testid xen-boot Tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu

[Xen-devel] [ovmf test] 126389: all pass - PUSHED

2018-08-22 Thread osstest service owner
flight 126389 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/126389/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 0442a9a9f42abed9f2e44e63115a3abb0d123459 baseline version: ovmf

[Xen-devel] [libvirt test] 126350: regressions - FAIL

2018-08-22 Thread osstest service owner
flight 126350 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/126350/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 123814 build-amd64-libvirt

Re: [Xen-devel] [xen-4.9-testing test] 126201: regressions - FAIL

2018-08-22 Thread Jim Fehlig
On 08/21/2018 05:14 AM, Jan Beulich wrote: On 21.08.18 at 03:11, wrote: flight 126201 xen-4.9-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/126201/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run:

Re: [Xen-devel] [PATCH v1 6/6] xsm: add tee access policy support

2018-08-22 Thread DeGraaf, Daniel G
> From: Volodymyr Babchuk > Sent: Wednesday, August 22, 2018 10:12 AM > > As we don't want any guest to access limited resources of TEE, we need a way > to control who can work with it. > > Thus, new access vector class "tee" is added with only ony operation "call" > so far. tee framework

Re: [Xen-devel] [PATCH] tools/xentop : replace use of deprecated vwprintw

2018-08-22 Thread Hans van Kranenburg
Hi, On 07/19/2018 08:53 AM, Wei Liu wrote: > On Wed, Jul 18, 2018 at 03:22:17PM -0700, Christopher Clark wrote: >> gcc-8.1 complains: >> >> | xentop.c: In function 'print': >> | xentop.c:304:4: error: 'vwprintw' is deprecated >> [-Werror=deprecated-declarations] >> | vwprintw(stdscr,

[Xen-devel] [linux-linus test] 126310: regressions - FAIL

2018-08-22 Thread osstest service owner
flight 126310 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/126310/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-shadow 7 xen-boot fail REGR. vs. 125898

[Xen-devel] [qemu-mainline test] 126322: tolerable FAIL - PUSHED

2018-08-22 Thread osstest service owner
flight 126322 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/126322/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stopfail like 126244

[Xen-devel] [freebsd-master test] 126376: tolerable FAIL - PUSHED

2018-08-22 Thread osstest service owner
flight 126376 freebsd-master real [real] http://logs.test-lab.xenproject.org/osstest/logs/126376/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: build-amd64-xen-freebsd 7 xen-build-freebsdfail never pass version targeted for testing:

Re: [Xen-devel] [Qemu-devel] [PATCH] RFC: chardev: mark the calls that allow an implicit mux monitor

2018-08-22 Thread Eric Blake
On 08/22/2018 01:02 PM, Marc-André Lureau wrote: This is mostly for readability of the code. Let's make it clear which callers can create an implicit monitor when the chardev is muxed. This will also enforce a safer behaviour, as we don't really support creating monitor anywhere/anytime at the

[Xen-devel] [xen-unstable-smoke test] 126397: tolerable all pass - PUSHED

2018-08-22 Thread osstest service owner
flight 126397 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/126397/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-armhf-armhf-xl

[Xen-devel] [PATCH] RFC: chardev: mark the calls that allow an implicit mux monitor

2018-08-22 Thread Marc-André Lureau
This is mostly for readability of the code. Let's make it clear which callers can create an implicit monitor when the chardev is muxed. This will also enforce a safer behaviour, as we don't really support creating monitor anywhere/anytime at the moment. There are documented cases, such as:

Re: [Xen-devel] [PATCH 2/2] tools/libxl: Switch Arm guest type to PVH

2018-08-22 Thread Julien Grall
Hi Roger, On 22/08/18 16:18, Roger Pau Monné wrote: On Wed, Aug 22, 2018 at 04:00:45PM +0100, Julien Grall wrote: Currently, the toolstack is considering Arm guest always PV. However, they are very similar to PVH because HW virtualization extension are used and QEMU is not started. So switch

Re: [Xen-devel] [PATCH v1 5/6] libxl: create DTS node for OP-TEE if it is enabled

2018-08-22 Thread Julien Grall
Hi, On 22/08/18 15:11, Volodymyr Babchuk wrote: Signed-off-by: Volodymyr Babchuk I am a bit confused. The DT is only here to tell the guest OP-TEE is present. But I don't see anything to tell the hypervisor the guest will use OP-TEE. Cheers, -- Julien Grall

Re: [Xen-devel] [PATCH v1 4/6] optee: add OP-TEE mediator

2018-08-22 Thread Julien Grall
Hi, Please only CC relevant people to the patches. This could be done easily using the new script add_maintainers.pl. On 22/08/18 15:11, Volodymyr Babchuk wrote: Add OP-TEE mediator, so guests can access OP-TEE services. OP-TEE mediator support address translation for DomUs. It tracks

Re: [Xen-devel] [PATCH 12/34] x86/pt: only call some functions for HVM guests

2018-08-22 Thread Wei Liu
On Mon, Aug 20, 2018 at 06:48:58AM -0600, Jan Beulich wrote: > >>> On 17.08.18 at 17:12, wrote: > > According to your earlier patch, has_vlapic() implies is_hvm_domain(), > so if anything is to be moved to the caller, then has_vlapic() (and > is_hvm_domain() would then to be dropped altogether).

Re: [Xen-devel] [PATCH v1 2/6] arm: add generic TEE mediator framework

2018-08-22 Thread Julien Grall
Hi Volodymyr, On 22/08/18 15:11, Volodymyr Babchuk wrote: This patch adds basic framework for TEE mediators. Guests can't talk to TEE directly, we need some entity that will intercept request and decide what to do with them. "TEE mediator" is a such entity. This is how it works: user can build

Re: [Xen-devel] [PATCH v1 5/6] libxl: create DTS node for OP-TEE if it is enabled

2018-08-22 Thread Wei Liu
On Wed, Aug 22, 2018 at 05:11:33PM +0300, Volodymyr Babchuk wrote: > Signed-off-by: Volodymyr Babchuk > --- > tools/libxl/libxl_arm.c | 29 + > tools/libxl/libxl_create.c | 1 + > tools/libxl/libxl_types.idl | 1 + > tools/xl/xl_parse.c | 1 + Please

Re: [Xen-devel] [PATCH v1 1/6] arm: add SMC wrapper that is compatible with SMCCC

2018-08-22 Thread Julien Grall
Hi Volodymyr, On 22/08/18 15:11, Volodymyr Babchuk wrote: Existing SMC wrapper call_smc() allows only 4 parameters and returns only one value. This is enough for existing use in PSCI code, but TEE mediator will need a call that is fully compatible with ARM SMCCC. This patch adds this call for

Re: [Xen-devel] [PATCH 10/34] x86: stub out has_* testing for emulation flags

2018-08-22 Thread Wei Liu
On Mon, Aug 20, 2018 at 06:37:28AM -0600, Jan Beulich wrote: > >>> On 17.08.18 at 17:12, wrote: > > Most are all HVM only. Provide stubs for !CONFIG_HVM. > > > > One exception is PIT emulation, which is available to both PV and HVM. > > > > Signed-off-by: Wei Liu > > --- > >

Re: [Xen-devel] [PATCH] pvshim: introduce a PV shim defconfig

2018-08-22 Thread Wei Liu
On Wed, Aug 22, 2018 at 12:36:55PM +0200, Roger Pau Monne wrote: > In order to build a tailored pvshim-only binary from Xen. Switch the > PV shim build from the tools firmware into using the new defconfig. > > A diff of the .config generated for the pvshim firmware build before > and after this

Re: [Xen-devel] [PATCH 07/34] x86: only call memory_type_changed for HVM guests

2018-08-22 Thread Wei Liu
On Mon, Aug 20, 2018 at 05:57:25AM -0600, Jan Beulich wrote: > >>> On 17.08.18 at 17:12, wrote: > > --- a/xen/arch/x86/domctl.c > > +++ b/xen/arch/x86/domctl.c > > @@ -416,7 +416,7 @@ long arch_do_domctl( > > ret = ioports_permit_access(d, fp, fp + np - 1); > > else > >

Re: [Xen-devel] [PATCH] gnttab/ARM: properly implement gnttab_create_status_page()

2018-08-22 Thread Julien Grall
Hi, On 15/08/18 18:57, Stefano Stabellini wrote: On Wed, 15 Aug 2018, Jan Beulich wrote: Prevent the "BUG_ON(page_get_owner(pg) != d)" in gnttab_unpopulate_status_frames() from triggering. Reported-by: 王磊 Signed-off-by: Jan Beulich --- It looks to me as if this was the only piece missing

Re: [Xen-devel] [PATCH v1 0/4] Renesas Stout board support (R-Car Gen2)

2018-08-22 Thread Oleksandr Tyshchenko
On Wed, Aug 22, 2018 at 6:48 PM, Julien Grall wrote: > On 06/08/18 19:35, Oleksandr Tyshchenko wrote: >> >> Hi, all. > > > Hi, Hi, Julien > > Can you CC relevant people on the cover letter? It would save me time to dig > into my e-mail :). Sure. > >> >> The purpose of this patch series is to

Re: [Xen-devel] [Xen-users] Xen shutdown fails to release DRBD device

2018-08-22 Thread Roger Pau Monné
On Wed, Aug 22, 2018 at 05:39:28PM +0200, Valentin Vidic wrote: > On Wed, Aug 22, 2018 at 03:55:46PM +0200, Valentin Vidic wrote: > > DRBD end for this seems rather simple, it only checks if the > > device->open_cnt is zero. So it would seem like drbd_release > > was not called yet when the

Re: [Xen-devel] [PATCH v1 0/4] Renesas Stout board support (R-Car Gen2)

2018-08-22 Thread Julien Grall
On 06/08/18 19:35, Oleksandr Tyshchenko wrote: Hi, all. Hi, Can you CC relevant people on the cover letter? It would save me time to dig into my e-mail :). The purpose of this patch series is to add required support to be able to run Xen on Renesas Stout board [1] which uses SCIFA

Re: [Xen-devel] [PATCH 00/15] xen/arm: Bunch of clean-up/improvement

2018-08-22 Thread Julien Grall
Hi, On 16/07/18 18:26, Julien Grall wrote: Julien Grall (15): xen/arm: cpregs: Allow HSR_CPREG* to receive more than 1 parameter xen/arm: cpregs: Fix typo in the documentation of TTBCR xen/arm: p2m: Reduce the locking section in get_page_from_gva xen/arm: p2m: Limit call to mem

Re: [Xen-devel] [PATCH v3 00/25] dom0less step1: boot multiple domains from device tree

2018-08-22 Thread Julien Grall
Hi Stefano, On 01/08/18 00:27, Stefano Stabellini wrote: xen/arm: move a few DT related defines to public/device_tree_defs.h xen/arm: do not pass dt_host to make_memory_node and make_hypervisor_node xen/arm: move evtchn_allocate call out of make_hypervisor_node

Re: [Xen-devel] [PATCH 1/2] tools/libxl: Rename libxl__arch_domain_build_info_acpi_setdefault to...

2018-08-22 Thread Wei Liu
On Wed, Aug 22, 2018 at 05:08:18PM +0200, Roger Pau Monné wrote: > On Wed, Aug 22, 2018 at 04:00:44PM +0100, Julien Grall wrote: > > libxl__arch_domain_build_info_setdefault > > > > A follow-up will require to modify default of multiple fields of > > build_info. So rename the function

Re: [Xen-devel] [PATCH v17 12/13] x86/hvm: Remove redundant save functions

2018-08-22 Thread Roger Pau Monné
On Wed, Aug 22, 2018 at 06:22:15PM +0300, Isaila Alexandru wrote: > > >   > > > -if ( handler(d, h) != 0 ) > > > +if ( handler(d->vcpu[0], h) != 0 ) > > >  { > > >  printk(XENLOG_G_ERR > > > -   "HVM%d save: failed to save

Re: [Xen-devel] [PATCH v3 02/25] xen/arm: move a few DT related defines to public/device_tree_defs.h

2018-08-22 Thread Wei Liu
On Wed, Aug 01, 2018 at 10:31:50AM +0100, Julien Grall wrote: > > > On 01/08/18 00:27, Stefano Stabellini wrote: > > Move a few constants defined by libxl_arm.c to > > xen/include/public/device_tree_defs.h, so that they can be used from Xen > > and libxl. Prepend GUEST_ to avoid conflicts. > >

Re: [Xen-devel] [PATCH v7 3/6] iommu: make iommu_inclusive_mapping a suboption of dom0-iommu

2018-08-22 Thread Julien Grall
Hi, On 22/08/18 16:22, Roger Pau Monné wrote: On Wed, Aug 22, 2018 at 04:07:26PM +0100, Julien Grall wrote: Hi Roger, On 22/08/18 08:51, Roger Pau Monne wrote: Introduce a new dom0-iommu=map-inclusive generic option that supersedes iommu_inclusive_mapping. The previous behavior is preserved

Re: [Xen-devel] [PATCH v7 3/6] iommu: make iommu_inclusive_mapping a suboption of dom0-iommu

2018-08-22 Thread Roger Pau Monné
On Wed, Aug 22, 2018 at 04:07:26PM +0100, Julien Grall wrote: > Hi Roger, > > On 22/08/18 08:51, Roger Pau Monne wrote: > > Introduce a new dom0-iommu=map-inclusive generic option that > > supersedes iommu_inclusive_mapping. The previous behavior is preserved > > and the option should only be

Re: [Xen-devel] [PATCH v17 12/13] x86/hvm: Remove redundant save functions

2018-08-22 Thread Isaila Alexandru
> >   > > -if ( handler(d, h) != 0 ) > > +if ( handler(d->vcpu[0], h) != 0 ) > >  { > >  printk(XENLOG_G_ERR > > -   "HVM%d save: failed to save type > > %"PRIu16"\n", > > +   "HVM d%d save: failed to save

Re: [Xen-devel] [PATCH 05/34] xen: is_hvm_domain should evaluate to 0 when !CONFIG_HVM

2018-08-22 Thread Wei Liu
On Wed, Aug 22, 2018 at 04:11:45PM +0100, Julien Grall wrote: > Hi Wei, > > On 21/08/18 21:08, Wei Liu wrote: > > On Tue, Aug 21, 2018 at 11:59:26AM -0700, Stefano Stabellini wrote: > > > On Tue, 21 Aug 2018, Julien Grall wrote: > > > > On 08/21/2018 07:49 PM, Wei Liu wrote: > > > > > On Tue, Aug

Re: [Xen-devel] [PATCH 2/2] tools/libxl: Switch Arm guest type to PVH

2018-08-22 Thread Roger Pau Monné
On Wed, Aug 22, 2018 at 04:00:45PM +0100, Julien Grall wrote: > Currently, the toolstack is considering Arm guest always PV. However, > they are very similar to PVH because HW virtualization extension are used > and QEMU is not started. So switch Arm guest type to PVH. > > To keep compatibility

Re: [Xen-devel] [PATCH v17 13/13] x86/domctl: Don't pause the whole domain if only getting vcpu state

2018-08-22 Thread Isaila Alexandru
On Mi, 2018-08-22 at 16:41 +0200, Roger Pau Monné wrote: > On Wed, Aug 22, 2018 at 05:02:43PM +0300, Alexandru Isaila wrote: > > > > This patch is focused on moving changing hvm_save_one() to save one > > typecode from one vcpu and now that the save functions get data > > from a > > single vcpu

Re: [Xen-devel] [PATCH 05/34] xen: is_hvm_domain should evaluate to 0 when !CONFIG_HVM

2018-08-22 Thread Julien Grall
Hi Wei, On 21/08/18 21:08, Wei Liu wrote: On Tue, Aug 21, 2018 at 11:59:26AM -0700, Stefano Stabellini wrote: On Tue, 21 Aug 2018, Julien Grall wrote: On 08/21/2018 07:49 PM, Wei Liu wrote: On Tue, Aug 21, 2018 at 07:33:56PM +0100, Julien Grall wrote: Hi Wei, On 08/21/2018 05:31 PM, Wei

Re: [Xen-devel] [PATCH 1/2] tools/libxl: Rename libxl__arch_domain_build_info_acpi_setdefault to...

2018-08-22 Thread Roger Pau Monné
On Wed, Aug 22, 2018 at 04:00:44PM +0100, Julien Grall wrote: > libxl__arch_domain_build_info_setdefault > > A follow-up will require to modify default of multiple fields of > build_info. So rename the function accordingly. No functional change. > > Signed-off-by: Julien Grall Reviewed-by:

Re: [Xen-devel] [PATCH v7 6/6] x86/iommu: add map-reserved dom0-iommu option to map reserved memory ranges

2018-08-22 Thread Julien Grall
Hi Roger, On 22/08/18 08:52, Roger Pau Monne wrote: Several people have reported hardware issues (malfunctioning USB controllers) due to iommu page faults on Intel hardware. Those faults are caused by missing RMRR (VTd) entries in the ACPI tables. Those can be worked around on VTd hardware by

Re: [Xen-devel] [PATCH v7 3/6] iommu: make iommu_inclusive_mapping a suboption of dom0-iommu

2018-08-22 Thread Julien Grall
Hi Roger, On 22/08/18 08:51, Roger Pau Monne wrote: Introduce a new dom0-iommu=map-inclusive generic option that supersedes iommu_inclusive_mapping. The previous behavior is preserved and the option should only be enabled by default on Intel hardware. Signed-off-by: Roger Pau Monné

Re: [Xen-devel] [PATCH v17 12/13] x86/hvm: Remove redundant save functions

2018-08-22 Thread Roger Pau Monné
On Wed, Aug 22, 2018 at 05:02:42PM +0300, Alexandru Isaila wrote: > diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c > index 4a70251..831f86b 100644 > --- a/xen/arch/x86/hvm/hvm.c > +++ b/xen/arch/x86/hvm/hvm.c > @@ -740,7 +740,7 @@ void hvm_domain_destroy(struct domain *d) >

[Xen-devel] [PATCH 2/2] tools/libxl: Switch Arm guest type to PVH

2018-08-22 Thread Julien Grall
Currently, the toolstack is considering Arm guest always PV. However, they are very similar to PVH because HW virtualization extension are used and QEMU is not started. So switch Arm guest type to PVH. To keep compatibility with toolstack creating Arm guest with PV type (e.g libvirt), libxl will

[Xen-devel] [PATCH 0/2] tools/libxl: Switch Arm guest type to PVH

2018-08-22 Thread Julien Grall
Hi all, This small patch series adds switch Arm guest type to PVH in libxl. See patch #2 for the rationale. Cheers, Julien Grall (2): tools/libxl: Rename libxl__arch_domain_build_info_acpi_setdefault to... tools/libxl: Switch Arm guest type to PVH docs/man/xl.cfg.pod.5.in | 3 ++-

[Xen-devel] [PATCH 1/2] tools/libxl: Rename libxl__arch_domain_build_info_acpi_setdefault to...

2018-08-22 Thread Julien Grall
libxl__arch_domain_build_info_setdefault A follow-up will require to modify default of multiple fields of build_info. So rename the function accordingly. Signed-off-by: Julien Grall --- tools/libxl/libxl_arch.h | 3 +-- tools/libxl/libxl_arm.c| 4 ++-- tools/libxl/libxl_create.c | 2 +-

Re: [Xen-devel] [PATCH v17 13/13] x86/domctl: Don't pause the whole domain if only getting vcpu state

2018-08-22 Thread Roger Pau Monné
On Wed, Aug 22, 2018 at 05:02:43PM +0300, Alexandru Isaila wrote: > This patch is focused on moving changing hvm_save_one() to save one > typecode from one vcpu and now that the save functions get data from a > single vcpu we can pause the specific vcpu instead of the domain. With this

Re: [Xen-devel] [PATCH] libxl: make sure string is null-terminated in libxl__prepare_sockaddr_un

2018-08-22 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH] libxl: make sure string is null-terminated in libxl__prepare_sockaddr_un"): > On Wed, Aug 22, 2018 at 12:39:33PM +0100, Ian Jackson wrote: > > If this new code has any effect at all, it will corrupt the string by > > truncating it. > > Corrupt? Per your analysis

Re: [Xen-devel] [PATCH v17 11/13] x86/domctl: Use hvm_save_vcpu_handler

2018-08-22 Thread Roger Pau Monné
On Wed, Aug 22, 2018 at 05:02:41PM +0300, Alexandru Isaila wrote: > This patch is aimed on using the new save_one fuctions in the hvm_save > > Signed-off-by: Alexandru Isaila > > --- > Changes since V15: > - Moved declarations into their scopes > - Remove redundant NULL check >

Re: [Xen-devel] [PATCH 22/34] x86/mm: put HVM only code under CONFIG_HVM

2018-08-22 Thread Wei Liu
On Tue, Aug 21, 2018 at 02:07:22AM -0600, Jan Beulich wrote: > >>> On 17.08.18 at 17:12, wrote: > > --- a/xen/arch/x86/mm/Makefile > > +++ b/xen/arch/x86/mm/Makefile > > @@ -2,8 +2,9 @@ subdir-y += shadow > > subdir-y += hap > > > > obj-y += paging.o > > -obj-y += p2m.o p2m-pt.o p2m-ept.o

Re: [Xen-devel] [PATCH 21/34] x86/mm: p2m_flush and nvcpu_flush are HVM only

2018-08-22 Thread Wei Liu
On Tue, Aug 21, 2018 at 02:01:12AM -0600, Jan Beulich wrote: > >>> On 17.08.18 at 17:12, wrote: > > p2m_flush is only called by HAP code, nvcpu_flush is only useful for > > nestedhvm, both of which depend on HVM support. > > > > Enclose their code in CONFIG_HVM. Add assertions. > > But why do

[Xen-devel] [PATCH v1 6/6] xsm: add tee access policy support

2018-08-22 Thread Volodymyr Babchuk
As we don't want any guest to access limited resources of TEE, we need a way to control who can work with it. Thus, new access vector class "tee" is added with only ony operation "call" so far. tee framework uses this to check if guest has a right to work with TEE. Also, example security context

[Xen-devel] [PATCH v1 3/6] arm: tee: add OP-TEE header files

2018-08-22 Thread Volodymyr Babchuk
This header files describe protocol between OP-TEE and OP-TEE client driver in Linux. They are needed for upcomient OP-TEE mediator, which is added in the next patch. Reason to add those headers in separate patch is to ease up review. Those files were taken from linux tree (drivers/tee/optee/) and

[Xen-devel] [PATCH v1 5/6] libxl: create DTS node for OP-TEE if it is enabled

2018-08-22 Thread Volodymyr Babchuk
Signed-off-by: Volodymyr Babchuk --- tools/libxl/libxl_arm.c | 29 + tools/libxl/libxl_create.c | 1 + tools/libxl/libxl_types.idl | 1 + tools/xl/xl_parse.c | 1 + 4 files changed, 32 insertions(+) diff --git a/tools/libxl/libxl_arm.c

[Xen-devel] [PATCH v1 0/6] TEE mediator (and OP-TEE) support in XEN

2018-08-22 Thread Volodymyr Babchuk
Hello all, This is follow for patch series [1]. There was lots of discussions for that series and I tried to address all of them in this new patchset. Currently, I had a working solution for OP-TEE virtualization and it is being upstreamed right now ([2]). So, I think it is a good time to

[Xen-devel] [PATCH v1 2/6] arm: add generic TEE mediator framework

2018-08-22 Thread Volodymyr Babchuk
This patch adds basic framework for TEE mediators. Guests can't talk to TEE directly, we need some entity that will intercept request and decide what to do with them. "TEE mediator" is a such entity. This is how it works: user can build XEN with multiple TEE mediators (see the next patches, where

[Xen-devel] [PATCH v17 13/13] x86/domctl: Don't pause the whole domain if only getting vcpu state

2018-08-22 Thread Alexandru Isaila
This patch is focused on moving changing hvm_save_one() to save one typecode from one vcpu and now that the save functions get data from a single vcpu we can pause the specific vcpu instead of the domain. Signed-off-by: Alexandru Isaila --- Changes since V15: - Moved pause/unpause calls

[Xen-devel] [PATCH v17 06/13] x86/hvm: Introduce hvm_save_mtrr_msr_one func

2018-08-22 Thread Alexandru Isaila
This is used to save data from a single instance. Signed-off-by: Alexandru Isaila i Reviewed-by: Jan Beulich --- Changes since v16: - Address style comments. Note: This patch is based on Roger Pau Monne's series[1] --- xen/arch/x86/hvm/mtrr.c | 80

[Xen-devel] [PATCH v17 11/13] x86/domctl: Use hvm_save_vcpu_handler

2018-08-22 Thread Alexandru Isaila
This patch is aimed on using the new save_one fuctions in the hvm_save Signed-off-by: Alexandru Isaila --- Changes since V15: - Moved declarations into their scopes - Remove redundant NULL check - Remove rc variable - Change fault return to -ENODATA. ---

[Xen-devel] [PATCH v17 02/13] x86/hvm: Introduce hvm_save_tsc_adjust_one() func

2018-08-22 Thread Alexandru Isaila
This is used to save data from a single instance. Signed-off-by: Alexandru Isaila Reviewed-by: Jan Beulich --- Changes since V13: - Moved tsc_adjust to the initializer. --- xen/arch/x86/hvm/hvm.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git

[Xen-devel] [PATCH v17 04/13] x86/hvm: Introduce hvm_save_cpu_xsave_states_one

2018-08-22 Thread Alexandru Isaila
This is used to save data from a single instance. Signed-off-by: Alexandru Isaila Reviewed-by: Jan Beulich --- Changes since V14: - Remove err init - Add blank line ahead of return - Move xsave_enabled() check to the save_one func. --- xen/arch/x86/hvm/hvm.c | 47

[Xen-devel] [PATCH v17 01/13] x86/cpu: Introduce vmce_save_vcpu_ctxt_one() func

2018-08-22 Thread Alexandru Isaila
This is used to save data from a single instance. Signed-off-by: Alexandru Isaila Reviewed-by: Jan Beulich --- Changes since V11: - Removed the memset and added init with {}. --- xen/arch/x86/cpu/mcheck/vmce.c | 21 + 1 file changed, 13 insertions(+), 8

[Xen-devel] [PATCH v17 05/13] x86/hvm: Introduce hvm_save_cpu_msrs_one func

2018-08-22 Thread Alexandru Isaila
This is used to save data from a single instance. Signed-off-by: Alexandru Isaila Reviewed-by: Paul Durrant Reviewed-by: Jan Beulich --- Changes since V14: - Remove err init - Add blank line ahead of return. --- xen/arch/x86/hvm/hvm.c | 106

[Xen-devel] [PATCH v17 09/13] x86/hvm: Introduce lapic_save_regs_one func

2018-08-22 Thread Alexandru Isaila
This is used to save data from a single instance. Signed-off-by: Alexandru Isaila Reviewed-by: Jan Beulich --- Changes since v15: - Drop struct vlapic *s. --- xen/arch/x86/hvm/vlapic.c | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git

[Xen-devel] [PATCH v17 10/13] x86/hvm: Add handler for save_one funcs

2018-08-22 Thread Alexandru Isaila
Signed-off-by: Alexandru Isaila Reviewed-by: Jan Beulich --- Changes since V14: - Change handler name from hvm_save_one_handler to hvm_save_vcpu_handler. --- xen/arch/x86/cpu/mcheck/vmce.c | 1 + xen/arch/x86/hvm/hpet.c| 2 +- xen/arch/x86/hvm/hvm.c | 6 +-

[Xen-devel] [PATCH v17 07/13] x86/hvm: Introduce viridian_save_vcpu_ctxt_one() func

2018-08-22 Thread Alexandru Isaila
This is used to save data from a single instance. Signed-off-by: Alexandru Isaila Reviewed-by: Paul Durrant --- Changes since V14: - Moved all the operations in the initializer. --- xen/arch/x86/hvm/viridian.c | 30 +++--- 1 file changed, 19 insertions(+), 11

[Xen-devel] [PATCH v17 12/13] x86/hvm: Remove redundant save functions

2018-08-22 Thread Alexandru Isaila
This patch removes the redundant save functions and renames the save_one* to save. It then changes the domain param to vcpu in the save funcs. Signed-off-by: Alexandru Isaila --- Changes since V16: - Drop the "instance = 0" from hvm_save_one - Changed if ( handler ) to if (

[Xen-devel] [PATCH v17 08/13] x86/hvm: Introduce lapic_save_hidden_one

2018-08-22 Thread Alexandru Isaila
This is used to save data from a single instance. Signed-off-by: Alexandru Isaila Reviewed-by: Jan Beulich --- Changes since v15: - Drop struct vlapic *s. --- xen/arch/x86/hvm/vlapic.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git

[Xen-devel] [PATCH v17 00/14] x86/domctl: Save info for one vcpu instance

2018-08-22 Thread Alexandru Isaila
Hi all, This patch series addresses the ideea of saving data from a single vcpu instance. First it starts by adding *save_one functions, then it introduces a handler for the new save_one* funcs and makes use of it in the hvm_save and hvm_save_one funcs. The final patches are used for clean up

Re: [Xen-devel] [PATCH] pvshim: introduce a PV shim defconfig

2018-08-22 Thread Wei Liu
On Wed, Aug 22, 2018 at 12:36:55PM +0200, Roger Pau Monne wrote: > In order to build a tailored pvshim-only binary from Xen. Switch the > PV shim build from the tools firmware into using the new defconfig. > > A diff of the .config generated for the pvshim firmware build before > and after this

Re: [Xen-devel] [PATCH] libxl: make sure string is null-terminated in libxl__prepare_sockaddr_un

2018-08-22 Thread Wei Liu
On Wed, Aug 22, 2018 at 12:39:33PM +0100, Ian Jackson wrote: > Wei Liu writes ("[PATCH] libxl: make sure string is null-terminated in > libxl__prepare_sockaddr_un"): > > Coverity-ID: 1438472 > > Signed-off-by: Wei Liu > > But... > > > diff --git a/tools/libxl/libxl_utils.c

Re: [Xen-devel] [PATCH 06/10] xen/arm: add OMAP5 kconfig

2018-08-22 Thread Andrii Anisov
Hello Stefano, I will look through the rest of changes. But my justifications could be wrong due to the fact that the rest of the SoC families are unfamiliar to me. On 21.08.18 20:24, Stefano Stabellini wrote: On Tue, 21 Aug 2018, Andrii Anisov wrote: Hello Stefano, On 21.08.18 02:59,

[Xen-devel] [ovmf test] 126360: all pass - PUSHED

2018-08-22 Thread osstest service owner
flight 126360 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/126360/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf e0c93c9b76153bc5a95bf174dab9805ec2f2942c baseline version: ovmf

[Xen-devel] [xen-4.7-testing test] 126307: regressions - FAIL

2018-08-22 Thread osstest service owner
flight 126307 xen-4.7-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/126307/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt-pair 22 guest-migrate/src_host/dst_host fail REGR. vs. 125057

[Xen-devel] [linux-3.18 bisection] complete test-amd64-i386-qemut-rhel6hvm-intel

2018-08-22 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-i386-qemut-rhel6hvm-intel testid redhat-install Tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu

[Xen-devel] [ovmf baseline-only test] 75102: tolerable FAIL

2018-08-22 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 75102 ovmf real [real] http://osstest.xensource.com/osstest/logs/75102/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-ovmf-amd64 10 debian-hvm-install fail like 75098

Re: [Xen-devel] [PATCH] pvshim: introduce a PV shim defconfig

2018-08-22 Thread Ian Jackson
Roger Pau Monne writes ("[PATCH] pvshim: introduce a PV shim defconfig"): > In order to build a tailored pvshim-only binary from Xen. Switch the > PV shim build from the tools firmware into using the new defconfig. > > A diff of the .config generated for the pvshim firmware build before > and

Re: [Xen-devel] [PATCH] libxl: make sure string is null-terminated in libxl__prepare_sockaddr_un

2018-08-22 Thread Ian Jackson
Wei Liu writes ("[PATCH] libxl: make sure string is null-terminated in libxl__prepare_sockaddr_un"): > Coverity-ID: 1438472 > Signed-off-by: Wei Liu But... > diff --git a/tools/libxl/libxl_utils.c b/tools/libxl/libxl_utils.c > index 5854717b11..e06f765699 100644 > ---

[Xen-devel] [xen-unstable baseline-only test] 75101: regressions - FAIL

2018-08-22 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 75101 xen-unstable real [real] http://osstest.xensource.com/osstest/logs/75101/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 10

[Xen-devel] [xen-4.9-testing test] 126296: regressions - FAIL

2018-08-22 Thread osstest service owner
flight 126296 xen-4.9-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/126296/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-ws16-amd64 17 guest-stopfail REGR. vs. 124248

[Xen-devel] [OSSTEST PATCH] Revert "production-config: Temporarily drop arm64"

2018-08-22 Thread Ian Jackson
This reverts commit 2d3fd8087e746bc5f64d3cf01014aac388a1bb7e. Signed-off-by: Ian Jackson CC: Julien Grall --- production-config | 3 --- 1 file changed, 3 deletions(-) diff --git a/production-config b/production-config index fae31ea..df02cd3 100644 --- a/production-config +++

[Xen-devel] [PATCH] pvshim: introduce a PV shim defconfig

2018-08-22 Thread Roger Pau Monne
In order to build a tailored pvshim-only binary from Xen. Switch the PV shim build from the tools firmware into using the new defconfig. A diff of the .config generated for the pvshim firmware build before and after this change shows no differences. Signed-off-by: Roger Pau Monné --- Cc: Ian

Re: [Xen-devel] [PATCH v3 24/25] xen/vpl011: buffer out chars when the backend is xen

2018-08-22 Thread Julien Grall
Hi, On 16/08/18 20:41, Stefano Stabellini wrote: On Mon, 13 Aug 2018, Julien Grall wrote: Hi, On 01/08/18 00:28, Stefano Stabellini wrote: To avoid mixing the output of different domains on the console, buffer the output chars and print line by line. Unless the domain has input from the

[Xen-devel] [PATCH] libxl: make sure string is null-terminated in libxl__prepare_sockaddr_un

2018-08-22 Thread Wei Liu
Coverity-ID: 1438472 Signed-off-by: Wei Liu --- Cc: Ian Jackson --- tools/libxl/libxl_utils.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/libxl/libxl_utils.c b/tools/libxl/libxl_utils.c index 5854717b11..e06f765699 100644 --- a/tools/libxl/libxl_utils.c +++

Re: [Xen-devel] [PATCH v3 22/25] xen/arm: Allow vpl011 to be used by DomU

2018-08-22 Thread Julien Grall
On 16/08/18 20:21, Stefano Stabellini wrote: On Mon, 13 Aug 2018, Julien Grall wrote: Hi Stefano, On 01/08/18 00:28, Stefano Stabellini wrote: Make vpl011 being able to be used without a userspace component in Dom0. In that case, output is printed to the Xen serial and input is received

Re: [Xen-devel] [RFC PATCH 2/2] xen/arm: Add MESON UART driver for Amlogic S905 SoC

2018-08-22 Thread Julien Grall
On 20/08/18 09:12, Amit Tomer wrote: Hello, Hi, Thanks for having a look at it. The spec does not seems to provide the offset register. Where did you find them? Actually, looked at couple of references from u-boot and Linux. These headers are picked from there. Please mention it in

[Xen-devel] [xen-unstable-coverity test] 126378: all pass - PUSHED

2018-08-22 Thread osstest service owner
flight 126378 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/126378/ Perfect :-) All tests in this flight passed as required version targeted for testing: xen 1385a14bfc09672513cb5bf9baafa881c8d93542 baseline version: xen

Re: [Xen-devel] [RFC PATCH 1/2] xen/arm: Add Amlogic S905 SoC early printk support

2018-08-22 Thread Julien Grall
On 20/08/18 10:16, Amit Tomer wrote: Hello, Hi Amit, I would prefer if no new alias are added. The same could be achieved with CONFIG_EARLY_PRINTK=meson,0xc81004c0. This could be documented on the wiki. Ok. I would prefer if we stick with the spec name. So UART_TX_REG should be

Re: [Xen-devel] [PATCH v7 4/6] mm: introduce a helper to get the memory type of a page

2018-08-22 Thread Wei Liu
On Wed, Aug 22, 2018 at 09:51:58AM +0200, Roger Pau Monne wrote: > Returns all the memory types applicable to a page. > > This function is unimplemented for ARM. > > Signed-off-by: Roger Pau Monné > Reviewed-by: Jan Beulich > --- > Changes since v5: > - Return all types that apply to a page,

Re: [Xen-devel] [PATCH v7 5/6] x86/iommu: switch the hwdom mapping function to use page_get_type

2018-08-22 Thread Wei Liu
On Wed, Aug 22, 2018 at 09:51:59AM +0200, Roger Pau Monne wrote: > This avoids repeated calls to page_is_ram_type which improves > performance and makes the code easier to read. > > Signed-off-by: Roger Pau Monné > Reviewed-by: Jan Beulich Reviewed-by: Wei Liu > --- > Changes since v4: > -

Re: [Xen-devel] [PATCH v7 3/6] iommu: make iommu_inclusive_mapping a suboption of dom0-iommu

2018-08-22 Thread Wei Liu
On Wed, Aug 22, 2018 at 09:51:57AM +0200, Roger Pau Monne wrote: > Introduce a new dom0-iommu=map-inclusive generic option that > supersedes iommu_inclusive_mapping. The previous behavior is preserved > and the option should only be enabled by default on Intel hardware. > > Signed-off-by: Roger

Re: [Xen-devel] [PATCH v7 2/6] iommu: introduce dom0-iommu option

2018-08-22 Thread Wei Liu
On Wed, Aug 22, 2018 at 09:51:56AM +0200, Roger Pau Monne wrote: > To select the iommu configuration used by Dom0. This option supersedes > iommu=dom0-strict|dom0-passthrough. > > Signed-off-by: Roger Pau Monné > Reviewed-by: Jan Beulich Reviewed-by: Wei Liu

Re: [Xen-devel] [PATCH v7 6/6] x86/iommu: add map-reserved dom0-iommu option to map reserved memory ranges

2018-08-22 Thread Wei Liu
On Wed, Aug 22, 2018 at 09:52:00AM +0200, Roger Pau Monne wrote: > Several people have reported hardware issues (malfunctioning USB > controllers) due to iommu page faults on Intel hardware. Those faults > are caused by missing RMRR (VTd) entries in the ACPI tables. Those can > be worked around on

Re: [Xen-devel] [PATCH v7 1/6] iommu: rename iommu_dom0_strict and iommu_passthrough

2018-08-22 Thread Wei Liu
On Wed, Aug 22, 2018 at 09:51:55AM +0200, Roger Pau Monne wrote: > To iommu_hwdom_strict and iommu_hwdom_passthrough which is more > descriptive of their usage. Also change their type from bool_t to > bool. > > No functional change. > > Signed-off-by: Roger Pau Monné > Reviewed-by: Jan Beulich

[Xen-devel] [PATCH RESEND v3 1/2] x86/mmcfg: Rename pt_pci_init() and call it in acpi_mmcfg_init()

2018-08-22 Thread Zhenzhong Duan
Given what pt_pci_init() actually does, rename it properly and move its declaration to pci.h, move the only call in acpi_mmcfg_init(). No functional change. Signed-off-by: Zhenzhong Duan Tested-by: Gopalasetty, Manoj Acked-by: Jan Beulich --- xen/arch/x86/setup.c |2 --

  1   2   >