[PATCH v5 10/10] xen/arm: Process pending vPCI map/unmap operations

2021-10-07 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko vPCI may map and unmap PCI device memory (BARs) being passed through which may take a lot of time. For this those operations may be deferred to be performed later, so that they can be safely preempted. Currently this deferred processing is happening in common IOREQ

[PATCH v5 09/10] xen/arm: Do not map PCI ECAM and MMIO space to Domain-0's p2m

2021-10-07 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko PCI host bridges are special devices in terms of implementing PCI passthrough. According to [1] the current implementation depends on Domain-0 to perform the initialization of the relevant PCI host bridge hardware and perform PCI device enumeration. In order to

[PATCH v5 08/10] xen/arm: Setup MMIO range trap handlers for hardware domain

2021-10-07 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko In order for vPCI to work it needs to maintain guest and hardware domain's views of the configuration space. For example, BARs and COMMAND registers require emulation for guests and the guest view of the registers needs to be in sync with the real contents of the

[PATCH v5 07/10] libxl: Only map legacy PCI IRQs if they are supported

2021-10-07 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko Arm's PCI passthrough implementation doesn't support legacy interrupts, but MSI/MSI-X. This can be the case for other platforms too. For that reason introduce a new CONFIG_PCI_SUPP_LEGACY_IRQ and add it to the CFLAGS and compile the relevant code in the toolstack

[PATCH v5 06/10] libxl: Allow removing PCI devices for all types of domains

2021-10-07 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko The PCI device remove path may now be used by PVH on ARM, so the assert is no longer valid. Signed-off-by: Oleksandr Andrushchenko Acked-by: Stefano Stabellini Reviewed-by: Rahul Singh Tested-by: Rahul Singh --- Cc: Ian Jackson Cc: Juergen Gross ---

[PATCH v5 05/10] xen/domain: Call pci_release_devices() when releasing domain resources

2021-10-07 Thread Oleksandr Andrushchenko
From: Oleksandr Tyshchenko This is the very same that we already do for DT devices. Moreover, x86 already calls pci_release_devices(). Signed-off-by: Oleksandr Tyshchenko Signed-off-by: Oleksandr Andrushchenko Reviewed-by: Stefano Stabellini Reviewed-by: Rahul Singh Tested-by: Rahul Singh

[PATCH v5 04/10] xen/arm: Mark device as PCI while creating one

2021-10-07 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko While adding a PCI device mark it as such, so other frameworks can distinguish it from DT devices. For that introduce an architecture defined helper which may perform additional initialization of the newly created PCI device. Signed-off-by: Oleksandr Andrushchenko

[PATCH v5 03/10] xen/device-tree: Make dt_find_node_by_phandle global

2021-10-07 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko Make dt_find_node_by_phandle globally visible, so it can be re-used by other frameworks. Signed-off-by: Oleksandr Andrushchenko Reviewed-by: Stefano Stabellini Reviewed-by: Rahul Singh Tested-by: Rahul Singh --- xen/common/device_tree.c | 2 +-

[PATCH v5 02/10] xen/arm: Introduce pci_find_host_bridge_node helper

2021-10-07 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko Get host bridge node given a PCI device attached to it. This helper will be re-used for adding PCI devices by the subsequent patches. Signed-off-by: Oleksandr Andrushchenko Signed-off-by: Oleksandr Tyshchenko Reviewed-by: Stefano Stabellini Reviewed-by: Rahul

[PATCH v5 01/10] xen/arm: Add new device type for PCI

2021-10-07 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko Add new device type (DEV_PCI) to distinguish PCI devices from platform DT devices, so some drivers, like IOMMU, can handle PCI devices differently. Also add a helper which is when given a struct device returns the corresponding struct pci_dev which this device is a

[PATCH v5 00/10] PCI devices passthrough on Arm, part 2

2021-10-07 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko Hi, all! This is an assorted series of patches which aim is to make some further basis for PCI passthrough on Arm support. The series continues the work published earlier by Arm [1] and adds new helpers and clears the way for vPCI changes which will follow. RFC is

[PATCH] docs: add references to Argo Linux driver sources and information

2021-10-07 Thread Christopher Clark
Add a section to the Argo design document to supply guidance on how to enable Argo in Xen and where to obtain source code and documentation for Argo device drivers for guest OSes, primarily from OpenXT. Signed-off-by: Christopher Clark --- docs/designs/argo.pandoc | 45

[libvirt test] 165412: regressions - FAIL

2021-10-07 Thread osstest service owner
flight 165412 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/165412/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-armhf-libvirt

[xen-unstable-smoke test] 165423: tolerable all pass - PUSHED

2021-10-07 Thread osstest service owner
flight 165423 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/165423/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

RE: [PATCH 03/11] xen/arm: introduce 1:1 direct-map for domUs

2021-10-07 Thread Penny Zheng
Hi Julien So sorry for taking so long to respond. Just being back from the long National Day holidays.  > -Original Message- > From: Julien Grall > Sent: Thursday, September 23, 2021 6:36 PM > To: Penny Zheng ; xen-devel@lists.xenproject.org; > sstabell...@kernel.org > Cc: Bertrand

[xen-4.13-testing test] 165401: tolerable FAIL - PUSHED

2021-10-07 Thread osstest service owner
flight 165401 xen-4.13-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/165401/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail baseline untested

Re: [PATCH] xen/arm: optee: fix possible memory leaks

2021-10-07 Thread Stefano Stabellini
On Thu, 7 Oct 2021, Volodymyr Babchuk wrote: > translate_noncontig() allocates domheap page for translated list > before calling to allocate_optee_shm_buf(), which can fail for number > of reason. Anyways, after fail we need to free the allocated page(s). > > Another leak is possible if the same

Re: [PING] Re: [PATCH] xen/arm: optee: Allocate anonymous domheap pages

2021-10-07 Thread Stefano Stabellini
On Thu, 7 Oct 2021, Volodymyr Babchuk wrote: > > On Thu, 7 Oct 2021, Volodymyr Babchuk wrote: > >> Hi Stefano, > >> > >> Stefano Stabellini writes: > >> > >> > On Wed, 6 Oct 2021, Oleksandr wrote: > >> >> Hello all > >> >> > >> >> Gentle reminder. > >> > > >> > Many thanks for the ping, this

Re: [PATCH] xen/arm: optee: Fix arm_smccc_smc's a0 for OPTEE_SMC_DISABLE_SHM_CACHE

2021-10-07 Thread Volodymyr Babchuk
Hi Oleksandr, Stefano, Oleksandr writes: > On 07.10.21 01:42, Stefano Stabellini wrote: > > Hi Stefano, Julien. > >> On Wed, 6 Oct 2021, Julien Grall wrote: >>> Hi Stefano, >>> >>> On 28/09/2021 06:52, Stefano Stabellini wrote: On Mon, 27 Sep 2021, Oleksandr Tyshchenko wrote: > From:

[PATCH] xen/arm: optee: fix possible memory leaks

2021-10-07 Thread Volodymyr Babchuk
translate_noncontig() allocates domheap page for translated list before calling to allocate_optee_shm_buf(), which can fail for number of reason. Anyways, after fail we need to free the allocated page(s). Another leak is possible if the same translate_noncontig() function fails to get domain

[xen-unstable-smoke test] 165420: tolerable all pass - PUSHED

2021-10-07 Thread osstest service owner
flight 165420 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/165420/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [PING] Re: [PATCH] xen/arm: optee: Allocate anonymous domheap pages

2021-10-07 Thread Volodymyr Babchuk
Hi, Stefano Stabellini writes: > On Thu, 7 Oct 2021, Volodymyr Babchuk wrote: >> Hi Stefano, >> >> Stefano Stabellini writes: >> >> > On Wed, 6 Oct 2021, Oleksandr wrote: >> >> Hello all >> >> >> >> Gentle reminder. >> > >> > Many thanks for the ping, this patch fell off my radar. >> >

[linux-linus test] 165394: regressions - FAIL

2021-10-07 Thread osstest service owner
flight 165394 linux-linus real [real] flight 165421 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/165394/ http://logs.test-lab.xenproject.org/osstest/logs/165421/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be

Re: [PATCH v5 00/11] PCI devices passthrough on Arm

2021-10-07 Thread Rahul Singh
Hi Stefano, > On 7 Oct 2021, at 8:54 pm, Stefano Stabellini wrote: > > I committed patches 2-7. > > I made two small adjustments on commit: > - patch #3: bool_t/bool > - patch #7: drop _XEN_DOMCTL_CDF_vpci Thank you very much. I will be on leave from tomorrow. Someone from my team will take

Re: [PATCH V5 3/3] xen/arm: Updates for extended regions support

2021-10-07 Thread Oleksandr
On 07.10.21 23:42, Stefano Stabellini wrote: Hi Stefano On Thu, 7 Oct 2021, Oleksandr wrote: On 07.10.21 23:06, Stefano Stabellini wrote: On Thu, 7 Oct 2021, Oleksandr wrote: On 07.10.21 04:50, Stefano Stabellini wrote: Hi Stefano On Wed, 6 Oct 2021, Oleksandr Tyshchenko wrote: From:

Re: [PING] Re: [PATCH] xen/arm: optee: Allocate anonymous domheap pages

2021-10-07 Thread Stefano Stabellini
On Thu, 7 Oct 2021, Volodymyr Babchuk wrote: > Hi Stefano, > > Stefano Stabellini writes: > > > On Wed, 6 Oct 2021, Oleksandr wrote: > >> Hello all > >> > >> Gentle reminder. > > > > Many thanks for the ping, this patch fell off my radar. > > > > > > > >> On 23.09.21 23:57, Volodymyr

Re: [PATCH V5 2/3] libxl/arm: Add handling of extended regions for DomU

2021-10-07 Thread Oleksandr
On 07.10.21 23:29, Stefano Stabellini wrote: Hi Stefano On Thu, 7 Oct 2021, Oleksandr wrote: On 07.10.21 04:29, Stefano Stabellini wrote: Hi Stefano On Wed, 6 Oct 2021, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko The extended region (safe range) is a region of guest

Re: [PATCH V5 3/3] xen/arm: Updates for extended regions support

2021-10-07 Thread Stefano Stabellini
On Thu, 7 Oct 2021, Oleksandr wrote: > On 07.10.21 23:06, Stefano Stabellini wrote: > > On Thu, 7 Oct 2021, Oleksandr wrote: > > > On 07.10.21 04:50, Stefano Stabellini wrote: > > > > > > Hi Stefano > > > > > > > On Wed, 6 Oct 2021, Oleksandr Tyshchenko wrote: > > > > > From: Oleksandr

Re: [PATCH V5 2/3] libxl/arm: Add handling of extended regions for DomU

2021-10-07 Thread Stefano Stabellini
On Thu, 7 Oct 2021, Ian Jackson wrote: > Stefano Stabellini writes ("Re: [PATCH V5 2/3] libxl/arm: Add handling of > extended regions for DomU"): > > On Wed, 6 Oct 2021, Oleksandr wrote: > > > On 06.10.21 14:34, Ian Jackson wrote: > > > > Oleksandr Tyshchenko writes ("[PATCH V5 2/3] libxl/arm:

Re: [PATCH V5 2/3] libxl/arm: Add handling of extended regions for DomU

2021-10-07 Thread Stefano Stabellini
On Thu, 7 Oct 2021, Oleksandr wrote: > On 07.10.21 04:29, Stefano Stabellini wrote: > > Hi Stefano > > > On Wed, 6 Oct 2021, Oleksandr Tyshchenko wrote: > > > From: Oleksandr Tyshchenko > > > > > > The extended region (safe range) is a region of guest physical > > > address space which is

Re: [PATCH V5 3/3] xen/arm: Updates for extended regions support

2021-10-07 Thread Oleksandr
On 07.10.21 23:06, Stefano Stabellini wrote: Hi Stefano On Thu, 7 Oct 2021, Oleksandr wrote: On 07.10.21 04:50, Stefano Stabellini wrote: Hi Stefano On Wed, 6 Oct 2021, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko This is a follow-up of "b6fe410 xen/arm: Add handling of

Re: [PATCH V5 1/3] xen/arm: Introduce gpaddr_bits field to struct xen_arch_domainconfig

2021-10-07 Thread Stefano Stabellini
On Thu, 7 Oct 2021, Jan Beulich wrote: > On 07.10.2021 15:12, Oleksandr wrote: > > > > On 07.10.21 15:43, Jan Beulich wrote: > > > > Hi Jan. > > > >> On 07.10.2021 14:30, Oleksandr wrote: > >>> On 07.10.21 10:42, Jan Beulich wrote: > On 06.10.2021 13:22, Oleksandr Tyshchenko wrote: > >

Re: [PATCH V5 1/3] xen/arm: Introduce gpaddr_bits field to struct xen_arch_domainconfig

2021-10-07 Thread Oleksandr
On 07.10.21 03:49, Stefano Stabellini wrote: Hi Stefano On Wed, 6 Oct 2021, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko We need to pass info about maximum supported guest physical address space size to the toolstack on Arm in order to properly calculate the base and size of

Re: [PATCH V5 3/3] xen/arm: Updates for extended regions support

2021-10-07 Thread Stefano Stabellini
On Thu, 7 Oct 2021, Oleksandr wrote: > On 07.10.21 04:50, Stefano Stabellini wrote: > > Hi Stefano > > > On Wed, 6 Oct 2021, Oleksandr Tyshchenko wrote: > > > From: Oleksandr Tyshchenko > > > > > > This is a follow-up of > > > "b6fe410 xen/arm: Add handling of extended regions for Dom0" > > >

Re: [PATCH v5 00/11] PCI devices passthrough on Arm

2021-10-07 Thread Stefano Stabellini
I committed patches 2-7. I made two small adjustments on commit: - patch #3: bool_t/bool - patch #7: drop _XEN_DOMCTL_CDF_vpci Cheers, Stefano On Wed, 6 Oct 2021, Rahul Singh wrote: > Hello All, > > The purpose of this patch series is to add PCI passthrough support to Xen on > Arm. PCI

[xen-unstable-smoke test] 165417: tolerable all pass - PUSHED

2021-10-07 Thread osstest service owner
flight 165417 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/165417/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [PING] Re: [PATCH] xen/arm: optee: Allocate anonymous domheap pages

2021-10-07 Thread Volodymyr Babchuk
Hi Stefano, Stefano Stabellini writes: > On Wed, 6 Oct 2021, Oleksandr wrote: >> Hello all >> >> Gentle reminder. > > Many thanks for the ping, this patch fell off my radar. > > > >> On 23.09.21 23:57, Volodymyr Babchuk wrote: >> > Hi Stefano, >> > >> > Stefano Stabellini writes: >> >

Re: [PATCH] xen/arm: optee: Fix arm_smccc_smc's a0 for OPTEE_SMC_DISABLE_SHM_CACHE

2021-10-07 Thread Oleksandr
On 07.10.21 01:42, Stefano Stabellini wrote: Hi Stefano, Julien. On Wed, 6 Oct 2021, Julien Grall wrote: Hi Stefano, On 28/09/2021 06:52, Stefano Stabellini wrote: On Mon, 27 Sep 2021, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko Fix a possible copy-paste error in

Re: [PATCH V5 3/3] xen/arm: Updates for extended regions support

2021-10-07 Thread Oleksandr
On 07.10.21 04:50, Stefano Stabellini wrote: Hi Stefano On Wed, 6 Oct 2021, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko This is a follow-up of "b6fe410 xen/arm: Add handling of extended regions for Dom0" Add various in-code comments, update Xen hypervisor device tree bindings

Re: [PATCH V5 2/3] libxl/arm: Add handling of extended regions for DomU

2021-10-07 Thread Oleksandr
On 07.10.21 04:29, Stefano Stabellini wrote: Hi Stefano On Wed, 6 Oct 2021, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko The extended region (safe range) is a region of guest physical address space which is unused and could be safely used to create grant/foreign mappings instead

[ovmf test] 165398: all pass - PUSHED

2021-10-07 Thread osstest service owner
flight 165398 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/165398/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf b4da6c29f1d36031e04212f53277ce0dcba309f1 baseline version: ovmf

Re: [XEN PATCH v7 17/51] build: set XEN_BUILD_EFI earlier

2021-10-07 Thread Jan Beulich
A general remark first: If I understand things correctly, a side effect of this change is to also address the issue that I'm trying to take care of in "x86/build: suppress EFI-related tool chain checks upon local $(MAKE) recursion". However, while that one's a reasonable backporting candidate, I

Re: [PATCH v5 10/11] arm/libxl: Emulated PCI device tree node in libxl

2021-10-07 Thread Ian Jackson
Rahul Singh writes ("Re: [PATCH v5 10/11] arm/libxl: Emulated PCI device tree node in libxl"): > As Stefano suggested in another email that we can remove the vpci > option, if we reach to conclusion that we need vpci option I will > move it to internal structure. ... > Yes I agree with you VPCI

Re: [PATCH v5 10/11] arm/libxl: Emulated PCI device tree node in libxl

2021-10-07 Thread Rahul Singh
Hi Stefano, > On 7 Oct 2021, at 1:26 am, Stefano Stabellini wrote: > > On Wed, 6 Oct 2021, Julien Grall wrote: >> Hi Rahul, >> >> On 06/10/2021 19:40, Rahul Singh wrote: >>> diff --git a/tools/libs/light/libxl_types.idl >>> b/tools/libs/light/libxl_types.idl >>> index 3f9fff653a..78b1ddf0b8

Re: [PATCH v5 10/11] arm/libxl: Emulated PCI device tree node in libxl

2021-10-07 Thread Rahul Singh
Hi Ian, > On 7 Oct 2021, at 11:53 am, Ian Jackson wrote: > > Julien Grall writes ("Re: [PATCH v5 10/11] arm/libxl: Emulated PCI device > tree node in libxl"): >> On 06/10/2021 19:40, Rahul Singh wrote: >>> diff --git a/tools/libs/light/libxl_types.idl >>> b/tools/libs/light/libxl_types.idl

PV - different behavior of pgd_offset in xen 4.6 and 4.13 for GUEST ACCESSIBLE memory area

2021-10-07 Thread Charles Gonçalves
Hello Guys, During some experiments in my PhD I've tried to reused a code from Jann Horn (https://bugs.chromium.org/p/project-zero/issues/detail?id=1184 ) that used the mapping in ``` 0x8040 - 0x807f [256GB, 2^38 bytes, PML4:256] Reserved for future shared info with the

Re: [XEN PATCH v7 16/51] build: generate "include/xen/compile.h" with if_changed

2021-10-07 Thread Jan Beulich
On 24.08.2021 12:50, Anthony PERARD wrote: > --- a/.gitignore > +++ b/.gitignore > @@ -332,7 +332,6 @@ xen/include/compat/* > xen/include/config/ > xen/include/generated/ > xen/include/public/public > -xen/include/xen/*.new While this indeed looks to only have been here for compile.h, I'm not

Re: [PATCH V5 2/3] libxl/arm: Add handling of extended regions for DomU

2021-10-07 Thread Oleksandr
On 07.10.21 13:57, Ian Jackson wrote: Hi Ian. Stefano Stabellini writes ("Re: [PATCH V5 2/3] libxl/arm: Add handling of extended regions for DomU"): On Wed, 6 Oct 2021, Oleksandr wrote: On 06.10.21 14:34, Ian Jackson wrote: Oleksandr Tyshchenko writes ("[PATCH V5 2/3] libxl/arm: Add

Xen Security Advisory 386 v2 (CVE-2021-28702) - PCI devices with RMRRs not deassigned correctly

2021-10-07 Thread Xen . org security team
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory CVE-2021-28702 / XSA-386 version 2 PCI devices with RMRRs not deassigned correctly UPDATES IN VERSION 2 Updated/corrected information about

[linux-5.4 test] 165392: regressions - FAIL

2021-10-07 Thread osstest service owner
flight 165392 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/165392/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit1 14 guest-start fail REGR. vs. 165206 Tests which are

Re: [PATCH v4 1/3] arm/efi: Introduce xen,uefi-cfg-load DT property

2021-10-07 Thread Luca Fancellu
> On 6 Oct 2021, at 19:32, Julien Grall wrote: > > Hi Luca, > > Sorry for jumping late in the conversation. While skimming through what has > been committed, I noticed one potential issue in this patch and have also a > question. > > On 30/09/2021 16:28, Luca Fancellu wrote: >> Introduce

Re: [XEN PATCH v7 14/51] xen: move include/asm-* to arch/*/include/asm

2021-10-07 Thread Jan Beulich
On 24.08.2021 12:50, Anthony PERARD wrote: > This avoid the need to create the symbolic link "include/asm". > > Whenever a comment refer to an "asm" headers, this patch avoid > spelling the arch when not needed to avoid some code churn. > > One unrelated change is to sort entries in MAINTAINERS

[libvirt test] 165395: regressions - FAIL

2021-10-07 Thread osstest service owner
flight 165395 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/165395/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-armhf-libvirt

Re: [XEN PATCH v7 13/51] build: convert binfile use to if_changed

2021-10-07 Thread Jan Beulich
On 24.08.2021 12:50, Anthony PERARD wrote: > This will allow to detect command line changes and allow to regenerate > the file in that case. > > Signed-off-by: Anthony PERARD Acked-by: Jan Beulich

Re: [PATCH V5 1/3] xen/arm: Introduce gpaddr_bits field to struct xen_arch_domainconfig

2021-10-07 Thread Jan Beulich
On 07.10.2021 15:12, Oleksandr wrote: > > On 07.10.21 15:43, Jan Beulich wrote: > > Hi Jan. > >> On 07.10.2021 14:30, Oleksandr wrote: >>> On 07.10.21 10:42, Jan Beulich wrote: On 06.10.2021 13:22, Oleksandr Tyshchenko wrote: > Changes V4 -> V5: > - update patch subject and

Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-07 Thread Jan Beulich
On 06.10.2021 19:40, Rahul Singh wrote: > --- /dev/null > +++ b/xen/arch/arm/vpci.c > @@ -0,0 +1,102 @@ > +/* > + * xen/arch/arm/vpci.c > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + *

Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in libxl

2021-10-07 Thread Rahul Singh
Hi Ian > On 7 Oct 2021, at 11:50 am, Ian Jackson wrote: > > Rahul Singh writes ("Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree > node in libxl"): >> On 6 Oct 2021, at 12:33 pm, Ian Jackson wrote: >>> We try >>> to make the libxl API "do the right thing" by default. In this case I

Re: [PATCH V5 1/3] xen/arm: Introduce gpaddr_bits field to struct xen_arch_domainconfig

2021-10-07 Thread Oleksandr
On 07.10.21 15:43, Jan Beulich wrote: Hi Jan. On 07.10.2021 14:30, Oleksandr wrote: On 07.10.21 10:42, Jan Beulich wrote: On 06.10.2021 13:22, Oleksandr Tyshchenko wrote: Changes V4 -> V5: - update patch subject and description - drop Michal's R-b - pass gpaddr_bits via

Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag

2021-10-07 Thread Jan Beulich
On 06.10.2021 19:40, Rahul Singh wrote: > --- a/xen/include/public/domctl.h > +++ b/xen/include/public/domctl.h > @@ -70,9 +70,11 @@ struct xen_domctl_createdomain { > #define XEN_DOMCTL_CDF_iommu (1U<<_XEN_DOMCTL_CDF_iommu) > #define _XEN_DOMCTL_CDF_nested_virt 6 > #define

Re: [PATCH v5 03/11] xen/arm: Add cmdline boot option "pci-passthrough = "

2021-10-07 Thread Jan Beulich
On 06.10.2021 19:40, Rahul Singh wrote: > Add cmdline boot option "pci-passthrough = = " to enable or > disable the PCI passthrough support on ARM. > > Signed-off-by: Rahul Singh > Reviewed-by: Stefano Stabellini > Reviewed-by: Bertrand Marquis Acked-by: Jan Beulich

Re: [PATCH v5 02/11] xen/arm: Add PHYSDEVOP_pci_device_(*add/remove) support for ARM

2021-10-07 Thread Jan Beulich
On 07.10.2021 02:05, Stefano Stabellini wrote: > On Wed, 6 Oct 2021, Rahul Singh wrote: >> Hardware domain is in charge of doing the PCI enumeration and will >> discover the PCI devices and then will communicate to XEN via hyper >> call PHYSDEVOP_pci_device_add(..) to add the PCI devices in XEN.

Re: [PATCH V5 1/3] xen/arm: Introduce gpaddr_bits field to struct xen_arch_domainconfig

2021-10-07 Thread Jan Beulich
On 07.10.2021 14:30, Oleksandr wrote: > On 07.10.21 10:42, Jan Beulich wrote: >> On 06.10.2021 13:22, Oleksandr Tyshchenko wrote: >>> Changes V4 -> V5: >>> - update patch subject and description >>> - drop Michal's R-b >>> - pass gpaddr_bits via createdomain domctl >>> (struct

Re: [PATCH V5 1/3] xen/arm: Introduce gpaddr_bits field to struct xen_arch_domainconfig

2021-10-07 Thread Oleksandr
On 07.10.21 10:42, Jan Beulich wrote: Hi Jan. On 06.10.2021 13:22, Oleksandr Tyshchenko wrote: Changes V4 -> V5: - update patch subject and description - drop Michal's R-b - pass gpaddr_bits via createdomain domctl (struct xen_arch_domainconfig) I'm afraid I can't bring

[qemu-mainline test] 165390: regressions - FAIL

2021-10-07 Thread osstest service owner
flight 165390 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/165390/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-libvirt-raw 17 guest-start/debian.repeat fail REGR. vs. 164950 Tests which are

Re: [RFC 1/1] xen/arm: set iommu property for IOMMU-protected devices

2021-10-07 Thread Roman Skakun
Hi Oleksandr, >> From: Roman Skakun >> >> Xen is not exposing any IOMMU properties to Dom0. >> So Dom0 assumes that all it's devices are not protected by IOMMU. >> >> To make Dom0 aware of IOMMU-protected devices, we need to mark >> them somehow. With this approach Dom0 Linux kernel will be able

Re: [PATCH V5 2/3] libxl/arm: Add handling of extended regions for DomU

2021-10-07 Thread Ian Jackson
Stefano Stabellini writes ("Re: [PATCH V5 2/3] libxl/arm: Add handling of extended regions for DomU"): > On Wed, 6 Oct 2021, Oleksandr wrote: > > On 06.10.21 14:34, Ian Jackson wrote: > > > Oleksandr Tyshchenko writes ("[PATCH V5 2/3] libxl/arm: Add handling of > > > extended regions for DomU"):

Re: [PATCH v5 10/11] arm/libxl: Emulated PCI device tree node in libxl

2021-10-07 Thread Ian Jackson
Julien Grall writes ("Re: [PATCH v5 10/11] arm/libxl: Emulated PCI device tree node in libxl"): > On 06/10/2021 19:40, Rahul Singh wrote: > > diff --git a/tools/libs/light/libxl_types.idl > > b/tools/libs/light/libxl_types.idl > > index 3f9fff653a..78b1ddf0b8 100644 > > ---

Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in libxl

2021-10-07 Thread Ian Jackson
Rahul Singh writes ("Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in libxl"): > On 6 Oct 2021, at 12:33 pm, Ian Jackson wrote: > > We try > > to make the libxl API "do the right thing" by default. In this case I > > think that means to enable VPCI (i) on platforms where it's

Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in libxl

2021-10-07 Thread Rahul Singh
Hi Julien, > On 6 Oct 2021, at 6:53 pm, Julien Grall wrote: > > Hi Rahul, > > On 06/10/2021 19:34, Rahul Singh wrote: >>> On 6 Oct 2021, at 12:33 pm, Ian Jackson wrote: >>> >>> Rahul Singh writes ("Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device >>> tree node in libxl"): Hi Ian

Re: [PATCH] x86/spec-ctrl: Build with BRANCH_HARDEN lfences by default

2021-10-07 Thread Jan Beulich
On 05.10.2021 13:11, Andrew Cooper wrote: > Branch Harden is enabled by default at compile and boot time. Invert the code > to compile with lfence by default and nop out in the non-default case. > > This has several advantages. It removes 3829 patch points (in the random > build of Xen I have

Re: [PATCH v2 3/3] xen: Expose the PMU to the guests

2021-10-07 Thread Jan Beulich
On 07.10.2021 10:21, Michal Orzel wrote: > Hi Jan, > > On 07.10.2021 10:03, Jan Beulich wrote: >> On 06.10.2021 12:58, Michal Orzel wrote: >>> --- a/xen/arch/x86/domain.c >>> +++ b/xen/arch/x86/domain.c >>> @@ -692,6 +692,12 @@ int arch_sanitise_domain_config(struct >>> xen_domctl_createdomain

Re: [PATCH v5 03/11] xen/arm: Add cmdline boot option "pci-passthrough = "

2021-10-07 Thread Rahul Singh
Hi Jan, > On 7 Oct 2021, at 9:27 am, Jan Beulich wrote: > > On 06.10.2021 19:40, Rahul Singh wrote: >> @@ -62,8 +63,19 @@ static int __init acpi_pci_init(void) >> } >> #endif >> >> +/* By default pci passthrough is disabled. */ >> +bool __read_mostly pci_passthrough_enabled; > > You properly

Re: [PATCH v5 03/11] xen/arm: Add cmdline boot option "pci-passthrough = "

2021-10-07 Thread Jan Beulich
On 06.10.2021 19:40, Rahul Singh wrote: > @@ -62,8 +63,19 @@ static int __init acpi_pci_init(void) > } > #endif > > +/* By default pci passthrough is disabled. */ > +bool __read_mostly pci_passthrough_enabled; You properly use "bool " here. Why ... > --- a/xen/include/asm-arm/pci.h > +++

Re: [PATCH v2 3/3] xen: Expose the PMU to the guests

2021-10-07 Thread Michal Orzel
Hi Jan, On 07.10.2021 10:03, Jan Beulich wrote: > On 06.10.2021 12:58, Michal Orzel wrote: >> --- a/xen/arch/x86/domain.c >> +++ b/xen/arch/x86/domain.c >> @@ -692,6 +692,12 @@ int arch_sanitise_domain_config(struct >> xen_domctl_createdomain *config) >> return -EINVAL; >> } >>

[xen-unstable test] 165388: tolerable FAIL - PUSHED

2021-10-07 Thread osstest service owner
flight 165388 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/165388/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 165371 test-armhf-armhf-libvirt 16

Re: [PATCH v2 1/3] xen+tools: Introduce XEN_SYSCTL_PHYSCAP_vpmu

2021-10-07 Thread Jan Beulich
On 07.10.2021 10:02, Michal Orzel wrote: > On 07.10.2021 09:59, Jan Beulich wrote: >> On 06.10.2021 12:58, Michal Orzel wrote: >>> Introduce flag XEN_SYSCTL_PHYSCAP_vpmu which >>> indicates whether the platform supports vPMU >>> functionality. Modify Xen and tools accordingly. >>> >>> Take the

Re: [PATCH v2 3/3] xen: Expose the PMU to the guests

2021-10-07 Thread Jan Beulich
On 06.10.2021 12:58, Michal Orzel wrote: > --- a/xen/arch/x86/domain.c > +++ b/xen/arch/x86/domain.c > @@ -692,6 +692,12 @@ int arch_sanitise_domain_config(struct > xen_domctl_createdomain *config) > return -EINVAL; > } > > +if ( config->flags & XEN_DOMCTL_CDF_vpmu ) > +{

Re: [PATCH v2 1/3] xen+tools: Introduce XEN_SYSCTL_PHYSCAP_vpmu

2021-10-07 Thread Michal Orzel
Hi, On 07.10.2021 09:59, Jan Beulich wrote: > On 06.10.2021 12:58, Michal Orzel wrote: >> Introduce flag XEN_SYSCTL_PHYSCAP_vpmu which >> indicates whether the platform supports vPMU >> functionality. Modify Xen and tools accordingly. >> >> Take the opportunity and fix XEN_SYSCTL_PHYSCAP_vmtrace

Re: [PATCH v2 1/3] xen+tools: Introduce XEN_SYSCTL_PHYSCAP_vpmu

2021-10-07 Thread Jan Beulich
On 06.10.2021 12:58, Michal Orzel wrote: > Introduce flag XEN_SYSCTL_PHYSCAP_vpmu which > indicates whether the platform supports vPMU > functionality. Modify Xen and tools accordingly. > > Take the opportunity and fix XEN_SYSCTL_PHYSCAP_vmtrace > definition in sysctl.h which wrongly uses (1<<6)

Re: [PATCH V5 1/3] xen/arm: Introduce gpaddr_bits field to struct xen_arch_domainconfig

2021-10-07 Thread Jan Beulich
On 06.10.2021 13:22, Oleksandr Tyshchenko wrote: > Changes V4 -> V5: >- update patch subject and description >- drop Michal's R-b >- pass gpaddr_bits via createdomain domctl > (struct xen_arch_domainconfig) I'm afraid I can't bring this in line with ... > ---

Re: [PATCH v3 04/11] vpci/header: Add and remove register handlers dynamically

2021-10-07 Thread Jan Beulich
On 04.10.2021 07:58, Oleksandr Andrushchenko wrote: > > > On 01.10.21 16:26, Jan Beulich wrote: >> On 30.09.2021 09:52, Oleksandr Andrushchenko wrote: >>> @@ -445,14 +456,25 @@ static void rom_write(const struct pci_dev *pdev, >>> unsigned int reg, >>> rom->addr = val &

Re: HVM/PVH Balloon crash

2021-10-07 Thread Jan Beulich
On 02.10.2021 04:35, Elliott Mitchell wrote: > On Thu, Sep 30, 2021 at 09:08:34AM +0200, Jan Beulich wrote: >> On 29.09.2021 17:31, Elliott Mitchell wrote: >>> >>> Copy and paste from the xl.cfg man page: >>> >>>nestedhvm=BOOLEAN >>>Enable or disables guest access to hardware

Re: [PATCH v4 2/3] arm/efi: Use dom0less configuration when using EFI boot

2021-10-07 Thread Jan Beulich
On 01.10.2021 17:13, Luca Fancellu wrote: > > >> On 1 Oct 2021, at 15:22, Jan Beulich wrote: >> >> On 01.10.2021 15:55, Luca Fancellu wrote: On 1 Oct 2021, at 12:02, Jan Beulich wrote: On 30.09.2021 16:28, Luca Fancellu wrote: > @@ -1361,12 +1361,30 @@ efi_start(EFI_HANDLE