Re: [PATCH v4 01/17] perf: Protect perf_guest_cbs with RCU

2021-11-11 Thread Paolo Bonzini
On 11/11/21 11:47, Peter Zijlstra wrote: This technically could be RCU_INIT_POINTER but it's not worth a respin. There are dozens of other occurrences, and if somebody wanted they could use Coccinelle to fix all of them. I've been pushing the other way, trying to get rid of RCU_INIT_POINTER()

[XEN][RFC PATCH v4 0/1] Update libfdt to v1.6.1

2021-11-11 Thread Vikram Garhwal
This update is done to support device tree overlays functionality. This is taken from David Gibson's DTC git: github.com/dgibson/dtc. Change log: v3 -> v4: Remove unnecessary config.h and stdbool.h header includes from libfdt_env.h. v2 -> v3: Include version.lds changes. v1 -> v2:

[ovmf test] 166120: all pass - PUSHED

2021-11-11 Thread osstest service owner
flight 166120 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/166120/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf a92559671a3bbdbc154429cf66edf4f490bbe218 baseline version: ovmf

[linux-linus test] 166117: regressions - FAIL

2021-11-11 Thread osstest service owner
flight 166117 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/166117/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-coresched-amd64-xl 14 guest-start fail REGR. vs. 165976

RE: ACPI/UEFI support for Xen/ARM status?

2021-11-11 Thread Henry Wang
Hi Elliott, > -Original Message- > From: Xen-devel On Behalf Of > Elliott Mitchell > Sent: Friday, November 12, 2021 12:28 PM > To: Stefano Stabellini ; Julien Grall > Cc: xen-devel@lists.xenproject.org > Subject: ACPI/UEFI support for Xen/ARM status? > > I've been busy with another

ACPI/UEFI support for Xen/ARM status?

2021-11-11 Thread Elliott Mitchell
I've been busy with another part of this project, so I've lost track of progress on ACPI/UEFI support on ARM. Last I'd read full support for ACPI/UEFI seemed a ways off. Using a stub domain to constrain ACPI table parsing seemed the favored approach. I was under the impression that would take

[qemu-mainline test] 166115: tolerable FAIL - PUSHED

2021-11-11 Thread osstest service owner
flight 166115 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/166115/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail like 166110

[xen-unstable-smoke test] 166116: tolerable all pass - PUSHED

2021-11-11 Thread osstest service owner
flight 166116 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/166116/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [PATCH v4 16/17] KVM: arm64: Drop perf.c and fold its tiny bits of code into arm.c

2021-11-11 Thread Marc Zyngier
On Thu, 11 Nov 2021 02:07:37 +, Sean Christopherson wrote: > > Call KVM's (un)register perf callbacks helpers directly from arm.c and > delete perf.c > > No functional change intended. > > Signed-off-by: Sean Christopherson Reviewed-by: Marc Zyngier M. -- Without deviation

Re: [PATCH v4 15/17] KVM: arm64: Hide kvm_arm_pmu_available behind CONFIG_HW_PERF_EVENTS=y

2021-11-11 Thread Marc Zyngier
On Thu, 11 Nov 2021 02:07:36 +, Sean Christopherson wrote: > > Move the definition of kvm_arm_pmu_available to pmu-emul.c and, out of > "necessity", hide it behind CONFIG_HW_PERF_EVENTS. Provide a stub for > the key's wrapper, kvm_arm_support_pmu_v3(). Moving the key's definition > out of

Re: [XEN][RFC PATCH v2 10/12] tools/libs/ctrl: Implement new xc interfaces for dt overlay

2021-11-11 Thread Vikram Garhwal
On Thu, Nov 11, 2021 at 04:54:25PM +, Anthony PERARD wrote: Hi Anthony, > On Mon, Nov 08, 2021 at 11:02:25PM -0800, Vikram Garhwal wrote: > > xc_dt_overlay() sends the device tree binary overlay, size of .dtbo and > > overlay > > operation type i.e. add or remove to xen. > > > >

[linux-linus test] 166113: regressions - FAIL

2021-11-11 Thread osstest service owner
flight 166113 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/166113/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-coresched-amd64-xl 14 guest-start fail REGR. vs. 165976

Re: [PATCH 3/5] xen/sort: Switch to an extern inline implementation

2021-11-11 Thread Julien Grall
Hi Andrew, On 11/11/2021 17:57, Andrew Cooper wrote: There are exactly 3 callers of sort() in the hypervisor. Both arm callers pass in NULL for the swap function. While this might seem like an attractive option at first, it causes generic_swap() to be used which forced a byte-wise copy.

[PATCH 0/5] xen: various function pointer cleanups

2021-11-11 Thread Andrew Cooper
Passing CI runs: https://cirrus-ci.com/build/6095362789212160 https://gitlab.com/xen-project/people/andyhhp/xen/-/pipelines/407123417 Andrew Cooper (5): xen/domain: Remove function pointers from domain pause helpers xen/domain: Improve pirq handling xen/sort: Switch to an extern inline

[PATCH 1/5] xen/domain: Remove function pointers from domain pause helpers

2021-11-11 Thread Andrew Cooper
Retpolines are expensive, and all these do are select between the sync and nosync helpers. Pass a boolean instead, and use direct calls everywhere. Pause/unpause operations on behalf of dom0 are not fastpaths, so avoid exposing the __domain_pause_by_systemcontroller() internal. This actually

[PATCH 4/5] xen/wait: Remove indirect jump

2021-11-11 Thread Andrew Cooper
There is no need for this to be an indirect jump at all. Execution always returns to a specific location, so use a direct jump instead. Use a named label for the jump. As both 1 and 2 have disappeared as labels, rename 3 to skip to better describe its purpose. Signed-off-by: Andrew Cooper ---

[PATCH 2/5] xen/domain: Improve pirq handling

2021-11-11 Thread Andrew Cooper
free_pirq_struct() has no external users, so shouldn't be exposed. Making it static necessitates moving the function as domain_destroy() uses it. Rework pirq_get_info() to have easier-to-follow logic. The one functional change is to the insertion failure path; we should not be using a full

[PATCH 5/5] x86/ioapic: Drop function pointers from __ioapic_{read,write}_entry()

2021-11-11 Thread Andrew Cooper
Function pointers are expensive, and the raw parameter is a constant from all callers, meaning that it predicts very well with local branch history. Furthermore, the knock-on effects are quite impressive. $ ../scripts/bloat-o-meter xen-syms-before xen-syms-after add/remove: 0/4 grow/shrink:

[PATCH 3/5] xen/sort: Switch to an extern inline implementation

2021-11-11 Thread Andrew Cooper
There are exactly 3 callers of sort() in the hypervisor. Both arm callers pass in NULL for the swap function. While this might seem like an attractive option at first, it causes generic_swap() to be used which forced a byte-wise copy. Provide real swap functions which the compiler can optimise

Re: [XEN][RFC PATCH v2 10/12] tools/libs/ctrl: Implement new xc interfaces for dt overlay

2021-11-11 Thread Anthony PERARD
On Mon, Nov 08, 2021 at 11:02:25PM -0800, Vikram Garhwal wrote: > xc_dt_overlay() sends the device tree binary overlay, size of .dtbo and > overlay > operation type i.e. add or remove to xen. > > Signed-off-by: Vikram Garhwal > --- > tools/include/xenctrl.h | 5 + >

Re: [XEN][RFC PATCH v2 11/12] tools/libs/light: Implement new libxl functions for device tree overlay ops

2021-11-11 Thread Anthony PERARD
On Mon, Nov 08, 2021 at 11:02:26PM -0800, Vikram Garhwal wrote: > Signed-off-by: Vikram Garhwal > --- > tools/include/libxl.h| 5 > tools/libs/light/Makefile| 3 ++ > tools/libs/light/libxl_overlay.c | 65 > > 3 files changed,

Re: [PATCH v2.2 07/15] xen: generate hypercall interface related code

2021-11-11 Thread Anthony PERARD
On Wed, Nov 03, 2021 at 11:20:59AM +0100, Juergen Gross wrote: > diff --git a/xen/Makefile b/xen/Makefile > index a3189eb47c..dfdae47e74 100644 > --- a/xen/Makefile > +++ b/xen/Makefile > @@ -405,6 +406,7 @@ $(TARGET): delete-unfresh-files > $(MAKE) -f $(BASEDIR)/Rules.mk -C include >

Re: [PATCH v2] MAINTAINERS: add Bertrand to the ARM reviewers

2021-11-11 Thread Ian Jackson
Julien Grall writes ("Re: [PATCH v2] MAINTAINERS: add Bertrand to the ARM reviewers"): > (+ Ian) > > On 05/11/2021 15:44, Stefano Stabellini wrote: > > Signed-off-by: Stefano Stabellini > > Acked-by: Julien Grall > > @Ian, do we need a release-acked-by for this? No, it's fine, but for the

Re: [PATCH v3] xen/arm: don't assign domU static-mem to dom0 as reserved-memory

2021-11-11 Thread Ian Jackson
Julien Grall writes ("Re: [PATCH v3] xen/arm: don't assign domU static-mem to dom0 as reserved-memory"): > The first version of the patch [1] was tagged with for-4.16 and contains > the rationale. > > I was thinking to commit it because it already contains your > release-acked-by. Can you let

Re: [PATCH v5] tools/xl: fix autoballoon regex

2021-11-11 Thread Anthony PERARD
On Tue, Nov 09, 2021 at 07:17:53PM +0300, Dmitry Isaykin wrote: > Up The patch as been committed ;-) https://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=2faeb4213d9b412836fe80e5685bf51feb92 Cheers, -- Anthony PERARD

Re: [PATCH for-4.16] x86/cpuid: prevent shrinking migrated policies max leaves

2021-11-11 Thread Roger Pau Monné
On Thu, Nov 11, 2021 at 10:26:29AM +0100, Jan Beulich wrote: > On 10.11.2021 19:17, Andrew Cooper wrote: > > On 10/11/2021 17:40, Roger Pau Monne wrote: > >> diff --git a/tools/libs/guest/xg_cpuid_x86.c > >> b/tools/libs/guest/xg_cpuid_x86.c > >> index 198892ebdf..3ffd5f683b 100644 > >> ---

Re: [PATCH v3] xen/arm: don't assign domU static-mem to dom0 as reserved-memory

2021-11-11 Thread Julien Grall
Hi Ian, On 11/11/2021 13:33, Ian Jackson wrote: Julien Grall writes ("Re: [PATCH v3] xen/arm: don't assign domU static-mem to dom0 as reserved-memory"): Hi Stefano, On 10/11/2021 20:18, Stefano Stabellini wrote: From: Stefano Stabellini DomUs static-mem ranges are added to the

Re: [PATCH v3] xen/arm: don't assign domU static-mem to dom0 as reserved-memory

2021-11-11 Thread Ian Jackson
Julien Grall writes ("Re: [PATCH v3] xen/arm: don't assign domU static-mem to dom0 as reserved-memory"): > Hi Stefano, > > On 10/11/2021 20:18, Stefano Stabellini wrote: > > From: Stefano Stabellini > > > > DomUs static-mem ranges are added to the reserved_mem array for > > accounting, but

Re: [PATCH] x86/smp: Factor out parts of native_smp_prepare_cpus()

2021-11-11 Thread Josef Johansson
On 11/11/21 11:15, Peter Zijlstra wrote: > On Wed, Nov 10, 2021 at 10:52:09PM +0100, Josef Johansson wrote: >> On 11/3/21 00:36, Boris Ostrovsky wrote: >>> Commit 66558b730f25 ("sched: Add cluster scheduler level for x86") >>> introduced cpu_l2c_shared_map mask which is expected to be initialized

[ovmf test] 166114: all pass - PUSHED

2021-11-11 Thread osstest service owner
flight 166114 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/166114/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 22c3b5a865ec800b7eecf43de336ad5e2d917a08 baseline version: ovmf

Re: [PATCH v2 for-4.16] xen/arm: allocate_bank_memory: don't create memory banks of size zero

2021-11-11 Thread Julien Grall
Hi Stefano, On 10/11/2021 20:55, Stefano Stabellini wrote: From: Stefano Stabellini allocate_bank_memory can be called with a tot_size of zero, as an example see the implementation of allocate_memory which can call allocate_bank_memory with a tot_size of zero for the second memory bank. If

Re: [PATCH v4 00/17] perf: KVM: Fix, optimize, and clean up callbacks

2021-11-11 Thread Peter Zijlstra
On Thu, Nov 11, 2021 at 02:07:21AM +, Sean Christopherson wrote: > Like Xu (1): > perf/core: Rework guest callbacks to prepare for static_call support > > Sean Christopherson (16): > perf: Protect perf_guest_cbs with RCU > KVM: x86: Register perf callbacks after calling vendor's >

Re: [PATCH v3] xen/arm: don't assign domU static-mem to dom0 as reserved-memory

2021-11-11 Thread Julien Grall
Hi Stefano, On 10/11/2021 20:18, Stefano Stabellini wrote: From: Stefano Stabellini DomUs static-mem ranges are added to the reserved_mem array for accounting, but they shouldn't be assigned to dom0 as the other regular reserved-memory ranges in device tree. In make_memory_nodes, fix the

Re: [PATCH] xen/cpufreq: Reset policy after enabling/disabling turbo status

2021-11-11 Thread Jan Beulich
On 10.11.2021 13:39, Roger Pau Monné wrote: > On Wed, Nov 10, 2021 at 09:19:35AM +, Jane Malalane wrote: >> --- a/xen/drivers/cpufreq/utility.c >> +++ b/xen/drivers/cpufreq/utility.c >> @@ -417,10 +417,14 @@ int cpufreq_update_turbo(int cpuid, int new_state) >> { >> ret =

Re: [PATCH] xen/cpufreq: Reset policy after enabling/disabling turbo status

2021-11-11 Thread Jan Beulich
On 10.11.2021 10:19, Jane Malalane wrote: > Before, user would change turbo status but this had no effect: boolean > was set but policy wasn't reevaluated. Policy must be reevaluated so > that CPU frequency is chosen according to the turbo status and the > current governor. Aiui this only (or at

Re: [PATCH v2 for-4.16] xen/arm: allocate_bank_memory: don't create memory banks of size zero

2021-11-11 Thread Ian Jackson
To the maiontainer who will review this: could you please consider these comments as part of your review: Stefano Stabellini writes ("[PATCH v2 for-4.16] xen/arm: allocate_bank_memory: don't create memory banks of size zero"): > From: Stefano Stabellini > In regards to inclusion in 4.16. > >

Re: [PATCH v4 01/17] perf: Protect perf_guest_cbs with RCU

2021-11-11 Thread Peter Zijlstra
On Thu, Nov 11, 2021 at 08:26:58AM +0100, Paolo Bonzini wrote: > On 11/11/21 03:07, Sean Christopherson wrote: > > EXPORT_SYMBOL_GPL(perf_register_guest_info_callbacks); > > int perf_unregister_guest_info_callbacks(struct perf_guest_info_callbacks > > *cbs) > > { > > - perf_guest_cbs =

[xen-unstable test] 166111: tolerable FAIL

2021-11-11 Thread osstest service owner
flight 166111 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/166111/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-arm64-arm64-xl-seattle 8 xen-boot fail in 166106 pass in 166111 test-armhf-armhf-xl-rtds 18

Re: [PATCH] x86/smp: Factor out parts of native_smp_prepare_cpus()

2021-11-11 Thread Peter Zijlstra
On Wed, Nov 10, 2021 at 10:52:09PM +0100, Josef Johansson wrote: > On 11/3/21 00:36, Boris Ostrovsky wrote: > > Commit 66558b730f25 ("sched: Add cluster scheduler level for x86") > > introduced cpu_l2c_shared_map mask which is expected to be initialized > > by smp_op.smp_prepare_cpus(). That

[libvirt test] 166112: regressions - FAIL

2021-11-11 Thread osstest service owner
flight 166112 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/166112/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-arm64-libvirt

Re: [PATCH 0/3][4.16?] VT-d: misc (regression) fixes

2021-11-11 Thread Jan Beulich
On 09.11.2021 15:55, Jan Beulich wrote: > 1: per-domain IOMMU bitmap needs to have dynamic size > 2: fix reduced page table levels support when sharing tables > 3: don't needlessly engage the untrusted-MSI workaround > > As to 4.16 considerations: Only patch 1 addresses a regression > introduced

Re: [PATCH for-4.16] x86/cpuid: prevent shrinking migrated policies max leaves

2021-11-11 Thread Jan Beulich
On 10.11.2021 19:17, Andrew Cooper wrote: > On 10/11/2021 17:40, Roger Pau Monne wrote: >> diff --git a/tools/libs/guest/xg_cpuid_x86.c >> b/tools/libs/guest/xg_cpuid_x86.c >> index 198892ebdf..3ffd5f683b 100644 >> --- a/tools/libs/guest/xg_cpuid_x86.c >> +++ b/tools/libs/guest/xg_cpuid_x86.c >>

RE: [PATCH v3] xen/arm: don't assign domU static-mem to dom0 as reserved-memory

2021-11-11 Thread Penny Zheng
Hi Stefano > -Original Message- > From: Stefano Stabellini > Sent: Thursday, November 11, 2021 4:18 AM > To: jul...@xen.org > Cc: sstabell...@kernel.org; Penny Zheng ; Bertrand > Marquis ; Wei Chen ; > i...@xenproject.org; volodymyr_babc...@epam.com; xen- > de...@lists.xenproject.org;