[Xen-devel] [PATCH v2 13/35] libxl_dm: Update libxl__spawn_stub_dm to use libxl__domain_unpause

2019-09-19 Thread Anthony PERARD
Signed-off-by: Anthony PERARD Acked-by: Ian Jackson --- tools/libxl/libxl_dm.c | 22 +- tools/libxl/libxl_internal.h | 1 + 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c index 246c570121d3..c00356a2f16a

[Xen-devel] [PATCH v2 31/35] libxl: Use ev_qmp for libxl_send_trigger

2019-09-19 Thread Anthony PERARD
Signed-off-by: Anthony PERARD Acked-by: Ian Jackson --- tools/libxl/libxl_domain.c | 49 ++-- tools/libxl/libxl_internal.h | 2 -- tools/libxl/libxl_qmp.c | 5 3 files changed, 42 insertions(+), 14 deletions(-) diff --git a/tools/libxl

[Xen-devel] [PATCH v2 28/35] libxl_pci: Use ev_qmp in do_pci_add

2019-09-19 Thread Anthony PERARD
This patch also replaces the use of libxl__wait_for_device_model_deprecated() by its equivalent without the need for a thread. Signed-off-by: Anthony PERARD Acked-by: Ian Jackson --- tools/libxl/libxl_internal.h | 1 - tools/libxl/libxl_pci.c | 288

[Xen-devel] [PATCH v2 24/35] libxl: Remove libxl__qmp_run_command_flexarray

2019-09-19 Thread Anthony PERARD
There are no more users. Signed-off-by: Anthony PERARD Acked-by: Ian Jackson --- tools/libxl/libxl_internal.h | 3 --- tools/libxl/libxl_qmp.c | 16 2 files changed, 19 deletions(-) diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h index

Re: [Xen-devel] [PATCH v2 00/35] libxl refactoring to use ev_qmp (with API changes) [and 1 more messages]

2019-09-20 Thread Anthony PERARD
On Thu, Sep 19, 2019 at 08:17:43PM +0100, Ian Jackson wrote: > Anthony PERARD writes ("[PATCH v2 00/35] libxl refactoring to use ev_qmp > (with API changes)"): > > Patches with missing ackes: > ... > > libxl: Use ev_qmp in libxl_set_vcpuonline > > From m

[Xen-devel] [PATCH] tools/ocaml: Build fix following libxl API changes

2019-09-20 Thread Anthony PERARD
Fixes: 95627b87c3159928458ee586e8c5c593bdd248d8 Signed-off-by: Anthony PERARD --- Notes: Currently, all libxl API that takes an `ao_how` have `?async:'a -> unit` in the ocaml definition (and an extra unused value unit in the c stub file), is that `unit` needed ? I tried to add it,

Re: [Xen-devel] [PATCH] tools/ocaml: Build fix following libxl API changes

2019-09-20 Thread Anthony PERARD
On Fri, Sep 20, 2019 at 05:19:02PM +0100, Anthony PERARD wrote: > The following libxl API became asynchronous and gained an additional > `ao_how' parameter: > libxl_domain_pause() > libxl_domain_unpause() > libxl_send_trigger() > > Adapt the ocaml bindi

Re: [Xen-devel] [PATCH] xen-block: treat XenbusStateUnknown the same as XenbusStateClosed

2019-09-23 Thread Anthony PERARD
This patch simply treats a frontend state of XenbusStateUnknown the same > as XenbusStateClosed, which will unblock the backend in these circumstances. > > Reported-by: Mark Syms > Signed-off-by: Paul Durrant Acked-by: Anthony PERARD Thanks, -- Anthony PERARD __

[Xen-devel] [PATCH] libxl: Fix build when LIBXL_API_VERSION is set

2019-09-23 Thread Anthony PERARD
The compatibility function mistakenly called itself. Fixes: 95627b87c3159928458ee586e8c5c593bdd248d8 Signed-off-by: Anthony PERARD --- tools/libxl/libxl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libxl/libxl.h b/tools/libxl/libxl.h index ba48e7e900d3

Re: [Xen-devel] [PATCH] xen-bus: only set the xen device frontend state if it is missing

2019-09-23 Thread Anthony PERARD
set their state to Closing. If this has occurred then > device realize must not overwrite the frontend keys as then > the handshake will stall. > > Signed-off-by: Mark Syms > > Also avoid creating the frontend area if it already exists. > > Signed-off-by: Paul Durr

[Xen-devel] [PULL 7/7] xen-bus: only set the xen device frontend state if it is missing

2019-09-24 Thread Anthony PERARD
frontend keys as then the handshake will stall. Signed-off-by: Mark Syms Also avoid creating the frontend area if it already exists. Signed-off-by: Paul Durrant Reviewed-by: Anthony PERARD Message-Id: <20190918115745.39006-1-paul.durr...@citrix.com> Signed-off-by: Anthony PERARD ---

[Xen-devel] [PULL 5/7] MAINTAINERS: update my email address

2019-09-24 Thread Anthony PERARD
From: Paul Durrant My Citrix email address will expire shortly. Signed-off-by: Paul Durrant Reviewed-by: Anthony PERARD Message-Id: <20190913122418.848-1-paul.durr...@citrix.com> Signed-off-by: Anthony PERARD --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Xen-devel] [PULL 6/7] xen-block: treat XenbusStateUnknown the same as XenbusStateClosed

2019-09-24 Thread Anthony PERARD
, which will unblock the backend in these circumstances. Reported-by: Mark Syms Signed-off-by: Paul Durrant Acked-by: Anthony PERARD Reviewed-by: John Snow Message-Id: <20190918115702.38959-1-paul.durr...@citrix.com> Signed-off-by: Anthony PERARD --- hw/block/xen-block.c | 1 + 1 file c

[Xen-devel] [PULL 0/7] xen queue 2019-09-24

2019-09-24 Thread Anthony PERARD
The following changes since commit 2f93a3ecdd3bb060bd04f698ccafe66efd98563a: Merge remote-tracking branch 'remotes/davidhildenbrand/tags/s390x-tcg-2019-09-23' into staging (2019-09-23 15:44:52 +0100) are available in the Git repository at: https://xenbits.xen.org/git-http/people/aperard/qe

[Xen-devel] [PULL 2/7] xen / notify: introduce a new XenWatchList abstraction

2019-09-24 Thread Anthony PERARD
of adding an assertion that a XenWatchList is not freed whilst its associated NotifierList is still occupied. Signed-off-by: Paul Durrant Reviewed-by: Anthony Perard Message-Id: <20190913082159.31338-2-paul.durr...@citrix.com> Signed-off-by: Anthony PERARD --- hw/xen/trace-

[Xen-devel] [PULL 4/7] xen: perform XenDevice clean-up in XenBus watch handler

2019-09-24 Thread Anthony PERARD
ests contained therein only apply to a frontend. - use 'state' rather then 'xendev->backend_state' in xen_device_backend_changed() to shorten the code. Signed-off-by: Paul Durrant Reviewed-by: Anthony PERARD Message-Id: <20190913082159.31338-4-paul.durr...@citri

[Xen-devel] [PULL 3/7] xen: introduce separate XenWatchList for XenDevice objects

2019-09-24 Thread Anthony PERARD
: Anthony Perard Message-Id: <20190913082159.31338-3-paul.durr...@citrix.com> Signed-off-by: Anthony PERARD --- hw/xen/trace-events | 2 ++ hw/xen/xen-bus.c | 72 include/hw/xen/xen-bus.h | 2 ++ 3 files changed, 62 insertions(+), 14 del

[Xen-devel] [PULL 1/7] xen-bus: check whether the frontend is active during device reset...

2019-09-24 Thread Anthony PERARD
a check (now in a helper function) of 'state', which actually equates to 'xendev->backend_state'. This patch fixes the mistake. Fixes: cb3231460747552d70af9d546dc53d8195bcb796 Signed-off-by: Paul Durrant Reviewed-by: Anthony PERARD Message-Id: <20190910171753.3775-1-paul

Re: [Xen-devel] [PATCH v8 1/4] libxl: fix cold plugged PCI device with stubdomain

2019-09-30 Thread Anthony PERARD
gt;starting value. > > Fixes: 11db56f9a6 (libxl_pci: Use libxl__ao_device with libxl__device_pci_add) > Signed-off-by: Marek Marczykowski-Górecki Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v8 3/4] libxl: attach PCI device to qemu only after setting pciback/pcifront

2019-09-30 Thread Anthony PERARD
ng. > > Signed-off-by: Marek Marczykowski-Górecki > --- > Changes in v2: > - Fixed code style since previous version. > Changes in v8: > - rebase on staging > - rework for async api The patch looks good, I only have coding style comments. With those addressed: Reviewed-by: A

[Xen-devel] [PATCH 2/2] libxl_pci: Fix guest shutdown with PCI PT attached

2019-09-30 Thread Anthony PERARD
oom Fixes: fae4880c45fe015e567afa223f78bf17a6d98e1b Signed-off-by: Anthony PERARD --- tools/libxl/libxl_pci.c | 41 ++--- 1 file changed, 26 insertions(+), 15 deletions(-) diff --git a/tools/libxl/libxl_pci.c b/tools/libxl/libxl_pci.c index 3b31cfd417be..cb849b241581 100644 --- a/tools/libxl/l

[Xen-devel] [PATCH 1/2] libxl_pci: Don't ignore PCI PT error at guest creation

2019-09-30 Thread Anthony PERARD
Fixes: 11db56f9a6291 Signed-off-by: Anthony PERARD --- tools/libxl/libxl_pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/libxl/libxl_pci.c b/tools/libxl/libxl_pci.c index 47258177bc71..3b31cfd417be 100644 --- a/tools/libxl/libxl_pci.c +++ b/tools/libxl/libxl_pci.c @@ -1694,6

[Xen-devel] [PATCH 0/2] libxl fixes with pci passthrough

2019-09-30 Thread Anthony PERARD
Patch series available in this git branch: https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.fixes-for-pci-pt-libxl-v1 Hi, Some fixes following the recent changes to use ev_qmp in libxl. Anthony PERARD (2): libxl_pci: Don't ignore PCI PT error at guest creation libx

Re: [Xen-devel] Xen-unstable: regression when trying to shutdown HVM guest with pci passthrough

2019-09-30 Thread Anthony PERARD
_cb: Domain > 9:Destruction of domain failed destroy failed (rc=-9) > > Bisection turned up commit fae4880c45fe015e567afa223f78bf17a6d98e1b > "libxl_pci: Use ev_qmp for pci_remove" as the culprit. Thanks for the report and the bisection! I've sent a patch which I think should fix

[Xen-devel] [PATCH] tools/Makefile: Fix build of QEMU, remove --source-path

2019-05-02 Thread Anthony PERARD
.) Signed-off-by: Anthony PERARD --- This patch would unblock the qemu-mainline branch in osstest. --- tools/Makefile | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/Makefile b/tools/Makefile index c903d6a63e..99cbc950dc 100644 --- a/tools/Makefile +++ b/tools/Makefile @@ -246,7 +246,6

Re: [Xen-devel] [PATCH v3 3/4] libxl: add libxl_get_parameters() function

2019-05-13 Thread Anthony PERARD
t; 0) { LOG... rc = ERROR_FAIL; goto out; } rc=0; out: GC_FREE; return rc; > +} > + Thanks, -- Anthony PERARD ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 1/4] gitignore: ignore .vscode directory

2019-05-13 Thread Anthony PERARD
itignore > index 26bc583f74..3822bb75ba 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -30,6 +30,7 @@ cscope.out > cscope.po.out > .config > .vimrc > +.vscode Shouldn't this go in "~/.config/git/ignore" instead? Or whatever `git config core.excludesFile`

[Xen-devel] [PATCH] libxc: elf_kernel loader: Remove check for shstrtab

2019-05-15 Thread Anthony PERARD
clare a blob as compaptible with the PVH boot ABI. Note that without the ELFNOTE, libxc will load an ELF but with the plain ELF loader, which doesn't check for shstrtab. Signed-off-by: Anthony PERARD --- tools/libxc/xc_dom_elfloader.c | 9 - 1 file changed, 9 deletions(-) diff

Re: [Xen-devel] [PATCH] libxc: elf_kernel loader: Remove check for shstrtab

2019-05-15 Thread Anthony PERARD
On Wed, May 15, 2019 at 01:07:03PM +0100, Andrew Cooper wrote: > On 15/05/2019 12:40, Anthony PERARD wrote: > > This was probably useful to load ELF Note, but now ELF notes > > "should live in a PT_NOTE segment" (elfnote.h). > > > > With notes living in segmen

Re: [Xen-devel] [qemu-upstream-4.12-testing test] 136177: regressions - FAIL

2019-05-16 Thread Anthony PERARD
sult doesn't matter to qemu-upstream-* flights. Thanks, -- Anthony PERARD ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [qemu-upstream-4.11-testing test] 136184: regressions - FAIL

2019-05-16 Thread Anthony PERARD
Do you know what could cause xen to fail to boot? I don't believe a few more patch on top of qemu-xen would. Thanks, -- Anthony PERARD ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [qemu-upstream-4.10-testing test] 136181: FAIL

2019-05-16 Thread Anthony PERARD
st) is blocking? But that the -qcow2 test which now keeps failing isn't blocking? Anyway, the *arm64* tests succeed, and the *qcow2 test keeps failing. But the qcow2 issue seems to be a guest kernel thread failing to suspend, so not a bug in qemu, but a regression the guest used

[Xen-devel] [PATCH v2] libxc: elf_kernel loader: Remove check for shstrtab

2019-05-17 Thread Anthony PERARD
ote that without the ELFNOTE, libxc will load an ELF but with the plain ELF loader, which doesn't check for shstrtab. Signed-off-by: Anthony PERARD --- Notes: v2: Rework commit message, explain why the check is unnecessary. tools/libxc/xc_dom_elfloader.c | 9 - 1 file changed,

Re: [Xen-devel] [qemu-upstream-4.11-testing test] 136184: regressions - FAIL

2019-05-17 Thread Anthony PERARD
On Thu, May 16, 2019 at 10:38:54PM +0100, Julien Grall wrote: > Hi Anthony, > > Thank you for CCing me. > > On 5/16/19 11:37 AM, Anthony PERARD wrote: > > On Wed, May 15, 2019 at 07:48:17PM +, osstest service owner wrote: > > > flight 136184 qemu-upstream-4.11-

[Xen-devel] [PATCH qemu-xen 4.10 & 4.11] xen_disk: Disable file locking for the PV disk backend

2019-05-22 Thread Anthony PERARD
0 and 3.1 Signed-off-by: Anthony PERARD --- Hi Olaf, Roger, Wei, Instead of a fix in libxl (with the reverted patch "libxl: fix migration of PV and PVH domUs with and without qemu"), what do you think of this QEMU patch? It is much simpler that trying to work around the issue in li

Re: [Xen-devel] [PATCH qemu-xen 4.10 & 4.11] xen_disk: Disable file locking for the PV disk backend

2019-05-23 Thread Anthony PERARD
On Wed, May 22, 2019 at 07:54:42PM +0200, Olaf Hering wrote: > Am Wed, 22 May 2019 15:51:40 +0100 > schrieb Anthony PERARD : > > > Can you give it a try with one of the affected qemu? (qemu-xen-4.10 or > > qemu-xen-4.11) > > Thanks for the patch. Unfortunately there is

Re: [Xen-devel] Compiling Xen error on RedHat8.0

2019-05-24 Thread Anthony PERARD
d a softlink "python-config" to "python2-config" as well and the "checking for PyArg_ParseTuple" is more likely to succeed. Cheers, -- Anthony PERARD ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [qemu-upstream-4.11-testing test] 136184: regressions - FAIL

2019-06-03 Thread Anthony PERARD
Set-up page permission for Xen mappings earlier > on" This commit alone, cherry-picked on top of stable-4.11 makes xen boot on rochester. >- f60658c6ae "xen/arm: Stop relocating Xen" With that commit applied, xen doesn't build. So I couldn't try to boot it.

[Xen-devel] Ping: [PATCH 0/9] libxl: New slow lock + fix libxl_cdrom_insert with QEMU depriv

2019-06-04 Thread Anthony PERARD
Ping? On Tue, Apr 09, 2019 at 05:45:33PM +0100, Anthony PERARD wrote: > This patch series fix libxl_cdrom_insert to work with a depriviledge QEMU. For > that, we need to use libxl__ev_qmp. For that, we need a new lock because > userdata_lock can't be used anymore. > > Patch

Re: [Xen-devel] [PATCH qemu-xen 4.10 & 4.11] xen_disk: Disable file locking for the PV disk backend

2019-06-05 Thread Anthony PERARD
On Thu, May 23, 2019 at 10:41:48AM +0100, Anthony PERARD wrote: > On Wed, May 22, 2019 at 07:54:42PM +0200, Olaf Hering wrote: > > Am Wed, 22 May 2019 15:51:40 +0100 > > schrieb Anthony PERARD : > > > > > Can you give it a try with one of the affected qemu? (qemu-x

Re: [Xen-devel] 4.10.4 preparations

2019-06-05 Thread Anthony PERARD
apply a patch to the qemu-xen tree: https://lists.xenproject.org/archives/html/xen-devel/2019-05/msg01840.html -- Anthony PERARD ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 4/9] libxl_internal: Create new lock for devices hotplug via QMP

2019-06-05 Thread Anthony PERARD
On Tue, Jun 04, 2019 at 06:11:23PM +0100, Ian Jackson wrote: > Anthony PERARD writes ("[PATCH 4/9] libxl_internal: Create new lock for > devices hotplug via QMP"): > > The current lock `domain_userdata_lock' can't be used when modification > > to a guest is

Re: [Xen-devel] [PATCH 9/9] libxl_disk: Implement missing timeout for libxl_cdrom_insert

2019-06-05 Thread Anthony PERARD
On Tue, Jun 04, 2019 at 06:47:32PM +0100, Ian Jackson wrote: > Anthony PERARD writes ("[PATCH 9/9] libxl_disk: Implement missing timeout for > libxl_cdrom_insert"): > > Since the previous patch "libxl_disk: Use ev_qmp in libxl_cdrom_insert", > > there are no

Re: [Xen-devel] [PATCH 6/9] libxl_disk: Cut libxl_cdrom_insert into steps ..

2019-06-07 Thread Anthony PERARD
On Tue, Jun 04, 2019 at 06:29:14PM +0100, Ian Jackson wrote: > Anthony PERARD writes ("[PATCH 6/9] libxl_disk: Cut libxl_cdrom_insert into > steps .."): > > This patch cut libxl_cdrom_insert into different step/function but there > > are still called synchronously.

Re: [Xen-devel] Relevance of global lock (/var/lock/xl) in xl tool

2019-06-10 Thread Anthony PERARD
er xl instances from conflicting during this operation. So there are probably configurations where the lock isn't useful, or there are better ways to reserve memory for domain creation. -- Anthony PERARD ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v7 06/14] libxl_qmp: Implementation of libxl__ev_qmp_*

2019-01-03 Thread Anthony PERARD
On Fri, Dec 21, 2018 at 03:36:18PM +, Ian Jackson wrote: > Anthony PERARD writes ("[PATCH v7 06/14] libxl_qmp: Implementation of > libxl__ev_qmp_*"): > > This patch implement the API libxl__ev_qmp documented in the previous > > patch, "libxl: Design of an a

Re: [Xen-devel] [PATCH v7 06/14] libxl_qmp: Implementation of libxl__ev_qmp_*

2019-01-04 Thread Anthony PERARD
On Thu, Jan 03, 2019 at 12:40:18PM +, Anthony PERARD wrote: > On Fri, Dec 21, 2018 at 03:36:18PM +, Ian Jackson wrote: > > Anthony PERARD writes ("[PATCH v7 06/14] libxl_qmp: Implementation of > > libxl__ev_qmp_*"): > > > +static void qmp_ev_set_stat

Re: [Xen-devel] [PATCH v7 06/14] libxl_qmp: Implementation of libxl__ev_qmp_*

2019-01-04 Thread Anthony PERARD
On Fri, Jan 04, 2019 at 11:21:11AM +, Ian Jackson wrote: > Anthony PERARD writes ("Re: [PATCH v7 06/14] libxl_qmp: Implementation of > libxl__ev_qmp_*"): > > On Fri, Dec 21, 2018 at 03:36:18PM +, Ian Jackson wrote: > > > > +while (ev->tx_buf_off &

Re: [Xen-devel] [PATCH v7 01/14] libxl: Enhance libxl__sendmsg_fds to deal with EINTR and EWOULDBLOCK

2019-01-04 Thread Anthony PERARD
On Fri, Dec 21, 2018 at 02:30:05PM +, Ian Jackson wrote: > Anthony PERARD writes ("[PATCH v7 01/14] libxl: Enhance libxl__sendmsg_fds to > deal with EINTR and EWOULDBLOCK"): > > This patch change the behavior of libxl__sendmsg_fds to retry sendmsg on > > EINTR err

[Xen-devel] [PATCH v8 08/17] libxl: Add init/dispose of for libxl__domain_build_state

2019-01-04 Thread Anthony PERARD
These two new functions libxl__domain_build_state_{init,dispose} should be called every time a new libxl__domain_build_state comes to existance. There seems to be two of them, one with the domain creation machinery, and one in the stub_dm_spawn. Signed-off-by: Anthony PERARD Acked-by: Ian

[Xen-devel] [PATCH v8 02/17] libxl_qmp: Separate QMP message generation from qmp_send_prepare

2019-01-04 Thread Anthony PERARD
.. to be able to re-use qmp_prepare_cmd with libxl__ev_qmp. This patch also add the QMP end of command '\r\n' into the generated string as every caller will needs this. There should be no functional change. Signed-off-by: Anthony PERARD Acked-by: Ian Jackson --- Notes: v8:

[Xen-devel] [PATCH v8 01/17] libxl: Enhance libxl__sendmsg_fds to deal with EINTR and EWOULDBLOCK

2019-01-04 Thread Anthony PERARD
-blocking fds a EWOULDBLOCK error would mean that the fds haven't been sent yet. Current caller already send only 1 byte. Signed-off-by: Anthony PERARD Acked-by: Ian Jackson --- Notes: v8: Acked, but: - there is a follow-up patch to get rid of datalen

[Xen-devel] [PATCH v8 06/17] libxl_qmp: Implementation of libxl__ev_qmp_*

2019-01-04 Thread Anthony PERARD
MP) can be found in the QEMU repository at: https://git.qemu.org/?p=qemu.git;a=blob_plain;f=docs/interop/qmp-spec.txt Signed-off-by: Anthony PERARD --- Notes: v8: - using STATE_AO_GC everywhere - call qmp_ev_ensure_reading_writing from qmp_ev_set_state instead of other places. But

[Xen-devel] [PATCH v8 00/17] libxl: Enable save/restore/migration of a restricted QEMU + libxl__ev_qmp_*

2019-01-04 Thread Anthony PERARD
_suspend_device_model using libxl__ev_qmp" Which rewrite libxl__qmp_save(), and adds the ability to have QEMU save its state to a file descriptor which libxl will have openned. Patch series available in this git branch: https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br

[Xen-devel] [PATCH v8 03/17] libxl_qmp: Change qmp_qemu_check_version to compare version

2019-01-04 Thread Anthony PERARD
This patch makes the function simpler to read. It also add the ability for a caller to tell if QEMU is newer or have the exact version. Signed-off-by: Anthony PERARD Acked-by: Ian Jackson --- Notes: v6: new patch tools/libxl/libxl_qmp.c | 28 +--- 1 file

[Xen-devel] [PATCH v8 05/17] libxl: Design of an async API to issue QMP commands to QEMU

2019-01-04 Thread Anthony PERARD
All the functions will be implemented in later patches. This patch includes the API that libxl can use to send QMP commands to QEMU. Signed-off-by: Anthony PERARD Acked-by: Ian Jackson --- Notes: v7: acked, but with: fd field renamed to payload_fd libxl__ao

[Xen-devel] [PATCH v8 07/17] libxl_exec: Add libxl__spawn_initiate_failure

2019-01-04 Thread Anthony PERARD
This function can be used by user of libxl__spawn_* when they setup a notification other than xenstore. The parent can already report success via libxl__spawn_initiate_detach(), this new function can be used for failure instead of waiting for the timeout. Signed-off-by: Anthony PERARD Acked-by

[Xen-devel] [PATCH v8 04/17] libxl: Add wrapper around libxl__json_object_to_json JSON

2019-01-04 Thread Anthony PERARD
That wrapper is going to be used to safely log a json_object, as libxl__json_object_to_json return NULL on error. In the error case, JSON() will return an invalid json string. Signed-off-by: Anthony PERARD Acked-by: Ian Jackson --- Notes: v8: Acked v7: new patch

[Xen-devel] [PATCH v8 09/17] libxl_dm: Pre-open QMP socket for QEMU

2019-01-04 Thread Anthony PERARD
sing pre-opened socket file descriptor at startup > 0935700f8544033ebbd41e1f13cd528f8a58d24d dm_restrict is available in QEMU 3.0. Signed-off-by: Anthony PERARD Acked-by: Ian Jackson --- Notes: v8: acked v7: move domain_build_state init/dispose to a diff

Re: [Xen-devel] [PATCH v7 09/18] xen: remove unnecessary code from dataplane/xen-block.c

2019-01-04 Thread Anthony PERARD
t patch. > > Signed-off-by: Paul Durrant Acked-by: Anthony PERARD -- Anthony PERARD ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [PATCH v8 14/17] libxl: Re-implement domain_suspend_device_model using libxl__ev_qmp

2019-01-04 Thread Anthony PERARD
libxl__qmp_save(), so it is replace by a version using libxl__ev_qmp instead. Coding style fixed in libxl__domain_suspend_device_model() for the return value. Signed-off-by: Anthony PERARD Acked-by: Ian Jackson --- Notes: v8: Acked v7: use libxl__remove_file instead of

[Xen-devel] [PATCH v8 15/17] libxl: Remove unused arg from libxl__sendmsg_fds

2019-01-04 Thread Anthony PERARD
From: Anthony PERARD Now that `datalen' needs to be 1, we can remove it. Also change `data' parameter to be a singe byte. Signed-off-by: Anthony PERARD --- Notes: v8: new patch, just a follow-up tools/libxl/libxl_aoutils.c | 2 +- tools/libxl/libxl_internal.h | 4 +

[Xen-devel] [PATCH v8 10/17] libxl: Add dmss_init/dispose for libxl__dm_spawn_state

2019-01-04 Thread Anthony PERARD
stubdom libxl__spawn_stub_dm and libxl__spawn_qdisk_backend. But there are only 2 exit path as libxl__spawn_qdisk_backend is using libxl__spawn_local_dm functions. These two new functions are empty but will be used shortly. Signed-off-by: Anthony PERARD Acked-by: Ian Jackson --- Notes: v8

[Xen-devel] [PATCH v8 12/17] libxl_qmp: Store advertised QEMU version in libxl__ev_qmp

2019-01-04 Thread Anthony PERARD
This will be used in a later patch. Signed-off-by: Anthony PERARD Acked-by: Ian Jackson --- Notes: v8: Acked v7: Add do{}while around the MACRO. formating nits changes. v6: new local macro GRAB_VERSION better definition of

[Xen-devel] [PATCH v8 11/17] libxl: QEMU startup sync based on QMP

2019-01-04 Thread Anthony PERARD
This is only activated when dm_restrict=1, as explained in a previous patch "libxl_dm: Pre-open QMP socket for QEMU" Signed-off-by: Anthony PERARD Reviewed-by: Roger Pau Monné Acked-by: Ian Jackson --- Notes: v8: Acked v7: fixed _dispo

[Xen-devel] [PATCH v8 13/17] libxl: Change libxl__domain_suspend_device_model() to be async

2019-01-04 Thread Anthony PERARD
This create an extra step for the two call sites of the function. libxl__domain_suspend_device_model() in this patch gets an extra error variable (there is ret and rc), but ret goes away in the next patch. Signed-off-by: Anthony PERARD Acked-by: Ian Jackson --- libxl_domain_soft_reset

[Xen-devel] [PATCH v8 16/17] libxl_json: Remove libxl__json_object_append_to from header

2019-01-04 Thread Anthony PERARD
It isn't possible to use libxl__json_object_append_to() outside of libxl_json.c as there is no way to allocate a struct libxl__yajl_ctx. So also remove libxl__yajl_ctx typedef from the internal header. Signed-off-by: Anthony PERARD --- Notes: v8: New follow-up patch tools/

[Xen-devel] [PATCH v8 17/17] libxl: Add comments to libxl__json_*get* functions

2019-01-04 Thread Anthony PERARD
. Signed-off-by: Anthony PERARD --- Notes: v8: New follow-up patch tools/libxl/libxl_internal.h | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h index f1e5c2c980..8674b3ed47 100644

Re: [Xen-devel] [PATCH v7 16/18] xen: automatically create XenBlockDevice-s

2019-01-04 Thread Anthony PERARD
strdup(v[0]); > +} > +filename = g_strdup(v[1]); > +} > + > +g_strfreev(v); > +} > + ... > +/* If the image is a raw file then we are done */ raw files should use the "raw" driver, so we aren't done yet. > +

Re: [Xen-devel] [PATCH v7 16/18] xen: automatically create XenBlockDevice-s

2019-01-08 Thread Anthony PERARD
On Tue, Jan 08, 2019 at 01:07:49PM +, Paul Durrant wrote: > > -Original Message- > > From: Kevin Wolf [mailto:kw...@redhat.com] > > Sent: 08 January 2019 12:53 > > To: Paul Durrant > > Cc: Anthony Perard ; qemu-de...@nongnu.org; > &

Re: [Xen-devel] [PATCH v7 16/18] xen: automatically create XenBlockDevice-s

2019-01-08 Thread Anthony PERARD
> I've tested your patch and it does seem like the best way forward. I'll > squash it in. Do you want me to put your S-o-b on the combined patch? You can, I'll have to add it anyway when I'll prepare the pull request. T

Re: [Xen-devel] [PATCH] tools/firmware: update OVMF Makefile

2019-01-09 Thread Anthony PERARD
On Thu, Nov 29, 2018 at 11:39:54AM +, Wei Liu wrote: > On Thu, Nov 29, 2018 at 11:31:41AM +0000, Anthony PERARD wrote: > > On Wed, Nov 28, 2018 at 05:43:33PM +, Wei Liu wrote: > > > OVMF has become dependent on OpenSSL, which it is included as a submodule. > >

Re: [Xen-devel] [PATCH v9 16/18] xen: automatically create XenBlockDevice-s

2019-01-09 Thread Anthony PERARD
7;qdisk' is removed by this patch, which makes > the 'xen_disk' code is redundant. The code will be removed by a subsequent > patch. > > Signed-off-by: Paul Durrant > Signed-off-by: Anthony Perard > --- > diff --git a/hw/block/xen-block.c b/hw/block/xen-block.c

Re: [Xen-devel] [PATCH] tools/firmware: update OVMF Makefile

2019-01-09 Thread Anthony PERARD
e change of PcdDebugIoPort.) I don't know if DEBUG_ON_SERIAL_PORT is going to work, and how it works, but it certainly don't use PcdDebugIoPort. Using a serial port instead of an IO port is even going to be slower. So I don't know if it would be useful to have. -- Anthony PERARD ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] tools/firmware: update OVMF Makefile

2019-01-09 Thread Anthony PERARD
On Wed, Jan 09, 2019 at 09:03:25AM -0700, Tamas K Lengyel wrote: > Ah, thanks for that info! We should probably put that on the wiki too ;) Done: https://wiki.xenproject.org/index.php?title=OVMF&diff=19075&oldid=19074 -- Anthony PERARD __

[Xen-devel] [PULL 07/25] xen: add xenstore watcher infrastructure

2019-01-10 Thread Anthony PERARD
subsequent patch will supply a full implementation for these functions. Signed-off-by: Paul Durrant Reviewed-by: Anthony Perard Signed-off-by: Anthony PERARD --- hw/block/trace-events | 2 + hw/block/xen-block.c| 70 +++ hw/xen/trace-events

[Xen-devel] [PULL 02/25] xen/pt: allow passthrough of devices with bogus interrupt pin

2019-01-10 Thread Anthony PERARD
o Yan Acked-by: Anthony PERARD Signed-off-by: Anthony PERARD --- hw/xen/xen_pt.c | 6 ++ hw/xen/xen_pt_config_init.c | 4 +++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c index f1f3a3727c..815dc46ba7 100644 --- a/hw/xen/xen_pt.c

[Xen-devel] [PULL 00/25] xen queue

2019-01-10 Thread Anthony PERARD
27;. Starting with xen_disk. * Performance improvements for xen-block. * Remove of the Xen PV domain builder. * bug fixes. -------- Anthony PERARD (2): Remove broken Xen PV domain builder xen: Replace few mentions of xend by lib

[Xen-devel] [PULL 08/25] xen: add grant table interface for XenDevice-s

2019-01-10 Thread Anthony PERARD
From: Paul Durrant The legacy PV backend infrastructure provides functions to map, unmap and copy pages granted by frontends. Similar functionality will be required by XenDevice implementations so this patch adds the necessary support. Signed-off-by: Paul Durrant Reviewed-by: Anthony Perard

[Xen-devel] [PULL 05/25] xen: introduce 'xen-block', 'xen-disk' and 'xen-cdrom'

2019-01-10 Thread Anthony PERARD
of the vdev parameter formulates the appropriate VBD number for use in the PV protocol. [1] https://xenbits.xen.org/docs/unstable/man/xen-vbd-interface.7.html Signed-off-by: Paul Durrant Reviewed-by: Anthony Perard Signed-off-by: Anthony PERARD --- MAINTAINERS| 2 +- hw/block/

[Xen-devel] [PULL 01/25] hw/xen/xen_pt_graphics: Don't trust the BIOS ROM contents so much

2019-01-10 Thread Anthony PERARD
of the buffer. Check that the size is within bounds before we use it. We are also trusting the pcioffset field, and assuming that the whole rom_header is present; Coverity doesn't notice these, but check them too. Signed-off-by: Peter Maydell Acked-by: Anthony PERARD Signed-off-by: Anthon

[Xen-devel] [PULL 06/25] xen: create xenstore areas for XenDevice-s

2019-01-10 Thread Anthony PERARD
n subsequent patches. Signed-off-by: Paul Durrant Reviewed-by: Anthony Perard Signed-off-by: Anthony PERARD --- hw/block/xen-block.c| 9 + hw/xen/Makefile.objs| 2 +- hw/xen/trace-events | 12 +- hw/xen/xen-bus-helper.c

[Xen-devel] [PULL 04/25] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy

2019-01-10 Thread Anthony PERARD
nit() function called from the same sites as the legacy xen_be_init() function. Subsequent patches will flesh-out the functionality of these objects. Signed-off-by: Paul Durrant Reviewed-by: Anthony Perard Signed-off-by: Anthony PERARD --- hw/i386/xen/xen-hvm.c | 3 + hw/xen/Makefile.ob

[Xen-devel] [PULL 09/25] xen: add event channel interface for XenDevice-s

2019-01-10 Thread Anthony PERARD
Perard Signed-off-by: Anthony PERARD --- hw/xen/xen-bus.c | 101 +++ include/hw/xen/xen-bus.h | 18 +++ 2 files changed, 119 insertions(+) diff --git a/hw/xen/xen-bus.c b/hw/xen/xen-bus.c index faa9fd3577..9443f27d44 100644 --- a/hw/xen/xen-bus.c

[Xen-devel] [PULL 03/25] xen: re-name XenDevice to XenLegacyDevice...

2019-01-10 Thread Anthony PERARD
. Hence it is necessary to re-name parts of existing code to avoid name clashes. The re-named 'legacy' infrastructure will be removed once all backends have been ported to the new framework. This patch is purely cosmetic. No functional change. Signed-off-by: Paul Durrant Acked-by: Anth

[Xen-devel] [PULL 22/25] xen: Replace few mentions of xend by libxl

2019-01-10 Thread Anthony PERARD
xend have been replaced by libxenlight (libxl) for many Xen releases now. Signed-off-by: Anthony PERARD Acked-by: Stefano Stabellini --- hw/xenpv/xen_machine_pv.c | 2 +- include/hw/xen/xen.h | 2 +- qemu-options.hx | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions

[Xen-devel] [PULL 15/25] xen: purge 'blk' and 'ioreq' from function names in dataplane/xen-block.c

2019-01-10 Thread Anthony PERARD
From: Paul Durrant This is a purely cosmetic patch that purges remaining use of 'blk' and 'ioreq' in local function names, and then makes sure all functions are prefixed with 'xen_block_'. No functional change. Signed-off-by: Paul Durrant Acked-by: Anthony

[Xen-devel] [PULL 21/25] Remove broken Xen PV domain builder

2019-01-10 Thread Anthony PERARD
It is broken since Xen 4.9 [1] and it will not build in Xen 4.12. Also, it is not built by default since QEMU 2.6. [1] https://lists.xenproject.org/archives/html/xen-devel/2018-09/msg00313.html Signed-off-by: Anthony PERARD Acked-by: Stefano Stabellini --- configure | 17

[Xen-devel] [PULL 18/25] xen: automatically create XenBlockDevice-s

2019-01-10 Thread Anthony PERARD
will be removed by a subsequent patch. Signed-off-by: Paul Durrant Reviewed-by: Anthony PERARD Signed-off-by: Anthony PERARD --- hw/block/trace-events | 4 + hw/block/xen-block.c| 375 hw/xen/xen-legacy-backend.c | 1 - include/hw/xen/xen-

[Xen-devel] [PULL 25/25] xen-block: avoid repeated memory allocation

2019-01-10 Thread Anthony PERARD
-off-by: Tim Smith Re-based and commit comment adjusted. Signed-off-by: Paul Durrant Acked-by: Anthony PERARD Signed-off-by: Anthony PERARD --- hw/block/dataplane/xen-block.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/hw/block/dataplane/xen-block.c b/hw

[Xen-devel] [PULL 11/25] xen: remove unnecessary code from dataplane/xen-block.c

2019-01-10 Thread Anthony PERARD
error_report(). NOTE: The code is still not yet built. Further transformations will be required to make it correctly interface to the new XenBus/XenDevice framework. They will be delivered in a subsequent patch. Signed-off-by: Paul Durrant Acked-by: Anthony Perard Signed-off-by

[Xen-devel] [PULL 24/25] xen-block: improve response latency

2019-01-10 Thread Anthony PERARD
-based and commit comment adjusted. Signed-off-by: Paul Durrant Acked-by: Anthony PERARD Signed-off-by: Anthony PERARD --- hw/block/dataplane/xen-block.c | 56 +++--- 1 file changed, 18 insertions(+), 38 deletions(-) diff --git a/hw/block/dataplane/xen-block.c b/hw

[Xen-devel] [PULL 23/25] xen-block: improve batching behaviour

2019-01-10 Thread Anthony PERARD
()/ blk_io_unplug() in an amount proportional to the number which were already in flight at the time we started reading the ring. Signed-off-by: Tim Smith Re-based and commit comment adjusted. Signed-off-by: Paul Durrant Acked-by: Anthony PERARD Signed-off-by: Anthony PERARD --- hw/block/dataplane/xen

[Xen-devel] [PULL 20/25] xen: remove the legacy 'xen_disk' backend

2019-01-10 Thread Anthony PERARD
From: Paul Durrant This backend has now been replaced by the 'xen-qdisk' XenDevice. Signed-off-by: Paul Durrant Acked-by: Anthony Perard Signed-off-by: Anthony PERARD --- hw/block/Makefile.objs |1 - hw/block/xen_disk.c| 1011 2 fil

[Xen-devel] [PULL 16/25] xen: add implementations of xen-block connect and disconnect functions...

2019-01-10 Thread Anthony PERARD
ues specified in the frontend xenstore area are mapped/bound and used to set up the dataplane. Signed-off-by: Paul Durrant Reviewed-by: Anthony Perard Signed-off-by: Anthony PERARD --- hw/block/xen-block.c | 166 hw/xen/trace-events| 3 + hw/xen/xen-b

[Xen-devel] [PULL 10/25] xen: duplicate xen_disk.c as basis of dataplane/xen-block.c

2019-01-10 Thread Anthony PERARD
, thus making review harder. Signed-off-by: Paul Durrant Acked-by: Anthony Perard Signed-off-by: Anthony PERARD --- MAINTAINERS|1 + hw/block/dataplane/xen-block.c | 1019 2 files changed, 1020 insertions(+) create mode 100644 hw/block

[Xen-devel] [PULL 17/25] xen: add a mechanism to automatically create XenDevice-s...

2019-01-10 Thread Anthony PERARD
Signed-off-by: Paul Durrant Reviewed-by: Anthony Perard Signed-off-by: Anthony PERARD --- hw/xen/Makefile.objs | 2 +- hw/xen/trace-events | 3 + hw/xen/xen-backend.c | 165 +++ hw/xen/xen-bus.c | 164 +++

[Xen-devel] [PULL 13/25] xen: remove 'XenBlkDev' and 'blkdev' names from dataplane/xen-block

2019-01-10 Thread Anthony PERARD
. Signed-off-by: Paul Durrant Acked-by: Anthony Perard Signed-off-by: Anthony PERARD --- hw/block/dataplane/xen-block.c | 352 + hw/block/dataplane/xen-block.h | 2 +- 2 files changed, 183 insertions(+), 171 deletions(-) diff --git a/hw/block/dataplane/xen-

[Xen-devel] [PULL 14/25] xen: remove 'ioreq' struct/varable/field names from dataplane/xen-block.c

2019-01-10 Thread Anthony PERARD
;struct ioreq' with a new 'XenBlockRequest' type and 'ioreq' field/variable names with 'request', and then does necessary fix-up to adhere to coding style. Function names are not modified by this patch. They will be dealt with in a subsequent patch. No functional change. S

[Xen-devel] [PULL 19/25] MAINTAINERS: add myself as a Xen maintainer

2019-01-10 Thread Anthony PERARD
removing the legacy code. It therefore seems reasonable that I become a maintainer of the Xen code. Signed-off-by: Paul Durrant Acked-by: Anthony Perard Acked-by: Stefano Stabellini Signed-off-by: Anthony PERARD --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b

<    1   2   3   4   5   6   7   8   9   10   >