Stefano Stabellini writes ("[PATCH v10 4/6] xen/x86: use DEFINE_SYMBOL as
required"):
> Use SYMBOLS_SUBTRACT and SYMBOLS_COMPARE in cases of comparisons and
> subtractions of:
Oh and the commit message still mentions old macro names :-).
FTR I think your definition macro should be called
Stefano Stabellini writes ("[PATCH v10 4/6] xen/x86: use DEFINE_SYMBOL as
required"):
> Use SYMBOLS_SUBTRACT and SYMBOLS_COMPARE in cases of comparisons and
> subtractions of:
...
> Use explicit casts to uintptr_t when it is not possible to use the
> provided static inline functions.
Why is it
Jan Beulich writes ("Re: [PATCH v10 2/6] xen: introduce DEFINE_SYMBOL"):
> On 26.02.19 at 17:46, wrote:
> > I am not aware of a standard C type which could be used instead of
> > this struct. But I think you can use the `packed' attribute to get
> > the right behaviour. The GCC manual says:
> >
or now, disable security updates entirely. We don't really care
about the security patch status of test boxes anyway. Hopefully this
will cause the system to become reliable again.
CC: Juergen Gross
Signed-off-by: Ian Jackson
---
Osstest/Debian.pm | 3 ++-
1 file changed, 2 insertions(+), 1 d
Stefano Stabellini writes ("Re: [PATCH v11 5/9] xen/x86: use DECLARE_BOUNDS as
required"):
> This is problematic. We have also the following instances in this series
> to deal with:
>
> xen/arch/arm/percpu.c:_free_percpu_area
> char *p = (char *)__per_cpu_start + __per_cpu_offset[cpu];
>
>
Jan Beulich writes ("Re: [PATCH v11 3/9] xen: introduce DECLARE_BOUNDS"):
> On 06.03.19 at 21:55, wrote:
> > On Wed, 6 Mar 2019, Jan Beulich wrote:
> > uintptr_t is the integer type corresponding to a pointer, so we should
> > use uintptr_t first. ptrdiff_t is the difference type so we should
Stefano Stabellini writes ("Re: [PATCH v11 5/9] xen/x86: use DECLARE_BOUNDS as
required"):
> On Wed, 6 Mar 2019, Jan Beulich wrote:
> > Is the line wrapping really needed here?
>
> It would end at 80 characters exactly otherwise. I am happy to do as you
> prefer.
Certainly I prefer lines to end
Jan Beulich writes ("Re: [PATCH v11 5/9] xen/x86: use DECLARE_BOUNDS as
required"):
> I'd like to note though that in the first two cases we don't alter the
> declared object anyway, but instead a derived one; the declaration
> should not use const for other reasons though. And the 3rd case is
>
Andrew Cooper writes ("Re: [PATCH v11 1/9] xen: use __UINTPTR_TYPE__ for
uintptr_t"):
> NACK.
>
> Stop messing around with GCC-isms and use the spec-compliant way of
> getting uintptr_t (and others).
>
> #include
If everything is working correctly, stdint.h is provided by the
compiler (eg by
Olaf Hering writes ("Re: [PATCH v2] libxl: prepare environment for
domcreate_stream_done"):
> Am Fri, 8 Mar 2019 14:08:10 +0000
> schrieb Ian Jackson :
>
> > In fact this is OK because domcreate_stream_done only reads srs->dcs
> > and then doe
Olaf Hering writes ("[PATCH v2] libxl: prepare environment for
domcreate_stream_done"):
> The function domcreate_bootloader_done may branch early to
> domcreate_stream_done, in case some error occoured. Here srs->dcs will be
> NULL, which leads to a crash.
Thanks. I think this is OK as far as
Jan Beulich writes ("Re: [PATCH v11 5/9] xen/x86: use DECLARE_BOUNDS as
required"):
> Ian Jackson 03/07/19 3:44 PM >>>
> >Jan Beulich writes ("Re: [PATCH v11 5/9] xen/x86: use DECLARE_BOUNDS as
> >required"):
> >> I'd like to n
Andrew Cooper writes ("Re: SRSL People... [PATCH v11 0/9] misc safety
certification fixes"):
> The rational for this series is to satisfy MISRA. MISRA have said in no
> uncertain terms that all of these tricks are unacceptable, and have
> identified the one acceptable option. By not doing what
Stefano Stabellini writes ("[PATCH v11 5/9] xen/x86: use DECLARE_BOUNDS as
required"):
> Use DECLARE_BOUNDS and the two static inline functions that come with it
> for comparisons and subtractions of:
>
> __2M_rwdata_start, __2M_rwdata_end, __end_vpci_array,
> __start_vpci_array, _stextentry,
Jan Beulich writes ("Re: [PATCH v11 5/9] xen/x86: use DECLARE_BOUNDS as
required"):
> Ian Jackson 03/07/19 3:02 PM
> >Jan, it is quite unfortunate that you are replying to Stefano to
> >disagree with things that Stefano did because I suggested them, rather
> >tha
Jan Beulich writes ("Re: [PATCH v11 9/9] xen: explicit casts when
DECLARE_BOUNDS cannot be used [and 1 more messages]"):
> Ian Jackson 03/07/19 4:26 PM >>>
> >Jan, I'm not sure exactly what you are suggesting. Currently the
> >array has one pointer per elem
Jan Beulich writes ("Re: [PATCH v11 3/9] xen: introduce DECLARE_BOUNDS"):
> >No. This is not fine. Signed integer subtraction sometimes has UB.
...
> I've spent an hour trying to find the relevant parts of the spec, but I'm
> afraid I've once again failed at finding all necessary pieces.
The
Jan Beulich writes ("Re: [PATCH v11 1/9] xen: use __UINTPTR_TYPE__ for
uintptr_t"):
> On 06.03.19 at 22:16, wrote:
> > Also, it is not a good idea to use __mode__(__pointer__) to define
> > uintptr_t, because it relies on an obscurely defined GCC feature whose
> > semantics might be taken to
Stefano Stabellini writes ("[PATCH v11 9/9] xen: explicit casts when
DECLARE_BOUNDS cannot be used"):
> Sometimes the static inline functions provided by DECLARE_BOUNDS cannot
> be used. This patch uses explicit casts to uintptr_t in those cases.
>
> M3CM: Rule-18.2: Subtraction between pointers
Andrew Cooper writes ("Re: [PATCH 0/3] docs: User oriented documentation"):
> The point of using virtualenv is to get a known-compatible set of
> dependencies. See docs/sphinx/requirements.txt in patch 1.
I don't think we need to have more curlbashware in the Xen build tree.
Sphinx 1.4.9 is what
Andrew Cooper writes ("Re: [PATCH 0/3] docs: User oriented documentation"):
> It turns out that I mis-interpreted the compatibility note in
> https://www.kernel.org/doc/html/latest/doc-guide/sphinx.html# and
> stretch is probably fine.
OK, good.
Well, I think we could say that to build this
width to a sensible value.
>
> Reported-by: Igor Druzhinin
> Signed-off-by: Wei Liu
LGTM. Thanks for the copious comment.
Acked-by: Ian Jackson
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
Wei Liu writes ("[PATCH] libxc: fix HVM core dump"):
> f969bc9fc96 forbid get_address_size call on HVM guests, because that
> didn't make sense. It broke core dump functionality on HVM because
> libxc unconditionally asked for guest width.
...
> +if ( !auto_translated_physmap &&
> +
In particular, say clearly that X.Y-unstable should be thus, not
X.Y.0-unstable.
CC: Jan Beulich
Signed-off-by: Ian Jackson
---
docs/process/release-technician-checklist.txt | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/docs/process/release-technician-checklist.txt
One per line is a lot easier to read.
Signed-off-by: Ian Jackson
---
docs/process/release-technician-checklist.txt | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/docs/process/release-technician-checklist.txt
b/docs/process/release-technician-checklist.txt
index
We no longer use hg
Signed-off-by: Ian Jackson
---
docs/process/branching-checklist.txt | 4
1 file changed, 4 deletions(-)
diff --git a/docs/process/branching-checklist.txt
b/docs/process/branching-checklist.txt
index 5a02d21968..4cda33656d 100644
--- a/docs/process/branching
It is only necessary to change Config.mk if it refers to unstable
branches anywhere. This time, for example, it didn't.
Signed-off-by: Ian Jackson
---
docs/process/branching-checklist.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/docs/process/branching-checklist.txt
b/docs/process
Provide a rune, following which a magit selective git add
(or git add -p) can be used to commit the appropriate changes.
Signed-off-by: Ian Jackson
---
docs/process/branching-checklist.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/docs/process/branching-checklist.txt
b/docs/process
Juergen Gross writes ("Commit moratorium for branching off 4.12"):
> Committers,
>
> Please don't push any new patch to staging because we are going to
> branch off 4.12 from the main trunk.
4.12 is now branched off from the main trunk (ie, staging-4.12 is
branched from staging).
The commit
Jan Beulich writes ("Ping: libfsimage path/file name changes"):
> On 28.01.19 at 08:55, wrote:
> > back in October you've added quite a number of "xen" prefixes to
> > various pieces there. Now that I've finally had time to connect this
> > change of yours with PV domain creation failures that
Jan Beulich writes ("Re: [Xen-devel] [PATCH v6 1/4] xen: introduce SYMBOL"):
> As per my earlier reply, I've yet to see proof of a "code-breaking
> optimization" that actually matches our case(s).
I have personally experienced a program being miscompiled because of
the mistaken belief by the
Jan Beulich writes ("Re: [Xen-devel] [xen-unstable test] 132932: regressions -
FAIL"):
> >>> On 06.02.19 at 17:10, wrote:
> > flight 132932 xen-unstable real [real]
> > http://logs.test-lab.xenproject.org/osstest/logs/132932/
> >
> > Regressions :-(
> >
> > Tests which did not succeed and are
Jan Beulich writes ("Re: [Xen-devel] [PATCH v6 1/4] xen: introduce SYMBOL"):
> On 06.02.19 at 17:37, wrote:
> > Jan Beulich writes ("Re: [Xen-devel] [PATCH v6 1/4] xen: introduce SYMBOL"):
> >> - it allows the end-of-whatever symbols to also be handed to
> >> functions in a type-safe manner
> >
Jan Beulich writes ("Re: [Xen-devel] [PATCH v6 1/4] xen: introduce SYMBOL"):
> On 06.02.19 at 16:41, wrote:
> > (i) define indirection variables eg end_ in an assembly language file.
> > (ii) convert to uintptr_t before comparing
> >
> > (i) is IMO wholly safe but it is a bit ugly and slightly
Sorry for the rather random CC list.
Last year we bought a variety of test boxes. Amongst them were three
biggish Intel machines which I had primarily intended for use as
dedicated build servers. These are himrod[012].
Unfortunately I have not been able to commission them because they
have
Summary:
7b8052e19304 which is a backport to linux-3.18 of be06998f96ec has
been found by the Xen CI auto-bisector to be responsible for a
regression booting under Xen.
Jan Beulich writes ("Re: [linux-3.18 bisection] complete
test-amd64-amd64-pair"):
> No, I'm not. I've said what I can say
Jan Beulich writes ("Re: [Xen-devel] [PATCH v9 2/5] xen: introduce
SYMBOLS_SUBTRACT and SYMBOLS_COMPARE"):
> On 12.02.19 at 15:47, wrote:
> > I didn't see your proposed inline function, but don't think it can
> > work correctly because it won't be type-generic. Ie, the requirement
> > is to use
Jan Beulich writes ("Re: [Xen-devel] [PATCH v9 2/5] xen: introduce
SYMBOLS_SUBTRACT and SYMBOLS_COMPARE"):
> On 12.02.19 at 13:01, wrote:
> > I would particularly welcome the opinion of hypervisor maintainers on
> > my type safety point, below.
>
> I agree with the requirements you put forward;
Jan Beulich writes ("Re: [PATCH v9 1/5] xen: introduce ptrdiff_t, fix
uintptr_t"):
> On 12.02.19 at 02:13, wrote:
> > -typedef unsigned int __attribute__((__mode__(__pointer__))) uintptr_t;
> > +typedef unsigned long __attribute__((__mode__(__pointer__))) uintptr_t;
>
> I don't understand this
Ian Jackson writes ("Re: [Xen-devel] arm64, laxton[01] (was Re:
[xen-unstable-smoke test] 133030: trouble: blocked/broken/pass)"):
> And that part works. It runs through d-i and thinks it has succeeded.
> But then when the host reboots it reboots into 3.16, not the ba
Julien Grall writes ("Re: [Xen-devel] arm64, laxton[01] (was Re:
[xen-unstable-smoke test] 133030: trouble: blocked/broken/pass)"):
> On Tue, Feb 12, 2019 at 12:26 PM Ian Jackson wrote:
> > I don't have a good plan about what to do next. I guess one thing we
> > could
Stefano Stabellini writes ("Re: [Xen-devel] [PATCH v6 1/4] xen: introduce
SYMBOL"):
> On Thu, 7 Feb 2019, Ian Jackson wrote:
> > FAOD, I think you should expect people to declare the linker symbols
> > either as I suggested:
> >
> > exte
nd) is negative but COMPARE(start,end) is
positive. I suggest that you call the macro DIFFERENCE and have
DIFFERENCE(start,end) be positive.
Thirdly, in an earlier exchange:
> On Thu, 7 Feb 2019, Ian Jackson wrote:
> > FAOD, I think you should expect people to declare the linker symbols
> &g
In jessie and earlier, this has to be done with a global option.
In later releases, it can be done by putting some options in [ ]
in the relevant sources list entry.
Signed-off-by: Ian Jackson
---
Osstest/Debian.pm | 13 +
1 file changed, 13 insertions(+)
diff --git a/Osstest
ended up trying to
boot the installed system with 3.16, which does not work on our two
SoftIron arm64 test boxes.
Also, jessie-backports about to be completely removed.
Signed-off-by: Ian Jackson
---
production-config | 2 ++
production-config-cambridge | 2 ++
2 files changed, 4
If this is set, use it instead of the usual DebianMirrorHost and
Subpath. No functional change with configs that don't set it.
This is not sufficient to work right yet, because snapshots
repositories have out-of-date signatures...
Signed-off-by: Ian Jackson
---
Osstest/Debian.pm | 5 -
1
No functional change.
Signed-off-by: Ian Jackson
---
Osstest/Debian.pm | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm
index ee7e03cf..5e74e86e 100644
--- a/Osstest/Debian.pm
+++ b/Osstest/Debian.pm
@@ -949,6 +949,8 @@ sub
Ian Jackson writes ("[OSSTEST PATCH 0/4] Use snapshot for jessie-backports"):
> Things are being removed from jessie-backports, which we rely on for
> arm64 tests. Switch to using snapshot.debian.org.
>
> In my moderately-formal test, this has got as far as booting one of
&
to preseed_backports_packages only triggers if
$kp eq 'backports', so only for the laxtons.
Accordingly, I have convinced myself that this code will only affect
arm64 in the Xen Project CI lab.
Ian Jackson (4):
backports snapshot: Honour DebianSnapshotBackports_ config var
backports snapshot
We need to put this in /target or it does not take effect.
Yesterday's 4 patches worked yesterday but not today, because the
snapshot in question in fact expired in between. With this additional
patch they work today too.
Signed-off-by: Ian Jackson
---
Osstest/Debian.pm | 2 +-
1 file changed
Ian Jackson writes ("[OSSTEST PATCH 3/4] backports snapshot: Disable apt
timestamp checking (sometimes)"):
> In jessie and earlier, this has to be done with a global option.
>
> In later releases, it can be done by putting some options in [ ]
> in the relevant sources l
Ian Jackson writes ("arm64, laxton[01] (was Re: [Xen-devel] [xen-unstable-smoke
test] 133030: trouble: blocked/broken/pass)"):
> I have checked and there was no update to the osstest code. I don't
> think there have been updates to the infrastructure config but I
> h
Jan, are you investigating this regression ?
osstest service owner writes ("[linux-3.18 bisection] complete
test-amd64-amd64-pair"):
> branch xen-unstable
> xenbranch xen-unstable
> job test-amd64-amd64-pair
> testid xen-boot/dst_host
>
> Tree: linux
>
Lars Kurth writes ("Re: [OSSTEST PATCH] README.hardware-acquisition [and 1 more
messages]"):
> as mentioned earlier, I think we need a legal/admin item for hardware and
> donations. See proposed addition below.
...
> LEGAL
> =
I would prefer not to bake the Linux Foundation address into
Lars Kurth writes ("Re: [OSSTEST PATCH] README.hardware-acquisition [and 1 more
messages]"):
> This is fine by me
Thanks, pushed now.
Ian.
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
Juergen Gross writes ("Re: [Xen-devel] [OSSTEST PATCH 5/4] backports snapshot:
Disable apt timestamp checking in right place"):
> Release-acked-by: Juergen Gross
>
> in case my implicit ack from yesterday expired as well ;-)
Thanks :-). I pushed it without waiting. It is now in production
Paul Durrant writes ("RE: [PATCH] tools/libxendevicemodel: add
xendevicemodel_modified_memory_bulk to map"):
> Cc-ing Juergen, in case this can make 4.12...
I think this should go into 4.12. It is very low risk.
In another case there would possibly be questions about whether we
wanted to add
Paul Durrant writes ("RE: [PATCH] tools/libxendevicemodel: add
xendevicemodel_modified_memory_bulk to map"):
> Perhaps it would be possible to build some sort of cross-check that all
> functions listed in the public header of a library are actually *somewhere*
> in the map file, so this doesn't
Ian Jackson writes ("Re: [OSSTEST PATCH] README.hardware-acquisition [and 1
more messages]"):
> So overall, for the reasons I explain, I'm going to commit this
> document (subject to the other comments etc.) *with* the requirement
> that hardware must be supported
Stefano Stabellini writes ("Re: [Xen-devel] [PATCH v6 1/4] xen: introduce
SYMBOL"):
> I am OK with this approach. Maybe not the best IMO, but good enough. It
> should also satisfy the MISRAC guys, as they wrote "ideally cast to
> uintptr_t only once": here we wouldn't be casting only once, but at
`neeeded' is a typo. And xend is long gone.
No functional change.
Signed-off-by: Ian Jackson
---
tools/hotplug/Linux/init.d/xencommons.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/hotplug/Linux/init.d/xencommons.in
b/tools/hotplug/Linux/init.d/xencommons.in
.
Signed-off-by: Ian Jackson
---
tools/hotplug/Linux/init.d/xencommons.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/hotplug/Linux/init.d/xencommons.in
b/tools/hotplug/Linux/init.d/xencommons.in
index a33058ed44..581b02c27a 100644
--- a/tools/hotplug/Linux/init.d
These directories ought not to be even world-readable. If this script
for some reason runs with a lax umask they might be created
overly-writeable. Avoid any such bug by setting the mode explicitly.
Signed-off-by: Ian Jackson
---
tools/hotplug/Linux/init.d/xencommons.in | 4 ++--
1 file
The Debian Xen maintainers had a review of the init scripts. Debian
has its completely own set of scripts. This is something that needs
to be tackled in the medium term but not now.
However, we did identify some things which could be remedied upstream
right away.
Ian Jackson (3):
tools: init
On Fri, Feb 08, 2019 at 01:14:16PM +, Wei Liu wrote:
> On Fri, Feb 08, 2019 at 05:21:44AM +, osstest service owner wrote:
> > flight 133030 xen-unstable-smoke real [real]
> > http://logs.test-lab.xenproject.org/osstest/logs/133030/
> >
> > Failures and problems with tests :-(
Thanks for
This is really not going to take a minute. Probably, much less.
Waiting less long will save time when we fall back.
Signed-off-by: Ian Jackson
---
Osstest/PDU/ssh.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Osstest/PDU/ssh.pm b/Osstest/PDU/ssh.pm
index cfcf8f85
the uptime (of the existing environment), between
the reboot command being issued and the host actually rebooting.
So, wait (up to just over a minute) until the host does not respond to
ping. (target_await_down runs ping -c 5.)
CC: Roger Pau Monné
Signed-off-by: Ian Jackson
---
Osstest/PDU
When this error trips it is usually because the call site looked up an
unset runvar and it can be hard to tell what that runvar was.
If we use confess we will at least find out the calling line number...
Signed-off-by: Ian Jackson
---
Osstest.pm | 4 +++-
1 file changed, 3 insertions(+), 1
)
races with the attempt to reboot.
Signed-off-by: Ian Jackson
---
Osstest/PDU/ssh.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Osstest/PDU/ssh.pm b/Osstest/PDU/ssh.pm
index ac1eb919..cfcf8f85 100644
--- a/Osstest/PDU/ssh.pm
+++ b/Osstest/PDU/ssh.pm
@@ -47,7 +47,7 @@ sub
This replaces the `DO NOT APPLY' patch 26/26 from the part 1 series.
It also contains some other fixes/improvements.
Ian Jackson (5):
flight_otherjob: Use confess rather than die
power: ssh: Fix handling of $delay
power: ssh: Reduce timeout for script fragment
power: ts-freebsd-host
Monné
Signed-off-by: Ian Jackson
---
ts-freebsd-host-install | 33 +
1 file changed, 25 insertions(+), 8 deletions(-)
diff --git a/ts-freebsd-host-install b/ts-freebsd-host-install
index 53daeefc..3c3e9c34 100755
--- a/ts-freebsd-host-install
+++ b/ts-freebsd
Roger Pau Monne writes ("Re: [OSSTEST PATCH 5/5] power: ssh: Wait for the
target to appear to go down"):
> On Fri, Jan 25, 2019 at 02:50:46PM +, Ian Jackson wrote:
> > On some systems (notably, FreeBSD) the kernel does not simply reboot
> > immediately even with the
Anthony PERARD writes ("[PATCH for-4.12] libxl: When restricted, start QEMU
paused"):
> [stuff]
Thanks for this. I think the code looks right but to make it easier
to understand what was going on I have taken the liberty of trying to
reword your commit message for English grammar.
Can you
Anthony PERARD writes ("Re: [PATCH for-4.12] libxl: When restricted, start QEMU
paused"):
> On Wed, Jan 30, 2019 at 03:09:45PM +, Ian Jackson wrote:
> > - libxl connects and hand-checks [xxx???] with QEMU, then sends the
> > cmd "query-status".
&g
Anthony PERARD writes ("[PATCH v2 for-4.12] libxl: When restricted, start QEMU
paused"):
> Signed-off-by: Anthony PERARD
> Release-acked-by: Juergen Gross
Acked-by: Ian Jackson
___
Xen-devel mailing list
Xen-devel@lists.xenp
Wei Liu writes ("Re: [PATCH-for-4.10/4.11] libxl: don't set gnttab limits in
soft reset case"):
> On Thu, Jan 17, 2019 at 05:40:59PM +0100, Juergen Gross wrote:
> > In case of soft reset the gnttab limit setting will fail, so omit it.
> > Setting of max vcpu count is pointless in this case, too,
Jan Beulich writes ("Re: [Xen-devel] preparations for 4.10.3 and 4.9.4"):
> On 01.02.19 at 12:23, wrote:
> > For 4.10.3:
> >
> > https://lists.xen.org/archives/html/xen-devel/2019-01/msg01451.html
>
> Ian, this looks to be one for you.
Indeed, thanks.
Ian.
Ian Jackson writes ("Re: [PATCH for-4.12] libxl: correctly dispose of dominfo
list in libxl_name_to_domid"):
> Wei Liu writes ("[PATCH for-4.12] libxl: correctly dispose of dominfo list in
> libxl_name_to_domid"):
> > Tamas reported ssid_label was leaked. Use the
From: Ian Jackson
Date: Tue, 29 Jan 2019 13:26:29 +
Subject: [OSSTEST PATCH] Revert "production-config: Temporarily drop arm64"
This reverts commit c65d7eb3f6c424d6c1fe69c5ecfca9c0b6cf4302.
---
production-config | 3 ---
1 file changed, 3 deletions(-)
diff --git a/productio
Liu
> Tested-by: Tamas K Lengyel
Acked-by: Ian Jackson
> Backport candidate.
Noted.
Thanks,
Ian.
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
Juergen Gross writes ("OSStest commits and Xen releases"):
> I have found an alarming tendency regarding changes in the OSStest
> repository: over the last 2 years (or 3 Xen versions) there has been
> a pattern of OSStest commits being more frequent during the RC phase
> of a Xen release. On
We are going to want to use this magically, in our new approach. Make
a general version, and deprecate ipmi_try (which will be obsoleted by
the new approach and which has probably not been used very much).
Signed-off-by: Ian Jackson
---
Osstest/PDU/ipmi_try.pm | 2 ++
Osstest/PDU/try_off.pm
Signed-off-by: Ian Jackson
---
Osstest/TestSupport.pm | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm
index 29108423..68b51728 100644
--- a/Osstest/TestSupport.pm
+++ b/Osstest/TestSupport.pm
@@ -917,10 +917,10
Signed-off-by: Ian Jackson
---
ts-host-powercycle | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/ts-host-powercycle b/ts-host-powercycle
index 5c1698c7..79a3b711 100755
--- a/ts-host-powercycle
+++ b/ts-host-powercycle
@@ -33,8 +33,10 @@ our ($whhost) = @ARGV;
$whhost
Signed-off-by: Ian Jackson
---
Osstest/TestSupport.pm | 11 +++
mg-hosts | 2 +-
2 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm
index 886e95d4..fb14c4b3 100644
--- a/Osstest/TestSupport.pm
+++ b/Osstest
The semantics are slightly different here: not specifying it means to
try everything rather than only the hardest. But the effect is
similar: not specifying $approach_re means we must succeed.
Signed-off-by: Ian Jackson
---
Osstest/TestSupport.pm | 5 +++--
1 file changed, 3 insertions(+), 2
Actually iterate over PowerApproaches, rather than calling power_state
with no approach selector regexp.
No overall functional change right now because nothing puts more
than one entry in PowerApproaches.
Signed-off-by: Ian Jackson
---
Osstest/TestSupport.pm | 21 -
1 file
-by: Ian Jackson
---
ts-freebsd-host-install | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/ts-freebsd-host-install b/ts-freebsd-host-install
index 53daeefc..21f3b5a2 100755
--- a/ts-freebsd-host-install
+++ b/ts-freebsd-host-install
@@ -259,14 +259,14 @@ END
Signed-off-by: Ian Jackson
---
sg-report-host-history | 56 ++
1 file changed, 56 insertions(+)
diff --git a/sg-report-host-history b/sg-report-host-history
index 51814534..18b538e9 100755
--- a/sg-report-host-history
+++ b/sg-report-host-history
Before we try anything with IPMI (if provided) or the PDU, try
rebooting with ssh.
I think this will dramatically reduce the rate at which we power cycle
our test hosts.
Signed-off-by: Ian Jackson
---
Osstest/TestSupport.pm | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff
No functional change with existing callers.
Signed-off-by: Ian Jackson
---
Osstest/Executive.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/Osstest/Executive.pm b/Osstest/Executive.pm
index 1b1cdc36..0d8502b5 100644
--- a/Osstest/Executive.pm
+++ b/Osstest/Executive.pm
@@ -60,6 +60,7
. There is a
difficulty with the FreeBSD host install, which is discussed in patch
26 which is definitely not ready in this form.
Ian Jackson (26):
power: Osstest::PDU::*: drop Exporter blocks
power: Osstest::PDU::*: use parent ::unsupported
power: ipmi_try: Use `use parent' instead of Exporter
These two modules both had the same `new' as `unsupported'. Now that
we have `use parent' they can be removed.
Signed-off-by: Ian Jackson
---
Osstest/PDU/manual.pm | 5 -
Osstest/PDU/xenuse.pm | 5 -
2 files changed, 10 deletions(-)
diff --git a/Osstest/PDU/manual.pm b/Osstest/PDU
Signed-off-by: Ian Jackson
---
Osstest/TestSupport.pm | 8
mg-hosts | 14 +-
2 files changed, 13 insertions(+), 9 deletions(-)
diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm
index 8101b739..e45f54b2 100644
--- a/Osstest/TestSupport.pm
+++ b
If ILOM is provided, and the host is not responding when we try logs
capture, try the ILOM before hard power cycling the host.
Signed-off-by: Ian Jackson
---
Osstest/TestSupport.pm | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Osstest/TestSupport.pm b/Osstest
No functional change.
Signed-off-by: Ian Jackson
---
Osstest/Executive.pm | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/Osstest/Executive.pm b/Osstest/Executive.pm
index 0be27b64..1b1cdc36 100644
--- a/Osstest/Executive.pm
+++ b/Osstest/Executive.pm
@@ -59,7
to be the most reliable.
* Currently there will only be one approach, `Only'.
No overall functional change other than to log messages.
Signed-off-by: Ian Jackson
---
Osstest/TestSupport.pm | 35 +--
1 file changed, 29 insertions(+), 6 deletions(-)
diff --git a/Osstest
both PowerPDU and PowerILOM.
The overall result of this patch, with that configuration, is to avoid
using the PDU at all if an IPMI-requested reboot is successful. This
should significantly reduce the number of hard power cycles for hosts
with IMPI.
Signed-off-by: Ian Jackson
---
Osstest
hosts) too.
Signed-off-by: Ian Jackson
---
Osstest/PDU/guest.pm | 5 +
Osstest/PDU/try_off.pm | 5 +
Osstest/PDU/unsupported.pm | 5 +
Osstest/TestSupport.pm | 9 -
4 files changed, 23 insertions(+), 1 deletion(-)
diff --git a/Osstest/PDU/guest.pm b/Osstest/PDU
approach
if ssh didn't work.
Signed-off-by: Ian Jackson
---
Osstest/PDU/ssh.pm | 74 ++
1 file changed, 74 insertions(+)
create mode 100644 Osstest/PDU/ssh.pm
diff --git a/Osstest/PDU/ssh.pm b/Osstest/PDU/ssh.pm
new file mode 100644
index
1101 - 1200 of 3634 matches
Mail list logo
