Re: [Xen-devel] Linux as 32-bit Dom0?

2017-11-23 Thread Juergen Gross
On 22/11/17 15:48, Jan Beulich wrote: On 22.11.17 at 15:40, wrote: >> On 22/11/17 15:05, Jan Beulich wrote: >>> Jürgen, Boris, >>> >>> am I trying something that's not allowed, but selectable via Kconfig? >>> On system with multiple IO-APICs (I assume that's what triggers the >>> problem) I g

[Xen-devel] [PATCH] x86/xen: support early interrupts in xen pv guests

2017-11-24 Thread Juergen Gross
Add early interrupt handlers activated by idt_setup_early_handler() to the handlers supported by Xen pv guests. This will allow for early WARN() calls not crashing the guest. Suggested-by: Andy Lutomirski Signed-off-by: Juergen Gross --- arch/x86/include/asm/segment.h | 12 arch

Re: [Xen-devel] [PATCH] x86/xen: support early interrupts in xen pv guests

2017-11-24 Thread Juergen Gross
Sorry, Andy, forgot to Cc: you... On 24/11/17 09:42, Juergen Gross wrote: > Add early interrupt handlers activated by idt_setup_early_handler() to > the handlers supported by Xen pv guests. This will allow for early > WARN() calls not crashing the guest. > > Suggested-by:

Re: [Xen-devel] Xen PV breakage after IRQ stack code refactoring

2017-11-26 Thread Juergen Gross
On 27/11/17 05:03, Andy Lutomirski wrote: > On Sun, Nov 26, 2017 at 9:10 AM, Boris Ostrovsky > wrote: >> Andy, >> >> (Can't find the original patch in my mailbox) >> >> This hunk from 1d3e53e8624a ("x86/entry/64: Refactor IRQ stacks and make >> them NMI-safe") >> >> >> diff --git a/arch/x86/entry/

Re: [Xen-devel] [PATCHv2] xen-netfront: remove warning when unloading module

2017-11-27 Thread Juergen Gross
laying the warnings on dmesg. > > The trick here is to make netfront to wait until netback frees all the g.e.'s > and only then continue to cleanup for the module removal, and this is done by > manipulating both device states. > > Signed-off-by: Eduardo Otubo Acked-by: Juer

Re: [Xen-devel] [PATCH] x86/entry/64/paravirt: Use paravirt-safe macro to access eflags

2017-11-27 Thread Juergen Gross
On 27/11/17 19:05, Boris Ostrovsky wrote: > Commit 1d3e53e8624a ("x86/entry/64: Refactor IRQ stacks and make > them NMI-safe") added DEBUG_ENTRY_ASSERT_IRQS_OFF macro that acceses > eflags using 'pushfq' instruction when testing for IF bit. On PV Xen > guests looking at IF flag directly will always

[Xen-devel] [PATCH 1/3] x86/boot: add acpi rsdp address to setup_header

2017-11-28 Thread Juergen Gross
the RSDP address. Being zero means it isn't specified and has to be located the legacy way (searching through low memory or EBDA). Signed-off-by: Juergen Gross --- Documentation/x86/boot.txt| 19 +++ arch/x86/boot/header.S| 6 +- arch/x86/in

[Xen-devel] [PATCH 2/3] x86/acpi: take rsdp address for boot params if available

2017-11-28 Thread Juergen Gross
In case the rsdp address in struct boot_params is specified don't try to find the table by searching, but take the address directly as set by the boot loader. Signed-off-by: Juergen Gross --- drivers/acpi/osl.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/acpi/os

[Xen-devel] [PATCH 0/3] x86: make rsdp address accessible via boot params

2017-11-28 Thread Juergen Gross
RSDP address being specified by grub2 (which in turn got the address via the start of day information block from Xen). Juergen Gross (3): x86/boot: add acpi rsdp address to setup_header x86/acpi: take rsdp address for boot params if available x86/xen: supply rsdp address in boot params for pvh

[Xen-devel] [PATCH 3/3] x86/xen: supply rsdp address in boot params for pvh guests

2017-11-28 Thread Juergen Gross
When booted via the special PVH entry save the RSDP address set in the boot information block in struct boot_params. This will enable Xen to locate the RSDP at an arbitrary address. Signed-off-by: Juergen Gross --- arch/x86/xen/enlighten_pvh.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [Xen-devel] [PATCH 2/3] x86/acpi: take rsdp address for boot params if available

2017-11-28 Thread Juergen Gross
On 28/11/17 11:18, Roger Pau Monné wrote: > On Tue, Nov 28, 2017 at 10:43:59AM +0100, Juergen Gross wrote: >> In case the rsdp address in struct boot_params is specified don't try >> to find the table by searching, but take the address directly as set >> by the boot l

Re: [Xen-devel] [PATCH 3/3] x86/xen: supply rsdp address in boot params for pvh guests

2017-11-28 Thread Juergen Gross
On 28/11/17 11:17, Roger Pau Monné wrote: > On Tue, Nov 28, 2017 at 10:44:00AM +0100, Juergen Gross wrote: >> When booted via the special PVH entry save the RSDP address set in the >> boot information block in struct boot_params. This will enable Xen to >> locate the RSDP at

Re: [Xen-devel] [PATCH v2] x86/entry/64/paravirt: Use paravirt-safe macro to access eflags

2017-11-28 Thread Juergen Gross
looking at IF flag directly will always see it set, resulting > in 'ud2'. > > Introduce SAVE_FLAGS() macro that will use appropriate save_fl pv op > when running paravirt. > > Signed-off-by: Boris Ostrovsky Reviewed-by: Juergen Gross Juergen

Re: [Xen-devel] [PATCH 0/3] x86: make rsdp address accessible via boot params

2017-11-28 Thread Juergen Gross
On 28/11/17 22:03, Rafael J. Wysocki wrote: > On Tue, Nov 28, 2017 at 10:43 AM, Juergen Gross wrote: >> In the non-EFI boot path the ACPI RSDP table is currently found via >> either EBDA or by searching through low memory for the RSDP magic. >> This requires the RSDP to be

Re: [Xen-devel] [RFC PATCH] KVM: x86: Allow Qemu/KVM to use PVH entry point

2017-11-29 Thread Juergen Gross
On 28/11/17 20:34, Maran Wilson wrote: > For certain applications it is desirable to rapidly boot a KVM virtual > machine. In cases where legacy hardware and software support within the > guest is not needed, Qemu should be able to boot directly into the > uncompressed Linux kernel binary without t

[Xen-devel] [PATCH 2/8] loader/linux: support passing rsdp address via boot params

2017-11-29 Thread Juergen Gross
Xen PVH guests will have the RSDP at an arbitrary address. Support that by passing the RSDP address via the boot parameters to Linux. Signed-off-by: Juergen Gross --- grub-core/loader/i386/linux.c | 6 ++ include/grub/i386/linux.h | 4 +++- 2 files changed, 9 insertions(+), 1 deletion

[Xen-devel] [PATCH 0/8] xen: add pvh guest support

2017-11-29 Thread Juergen Gross
loader is to pass the ACPI RSDP address via boot parameters to the kernel, as that table might not be located at the usual physical address just below 1MB. As the related Linux kernel patches are not yet accepted please wait for this to happen before applying the series. Juergen Gross (8): xen

[Xen-devel] [PATCH 8/8] xenpvh: add support to configure

2017-11-29 Thread Juergen Gross
Support platform i386/xenpvh in configure. Signed-off-by: Juergen Gross --- configure.ac | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configure.ac b/configure.ac index c7888e40f..d987d3379 100644 --- a/configure.ac +++ b/configure.ac @@ -147,6 +147,7 @@ case "$target_cpu"-

[Xen-devel] [PATCH 7/8] xenpvh: support grub-install for xenpvh

2017-11-29 Thread Juergen Gross
Add xenpvh support to grub-install. Signed-off-by: Juergen Gross --- include/grub/util/install.h | 1 + util/grub-install-common.c | 1 + util/grub-install.c | 7 +++ 3 files changed, 9 insertions(+) diff --git a/include/grub/util/install.h b/include/grub/util/install.h index

[Xen-devel] [PATCH 1/8] xen: add some xen headers

2017-11-29 Thread Juergen Gross
In order to support grub2 in Xen PVH environment some additional Xen headers are needed. Add them. Signed-off-by: Juergen Gross --- include/xen/hvm/hvm_op.h | 296 +++ include/xen/hvm/params.h | 284 ++ include/xen/hvm/start_info.h | 98 +++ include

[Xen-devel] [PATCH 6/8] xenpvh: support building a standalone image

2017-11-29 Thread Juergen Gross
Suppor mkimage for xenpvh. Signed-off-by: Juergen Gross --- include/grub/util/mkimage.h | 3 ++- util/grub-mkimage32.c | 1 + util/grub-mkimage64.c | 1 + util/grub-mkimagexx.c | 44 util/mkimage.c | 23

[Xen-devel] [PATCH 3/8] xen: carve out grant tab initialization into dedicated function

2017-11-29 Thread Juergen Gross
Initialize the grant tab in a dedicated function. This will enable using it for PVH guests, too. Signed-off-by: Juergen Gross --- grub-core/kern/xen/init.c | 35 +-- 1 file changed, 21 insertions(+), 14 deletions(-) diff --git a/grub-core/kern/xen/init.c b/grub

[Xen-devel] [PATCH 5/8] xenpvh: add build runes for grub-core

2017-11-29 Thread Juergen Gross
Add the modifications to the build system needed to build a xenpvh grub. Signed-off-by: Juergen Gross --- gentpl.py | 4 ++-- grub-core/Makefile.am | 12 grub-core/Makefile.core.def | 35 +++ 3 files changed, 49 insertions

[Xen-devel] [PATCH 4/8] xen: add xen pvh guest support to grub-core

2017-11-29 Thread Juergen Gross
PVH Enabling all this code is done later. Signed-off-by: Juergen Gross --- grub-core/kern/i386/tsc.c | 2 +- grub-core/kern/i386/xen/pvh.c | 344 ++ grub-core/kern/i386/xen/startup_pvh.S | 80 grub-core/kern/xen/init.c

Re: [Xen-devel] [RFC PATCH] KVM: x86: Allow Qemu/KVM to use PVH entry point

2017-11-29 Thread Juergen Gross
On 29/11/17 15:03, Boris Ostrovsky wrote: > On 11/29/2017 03:50 AM, Roger Pau Monné wrote: >> On Wed, Nov 29, 2017 at 09:21:59AM +0100, Juergen Gross wrote: >>> On 28/11/17 20:34, Maran Wilson wrote: >>>> For certain applications it is desirable to rapidly boot a KVM

[Xen-devel] [PATCH] libxl: put RSDP for PVH guest near 4GB

2017-11-29 Thread Juergen Gross
Instead of locating the RSDP table below 1MB put it just below 4GB like the rest of the ACPI tables in case of PVH guests. This will avoid punching more holes than necessary into the memory map. Signed-off-by: Juergen Gross --- tools/libxc/xc_dom_hvmloader.c | 2 +- tools/libxl/libxl_x86_acpi.c

Re: [Xen-devel] [PATCH] libxl: put RSDP for PVH guest near 4GB

2017-11-29 Thread Juergen Gross
On 29/11/17 15:25, Jan Beulich wrote: On 29.11.17 at 15:13, wrote: >> --- a/tools/libxl/libxl_x86_acpi.c >> +++ b/tools/libxl/libxl_x86_acpi.c >> @@ -23,7 +23,6 @@ >> /* Number of pages holding ACPI tables */ >> #define NUM_ACPI_PAGES 16 >> /* Store RSDP in the last 64 bytes of BIOS RO me

Re: [Xen-devel] [RFC PATCH] KVM: x86: Allow Qemu/KVM to use PVH entry point

2017-11-29 Thread Juergen Gross
On 29/11/17 15:44, Paolo Bonzini wrote: > On 29/11/2017 15:25, Boris Ostrovsky wrote: > zeropage is x86/Linux-specific so we'd need some sort of firmware (like > grub) between a hypervisor and Linux to convert hvm_start_info to > bootparams. qemu? >> >> I think KVM folks didn't wan

Re: [Xen-devel] [PATCH 0/8] xen: add pvh guest support

2017-11-30 Thread Juergen Gross
On 30/11/17 22:03, Daniel Kiper wrote: > On Wed, Nov 29, 2017 at 02:46:42PM +0100, Juergen Gross wrote: >> This patch series adds support for booting Linux as PVH guest. >> >> Similar to i386/xen and x86_64/xen platforms the new i386/xenpvh >> platform grub is booted as

[Xen-devel] [PATCH v2] libxl: put RSDP for PVH guest near 4GB

2017-12-01 Thread Juergen Gross
Instead of locating the RSDP table below 1MB put it just below 4GB like the rest of the ACPI tables in case of PVH guests. This will avoid punching more holes than necessary into the memory map. Signed-off-by: Juergen Gross Acked-by: Wei Liu --- tools/libxc/xc_dom_hvmloader.c | 2 +- tools

Re: [Xen-devel] [PATCH v2] tools/libxl: mark special pages as reserved in e820 map for PVH

2017-12-04 Thread Juergen Gross
On 21/11/17 12:06, Juergen Gross wrote: > The "special pages" for PVH guests include the frames for console and > Xenstore ring buffers. Those have to be marked as "Reserved" in the > guest's E820 map, as otherwise conflicts might arise later e.g. when &

Re: [Xen-devel] [patch 01/60] x86/entry/64/paravirt: Use paravirt-safe macro to access eflags

2017-12-05 Thread Juergen Gross
> Cc: jgr...@suse.com > Cc: xen-devel@lists.xenproject.org > Cc: l...@kernel.org > Link: > https://lkml.kernel.org/r/1512159805-6314-1-git-send-email-boris.ostrov...@oracle.com Reviewed-by: Juergen Gross Juergen ___ Xen-devel mailing

Re: [Xen-devel] [for-4.10] Re: [PATCH v2] tools/libxl: mark special pages as reserved in e820 map for PVH

2017-12-05 Thread Juergen Gross
On 05/12/17 16:23, Julien Grall wrote: > Hi Juergen, > > On 04/12/17 15:49, Juergen Gross wrote: >> On 21/11/17 12:06, Juergen Gross wrote: >>> The "special pages" for PVH guests include the frames for console and >>> Xenstore ring buffers. Those have to

Re: [Xen-devel] [PATCH 2/2] xen/pvcalls: Fix a check in pvcalls_front_remove()

2017-12-05 Thread Juergen Gross
ect to the backend") > Signed-off-by: Dan Carpenter Reviewed-by: Juergen Gross Juergen ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] xen/pvcalls: check for xenbus_read() errors

2017-12-05 Thread Juergen Gross
On 05/12/17 15:38, Dan Carpenter wrote: > Smatch complains that "len" is uninitialized if xenbus_read() fails so > let's add some error handling. > > Signed-off-by: Dan Carpenter Reviewed-by: Juergen Gross Juergen ___

Re: [Xen-devel] [for-4.10] Re: [PATCH v2] tools/libxl: mark special pages as reserved in e820 map for PVH

2017-12-06 Thread Juergen Gross
On 06/12/17 10:53, Julien Grall wrote: > Hi Juergen, > > On 12/05/2017 04:19 PM, Juergen Gross wrote: >> On 05/12/17 16:23, Julien Grall wrote: >>> Hi Juergen, >>> >>> On 04/12/17 15:49, Juergen Gross wrote: >>>> On 21/11/17 12:06, Juergen

Re: [Xen-devel] [for-4.10] Re: [PATCH v2] tools/libxl: mark special pages as reserved in e820 map for PVH

2017-12-06 Thread Juergen Gross
On 06/12/17 12:50, Julien Grall wrote: > Hi, > > On 12/06/2017 11:47 AM, Roger Pau Monné wrote: >> On Wed, Dec 06, 2017 at 12:22:00PM +0100, Juergen Gross wrote: >>> On 06/12/17 10:53, Julien Grall wrote: >>>> Hi Juergen, >>>> >>>> On 12

[Xen-devel] [PATCH v2 2/3] x86/acpi: take rsdp address for boot params if available

2017-12-07 Thread Juergen Gross
In case the rsdp address in struct boot_params is specified don't try to find the table by searching, but take the address directly as set by the boot loader. Signed-off-by: Juergen Gross --- drivers/acpi/osl.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/acpi/os

[Xen-devel] [PATCH v2 0/3] x86: make rsdp address accessible via boot params

2017-12-07 Thread Juergen Gross
RSDP address being specified by grub2 (which in turn got the address via the start of day information block from Xen). Juergen Gross (3): x86/boot: add acpi rsdp address to setup_header x86/acpi: take rsdp address for boot params if available x86/xen: supply rsdp address in boot params for pvh

[Xen-devel] [PATCH v2 1/3] x86/boot: add acpi rsdp address to setup_header

2017-12-07 Thread Juergen Gross
the RSDP address. Being zero means it isn't specified and has to be located the legacy way (searching through low memory or EBDA). Signed-off-by: Juergen Gross Reviewed-by: Roger Pau Monné --- Documentation/x86/boot.txt| 19 +++ arch/x86/boot/hea

[Xen-devel] [PATCH v2 3/3] x86/xen: supply rsdp address in boot params for pvh guests

2017-12-07 Thread Juergen Gross
-by: Juergen Gross --- V2: set bootloader version to 2.14 (Roger Pau Monné) --- arch/x86/xen/enlighten_pvh.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/x86/xen/enlighten_pvh.c b/arch/x86/xen/enlighten_pvh.c index 436c4f003e17..036e3a5f284a 100644 --- a/arch/x86/xen

Re: [Xen-devel] [PATCH v2 2/3] x86/acpi: take rsdp address for boot params if available

2017-12-08 Thread Juergen Gross
On 08/12/17 08:05, Ingo Molnar wrote: > > * Juergen Gross wrote: > >> In case the rsdp address in struct boot_params is specified don't try >> to find the table by searching, but take the address directly as set >> by the boot loader. >> >> Signed-of

Re: [Xen-devel] [PATCH v2 1/3] x86/boot: add acpi rsdp address to setup_header

2017-12-08 Thread Juergen Gross
On 08/12/17 08:16, Ingo Molnar wrote: > > * Juergen Gross wrote: > >> Xen PVH guests receive the address of the RSDP table from Xen. In order >> to support booting a Xen PVH guest via grub2 using the standard x86 >> boot entry we need a way fro grub2 to pass the RS

Re: [Xen-devel] [PATCH v2 3/3] x86/xen: supply rsdp address in boot params for pvh guests

2017-12-08 Thread Juergen Gross
On 08/12/17 08:22, Ingo Molnar wrote: > > * Juergen Gross wrote: > >> When booted via the special PVH entry save the RSDP address set in the >> boot information block in struct boot_params. This will enable Xen to >> locate the RSDP at an arbitrary address. >>

Re: [Xen-devel] [PATCH v2 1/3] x86/boot: add acpi rsdp address to setup_header

2017-12-08 Thread Juergen Gross
On 08/12/17 09:48, Ingo Molnar wrote: > > * Juergen Gross wrote: > >>>> +Offset/size: 0x268/8 >>>> +Protocol: 2.14+ >>>> + >>>> + This field can be set by the boot loader to tell the kernel the >>>> + physical addr

[Xen-devel] [GIT PULL] xen: fixes for 4.15-rc3

2017-12-08 Thread Juergen Gross
Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-4.15-rc3-tag xen: fixes for 4.15-rc3 Those are just two small fixes for the nev pvcalls frontend driver. Thanks. Juergen drivers/xen/pvcalls-front.c | 4 +++- 1 file changed, 3 in

Re: [Xen-devel] [PATCH v2 2/3] x86/acpi: take rsdp address for boot params if available

2017-12-08 Thread Juergen Gross
On 08/12/17 08:05, Ingo Molnar wrote: > > * Juergen Gross wrote: ... > acpi_physical_address acpi_arch_get_root_pointer(void) > { > return boot_params.hdr.acpi_rsdp_addr; > } > > 4) > > Add this to arch/x86/include/asm/acpi.h: >

Re: [Xen-devel] [PATCH v2 2/3] x86/acpi: take rsdp address for boot params if available

2017-12-08 Thread Juergen Gross
On 08/12/17 12:26, Ingo Molnar wrote: > > * Juergen Gross wrote: > >> On 08/12/17 08:05, Ingo Molnar wrote: >>> >>> * Juergen Gross wrote: >> >> ... >> >>> acpi_physical_address acpi_arch_get_root_pointer(void) >>> { >&g

Re: [Xen-devel] [PATCH] x86/Xen: don't report ancient LAPIC version

2017-12-08 Thread Juergen Gross
hypervisor's responsibility anyway, so > makes no sense to be used when running on Xen. Uniformly report a more > modern version; this shouldn't matter much as both LAPIC and IO-APIC are > being managed entirely / mostly by the hypervisor. > > Signed-off-by: Jan Beulich

[Xen-devel] [PATCH v3 3/4] x86/xen: fix boot loader version reported for pvh guests

2017-12-08 Thread Juergen Gross
# 4.12 Signed-off-by: Juergen Gross --- arch/x86/xen/enlighten_pvh.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/xen/enlighten_pvh.c b/arch/x86/xen/enlighten_pvh.c index 436c4f003e17..6e6430cb5e3f 100644 --- a/arch/x86/xen/enlighten_pvh.c +++ b/arch/x86/xen/enlighten

[Xen-devel] [PATCH v3 1/4] x86/boot: add acpi rsdp address to setup_header

2017-12-08 Thread Juergen Gross
the RSDP address. Being zero means it isn't specified and has to be located the legacy way (searching through low memory or EBDA). While documenting the new setup_header layout and protocol version 2.14 add the missing documentation of protocol version 2.13. Signed-off-by: Juergen Gross Review

[Xen-devel] [PATCH v3 4/4] x86/xen: supply rsdp address in boot params for pvh guests

2017-12-08 Thread Juergen Gross
-by: Juergen Gross --- V2: set bootloader version to 2.14 (Roger Pau Monné) --- arch/x86/xen/enlighten_pvh.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/x86/xen/enlighten_pvh.c b/arch/x86/xen/enlighten_pvh.c index 6e6430cb5e3f..e85e6dafe4bc 100644 --- a/arch/x86/xen

[Xen-devel] [PATCH v3 0/4] x86: make rsdp address accessible via boot params

2017-12-08 Thread Juergen Gross
RSDP address being specified by grub2 (which in turn got the address via the start of day information block from Xen). Juergen Gross (4): x86/boot: add acpi rsdp address to setup_header x86/acpi: take rsdp address for boot params if available x86/xen: fix boot loader version reported for pvh

[Xen-devel] [PATCH v3 2/4] x86/acpi: take rsdp address for boot params if available

2017-12-08 Thread Juergen Gross
In case the rsdp address in struct boot_params is specified don't try to find the table by searching, but take the address directly as set by the boot loader. Signed-off-by: Juergen Gross --- V3: use a generic retrieval function with a __weak annotated default function (Ingo M

Re: [Xen-devel] [PATCH v3 4/4] x86/xen: supply rsdp address in boot params for pvh guests

2017-12-11 Thread Juergen Gross
On 11/12/17 11:09, Jan Beulich wrote: On 08.12.17 at 16:11, wrote: >> Set the boot loader version to 2.14 (0x020e) replacing the wrong 0x0212 >> which should have been 0x020c. > > This part of the description has become partly stale now with the > new patch 3. Indeed. I'll wait for other co

Re: [Xen-devel] [PATCH 41/45] arch/x86: remove duplicate includes

2017-12-11 Thread Juergen Gross
On 11/12/17 21:42, Pravin Shedge wrote: > These duplicate includes have been found with scripts/checkincludes.pl but > they have been removed manually to avoid removing false positives. > > Signed-off-by: Pravin Shedge Reviewed-by: Juergen Gros

Re: [Xen-devel] [PATCH] xen: XEN_ACPI_PROCESSOR is Dom0-only

2017-12-12 Thread Juergen Gross
On 12/12/17 11:18, Jan Beulich wrote: > Add a respective dependency. > > Signed-off-by: Jan Beulich Reviewed-by: Juergen Gross Juergen ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/lis

Re: [Xen-devel] [PATCH 2/2] x86-64/Xen: eliminate W+X mappings

2017-12-12 Thread Juergen Gross
On 12/12/17 11:48, Jan Beulich wrote: On 12.12.17 at 11:38, wrote: >> * Jan Beulich wrote: >>> --- 4.15-rc3/arch/x86/xen/mmu_pv.c >>> +++ 4.15-rc3-x86_64-Xen-avoid-W+X/arch/x86/xen/mmu_pv.c >>> @@ -1902,6 +1902,16 @@ void __init xen_setup_kernel_pagetable(p >>> /* Graft it onto L4[511][5

Re: [Xen-devel] [PATCH] docs/process/xen-release-management: Lesson to learn

2017-12-13 Thread Juergen Gross
by committing to a release date before the exact code to be released > is known and has been made and tested. > > Evidently our docs makes it insufficiently clear not to do that. > > CC: Lars Kurth > CC: Julien Grall > CC: Juergen Gross > Signed-off-by: Ian Jacks

[Xen-devel] Xen release cycle revisited

2017-12-13 Thread Juergen Gross
Hi all, with 4.10 more or less finished it is time to plan for the next release 4.11. Since 4.7 we are using a 6 month release cycle [1] targeting to release in June and December. While this worked reasonably well for 4.7, 4.8 and 4.9 we had some difficulties with 4.10: bad luck with security pat

Re: [Xen-devel] [PATCH 0/8] xen: add pvh guest support

2017-12-14 Thread Juergen Gross
On 14/12/17 12:19, Daniel Kiper wrote: > On Fri, Dec 01, 2017 at 12:12:50PM +0100, Daniel Kiper wrote: >> On Fri, Dec 01, 2017 at 06:37:37AM +0100, Juergen Gross wrote: >>> On 30/11/17 22:03, Daniel Kiper wrote: >>>> On Wed, Nov 29, 2017 at 02:46:42PM +0100, Juergen

Re: [Xen-devel] Xen release cycle revisited

2017-12-14 Thread Juergen Gross
On 14/12/17 12:28, Julien Grall wrote: > > > On 14/12/17 07:56, Juergen Gross wrote: >> Hi all, > > Hi Juergen, > > I would recommend to CC committers on that thread, so your thread don't > get lost in the xen-devel meanders :). > >> with 4.10 more

Re: [Xen-devel] [PATCH 0/8] xen: add pvh guest support

2017-12-14 Thread Juergen Gross
On 14/12/17 12:32, Daniel Kiper wrote: > On Thu, Dec 14, 2017 at 12:26:02PM +0100, Juergen Gross wrote: >> On 14/12/17 12:19, Daniel Kiper wrote: >>> On Fri, Dec 01, 2017 at 12:12:50PM +0100, Daniel Kiper wrote: >>>> On Fri, Dec 01, 2017 at 06:37:37AM +0100, Juergen

Re: [Xen-devel] Xen release cycle revisited

2017-12-14 Thread Juergen Gross
On 14/12/17 13:43, Julien Grall wrote: > > > On 14/12/17 11:38, Juergen Gross wrote: >> On 14/12/17 12:28, Julien Grall wrote: >>> >>> >>> On 14/12/17 07:56, Juergen Gross wrote: >>>> Hi all, >>> >>> Hi Juergen, >>

Re: [Xen-devel] [PATCH 1/2] x86: consider effective protection attributes in W+X check

2017-12-14 Thread Juergen Gross
ags(*start); > - note_page(m, st, __pgprot(prot), 4); > + note_page(m, st, __pgprot(prot), eff, 4); > } else if (!kasan_page_table(m, st, pmd_start)) { > - walk_pte_level(m, st, *start, > + walk_pte_level(m, st, *start, eff, > P + i * PMD_LEVEL_MULT); > } You can drop the braces for both cases. Applies to similar constructs below, too. With that fixed you can add my: Reviewed-by: Juergen Gross Juergen ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 1/2] x86: consider effective protection attributes in W+X check

2017-12-14 Thread Juergen Gross
} else if (!kasan_page_table(m, st, pmd_start)) { >>> - walk_pte_level(m, st, *start, >>> + walk_pte_level(m, st, *start, eff, >>>P + i * PMD_LEVEL_MULT); >>>

[Xen-devel] Tree is open again

2017-12-14 Thread Juergen Gross
Committers, as 4.10 has been released, feel free to commit patches again. Juergen ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [GIT PULL] xen: fixes for 4.15-rc4

2017-12-14 Thread Juergen Gross
Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-4.15-rc4-tag xen: fixes for 4.15-rc4 It contains two minor fixes for running as Xen dom0: - when built as 32 bit kernel on large machines the Xen LAPIC emulation should report a rat

Re: [Xen-devel] [PATCH] xen/balloon: Mark unallocated host memory as UNUSABLE

2017-12-15 Thread Juergen Gross
On 12/12/17 23:51, Boris Ostrovsky wrote: > Commit f5775e0b6116 ("x86/xen: discard RAM regions above the maximum > reservation") left host memory not assigned to dom0 as available for > memory hotplug. > > Unfortunately this also meant that those regions could be used by > others. Specifically, co

Re: [Xen-devel] [PATCH] xen/balloon: Mark unallocated host memory as UNUSABLE

2017-12-15 Thread Juergen Gross
On 15/12/17 15:24, Boris Ostrovsky wrote: > >>> + >>> + hostmem_resource->start = max_addr; >>> + hostmem_resource->end = entry->addr + entry->size; >>> + for (; i < memmap.nr_entries; i++) { >>> + entry = &xen_e820_table->entries[i]; >>> + if (entry->type == E820_TYPE_RA

Re: [Xen-devel] Xen release cycle revisited

2017-12-15 Thread Juergen Gross
On 14/12/17 14:13, Juergen Gross wrote: > On 14/12/17 13:43, Julien Grall wrote: >> >> >> On 14/12/17 11:38, Juergen Gross wrote: >>> On 14/12/17 12:28, Julien Grall wrote: >>>> >>>> >>>> On 14/12/17 07:56, Juergen Gross wrote: >

Re: [Xen-devel] [PATCH] xen/balloon: Mark unallocated host memory as UNUSABLE

2017-12-15 Thread Juergen Gross
On 15/12/17 15:58, Boris Ostrovsky wrote: > On 12/15/2017 09:47 AM, Juergen Gross wrote: >> On 15/12/17 15:24, Boris Ostrovsky wrote: >>>>> + >>>>> + hostmem_resource->start = max_addr; >>>>> + hostmem_resource->end = entry-

Re: [Xen-devel] [RFC PATCH v3 2/2] KVM: x86: Allow Qemu/KVM to use PVH entry point

2017-12-15 Thread Juergen Gross
On 13/12/17 00:42, Maran Wilson wrote: > For certain applications it is desirable to rapidly boot a KVM virtual > machine. In cases where legacy hardware and software support within the > guest is not needed, Qemu should be able to boot directly into the > uncompressed Linux kernel binary without t

Re: [Xen-devel] [PATCH] swiotlb-zen: Convert to use macro

2019-09-02 Thread Juergen Gross
On 01.09.19 21:28, Souptick Joarder wrote: Rather than using static int max_dma_bits, this can be coverted to use as macro. Signed-off-by: Souptick Joarder s/zen/xen/ in the patch title, other than that: Reviewed-by: Juergen Gross Juergen

Re: [Xen-devel] [PATCH v2 3/3] xen/sched: add minimalistic idle scheduler for free cpus

2019-09-02 Thread Juergen Gross
On 02.09.19 13:06, Jan Beulich wrote: On 27.08.2019 14:40, Juergen Gross wrote: On 27.08.19 14:37, Andrew Cooper wrote: On 27/08/2019 11:59, Juergen Gross wrote: +static void * +sched_idle_alloc_vdata(const struct scheduler *ops, struct vcpu *v, + void *dd

[Xen-devel] [PATCH v2] xen: add macro for defining variable length array in public headers

2019-09-02 Thread Juergen Gross
header add a common macro for that purpose in xen.h. This at once corrects most of the definitions which miss one case leading to not defining the array at all. Signed-off-by: Juergen Gross --- V2: - rename macro (Jan Beulich) --- xen/include/public/arch-x86/hvm/save.h | 8 +--- xen/include

[Xen-devel] [PATCH] tools/libs: put common Makefile parts into new libs.mk

2019-09-03 Thread Juergen Gross
The Makefile below tools/libs have a lot in common. Put those common parts into a new libs.mk and include that from the specific Makefiles. Signed-off-by: Juergen Gross --- tools/libs/call/Makefile | 86 ++- tools/libs/devicemodel/Makefile | 88

Re: [Xen-devel] [PATCH v3 1/4] xen: use common output function in debugtrace

2019-09-03 Thread Juergen Gross
On 03.09.19 12:00, Jan Beulich wrote: On 28.08.2019 10:00, Juergen Gross wrote: Today dumping the debugtrace buffers is done via sercon_puts(), while direct printing of trace entries (after toggling output to the console) is using serial_puts(). Use sercon_puts() in both cases, as the

Re: [Xen-devel] [PATCH v3 3/4] xen: refactor debugtrace data

2019-09-03 Thread Juergen Gross
On 03.09.19 12:16, Jan Beulich wrote: On 28.08.2019 10:00, Juergen Gross wrote: As a preparation for per-cpu buffers do a little refactoring of the debugtrace data: put the needed buffer admin data into the buffer as it will be needed for each buffer. While at it switch

Re: [Xen-devel] [PATCH v3 4/4] xen: add per-cpu buffer option to debugtrace

2019-09-03 Thread Juergen Gross
On 03.09.19 12:51, Jan Beulich wrote: On 28.08.2019 10:00, Juergen Gross wrote: @@ -24,32 +25,62 @@ struct debugtrace_data_s { }; static struct debugtrace_data_s *debtr_data; +static DEFINE_PER_CPU(struct debugtrace_data_s *, debtr_cpu_data); -static unsigned int debugtrace_kilobytes

Re: [Xen-devel] [PATCH V2] arm: xen: mm: use __GPF_DMA32 for arm64

2019-09-03 Thread Juergen Gross
On 02.09.19 17:57, Christoph Hellwig wrote: On Fri, Aug 30, 2019 at 07:40:42PM -0700, Stefano Stabellini wrote: + Juergen, Boris On Fri, 30 Aug 2019, Christoph Hellwig wrote: Can we take a step back and figure out what we want to do here? AFAICS this function allocates memory for the swiotlb-

Re: [Xen-devel] [PATCH v3 1/4] xen: use common output function in debugtrace

2019-09-03 Thread Juergen Gross
On 03.09.19 13:47, Jan Beulich wrote: On 03.09.2019 12:22, Juergen Gross wrote: On 03.09.19 12:00, Jan Beulich wrote: On 28.08.2019 10:00, Juergen Gross wrote: Today dumping the debugtrace buffers is done via sercon_puts(), while direct printing of trace entries (after toggling output to the

Re: [Xen-devel] [PATCH v3 4/4] xen: add per-cpu buffer option to debugtrace

2019-09-03 Thread Juergen Gross
On 03.09.19 14:01, Jan Beulich wrote: On 03.09.2019 13:10, Juergen Gross wrote: On 03.09.19 12:51, Jan Beulich wrote: On 28.08.2019 10:00, Juergen Gross wrote: +static void debugtrace_dump_buffer(struct debugtrace_data_s *data, + const char *which

Re: [Xen-devel] [PATCH v3 1/4] xen: use common output function in debugtrace

2019-09-03 Thread Juergen Gross
On 03.09.19 14:09, Jan Beulich wrote: On 03.09.2019 13:58, Juergen Gross wrote: On 03.09.19 13:47, Jan Beulich wrote: On 03.09.2019 12:22, Juergen Gross wrote: On 03.09.19 12:00, Jan Beulich wrote: On 28.08.2019 10:00, Juergen Gross wrote: Today dumping the debugtrace buffers is done via

Re: [Xen-devel] [PATCH v3 3/4] xen: refactor debugtrace data

2019-09-03 Thread Juergen Gross
On 03.09.19 13:50, Jan Beulich wrote: On 03.09.2019 12:31, Juergen Gross wrote: On 03.09.19 12:16, Jan Beulich wrote: On 28.08.2019 10:00, Juergen Gross wrote: +static unsigned int debugtrace_kilobytes = 128; Since you touch this anyway, add __initdata? Maybe also move it next to its

Re: [Xen-devel] [PATCH v3 1/5] xen/spinlocks: in debug builds store cpu holding the lock

2019-09-03 Thread Juergen Gross
On 03.09.19 16:11, Jan Beulich wrote: On 29.08.2019 12:18, Juergen Gross wrote: --- a/xen/include/xen/spinlock.h +++ b/xen/include/xen/spinlock.h @@ -6,14 +6,21 @@ #include #ifndef NDEBUG -struct lock_debug { -s16 irq_safe; /* +1: IRQ-safe; 0: not IRQ-safe; -1: don't kno

Re: [Xen-devel] [PATCH v3 3/5] xen: print lock profile info in panic()

2019-09-03 Thread Juergen Gross
On 03.09.19 16:22, Jan Beulich wrote: On 29.08.2019 12:18, Juergen Gross wrote: V2: - rename CONFIG_LOCK_PROFILE to CONFIG_DEBUG_LOCK_PROFILE (Jan Beulich) - move .lockprofile.data section to init area in linker scripts How can this be correct, when you don't change lock_prof_init() a

Re: [Xen-devel] [PATCH v3 5/5] xen: modify several static locks to unique names

2019-09-03 Thread Juergen Gross
On 03.09.19 16:53, Jan Beulich wrote: On 29.08.2019 12:18, Juergen Gross wrote: In order to have unique names when doing lock profiling several local locks "lock" need to be renamed. But these are all named simply "lock" for a good reason, including because they're a

Re: [Xen-devel] [PATCH v3 5/5] xen: modify several static locks to unique names

2019-09-03 Thread Juergen Gross
On 03.09.19 17:09, Jan Beulich wrote: On 03.09.2019 17:03, Juergen Gross wrote: On 03.09.19 16:53, Jan Beulich wrote: On 29.08.2019 12:18, Juergen Gross wrote: In order to have unique names when doing lock profiling several local locks "lock" need to be renamed. But these are

Re: [Xen-devel] [PATCH v3 5/5] xen: modify several static locks to unique names

2019-09-04 Thread Juergen Gross
On 03.09.19 17:09, Jan Beulich wrote: On 03.09.2019 17:03, Juergen Gross wrote: On 03.09.19 16:53, Jan Beulich wrote: On 29.08.2019 12:18, Juergen Gross wrote: In order to have unique names when doing lock profiling several local locks "lock" need to be renamed. But these are

Re: [Xen-devel] [PATCH v3 4/5] xen: modify lock profiling interface

2019-09-04 Thread Juergen Gross
On 03.09.19 16:46, Jan Beulich wrote: On 29.08.2019 12:18, Juergen Gross wrote: Today adding locks located in a struct to lock profiling requires a unique type index for each structure. This makes it hard to add any new structure as the related sysctl interface needs to be changed, too

Re: [Xen-devel] [PATCH v3 5/5] xen: modify several static locks to unique names

2019-09-04 Thread Juergen Gross
On 04.09.19 10:40, Jan Beulich wrote: On 04.09.2019 10:25, Juergen Gross wrote: On 03.09.19 17:09, Jan Beulich wrote: On 03.09.2019 17:03, Juergen Gross wrote: On 03.09.19 16:53, Jan Beulich wrote: On 29.08.2019 12:18, Juergen Gross wrote: In order to have unique names when doing lock

Re: [Xen-devel] [PATCH v3 5/5] xen: modify several static locks to unique names

2019-09-04 Thread Juergen Gross
On 04.09.19 10:58, Andrew Cooper wrote: On 04/09/2019 09:40, Jan Beulich wrote: On 04.09.2019 10:25, Juergen Gross wrote: On 03.09.19 17:09, Jan Beulich wrote: On 03.09.2019 17:03, Juergen Gross wrote: On 03.09.19 16:53, Jan Beulich wrote: On 29.08.2019 12:18, Juergen Gross wrote: In order

Re: [Xen-devel] [PATCH v3 5/5] xen: modify several static locks to unique names

2019-09-04 Thread Juergen Gross
On 04.09.19 11:15, Andrew Cooper wrote: On 04/09/2019 10:11, Juergen Gross wrote: On 04.09.19 10:58, Andrew Cooper wrote: On 04/09/2019 09:40, Jan Beulich wrote: On 04.09.2019 10:25, Juergen Gross wrote: On 03.09.19 17:09, Jan Beulich wrote: On 03.09.2019 17:03, Juergen Gross wrote: On

Re: [Xen-devel] [PATCH v3 5/5] xen: modify several static locks to unique names

2019-09-04 Thread Juergen Gross
On 04.09.19 10:51, Jan Beulich wrote: On 04.09.2019 10:47, Juergen Gross wrote: On 04.09.19 10:40, Jan Beulich wrote: On 04.09.2019 10:25, Juergen Gross wrote: On 03.09.19 17:09, Jan Beulich wrote: On 03.09.2019 17:03, Juergen Gross wrote: On 03.09.19 16:53, Jan Beulich wrote: On

[Xen-devel] [PATCH v4 0/4] xen: debugtrace cleanup and per-cpu buffer support

2019-09-04 Thread Juergen Gross
patch 1 (preparing the move of debugtrace coding) - patch 4 (v1 patch 3): avoid leaking buffer Juergen Gross (4): xen: fix debugtrace clearing xen: move debugtrace coding to common/debugtrace.c xen: refactor debugtrace data xen: add per-cpu buffer option to debugtrace docs/misc/xen

[Xen-devel] [PATCH v4 4/4] xen: add per-cpu buffer option to debugtrace

2019-09-04 Thread Juergen Gross
unction to accept size modifiers (e.g. 4M or 1G). Printing out the trace entries is done for each buffer in order to minimize the effort needed during printing. As each entry is prefixed with its sequence number sorting the entries can easily be done when analyzing them. Signed-off-by: Juergen Gro

[Xen-devel] [PATCH v4 3/4] xen: refactor debugtrace data

2019-09-04 Thread Juergen Gross
As a preparation for per-cpu buffers do a little refactoring of the debugtrace data: put the needed buffer admin data into the buffer as it will be needed for each buffer. While at it switch debugtrace_send_to_console and debugtrace_used to bool and delete an empty line. Signed-off-by: Juergen

[Xen-devel] [PATCH v4 1/4] xen: fix debugtrace clearing

2019-09-04 Thread Juergen Gross
chars to be printed in the related interfaces, so the trailing 0 byte is no longer required. Signed-off-by: Juergen Gross --- xen/drivers/char/console.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c index

[Xen-devel] [PATCH v4 2/4] xen: move debugtrace coding to common/debugtrace.c

2019-09-04 Thread Juergen Gross
Instead of living in drivers/char/console.c move the debugtrace related coding to a new file common/debugtrace.c No functional change, code movement only. Signed-off-by: Juergen Gross Acked-by: Jan Beulich --- xen/common/Makefile| 1 + xen/common/debugtrace.c| 180

  1   2   3   4   5   6   7   8   9   10   >