Re: Block protocol incompatibilities with 4K logical sector size disks

2024-09-02 Thread Mark Syms
On Mon, 2 Sept 2024 at 09:55, Roger Pau Monné wrote: > > > So yes, after more research, having sector in the protocol been a > > 512-byte size seems the least bad option. "sector_number" and > > "{first,last}_sect" have been described as is for a long while. Only > > "sectors" for the size has bee

Xen Summit 2023: Design Session Notes: SMAPIv3

2023-06-28 Thread Mark Syms
Slides used for scene setting - https://github.com/xapi-project/xen-api/discussions/5080. Example code in Github - https://github.com/xapi-project/xen-api/tree/master/ocaml/xapi-storage/python/examples Notes taken in the session Since scene setting slides wer

[PATCH 0/1] Updated: Ensure PV ring is drained on disconenct

2023-04-20 Thread Mark Syms
Updated patch to address intermittent SIGSEGV on domain disconnect/shutdown. Mark Syms (1): Ensure the PV ring is drained on disconnect hw/block/dataplane/xen-block.c | 31 +-- 1 file changed, 25 insertions(+), 6 deletions(-) -- 2.40.0 >F

Re: [PATCH v2 RESEND] xen: Fix SEGV on domain disconnect

2023-04-24 Thread Mark Syms
Copying in Tim who did the final phase of the changes. On Mon, 24 Apr 2023 at 11:32, Paul Durrant wrote: > > On 20/04/2023 12:02, mark.s...@citrix.com wrote: > > From: Mark Syms > > > > Ensure the PV ring is drained on disconnect. Also ensure all pending > > AIO is

Re: [PATCH] Clarify the cases where BLKIF_RSP_EOPNOTSUPP can be returned.

2025-08-29 Thread Mark Syms
On Fri, 29 Aug 2025 at 08:41, Roger Pau Monné wrote: > I think there's no need to mention the specific operations. FWIW, > blkback will return BLKIF_RSP_EOPNOTSUPP for any request type it > doesn't understand (see dispatch_other_io()), which covers any > possible request type that's not yet define

[PATCH] Clarify the cases where BLKIF_RSP_EOPNOTSUPP can be returned.

2025-08-28 Thread Mark Syms
Previously this said it would only happen on barrier writes. Except the documentation blocks for * feature-flush-cache * feature-discard Also say that they can return this error. Signed-off-by: Mark Syms --- xen/include/public/io/blkif.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH] [xen-block] Return BLKIF_RSP_EOPNOTSUPP for unknown operation

2025-08-28 Thread Mark Syms
> The comment in blkif.h contains: > > /* Operation not supported (only happens on barrier writes). */ > #define BLKIF_RSP_EOPNOTSUPP -2 > > So in principle BLKIF_RSP_EOPNOTSUPP is only to be used as a response > for BLKIF_OP_WRITE_BARRIER or BLKIF_OP_FLUSH_DISKCACHE requests, > however blkback a

[PATCH] [xen-block] Return BLKIF_RSP_EOPNOTSUPP for unknown operation

2025-08-27 Thread Mark Syms
in-flight request might be issued (or reissued) which is then not supported by this backend. Signed-off-by: Mark Syms --- hw/block/dataplane/xen-block.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/block/dataplane/xen-block.c b/hw/block/dataplane/xen-block.c index