On Wed, May 15, Olaf Hering wrote:
> Am Mon, 13 May 2019 17:20:05 +0200
> schrieb Roger Pau Monné :
>
> > Let me know if that works for you and I will submit it formally.
> Yes, it works for me. Thanks.
Did you have a chance to submit a fix to support '--disable-pv-shim'?
Ol
Am Sun, 18 Aug 2019 18:20:26 +0100
schrieb Wei Liu :
> This doesn't apply. There is no such file.
My changes need to be applied in this order, some of them may apply in any
order:
20190619120633.27466-1-o...@aepfle.de
20190619121715.28532-1-o...@aepfle.de
20190619123818.30747-1-o...@aepfle.de
Ian, Wei,
we got a report about a crash from libxl_domain_suspend like this, from 'virsh
migrate --live xen+ssh://host':
#1 helper_done (egc=0x7fc0284aa6c0, shs=0x7fc0180256c8) at
libxl_save_callout.c:371
helper_failed
helper_stop
libxl__save_helper_abort
#2 check_all_finished
A plain crashkernel=size is apparently not supported by the code
anymore. In case kdump ever worked like that, the code which removed
support for this notation did not update the documentation.
Signed-off-by: Olaf Hering
---
docs/misc/kexec_and_kdump.txt | 14 ++
1 file changed, 2
Am Wed, 4 Sep 2019 10:18:41 +0100
schrieb Andrew Cooper :
> That sounds like an accidental regression in parsing of crashkernel=,
> rather than a deliberate action.
Maybe just the lack of b49225dc9df336405292dc08862b4c7c9d887bd6 in vendor
binaries...
It is likely broken since 4.10. I have not
Am Wed, 4 Sep 2019 16:22:37 +0200
schrieb Jan Beulich :
> First of all - does "the code" here mean master/staging, or any
> release branch? And then, yes, on release branches there will be
> EINVAL, but as said before kexec_crash_area.size will get/remain
> set nevertheless (as the error path
Am Wed, 4 Sep 2019 14:19:23 +0200
schrieb Jan Beulich :
> On 04.09.2019 11:37, Olaf Hering wrote:
> > Maybe just the lack of b49225dc9df336405292dc08862b4c7c9d887bd6 in vendor
> > binaries...
> But this change was only to deal with the bogus log message.
> The handl
n is only called after stream_header_done.
Any error before that will leave dss partly uninitialized.
Fix this crash by checking if ->completion_callback is valid.
Signed-off-by: Olaf Hering
---
tools/libxl/libxl_save_callout.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff -
The referenced versions can not run staging anymore since a while.
Signed-off-by: Olaf Hering
---
tools/examples/Makefile | 1 -
tools/examples/README.incompatibilities | 38 -
2 files changed, 39 deletions(-)
delete mode 100644 tools/examples
Maybe xm create had a feature to create a domU based on a configuration
file. xl create requires the '-f' option to refer to a file.
There is no code to look into XEN_CONFIG_DIR, so remove the example.
Signed-off-by: Olaf Hering
---
docs/man/xl.1.pod.in | 7 ---
1 file changed, 7 deletions
directory. The expected values are all described in xl.conf(5). There is
no need to duplicate this info into another file.
If the local admin really needs to tweak the defaults he will be able to
create this file with the desired content.
Signed-off-by: Olaf Hering
Acked-by: Dario Faggioli
---
tools
Resending due to lack of responses.
Olaf
Olaf Hering (8):
stubdom/vtpm: include stdio.h for declaration of printf
tools: move scripts from etc to libexec
Use XEN_SCRIPT_DIR to refer to /etc/xen/scripts
Remove tools/examples/README.incompatibilities
tools: remove empty xl.conf
Remove
because they are not exactly configuration.
Signed-off-by: Olaf Hering
---
m4/paths.m4 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/m4/paths.m4 b/m4/paths.m4
index 89d3bb8312..0ccc92d0ff 100644
--- a/m4/paths.m4
+++ b/m4/paths.m4
@@ -137,7 +137,7 @@ AC_SUBST(INITD_DIR
Now that scripts are stored in libexec, replace all hardcoded paths to
use XEN_SCRIPT_DIR to expand the actual location.
Update .gitignore.
Signed-off-by: Olaf Hering
---
.gitignore | 3 +++
docs/configure.ac
xl(1) opens xl.conf in XEN_CONFIG_DIR.
Substitute this variable also in the man page.
Signed-off-by: Olaf Hering
Reviewed-by: Anthony PERARD
---
docs/man/xl.1.pod.in | 2 +-
docs/man/xl.conf.5.pod.in | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/man/xl.1
directory. The expected values are all described in xlcpupool.cfg(5).
There is no need to duplicate this info into another file.
The need for a dedicated file is also described in xl(1) cpupool-create.
Signed-off-by: Olaf Hering
---
tools/examples/Makefile | 1 -
tools/examples/README | 1 -
tools
ected: ");
vtpmblk.c:322:7: warning: incompatible implicit declaration of built-in
function 'printf'
vtpmblk.c:322:7: note: include '' or provide a declaration of 'printf'
Signed-off-by: Olaf Hering
---
stubdom/vtpm/vtpmblk.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/stubdom/vtpm/vtpmblk.c
Am Tue, 24 Sep 2019 15:09:58 +0100
schrieb Ian Jackson :
> Err, no ?
It will happen for sure:
https://github.com/thkukuk/atomic-updates_and_etc/blob/master/README.md
https://en.opensuse.org/openSUSE:Packaging_UsrEtc
Olaf
pgpK7xJyPc0sl.pgp
Description: Digitale Signatur von OpenPGP
Am Tue, 24 Sep 2019 15:17:43 +0100
schrieb Ian Jackson :
> I think the ability of the admin to edit these scripts is important and I
> have used it myself in the past.
Since they are scripts, they can be edited in any location. To me it is not
clear what the case would be to diverge from the
ected: ");
vtpmblk.c:322:7: warning: incompatible implicit declaration of built-in
function 'printf'
vtpmblk.c:322:7: note: include '' or provide a declaration of 'printf'
Signed-off-by: Olaf Hering
cked-by: Daniel De Graaf
---
stubdom/vtpm/vtpmblk.c | 1 +
1 file changed, 1 insertion(+)
diff --git
The referenced versions can not run staging anymore since a while.
Signed-off-by: Olaf Hering
---
tools/examples/Makefile | 1 -
tools/examples/README.incompatibilities | 38 -
2 files changed, 39 deletions(-)
delete mode 100644 tools/examples
the hotplug scripts to libexec because they are not exactly
configuration. The current default is unchanged, which is
/etc/xen/scripts.
Signed-off-by: Olaf Hering
---
m4/paths.m4 | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/m4/paths.m4 b/m4/paths.m4
index 89d3bb8312
Maybe xm create had a feature to create a domU based on a configuration
file. xl create requires the '-f' option to refer to a file.
There is no code to look into XEN_CONFIG_DIR, so remove the example.
Signed-off-by: Olaf Hering
---
docs/man/xl.1.pod.in | 7 ---
1 file changed, 7 deletions
directory. The expected values are all described in xl.conf(5). There is
no need to duplicate this info into another file.
If the local admin really needs to tweak the defaults he will be able to
create this file with the desired content.
Signed-off-by: Olaf Hering
Acked-by: Dario Faggioli
---
tools
Olaf Hering (8):
stubdom/vtpm: include stdio.h for declaration of printf
tools: add with-xen-scriptdir configure option
Use XEN_SCRIPT_DIR to refer to /etc/xen/scripts
Remove tools/examples/README.incompatibilities
tools: remove empty xl.conf
Remove tools/examples/cpupool
docs
Replace all hardcoded paths to use XEN_SCRIPT_DIR to expand the actual location.
Update .gitignore.
Signed-off-by: Olaf Hering
---
.gitignore | 3 +++
docs/configure.ac | 3 +++
.../{xl
xl(1) opens xl.conf in XEN_CONFIG_DIR.
Substitute this variable also in the man page.
Signed-off-by: Olaf Hering
Reviewed-by: Anthony PERARD
---
docs/man/xl.1.pod.in | 2 +-
docs/man/xl.conf.5.pod.in | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/man/xl.1
directory. The expected values are all described in xlcpupool.cfg(5).
There is no need to duplicate this info into another file.
The need for a dedicated file is also described in xl(1) cpupool-create.
Signed-off-by: Olaf Hering
---
tools/examples/Makefile | 1 -
tools/examples/README | 1 -
tools
Am Tue, 24 Sep 2019 15:17:43 +0100
schrieb Ian Jackson :
> I might be open to argument on that for specific target operating systems if
> the appropriate distro maintainers were to make a case.
I provided reasons why the current default is not appropriate, and the change
should be applied.
Am Fri, 27 Sep 2019 18:17:12 +0100
schrieb Ian Jackson :
> Olaf Hering writes ("[PATCH v1] libxl: fix crash in helper_done due to
> uninitialized data"):
> > A crash in helper_done, called from libxl_domain_suspend, was reported,
> > libxl_aoutils.c:328:datacopier_wri
Am Wed, 2 Oct 2019 19:05:37 +0200
schrieb Olaf Hering :
> add a knob to configure
Was this ever considered for merging, or are we done with this series?
Olaf
pgp2HK5KoaJkO.pgp
Description: Digitale Signatur von OpenPGP
___
Xen-devel mailing l
Am Sun, 13 Oct 2019 18:21:27 +0200
schrieb Samuel Thibault :
> > > cked-by: Daniel De Graaf
>
> Note that you miss an 'A' at the beginning of the line there.
Thanks for spotting.
Should I resend this patch?
Olaf
pgpgf6l4YQpvk.pgp
Description: Digitale Signatur von OpenPGP
I was made aware of the fact that Xen apparently loses memory as soon as domUs
are started. In my testing HVM domUs occupy much more memory than what was
configured for them. The expected memory footprint for a PV domU seems to match
the value in the domU config file.
My test host has 128GB
Am Thu, 13 Feb 2020 11:28:29 +0100
schrieb Jan Beulich :
> On 12.02.2020 15:22, Olaf Hering wrote:
> > With the script below, the formula may look like this:
> > - each vcpu needs 1MB extra memory
> > - each GB of a HVM domU memory needs 8MB extra memory
> > - each HVM
Am Wed, 12 Feb 2020 11:53:25 +0100
schrieb Olaf Hering :
> Is there a formula to calculate that amount of extra memory, is this behavior
> documented somewhere?
With the script below, the formula may look like this:
- each vcpu needs 1MB extra memory
- each GB of a HVM domU memory nee
Add missing 'a' to sharing.
Signed-off-by: Olaf Hering
---
xen/include/public/domctl.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
index fec6f6fdd1..1ad34c35eb 100644
--- a/xen/include/public/domctl.h
+++ b/xen
Am Mon, 13 Jan 2020 11:36:27 +0100
schrieb Olaf Hering :
> This HVM domU fails to live migrate from staging-4.12 to staging-4.13:
It turned out libxl does not configure qemu correctly at runtime:
libxl__build_device_model_args_new() uses 'qemu -machine xenfv', perhaps with
the assumpt
Am Mon, 27 Jan 2020 11:54:37 +
schrieb "Durrant, Paul" :
> > Should the string "pc-i440fx-3.0" become a configure option?
> I suppose. Could we have "pc-i440fx" as the default, which libxl prefix
> matches against qemu's supported versions to select the latest?
I think the qemu machine
The array is named msr_policy.
Fixes commit 60529dfeca1
Signed-off-by: Olaf Hering
---
xen/include/public/domctl.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
index e313da499f..2bb7397923 100644
--- a/xen/include
Am Mon, 27 Jan 2020 11:54:37 +
schrieb "Durrant, Paul" :
> I suppose. Could we have "pc-i440fx" as the default, which libxl prefix
> matches against qemu's supported versions to select the latest? I guess that
> would work.
This can not be fixed in libxl because libxl can not possibly know
I did not find anything in the Xen 4.13 release notes, so I'm asking here:
This HVM domU fails to live migrate from staging-4.12 to staging-4.13:
name='hvm'
serial='pty'
vcpus='4'
memory='888'
disk=[ 'vdev=xvda, format=raw, access=rw, target=/netshare/disk0.raw' ]
vif=[
Am Mon, 13 Jan 2020 11:36:27 +0100
schrieb Olaf Hering :
> qemu-system-i386: Unknown savevm section type 111
Looks like hw/i386/pc_piix.c:xenfv_machine_options must set
m->smbus_no_migration_support to true.
Not sure why this remained unnoticed for so long.
Olaf
pgpffQqWBqgtH.pgp
Descr
On Fri, Mar 27, Ian Jackson wrote:
> This seems likely to be right, but: what is the default in Xen ? Is
> it sufficiently tight to stop a guest using too many resources ?
The value of d->max_evtchns will be either 4k or 128k.
AFAICS no extra resources are allocated with the changed value.
The imposed limit of 1023 is too low for a three digit value of vcpus.
Remove the arbitrary value of 1023 and let Xen decide about the upper limit.
Signed-off-by: Olaf Hering
---
docs/man/xl.cfg.5.pod.in | 8 +++-
tools/libxl/libxl_create.c | 2 +-
2 files changed, 4 insertions(+), 6
Use also HOSTCFLAGS for biossums while touching the code.
Spotted by inspecting build logfile.
Signed-off-by: Olaf Hering
---
tools/firmware/rombios/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/firmware/rombios/Makefile b/tools/firmware/rombios
A return value of zero means no PV drivers. Restore a hunk which was removed.
Fixes commit b183e180bce93037d3ef385a8c2338bbfb7f23d9
Signed-off-by: Olaf Hering
---
tools/libxl/libxl_domain.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tools/libxl/libxl_domain.c b/tools/libxl
It mentions just stale and obsolete distributions.
They are not suitable to build current Xen, since a couple of years.
Signed-off-by: Olaf Hering
---
tools/examples/Makefile | 1 -
tools/examples/README.incompatibilities | 38 -
2 files changed, 39
Use existing helper to allocate a bitmap.
Signed-off-by: Olaf Hering
---
tools/libxc/xc_sr_save.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/libxc/xc_sr_save.c b/tools/libxc/xc_sr_save.c
index 80b1d5de1f..bc5a1a723c 100644
--- a/tools/libxc/xc_sr_save.c
+++ b
Am Wed, 9 Sep 2020 14:06:42 +0100
schrieb Julien Grall :
> "bridge-utils (if iroute version < ...)"
A brief search in git://git.kernel.org/pub/scm/network/iproute2/iproute2.git
shows bridge support appeared in v3.5.0 from 2012.
One can barely run Xen on such old dists, so the patch is fine as
Am Wed, 9 Sep 2020 14:43:28 +0100
schrieb Julien Grall :
> If you think that bridge-utils should be dropped, then please send a
> proposal to remove/deprecate brctl.
This was already done with 0e7c69bd3c0b35a677d73843b39522787ccf5a3f.
The current code is just the simple form of a fallback, it
Am Wed, 9 Sep 2020 13:43:10 +0100
schrieb Julien Grall :
> So can you expand how this is an unusual combination?
'ip' is the tool of choice since a couple of years. What 'git grep' shows is
just compat code.
Olaf
pgpHVAGHf0gSR.pgp
Description: Digitale Signatur von OpenPGP
Having the latest Xen, but an obsolete iproute package, is an unusual
combination.
Signed-off-by: Olaf Hering
---
README | 1 -
1 file changed, 1 deletion(-)
diff --git a/README b/README
index 0e4787c1a6..ce580d3029 100644
--- a/README
+++ b/README
@@ -57,7 +57,6 @@ provided by your OS
On Wed, Sep 09, Juergen Gross wrote:
> +++ b/tools/libs/guest/include/xenguest.h
> +#include
In case this file will be installed via make install:
Does any of the pending patches create that file?
Olaf
signature.asc
Description: PGP signature
of `tpm_version';
/home/abuild/rpmbuild/BUILD/xen-4.14.20200616T103126.3625b04991/non-dbg/stubdom/vtpmmgr/vtpmmgr.a(vtpmmgr.o):(.bss+0x0):
first defined here
Signed-off-by: Olaf Hering
---
stubdom/vtpmmgr/vtpmmgr.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/stubdom/vtpmmgr
xc_map_foreign_bulk is an obsolete API, which is only used by
qemu-xen-traditional.
Adjust the error string to refer to the current API.
Signed-off-by: Olaf Hering
---
tools/libs/foreignmemory/freebsd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/libs
process to make it more obvious which
side produced a given log line.
Signed-off-by: Olaf Hering
---
docs/man/xl.1.pod.in | 4
tools/xl/xl_cmdtable.c | 1 +
tools/xl/xl_migrate.c | 25 +
3 files changed, 26 insertions(+), 4 deletions(-)
diff --git a/docs/man/xl.1
Signed-off-by: Olaf Hering
---
tools/xl/Makefile| 4 ++--
tools/xl/bash-completion | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/xl/Makefile b/tools/xl/Makefile
index bdf67c8464..656b21c7da 100644
--- a/tools/xl/Makefile
+++ b/tools/xl/Makefile
@@ -45,11
Since commit 6b85e427098cce1a6d386b3bae2f0c7ce86e47f7 'xen-cpuid -p' shows the
cpuid policies. I think these policies define what a domU will get to see when
cpuid() is invoked, or when MSRs are accessed.
Unfortunately this commit shows only the raw hex values, which makes it
difficult to
While reviewing changed behavior in 'xen-cpuid -d' output between Xen 4.8 and
4.9 I found commit 20e92c97f904aa460e2223c30dcad36c234496b6 ("x86/cpuid: Only
recalculate the shared feature bits once").
I wonder what the mentioned "cross-vendor case" in the comment, which was
removed from
If the bitmap is used to represent domU pages, the amount of memory is
limited to 8TB due to the 32bit value. Adjust the code to use 64bit
values as input. All callers already use some form of 64bit as input,
so no further adjustment is required.
Signed-off-by: Olaf Hering
---
tools/libs/ctrl
With commit 68a8aa5d72 the build randomly fails. Up to commit c7e3021a71 no
errors (like this) are seen. For some reason nothing below tools/ was touched
in this range, so the bug may already exist for a while.
attempt on host#1:
[ 81s] ln: failed to create symbolic link
Am Tue, 22 Sep 2020 15:51:00 +0200
schrieb Jürgen Groß :
> Is this really a normal upstream build, or do you have any additional
> patches applied?
Nothing relevant.
https://github.com/olafhering/xen/compare/olafhering:olh-base-staging...olh-fixes-staging
Maybe the build VMs have filesystem
The caller of writev_exact should be notified about malloc errors
when dealing with partial writes.
Signed-off-by: Olaf Hering
---
I think this is a backport candidate...
tools/libs/ctrl/xc_private.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/libs/ctrl/xc_private.c b/tools
The default value '/' for DESTDIR is unusual, but does probably not hurt.
Fixes commit f2b40dababedcd8355bf3e85d00baf17f9827131
Fixes commit 8e986e5a61efeca92b9b268e77957d45d8316ee4
Signed-off-by: Olaf Hering
---
INSTALL | 7 ---
1 file changed, 7 deletions(-)
diff --git a/INSTALL b
On Wed, Sep 16, David I wrote:
> So, how did the debian package was compiled ? is this the same source code
> with
> different options ?
Xen 4.11 is from 2018. Use also a compiler from that year.
Using this years compiler will lead to errors...
Olaf
signature.asc
Description: PGP signature
Use a temporay file, and move it in place once done.
The same pattern exists already for other dependencies.
Signed-off-by: Olaf Hering
---
tools/libacpi/Makefile | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/libacpi/Makefile b/tools/libacpi/Makefile
index
Am Tue, 27 Oct 2020 23:18:47 +
schrieb Andrew Cooper :
> I suspect we probably want an is_known_page_type() predicate on the
> source side to sanity check data from Xen, and on the destination side
> in handle_page_data() to sanity check data in the stream, and we
> probably want a
Am Wed, 28 Oct 2020 10:39:55 +
schrieb Andrew Cooper :
> I would however recommend against the name is_data_page_type() because
> then the predicate is ambiguous with "== NOTAB".
Why is it ambiguous? It is not obvious to me.
page_type_has_stream_data() is certainly fine as a name.
Olaf
Introduce a helper which decides if a given pfn type has data
for the migration stream.
No change in behavior intended.
Signed-off-by: Olaf Hering
---
tools/libs/guest/xg_sr_common.h | 17
tools/libs/guest/xg_sr_restore.c | 34 +---
tools/libs
Users of xc_get_pfn_type_batch may want to sanity check the data
returned by Xen. Add a simple helper for this purpose.
Signed-off-by: Olaf Hering
---
tools/libs/ctrl/xc_private.h | 33 +
1 file changed, 33 insertions(+)
diff --git a/tools/libs/ctrl/xc_private.h
Verify pfn type on sending side, also verify incoming batch of pfns.
Signed-off-by: Olaf Hering
---
tools/libs/guest/xg_sr_restore.c | 3 +--
tools/libs/guest/xg_sr_save.c| 6 ++
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/tools/libs/guest/xg_sr_restore.c b/tools/libs
Read a batch of iovec's.
In the common case of short reads, finish individual iov's with read_exact.
Signed-off-by: Olaf Hering
---
Users will follow, next month probably.
tools/libs/ctrl/xc_private.c | 54 +++-
tools/libs/ctrl/xc_private.h | 1 +
2 files
Andrew,
with commit 93c2ff78adcadbe0f8bda57eeb30b1414c966324 a new function
process_page_data was added. While filling the mfns array for
xenforeignmemory_map, the individual pfn types[] are checked in a different way
than the checking of the result of the mapping attempt.
Is there a special
Am Tue, 27 Oct 2020 11:16:04 +0100
schrieb Jan Beulich :
> This pattern is used when a rule consists of multiple commands
> having their output appended to one another's.
My understanding is: a rule is satisfied as soon as the file exists. In this
case once the invoked shell opens the file for
Am Tue, 27 Oct 2020 11:25:17 +0100
schrieb Jan Beulich :
> In this context it then is relevant in which context you see the failure -
> firmware/hvmloader/ or libs/light/ ?
I do not have the log anymore to check this detail.
Olaf
pgpnVV_Iyo1_o.pgp
Description: Digitale Signatur von OpenPGP
Am Tue, 27 Oct 2020 11:38:04 +0100
schrieb Jan Beulich :
> I guess I'll make a patch then.
Thanks. I briefly looked at the code and it is not obvious how it would need to
look like.
Olaf
pgphFNbYHfwgk.pgp
Description: Digitale Signatur von OpenPGP
Every once in a while build.c fails to compile because ssdt_s3.h does not
exist. The 'sed' command which creates the file appears a few lines down in the
build log.
I'm not familiar with make. I wonder if "build.o" should depend on "$(H_SRC)"
instead of the expanded list of generated headers.
On Wed, Oct 23, Ian Jackson wrote:
> 0x040700 was introduced in 304400459ef0 (aka 4.7.0-rc1~481)
> 0x040800 was introduced in 57f8b13c7240 (aka 4.8.0-rc1~437)
> Anyway, in the meantime, we should fix it. Backporting this is
> probably a good idea: it won't change the behaviour for existing
>
Am Fri, 31 Jul 2020 13:04:35 +0100
schrieb Andrew Cooper :
> And in particular, probably missing from libxl_cpuid.c, which I was
> meaning to check when I've got a free moment.
Will a ever domU see this flag? I just spotted the <29> when comparing
'xen-cpuid' output between recent Xen releases.
Rename 'vai' to 'via'.
Signed-off-by: Olaf Hering
---
xen/arch/x86/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig
index 4a2ec87ff5..a636a4bb1e 100644
--- a/xen/arch/x86/Kconfig
+++ b/xen/arch/x86/Kconfig
@@ -113,7 +113,7
On Tue, Jun 30, Michael Young wrote:
> I get the following errors when trying to build xen-4.14.0-rc4
This happens to work for me.
Olaf
---
tools/debugger/kdd/kdd.c | 8
1 file changed, 3 insertions(+), 3 deletions(-)
--- a/tools/debugger/kdd/kdd.c
+++ b/tools/debugger/kdd/kdd.c
@@
Am Fri, 3 Jul 2020 14:23:14 +0100
schrieb Paul Durrant :
> That doesn't look quite right.
That might be true. I do not debug windows, and it makes gcc happy...
Olaf
pgp2PK2BM9w6V.pgp
Description: Digitale Signatur von OpenPGP
-4.14.20200616T103126.3625b04991/non-dbg/stubdom/vtpmmgr/vtpmmgr.a(vtpmmgr.o):(.bss+0x0):
first defined here
Signed-off-by: Olaf Hering
---
stubdom/vtpmmgr/vtpmmgr.c | 8 +++-
stubdom/vtpmmgr/vtpmmgr.h | 9 -
2 files changed, 3 insertions(+), 14 deletions(-)
diff --git a/stubdom/vtpmmgr
Code compiled with gcc10 will not link properly due to multiple definition of
the same function.
Signed-off-by: Olaf Hering
---
stubdom/Makefile | 1 +
stubdom/vtpm_extern.patch | 48 +++
2 files changed, 49 insertions(+)
create mode 100644
On Fri, Jun 12, Ian Jackson wrote:
> These files are in tree so that people can build (including from git)
> without needing recent autotools.
Do you know those people who can not possibly install the required (now 8year
old) autoconf version?
Olaf
signature.asc
Description: PGP signature
Am Mon, 8 Jun 2020 09:28:54 +0200
schrieb Olaf Hering :
> off-by-one error in libxl__prepare_sockaddr_un
There is none, I had read the code backwards...
Olaf
pgpFP2LeUeAH4.pgp
Description: Digitale Signatur von OpenPGP
, __bos (__dest));
| ^~
cc1: all warnings being treated as errors
Signed-off-by: Olaf Hering
---
gcc may not detect the off-by-one error in libxl__prepare_sockaddr_un, fix the
strncpy usage anyway.
tools/libvchan/vchan
Am Mon, 8 Jun 2020 08:43:50 -0400
schrieb Jason Andryuk :
> I added a length check in this patch:
gcc will not recognize such runtime checks and will (most likely) complain
about the strncpy usage anyway, just as it does now in
libxl__prepare_sockaddr_un. While the usage in
Am Tue, 9 Jun 2020 14:26:46 +0100
schrieb Ian Jackson :
> +uint8_t payload[];
This compiles, but will access memory behind the union{};, which is most likely
not what the intention is.
Olaf
pgpxOU96iXev2.pgp
Description: Digitale Signatur von OpenPGP
Am Tue, 9 Jun 2020 13:15:49 +0100
schrieb Tim Deegan :
> Olaf, can you try dropping the 'payload' field from the header and replacing
> the payload[0] in pkt with payload[] ?
In file included from kdd.c:53:
kdd.h:325:17: error: flexible array member in union
325 | uint8_t payload[];
Am Tue, 9 Jun 2020 14:00:31 +0100
schrieb Ian Jackson :
> Why do you not use strcpy here ?
Either variant of 'cpy' will work in this context. I decided to use memcpy for
no specific reason.
Olaf
pgpdJBOoXbiGd.pgp
Description: Digitale Signatur von OpenPGP
Am Tue, 9 Jun 2020 08:33:12 -0400
schrieb Jason Andryuk :
> What version of gcc are you using? I was using 9.x and it didn't warn from
> what I can remember.
This is gcc10 from current Tumbleweed. For libxl strcpy will certainly work
because the length check is done prior the copying of data.
'
specified bound 108 equals destination size [-Werror=stringop-truncation]
106 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
| ^~
cc1: all warnings being treated as errors
Signed-off-by: Olaf
d[0];
| ^~~
cc1: all warnings being treated as errors
Signed-off-by: Olaf Hering
---
tools/debugger/kdd/kdd.c | 10 +-
tools/debugger/kdd/kdd.h | 3 +--
2 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/tools/debugger/kdd/kdd.c b/tools/debugger/
Am Tue, 9 Jun 2020 12:35:51 -0400
schrieb Rich Persaud :
> Is there any reason not to take a patch that builds libvchan with -Werror?
The per-subdirectory settings of -Werror should probably become a global
-Werror. Someone has to step up and explore that path.
Bonus points if -Werror could be
Am Wed, 10 Jun 2020 20:16:57 +0100
schrieb Tim Deegan :
> How tedious.
Indeed. This compiles for me as well:
--- orig/kdd.h 2020-06-08 17:40:05.0 +
+++ kdd.h 2020-06-11 19:00:44.234364040 +
@@ -68,7 +68,6 @@
uint16_t len; /* Payload length, excl. header and
On Mon, Feb 03, Jürgen Groß wrote:
> On 31.01.20 16:57, Wei Liu wrote:
> > On Tue, Jan 21, 2020 at 09:43:26AM +0100, Juergen Gross wrote:
> > > +Requires.private: xentoolcore,xentoollog,xencall
> > Need to list libz here?
> Probably, yes.
See "rpm -qf --provides /usr/include/zlib.h" for the
Am Tue, 9 Jun 2020 09:55:52 +0100
schrieb Paul Durrant :
> Is it not sufficient to just change the declaration of payload in kdd_pkt
> from [0] to []?
AFAIR this lead to compile errors.
Olaf
pgpeRRQw92FvJ.pgp
Description: Digitale Signatur von OpenPGP
Am Tue, 9 Jun 2020 10:04:30 +0100
schrieb Paul Durrant :
> OOI which compiler (might be worth mentioning in the commit comment too, for
> reference)? I'm not seeing a problem.
This is from gcc10. I think the build automation for Tumbleweed will show this
error, unless the Tumbleweed image is
Translate <29> into a feature string.
Signed-off-by: Olaf Hering
---
not compile nor runtime tested.
tools/misc/xen-cpuid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/misc/xen-cpuid.c b/tools/misc/xen-cpuid.c
index ac3548dcfe..2446941a47 100644
--- a/tool
301 - 400 of 903 matches
Mail list logo
