Re: [RFC PATCH v1 17/25] hw/xen: Build PV backend drivers for CONFIG_XEN_BUS

2023-03-07 Thread Paul Durrant
| 2 +- hw/block/meson.build | 2 +- hw/char/meson.build| 2 +- hw/display/meson.build | 2 +- hw/usb/meson.build | 2 +- hw/xen/meson.build | 5 - 7 files changed, 10 insertions(+), 7 deletions(-) Reviewed-by: Paul Durrant

Re: [RFC PATCH v1 16/25] hw/xen: Rename xen_common.h to xen_native.h

2023-03-07 Thread Paul Durrant
xen/xen_pvdev.h| 3 ++- 17 files changed, 47 insertions(+), 32 deletions(-) rename include/hw/xen/{xen_common.h => xen_native.h} (98%) Reviewed-by: Paul Durrant

Re: [RFC PATCH v1 13/25] hw/xen: Add xenstore operations to allow redirection to internal emulation

2023-03-07 Thread Paul Durrant
On 07/03/2023 14:52, David Woodhouse wrote: On Tue, 2023-03-07 at 14:44 +, Paul Durrant wrote: On 02/03/2023 15:34, David Woodhouse wrote: From: Paul Durrant Signed-off-by: Paul Durrant Signed-off-by: David Woodhouse --- Reviewed-by: Paul Durrant You're reviewing your own code

Re: [RFC PATCH v1 12/25] hw/xen: Add foreignmem operations to allow redirection to internal emulation

2023-03-07 Thread Paul Durrant
On 07/03/2023 14:48, David Woodhouse wrote: On Tue, 2023-03-07 at 14:40 +, Paul Durrant wrote: - -#define xenforeignmemory_unmap(h, p, s) munmap(p, s * XC_PAGE_SIZE) - Actually, probably best 'static inline' that, or at least put brackets round the 'p' and 's' for safety. That's

Re: [RFC PATCH v1 15/25] hw/xen: Use XEN_PAGE_SIZE in PV backend drivers

2023-03-07 Thread Paul Durrant
/block/dataplane/xen-block.c | 8 hw/display/xenfb.c | 12 ++-- hw/net/xen_nic.c | 12 ++-- hw/usb/xen-usb.c | 8 4 files changed, 20 insertions(+), 20 deletions(-) Reviewed-by: Paul Durrant

Re: [RFC PATCH v1 14/25] hw/xen: Move xenstore_store_pv_console_info to xen_console.c

2023-03-07 Thread Paul Durrant
at it. Signed-off-by: David Woodhouse --- accel/xen/xen-all.c | 61 --- hw/char/xen_console.c | 45 +-- include/hw/xen/xen.h | 2 -- 3 files changed, 43 insertions(+), 65 deletions(-) Reviewed-by: Paul Durrant

Re: [RFC PATCH v1 13/25] hw/xen: Add xenstore operations to allow redirection to internal emulation

2023-03-07 Thread Paul Durrant
On 02/03/2023 15:34, David Woodhouse wrote: From: Paul Durrant Signed-off-by: Paul Durrant Signed-off-by: David Woodhouse --- accel/xen/xen-all.c | 11 +- hw/char/xen_console.c | 2 +- hw/i386/kvm/xen_xenstore.c | 3 - hw/i386/kvm

Re: [RFC PATCH v1 12/25] hw/xen: Add foreignmem operations to allow redirection to internal emulation

2023-03-07 Thread Paul Durrant
On 02/03/2023 15:34, David Woodhouse wrote: From: David Woodhouse Signed-off-by: David Woodhouse Signed-off-by: Paul Durrant --- hw/char/xen_console.c| 8 +++--- hw/display/xenfb.c | 20 +++--- hw/xen/xen-operations.c | 45

Re: [RFC PATCH v1 11/25] hw/xen: Pass grant ref to gnttab unmap operation

2023-03-07 Thread Paul Durrant
xen-bus.h| 2 +- include/hw/xen/xen-legacy-backend.h | 6 +++--- include/hw/xen/xen_backend_ops.h| 7 --- 11 files changed, 50 insertions(+), 26 deletions(-) Reviewed-by: Paul Durrant

Re: [RFC PATCH v1 10/25] hw/xen: Add gnttab operations to allow redirection to internal emulation

2023-03-07 Thread Paul Durrant
a XEN_GNTTAB_OP_FEATURE_MAP_MULTIPLE flag to indicate that the native Xen implementation *does* support multi-page maps, and a helper function to query it. Signed-off-by: David Woodhouse Signed-off-by: Paul Durrant [snip] @@ -65,7 +195,34 @@ struct evtchn_backend_ops libxenevtchn_backend_ops = { .pending

Re: [RFC PATCH v1 09/25] hw/xen: Add evtchn operations to allow redirection to internal emulation

2023-03-07 Thread Paul Durrant
support. Signed-off-by: David Woodhouse Signed-off-by: Paul Durrant --- hw/9pfs/xen-9p-backend.c| 24 +++--- hw/i386/xen/xen-hvm.c | 27 --- hw/xen/meson.build | 1 + hw/xen/xen-bus.c| 22 +++--- hw/xen/xen-legacy

Re: [RFC PATCH v1 08/25] hw/xen: Create initial XenStore nodes

2023-03-07 Thread Paul Durrant
On 02/03/2023 15:34, David Woodhouse wrote: From: Paul Durrant Signed-off-by: Paul Durrant Signed-off-by: David Woodhouse --- hw/i386/kvm/xen_xenstore.c | 70 ++ 1 file changed, 70 insertions(+) Reviewed-by: Paul Durrant

Re: [RFC PATCH v1 07/25] hw/xen: Implement core serialize/deserialize methods for xenstore_impl

2023-03-07 Thread Paul Durrant
On 02/03/2023 15:34, David Woodhouse wrote: From: David Woodhouse In fact I think we want to only serialize the contents of the domain's path in /local/domain/${domid} and leave the rest to be recreated? Will defer to Paul for that. Yes. Assuming backends have properly implemented

Re: [RFC PATCH v1 06/25] hw/xen: Implement XenStore permissions

2023-03-07 Thread Paul Durrant
On 02/03/2023 15:34, David Woodhouse wrote: From: Paul Durrant Store perms as a GList of strings, check permissions. Signed-off-by: Paul Durrant Signed-off-by: David Woodhouse --- hw/i386/kvm/xen_xenstore.c | 2 +- hw/i386/kvm/xenstore_impl.c | 259

Re: [RFC PATCH v1 05/25] hw/xen: Watches on XenStore transactions

2023-03-07 Thread Paul Durrant
. Signed-off-by: David Woodhouse --- hw/i386/kvm/xenstore_impl.c | 151 ++- tests/unit/test-xs-node.c | 231 +++- 2 files changed, 380 insertions(+), 2 deletions(-) Reviewed-by: Paul Durrant ... with a couple of nits in comments called out

Re: [RFC PATCH v1 04/25] hw/xen: Implement XenStore transactions

2023-03-07 Thread Paul Durrant
-on commit. Signed-off-by: David Woodhouse --- hw/i386/kvm/xenstore_impl.c | 150 ++-- tests/unit/test-xs-node.c | 118 2 files changed, 262 insertions(+), 6 deletions(-) Reviewed-by: Paul Durrant

Re: [RFC PATCH v1 03/25] hw/xen: Implement XenStore watches

2023-03-07 Thread Paul Durrant
anged, 323 insertions(+), 15 deletions(-) Reviewed-by: Paul Durrant ... with one suggestion... [snip] +/* Check for duplicates */ +w = g_hash_table_lookup(s->watches, abspath); +while (w) { +if (!g_strcmp0(token, w->token) && opaque == w->cb_opaque &&

Re: [RFC PATCH v1 02/25] hw/xen: Add basic XenStore tree walk and write/read/directory support

2023-03-07 Thread Paul Durrant
... Reviewed-by: Paul Durrant

Re: [RFC PATCH v1 01/25] hw/xen: Add xenstore wire implementation and implementation stubs

2023-03-07 Thread Paul Durrant
/xenstore_impl.c create mode 100644 hw/i386/kvm/xenstore_impl.h Reviewed-by: Paul Durrant

Re: [PATCH v6 4/4] hw: replace most qemu_bh_new calls with qemu_bh_new_guarded

2023-03-02 Thread Paul Durrant
kin Xen parts... Reviewed-by: Paul Durrant

Re: memory access atomicity during HVM insn emulation on x86

2023-03-02 Thread Paul Durrant
On 02/03/2023 08:35, Jan Beulich wrote: Hello, in (I think) Intel SDM version 076 a new guarantee of atomicity of certain aligned 16-byte accesses appeared. While initially I thought this would be another special case we need to invent a solution for (it still is, in certain cases, as per

Re: Ping: [PATCH 1/6] x86/Hyper-V: use standard C types in hyperv-tlfs.h

2023-02-22 Thread Paul Durrant
On 21/02/2023 13:43, Jan Beulich wrote: On 09.02.2023 11:38, Jan Beulich wrote: This is the only file left with a use of an __s type coming from Linux. Since the file has been using an apparently random mix of all three classes of fixed-width types (__{s,u}, {s,u}, and {,u}int_t), consolidate

Re: [PATCH] accel/xen: Remove dead code

2023-02-20 Thread Paul Durrant
On 15/02/2023 15:34, Philippe Mathieu-Daudé wrote: Unused since introduction in commit 04b0de0ee8 ("xen: factor out common functions"). Signed-off-by: Philippe Mathieu-Daudé --- accel/xen/xen-all.c | 10 -- 1 file changed, 10 deletions(-) Acked-by: Paul Durrant

Re: [PATCH] hw/i386/xen: Remove unused 'hw/ide.h' include from header

2023-02-20 Thread Paul Durrant
/xen_platform.c +++ b/hw/i386/xen/xen_platform.c @@ -25,7 +25,6 @@ #include "qemu/osdep.h" #include "qapi/error.h" -#include "hw/ide.h" #include "hw/ide/pci.h" #include "hw/pci/pci.h" #include "hw/xen/xen_common.h" Acked-by: Paul Durrant

Re: [QEMU][PATCH v5 09/10] hw/arm: introduce xenpvh machine

2023-02-02 Thread Paul Durrant
On 01/02/2023 18:22, Vikram Garhwal wrote: Hi Paul, Thanks for reviewing this and other patches in series. Please see my reply below. On 2/1/23 12:30 AM, Paul Durrant wrote: On 31/01/2023 22:51, Vikram Garhwal wrote: Add a new machine xenpvh which creates a IOREQ server to register/connect

Re: [QEMU][PATCH v5 09/10] hw/arm: introduce xenpvh machine

2023-02-01 Thread Paul Durrant
On 31/01/2023 22:51, Vikram Garhwal wrote: Add a new machine xenpvh which creates a IOREQ server to register/connect with Xen Hypervisor. Is this really the right way? Is it not possible to do the Xen initialization (including ioreq server registration) off the back of the accelerator init

Re: [QEMU][PATCH v5 07/10] hw/xen/xen-hvm-common: Use g_new and error_report

2023-02-01 Thread Paul Durrant
On 31/01/2023 22:51, Vikram Garhwal wrote: Replace g_malloc with g_new and perror with error_report. Signed-off-by: Vikram Garhwal Reviewed-by: Stefano Stabellini --- hw/xen/xen-hvm-common.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) Reviewed-by: Paul Durrant

Re: [QEMU][PATCH v5 06/10] hw/xen/xen-hvm-common: skip ioreq creation on ioreq registration failure

2023-02-01 Thread Paul Durrant
-by: Paul Durrant

Re: [QEMU][PATCH v5 05/10] include/hw/xen/xen_common: return error from xen_create_ioreq_server

2023-02-01 Thread Paul Durrant
to the PV backends initialization. Signed-off-by: Stefano Stabellini Signed-off-by: Vikram Garhwal Reviewed-by: Stefano Stabellini --- include/hw/xen/xen_common.h | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) Reviewed-by: Paul Durrant

Re: [QEMU][PATCH v5 04/10] xen-hvm: reorganize xen-hvm and move common function to xen-hvm-common

2023-02-01 Thread Paul Durrant
100644 include/hw/i386/xen_arch_hvm.h create mode 100644 include/hw/xen/arch_hvm.h create mode 100644 include/hw/xen/xen-hvm-common.h Reviewed-by: Paul Durrant

Re: [QEMU][PATCH v5 01/10] hw/i386/xen/: move xen-mapcache.c to hw/xen/

2023-01-31 Thread Paul Durrant
10 insertions(+), 6 deletions(-) rename hw/{i386 => }/xen/xen-mapcache.c (100%) Reviewed-by: Paul Durrant

Re: [SeaBIOS PATCH] xen: require Xen info structure at 0x1000 to detect Xen

2023-01-26 Thread Paul Durrant
... Tested-by: Paul Durrant Signed-off-by: David Woodhouse --- src/fw/xen.c | 45 - 1 file changed, 32 insertions(+), 13 deletions(-) Also... Reviewed-by: Paul Durrant

[PATCH v7 2/2] KVM: x86/xen: update Xen CPUID Leaf 4 (tsc info) sub-leaves, if present

2023-01-06 Thread Paul Durrant
. The TSC frequency should also be set in sub-leaf 2. Signed-off-by: Paul Durrant --- Cc: Sean Christopherson Cc: Paolo Bonzini Cc: Juergen Gross Cc: Boris Ostrovsky Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: Dave Hansen Cc: "H. Peter Anvin" Cc: David Woodhouse

[PATCH v7 1/2] KVM: x86/cpuid: generalize kvm_update_kvm_cpuid_base() and also capture limit

2023-01-06 Thread Paul Durrant
-by: Paul Durrant --- Cc: Sean Christopherson Cc: Paolo Bonzini Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: Dave Hansen Cc: David Woodhouse v7: - Morph kvm_update_hypervisor_cpuid() into kvm_get_hypervisor_cpuid() - Place the definition of struct kvm_hypervisor_cpuid to avoid

[PATCH v7 0/2] KVM: x86/xen: update Xen CPUID Leaf 4

2023-01-06 Thread Paul Durrant
Patch #2 was the original patch. It has been expended to a series in v6. Paul Durrant (2): KVM: x86/cpuid: generalize kvm_update_kvm_cpuid_base() and also capture limit KVM: x86/xen: update Xen CPUID Leaf 4 (tsc info) sub-leaves, if present arch/x86/include/asm/kvm_host.h | 8

Re: [PATCH v2] ioreq_broadcast(): accept partial broadcast success

2022-12-06 Thread Paul Durrant
with better information. A lot of simplicity was added. --- Reviewed-by: Paul Durrant

Re: [PATCH net] xen/netback: don't call kfree_skb() under spin_lock_irqsave()

2022-12-05 Thread Paul Durrant
umber of packages") Signed-off-by: Yang Yingliang Reviewed-by: Paul Durrant

Re: [PATCH] ioreq_broadcast(): accept partial broadcast success

2022-11-30 Thread Paul Durrant
On 28/11/2022 12:26, Jan Beulich wrote: On 28.11.2022 12:06, Roger Pau Monné wrote: On Mon, Nov 28, 2022 at 09:21:47AM +0100, Jan Beulich wrote: On 26.11.2022 23:19, Julien Grall wrote: On 25/11/2022 14:15, Per Bilse wrote: This patch modifies ioreq_broadcast() to allow partial success.

Re: [PATCH] x86/Viridian: don't mark IRQ vectors as pending when vLAPIC is disabled

2022-11-21 Thread Paul Durrant
rs") Signed-off-by: Jan Beulich Reviewed-by: Paul Durrant

Re: [PATCH for-4.17 v2] hvm/apic: repurpose the reporting of the APIC assist options

2022-11-04 Thread Paul Durrant
nction logic at this point. --- Changes since v1: - Fix Viridian MSR tip conditions. Reviewed-by: Paul Durrant

Re: [PATCH for-4.17 2/2] hvm/apic: repurpose the reporting of the APIC assist options

2022-11-04 Thread Paul Durrant
On 04/11/2022 16:10, Roger Pau Monné wrote: On Fri, Nov 04, 2022 at 04:05:05PM +, Paul Durrant wrote: On 04/11/2022 16:01, Roger Pau Monné wrote: On Fri, Nov 04, 2022 at 03:55:54PM +, Paul Durrant wrote: On 04/11/2022 14:22, Roger Pau Monne wrote: The current reporting

Re: [PATCH for-4.17 2/2] hvm/apic: repurpose the reporting of the APIC assist options

2022-11-04 Thread Paul Durrant
On 04/11/2022 16:01, Roger Pau Monné wrote: On Fri, Nov 04, 2022 at 03:55:54PM +, Paul Durrant wrote: On 04/11/2022 14:22, Roger Pau Monne wrote: The current reporting of the hardware assisted APIC options is done by checking "virtualize APIC accesses" which is not ve

Re: [PATCH for-4.17 2/2] hvm/apic: repurpose the reporting of the APIC assist options

2022-11-04 Thread Paul Durrant
On 04/11/2022 14:22, Roger Pau Monne wrote: The current reporting of the hardware assisted APIC options is done by checking "virtualize APIC accesses" which is not very helpful, as that feature doesn't avoid a vmexit, instead it does provide some help in order to detect APIC MMIO accesses in

Re: [PATCH for-4.17 1/2] viridian: suggest MSR APIC accesses if MSR accesses are accelerated

2022-11-04 Thread Paul Durrant
On 04/11/2022 14:22, Roger Pau Monne wrote: The "APIC register virtualization" Intel hardware feature applies to both MMIO or MSR APIC accesses depending on whether "virtualize x2APIC mode" is also available. As such also suggest MSR APIC accesses if both "APIC register virtualization" and

Re: [PATCH v1 09/12] accel/xen/xen-all: export xenstore_record_dm_state

2022-10-19 Thread Paul Durrant
On 15/10/2022 06:07, Vikram Garhwal wrote: xenstore_record_dm_state() will also be used in aarch64 xenpv machine. Signed-off-by: Vikram Garhwal Signed-off-by: Stefano Stabellini Reviewed-by: Paul Durrant

Re: [PATCH v1 06/12] xen-hvm: move common functions to hw/xen/xen-hvm-common.c

2022-10-19 Thread Paul Durrant
On 15/10/2022 06:07, Vikram Garhwal wrote: [snip] +qemu_add_vm_change_state_handler(xen_hvm_change_state_handler, state); + +state->memory_listener = xen_memory_listener; +memory_listener_register(>memory_listener, _space_memory); + +state->io_listener = xen_io_listener; +

Re: [PATCH v1 05/12] hw/i386/xen/xen-hvm: create arch_handle_ioreq and arch_xen_set_memory

2022-10-19 Thread Paul Durrant
-by: Vikram Garhwal Reviewed-by: Paul Durrant

Re: [PATCH v1 04/12] hw/i386/xen/xen-hvm: move x86-specific fields out of XenIOState

2022-10-19 Thread Paul Durrant
the ones related to dirty logging. Updated XenIOState can be used for both aarch64 and x86. Also, remove free_phys_offset as it was unused. Signed-off-by: Stefano Stabellini Signed-off-by: Vikram Garhwal Reviewed-by: Paul Durrant

Re: [PATCH v1 04/12] hw/i386/xen/xen-hvm: move x86-specific fields out of XenIOState

2022-10-19 Thread Paul Durrant
the ones related to dirty logging. Updated XenIOState can be used for both aarch64 and x86. Also, remove free_phys_offset as it was unused. Signed-off-by: Stefano Stabellini Signed-off-by: Vikram Garhwal Reviewed-by: Paul Durrant

Re: [PATCH v1 03/12] hw/i386/xen: rearrange xen_hvm_init_pc

2022-10-19 Thread Paul Durrant
. This is done to keep the common ioreq functions in one place which will be moved to new function in next patch in order to make it common to both x86 and aarch64 machines. Signed-off-by: Vikram Garhwal Signed-off-by: Stefano Stabellini Reviewed-by: Paul Durrant

Re: [PATCH v1 02/12] hw/i386/xen/: move xen-mapcache.c to hw/xen/

2022-10-19 Thread Paul Durrant
On 15/10/2022 06:07, Vikram Garhwal wrote: xen-mapcache.c contains common functions which can be used for enabling Xen on aarch64 with IOREQ handling. Moving it out from hw/i386/xen to hw/xen to make it accessible for both aarch64 and x86. Signed-off-by: Vikram Garhwal Signed-off-by: Stefano

Re: [PATCH v1 01/12] hw/xen: Correct build config for xen_pt_stub

2022-10-19 Thread Paul Durrant
On 15/10/2022 06:07, Vikram Garhwal wrote: Build fails when have_xen_pci_passthrough is disabled. This is because of incorrect build configuration for xen_pt_stub.c. Signed-off-by: Stefano Stabellini Signed-off-by: Vikram Garhwal Reviewed-by: Paul Durrant

Re: [PATCH] hw/xen: set pci Atomic Ops requests for passthrough device

2022-09-23 Thread Paul Durrant
On 21/09/2022 02:19, Ji, Ruili wrote: [AMD Official Use Only - General] Hi Paul and AFAIK: ^^^ you mean Anthony :-) Thanks for your help. When could we see this patch on the master branch?  Our project urgently needs this solution. Anthony? Ping? Paul

Re: [PATCH] hw/xen: set pci Atomic Ops requests for passthrough device

2022-09-16 Thread Paul Durrant
On 14/09/2022 03:07, Ji, Ruili wrote: [AMD Official Use Only - General] Hi Paul, Thank you! But how could we merge this patch ? AFAIK Anthony (anthony.per...@citrix.com) still deals with this. Cheers, Paul

Re: [PATCH] hw/xen: set pci Atomic Ops requests for passthrough device

2022-09-14 Thread Paul Durrant
On 13/09/2022 04:02, Ji, Ruili wrote: [AMD Official Use Only - General] Hi Paul, Could you help to review this patch? LGTM. You can add my R-b to it. Paul Thanks *From:* Ji, Ruili *Sent:* 2022年9月7日 9:04 *To:* 'Paul Durrant' ; 'qemu-de...@nongnu.org' *Cc:* Liu, Aaron ; 'xen-devel

Re: [RFC PATCH v1] xen/docs: Document acquire resource interface

2022-08-30 Thread Paul Durrant
On 29/08/2022 10:03, Matias Ezequiel Vara Larsen wrote: This commit creates a new doc to document the acquire resource interface. This is a reference document. Signed-off-by: Matias Ezequiel Vara Larsen --- Changes in v1: - correct documentation about how mfns are allocated - correct

Re: Ping²: [PATCH] xen-netback: correct success/error reporting for the SKB-with-fraglist case

2021-09-16 Thread Paul Durrant
On 16/09/2021 16:45, Jan Beulich wrote: On 15.07.2021 10:58, Jan Beulich wrote: On 20.05.2021 13:46, Jan Beulich wrote: On 25.02.2021 17:23, Paul Durrant wrote: On 25/02/2021 14:00, Jan Beulich wrote: On 25.02.2021 13:11, Paul Durrant wrote: On 25/02/2021 07:33, Jan Beulich wrote

Re: [PATCH v3 30/30] accel: Add missing AccelOpsClass::has_work() and drop SysemuCPUOps one

2021-09-06 Thread Paul Durrant
::has_work, remove it along with the assertion in cpu_has_work(). Signed-off-by: Philippe Mathieu-Daudé Xen parts... Acked-by: Paul Durrant

Re: [PATCH] AMD/IOMMU: don't leave page table mapped when unmapping ...

2021-08-19 Thread Paul Durrant
ff-by: Jan Beulich Reviewed-by: Paul Durrant

Re: [PATCH] AMD/IOMMU: don't increase perms when splitting superpage

2021-08-19 Thread Paul Durrant
On 19/08/2021 09:04, Jan Beulich wrote: The old (super)page's permissions ought to be propagated, rather than blindly allowing both reads and writes. Signed-off-by: Jan Beulich Reviewed-by: Paul Durrant

Re: [PATCH] VT-d: fix caching mode IOTLB flushing

2021-08-19 Thread Paul Durrant
domain ID (from the [present] context entry) gets used. See sub-section "IOTLB" of section "Address Translation Caches" in the VT-d spec. Signed-off-by: Jan Beulich Reviewed-by: Paul Durrant

Re: meaning and use of IOMMU_FLUSHF_added

2021-08-18 Thread Paul Durrant
On 18/08/2021 13:09, Jan Beulich wrote: On 18.08.2021 12:51, Jan Beulich wrote: Paul, back at the time I did already question your intended meaning of this flag. I notice that there's presently no consumer of it being set (apart from yielding non-zero flush_flags). I'm afraid this model makes

Re: IOMMU page table freeing

2021-08-16 Thread Paul Durrant
On 10/08/2021 14:37, Jan Beulich wrote: Hello, while I don't expect this case to occur often in practice, for superpage support we will need to be able to correctly free a page table (hierarchy) after replacing its mapping range by a superpage. Following P2M by carrying out an immediate iotlb

Re: your change "iommu: make map and unmap take a page count, similar to flush"

2021-07-21 Thread Paul Durrant
On 21/07/2021 16:58, Jan Beulich wrote: Paul, the description of this says "At the moment iommu_map() and iommu_unmap() take a page order rather than a count, whereas iommu_iotlb_flush() takes a page count rather than an order. This patch makes them consistent with each other, opting for a

Re: [PATCH 2/2] CHANGELOG: record changed PCI device quarantining default

2021-07-12 Thread Paul Durrant
On 07/07/2021 14:22, Jan Beulich wrote: This amends commit 980d6acf1517 ("IOMMU: make DMA containment of quarantined devices optional"). Signed-off-by: Jan Beulich Reviewed-by: Paul Durrant --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,13 @@ The format is based on [Keep a

Re: [PATCH 1/2] IOMMU: correct parsing of "quarantine=scratch-page"

2021-07-12 Thread Paul Durrant
Cooper Signed-off-by: Jan Beulich Reviewed-by: Paul Durrant --- a/xen/drivers/passthrough/iommu.c +++ b/xen/drivers/passthrough/iommu.c @@ -82,7 +82,7 @@ static int __init parse_iommu_param(cons #ifdef CONFIG_HAS_PCI else if ( (val = parse_boolean("qu

Re: [PATCH v5] IOMMU: make DMA containment of quarantined devices optional

2021-07-06 Thread Paul Durrant
's wanted is a "return", eliminate the "out" label at the same time. Take the opportunity and also limit the control to builds supporting PCI. Signed-off-by: Jan Beulich Reviewed-by: Paul Durrant

Re: [PATCH 16/16] x86/P2M: the majority for struct p2m_domain's fields are HVM-only

2021-07-05 Thread Paul Durrant
On 05/07/2021 17:15, Jan Beulich wrote: ..., as are the majority of the locks involved. Conditionalize things accordingly. Also adjust the ioreq field's indentation at this occasion. Signed-off-by: Jan Beulich Reviewed-by: Paul Durrant

Re: [PATCH 02/16] x86/P2M: introduce p2m_{add,remove}_page()

2021-07-05 Thread Paul Durrant
... Reviewed-by: Paul Durrant

Re: [XEN PATCH v6 18/31] xen: move include/asm-* to include/arch-*/asm

2021-07-01 Thread Paul Durrant
On 01/07/2021 15:09, Anthony PERARD wrote: This avoid the need to create the symbolic link "include/asm". Signed-off-by: Anthony PERARD Acked-by: Paul Durrant

Re: [PATCH v2 2/2] AMD/IOMMU: re-work locking around sending of commands

2021-06-25 Thread Paul Durrant
the lock. Contain all command sending related locking to the latter function. Signed-off-by: Jan Beulich Reviewed-by: Paul Durrant

Re: [PATCH 9/9] IOMMU/PCI: don't let domain cleanup continue when device de-assignment failed

2021-06-24 Thread Paul Durrant
o idea why it was used here in the first place, instead of the cheaper list iteration. Signed-off-by: Jan Beulich Reviewed-by: Paul Durrant --- A first step beyond this could be to have the backing functions of deassign_device() allow the caller to tell whether the failure was from removing the d

Re: [PATCH] xen-netback: Check for hotplug-status existence before watching

2021-05-18 Thread Paul Durrant
On 17/05/2021 22:43, Marek Marczykowski-Górecki wrote: On Tue, May 11, 2021 at 12:46:38PM +, Durrant, Paul wrote: -Original Message- From: Marek Marczykowski-Górecki Sent: 11 May 2021 11:45 To: Durrant, Paul Cc: Michael Brown ; p...@xen.org; xen-devel@lists.xenproject.org;

Re: [PATCH RFC 2/2] xen/kexec: Reserve KEXEC_TYPE_LIVEUPDATE and KEXEC_RANGE_MA_LIVEUPDATE

2021-05-07 Thread Paul Durrant
: * KEXEC_TYPE_LIVEUPDATE: New operation to request Live Update * KEXEC_MA_RANGE_LIVEUPDATE: New range to query the Live Update area below Xen Signed-off-by: Julien Grall Reviewed-by: Paul Durrant --- xen/include/public/kexec.h | 13 ++--- 1 file changed, 10 insertions(+), 3

Re: [PATCH RFC 1/2] docs/design: Add a design document for Live Update

2021-05-06 Thread Paul Durrant
On 06/05/2021 11:42, Julien Grall wrote: From: Julien Grall Looks good in general... just a few comments below... Administrators often require updating the Xen hypervisor to address security vulnerabilities, introduce new features, or fix software defects. Currently, we offer the following

Re: [PATCH] xen-block: Use specific blockdev driver

2021-05-05 Thread Paul Durrant
verything doesn't work anymore, we need to use the "host_device" driver when the disk image is a block device and "file" driver when it is a regular file. Signed-off-by: Anthony PERARD Acked-by: Paul Durrant --- hw/block/xen-block.c | 14 +- 1 file changed

Re: [PATCH] xen: Free xenforeignmemory_resource at exit

2021-05-05 Thread Paul Durrant
On 30/04/2021 17:37, Anthony PERARD wrote: From: Anthony PERARD Because Coverity complains about it and this is one leak that Valgrind reports. Signed-off-by: Anthony PERARD Acked-by: Paul Durrant --- hw/i386/xen/xen-hvm.c | 9 ++--- include/hw/xen/xen_common.h | 6

Re: [RFC PATCH] iommu: make no-quarantine mean no-quarantine

2021-04-28 Thread Paul Durrant
On 28/04/2021 09:49, Jan Beulich wrote: On 28.04.2021 09:19, Paul Durrant wrote: On 28/04/2021 07:15, Jan Beulich wrote: Following the extension to the command line option I'm putting in place in "IOMMU: make DMA containment of quarantined devices optional" (which I still need to

Re: [RFC PATCH] iommu: make no-quarantine mean no-quarantine

2021-04-28 Thread Paul Durrant
On 28/04/2021 07:15, Jan Beulich wrote: On 28.04.2021 00:00, Scott Davis wrote: On 4/27/21, 2:56 AM, Jan Beulich wrote: On 26.04.2021 19:25, Scott Davis wrote: This patch modifies Xen's behavior when making devices assignable while the iommu=no-quarantine command line option is in effect.

Re: [PATCH v3 19/22] x86emul: support TILELOADD{,T1} and TILESTORE

2021-04-26 Thread Paul Durrant
On 22/04/2021 16:11, Jan Beulich wrote: On 22.04.2021 17:06, Jan Beulich wrote: On 22.04.2021 16:55, Jan Beulich wrote: +do { +/* Limit rows to just as many to cover the next one to access. */ +cfg->start_row = i; +cfg->rows[modrm_reg] = i + 1; +

Re: Ping: [PATCH v3] x86/CPUID: shrink max_{,sub}leaf fields according to actual leaf contents

2021-04-22 Thread Paul Durrant
On 22/04/2021 12:38, Jan Beulich wrote: On 16.04.2021 15:16, Jan Beulich wrote: Zapping leaf data for out of range leaves is just one half of it: To avoid guests (bogusly or worse) inferring information from mere leaf presence, also shrink maximum indicators such that the respective trailing

Re: [PATCH] xen-mapcache: avoid a race on memory map while using MAP_FIXED

2021-04-20 Thread Paul Durrant
that it wouldn't make the replacement atomic for parallel accesses to the replaced region - those might still fail with SIGBUS due to xenforeignmemory_map not being atomic. So we're still not expecting those. Tested-by: Anthony PERARD Signed-off-by: Igor Druzhinin Reviewed-by: Paul Durrant --- hw/i386

Re: [PATCH] xen-netback: Check for hotplug-status existence before watching

2021-04-13 Thread Paul Durrant
behaviour that was previously assumed to exist. Signed-off-by: Michael Brown Reviewed-by: Paul Durrant --- drivers/net/xen-netback/xenbus.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c in

Re: xen-netback hotplug-status regression bug

2021-04-13 Thread Paul Durrant
On 13/04/2021 11:48, Michael Brown wrote: On 13/04/2021 08:12, Paul Durrant wrote: If the frontend subsequently disconnects and reconnects (e.g. transitions through Closed->Initialising->Connected) then: - Nothing recreates "hotplug-status" - When the frontend re-enters

Re: xen-netback hotplug-status regression bug

2021-04-13 Thread Paul Durrant
On 10/04/2021 19:25, Michael Brown wrote: Commit https://github.com/torvalds/linux/commit/1f25657 ("xen-netback: remove 'hotplug-status' once it has served its purpose") seems to have introduced a regression that prevents a vif frontend from transitioning more than once into Connected state.

Re: [PATCH for-4.15 2/7] CHANGELOG.md: xl PCI configuration doc, xenstore MTU entries

2021-04-01 Thread Paul Durrant
On 01/04/2021 14:38, George Dunlap wrote: Signed-off-by: George Dunlap --- CC: Paul Durrant CC: Ian Jackson CC: Wei Liu Reviewed-by: Paul Durrant --- CHANGELOG.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index f7ce6682b9

Re: [PATCH] x86/viridian: EOI MSR should always happen in affected vCPU context

2021-04-01 Thread Paul Durrant
. No functional change intended. Requested-by: Jan Beulich Signed-off-by: Roger Pau Monné Reviewed-by: Paul Durrant --- xen/arch/x86/hvm/viridian/synic.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/xen/arch/x86/hvm/viridian/synic.c b/xen/arch/x86/hvm

Re: [PATCH 2/6] CHANGELOG.md: Add named PCI devices

2021-03-26 Thread Paul Durrant
On 24/03/2021 16:44, George Dunlap wrote: Signed-off-by: George Dunlap --- CC: Ian Jackson CC: Paul Durrant Reviewed-by: Paul Durrant --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7f03e85bd7..8c89212f14 100644 --- a/CHANGELOG.md

Re: [PATCH for-4.15?] docs/misc: xenstored: Re-instate and tweak the documentation for XS_RESUME

2021-03-26 Thread Paul Durrant
the opportunity to update it as there is a user of the command. Fixes: 13dd372834a4 ("docs/designs: re-work the xenstore migration document...") Signed-off-by: Julien Grall --- Cc: raphn...@gmail.com Cc: jgr...@suse.com Cc: p...@xen.org Reviewed-by: Paul Durrant Ian, would you stil

Re: [PATCH] xen-block: Fix removal of backend instance via xenstore

2021-03-22 Thread Paul Durrant
with `xendev' with s/cann't/can't With those fixed... Reviewed-by: Paul Durrant + * xen_block_drive_destroy() below. + */ +drain_call_rcu(); + if (iothread) { xen_block_iothread_destroy(iothread, errp); if (*errp) {

Re: [net-next 2/2] xen-netback: add module parameter to disable dynamic multicast control

2021-03-11 Thread Paul Durrant
is enable. Signed-off-by: ChiaHao Hsu Reviewed-by: Paul Durrant

Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring

2021-03-11 Thread Paul Durrant
-off-by: ChiaHao Hsu Reviewed-by: Paul Durrant

Re: [PATCH for-4.15 v3] xen/dmop: Strip __XEN_TOOLS__ header guard from public ABI

2021-03-11 Thread Paul Durrant
private.h. Fix the dmop design doc to discuss both reasons behind the the ABI design. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich Release-Acked-by: Ian Jackson Reviewed-by: Paul Durrant --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Paul Durrant CC: Ian Jackson v3

Re: xen-blkfront: BUG_ON(info->nr_rings)

2021-03-11 Thread Paul Durrant
On 10/03/2021 14:58, Jason Andryuk wrote: Hi, I was running a loop of `xl block-attach ; xl block-detach` and I triggered a BUG in xen-blkfront, drivers/block/xen-blkfront.c:1917 This is BUG_ON(info->nr_rings) in negotiate_mq called by blkback_changed. I'm using Linux 5.4.103 and blktap3 on

Re: [PATCH 4.15 1/3] MAINTAINERS: Make myself the owner of the changelog

2021-03-09 Thread Paul Durrant
On 09/03/2021 14:50, Ian Jackson wrote: Signed-off-by: Ian Jackson Perhaps we need a release.mana...@xenproject.org alias that can be passed along. Anyway... Acked-by: Paul Durrant --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b

Re: [PATCH 1/2] xen-netback: add module parameter to disable ctrl-ring

2021-03-09 Thread Paul Durrant
On 09/03/2021 14:10, Hsu, Chiahao wrote: On 25.02.21, 13:29, "Hsu, Chiahao" wrote: In order to support live migration of guests between kernels that do and do not support 'feature-ctrl-ring', we add a module parameter that allows the feature to be disabled at run time,

Re: [PATCH] xen-netback: correct success/error reporting for the SKB-with-fraglist case

2021-02-25 Thread Paul Durrant
On 25/02/2021 14:00, Jan Beulich wrote: On 25.02.2021 13:11, Paul Durrant wrote: On 25/02/2021 07:33, Jan Beulich wrote: On 24.02.2021 17:39, Paul Durrant wrote: On 23/02/2021 16:29, Jan Beulich wrote: When re-entering the main loop of xenvif_tx_check_gop() a 2nd time, the special

Re: [PATCH] xen-netback: correct success/error reporting for the SKB-with-fraglist case

2021-02-25 Thread Paul Durrant
On 25/02/2021 07:33, Jan Beulich wrote: On 24.02.2021 17:39, Paul Durrant wrote: On 23/02/2021 16:29, Jan Beulich wrote: When re-entering the main loop of xenvif_tx_check_gop() a 2nd time, the special considerations for the head of the SKB no longer apply. Don't mistakenly report ERROR

Re: [PATCH] xen-netback: correct success/error reporting for the SKB-with-fraglist case

2021-02-24 Thread Paul Durrant
On 23/02/2021 16:29, Jan Beulich wrote: When re-entering the main loop of xenvif_tx_check_gop() a 2nd time, the special considerations for the head of the SKB no longer apply. Don't mistakenly report ERROR to the frontend for the first entry in the list, even if - from all I can tell - this

Re: [PATCH v2 09/11] hw/xenpv: Restrict Xen Para-virtualized machine to Xen accelerator

2021-02-19 Thread Paul Durrant
failed By restricting it to Xen, we display a clearer error message: $ qemu-system-x86_64 -M xenpv,accel=kvm qemu-system-x86_64: invalid accelerator 'kvm' for machine xenpv Signed-off-by: Philippe Mathieu-Daudé Acked-by: Paul Durrant

<    1   2   3   4   5   6   7   8   9   10   >