Re: [Xen-devel] [PATCH v2 2/2] xen: events: free irqs in error condition

On Tue, Feb 27, 2018 at 05:32:53PM +, Shah, Amit wrote: > > On Di, 2018-02-27 at 17:07 +, Roger Pau Monné wrote: > > On Tue, Feb 27, 2018 at 03:55:58PM +, Amit Shah wrote: > > > > > > In case of errors in irq setup for MSI, free up the allo

Re: [Xen-devel] [PATCH v3] build: remove shim related targets

On Wed, Feb 28, 2018 at 05:29:06AM -0700, Jan Beulich wrote: > >>> On 28.02.18 at 12:47, wrote: > > On Wed, Feb 28, 2018 at 04:02:53AM -0700, Jan Beulich wrote: > >> >>> On 21.02.18 at 13:22, wrote: > >> > --- a/tools/firmware/Makefile > >> > +++

Re: [Xen-devel] [PATCH RFC 3/3] xtf: add minimal HPET functionality test

ovements should add support for interrupt delivery, and > > testing all the available timers. > > > > Signed-off-by: Roger Pau Monné <roger@citrix.com> > > --- > > Cc: Andrew Cooper <andrew.coop...@citrix.com> > > --- > > arch/x86/inclu

Re: [Xen-devel] [PATCH v3] build: remove shim related targets

On Wed, Feb 28, 2018 at 06:25:23AM -0700, Jan Beulich wrote: > >>> On 28.02.18 at 14:02, wrote: > > On Wed, Feb 28, 2018 at 05:29:06AM -0700, Jan Beulich wrote: > >> >>> On 28.02.18 at 12:47, wrote: > >> > On Wed, Feb 28, 2018 at 04:02:53AM -0700, Jan

Re: [Xen-devel] pvh+vcpus startup issue

On Wed, Feb 28, 2018 at 01:34:31PM +1300, x...@randomwebstuff.com wrote: > > Regards, Peter > http://ri.mu Startups start here. Hosting. DNS. Offsite backups. > Monitoring. Email. > > On 27/02/18 12:42 AM, Juergen Gross wrote: > > On 22/02/18 21:38, x...@randomwebstuff.com wrote: > > > On

Re: [Xen-devel] [PATCH v3] build: remove shim related targets

On Wed, Feb 28, 2018 at 04:02:53AM -0700, Jan Beulich wrote: > >>> On 21.02.18 at 13:22, wrote: > > --- a/tools/firmware/Makefile > > +++ b/tools/firmware/Makefile > > @@ -8,6 +8,7 @@ endif > > # hvmloader is a 32-bit protected mode binary. > > TARGET :=

Re: [Xen-devel] [PATCH v2 1/2] firmware/shim: better filtering of dependency files during Xen tree setup

k, but would probably have been better from the beginning. > > Signed-off-by: Jan Beulich <jbeul...@suse.com> Reviewed-by: Roger Pau Monné <roger@citrix.com> Thanks, Roger. ___ Xen-devel mailing list Xen-devel@lists.xenproject.or

Re: [Xen-devel] [PATCH v2 2/2] firmware/shim: better filtering of intermediate files during Xen tree setup

On Wed, Feb 28, 2018 at 04:35:19AM -0700, Jan Beulich wrote: > I have no idea what *.1 is meant to cover. Instead also exclude > preprocessed and non-source assembly files. > > Signed-off-by: Jan Beulich <jbeul...@suse.com> > Reviewed-by: Wei Liu <wei.l...@citrix.com&

Re: [Xen-devel] [PATCH v8 07/11] vpci/bars: add handlers to map the BARs

On Wed, Feb 28, 2018 at 04:34:01AM -0700, Jan Beulich wrote: > >>> On 28.02.18 at 12:20, wrote: > > I've been giving some thought to this, and I cannot find a good > > solution. So far the less worse one would be: > > > > +--+ YES +-+ > > |Is

Re: [Xen-devel] [PATCH v3] build: remove shim related targets

On Wed, Feb 28, 2018 at 08:30:12AM -0700, Jan Beulich wrote: > >>> On 28.02.18 at 16:02, wrote: > > But that raises the question, if prefix=/usr/local this will become: > > > > /usr/local/lib/usr/local/lib/xen/... > > /usr/local/lib/debug/usr/local/lib/xen/... > > >

Re: [Xen-devel] [PATCH v8 11/11] vpci/msix: add MSI-X handlers

On Wed, Feb 28, 2018 at 07:33:55AM -0700, Jan Beulich wrote: > >>> On 23.01.18 at 16:07, wrote: > > @@ -255,6 +256,23 @@ static void modify_bars(const struct pci_dev *pdev, > > bool map, bool rom) > > } > > } > > > > +/* Remove any MSIX regions if

Re: [Xen-devel] [PATCH V2] libxl: set channel devid when not provided by application

v > > Besides the odd '-1' value in the id, multiple channels have the same > id, causing qemu to fail. A simple fix is to set an uninitialized > devid (-1) to the dev_num passed to libxl__init_console_from_channel(). > > Signed-off-by: Jim Fehlig <jfeh...@suse.com> Reviewed-

Re: [Xen-devel] [PATCH] xl: remove apic option for PVH guests

On Wed, Feb 28, 2018 at 10:20:53AM +, Roger Pau Monne wrote: > XSA-256 forces the local APIC to always be enabled for PVH guests, so > ignore any apic option for PVH guests. Update the documentation > accordingly. > > Signed-off-by: Roger Pau Monné <roger@citrix.co

Re: [Xen-devel] [PATCH v8 07/11] vpci/bars: add handlers to map the BARs

On Tue, Feb 27, 2018 at 07:10:51AM -0700, Jan Beulich wrote: > >>> On 27.02.18 at 12:57, wrote: > > On Tue, Feb 27, 2018 at 03:01:44AM -0700, Jan Beulich wrote: > >> >>> On 27.02.18 at 10:21, wrote: > >> > With the current approach in the unmap case

Re: [Xen-devel] [PATCH v3 5/6] vpt: add support for level interrupts

On Fri, Jun 22, 2018 at 08:23:02AM -0600, Jan Beulich wrote: > >>> On 08.06.18 at 17:07, wrote: > > @@ -316,7 +317,9 @@ int pt_update_irq(struct vcpu *v) > > if ( pt->pending_intr_nr ) > > { > > /* RTC code takes care of disabling the timer itself. */ > > -

Re: [Xen-devel] [PATCH v6 11/13] xen: support the Null scheduler

On Thu, Jun 28, 2018 at 09:27:08AM +0200, Dario Faggioli wrote: > On Thu, 2018-06-14 at 13:20 -0700, Stefano Stabellini wrote: > > On Thu, 14 Jun 2018, Andrew Cooper wrote: > > > On 14/06/18 14:40, Jan Beulich wrote: > > > I don't think its reasonable to alter the support status with this > >

Re: [Xen-devel] [PATCH 1/2] x86/cpuid: Fix up stale comments

On Wed, Jun 27, 2018 at 02:55:49PM +0100, Andrew Cooper wrote: > * There is no legacy path any more. All static information is retrieved in >the first pass. > * d->arch.cpuids[] doesn't exist any more. > > Signed-off-by: Andrew Cooper Reviewed-b

Re: [Xen-devel] [PATCH 3/3] libxc: do not return a value from xc_cpuid_policy

On Thu, Jun 28, 2018 at 09:45:06AM +0200, Roger Pau Monné wrote: > On Thu, Jun 28, 2018 at 08:31:49AM +0100, Wei Liu wrote: > > On Thu, Jun 28, 2018 at 09:29:32AM +0200, Roger Pau Monné wrote: > > > On Wed, Jun 27, 2018 at 03:49:30PM +0100, Wei Liu wrote: > > > > On W

Re: [Xen-devel] [PATCH v2 2/2] x86/cpuid: Alter the policy logic for leaf 0xb to be multi-invocation

umber of leaves in the future. > > Host data is scanned when filling in the raw policy, but Xen still discards > any toolstack settings for now. > > Signed-off-by: Andrew Cooper > Reviewed-by: Jan Beulich Reviewed-by: Roger Pau Monné _

Re: [Xen-devel] [PATCH 3/3] libxc: do not return a value from xc_cpuid_policy

On Thu, Jun 28, 2018 at 08:31:49AM +0100, Wei Liu wrote: > On Thu, Jun 28, 2018 at 09:29:32AM +0200, Roger Pau Monné wrote: > > On Wed, Jun 27, 2018 at 03:49:30PM +0100, Wei Liu wrote: > > > On Wed, Jun 27, 2018 at 04:32:14PM +0200, Roger Pau Monne wrote: > > > >

Re: [Xen-devel] [PATCH 3/3] libxc: do not return a value from xc_cpuid_policy

On Wed, Jun 27, 2018 at 03:49:30PM +0100, Wei Liu wrote: > On Wed, Jun 27, 2018 at 04:32:14PM +0200, Roger Pau Monne wrote: > > None of the called functions return any errors, so there's no point in > > returning an int from xc_cpuid_policy. > > > > Signed-off-by:

Re: [Xen-devel] [OSSTEST PATCH v2] crontabs: Run freebsd-master only three times per week

On Thu, Jun 28, 2018 at 11:34:11AM +0100, Ian Jackson wrote: > freebsd master seems to update very frequently and our tests are > pretty minimal. Right now having a permanent freebsd build test going > is probably not a very good use of our resources. > > CC: Roger Pau Monn

Re: [Xen-devel] [PATCH 01/10] vpci: move lock

On Fri, Jun 29, 2018 at 11:19:57AM +0100, Wei Liu wrote: > On Wed, Jun 20, 2018 at 04:42:25PM +0200, Roger Pau Monne wrote: > > diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c > > index 0ec4c082a6..9d5607d5f8 100644 > > --- a/xen/drivers/vpci/header.c > > +++

Re: [Xen-devel] [PATCH] x86/vtd: fix iommu_share_p2m_table

On Mon, Oct 08, 2018 at 04:33:04AM -0600, Jan Beulich wrote: > >>> On 08.10.18 at 12:14, wrote: > > --- a/xen/drivers/passthrough/iommu.c > > +++ b/xen/drivers/passthrough/iommu.c > > @@ -505,7 +505,7 @@ int iommu_do_domctl( > > > > void iommu_share_p2m_tableiommu_share_p2m_table(struct

Re: [Xen-devel] [PATCH] x86/vtd: fix iommu_share_p2m_table

On Mon, Oct 08, 2018 at 12:37:39PM +0200, Roger Pau Monné wrote: > On Mon, Oct 08, 2018 at 04:33:04AM -0600, Jan Beulich wrote: > > >>> On 08.10.18 at 12:14, wrote: > > > --- a/xen/drivers/passthrough/iommu.c > > > +++ b/xen/drivers/passthrough/i

Re: [Xen-devel] [PATCH] xen/blkfront: avoid NULL blkfront_info dereference on device removal

On Thu, Oct 11, 2018 at 06:20:00PM +0200, Vasilis Liaskovitis wrote: > If a block device is hot-added when we are out of grants, > gnttab_grant_foreign_access fails with -ENOSPC (log message "28 > granting access to ring page") in this code path: > > talk_to_blkback -> > setup_blkring ->

Re: [Xen-devel] [PATCH 1/6] x86/pvh: fix TSC mode setup for PVH Dom0

On Fri, Oct 12, 2018 at 09:34:35AM -0600, Jan Beulich wrote: > >>> On 09.10.18 at 11:42, wrote: > > A PVH Dom0 might use TSC scaling or other HVM specific TSC > > adjustments, so only short-circuit the TSC setup for a classic PV > > Dom0. > > How that? If the hardware supports

[Xen-devel] Interrupt injection with ISR set on Intel hardware

6:42 +0200 Subject: [PATCH] PEOI debug MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Andrew Cooper [power state tracing] Signed-off-by: Roger Pau Monné --- xen/arch/x86/acpi/cpu_idle.c | 4 + xen/arch/x86/cpu/mwait-idle.c | 2 + xen

Re: [Xen-devel] [PATCH v2 2/5] x86/domain: Initialise vcpu debug registers correctly

Intel processors. We clearly have no > software which cares, seeing as it is wrong for the last decade's worth of > Intel hardware and for all other vendors, so lets use the value 0 for > simplicity. > > Signed-off-by: Andrew Cooper > Reviewe

Re: [Xen-devel] [PATCH 09/17] x86/amd: put setting pv_post_outb_hook under CONFIG_PV

On Fri, Oct 12, 2018 at 08:14:36AM -0600, Jan Beulich wrote: > >>> On 04.10.18 at 17:43, wrote: > > It is used by PV code only. > > And wrongly so - the same is needed for a PVH Dom0 afaict. Yes, looking at the models affected by this issue according to init_amd it seems to cover the full AMD

Re: [Xen-devel] [PATCH v2 1/5] x86/boot: Initialise the debug registers correctly

er > Reviewed-by: Jan Beulich Reviewed-by: Roger Pau Monné ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v2 3/5] tools/dombuilder: Initialise vcpu debug registers correctly

actually > been observed. > > Signed-off-by: Andrew Cooper > Reviewed-by: Jan Beulich Reviewed-by: Roger Pau Monné > --- > CC: Ian Jackson > CC: Wei Liu > CC: Roger Pau Monné > > The correct way to do this would be to get/modify/set the vcpu state, but it &g

Re: [Xen-devel] [PATCH v2 5/5] x86: Reorganise and rename debug register fields in struct vcpu

On Mon, Oct 15, 2018 at 11:36:20AM +0100, Andrew Cooper wrote: > diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c > index 115ddf6..cc85395 100644 > --- a/xen/arch/x86/domctl.c > +++ b/xen/arch/x86/domctl.c > @@ -1576,8 +1576,11 @@ void arch_get_info_guest(struct vcpu *v, >

Re: [Xen-devel] [PATCH v2] xen/blkfront: avoid NULL blkfront_info dereference on device removal

_lock(_mutex); > free_info(info); > mutex_unlock(_mutex); > > dev_set_drvdata(>dev, NULL); > > This results in a NULL pointer BUG when blkfront_remove and blkif_free > try to access the failing device's NULL struct blkfront_info. &

Re: [Xen-devel] [PATCH v2 5/5] x86: Reorganise and rename debug register fields in struct vcpu

which > removes the storage for debugreg[4,5]. > > In arch_get_info_guest(), handle the merging of emulated dr7 state alongside > all other dr handling, rather than much later. > > Signed-off-by: Andrew Cooper Reviewed-by: Roger Pau Monné Thanks. ___

Re: [Xen-devel] [PATCH v2 5/5] x86: Reorganise and rename debug register fields in struct vcpu

On Mon, Oct 15, 2018 at 03:07:21PM +0100, Andrew Cooper wrote: > On 15/10/18 14:56, Roger Pau Monné wrote: > > On Mon, Oct 15, 2018 at 11:36:20AM +0100, Andrew Cooper wrote: > >> diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c > >> + > >>

Re: [Xen-devel] [Qemu-devel] [PATCH] Xen PCI passthrough: fix passthrough failure when irq map failure

On Thu, Oct 18, 2018 at 08:22:41AM +, Zhao, Yan Y wrote: > Hi > The background for this patch is that: for some pci device, even it's > PCI_INTERRUPT_PIN is not 0, it actually does not support INTx mode, so we > should just report error, disable INTx mode and continue the passthrough. >

Re: [Xen-devel] [PATCH] x86/mm/p2m: don't needlessly limit MMIO mapping order to 4k

On Tue, Oct 16, 2018 at 03:41:55PM +0100, Paul Durrant wrote: > The P2M common code currently restricts the MMIO mapping order of any > domain with IOMMU mappings, but that is not using shared tables, to 4k. > This has been shown to have a huge performance cost when passing through > a PCI device

Re: [Xen-devel] [PATCH v2 12/18] xen: setup Xen specific data for PVH

On Tue, Oct 09, 2018 at 01:03:11PM +0200, Juergen Gross wrote: > Initialize the needed Xen specific data. This is: > > - the Xen start of day page containing the console and Xenstore ring > page PFN and event channel > - the grant table > - the shared info page > > Set the RSDP address for the

Re: [Xen-devel] [PATCH v2 08/18] xen: add basic hooks for PVH in current code

On Tue, Oct 09, 2018 at 01:03:07PM +0200, Juergen Gross wrote: > Add the hooks to current code needed for Xen PVH. > > Signed-off-by: Juergen Gross > --- > grub-core/kern/i386/xen/pvh.c | 36 > +++ > grub-core/kern/i386/xen/startup_pvh.S | 29

Re: [Xen-devel] [PATCH v2 10/18] xen: setup hypercall page for PVH

On Tue, Oct 09, 2018 at 01:03:09PM +0200, Juergen Gross wrote: > Add the needed code to setup the hypercall page for calling into the > Xen hypervisor. > > Signed-off-by: Juergen Gross > --- > grub-core/kern/i386/xen/pvh.c | 70 > +++ > 1 file changed,

Re: [Xen-devel] [PATCH v2 12/18] xen: setup Xen specific data for PVH

On Tue, Oct 09, 2018 at 01:03:11PM +0200, Juergen Gross wrote: > Initialize the needed Xen specific data. This is: > > - the Xen start of day page containing the console and Xenstore ring > page PFN and event channel > - the grant table > - the shared info page > > Set the RSDP address for the

Re: [Xen-devel] dom0/pvh: Dom0 PVH with PCI passthrough support status

Hello, Thanks for your interest and testing of PVH Dom0! On Fri, Oct 19, 2018 at 04:08:45PM +, Vasile, Alexandru-catalin wrote: > Hello, > > I would like to use Dom0 with PVH mode together with PCI passthrough in order > to compare PVH and HVM in a real test scenario for early adoption of

Re: [Xen-devel] [PATCH 3/6] x86/pvh: allow PVH Dom0 to use the debug IO port console

On Fri, Oct 12, 2018 at 09:55:10AM -0600, Jan Beulich wrote: > >>> On 09.10.18 at 11:42, wrote: > > --- a/docs/misc/xen-command-line.markdown > > +++ b/docs/misc/xen-command-line.markdown > > @@ -681,6 +681,17 @@ Flag that makes a dom0 boot in PVHv2 mode. > > Flag that makes a dom0 use shadow

Re: [Xen-devel] [xen-unstable test] 128775: regressions - trouble: broken/fail/pass

On Tue, Oct 16, 2018 at 03:37:16PM +, osstest service owner wrote: > flight 128775 xen-unstable real [real] > http://logs.test-lab.xenproject.org/osstest/logs/128775/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: >

Re: [Xen-devel] Interrupt injection with ISR set on Intel hardware

On Mon, Oct 22, 2018 at 03:33:07PM +0800, Chao Gao wrote: > Hi, Roger, Andrew and Wei, > > Jan's patch > (https://lists.xen.org/archives/html/xen-devel/2018-10/msg01031.html) > fixs an issue in handling SVI. Currently, when dealing with EOI from guest, > the > SVI was cleared. But the correct

Re: [Xen-devel] [PATCH v2 12/18] xen: setup Xen specific data for PVH

On Fri, Oct 19, 2018 at 06:39:50PM +0200, Juergen Gross wrote: > On 19/10/2018 18:10, Roger Pau Monné wrote: > > On Tue, Oct 09, 2018 at 01:03:11PM +0200, Juergen Gross wrote: > >> Initialize the needed Xen specific data. This is: > >> > >> - the Xen star

Re: [Xen-devel] [PATCH] xen-blkfront: fix kernel panic with negotiate_mq error path

On Mon, Oct 29, 2018 at 11:31:56AM -0700, Manjunath Patil wrote: > info->nr_rings isn't adjusted in case of ENOMEM error from > negotiate_mq(). This leads to kernel panic in error path. > > Typical call stack involving panic - > #8 page_fault at 8175936f > [exception RIP:

Re: [Xen-devel] [PATCH v2 7/7] amd/pvh: enable ACPI C1E disable quirk on PVH Dom0

On Mon, Oct 29, 2018 at 08:19:20AM -0600, Jan Beulich wrote: > >>> On 19.10.18 at 17:20, wrote: > > --- a/xen/arch/x86/hvm/svm/svm.c > > +++ b/xen/arch/x86/hvm/svm/svm.c > > @@ -1272,6 +1272,24 @@ void svm_host_osvw_init() > > spin_unlock(_lock); > > } > > > > +static int

Re: [Xen-devel] [PATCH v2 2/7] x86/hvm: introduce a define for the debug output IO port

On Mon, Oct 29, 2018 at 10:51:07AM -0600, Jan Beulich wrote: > >>> On 19.10.18 at 17:20, wrote: > > No functional change intended. > > > > Signed-off-by: Roger Pau Monné > > Reviewed-by: Jan Beulich > with one remark: > > > --- a/xen/include/pu

Re: [Xen-devel] [PATCH v2] iommu / p2m: add a page_order parameter to iommu_map/unmap_page()

On Mon, Oct 29, 2018 at 01:29:28PM +, Paul Durrant wrote: > The P2M code currently contains many loops to deal with the fact that, > while it may be require to handle page orders greater than 4k, the > IOMMU map and unmap functions do not. > This patch adds a page_order parameter to those

Re: [Xen-devel] [PATCH 2/8] viridian: remove MSR perf counters

On Mon, Oct 29, 2018 at 06:02:05PM +, Paul Durrant wrote: > They're not really useful so maintaining them is pointless. > > Signed-off-by: Paul Durrant If you think they are not helpful: Reviewed-by: Roger Pau Monné Thanks, Roger. __

Re: [Xen-devel] [PATCH 3/8] viridian: remove comments referencing section number in the spec.

t; these too. > > This patch also cleans up some > 80 character lines. > > Purely cosmetic. No functional change. > > Signed-off-by: Paul Durrant Reviewed-by: Roger Pau Monné Just one nit below. > --- > Cc: Jan Beulich > Cc: Andrew Cooper > Cc: Wei Liu >

Re: [Xen-devel] [PATCH 5/8] viridian: separate interrupt related enlightenment implementations...

On Mon, Oct 29, 2018 at 06:02:08PM +, Paul Durrant wrote: > ...into new 'synic' module. > > The SynIC (synthetic interrupt controller) is specified [1] to be a super- > set of a virtualized LAPIC, and its definition encompasses all > enlightenments related to virtual interrupt control. > >

Re: [Xen-devel] [PATCH 4/8] viridian: remove duplicate union types

On Mon, Oct 29, 2018 at 06:02:07PM +, Paul Durrant wrote: > The 'viridian_vp_assist', 'viridian_hypercall_gpa' and > 'viridian_reference_tsc' union types are identical in layout. The layout > is also common throughout the specification [1]. > > This patch declares a common 'viridian_page_msr'

Re: [Xen-devel] [PATCH 7/8] viridian: define type for the 'virtual VP assist page'

On Mon, Oct 29, 2018 at 06:02:10PM +, Paul Durrant wrote: > The specification [1] defines a type so we should use it, rather than just > OR-ing and AND-ing magic bits. > > No functional change. > > NOTE: The type defined in the specification does include an anonymous > sub-struct in

Re: [Xen-devel] [PATCH 8/8] viridian: introduce struct viridian_page

t; No functional change. > > [1] > https://github.com/MicrosoftDocs/Virtualization-Documentation/raw/live/tlfs/Hypervisor%20Top%20Level%20Functional%20Specification%20v5.0C.pdf > > Signed-off-by: Paul Durrant Reviewed-by: Roger Pau Monné > --- > Cc: Ian Jackson > Cc: We

Re: [Xen-devel] [PATCH 6/8] viridian: separate time related enlightenment implementations...

On Mon, Oct 29, 2018 at 06:02:09PM +, Paul Durrant wrote: > @@ -154,6 +145,14 @@ viridian_hypercall(struct cpu_user_regs *regs); > void viridian_time_ref_count_freeze(struct domain *d); > void viridian_time_ref_count_thaw(struct domain *d); > > +int viridian_time_wrmsr(struct vcpu *v,

Re: [Xen-devel] [PATCH v2] xen-blkfront: fix kernel panic with negotiate_mq error path

t: move negotiate_mq to cover all cases of > new VBDs") > Signed-off-by: Manjunath Patil Acked-by: Roger Pau Monné Thanks, Roger. ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v2 3/7] x86/pvh: allow PVH Dom0 to use the debug IO port console

nsole. Note this is not > >> enabled by default in order to prevent clashes with hardware on the > >> system using 0xe9. > >> > >> Signed-off-by: Roger Pau Monné > >> --- > >> Cc: Jan Beulich > >> Cc: Andrew Cooper > >> Cc:

Re: [Xen-devel] [PATCH v2 12/18] xen: setup Xen specific data for PVH

On Mon, Oct 29, 2018 at 03:19:34PM +0100, Juergen Gross wrote: > On 29/10/2018 13:57, Roger Pau Monné wrote: > > On Fri, Oct 19, 2018 at 06:39:50PM +0200, Juergen Gross wrote: > >> On 19/10/2018 18:10, Roger Pau Monné wrote: > >>> On Tue, Oct 09, 2018 at 01:03:1

Re: [Xen-devel] [PATCH 4/8] viridian: remove duplicate union types

ns that represent the layout of an MSR, e.g > See section 2.6 "Reporting the Guest OS Identity". > > > Is there a plan to add a new structure like viridian_page_mmio or > > similar that requires such prefixes to be present? >

Re: [Xen-devel] [PATCH 7/8] viridian: define type for the 'virtual VP assist page'

On Tue, Oct 30, 2018 at 05:11:30PM +, Paul Durrant wrote: > > -Original Message- > > From: Roger Pau Monne > > Sent: 30 October 2018 17:09 > > To: Paul Durrant > > Cc: xen-devel@lists.xenproject.org; Andrew Cooper > > ; Wei Liu ; Jan Beulich > > > > Subject: Re: [Xen-devel] [PATCH

Re: [Xen-devel] [OSSTEST PATCH 3/3] mfi-common: Drop freebsd builds on non-freebsd flights

s being dropped are > build-amd64-xen-freebsd > build-amd64-xen-xsm-freebsd > in the branches > osstest > xen-unstable > (verified with standalone-generate-dump-flight-runvars). > > CC: Roger Pau Monné > CC: Wei Liu > Signed-off-by: Ian Jackson Acked

Re: [Xen-devel] [RFC PATCH v2 03/17] libxl: Handle Linux stubdomain specific QEMU options.

On Tue, Oct 16, 2018 at 06:16:41PM +0100, Ian Jackson wrote: > Marek Marczykowski-Górecki writes ("[RFC PATCH v2 03/17] libxl: Handle Linux > stubdomain specific QEMU options."): > > From: Eric Shelton > > > > This patch creates an appropriate command line for the QEMU instance > > running in a

Re: [Xen-devel] [PATCH v3 5/5] x86/domctl: Implement XEN_DOMCTL_get_cpu_policy

w flask access vector and update the default policies. > > Also extend xen-cpuid's --policy mode to be able to take a domid and dump a > specific domains CPUID and MSR policy. > > Signed-off-by: Andrew Cooper > Signed-off-by: Sergey Dyasli Reviewed-by: Roger Pau Monné > d

Re: [Xen-devel] dom0/pvh: Dom0 PVH with PCI passthrough support status

On Mon, Nov 05, 2018 at 04:17:56PM +0200, Alexandru Vasile wrote: > On Mon, Nov 05, 2018 at 12:57 PM, Wei Liu wrote: > > On Mon, Nov 05, 2018 at 11:58:09AM +0200, Alexandru Vasile wrote: > > > Hello, > > > (XEN) event_channel.c:319:d0v1 EVTCHNOP failure: domain 1, error -22 > > > (XEN)

Re: [Xen-devel] [PATCH 2/6] libx86: Split x86_cpuid_policy_fill_native() out of calculate_raw_policy()

; > Signed-off-by: Andrew Cooper Reviewed-by: Roger Pau Monné I'm slightly worried about the _native prefix in the function name, if this is run on Dom0 userspace the _native part of this is dubious, since the policy returned is going to be provided by Xen, and thus might not match the host one. I d

Re: [Xen-devel] [PATCH v3 5/7] vpci: fix execution of long running operations

On Wed, Nov 07, 2018 at 08:06:00AM -0700, Jan Beulich wrote: > >>> On 07.11.18 at 12:11, wrote: > > On Mon, Nov 05, 2018 at 09:56:13AM -0700, Jan Beulich wrote: > >> >>> On 30.10.18 at 16:41, wrote: > >> > BAR map/unmap is a long running operation that needs to be preempted > >> > in order to

Re: [Xen-devel] [PATCH v3 5/7] vpci: fix execution of long running operations

On Thu, Nov 08, 2018 at 11:42:35AM +, Julien Grall wrote: > Hi, > > Sorry to jump in the conversation late. > > On 11/8/18 11:29 AM, Roger Pau Monné wrote: > > > Why would that be? The do_softirq() invocation sits on the exit- > > > to-guest path, explicitly

Re: [Xen-devel] [PATCH v3 5/7] vpci: fix execution of long running operations

On Thu, Nov 08, 2018 at 06:04:11AM -0700, Jan Beulich wrote: > >>> On 08.11.18 at 13:47, wrote: > > My point would be that on x86 I think the only way to have preemptible > > long-running operations inside of Xen is to block the guest vCPU and > > run them in a tasklet, or at least this seems the

Re: [Xen-devel] [PATCH v3 5/7] vpci: fix execution of long running operations

On Thu, Nov 08, 2018 at 11:52:57AM +, Julien Grall wrote: > Hi Roger, > > On 11/8/18 11:44 AM, Roger Pau Monné wrote: > > On Thu, Nov 08, 2018 at 11:42:35AM +, Julien Grall wrote: > > > Hi, > > > > > > Sorry to jump in the conversation late. &

Re: [Xen-devel] [PATCH v3 5/7] vpci: fix execution of long running operations

On Thu, Nov 08, 2018 at 02:55:56AM -0700, Jan Beulich wrote: > >>> On 07.11.18 at 18:15, wrote: > > On Wed, Nov 07, 2018 at 08:06:00AM -0700, Jan Beulich wrote: > >> >>> On 07.11.18 at 12:11, wrote: > >> > On Mon, Nov 05, 2018 at 09:56:13AM -0700, Jan Beulich wrote: > >> >> >>> On 30.10.18 at

Re: [Xen-devel] [PATCH v3 5/7] vpci: fix execution of long running operations

On Thu, Nov 08, 2018 at 05:32:02AM -0700, Jan Beulich wrote: > >>> On 08.11.18 at 12:29, wrote: > > On Thu, Nov 08, 2018 at 02:55:56AM -0700, Jan Beulich wrote: > >> >>> On 07.11.18 at 18:15, wrote: > >> Then if the blocked bit is not set the call to do_softirq > >> > would be recurred, thus

Re: [Xen-devel] [PATCH v4] amd/pvh: enable ACPI C1E disable quirk on PVH Dom0

H Dom0, which consist on trapping accesses to the SMI command IO > > port and disabling C1E if ACPI is enabled. > > > > Reported-by: Jan Beulich > > Signed-off-by: Roger Pau Monné > > Reviewed-by: Wei Liu > > > > --- > > Cc: Jan Beulich &g

Re: [Xen-devel] [PATCH v2] mm/page_alloc: make bootscrub happen in idle-loop

On Thu, Nov 08, 2018 at 02:48:40PM +, Sergey Dyasli wrote: > (CCing Roger) > > On 08/11/2018 11:07, Andrew Cooper wrote: > > On 08/11/18 10:31, Jan Beulich wrote: > > On 07.11.18 at 19:20, wrote: > >>> On 09/10/18 16:21, Sergey Dyasli wrote: > Scrubbing RAM during boot may take a

Re: [Xen-devel] [PATCH] x86/amd: don't set pv_post_outb_hook when !CONFIG_PV

On Thu, Nov 08, 2018 at 02:58:09PM +, Wei Liu wrote: > Obviously it won't exist when PV is disabled. > > Signed-off-by: Wei Liu Reviewed-by: Roger Pau Monné Thanks, Roger. ___ Xen-devel mailing list Xen-devel@lists.xenproject.

Re: [Xen-devel] [PATCH] libx86: Fix 32bit stubdom build of x86_cpuid_policy_fill_native()

On Tue, Nov 13, 2018 at 11:59:15AM +, Andrew Cooper wrote: > With -m32, GCC generates a warning for _t == long, which is the > typecheck hidden inside the min() macro. > > Switch to using explicitly typed versions instead. > > Signed-off-by: Andrew Cooper Reviewed-b

Re: [Xen-devel] [PATCH 1/2] guest/pvh: fix handling of multiboot info and module list

On Mon, Nov 12, 2018 at 03:28:37AM -0700, Jan Beulich wrote: > >>> On 09.11.18 at 18:22, wrote: > > When booting Xen as a PVH guest the data in the PVH start info > > structure is copied over to a multiboot structure and a module list > > array that resides in the .init section of the Xen image.

Re: [Xen-devel] [PATCH 1/2] guest/pvh: fix handling of multiboot info and module list

On Mon, Nov 12, 2018 at 05:40:21AM -0700, Jan Beulich wrote: > >>> On 12.11.18 at 12:49, wrote: > > On Mon, Nov 12, 2018 at 03:28:37AM -0700, Jan Beulich wrote: > >> >>> On 09.11.18 at 18:22, wrote: > >> > for ( i = 0; i < pvh_info->nr_modules; i++ ) > >> > { > >> >

Re: [Xen-devel] [PATCH] x86: fix hvm_migrate_irq assertion

t; > Signed-off-by: Wei Liu Reviewed-by: Roger Pau Monné > --- > xen/arch/x86/hvm/hvm.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c > index 519282937b..5d263c4090 100644 > --- a/xen/arch/x86/

Re: [Xen-devel] [PATCH 1/2] guest/pvh: fix handling of multiboot info and module list

On Mon, Nov 12, 2018 at 08:12:56AM -0700, Jan Beulich wrote: > >>> On 12.11.18 at 16:00, wrote: > > Yes, it's only the module list that's passed by physical address and > > then mapped using __va. How about the following description: > > > > "When booting Xen as a PVH guest the data in the PVH

Re: [Xen-devel] [PATCH 2/4] x86/vvmx: Correct the INVALID_PADDR checks for VMPTRLD/VMCLEAR

On Thu, Nov 15, 2018 at 01:52:48PM +, Andrew Cooper wrote: > The referenced addresses also need checking against MAXPHYSADDR. > > Signed-off-by: Andrew Cooper Reviewed-by: Roger Pau Monné > --- > CC: Jan Beulich > CC: Wei Liu > CC: Roger Pau Monné > CC:

Re: [Xen-devel] [PATCH 3/4] x86/vvmx: Fixes to VMWRITE emulation

On Thu, Nov 15, 2018 at 01:52:49PM +, Andrew Cooper wrote: > * Don't assume that decode_vmx_inst() always returns X86EMUL_EXCEPTION. > * The okay boolean is never written, making the else case dead. > > Signed-off-by: Andrew Cooper Reviewed-by: Rog

Re: [Xen-devel] [PATCH v4 5/5] amd/iommu: skip bridge devices when updating IOMMU page tables

On Thu, Nov 15, 2018 at 08:40:11AM -0700, Jan Beulich wrote: > >>> On 14.11.18 at 12:57, wrote: > > Bridges are not behind an IOMMU, and are already special cased and > > silently skipped in amd_iommu_add_device. Apply the same special > > casing when updating page tables. > > But bridges also

Re: [Xen-devel] [PATCH 4/4] x86/vvmx: Don't call vmsucceed() at the end of virtual_vmexit()

On Thu, Nov 15, 2018 at 01:52:50PM +, Andrew Cooper wrote: > This ends up corrupting L1's view of RFLAGS by setting ZF. The correct value > is established earlier in the function. > > Signed-off-by: Andrew Cooper Reviewed-by: Rog

Re: [Xen-devel] [PATCH 1/4] x86/vvmx: Drop unused CASE_{GET, SET}_REG() macros

On Thu, Nov 15, 2018 at 01:52:47PM +, Andrew Cooper wrote: > These have been obsolete since c/s 053ae230 "x86/vvmx: Remove enum > vmx_regs_enc". > > Signed-off-by: Andrew Cooper Reviewed-by: Roger Pau Monné ___ Xen-devel

Re: [Xen-devel] [PATCH v4 4/5] amd/iommu: assign iommu devices to Xen

On Thu, Nov 15, 2018 at 08:34:44AM -0700, Jan Beulich wrote: > >>> On 14.11.18 at 12:57, wrote: > > --- a/xen/drivers/passthrough/amd/iommu_init.c > > +++ b/xen/drivers/passthrough/amd/iommu_init.c > > @@ -993,6 +993,16 @@ static void * __init allocate_ppr_log(struct amd_iommu > > *iommu) > >

Re: [Xen-devel] [PATCH v2] xen/pt: fix some pass-thru devices don't work across reboot

On Fri, Nov 16, 2018 at 03:53:50PM +0800, Chao Gao wrote: > On Thu, Nov 15, 2018 at 11:40:39AM +0100, Roger Pau Monné wrote: > >On Thu, Nov 15, 2018 at 09:10:26AM +0800, Chao Gao wrote: > >> I find some pass-thru devices don't work any more across guest > >> reboot. Ass

Re: [Xen-devel] [PATCH v2] xen/pt: fix some pass-thru devices don't work across reboot

On Fri, Nov 16, 2018 at 02:59:41AM -0700, Jan Beulich wrote: > >>> On 16.11.18 at 10:35, wrote: > > On Fri, Nov 16, 2018 at 03:53:50PM +0800, Chao Gao wrote: > >> On Thu, Nov 15, 2018 at 11:40:39AM +0100, Roger Pau Monné wrote: > >> >On Thu, Nov 15, 2

Re: [Xen-devel] [PATCH v4 1/5] vpci: fix updating the command register

On Fri, Nov 16, 2018 at 05:00:29AM -0700, Jan Beulich wrote: > >>> On 14.11.18 at 12:57, wrote: > > @@ -413,7 +412,7 @@ static void rom_write(const struct pci_dev *pdev, > > unsigned int reg, > > header->rom_enabled = new_enabled; > > pci_conf_write32(pdev->seg, pdev->bus,

Re: [Xen-devel] [PATCH v3 4/7] vpci: fix updating the command register

On Mon, Nov 05, 2018 at 09:46:22AM -0700, Jan Beulich wrote: > >>> On 30.10.18 at 16:41, wrote: > > When switching the memory decoding bit in the command register the > > rest of the changes where dropped, leading to only the memory decoding > > bit being updated. > > > > Fix this by

Re: [Xen-devel] [PATCH v3 6/7] vpci/msix: carve p2m hole for MSIX MMIO regions

On Mon, Nov 05, 2018 at 10:07:24AM -0700, Jan Beulich wrote: > >>> On 30.10.18 at 16:41, wrote: > > Make sure the MSIX MMIO regions don't have p2m entries setup, so that > > accesses to them trap into the hypervisor and can be handled by vpci. > > > > This is a side-effect of commit 042678762

Re: [Xen-devel] [PATCH v3 7/7] amd/pvh: enable ACPI C1E disable quirk on PVH Dom0

On Fri, Nov 02, 2018 at 03:06:58AM -0600, Jan Beulich wrote: > >>> On 30.10.18 at 16:41, wrote: > > --- a/xen/arch/x86/cpu/amd.c > > +++ b/xen/arch/x86/cpu/amd.c > > @@ -44,6 +44,9 @@ integer_param("cpuid_mask_thermal_ecx", > > opt_cpuid_mask_thermal_ecx); > > s8 __read_mostly opt_allow_unsafe;

Re: [Xen-devel] [PATCH v3 5/7] vpci: fix execution of long running operations

On Mon, Nov 05, 2018 at 09:56:13AM -0700, Jan Beulich wrote: > >>> On 30.10.18 at 16:41, wrote: > > BAR map/unmap is a long running operation that needs to be preempted > > in order to avoid overrunning the assigned vCPU time (or even > > triggering the watchdog). > > > > Current logic for this

Re: [Xen-devel] [PATCH v3 1/5] viridian: separate interrupt related enlightenment implementations...

lfs/Hypervisor%20Top%20Level%20Functional%20Specification%20v5.0C.pdf > > Signed-off-by: Paul Durrant > Reviewed-by: Wei Liu Reviewed-by: Roger Pau Monné Thanks, Roger. ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v3 2/5] viridian: separate time related enlightenment implementations...

t; - Clean up a bool_t. > > Signed-off-by: Paul Durrant > Reviewed-by: Wei Liu Reviewed-by: Roger Pau Monné Thanks, Roger. ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v3 3/5] viridian: define type for the 'virtual VP assist page'

> > Signed-off-by: Paul Durrant > Reviewed-by: Wei Liu Reviewed-by: Roger Pau Monné Just one style nit below... > --- > Cc: Jan Beulich > Cc: Andrew Cooper > > v3: > - Move the typedef of HV_VP_ASSIST_PAGE into viridian.h so that it can >be used in th

Re: [Xen-devel] [PATCH v3] iommu / p2m: add a page_order parameter to iommu_map/unmap_page()...

lso adds emacs boilerplate to xen/iommu.h to avoid tabbing > problem. > > NOTE: This patch does not modify the underlying vendor IOMMU > implementations to deal with more than a single page at once. > > Signed-off-by: Paul Durrant Reviewed-by: Roger Pau Monné Thanks, Roger.

Re: [Xen-devel] [PATCH v4 12/19] xen: add PCI MMIO areas to memory map

ned-off-by: Juergen Gross > --- > V4: new patch (Roger Pau Monné) > --- > grub-core/kern/i386/xen/pvh.c | 70 > +++ > 1 file changed, 70 insertions(+) > > diff --git a/grub-core/kern/i386/xen/pvh.c b/grub-core/kern/i386/xen/pvh.c >

<    4   5   6   7   8   9   10   11   12   13   >