Re: [Xen-devel] [PATCH for-next RFC 1/4] build/m4: make python_devel.m4 work with both python 2 and 3

2019-03-06 Thread Wei Liu
On Wed, Mar 06, 2019 at 03:07:16PM +, Anthony PERARD wrote: > On Tue, Mar 05, 2019 at 04:42:03PM +0000, Wei Liu wrote: > > Do the following: > > > > 1. Change the form of "print". > > 2. Check for ABI flags -- this is complicated because it is only >

Re: [Xen-devel] [PATCH for-next RFC 2/4] libxl: make python scripts work with python 2 and 3

2019-03-06 Thread Wei Liu
On Tue, Mar 05, 2019 at 05:34:13PM +, Andrew Cooper wrote: > On 05/03/2019 16:42, Wei Liu wrote: > > All scripts are transformed by 2to3. > > > > The only addition is "from __future__ import print_function" so that > > print("BLAH", file=sys.stde

Re: [Xen-devel] [PATCH for-next RFC 1/4] build/m4: make python_devel.m4 work with both python 2 and 3

2019-03-06 Thread Wei Liu
On Wed, Mar 06, 2019 at 03:35:53PM +, Anthony PERARD wrote: > On Wed, Mar 06, 2019 at 03:24:43PM +0000, Wei Liu wrote: > > On Wed, Mar 06, 2019 at 03:07:16PM +, Anthony PERARD wrote: > > > > -AC_CHECK_LIB(python$ac_python_version, PyArg_ParseTuple, [], > > > &

Re: [Xen-devel] [PATCH for-next RFC 4/4] pygrub: make it build with python 3

2019-03-06 Thread Wei Liu
On Tue, Mar 05, 2019 at 04:42:06PM +, Wei Liu wrote: > + > PyMODINIT_FUNC > initxenfsimage(void) So Python 3 requires the initialisation function to be called PyInit_xenfsimage, otherwise it can't find the entry point of this module. I have fixed this in my next version. Wei

[Xen-devel] [PATCH for-next v2 v2 4/5] pygrub: make it build with python 3

2019-03-06 Thread Wei Liu
removed, yet an alternative wasn't documented. The code is the result of reverse-engineering cpython commit 6116d4a1d1 https://docs.python.org/3/howto/cporting.html http://python3porting.com/cextensions.html Signed-off-by: Wei Liu --- v2: use PyBytes. --- tools/pygrub/src/fsimage/fsimage.c

[Xen-devel] [PATCH for-next v2 v2 3/5] pygrub: convert python scripts to work with 2.6 and up

2019-03-06 Thread Wei Liu
Run 2to3 and pick the sensible suggestions. Signed-off-by: Wei Liu --- tools/pygrub/src/ExtLinuxConf.py | 15 --- tools/pygrub/src/GrubConf.py | 36 ++-- tools/pygrub/src/LiloConf.py | 15 --- 3 files changed, 34 insertions(+), 32

[Xen-devel] [PATCH for-next v2 v2 2/5] libxl: make python scripts work with python 2.6 and up

2019-03-06 Thread Wei Liu
Go through the transformations suggested by 2to3 and pick the necessary ones. Use sys.stderr.write to avoid importing from __future__. Signed-off-by: Wei Liu --- tools/libxl/gentest.py | 2 +- tools/libxl/gentypes.py | 10 +- tools/libxl/idl.py | 13 ++--- 3 files

[Xen-devel] [PATCH for-next v2 v2 5/5] Update python requirement

2019-03-06 Thread Wei Liu
CentOS 5, which was the reason of the 2.4 restriction, is EOL. CentOS 6 ships 2.6. Bump the version to 2.6 in README. Now that all scripts are 3 compatible, remove the restriction on python 2 as well. Update the check in configure.ac. Signed-off-by: Wei Liu --- README | 10

[Xen-devel] [PATCH for-next v2 v2 0/5] tools: Python 3 compatibility

2019-03-06 Thread Wei Liu
This series makes tools work with Python 2 and 3. No more RFC because I have tested it on my testbox. You need Andrew's "tools/xen-foreign: Update python scripts to be Py3 compatible" as well. W

[Xen-devel] [PATCH for-next v2 v2 1/5] build/m4: make python_devel.m4 work with both python 2 and 3

2019-03-06 Thread Wei Liu
Do the following: 1. Change the form of "print". 2. Use AC_CHECK_FUNC to avoid the need to generate library name. 3. Remove unused stuff. Signed-off-by: Wei Liu --- I doubt the non-python-config branch works, because the paths generated seem rather off. It definitely doesn't wor

Re: [Xen-devel] [PATCH for-next v2 v2 0/5] tools: Python 3 compatibility

2019-03-06 Thread Wei Liu
On Wed, Mar 06, 2019 at 05:52:05PM +, Wei Liu wrote: > This series makes tools work with Python 2 and 3. > > No more RFC because I have tested it on my testbox. Spoke too soon. The testbox wasn't using the files I installed. I will retest

Re: [Xen-devel] [PATCH for-next v2 v2 2/5] libxl: make python scripts work with python 2.6 and up

2019-03-07 Thread Wei Liu
On Wed, Mar 06, 2019 at 09:58:19PM +0100, Hans van Kranenburg wrote: > On 3/6/19 6:52 PM, Wei Liu wrote: > > Go through the transformations suggested by 2to3 and pick the > > necessary ones. > > > > Use sys.stderr.write to avoid importing from __future__. >

Re: [Xen-devel] [PATCH 1/2] x86/e820: fix build with gcc9

2019-03-07 Thread Wei Liu
On Thu, Mar 07, 2019 at 11:46:08AM +0100, Roger Pau Monné wrote: > On Thu, Mar 07, 2019 at 03:31:43AM -0700, Jan Beulich wrote: > > e820.c: In function ‘clip_to_limit’: > > .../xen/include/asm/string.h:10:26: error: ‘__builtin_memmove’ offset [-16, > > -36] is out of the bounds [0, 20484] of > > o

Re: [Xen-devel] [PATCH v1] libxl: prepare environment for domcreate_stream_done

2019-03-07 Thread Wei Liu
Thanks for the patch! On Thu, Mar 07, 2019 at 11:56:49AM +0100, Olaf Hering wrote: > The function domcreate_bootloader_done may branch early to > domcreate_stream_done, in case some error occoured. Here srs->dcs will be > NULL, which leads to a crash. > > It is unclear what the purpose of that ba

Re: [Xen-devel] [PATCH 0/2] x86: fix build with gcc9

2019-03-07 Thread Wei Liu
ch I haven't been able to see > myself, and hence for now I'm unable to sort out a proper fix / > workaround for them. > > Despite this coming late, I think this is a worthwhile change for 4.12 > with pretty low risk. > > 1: e820: fix build with gcc9 > 2: mtrr

Re: [Xen-devel] [PATCH for-next v2 v2 5/5] Update python requirement

2019-03-07 Thread Wei Liu
On Thu, Mar 07, 2019 at 11:21:29AM +, Anthony PERARD wrote: > On Wed, Mar 06, 2019 at 05:52:10PM +0000, Wei Liu wrote: > > CentOS 5, which was the reason of the 2.4 restriction, is EOL. CentOS > > 6 ships 2.6. > > > > Bump the version to 2.6 in README.

Re: [Xen-devel] [PATCH for-next v2 v2 2/5] libxl: make python scripts work with python 2.6 and up

2019-03-07 Thread Wei Liu
On Thu, Mar 07, 2019 at 10:37:45AM +, Wei Liu wrote: > > Importing print_function was specifically avoided because we wanted 2.4 > compatibility at first. But now I propose to bump the requirement to > 2.6, the from __future__ import print_function may become available. I > wil

Re: [Xen-devel] [PATCH v1] libxl: prepare environment for domcreate_stream_done

2019-03-07 Thread Wei Liu
On Thu, Mar 07, 2019 at 12:53:38PM +0100, Olaf Hering wrote: > Am Thu, 7 Mar 2019 11:02:47 + > schrieb Wei Liu : > > > Have you seen the field been set before entering this function? Or is > > the if () just a precaution? > > Sorry, this is not the varian

Re: [Xen-devel] Intel TXT maintainter update

2019-03-07 Thread Wei Liu
Hi Lukasz On Wed, Mar 06, 2019 at 11:21:22AM +, Hawrylko, Lukasz wrote: > Due to personal changes at Intel, I am new TXT maintainer for XEN. > Adding patch that updates maintainers list. > > Thanks, > Lukasz Unfortunately your patch needs fixing. The form is not correct. I would suggest you

Re: [Xen-devel] [PATCH v1] libxl: prepare environment for domcreate_stream_done

2019-03-08 Thread Wei Liu
On Fri, Mar 08, 2019 at 10:22:18AM +0100, Olaf Hering wrote: > Am Thu, 7 Mar 2019 12:18:20 + > schrieb Wei Liu : > > > That code has been changed quite a bit with migration v2 and COLO. I > > wouldn't be surprised if some code becomes stale. > > Are you ok wit

Re: [Xen-devel] [PATCH v2] libxl: prepare environment for domcreate_stream_done

2019-03-08 Thread Wei Liu
ointer is. Perhaps it can be > removed, and domcreate_stream_done could use CONTAINER_OF. > > Signed-off-by: Olaf Hering Acked-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v2] libxl: prepare environment for domcreate_stream_done

2019-03-08 Thread Wei Liu
On Fri, Mar 08, 2019 at 03:43:18PM +0100, Olaf Hering wrote: > Am Fri, 8 Mar 2019 14:08:10 + > schrieb Ian Jackson : > > > In fact this is OK because domcreate_stream_done only reads srs->dcs > > and then does everything with the obtained dcs. But there is nothing > > there to indicate that s

[Xen-devel] [PATCH v3 1/7] Update python requirement

2019-03-11 Thread Wei Liu
CentOS 5, which was the reason of the 2.4 restriction, is EOL. CentOS 6 ships 2.6. Bump the version to 2.6 in README. Now that all scripts are 3 compatible, remove the restriction on python 2 as well. Update the check in configure.ac. Signed-off-by: Wei Liu --- README | 10

[Xen-devel] [PATCH v3 4/7] build/m4: make python_devel.m4 work with both python 2 and 3

2019-03-11 Thread Wei Liu
Do the following: 1. Change the form of "print". 2. Use AC_CHECK_FUNC to avoid the need to generate library name. 3. Remove unused stuff. Signed-off-by: Wei Liu Reviewed-by: Anthony PERARD --- m4/python_devel.m4 | 23 +++- tools/configu

[Xen-devel] [PATCH v3 3/7] pygrub: change tabs into spaces

2019-03-11 Thread Wei Liu
Not sure why Python 2 never complained, but Python 3 does. Change tabs to spaces. Signed-off-by: Wei Liu --- Backport candidate. --- tools/pygrub/src/pygrub | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/pygrub/src/pygrub b/tools/pygrub/src/pygrub index

[Xen-devel] [PATCH v3 6/7] pygrub: make python scripts work with 2.6 and up

2019-03-11 Thread Wei Liu
lemented a (undocumented) module. We only need to import curses to make curses.wrapper available to pygrub. Signed-off-by: Wei Liu --- tools/pygrub/src/ExtLinuxConf.py | 19 ++- tools/pygrub/src/GrubConf.py | 39 -- tools/pygrub/src/LiloConf.py | 19 ++- tools/

[Xen-devel] [PATCH v3 7/7] pygrub/fsimage: make it work with python 3

2019-03-11 Thread Wei Liu
The code is the result of reverse-engineering cpython commit 6116d4a1d1 https://docs.python.org/3/howto/cporting.html http://python3porting.com/cextensions.html Signed-off-by: Wei Liu --- v3: use PyType_Ready to initialise types. v2: use PyBytes. --- tools/pygrub/src/fsimage/fsimage.c

[Xen-devel] [PATCH v3 5/7] libxl: make python scripts work with python 2.6 and up

2019-03-11 Thread Wei Liu
Go through transformations suggested by 2to3 and pick the necessary ones. Signed-off-by: Wei Liu --- tools/libxl/gentest.py | 4 +++- tools/libxl/gentypes.py | 12 +++- tools/libxl/idl.py | 15 --- 3 files changed, 18 insertions(+), 13 deletions(-) diff --git a/tools

[Xen-devel] [PATCH v3 2/7] pygrub/fsimage: drop unused struct

2019-03-11 Thread Wei Liu
Signed-off-by: Wei Liu --- tools/pygrub/src/fsimage/fsimage.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/tools/pygrub/src/fsimage/fsimage.c b/tools/pygrub/src/fsimage/fsimage.c index 743a3fb7b8..780207791c 100644 --- a/tools/pygrub/src/fsimage/fsimage.c +++ b/tools/pygrub/src

[Xen-devel] [PATCH v3 0/7] tools: Python 3 compatibility

2019-03-11 Thread Wei Liu
n scripts to be Py3 compatible" is a pre-requisite. Wei. Wei Liu (7): Update python requirement pygrub/fsimage: drop unused struct pygrub: change tabs into spaces build/m4: make python_devel.m4 work with both python 2 and 3 libxl: make python scripts work with python 2.6 and up

Re: [Xen-devel] [PATCH v3 1/7] Update python requirement

2019-03-11 Thread Wei Liu
On Mon, Mar 11, 2019 at 01:08:11PM +, Andrew Cooper wrote: > On 11/03/2019 13:04, Wei Liu wrote: > > CentOS 5, which was the reason of the 2.4 restriction, is EOL. CentOS > > 6 ships 2.6. > > > > Bump the version to 2.6 in README. Now that all scripts are 3

[Xen-devel] [PATCH v3 8/7] pygrub/fsimage: use named initialisation in extension

2019-03-11 Thread Wei Liu
... and drop PY_PAD. Signed-off-by: Wei Liu --- This can be squashed into previous patch. --- tools/pygrub/src/fsimage/fsimage.c | 47 ++ 1 file changed, 7 insertions(+), 40 deletions(-) diff --git a/tools/pygrub/src/fsimage/fsimage.c b/tools/pygrub/src

[Xen-devel] [PATCH v4 0/8] tools: Python 3 compatibility

2019-03-11 Thread Wei Liu
Wei Liu (8): Update Python requirement to 2.6 pygrub/fsimage: drop unused struct pygrub: change tabs into spaces build/m4: make python_devel.m4 work with both python 2 and 3 libxl: make python scripts work with python 2.6 and up pygrub: make python scripts work with 2.6 and up pygrub

[Xen-devel] [PATCH v4 4/8] build/m4: make python_devel.m4 work with both python 2 and 3

2019-03-11 Thread Wei Liu
Do the following: 1. Change the form of "print". 2. Use AC_CHECK_FUNC to avoid the need to generate library name. 3. Remove unused stuff. Signed-off-by: Wei Liu Reviewed-by: Anthony PERARD --- m4/python_devel.m4 | 23 +++- tools/configu

[Xen-devel] [PATCH v4 7/8] pygrub/fsimage: make it work with python 3

2019-03-11 Thread Wei Liu
The code is the result of reverse-engineering cpython commit 6116d4a1d1 https://docs.python.org/3/howto/cporting.html http://python3porting.com/cextensions.html Signed-off-by: Wei Liu Reviewed-by: Andrew Cooper --- tools/pygrub/src/fsimage/fsimage.c | 123 + 1

[Xen-devel] [PATCH v4 1/8] Update Python requirement to 2.6

2019-03-11 Thread Wei Liu
CentOS 5, which was the reason for the 2.4 restriction, is EOL. CentOS 6 ships 2.6. Bump the version to 2.6 in README. Update configure. Signed-off-by: Wei Liu --- README | 4 ++-- tools/configure| 8 tools/configure.ac | 2 +- 3 files changed, 7 insertions(+), 7

[Xen-devel] [PATCH v4 2/8] pygrub/fsimage: drop unused struct

2019-03-11 Thread Wei Liu
Signed-off-by: Wei Liu Reviewed-by: Andrew Cooper --- tools/pygrub/src/fsimage/fsimage.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/tools/pygrub/src/fsimage/fsimage.c b/tools/pygrub/src/fsimage/fsimage.c index 743a3fb7b8..780207791c 100644 --- a/tools/pygrub/src/fsimage

[Xen-devel] [PATCH v4 8/8] README: remove requirement on Python 2

2019-03-11 Thread Wei Liu
Now that all python scripts are compatible with Python 2.6 and above, remove the restriction. Signed-off-by: Wei Liu --- README | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/README b/README index 923c8fddf9..6504a7f19c 100644 --- a/README +++ b/README @@ -46,7

[Xen-devel] [PATCH v4 5/8] libxl: make python scripts work with python 2.6 and up

2019-03-11 Thread Wei Liu
Go through transformations suggested by 2to3 and pick the necessary ones. Signed-off-by: Wei Liu Reviewed-by: Andrew Cooper --- tools/libxl/gentest.py | 4 +++- tools/libxl/gentypes.py | 12 +++- tools/libxl/idl.py | 15 --- 3 files changed, 18 insertions(+), 13

[Xen-devel] [PATCH v4 6/8] pygrub: make python scripts work with 2.6 and up

2019-03-11 Thread Wei Liu
lemented a (undocumented) module. We only need to import curses to make curses.wrapper available to pygrub. Signed-off-by: Wei Liu Reviewed-by: Andrew Cooper --- tools/pygrub/src/ExtLinuxConf.py | 19 ++- tools/pygrub/src/GrubConf.py | 39 -- tools/pygrub/src/LiloConf.p

[Xen-devel] [PATCH v4 3/8] pygrub: change tabs into spaces

2019-03-11 Thread Wei Liu
Not sure why Python 2 never complained, but Python 3 does. Change tabs to spaces. Signed-off-by: Wei Liu Reviewed-by: Andrew Cooper --- tools/pygrub/src/pygrub | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/pygrub/src/pygrub b/tools/pygrub/src/pygrub index

Re: [Xen-devel] [PATCH 1/1] Update TXT maintainter

2019-03-12 Thread Wei Liu
Thanks. The format looks correct now. Shane, can you ack this patch? On Tue, Mar 12, 2019 at 09:39:26AM +, Hawrylko, Lukasz wrote: > Signed-off-by: Lukasz Hawrylko > --- > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index

Re: [Xen-devel] [PATCH v2] tools/xen-foreign: Update python scripts to be Py3 compatible

2019-03-12 Thread Wei Liu
"long", and the only reason sorting is necessary is because > inttypes[arch] is needlessly a dictionary. Update inttypes[arch] to be a list > of tuples rather than a dictionary, and process them in list order. > > Reported-by: George

Re: [Xen-devel] [PATCH v5 0/1] cameraif: add ABI for para-virtual camera

2019-03-12 Thread Wei Liu
On Tue, Mar 12, 2019 at 10:15:08AM +0100, Juergen Gross wrote: > On 12/03/2019 10:07, Jan Beulich wrote: > On 12.03.19 at 09:48, wrote: > >> On 12/03/2019 09:19, Oleksandr Andrushchenko wrote: > >>> From: Oleksandr Andrushchenko > >>> > >>> Hello! > >>> > >>> At the moment Xen [1] already su

Re: [Xen-devel] [PATCH] xen: Fix XEN_EXTRAVERSION after c/s 100507b34 branching for 4.13

2019-03-12 Thread Wei Liu
On Tue, Mar 12, 2019 at 11:38:03AM +, Andrew Cooper wrote: > The update to README and SUPPORT.md where correct, but XEN_EXTRAVERSION had an > additional .0 slip in. > > Signed-off-by: Andrew Cooper Acked-by: Wei Liu ___ Xen-devel

Re: [Xen-devel] [PATCH v2 0/3] Remove tmem

2019-03-12 Thread Wei Liu
On Wed, Nov 28, 2018 at 01:58:03PM +, Wei Liu wrote: > It is agreed that tmem can be removed from xen.git. See the thread starting > > > from . > > In this version: > > 1. Remove some

Re: [Xen-devel] [PATCH v2] x86: don't allow clearing of TF_kernel_mode for other than 64-bit PV

2019-03-12 Thread Wei Liu
r 32-bit PV (this isn't a fast path after all). > > Remove no longer necessary is_pv_32bit_*() from sh_update_cr3() and > sh_walk_guest_tables(). Note that shadow_one_bit_disable() already > assumes the new behavior. > > Signed-of

Re: [Xen-devel] [PATCH] MAINTAINERS: add myself as maintainer for public I/O interfaces

2019-03-12 Thread Wei Liu
On Tue, Mar 12, 2019 at 02:24:14PM +0100, Juergen Gross wrote: > The "PUBLIC I/O INTERFACES AND PV DRIVERS DESIGNS" section of the > MAINTAINERS file lists Konrad as the only maintainer. Add myself for > helping him to review patches. > > Signed-off-by: Juergen

Re: [Xen-devel] [PATCH] SVM: fix build after "make nested page-fault tracing and logging consistent"

2019-03-12 Thread Wei Liu
Andrew Cooper > Signed-off-by: Jan Beulich Reviewed-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [linux-linus bisection] complete test-arm64-arm64-xl-xsm

2019-03-12 Thread Wei Liu
On Tue, Mar 12, 2019 at 06:27:03PM +0100, Roger Pau Monné wrote: > On Tue, Mar 12, 2019 at 03:59:04PM +, Julien Grall wrote: > > Hi all, > > > > It looks like all the arm test for linus [1] and next [2] tree > > are now failing. x86 seems to be mostly ok. > > I'm quite sure x86 PVH dom0 is al

Re: [Xen-devel] [PATCH v6 02/12] microcode/intel: use union to get fields without shifting and masking

2019-03-12 Thread Wei Liu
On Tue, Mar 12, 2019 at 10:43:23AM -0600, Jan Beulich wrote: > >>> On 12.03.19 at 16:33, wrote: > > On Mon, Mar 11, 2019 at 03:57:26PM +0800, Chao Gao wrote: > > > > Please add "No functional change" to the commit description. > > > > Reviewed-by: Roger Pau Monné > > Acked-by: Jan Beulich >

Re: [Xen-devel] [PATCH v6 01/12] misc/xenmicrocode: Upload a microcode blob to the hypervisor

2019-03-13 Thread Wei Liu
On Mon, Mar 11, 2019 at 03:57:25PM +0800, Chao Gao wrote: > +ret = xc_platform_op(xch, &op); > +if ( ret ) Since you will be resending anyway, please make the coding style consistent here. Thanks. > +fprintf(stderr, "Failed to update microcode. (err: %d)\n", ret); ret is -1 here.

Re: [Xen-devel] Commit 16cc3362aed39e3093419b9df6ec73269071d063 configure failure

2019-03-13 Thread Wei Liu
On Wed, Mar 13, 2019 at 01:24:06PM +0200, Razvan Cojocaru wrote: > Hello, > > Commit "build/m4: make python_devel.m4 work with both python 2 and 3" makes > my configure run fail, at least on my Ubuntu 16.04.6 LTS machine. > > http://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=16cc3362aed39e3

[Xen-devel] [PATCH 0/3] Python 3 compatibility followup patches

2019-03-13 Thread Wei Liu
Wei Liu (3): automation: use python-dev python2.7-dev in Debian and Ubuntu travis: use python-dev instead of python2.7-dev build/m4: fix python library detection on Ubuntu systems .travis.yml | 2 +- automation/build/debian/jessie-i386.dockerfile

[Xen-devel] [PATCH 2/3] travis: use python-dev instead of python2.7-dev

2019-03-13 Thread Wei Liu
Xen build should be using default python now. Signed-off-by: Wei Liu --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 2266b4d22f..15ca9e9047 100644 --- a/.travis.yml +++ b/.travis.yml @@ -44,7 +44,7 @@ addons

[Xen-devel] [PATCH 1/3] automation: use python-dev python2.7-dev in Debian and Ubuntu

2019-03-13 Thread Wei Liu
distros pick the default python. Signed-off-by: Wei Liu --- I already updated all docker images. I intend to commit this even without an ack from Doug. --- automation/build/debian/jessie-i386.dockerfile | 2 +- automation/build/debian/jessie.dockerfile | 2 +- automation/build/debian

[Xen-devel] [PATCH 3/3] build/m4: fix python library detection on Ubuntu systems

2019-03-13 Thread Wei Liu
16cc3362aed doesn't work on Ubuntu with gcc (but it does work with clang). Work around it by manipulating LIBS. Signed-off-by: Wei Liu --- m4/python_devel.m4 | 7 +++ tools/configure| 7 +++ 2 files changed, 14 insertions(+) diff --git a/m4/python_devel.m4 b/m4/python_dev

Re: [Xen-devel] Commit 16cc3362aed39e3093419b9df6ec73269071d063 configure failure

2019-03-13 Thread Wei Liu
On Wed, Mar 13, 2019 at 01:31:22PM +0200, Razvan Cojocaru wrote: > On 3/13/19 1:28 PM, Wei Liu wrote: > > On Wed, Mar 13, 2019 at 01:24:06PM +0200, Razvan Cojocaru wrote: > > > Hello, > > > > > > Commit "build/m4: make python_devel.m4 work with both python

Re: [Xen-devel] [PATCH v2 2/2] tools: add new xl command get-hypervisor-config

2019-03-14 Thread Wei Liu
be moved to libxenguest.h. > > Signed-off-by: Juergen Gross Acked-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v2 1/2] xen: add interface for obtaining .config from hypervisor

2019-03-14 Thread Wei Liu
art from XSM changes) Reviewed-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [PATCH] build: don't mandate availability of a fetcher program

2019-03-14 Thread Wei Liu
ned-off-by: Wei Liu --- m4/fetcher.m4 | 4 +++- stubdom/configure | 46 +- tools/configure | 46 +- 3 files changed, 93 insertions(+), 3 deletions(-) diff --git a/m4/fetcher.m4 b/m4/fetcher.m4 index

Re: [Xen-devel] [PATCH 1/1] Update TXT maintainter

2019-03-15 Thread Wei Liu
On Thu, Mar 14, 2019 at 06:25:42PM +, Julien Grall wrote: > Hi Wei, > > On 3/12/19 11:54 AM, Wei Liu wrote: > > Thanks. The format looks correct now. > > > > Shane, can you ack this patch? > > Do we also need Gang Wei acked-by to confirm he wants to be rem

Re: [Xen-devel] [PATCH 1/1] Update TXT maintainter

2019-03-15 Thread Wei Liu
On Fri, Mar 15, 2019 at 11:01:04AM +, Julien Grall wrote: > Hi Wei, > > On 15/03/2019 10:58, Wei Liu wrote: > > On Thu, Mar 14, 2019 at 06:25:42PM +, Julien Grall wrote: > > > Hi Wei, > > > > > > On 3/12/19 11:54 AM, Wei Liu wrote: &g

Re: [Xen-devel] [PATCH v2] automation: enable building rombios with clang

2019-03-15 Thread Wei Liu
On Sat, Aug 25, 2018 at 10:01:38PM -0500, Doug Goldstein wrote: > On Fri, Aug 24, 2018 at 04:34:35PM +0100, Wei Liu wrote: > > On Fri, Aug 24, 2018 at 10:32:24AM -0500, Doug Goldstein wrote: > > > On Fri, Aug 24, 2018 at 04:22:47PM +0100, Wei Liu wrote: > > > > Pre

Re: [Xen-devel] xen source configured with --enable-systemd installs xencommons

2019-03-15 Thread Wei Liu
On Wed, Mar 13, 2019 at 03:26:13PM +, Mathieu Tarral wrote: > Hi, > > I think I found a small issue today in Xen's build system. > > When you configure the build with --enable-systemd, and generate > a debian package with make debball, the xencommons init script > will be installed alongside

Re: [Xen-devel] [PATCH v2 2/2] xen/debug: make debugtrace more clever regarding repeating entries

2019-03-15 Thread Wei Liu
On Fri, Mar 15, 2019 at 07:35:57AM +0100, Juergen Gross wrote: > In case debugtrace is writing to memory and the last entry is repeated > don't fill up the trace buffer, but modify the count prefix to "x-y " > style instead. > > Signed-off-by: Jue

Re: [Xen-devel] [PATCH] xen: drop the nop() macro

2019-03-15 Thread Wei Liu
l' > > In practice, a compiler barrier suffices just as well to prevent the tailcall, > and doesn't involve inserting unnecessary instructions. > > Signed-off-by: Andrew Cooper Reviewed-by: Wei Liu ___ Xen-devel ma

Re: [Xen-devel] [PATCH 1/1] Update TXT maintainter

2019-03-15 Thread Wei Liu
On Fri, Mar 15, 2019 at 10:12:16AM -0600, Tamas K Lengyel wrote: > On Fri, Mar 15, 2019 at 4:58 AM Wei Liu wrote: > > > > On Thu, Mar 14, 2019 at 06:25:42PM +, Julien Grall wrote: > > > Hi Wei, > > > > > > On 3/12/19 11:54 AM, Wei Liu wrote: &g

[Xen-devel] [PATCH 2/2] x86/pvshim: use 2M alignment

2019-03-18 Thread Wei Liu
The pvshim is loaded directly by toolstack. Use 2M alignment for potential better performance. Signed-off-by: Wei Liu --- xen/arch/x86/configs/pvshim_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/arch/x86/configs/pvshim_defconfig b/xen/arch/x86/configs/pvshim_defconfig

[Xen-devel] [PATCH 1/2] x86: decouple xen alignment setting from EFI/non-EFI build

2019-03-18 Thread Wei Liu
Introduce a new Kconfig option to pick the alignment for xen binary. To retain original behaviour, the default pick for EFI build is 2M and non-EFI build 4K. Signed-off-by: Wei Liu --- xen/arch/x86/Kconfig | 26 ++ xen/arch/x86/xen.lds.S | 16 ++-- 2 files

[Xen-devel] [PATCH 0/2] x86: more flexible alignment handling for xen binary

2019-03-18 Thread Wei Liu
Wei Liu (2): x86: decouple xen alignment setting from EFI/non-EFI build x86/pvshim: use 2M alignment xen/arch/x86/Kconfig | 26 ++ xen/arch/x86/configs/pvshim_defconfig | 1 + xen/arch/x86/xen.lds.S| 16 ++-- 3 files

Re: [Xen-devel] [PATCH 1/2] x86: decouple xen alignment setting from EFI/non-EFI build

2019-03-19 Thread Wei Liu
On Tue, Mar 19, 2019 at 04:45:35AM -0600, Jan Beulich wrote: > >>> On 18.03.19 at 15:57, wrote: > > Introduce a new Kconfig option to pick the alignment for xen binary. > > To retain original behaviour, the default pick for EFI build is 2M and > > non-EFI build 4K. > > Is this a worthwhile step t

[Xen-devel] [PATCH v2 0/2] x86: more flexible alignment handling for xen image

2019-03-19 Thread Wei Liu
Wei Liu (2): x86: decouple xen alignment setting from EFI/ELF build x86/pvshim: use 2M alignment xen/arch/x86/Kconfig | 23 +++ xen/arch/x86/configs/pvshim_defconfig | 1 + xen/arch/x86/xen.lds.S| 12 ++-- 3 files changed, 34

[Xen-devel] [PATCH v2 2/2] x86/pvshim: use 2M alignment

2019-03-19 Thread Wei Liu
The pvshim is loaded directly by toolstack. Use 2M alignment for potentially better performance. Signed-off-by: Wei Liu --- xen/arch/x86/configs/pvshim_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/arch/x86/configs/pvshim_defconfig b/xen/arch/x86/configs/pvshim_defconfig

[Xen-devel] [PATCH v2 1/2] x86: decouple xen alignment setting from EFI/ELF build

2019-03-19 Thread Wei Liu
Introduce a new Kconfig option to pick the alignment for xen binary. To retain original behaviour, the default pick for EFI build is 2M and ELF build 4K. Signed-off-by: Wei Liu --- xen/arch/x86/Kconfig | 23 +++ xen/arch/x86/xen.lds.S | 12 ++-- 2 files changed, 33

Re: [Xen-devel] [PATCH v2 1/2] x86: decouple xen alignment setting from EFI/ELF build

2019-03-19 Thread Wei Liu
On Tue, Mar 19, 2019 at 01:09:35PM +, Andrew Cooper wrote: > On 19/03/2019 13:05, Wei Liu wrote: > > @@ -20,13 +19,22 @@ ENTRY(efi_start) > > #else /* !EFI */ > > > > #define FORMAT "elf64-x86-64" > > -#define SECTION_ALIGN PAGE_SIZE

Re: [Xen-devel] [PATCH v2 2/2] x86/pvshim: use 2M alignment

2019-03-19 Thread Wei Liu
On Tue, Mar 19, 2019 at 07:42:56AM -0600, Jan Beulich wrote: > >>> On 19.03.19 at 14:05, wrote: > > --- a/xen/arch/x86/configs/pvshim_defconfig > > +++ b/xen/arch/x86/configs/pvshim_defconfig > > @@ -5,6 +5,7 @@ CONFIG_PVH_GUEST=y > > CONFIG_PV_SHIM=y > > CONFIG_PV_SHIM_EXCLUSIVE=y > > CONFIG_N

Re: [Xen-devel] [PATCH v2 1/2] x86: decouple xen alignment setting from EFI/ELF build

2019-03-19 Thread Wei Liu
On Tue, Mar 19, 2019 at 07:44:33AM -0600, Jan Beulich wrote: > >>> On 19.03.19 at 14:05, wrote: > > --- a/xen/arch/x86/Kconfig > > +++ b/xen/arch/x86/Kconfig > > @@ -138,6 +138,29 @@ config TBOOT > > > > If unsure, say Y. > > > > +choice > > + prompt "Alignment of Xen image" > > + de

[Xen-devel] [PATCH v3] x86: decouple xen alignment setting from EFI/ELF build

2019-03-19 Thread Wei Liu
Introduce a new Kconfig option to pick the alignment for xen binary. To retain original behaviour, the default pick for EFI build is 2M and ELF build 4K. Make the PVHSHIM build use 2M alignment for potentially better performance. Signed-off-by: Wei Liu --- xen/arch/x86/Kconfig | 23

[Xen-devel] [PATCH] x86: drop "depends on X86" for TBOOT Kconfig option

2019-03-19 Thread Wei Liu
Given that this file already resides under arch/x86, there is no need to have the dependency. Signed-off-by: Wei Liu --- xen/arch/x86/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig index 5c2d1070b6..76393fd23a 100644 --- a/xen/arch/x86

[Xen-devel] [PATCH] libxc: fix HVM core dump

2019-03-19 Thread Wei Liu
f969bc9fc96 forbid get_address_size call on HVM guests, because that didn't make sense. It broke core dump functionality on HVM because libxc unconditionally asked for guest width. Only issue the call when necessary in libxc. Reported-by: Igor Druzhinin Signed-off-by: Wei Liu --- Cc

Re: [Xen-devel] [PATCH 0/3] docs: User oriented documentation

2019-03-20 Thread Wei Liu
render ReStructuredText > docs/admin-guide: Boot time microcode loading I don't think these changes introduce new dependencies in the build. Assuming my observation is correct: Acked-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 0/3] docs: User oriented documentation

2019-03-20 Thread Wei Liu
On Wed, Mar 20, 2019 at 11:23:57AM +, Andrew Cooper wrote: > On 20/03/2019 11:20, Wei Liu wrote: > > On Tue, Mar 19, 2019 at 04:20:04PM +, Andrew Cooper wrote: > >> This is a project I've been musing over for a long time now, to try and > >> address

Re: [Xen-devel] [PATCH 0/3] docs: User oriented documentation

2019-03-20 Thread Wei Liu
On Wed, Mar 20, 2019 at 11:35:10AM +, Andrew Cooper wrote: > On 20/03/2019 11:28, Wei Liu wrote: > > On Wed, Mar 20, 2019 at 11:23:57AM +, Andrew Cooper wrote: > >> On 20/03/2019 11:20, Wei Liu wrote: > >>> On Tue, Mar 19, 2019 at 04:20:04PM +, Andrew

Re: [Xen-devel] [PATCH] libxc: fix HVM core dump

2019-03-20 Thread Wei Liu
On Wed, Mar 20, 2019 at 01:49:30PM +, Ian Jackson wrote: > Wei Liu writes ("[PATCH] libxc: fix HVM core dump"): > > f969bc9fc96 forbid get_address_size call on HVM guests, because that > > didn't make sense. It broke core dump functionality on HVM because >

[Xen-devel] [PATCH v2] libxc: fix HVM core dump

2019-03-20 Thread Wei Liu
f969bc9fc96 forbid get_address_size call on HVM guests, because that didn't make sense. It broke core dump functionality on HVM because libxc unconditionally asked for guest width. Force guest_width to a sensible value. Reported-by: Igor Druzhinin Signed-off-by: Wei Liu --- Cc: Ian Jackso

Re: [Xen-devel] [PATCH v2] libxc: fix HVM core dump

2019-03-20 Thread Wei Liu
On Wed, Mar 20, 2019 at 04:40:59PM +, Ian Jackson wrote: > Wei Liu writes ("[PATCH v2] libxc: fix HVM core dump"): > > f969bc9fc96 forbid get_address_size call on HVM guests, because that > > didn't make sense. It broke core dump functionality on HVM because >

Re: [Xen-devel] [PATCH] CI: Add a CentOS 6 container and build jobs

2019-03-25 Thread Wei Liu
ble ways to get Python 2.7 into a CentOS 6 > environments, so modify the build script to skip the Qemu upstream build > instead. > > Signed-off-by: Andrew Cooper Acked-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xenproject.org h

Re: [Xen-devel] [PATCH] CI: Fix indentation in containerize script

2019-03-25 Thread Wei Liu
On Fri, Mar 22, 2019 at 11:12:28AM +, Andrew Cooper wrote: > The script is mostly indented with spaces, but there are three tabs. Fix them > up to be consistent. > > No functional change. > > Signed-off-by: Andrew Cooper

Re: [Xen-devel] [PATCH] CI: Add a CentOS 6 container and build jobs

2019-03-25 Thread Wei Liu
On Mon, Mar 25, 2019 at 11:21:44AM +, Wei Liu wrote: > On Fri, Mar 22, 2019 at 11:13:40AM +, Andrew Cooper wrote: > > CentOS 6 is probably the most frequently broken build, so adding it to CI > > would be a very good move. > > > > One problem is that CentOS 6

Re: [Xen-devel] [PATCH] CI: Add a CentOS 6 container and build jobs

2019-03-26 Thread Wei Liu
On Mon, Mar 25, 2019 at 02:51:46PM +, Andrew Cooper wrote: > On 25/03/2019 11:33, Wei Liu wrote: > > On Mon, Mar 25, 2019 at 11:21:44AM +0000, Wei Liu wrote: > >> On Fri, Mar 22, 2019 at 11:13:40AM +, Andrew Cooper wrote: > >>> CentOS 6 is probably the mo

Re: [Xen-devel] python3 issues

2019-03-26 Thread Wei Liu
On Mon, Mar 25, 2019 at 10:20:05PM +, YOUNG, MICHAEL A. wrote: > I have been testing the python3 changes committed to xen and found a few > issues. There are a couple of ocaml python build scripts that don't work > for me with python3, and I needed a few fixes to get pygrub to work, > mostly

Re: [Xen-devel] python3 issues

2019-03-26 Thread Wei Liu
On Tue, Mar 26, 2019 at 01:16:35PM +, Wei Liu wrote: > On Mon, Mar 25, 2019 at 10:20:05PM +, YOUNG, MICHAEL A. wrote: > > if ty.init_fn is not None: > > --- xen-4.12.0-rc6/tools/pygrub/src/GrubConf.py.orig2019-03-24 > > 22:44:05.502581989 + &

Re: [Xen-devel] [PATCH v2] CI: Add a CentOS 6 container and build jobs

2019-03-26 Thread Wei Liu
ble ways to get Python 2.7 into a CentOS 6 > environments, so modify the build script to skip the Qemu upstream build > instead. Additionally, SeaBIOS requires GCC 4.6 or later, so skip it as well. > > Signed-off-by: Andrew Cooper Acked-by: Wei Liu __

Re: [Xen-devel] python3 issues

2019-04-01 Thread Wei Liu
On Tue, Mar 26, 2019 at 10:06:48PM +0100, Hans van Kranenburg wrote: > On 3/26/19 7:18 PM, M A Young wrote: > > On Tue, 26 Mar 2019, Wei Liu wrote: > > > >> On Tue, Mar 26, 2019 at 01:16:35PM +, Wei Liu wrote: > >>> On Mon, Mar 25, 2019 at 10:20

Re: [Xen-devel] [PATCH for-next 0/5] automation: test to build each commit in a branch

2019-04-01 Thread Wei Liu
Ping? On Thu, Feb 28, 2019 at 01:44:43PM +, Wei Liu wrote: > We have a requirement to make each commit buildable in xen.git. Put this > into a test in Gitlab CI. > > Wei Liu (5): > automation: allow build-test.sh to run in detached HEAD state > automation: set ret for

Re: [Xen-devel] python3 issues

2019-04-01 Thread Wei Liu
On Tue, Mar 26, 2019 at 10:06:48PM +0100, Hans van Kranenburg wrote: > > Python 3 no longer allows comparing string and int, because it doesn't > make sense. > > == sorted([1,2,3,'a','b','c']) > Traceback (most recent call last): > File "", line 1, in > TypeError: unorderable types: str() < in

Re: [Xen-devel] python3 issues

2019-04-01 Thread Wei Liu
On Mon, Apr 01, 2019 at 10:59:05AM +0100, M A Young wrote: > > > On Mon, 1 Apr 2019, Wei Liu wrote: > > > On Tue, Mar 26, 2019 at 10:06:48PM +0100, Hans van Kranenburg wrote: > > > > > > Python 3 no longer allows comparing string and int,

Re: [Xen-devel] python3 issues

2019-04-01 Thread Wei Liu
On Wed, Mar 27, 2019 at 01:36:10AM +0100, Hans van Kranenburg wrote: > On 3/26/19 2:16 PM, Wei Liu wrote: > > On Mon, Mar 25, 2019 at 10:20:05PM +, YOUNG, MICHAEL A. wrote: > >> [...] > >> --- xen-4.12.0-rc6/tools/pygrub/src/pygrub.orig2019-03-24 > >> 2

[Xen-devel] [PATCH 4/4] tools/ocaml: make python scripts 2 and 3 compatible

2019-04-01 Thread Wei Liu
1. Explicitly import reduce because that's required in 3. 2. Change print to function. 3. Eliminate invocations of has_key. Signed-off-by: M A Young Signed-off-by: Wei Liu --- tools/ocaml/libs/xentoollog/genlevels.py | 5 - tools/ocaml/libs/xl/genwrap.py

<    1   2   3   4   5   6   7   8   9   10   >