hange,
> to avoid getting stuck forever in wait_event().
>
> Signed-off-by: Andrea Righi
> ---
> Changes in v2:
> - remove all dev_dbg() calls (as suggested by David Miller)
Applied, thank you.
From: Andrea Righi
Date: Wed, 22 Jul 2020 08:52:11 +0200
> +static int xennet_remove(struct xenbus_device *dev)
> +{
> + struct netfront_info *info = dev_get_drvdata(&dev->dev);
> +
> + dev_dbg(&dev->dev, "%s\n", dev->nodename);
These kinds of debugging messages provide zero context and
From: Colin King
Date: Thu, 2 Jul 2020 15:22:23 +0100
> From: Colin Ian King
>
> The variable act is being initialized with a value that is
> never read and it is being updated later with a new value. The
> initialization is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value
From: Sergey Dyasli
Date: Fri, 7 Feb 2020 14:26:52 +
> From: Ross Lagerwall
>
> When KASAN (or SLUB_DEBUG) is turned on, there is a higher chance that
> non-power-of-two allocations are not aligned to the next power of 2 of
> the size. Therefore, handle grant copies that cross page boundari
From: madhuparnabhowmi...@gmail.com
Date: Wed, 15 Jan 2020 21:25:53 +0530
> From: Madhuparna Bhowmik
>
> list_for_each_entry_rcu has built-in RCU and lock checking.
> Pass cond argument to list_for_each_entry_rcu.
>
> Signed-off-by: Madhuparna Bhowmik
Applied to net-next.
___
From: Paul Durrant
Date: Mon, 23 Dec 2019 09:59:23 +
> By re-attaching RX, TX, and CTL rings during connect() rather than
> assuming they are freshly allocated (i.e. assuming the counters are zero),
> and avoiding forcing state to Closed in netback_remove() it is possible
> for vif instances
From: Paul Durrant
Date: Tue, 17 Dec 2019 13:32:18 +
> Removing the 'hotplug-status' node in netback_remove() is wrong; the script
> may not have completed. Only remove the node once the watch has fired and
> has been unregistered.
>
> Signed-off-by: Paul Durrant
Applied.
From: Paul Durrant
Date: Tue, 17 Dec 2019 13:32:17 +
> ...as the comment above the function states.
>
> The switch to Initialising at the start of the function is somewhat bogus
> as the toolstack will have set that initial state anyway. To behave
> correctly, a backend should switch to Init
From: Paul Durrant
Date: Tue, 17 Dec 2019 13:32:16 +
> ...of xenbus.c
>
> This is a cosmetic function re-ordering to reduce churn in a subsequent
> patch. Some style fix-up was done to make checkpatch.pl happier.
>
> No functional change.
>
> Signed-off-by: Paul Durrant
Applied.
___
From: Paul Durrant
Date: Thu, 12 Dec 2019 13:54:06 +
> In the past it used to be the case that the Xen toolstack relied upon
> udev to execute backend hotplug scripts. However this has not been the
> case for many releases now and removal of the associated code in
> xen-netback shortens the s
From: Paul Durrant
Date: Thu, 12 Dec 2019 12:37:23 +
> Commit 2ac061ce97f4 ("xen/netback: cleanup init and deinit code")
> introduced a problem. In function xenvif_disconnect_queue(), the value of
> queue->rx_irq is zeroed *before* queue->task is stopped. Unfortunately that
> task may call no
From: Juergen Gross
Date: Fri, 18 Oct 2019 09:45:49 +0200
> xenvif_connect_data() calls module_put() in case of error. This is
> wrong as there is no related module_get().
>
> Remove the superfluous module_put().
>
> Fixes: 279f438e36c0a7 ("xen-netback: Don't destroy the netdev until the vif
>
From: Juergen Gross
Date: Mon, 14 Oct 2019 11:09:08 +0200
> One bugfix (patch 1) I stumbled over while doing a cleanup (patch 2)
> of the xen-netback init/deinit code.
Please do not mix cleanups and genuine bug fixes.
Submit the bug fix targetting the 'net' GIT tree, and once that eventually
ge
From: Dongli Zhang
Date: Tue, 1 Oct 2019 21:56:41 +0800
> xennet_fill_frags() uses ~0U as return value when the sk_buff is not able
> to cache extra fragments. This is incorrect because the return type of
> xennet_fill_frags() is RING_IDX and 0x is an expected value for
> ring buffer ind
From: Dongli Zhang
Date: Mon, 16 Sep 2019 11:46:59 +0800
> When skb_shinfo(skb) is not able to cache extra fragment (that is,
> skb_shinfo(skb)->nr_frags >= MAX_SKB_FRAGS), xennet_fill_frags() assumes
> the sk_buff_head list is already empty. As a result, cons is increased only
> by 1 and returns
From: Paul Durrant
Date: Fri, 13 Sep 2019 13:47:27 +0100
> My Citrix email address will expire shortly.
>
> Signed-off-by: Paul Durrant
Applied.
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/
From: Greg Kroah-Hartman
Date: Sat, 10 Aug 2019 12:31:08 +0200
> When calling debugfs functions, there is no need to ever check the
> return value. The function can work or not, but the code logic should
> never do something different based on this.
>
> Cc: Wei Liu
> Cc: Paul Durrant
> Cc: xe
From: Ross Lagerwall
Date: Mon, 5 Aug 2019 16:34:34 +0100
> At this point nr_frags has been incremented but the frag does not yet
> have a page assigned so freeing the skb results in a crash. Reset
> nr_frags before freeing the skb to prevent this.
>
> Signed-off-by: Ross Lagerwall
Applied and
From: Wei Liu
Date: Fri, 31 May 2019 08:31:02 +0100
> Signed-off-by: Wei Liu
Applied.
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
From: Colin King
Date: Thu, 30 May 2019 20:04:38 +0100
> From: Colin Ian King
>
> The variable err is assigned with the value -ENOMEM that is never
> read and it is re-assigned a new value later on. The assignment is
> redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> S
From: "Gustavo A. R. Silva"
Date: Mon, 15 Apr 2019 16:11:41 -0500
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
>
> This patch fixes the following warning:
>
> drivers/net/xen-netfront.c: In function ‘netback_changed’:
> drivers
From: Dongli Zhang
Date: Fri, 12 Apr 2019 14:53:24 +0800
> During coredump analysis, it is not easy to obtain the address of
> backend_info in xen-netback.
>
> So far there are two ways to obtain backend_info:
>
> 1. Do what xenbus_device_find() does for vmcore to find the xenbus_device
> and t
From: Igor Druzhinin
Date: Thu, 28 Feb 2019 14:11:26 +
> Occasionally, during the disconnection procedure on XenBus which
> includes hash cache deinitialization there might be some packets
> still in-flight on other processors. Handling of these packets includes
> hashing and hash cache popul
From: Igor Druzhinin
Date: Thu, 28 Feb 2019 12:48:03 +
> Zero-copy callback flag is not yet set on frag list skb at the moment
> xenvif_handle_frag_list() returns -ENOMEM. This eventually results in
> leaking grant ref mappings since xenvif_zerocopy_callback() is never
> called for these frag
From: "Gustavo A. R. Silva"
Date: Fri, 8 Feb 2019 13:58:38 -0600
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> This patch is part of the ongoing efforts to enabling
> -W
From: Mike Rapoport
Date: Wed, 16 Jan 2019 15:44:15 +0200
> Add panic() calls if memblock_alloc*() returns NULL.
>
> Most of the changes are simply addition of
>
> if(!ptr)
> panic();
>
> statements after the calls to memblock_alloc*() variants.
>
> Exceptions are pcpu
From: Juergen Gross
Date: Tue, 18 Dec 2018 16:06:19 +0100
> At least old Xen net backends seem to send frags with no real data
> sometimes. In case such a fragment happens to occur with the frag limit
> already reached the frontend will BUG currently even if this situation
> is easily recoverable
From: Yangtao Li
Date: Mon, 10 Dec 2018 10:53:29 -0500
> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
>
> Signed-off-by: Yangtao Li
Applied.
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/list
From: Linus Torvalds
Date: Wed, 28 Nov 2018 10:00:06 -0800
> Not all memory is accessible even to the kernel. If you have memory
> that shows up in the last page of phys_addr_t, you just mark it
> reserved at boot-time.
It's not the physical memory at the end that needs to be reserved.
It's the
From: Jacob Wen
Date: Fri, 9 Nov 2018 14:53:59 +0800
> RING_PUSH_REQUESTS_AND_CHECK_NOTIFY is already able to make sure backend sees
> requests before req_prod is updated.
>
> Signed-off-by: Jacob Wen
Applied to net-next.
___
Xen-devel mailing list
From: YueHaibing
Date: Wed, 26 Sep 2018 17:18:14 +0800
> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
> which is a typedef for an enum type, so make sure the implementation in
> this driver has returns 'netdev_tx_t' value, and change the function
> return type to netdev_t
From: "Jan Beulich"
Date: Tue, 25 Sep 2018 02:11:33 -0600
> First and foremost the fix for XSA-270. On top of that further changes
> which looked desirable to me while investigating that XSA.
>
> 1: fix input validation in xenvif_set_hash_mapping()
> 2: validate queue numbers in xenvif_set_hash_
From: "Jan Beulich"
Date: Mon, 24 Sep 2018 01:43:50 -0600
On 11.09.18 at 12:16, wrote:
>> On Tue, Sep 11, 2018 at 02:12:07AM -0600, Jan Beulich wrote:
>>> >>> On 28.08.18 at 16:54, wrote:
>>> > First and foremost the fix for XSA-270. On top of that further changes
>>> > which looked desira
From: YueHaibing
Date: Thu, 20 Sep 2018 20:32:44 +0800
> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
> which is a typedef for an enum type, so make sure the implementation in
> this driver has returns 'netdev_tx_t' value, and change the function
> return type to netdev_t
From: Juergen Gross
Date: Tue, 11 Sep 2018 09:04:48 +0200
> Commit 57f230ab04d291 ("xen/netfront: raise max number of slots in
> xennet_get_responses()") raised the max number of allowed slots by one.
> This seems to be problematic in some configurations with netback using
> a larger MAX_SKB_FRAG
From: zhong jiang
Date: Sat, 8 Sep 2018 21:53:42 +0800
> debugfs_remove_recursive has taken IS_ERR_OR_NULL into account. So just
> remove the condition check before debugfs_remove_recursive.
>
> Signed-off-by: zhong jiang
Applied to net-next.
___
Xe
From: zhong jiang
Date: Sat, 8 Sep 2018 21:35:06 +0800
> debugfs_remove_recursive has taken the IS_ERR_OR_NULL into account. Just
> remove the unnecessary condition check.
>
> Signed-off-by: zhong jiang
Applied to net-next.
___
Xen-devel mailing lis
From: Juergen Gross
Date: Fri, 7 Sep 2018 14:21:30 +0200
> Commit 822fb18a82aba ("xen-netfront: wait xenbus state change when load
> module manually") added a new wait queue to wait on for a state change
> when the module is loaded manually. Unfortunately there is no wakeup
> anywhere to stop th
From: Xiao Liang
Date: Tue, 14 Aug 2018 23:21:28 +0800
> There is a call trace generated after commit
> 2d408c0d4574b01b9ed45e02516888bf925e11a9(
> xen-netfront: fix queue name setting). There is no 'device/vif/xx-q0-tx' file
> found
> under /proc/irq/xx/.
>
> This patch only picks up device t
From: Xiao Liang
Date: Sat, 11 Aug 2018 23:21:37 +0800
> There is a call trace generated after commit
> 2d408c0d4574b01b9ed45e02516888bf925e11a9(
> xen-netfront: fix queue name setting). There is no 'device/vif/xx-q0-tx' file
> found
> under /proc/irq/xx/.
>
> This patch only picks up device t
From: Juergen Gross
Date: Thu, 9 Aug 2018 16:42:16 +0200
> skb_shinfo() can change when calling __pskb_pull_tail(): Don't cache
> its return value.
>
> Cc: sta...@vger.kernel.org
> Signed-off-by: Juergen Gross
Applied.
___
Xen-devel mailing list
Xe
From: "Gustavo A. R. Silva"
Date: Wed, 1 Aug 2018 19:31:01 -0500
> Return statements in functions returning bool should use true or false
> instead of an integer value.
>
> This issue was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva
Applied.
__
From: Xiao Liang
Date: Fri, 27 Jul 2018 17:56:08 +0800
> When loading module manually, after call xenbus_switch_state to initializes
> the state of the netfront device, the driver state did not change so fast
> that may lead no dev created in latest kernel. This patch adds wait to make
> sure xen
From: Xiao Liang
Date: Fri, 27 Jul 2018 17:56:08 +0800
> @@ -1330,6 +1331,11 @@ static struct net_device *xennet_create_dev(struct
> xenbus_device *dev)
> netif_carrier_off(netdev);
>
> xenbus_switch_state(dev, XenbusStateInitialising);
> + wait_event(module_load_q,
> +
From: Vitaly Kuznetsov
Date: Fri, 20 Jul 2018 18:33:59 +0200
> Commit f599c64fdf7d ("xen-netfront: Fix race between device setup and
> open") changed the initialization order: xennet_create_queues() now
> happens before we do register_netdev() so using netdev->name in
> xennet_init_queue() is inc
From: Ross Lagerwall
Date: Thu, 21 Jun 2018 14:00:19 +0100
> Fix a couple of issues with commit f599c64fdf7d ("xen-netfront: Fix race
> between device setup and open").
Series applied and queued up for -stable.
___
Xen-devel mailing list
Xen-devel@lis
From: Juergen Gross
Date: Tue, 12 Jun 2018 08:57:53 +0200
> The max number of slots used in xennet_get_responses() is set to
> MAX_SKB_FRAGS + (rx->status <= RX_COPY_THRESHOLD).
>
> In old kernel-xen MAX_SKB_FRAGS was 18, while nowadays it is 17. This
> difference is resulting in frequent messag
From: Dongli Zhang
Date: Wed, 28 Mar 2018 07:42:16 +0800
> The "BUG_ON(!frag_iter)" in function xenvif_rx_next_chunk() is triggered if
> the received sk_buff is malformed, that is, when the sk_buff has pattern
> (skb->data_len && !skb_shinfo(skb)->nr_frags). Below is a sample call
> stack:
We sh
From: Joe Perches
Date: Fri, 23 Mar 2018 15:54:39 -0700
> Prefer the direct use of octal for permissions.
>
> Done with checkpatch -f --types=SYMBOLIC_PERMS --fix-inplace
> and some typing.
>
> Miscellanea:
>
> o Whitespace neatening around these conversions.
>
> Signed-off-by: Joe Perches
From: Colin King
Date: Fri, 23 Feb 2018 17:16:57 +
> From: Colin Ian King
>
> The function xenvif_rx_skb is local to the source and does not need
> to be in global scope, so make it static.
>
> Cleans up sparse warning:
> drivers/net/xen-netback/rx.c:422:6: warning: symbol 'xenvif_rx_skb'
From: Ross Lagerwall
Date: Thu, 11 Jan 2018 16:27:20 +
> On 01/11/2018 04:08 PM, David Miller wrote:
>> From: Ross Lagerwall
>> Date: Thu, 11 Jan 2018 15:49:07 +
>>
>>> I've now added CC'd netdev on the other two.
>> That doesn't wor
From: Ross Lagerwall
Date: Thu, 11 Jan 2018 15:49:07 +
> I've now added CC'd netdev on the other two.
That doesn't work.
If you don't post the originals explicitly to netdev then it won't
get properly queued in patchwork.
___
Xen-devel mailing li
From: Ross Lagerwall
Date: Thu, 11 Jan 2018 09:36:38 +
> When a netfront device is set up it registers a netdev fairly early on,
> before it has set up the queues and is actually usable. A userspace tool
> like NetworkManager will immediately try to open it and access its state
> as soon as i
From: Eduardo Otubo
Date: Fri, 5 Jan 2018 09:42:16 +0100
> When loading the module after unloading it, the network interface would
> not be enabled and thus wouldn't have a backend counterpart and unable
> to be used by the guest.
>
> The guest would face errors like:
>
> [root@guest ~]# eth
From: Joao Martins
Date: Thu, 21 Dec 2017 17:24:28 +
> Commit eb1723a29b9a ("xen-netback: refactor guest rx") refactored Rx
> handling and as a result decreased max grant copy ops from 4352 to 64.
> Before this commit it would drain the rx_queue (while there are
> enough slots in the ring to
From: Joe Perches
Date: Tue, 5 Dec 2017 22:40:25 -0800
> Using a period after a newline causes bad output.
>
> Signed-off-by: Joe Perches
Applied.
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listin
From: Eduardo Otubo
Date: Thu, 23 Nov 2017 15:18:35 +0100
> v2:
> * Replace busy wait with wait_event()/wake_up_all()
> * Cannot garantee that at the time xennet_remove is called, the
>xen_netback state will not be XenbusStateClosed, so added a
>condition for that
> * There's a small c
57 matches
Mail list logo