Re: [Xen-devel] [PATCH v3 09/15] argo: implement the sendv op; evtchn: expose send_guest_global_virq

2019-01-10 Thread Eric Chanudet
evious mask, shouldn't the sanity check be: if (len + offset > XEN_ARGO_MAX_RING_SIZE) -- Eric Chanudet ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v3 07/15] argo: implement the register op

2019-01-10 Thread Eric Chanudet
<10 somewhere or is it a typo in the comment? -- Eric Chanudet ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v3 04/15] argo: init, destroy and soft-reset, with enable command line opt

2019-01-10 Thread Eric Chanudet
On 06/01/19 at 11:42pm, Christopher Clark wrote: +partner_rings_remove(struct domain *src_d) +ring_info = ring_find_info(dst_d, _info->id); ring_find_info is defined later (PATCH 07/15), should it be moved to this patch since it is now used here? -- Eric Chanu