Re: [Discussion]: Making "LIBXL_HOTPLUG_TIMEOUT" configurable through 'xl.conf'

2023-11-24 Thread Jim Fehlig
On 11/24/23 06:04, Olaf Hering wrote: Fri, 24 Nov 2023 13:47:53 +0100 Juergen Gross : As Olaf has said already: this wouldn't cover actions e.g. by libvirt. Jim pointed me to /etc/libvirt/libxl.conf. So from this perspective both xl and libvirt is covered. Now it just takes someone to impleme

Re: vnuma_nodes missing pnode 0

2022-11-14 Thread Jim Fehlig
On 11/14/22 10:56, Anthony PERARD wrote: On Mon, Nov 14, 2022 at 08:53:17AM -0700, Jim Fehlig wrote: On 11/14/22 01:18, Jan Beulich wrote: On 14.11.2022 07:43, Henry Wang wrote: Sorry, missed Anthony (The toolstack maintainer). Also added him to this thread. Indeed there's nothing x8

Re: vnuma_nodes missing pnode 0

2022-11-14 Thread Jim Fehlig
On 11/14/22 01:18, Jan Beulich wrote: On 14.11.2022 07:43, Henry Wang wrote: Sorry, missed Anthony (The toolstack maintainer). Also added him to this thread. Indeed there's nothing x86-ish in here, it's all about data representation. It merely happens to be (for now) x86-specific data which is

vnuma_nodes missing pnode 0

2022-11-11 Thread Jim Fehlig
Hi All, While fixing [1] a recent downstream libvirt build failure against 4.17 rc3, I noticed the json representation of libxl_vnode_info omits pnode when value is 0. The problem can be seen by starting a VM containing the following vnuma config vnuma = [ [ "pnode=0", "size=2048", "vcpus=0",

Re: [PATCH 00/14] deprecations: remove many old deprecations

2021-02-25 Thread Jim Fehlig
Adding xen-devel and Ian to cc. On 2/24/21 6:11 AM, Daniel P. Berrangé wrote: The following features have been deprecated for well over the 2 release cycle we promise This reminded me of a bug report we received late last year when updating to 5.2.0. 'virsh setvcpus' suddenly stopped working

Re: [PATCH] OSSTEST: Install libtirpc-dev for libvirt builds

2020-08-10 Thread Jim Fehlig
On 8/10/20 4:13 AM, Ian Jackson wrote: Jim Fehlig writes ("[PATCH] OSSTEST: Install libtirpc-dev for libvirt builds"): The check for XDR support was changed in libvirt commit d7147b3797 to use libtirpc pkg-config instead of complicated AC_CHECK_LIB, AC_COMPILE_IFELSE, et. al. logic. T

Re: [libvirt test] 151910: regressions - FAIL

2020-07-23 Thread Jim Fehlig
On 7/15/20 1:53 PM, Jim Fehlig wrote: On 7/15/20 9:07 AM, osstest service owner wrote: flight 151910 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/151910/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run:   build-amd64

[PATCH] OSSTEST: Install libtirpc-dev for libvirt builds

2020-07-23 Thread Jim Fehlig
'extra_packages' installed for libvirt builds. Signed-off-by: Jim Fehlig --- I *think* this change will work for older libvirt branches too. The old, hand-coded m4 logic should work with libtirpc-dev installed. Osstest/Toolstack/libvirt.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletio

Re: [libvirt test] 151910: regressions - FAIL

2020-07-15 Thread Jim Fehlig
On 7/15/20 9:07 AM, osstest service owner wrote: flight 151910 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/151910/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build

Re: [libvirt test] 149773: regressions - FAIL

2020-06-04 Thread Jim Fehlig
On 6/4/20 6:51 AM, Ian Jackson wrote: Jim Fehlig writes ("Re: [libvirt test] 149773: regressions - FAIL"): On 4/24/20 3:53 AM, osstest service owner wrote: flight 149773 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/149773/ Regressions :-( Tests which did n

Re: [libvirt test] 149773: regressions - FAIL

2020-04-24 Thread Jim Fehlig
On 4/24/20 3:53 AM, osstest service owner wrote: flight 149773 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/149773/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build

Re: [Xen-devel] [PATCH] Revert "domctl: improve locking during domain destruction"

2020-03-26 Thread Jim Fehlig
On 3/25/20 1:11 AM, Jan Beulich wrote: On 24.03.2020 19:39, Julien Grall wrote: On 24/03/2020 16:13, Jan Beulich wrote: On 24.03.2020 16:21, Hongyan Xia wrote: From: Hongyan Xia In contrast, after dropping that commit, parallel domain destructions will just fail to take the domctl lock, creat

Re: [Xen-devel] [OSSTEST PATCH V2] build: fix configuration of libvirt

2020-02-17 Thread Jim Fehlig
On 2/14/20 10:47 AM, Ian Jackson wrote: Jim Fehlig writes ("[OSSTEST PATCH V2] build: fix configuration of libvirt"): libvirt.git commit 2621d48f00 removed the last traces of gnulib, which also removed the '--no-git' option from autogen.sh. Unknown options are now passed to

[Xen-devel] [OSSTEST PATCH V2] build: fix configuration of libvirt

2020-02-14 Thread Jim Fehlig
andling from ts-libvirt-build, including the '--no-git' option to autogen.sh. While at it remove configure options no longer supported by the libvirt configure script. Signed-off-by: Jim Fehlig --- The only change from V1 is adding Ian to cc. I have poor perl skills, but hopefully th

[Xen-devel] [OSSTEST PATCH] build: fix configuration of libvirt

2020-02-12 Thread Jim Fehlig
andling from ts-libvirt-build, including the '--no-git' option to autogen.sh. While at it remove configure options no longer supported by the libvirt configure script. Signed-off-by: Jim Fehlig --- I have poor perl skills, but hopefully this fixes the latest build failures of the libvirt

Re: [Xen-devel] libvirt support for scheduler credit2

2020-01-29 Thread Jim Fehlig
On 1/29/20 4:10 AM, Dario Faggioli wrote: > On Wed, 2020-01-22 at 18:56 +0000, Jim Fehlig wrote: >> On 1/21/20 10:05 AM, Jürgen Groß wrote: >>> On 21.01.20 17:56, Kevin Stange wrote: >>>> >>>> Since Xen 4.12, credit2 is the default scheduler, but at

Re: [Xen-devel] libvirt support for scheduler credit2

2020-01-22 Thread Jim Fehlig
On 1/21/20 10:05 AM, Jürgen Groß wrote: > On 21.01.20 17:56, Kevin Stange wrote: >> Hi, >> >> I looked around a bit and wasn't able to find a good answer to this, so >> George suggested I ask here. > > Cc-ing Jim. > >> >> Since Xen 4.12, credit2 is the default scheduler, but at least as of >> lib

Re: [Xen-devel] [XEN PATCH for-4.13 v2 1/9] libxl: Offer API versions 0x040700 and 0x040800

2019-11-25 Thread Jim Fehlig
On 10/10/19 9:11 AM, Ian Jackson wrote: > According to git log -G: > > 0x040700 was introduced in 304400459ef0 (aka 4.7.0-rc1~481) >"tools/libxl: rename remus device to checkpoint device" > > 0x040800 was introduced in 57f8b13c7240 (aka 4.8.0-rc1~437) >"libxl: memory size in kb requires 6

Re: [Xen-devel] [OSSTEST PATCH 2/2] ts-libvirt-build: Do an out-of-tree build

2019-11-12 Thread Jim Fehlig
On 11/12/19 9:10 AM, Ian Jackson wrote: > Hi. Thanks for the information. > > Jim Fehlig writes ("Re: [OSSTEST PATCH 2/2] ts-libvirt-build: Do an > out-of-tree build"): >> I assumed libvirt's gradual move from autotools to meson would >> affect OSSTEST,

Re: [Xen-devel] [OSSTEST PATCH 2/2] ts-libvirt-build: Do an out-of-tree build

2019-11-12 Thread Jim Fehlig
de541bfc575 >cpu_map: Ship arm_features.xml > > I also tested that a test job, built with current libvirt and these > osstest changes, passes as expected. > > CC: Jim Fehlig > Signed-off-by: Ian Jackson > Tested-by: Ian Jackson > --- > ts-libvirt-build | 12 +

Re: [Xen-devel] [OSSTEST PATCH 1/2] ts-libvirt-build: Provide PKG_CONFIG_PATH

2019-11-12 Thread Jim Fehlig
osstest build script run via ssh to the build host, > so the variables won't have been set already.) > > CC: Jim Fehlig > Signed-off-by: Ian Jackson > --- > ts-libvirt-build | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/ts-libvirt-build b/ts-libvirt

Re: [Xen-devel] [libvirt test] 140186: regressions - FAIL

2019-08-16 Thread Jim Fehlig
On 8/16/19 7:01 AM, osstest service owner wrote: > flight 140186 libvirt real [real] > http://logs.test-lab.xenproject.org/osstest/logs/140186/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: > build-amd64-libvirt 6 libvi

Re: [Xen-devel] [libvirt] domXML modeling question

2019-03-04 Thread Jim Fehlig
Adding xen-devel to cc in case anyone there wants to comment on my latest proposal... On 2/20/19 5:20 PM, Jim Fehlig wrote: There have been a few requests [1][2] to support Xen's max_grant_frames setting in libvirt domXML, but I'm not quite sure how to model it. The documentation [3

Re: [Xen-devel] [OSSTEST PATCH v2] ts-xen-build-prep: install libgnutls28-dev for libvirt build

2018-09-24 Thread Jim Fehlig
On 9/24/18 3:49 AM, Wei Liu wrote: d54ecf31b2 placed the build dependency in a wrong file. This patch adds the dependency to the right file. Add a runtime dependency in libvirt.pm. Thanks for fixing my fix :-). Regards, Jim Signed-off-by: Wei Liu --- Cc: Jim Fehlig --- Osstest

Re: [Xen-devel] virsh support?

2018-09-14 Thread Jim Fehlig
On 9/14/18 8:08 AM, Dag Nygren wrote: Hi! Can someone inform me on XEN vtpm support in libvirt? From which version if so? FYI, questions regarding libvirt are better directed to libvirt-l...@redhat.com Asking because I tried to do a "virh dumpxml" on a XEN machine with vtpm attached and "xl

Re: [Xen-devel] [xen-4.9-testing test] 126201: regressions - FAIL

2018-09-11 Thread Jim Fehlig
On 9/5/18 3:37 PM, Jim Fehlig wrote: On 08/24/2018 02:58 AM, Wei Liu wrote: On Wed, Aug 22, 2018 at 04:52:27PM -0600, Jim Fehlig wrote: On 08/21/2018 05:14 AM, Jan Beulich wrote: On 21.08.18 at 03:11, wrote: flight 126201 xen-4.9-testing real [real] http://logs.test-lab.xenproject.org

[Xen-devel] [PATCH OSSTEST] Install GnuTLS for libvirt builds

2018-09-05 Thread Jim Fehlig
Since libvirt commit 60d9ad6f GnuTLS is required to build libvirt. The various libvirt build tests in osstest began failing after the commit hit libvirt.git master. Adding libgnutls28-dev to the list of packages needed to build libvirt will fix the currently broken builds. Signed-off-by: Jim

Re: [Xen-devel] [xen-4.9-testing test] 126201: regressions - FAIL

2018-09-05 Thread Jim Fehlig
On 08/24/2018 02:58 AM, Wei Liu wrote: On Wed, Aug 22, 2018 at 04:52:27PM -0600, Jim Fehlig wrote: On 08/21/2018 05:14 AM, Jan Beulich wrote: On 21.08.18 at 03:11, wrote: flight 126201 xen-4.9-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/126201/ Regressions

[Xen-devel] [PATCH 4/5] libxl: fix job handling across migration phases on dst

2018-09-05 Thread Jim Fehlig
job for the incoming VM in the prepare phase and end the job in the finish phase. Signed-off-by: Jim Fehlig --- src/libxl/libxl_driver.c| 7 src/libxl/libxl_migration.c | 65 +++-- 2 files changed, 40 insertions(+), 32 deletions(-) diff --git a/src/libxl

[Xen-devel] [PATCH 5/5] libxl: join with thread receiving migration data

2018-09-05 Thread Jim Fehlig
It is possible the incoming VM is not fully started when the finish phase of migration is executed. In libxlDomainMigrationDstFinish, wait for the thread receiving the VM to complete before executing finish phase tasks. Signed-off-by: Jim Fehlig --- src/libxl/libxl_domain.h| 1 + src/libxl

[Xen-devel] [PATCH 1/5] libxl: migration: defer removing VM until finish phase

2018-09-05 Thread Jim Fehlig
until the finish phase, which already contains logic to remove the VM. Signed-off-by: Jim Fehlig --- src/libxl/libxl_migration.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/libxl/libxl_migration.c b/src/libxl/libxl_migration.c index b2e5847c58..97f72d0390

[Xen-devel] [PATCH 3/5] libxl: fix job handling across migration phases on src

2018-09-05 Thread Jim Fehlig
successful begin phase, and end the job in the confirm phase. The job must also end in the perform phase in the case of error since confirm phase would not be executed. Signed-off-by: Jim Fehlig --- src/libxl/libxl_migration.c | 26 +- 1 file changed, 25 insertions(+), 1

[Xen-devel] [PATCH 2/5] libxl: fix logic in P2P migration

2018-09-05 Thread Jim Fehlig
begin and perform. Skip the confirm phase if begin or perform fail. Signed-off-by: Jim Fehlig --- src/libxl/libxl_migration.c | 48 ++--- 1 file changed, 29 insertions(+), 19 deletions(-) diff --git a/src/libxl/libxl_migration.c b/src/libxl/libxl_migration.c index

[Xen-devel] [PATCH 0/5] libxl: various migration V3 improvements

2018-09-05 Thread Jim Fehlig
VM was not handled properly across the phases on either src or dst host. Patches 1-4 fix this and other problems found along the way. Jim Fehlig (5): libxl: migration: defer removing VM until finish phase libxl: fix logic in P2P migration libxl: fix job handling across migration phases on src

Re: [Xen-devel] [libvirt test] 126429: regressions - FAIL

2018-08-24 Thread Jim Fehlig
On 08/24/2018 04:48 AM, Wei Liu wrote: On Fri, Aug 24, 2018 at 10:25:49AM +, osstest service owner wrote: flight 126429 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/126429/ Regressions :-( Tests which did not succeed and are blocking, including tests which could no

Re: [Xen-devel] [xen-4.9-testing test] 126201: regressions - FAIL

2018-08-22 Thread Jim Fehlig
On 08/21/2018 05:14 AM, Jan Beulich wrote: On 21.08.18 at 03:11, wrote: flight 126201 xen-4.9-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/126201/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-l

[Xen-devel] [OSSTEST] Install GnuTLS for libvirt builds

2018-07-30 Thread Jim Fehlig
Since libvirt commit 60d9ad6f GnuTLS is required to build libvirt. The various libvirt build tests in osstest began failing after the commit hit libvirt.git master. Adding libgnutls28-dev to the list of packages needed to build libvirt will fix the currently broken builds. Signed-off-by: Jim

Re: [Xen-devel] libvirtd hang on CentOS6 after latest updates

2018-07-25 Thread Jim Fehlig
On 07/25/2018 10:17 AM, George Dunlap wrote: On Wed, Jul 25, 2018 at 4:42 PM, Jim Fehlig wrote: On 07/22/2018 04:03 PM, Karel Hendrych wrote: Hi, I am seeing frequent libvirtd hangs (clients not responding) after last CentOS6-Xen update : xen-devel is not the best place to seek help with

Re: [Xen-devel] libvirtd hang on CentOS6 after latest updates

2018-07-25 Thread Jim Fehlig
On 07/22/2018 04:03 PM, Karel Hendrych wrote: Hi, I am seeing frequent libvirtd hangs (clients not responding) after last CentOS6-Xen update : xen-devel is not the best place to seek help with downstream issues, particularly libvirt ones :-). You would have better luck contacting the CentOS6

Re: [Xen-devel] [xen-4.8-testing test] 124100: regressions - FAIL

2018-07-16 Thread Jim Fehlig
On 06/13/2018 05:18 AM, Ian Jackson wrote: Jim: please read down to where I discuss test-amd64-amd64-libvirt-pair. If you have any insight I'd appreciate it. Let me know if you want me to preserve the logs, which will otherwise expire in a few weeks. Whoa, sorry for the delay. This mail found

Re: [Xen-devel] Likely build race, "/usr/bin/ld: cannot find -lvirt"

2018-05-24 Thread Jim Fehlig
On 05/24/2018 04:27 AM, Ian Jackson wrote: Ian Jackson writes ("Likely build race, "/usr/bin/ld: cannot find -lvirt""): tl;dr: I think there is a bug in libvirt's build system which, with low probability, causes a build failure containing this message: /usr/bin/ld: cannot find -lvirt Comple

Re: [Xen-devel] [PATCH v2] xl/libxl: add pvcalls support

2018-03-29 Thread Jim Fehlig
On 03/29/2018 04:07 PM, Stefano Stabellini wrote: Add pvcalls support to libxl and xl. Create the appropriate pvcalls entries in xenstore. Signed-off-by: Stefano Stabellini --- Changes in v2: - rename pvcalls to pvcallsif internally in libxl to avoid `pvcallss' --- docs/misc/xenstore-paths.

Re: [Xen-devel] [PATCH v2] tools/xenstore: try to get minimum thread stack size for watch thread

2018-03-02 Thread Jim Fehlig
On 03/02/2018 05:40 AM, Wei Liu wrote: On Fri, Mar 02, 2018 at 12:29:31PM +, Wei Liu wrote: On Mon, Feb 26, 2018 at 09:53:38AM -0700, Jim Fehlig wrote: On 02/26/2018 01:46 AM, Juergen Gross wrote: When creating a pthread in xs_watch() try to get the minimal needed size of the thread from

[Xen-devel] [PATCH V2] libxl: set channel devid when not provided by application

2018-02-26 Thread Jim Fehlig
. A simple fix is to set an uninitialized devid (-1) to the dev_num passed to libxl__init_console_from_channel(). Signed-off-by: Jim Fehlig --- V2: Set console devid to channel devid as part of initializing a console from a channel. tools/libxl/libxl_console.c | 5 - 1 file changed, 4 inser

Re: [Xen-devel] [PATCH v2] tools/xenstore: try to get minimum thread stack size for watch thread

2018-02-26 Thread Jim Fehlig
ize) != 0) { pthread_attr_destroy(&attr); mutex_unlock(&h->request_mutex); return false; This worked fine, even on the system with the buggy glibc. Tested-by: Jim Fehlig Regards, Jim ___ Xen-deve

Re: [Xen-devel] [PATCH] tools/xenstore: try to get minimum thread stack size for watch thread

2018-02-23 Thread Jim Fehlig
On 02/22/2018 06:53 AM, Juergen Gross wrote: When creating a pthread in xs_watch() try to get the minimal needed size of the thread from glibc instead of using a constant. This avoids problems when the library is used in programs with large per-thread memory. Use dlsym() to get the pointer to __

Re: [Xen-devel] [PATCH] xenstore: increase default thread stack size to 32k

2018-02-22 Thread Jim Fehlig
On 02/21/2018 10:18 PM, Juergen Gross wrote: On 21/02/18 23:13, Jim Fehlig wrote: On several Skylake machines I've observed xl segfaults when running create or destroy subcommands. Other subcommands may segfault too, but I've only looked at create and destroy which share a similar

Re: [Xen-devel] [PATCH] libxl: set channel devid when not provided by application

2018-02-21 Thread Jim Fehlig
Any comments on this patch? Thanks! Regards, Jim On 02/07/2018 08:04 PM, Jim Fehlig wrote: Applications like libvirt may not populate a device devid field, delegating that to libxl. If needed, the application can later retrieve the libxl-produced devid. Indeed most devices are handled this way

[Xen-devel] [PATCH] xenstore: increase default thread stack size to 32k

2018-02-21 Thread Jim Fehlig
roader CPU feature set which must be saved within _dl_runtime_resolve and friends. While PTHREAD_STACK_MIN should advertise a suitable stack size based on the underlying system, increasing the default size makes xenstore a bit more robust on systems with insufficient/broken minimums. Signed-off-by:

[Xen-devel] [PATCH] libxl: set channel devid when not provided by application

2018-02-07 Thread Jim Fehlig
. A simple fix is to set an uninitialized devid (-1) to the dev_num passed to libxl__init_console_from_channel(). Signed-off-by: Jim Fehlig --- I get the feeling that if needed devid should be set earlier, but this seems like the most opportune spot. Suggestions for improvements welcome. tools/l

Re: [Xen-devel] [libvirt test] 118006: regressions - FAIL

2018-01-16 Thread Jim Fehlig
On 01/15/2018 07:49 AM, osstest service owner wrote: flight 118006 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/118006/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build