Re: [Xen-devel] [PATCH 2/2] xen/gntdev: Check and release imported dma-bufs on close

2019-02-17 Thread Juergen Gross
On 14/02/2019 15:23, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > Check if there are any imported dma-bufs left not released by > user-space when grant device's release callback is called and > free those if this is the case. This can happen if user-space > leaks the

Re: [Xen-devel] [PATCH] xen/pciback: Don't disable PCI_COMMAND on PCI device reset.

2019-02-17 Thread Juergen Gross
cess > [which enables the PCI_COMMAND_MEMORY|PCI_COMMAND_IO] > > However guests (and drivers) which don't do this could cause > problems, including the security issues which XSA-120 sought > to address. > > Reported-by: Jan Beulich > Signe

Re: [Xen-devel] [PATCH 1/2] xen/gntdev: Do not destroy context while dma-bufs are in use

2019-02-17 Thread Juergen Gross
On 14/02/2019 15:23, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > If there are exported DMA buffers which are still in use and > grant device is closed by either normal user-space close or by > a signal this leads to the grant device context to be destroyed, > thus making

Re: [Xen-devel] [PATCH 1/2] xen/gntdev: Do not destroy context while dma-bufs are in use

2019-02-15 Thread Juergen Gross
On 15/02/2019 16:35, Oleksandr Andrushchenko wrote: > On 2/15/19 5:28 PM, Boris Ostrovsky wrote: >> On 2/15/19 10:07 AM, Oleksandr Andrushchenko wrote: >>> On 2/15/19 5:03 PM, Boris Ostrovsky wrote: On 2/14/19 9:23 AM, Oleksandr Andrushchenko wrote: >      /* DMA buffer export support. */

Re: [Xen-devel] [PATCH for-4.12 v3 3/8] amd/npt/shadow: replace assert that prevents creating 2M/1G MMIO entries

2019-02-15 Thread Juergen Gross
ake sure > there's no overlapping with MMIO read-only ranges. > > Note that 1G MMIO entries will not be created unless mmio_order is > changed to allow it. > > Signed-off-by: Roger Pau Monné Release-acked-by: Juergen Gross Juergen ___ Xe

Re: [Xen-devel] [PATCH for-4.12 v3 2/8] x86/pvh: reorder PVH dom0 iommu initialization

2019-02-15 Thread Juergen Gross
dom0 physmap and sets the paging > allocation, and another one that actually populates the p2m with RAM > regions. > > Note that this allows to remove the special casing done for the low > 1MB in hwdom_iommu_map. > > Signed-off-by: Roger Pau Monné > Reviewed-by: Jan Beuli

Re: [Xen-devel] [PATCH for-4.12 v3 1/8] dom0/pvh: align allocation and mapping order to start address

2019-02-15 Thread Juergen Gross
by: Wei Liu > Reviewed-by: Jan Beulich Release-acked-by: Juergen Gross Juergen ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [OSSTEST PATCH] README.hardware-acquisition [and 1 more messages]

2019-02-15 Thread Juergen Gross
simply to pointlessly invite mistakes. And > if I'm to use a written-down checklist it should be one which is > actually official. > > Accordingly, I intend to commit this to osstest now. Juergen, this is > just a document: can I have your release ack for it ? Yes, sure: Release-acke

Re: [Xen-devel] [PATCH] tools/libxendevicemodel: add xendevicemodel_modified_memory_bulk to map

2019-02-15 Thread Juergen Gross
ost 2 years ago, but the function >> was not included in the map file, essentially making it useless. This >> patch rectifies the situation. >> >> Signed-off-by: Paul Durrant Release-acked-by: Juergen Gross Juergen ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] Upstream Dom0 DRM problems regarding swiotlb

2019-02-14 Thread Juergen Gross
On 14/02/2019 18:57, Christoph Hellwig wrote: > On Thu, Feb 14, 2019 at 07:03:38AM +0100, Juergen Gross wrote: >>> The thing which is different between Xen PV guests and most others (all >>> others(?), now that Lguest and UML have been dropped) is that what Linux >>

Re: [Xen-devel] [PATCH v2] viridian: fix the HvFlushVirtualAddress/List hypercall implementation

2019-02-14 Thread Juergen Gross
On 14/02/2019 13:10, Paul Durrant wrote: > The current code uses hvm_asid_flush_vcpu() but this is insufficient for > a guest running in shadow mode, which results in guest crashes early in > boot if the 'hcall_remote_tlb_flush' is enabled. > > This patch, instead of open coding a new flush

Re: [Xen-devel] [OSSTEST PATCH 5/4] backports snapshot: Disable apt timestamp checking in right place

2019-02-14 Thread Juergen Gross
t; Signed-off-by: Ian Jackson Release-acked-by: Juergen Gross in case my implicit ack from yesterday expired as well ;-) Juergen ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [PATCH v3 0/2] x86: respect memory size limits

2019-02-14 Thread Juergen Gross
to U64_MAX instead -1 - patch 2: set initial allowed size to end of E820 RAM Juergen Gross (2): x86: respect memory size limiting via mem= parameter x86/xen: dont add memory above max allowed allocation arch/x86/kernel/e820.c | 5 + arch/x86/xen/setup.c | 13 + d

[Xen-devel] [PATCH v3 2/2] x86/xen: dont add memory above max allowed allocation

2019-02-14 Thread Juergen Gross
] [] phys_pmd_init+0x210/0x255 [ 584.681587] [] phys_pud_init+0x1da/0x247 [ 584.687931] [] kernel_physical_mapping_init+0xf5/0x1d4 [ 584.695682] [] init_memory_mapping+0x18d/0x380 [ 584.702631] [] arch_add_memory+0x59/0xf0 Signed-off-by: Juergen Gross --- arch/x86/xen/setup.c | 13

[Xen-devel] [PATCH v3 1/2] x86: respect memory size limiting via mem= parameter

2019-02-14 Thread Juergen Gross
CI devices due to corresponding ACPI table entries. Not respecting "mem=" can be corrected by adding a global max_mem_size variable set by parse_memopt() which will result in rejecting adding memory areas resulting in a memory size above the allowed limit. Signed-off-by: Juergen Gross A

Re: [Xen-devel] Upstream Dom0 DRM problems regarding swiotlb

2019-02-13 Thread Juergen Gross
On 14/02/2019 01:11, Andrew Cooper wrote: > On 13/02/2019 21:08, Michael Labriola wrote: >> On Wed, Feb 13, 2019 at 3:21 PM Andrew Cooper >> wrote: >>> On 13/02/2019 20:15, Michael Labriola wrote: On Wed, Feb 13, 2019 at 2:16 PM Konrad Rzeszutek Wilk wrote: > On Wed, Feb 13, 2019

Re: [Xen-devel] Upstream Dom0 DRM problems regarding swiotlb

2019-02-13 Thread Juergen Gross
On 13/02/2019 19:38, Michael Labriola wrote: > On Wed, Feb 13, 2019 at 1:16 PM Michael Labriola > wrote: >> >> On Wed, Feb 13, 2019 at 11:57 AM Konrad Rzeszutek Wilk >> wrote: >>> >>> On Wed, Feb 13, 2019 at 09:09:32AM -0700, Jan Beulich wrote: >>> On 13.02.19 at 17:00, wrote: > On Wed,

Re: [Xen-devel] [PATCH] xen: mark expected switch fall-through

2019-02-12 Thread Juergen Gross
On 13/02/2019 00:50, Boris Ostrovsky wrote: > On Tue, Feb 12, 2019 at 02:37:20PM -0600, Gustavo A. R. Silva wrote: >> In preparation to enabling -Wimplicit-fallthrough, mark switch >> cases where we are expecting to fall through. >> >> This patch fixes the following warning: >> >>

Re: [Xen-devel] [PATCH Makefile v2] asm: handle comments when creating header file

2019-02-11 Thread Juergen Gross
rgen, is there a chance to get this patch into the 4.12 release? It > would be nice to be able to compile upstream Xen with the tool chain for > the CBMC model checker (i.e. the goto-gcc compiler), as that tool chain > allows to apply further reasoning. Thanks! Release-acked-by: Juergen Gross Juergen ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v5 7/8] x86/microcode: Synchronize late microcode loading

2019-02-11 Thread Juergen Gross
On 11/02/2019 14:23, Jan Beulich wrote: On 11.02.19 at 06:40, wrote: >> On Fri, Feb 08, 2019 at 09:29:32AM -0700, Jan Beulich wrote: >> On 28.01.19 at 08:06, wrote: +/* + * Initiate an update on all processors which don't have an online sibling + *

Re: [Xen-devel] [PATCH v2 1/2] x86: respect memory size limiting via mem= parameter

2019-02-11 Thread Juergen Gross
On 11/02/2019 13:23, Ingo Molnar wrote: > > * Juergen Gross wrote: > >>> If PCI devices had physical mmio memory areas above this range, we'd >>> still expect them to work - the option was really only meant to limit >>> RAM. >> >> No, in

Re: [Xen-devel] [PATCH v2 1/2] x86: respect memory size limiting via mem= parameter

2019-02-11 Thread Juergen Gross
On 11/02/2019 13:06, Ingo Molnar wrote: > > * Juergen Gross wrote: > >> When limiting memory size via kernel parameter "mem=" this should be >> respected even in case of memory made accessible via a PCI card. >> >> Today this kind of memory won'

Re: [Xen-devel] [PATCH] x86: make set_pmd_at() paravirt aware

2019-02-10 Thread Juergen Gross
On 10/02/2019 19:14, Linus Torvalds wrote: > On Sat, Feb 9, 2019 at 11:41 PM Juergen Gross wrote: >> >> Make set_pmd_at() paravirt aware by just letting it use set_pmd(). > > Well, that was simpler than I worried. > > Just checking: Is this purely an x86 issue

[Xen-devel] [PATCH] x86: make set_pmd_at() paravirt aware

2019-02-09 Thread Juergen Gross
on large regions") Reported-by: Sander Eikelenboom Signed-off-by: Juergen Gross --- arch/x86/include/asm/pgtable.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/include/asm/pgtable.h b/arch/x86/include/asm/pgtable.h index 40616e805292..2779ace16d23 100644 ---

Re: [Xen-devel] Linux 5.0 regression: BUG: unable to handle kernel paging request at ffff888023e26778 RIP: e030:move_page_tables+0x7c1/0xae0

2019-02-09 Thread Juergen Gross
On 09/02/2019 19:51, Sander Eikelenboom wrote: > On 09/02/2019 19:48, Juergen Gross wrote: >> On 09/02/2019 19:45, Sander Eikelenboom wrote: >>> On 09/02/2019 09:26, Sander Eikelenboom wrote: >>>> L.S., >>>> >>>> >>>> Whil

Re: [Xen-devel] Linux 5.0 regression: BUG: unable to handle kernel paging request at ffff888023e26778 RIP: e030:move_page_tables+0x7c1/0xae0

2019-02-09 Thread Juergen Gross
On 09/02/2019 19:45, Sander Eikelenboom wrote: > On 09/02/2019 09:26, Sander Eikelenboom wrote: >> L.S., >> >> >> While testing a Linux 5.0-rc5-ish kernel (pull of yesterday) with some >> additional patches for >> already reported other issues i came across the issue below which i haven't >>

[Xen-devel] [GIT PULL] xen: fixes for 5.0-rc6

2019-02-09 Thread Juergen Gross
Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.0-rc6-tag xen: fixes for 5.0-rc6 It contains two very minor fixes: one remove of a #include for an unused header and a fix of the xen ML address in MAINTAINERS. Thanks. Juergen

Re: [Xen-devel] [PATCH] docs: features/qemu-depriv formatting fixes

2019-02-07 Thread Juergen Gross
On 07/02/2019 16:09, George Dunlap wrote: > Need a space between the paragraph and the list so pandoc knows it's a > list. > > Signed-off-by: George Dunlap Release-acked-by: Juergen Gross Juergen ___ Xen-devel mailing li

Re: [Xen-devel] [PATCH for-4.12 0/3] tools: Init scripts minor fixes

2019-02-07 Thread Juergen Gross
mmons.in | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > For the series: Release-acked-by: Juergen Gross Juergen ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] x86/pv: Fix construction of 32bit dom0's

2019-02-07 Thread Juergen Gross
On 07/02/2019 14:45, Jan Beulich wrote: On 07.02.19 at 14:29, wrote: >> On 07/02/2019 12:58, Jan Beulich wrote: >> On 06.02.19 at 21:41, wrote: 2) The reported Dom0 alloc.: 3e80->3ec0 (240470 pages to be allocated) line

Re: [Xen-devel] [PATCH] x86/pv: Fix construction of 32bit dom0's

2019-02-07 Thread Juergen Gross
On 07/02/2019 14:29, Andrew Cooper wrote: > On 07/02/2019 12:58, Jan Beulich wrote: > On 06.02.19 at 21:41, wrote: >>> Slightly RFC: >>> >>> 1) I've not worked out exactly what the >>> >>> v->vcpu_info = (void *)>shared_info->compat.vcpu_info[0]; >>> >>>line is supposed to be doing

Re: [Xen-devel] [PATCH] docs: Update credit/credit2 feature docs reflecting new default scheduler

2019-02-07 Thread Juergen Gross
On 07/02/2019 13:08, George Dunlap wrote: > Signed-off-by: George Dunlap Release-acked-by: Juergen Gross Juergen ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v2] x86emul: avoid speculative out of bounds accesses

2019-02-07 Thread Juergen Gross
hardening effort. > > Signed-off-by: Jan Beulich Release-acked-by: Juergen Gross Juergen ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v2] x86/shadow: adjust minimum allocation calculations

2019-02-07 Thread Juergen Gross
er needlessly add 1 to > the vCPU count. > > Finally make the debugging printk() in shadow_alloc_p2m_page() a little > more useful by logging some of the relevant domain settings. > > Reported-by: Roger Pau Monné > Signed-off-by: Jan Beulich > Reviewed-b

Re: [Xen-devel] [PATCH for-4.12] xen/arm: gic-v2: deactivate interrupts during initialization

2019-02-07 Thread Juergen Gross
On 05/02/2019 22:38, Stefano Stabellini wrote: > Interrupts could be ACTIVE at boot. Make sure to deactivate them during > initialization. > > Signed-off-by: Stefano Stabellini Release-acked-by: Juergen Gross Juergen ___ Xen-devel mail

Re: [Xen-devel] [PATCH v2 2/2] x86/xen: dont add memory above max allowed allocation

2019-02-06 Thread Juergen Gross
On 01/02/2019 19:46, Boris Ostrovsky wrote: > On 1/30/19 3:22 AM, Juergen Gross wrote: >> Don't allow memory to be added above the allowed maximum allocation >> limit set by Xen. >> >> Trying to do so would result in cases like the following: >> >>

Re: [Xen-devel] Ping: libfsimage path/file name changes

2019-02-06 Thread Juergen Gross
On 06/02/2019 17:13, Ian Jackson wrote: > Jan Beulich writes ("Ping: libfsimage path/file name changes"): >> On 28.01.19 at 08:55, wrote: >>> back in October you've added quite a number of "xen" prefixes to >>> various pieces there. Now that I've finally had time to connect this >>> change of

Re: [Xen-devel] [PATCH v8 for-4.12 00/17] Argo: hypervisor-mediated interdomain communication

2019-02-06 Thread Juergen Gross
d new section for Argo and self as maintainer >> SUPPORT.md : add new entry for the Argo feature >> docs, argo: add design document for Argo > > Where necessary and not already present > Acked-by: Jan Beulich > > Jürgen, for this to be committed, your Rab wo

Re: [Xen-devel] [PATCH] VMX: don't ignore P2M setup error

2019-02-06 Thread Juergen Gross
cussion. I'm fine with that in 4.12: Release-acked-by: Juergen Gross Juergen ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v3 for-4.12] arm: gic-v3: deactivate interrupts during initialization

2019-02-05 Thread Juergen Gross
WN. > So make sure all interrupts are deactivated at during initialization by > clearing the state. > > Signed-off-by: Peng Fan Release-acked-by: Juergen Gross Juergen ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v6 1/4] xen: introduce SYMBOL

2019-02-04 Thread Juergen Gross
On 04/02/2019 20:08, Stefano Stabellini wrote: > On Mon, 4 Feb 2019, Jan Beulich wrote: > On 01.02.19 at 19:52, wrote: >> >> I'm not going to reply in detail to all of what you wrote about fanatics, >> but I would like to say that I think compiler people less of that than >> you appear to

Re: [Xen-devel] [PATCH for-4.12] xen/arm: irq: End cleanly spurious interrupt

2019-02-04 Thread Juergen Gross
gt; receive any interrupt route to any guest afterwards. >> >> The problem can be prevented by dropping the priority and deactivating >> the interrupt via gic_hw_ops->gic_host_irq->end(). >> >> Note that, for now, interrupt used by Xen are

Re: [Xen-devel] [PATCH for-4.12] x86/vpmu: Improve documentation and parsing for vpmu=

2019-02-04 Thread Juergen Gross
s = ss + 1; >>>>>> +} while ( *ss ); >>>>>> + >>>>>> +/* Selecting bts/ipc/arch forces vpmu to enabled. */ >>>>>> +if ( vpmu_features ) >>>>>> +opt_vpmu_enabled = true; >>>>> If you want to retain original behavior, the condition here would need >>>>> to be "!rc && vpmu_features". It's not clear whether your modification >>>>> in this regard is intentional. >>>> Oh - that wasn't intentional. >>>> >>>> An alternative, now I think about it, is to just have the =false >>>> case clear vpmu_features. This is new behaviour, but it is more >>>> consistent with how other options work, and it wasn't expressable before. >>> Generally - yes. But what would e.g. "vpmu=off,ipc" end up doing in >>> your new model? >> >> The use of vpmu_features is somewhat weird. "bts" acts as an extra >> feature on top of "generally on", whereas "ipc" and "arch" act as >> restrictions on top of "generally on". > > Okay let's go that route then. Release-acked-by: Juergen Gross Juergen ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] Xen 4.12 RC2

2019-02-04 Thread Juergen Gross
Hi all, Xen 4.12 rc2 is tagged. You can check that out from xen.git: git://xenbits.xen.org/xen.git 4.12-rc2 For your convenience there is also a tarball at: https://downloads.xenproject.org/release/xen/4.12-rc2/xen-4.12-rc2.tar.gz And the signature is at:

Re: [Xen-devel] [PATCH for-4.12] tools: drop obsolete xen-ringwatch

2019-02-04 Thread Juergen Gross
the > xenolinux fork which never got upstreamed. > > It's utility is zero nowadays. Drop it. > > Signed-off-by: Wei Liu Release-acked-by: Juergen Gross Juergen ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenpr

Re: [Xen-devel] [PATCH] tools/misc: Remove obsolete xen-bugtool

2019-02-03 Thread Juergen Gross
66380 > Cc: Ian Jackson > Cc: Wei Liu I think we want that in 4.12. So: Release-acked-by: Juergen Gross Juergen ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH for-4.12 v2] xen/iommu: fix iommu_ops initialization

2019-02-01 Thread Juergen Gross
On 01/02/2019 17:29, Juergen Gross wrote: > Commit 32a5ea00ec75ef53e ("IOMMU/x86: remove indirection from certain > IOMMU hook accesses") introduced iommu_ops initialized at boot time > with data declared as __initconstrel. > > On Intel systems there is another path where

[Xen-devel] [PATCH for-4.12 v2] xen/iommu: fix iommu_ops initialization

2019-02-01 Thread Juergen Gross
returning from system suspend. As the initialization data is no longer accessible in this case that second initialization must be dropped in case the system isn't just booting. Signed-off-by: Juergen Gross --- xen/drivers/passthrough/vtd/intremap.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [Xen-devel] [PATCH for-4.12] xen/iommu: fix iommu_ops attribute

2019-02-01 Thread Juergen Gross
On 01/02/2019 16:44, Jan Beulich wrote: On 01.02.19 at 16:13, wrote: >> --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c >> +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c >> @@ -570,7 +570,7 @@ static void amd_dump_p2m_table(struct domain *d) >>

[Xen-devel] [PATCH for-4.12] xen/iommu: fix iommu_ops attribute

2019-02-01 Thread Juergen Gross
Signed-off-by: Juergen Gross --- xen/drivers/passthrough/amd/pci_amd_iommu.c | 2 +- xen/drivers/passthrough/vtd/iommu.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/drivers/passthrough/amd/pci_amd_iommu.c b/xen/drivers/passthrough/amd/pci_amd_iommu.c index

Re: [Xen-devel] [PATCH for-4.12] automation: introduce a QEMU smoke test for PVH Dom0

2019-02-01 Thread Juergen Gross
On 01/02/2019 14:42, Doug Goldstein wrote: > On Thu, Jan 24, 2019 at 03:24:11PM +, Wei Liu wrote: >> Make qemu-smoke-x86-64.sh take a variant argument. Make two new tests >> in test.yaml. >> >> Signed-off-by: Wei Liu > > Acked-by: Doug Goldstein > > This is a good improvement to increase

Re: [Xen-devel] [PATCH for-4.12] x86/svm: Fix handling of ICEBP intercepts

2019-02-01 Thread Juergen Gross
aise #GP for the guest. > > If svm_get_insn_len() fails, return back to guest context rather than > continuing and mistaking a trap-style VMExit for a fault-style one. > > Spotted by Coverity. > > Signed-off-by: Andrew Cooper

Re: [Xen-devel] [PATCH for-4.12] automation: introduce a QEMU smoke test for PVH Dom0

2019-02-01 Thread Juergen Gross
On 01/02/2019 16:02, Wei Liu wrote: > On Fri, Feb 01, 2019 at 03:59:58PM +0100, Juergen Gross wrote: >> On 01/02/2019 14:42, Doug Goldstein wrote: >>> On Thu, Jan 24, 2019 at 03:24:11PM +, Wei Liu wrote: >>>> Make qemu-smoke-x86-64.sh take a varian

Re: [Xen-devel] preparations for 4.10.3 and 4.9.4

2019-02-01 Thread Juergen Gross
On 01/02/2019 12:14, Jan Beulich wrote: > All, > > both releases would have been due last week. Please point out > backports you find missing from their respective staging branches, > but which you consider relevant. For 4.10.3:

Re: [Xen-devel] Scheduling and the periodic timer

2019-02-01 Thread Juergen Gross
On 01/02/2019 10:50, Jan Beulich wrote: On 01.02.19 at 08:26, wrote: >> While working on my core scheduling series I stumbled over the periodic >> timer. Could it be this timer never worked correctly? >> >> When the vcpu with an active periodic timer is running everything seems >> to be

Re: [Xen-devel] Scheduling and the periodic timer

2019-02-01 Thread Juergen Gross
On 01/02/2019 10:40, Andrew Cooper wrote: > On 01/02/2019 07:26, Juergen Gross wrote: >> While working on my core scheduling series I stumbled over the periodic >> timer. Could it be this timer never worked correctly? >> >> When the vcpu with an active periodic timer

Re: [Xen-devel] xen/mem-reservation API and out-of-tree kernel modules

2019-02-01 Thread Juergen Gross
On 01/02/2019 09:39, Oleksandr Andrushchenko wrote: > On 1/31/19 11:44 PM, Stefano Stabellini wrote: >> On Thu, 31 Jan 2019, Oleksandr Andrushchenko wrote: >>> Hello, >>> >>> I am working on porting an out-of-tree kernel driver to the kernel >>> 5.0 and that driver uses functionality provided by

[Xen-devel] Scheduling and the periodic timer

2019-01-31 Thread Juergen Gross
While working on my core scheduling series I stumbled over the periodic timer. Could it be this timer never worked correctly? When the vcpu with an active periodic timer is running everything seems to be fine. But when not running the timer is stopped in schedule(). So a vcpu going to idle

Re: [Xen-devel] [PATCH v3 0/3] x86/svm: Improvements to SVM instruction length handling

2019-01-31 Thread Juergen Gross
Now that I've got maintainer acks, could I get a view to 4.12 release > ack please?  This improves diagnostics for a real issue we discovered > during the 4.12 development cycle. For the series: Release-acked-by: Juergen Gross Juergen ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 0/4] x86: further L1TF / XSA-289 guards

2019-01-31 Thread Juergen Gross
On 31/01/2019 15:07, Jan Beulich wrote: > This goes alongside Norbert's series, dealing with a few more > places where I happened to know (without any analysis tools) > guest controlled array accesses sit. I've additionally also > checked emul-i8254.c, and I think no adjustments are needed > there

Re: [Xen-devel] [PATCH v2 for-4.12] xen/cmdline: Work around some specific command line warnings

2019-01-30 Thread Juergen Gross
where > warning the user is the wrong course of action to take. > > Signed-off-by: Andrew Cooper > --- > CC: Jan Beulich > CC: Wei Liu > CC: Roger Pau Monné > CC: Juergen Gross > > v2: > * Rewrite from scratch, following Juergen's suggestion > > An implemen

Re: [Xen-devel] [PATCH] x86/pv-shim: Avoid a command line parameter warning for CONFIG_PV_SHIM_EXCLUSIVE builds

2019-01-30 Thread Juergen Gross
On 30/01/2019 15:09, Juergen Gross wrote: > On 30/01/2019 11:06, Jan Beulich wrote: >>>>> On 30.01.19 at 11:01, wrote: >>> On 30/01/2019 09:57, Jan Beulich wrote: >>>>>>> On 29.01.19 at 20:07, wrote: >>>>> --- a/xen/arch/x86/pv/

Re: [Xen-devel] [PATCH] x86/pv-shim: Avoid a command line parameter warning for CONFIG_PV_SHIM_EXCLUSIVE builds

2019-01-30 Thread Juergen Gross
On 30/01/2019 11:06, Jan Beulich wrote: On 30.01.19 at 11:01, wrote: >> On 30/01/2019 09:57, Jan Beulich wrote: >> On 29.01.19 at 20:07, wrote: --- a/xen/arch/x86/pv/shim.c +++ b/xen/arch/x86/pv/shim.c @@ -40,7 +40,11 @@ #undef virt_to_mfn #define

Re: [Xen-devel] [PATCH v2 for-4.12] x86/pvh-boot: don't mandate validity of RSDP pointer

2019-01-30 Thread Juergen Gross
On 30/01/2019 14:55, Wei Liu wrote: > RSDP is not mandatory according to PVH spec. Remove the BUG_ON. The > guest (xen) will fall back to scanning if necessary. > > Reported-by: Andrew Cooper > Signed-off-by: Wei Liu Release-acked-by: Juergen G

Re: [Xen-devel] [Xen 4.12 bug] HVM/PVH boot confusion

2019-01-30 Thread Juergen Gross
On 30/01/2019 14:38, Wei Liu wrote: > On Wed, Jan 30, 2019 at 12:46:45PM +, Wei Liu wrote: >> On Wed, Jan 30, 2019 at 12:30:44PM +, Andrew Cooper wrote: > There are at least two bugs here. > > 1) RSDP was a late addition to the PVH boot protocol.  Xen's PVH > entrypoint

[Xen-devel] [PATCH v2 1/2] x86: respect memory size limiting via mem= parameter

2019-01-30 Thread Juergen Gross
CI devices due to corresponding ACPI table entries. Not respecting "mem=" can be corrected by adding a global max_mem_size variable set by parse_memopt() which will result in rejecting adding memory areas resulting in a memory size above the allowed limit. Signed-off-by: Juergen Gross

[Xen-devel] [PATCH v2 2/2] x86/xen: dont add memory above max allowed allocation

2019-01-30 Thread Juergen Gross
] [] phys_pmd_init+0x210/0x255 [ 584.681587] [] phys_pud_init+0x1da/0x247 [ 584.687931] [] kernel_physical_mapping_init+0xf5/0x1d4 [ 584.695682] [] init_memory_mapping+0x18d/0x380 [ 584.702631] [] arch_add_memory+0x59/0xf0 Signed-off-by: Juergen Gross --- arch/x86/xen/setup.c | 10

[Xen-devel] [PATCH v2 0/2] x86: respect memory size limits

2019-01-30 Thread Juergen Gross
blems (e.g. avoiding to add only parts of a 128MB memory bar which might be difficult to remove later). Changes in V2: - patch 1: set initial allowed size to U64_MAX instead -1 - patch 2: set initial allowed size to end of E820 RAM Juergen Gross (2): x86: respect memory size limiting via mem= parameter

Re: [Xen-devel] [xen-unstable test] 132544: regressions - FAIL

2019-01-30 Thread Juergen Gross
On 29/01/2019 18:08, osstest service owner wrote: > flight 132544 xen-unstable real [real] > http://logs.test-lab.xenproject.org/osstest/logs/132544/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: >

Re: [Xen-devel] osstest commits and Xen releases

2019-01-29 Thread Juergen Gross
On 29/01/2019 13:43, Ian Jackson wrote: > Juergen Gross writes ("OSStest commits and Xen releases"): >> I have found an alarming tendency regarding changes in the OSStest >> repository: over the last 2 years (or 3 Xen versions) there has been >> a pattern of OSSt

Re: [Xen-devel] [PATCH for-4.12] libxl: correctly dispose of dominfo list in libxl_name_to_domid

2019-01-29 Thread Juergen Gross
On 29/01/2019 12:37, Wei Liu wrote: > Tamas reported ssid_label was leaked. Use the designated function to > free dominfo list to fix the leakage. > > Reported-by: Tamas K Lengyel > Signed-off-by: Wei Liu > Tested-by: Tamas K Lengyel Release-acked-by: Juerge

Re: [Xen-devel] [PATCH v2.1 1/2] tools: fix build dependency upon generated header(s)

2019-01-29 Thread Juergen Gross
to produce the header together with the > directory tree creation therefore does not work. Introduce a separate > goal. > > Signed-off-by: Jan Beulich Release-acked-by: Juergen Gross Juergen ___ Xen-devel mailing list Xe

Re: [Xen-devel] [PATCH v2.1 2/2] x86emul: fix test harness and fuzzer build dependencies

2019-01-29 Thread Juergen Gross
der if needed, but only when these rules did not > get invoked recursively themselves. > > Finally cpuid.o did not have any dependencies added for it. > > Signed-off-by: Jan Beulich > Acked-by: Andrew Cooper Release-acked-by: Juergen Gross Juergen __

Re: [Xen-devel] [PATCH v2 for-4.12] x86/hvm: Fix bit checking for CR4 and MSR_EFER

2019-01-29 Thread Juergen Gross
rder. > > Signed-off-by: Andrew Cooper Release-acked-by: Juergen Gross Juergen ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH for-4.12] pvh/dom0: fix deadlock in GSI mapping

2019-01-29 Thread Juergen Gross
a/0x270 > > In order to solve it move the vioapic_hwdom_map_gsi outside of the > locked region in vioapic_write_redirent. vioapic_hwdom_map_gsi will > not access any of the vioapic fields, so there's no need to call the > function holding the hvm.irq_lock. > > Signed-off-by: Roge

[Xen-devel] OSStest commits and Xen releases

2019-01-28 Thread Juergen Gross
I have found an alarming tendency regarding changes in the OSStest repository: over the last 2 years (or 3 Xen versions) there has been a pattern of OSStest commits being more frequent during the RC phase of a Xen release. On average there were about 4 commits to osstest.git per week. The numbers

Re: [Xen-devel] [PATCH for-4.12] arm: gic: deactivate sgi immediately after eoi

2019-01-28 Thread Juergen Gross
> To fix this issue, let's move the deactivate_irq operation just after > eoi_irq, then the SGI interrupt will be in deactive state when > smp_call_function_interrupt. > > Signed-off-by: Peng Fan Release-acked-by: Juergen Gross Juergen

Re: [Xen-devel] [PATCH for-4.12] libxl: When restricted, start QEMU paused

2019-01-28 Thread Juergen Gross
me, and > suspending its monitor (QMP) until the command as been processed and > sent. Disconnecting from the socket doesn't unsuspend the monitor. The > race described here is very likely to happen with QEMU 3.1.50 (during > 3.2 development), but can be reproduced with QEMU 3.1. > > Sign

Re: [Xen-devel] [PATCH v3] x86/AMD: flush TLB after ucode update

2019-01-28 Thread Juergen Gross
flushing just a single page is > sufficient: As per verify_patch_size() patch size can't exceed 4k, and > the way xmalloc() works the blob can't be crossing a page boundary. > > Signed-off-by: Jan Beulich Release-acked-by: Juergen Gross Juergen _

Re: [Xen-devel] [PATCH for-4.12 v2 0/7] xen/arm: Workaround for Cortex-A76 erratum 1165522

2019-01-28 Thread Juergen Gross
en/include/asm-arm/cpufeature.h | 3 +- > xen/include/asm-arm/processor.h | 2 + > 8 files changed, 139 insertions(+), 30 deletions(-) > Release-acked-by: Juergen Gross Juergen ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v2 for-4.12] gic-vgic: fix an assert condition

2019-01-28 Thread Juergen Gross
on on debug builds. > > Fixes: ec2a2f1 ("ARM: VGIC: factor out vgic_connect_hw_irq()") > Signed-off-by: Andrii Anisov > Suggested-by: Stefan Nuernberger Release-acked-by: Juergen Gross Juergen ___ Xen-devel mailing l

Re: [Xen-devel] SpectreV1+L1TF Patch Series

2019-01-28 Thread Juergen Gross
On 28/01/2019 10:56, Jan Beulich wrote: On 28.01.19 at 09:47, wrote: >> On 28/01/2019 09:28, Jan Beulich wrote: >> On 23.01.19 at 12:51, wrote: This patch series attempts to mitigate the issue that have been raised in the XSA-289

Re: [Xen-devel] SpectreV1+L1TF Patch Series

2019-01-28 Thread Juergen Gross
On 28/01/2019 09:28, Jan Beulich wrote: > Jürgen, > On 23.01.19 at 12:51, wrote: >> This patch series attempts to mitigate the issue that have been raised in the >> XSA-289 (https://xenbits.xen.org/xsa/advisory-289.html). To block speculative >> execution on Intel hardware, an lfence

Re: [Xen-devel] [PATCH for-4.12] x86/p2m: Drop erroneous #VE-enabled check in ept_set_entry()

2019-01-24 Thread Juergen Gross
-EOPNOTSUPP part of this > condition is also wrong. > > Drop the !sve check entirely. > > Signed-off-by: Andrew Cooper Release-acked-by: Juergen Gross Juergen ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH-for-4.12] docs: Fix dm_restrict documentation

2019-01-24 Thread Juergen Gross
are dropped: > - Mentioning PV; PV guests never have a device model. > - Drop the confusing statement about stdvga and cirrus vga options. > - Re-used domain IDs are now handled. > - Device models should no longer be able to create world-readable > files on dom0's filesys

Re: [Xen-devel] [PATCH for-4.12] iommu: fix order of arguments in iommu_map call at iommu_hwdom_init

2019-01-24 Thread Juergen Gross
for higher order map/unmap >> operations") >> Signed-off-by: Roger Pau Monné > > I notice you didn't Cc Jürgen - now done. Thanks. Release-acked-by: Juergen Gross Juergen ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] xen/sched: Introduce domain_vcpu() helper

2019-01-23 Thread Juergen Gross
ialisation offered by the global domheap lock. > > As a minor change noticed when checking the safety of this construct, sanity > check during boot that idle->max_vcpus is a suitable upper bound for > idle->vcpu[]. > > Signed-off-by: Andrew Cooper Release-acked-by: Juergen Gross

Re: [Xen-devel] [PATCH 1/2] x86: respect memory size limiting via mem= parameter

2019-01-23 Thread Juergen Gross
On 23/01/2019 15:35, William Kucharski wrote: > > >> On Jan 22, 2019, at 1:06 AM, Juergen Gross wrote: >> >> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c >> index b9a667d36c55..7fc2a87110a3 100644 >> --- a/mm/memory_hotplug.c >> +++ b/mm/me

Re: [Xen-devel] [PATCH for-4.12] xen/arm: gic: Make sure the number of interrupt lines is valid before using it

2019-01-23 Thread Juergen Gross
we compute it so we know we can >>> safely using it afterwards. >>> >>> Signed-off-by: Julien Grall >>> Reported-by: Jan-Peter Larsson >> >> Reviewed-by: Stefano Stabellini > > Would it be possible to give an RAB for this patch? Relea

Re: [Xen-devel] [PATCH v2 for-4.12] arm/p2m: call iommu iotlb flush if iommu exists and enabled

2019-01-23 Thread Juergen Gross
On 23/01/2019 13:50, Andrii Anisov wrote: > From: Andrii Anisov > > Taking decision by `need_iommu_pt_sync()` make us never kicking > `iommu_iotlb_flush()` for IOMMUs which do share P2M with CPU. > So check `has_iommu_pt()` instead. > > Signed-off-by: Andrii Anisov Rele

Re: [Xen-devel] [PATCH for-4.12 0/3] x86/pvh: Misc fixes and cleanup

2019-01-23 Thread Juergen Gross
letions(-) > For the series: Release-acked-by: Juergen Gross Juergen ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH for-4.12] amd/iommu: fix present bit checking when clearing PTE

2019-01-23 Thread Juergen Gross
y: Roger Pau Monné Release-acked-by: Juergen Gross Juergen ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 6/6] x86: xen: no need to check return value of debugfs_create functions

2019-01-23 Thread Juergen Gross
On 22/01/2019 15:35, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Boris Ostrovsky > Cc: Juergen Gr

Re: [Xen-devel] [PATCH v2 2/2] man: Highlight reference in xl-disk-configuration(5)

2019-01-22 Thread Juergen Gross
On 16/01/2019 17:16, Anthony PERARD wrote: > Provide a better way to see the link to a different manpage, with simple > words. > > Suggested-by: Ian Jackson > Signed-off-by: Anthony PERARD > Acked-by: Ian Jackson Release-acked-by: Juerge

Re: [Xen-devel] [PATCH v2 1/2] docs: Fix all links to Xen man pages in html

2019-01-22 Thread Juergen Gross
s scheme "relative" and > can end up with nice relative links. > > Signed-off-by: Anthony PERARD > Acked-by: Ian Jackson Release-acked-by: Juergen Gross Juergen ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 2/2] x86/xen: dont add memory above max allowed allocation

2019-01-22 Thread Juergen Gross
On 22/01/2019 09:52, Jan Beulich wrote: On 22.01.19 at 09:06, wrote: >> Don't allow memory to be added above the allowed maximum allocation >> limit set by Xen. > > This reads as if the hypervisor was imposing a limit here, but looking at > xen_get_max_pages(), xen_foreach_remap_area(), and

[Xen-devel] [PATCH 2/2] x86/xen: dont add memory above max allowed allocation

2019-01-22 Thread Juergen Gross
] [] phys_pmd_init+0x210/0x255 [ 584.681587] [] phys_pud_init+0x1da/0x247 [ 584.687931] [] kernel_physical_mapping_init+0xf5/0x1d4 [ 584.695682] [] init_memory_mapping+0x18d/0x380 [ 584.702631] [] arch_add_memory+0x59/0xf0 Signed-off-by: Juergen Gross --- arch/x86/xen/setup.c | 5 + 1 file

[Xen-devel] [PATCH 0/2] x86: respect memory size limits

2019-01-22 Thread Juergen Gross
blems (e.g. avoiding to add only parts of a 128MB memory bar which might be difficult to remove later). Juergen Gross (2): x86: respect memory size limiting via mem= parameter x86/xen: dont add memory above max allowed allocation arch/x86/kernel/e820.c | 5 + arch/x86/xen/setup.c

[Xen-devel] [PATCH 1/2] x86: respect memory size limiting via mem= parameter

2019-01-22 Thread Juergen Gross
CI devices due to corresponding ACPI table entries. Not respecting "mem=" can be corrected by adding a global max_mem_size variable set by parse_memopt() which will result in rejecting adding memory areas resulting in a memory size above the allowed limit. Signed-off-by: Juergen Gross

Re: [Xen-devel] [PATCH v6 1/4] xen: introduce SYMBOL

2019-01-21 Thread Juergen Gross
On 22/01/2019 00:41, Stefano Stabellini wrote: > On Mon, 21 Jan 2019, Jan Beulich wrote: > On 19.01.19 at 00:05, wrote: >>> On Fri, 18 Jan 2019, Jan Beulich wrote: >>> On 18.01.19 at 02:24, wrote: > On Thu, 17 Jan 2019, Jan Beulich wrote: > On 17.01.19 at 01:37, wrote:

  1   2   3   4   5   6   7   8   9   10   >