[PATCH] xen: acpi: Hide UART address only if SPCR exists

2021-01-18 Thread Masami Hiramatsu
Since there is a case that UEFI (EDK2) doesn't make the SPCR table when it is booted with graphic console, ignore it if SPCR doesn't exist. Signed-off-by: Masami Hiramatsu --- xen/arch/arm/acpi/domain_build.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff

[PATCH] xen: acpi: Hide UART address only if SPCR exists

2021-01-18 Thread Masami Hiramatsu
ignore the SPCR missing error. Compared with Linux kernel implementation, this doesn't check the STAO (status override) table, becaue it seems STAO (or XENV) will be provided by Xen itself. Or, should we check STAO too? Thank you, --- Masami Hiramatsu (1): xen: acpi: Hide UART address

Re: [PATCH V2 00/23] IOREQ feature (+ virtio-mmio) on Arm

2020-11-03 Thread Masami Hiramatsu
) mount: /mnt: WARNING: source write-protected, mounted read-only. So "ro" flag also correctly works. Great! Thank you! 2020年11月1日(日) 6:10 Oleksandr Tyshchenko : > > > > On Fri, Oct 30, 2020 at 1:34 PM Masami Hiramatsu > wrote: >> >> Hi Oleksandr, > > &

Re: [PATCH V2 00/23] IOREQ feature (+ virtio-mmio) on Arm

2020-10-30 Thread Masami Hiramatsu
Hi Oleksandr, 2020年10月30日(金) 6:14 Oleksandr Tyshchenko : > > Hi Stefano > > [sorry for the possible format issue] > > On Thu, Oct 29, 2020 at 9:53 PM Stefano Stabellini > wrote: >> >> On Thu, 29 Oct 2020, Oleksandr Tyshchenko wrote: >> > On Thu

Re: [PATCH V2 00/23] IOREQ feature (+ virtio-mmio) on Arm

2020-10-29 Thread Masami Hiramatsu
xen/include/xen/p2m-common.h|4 + > xen/include/xen/sched.h | 37 + > xen/include/xsm/dummy.h | 4 +- > xen/include/xsm/xsm.h |6 +- > xen/xsm/dummy.c |2 +- > xen/xsm/flask/hooks.c |5 +- > 69 files changed, 3223 insertions(+), 2125 deletions(-) > create mode 100644 tools/libs/light/libxl_virtio_disk.c > create mode 100644 tools/xl/xl_virtio_disk.c > create mode 100644 xen/arch/arm/dm.c > create mode 100644 xen/arch/arm/ioreq.c > delete mode 100644 xen/arch/x86/hvm/ioreq.c > create mode 100644 xen/common/dm.c > create mode 100644 xen/common/ioreq.c > create mode 100644 xen/include/asm-arm/hvm/ioreq.h > create mode 100644 xen/include/xen/dm.h > create mode 100644 xen/include/xen/ioreq.h > > -- > 2.7.4 > > -- Masami Hiramatsu

Re: [PATCH] meson.build: fix building of Xen support for aarch64

2020-10-28 Thread Masami Hiramatsu
not seem weird but that will require further build surgery. > > Signed-off-by: Alex Bennée > Cc: Masami Hiramatsu > Cc: Stefano Stabellini > Cc: Anthony Perard > Cc: Paul Durrant > Fixes: 8a19980e3f ("configure: move accelerator logic to meson") Thanks for the fix, I confirmed t

Re: [bug report] xen/arm64: singlestep doesn't work on Dom0

2020-10-28 Thread Masami Hiramatsu
Hi Alex, 2020年10月28日(水) 21:03 Alex Bennée : > > > Masami Hiramatsu writes: > > > Hello, > > > > When I tested the kprobes on Dom0 kernel, it caused a kernel panic. > > > > Here is an example, to clarify the bug is in the single-stepping > > (so

[bug report] xen/arm64: singlestep doesn't work on Dom0

2020-10-28 Thread Masami Hiramatsu
tions in Xen and transfer it to EL1 OS? I'm not sure how it was designed) Thank you, -- Masami Hiramatsu

[PATCH v3] arm/arm64: xen: Fix to convert percpu address to gfn correctly

2020-10-08 Thread Masami Hiramatsu
;) because it uses __pa() on percpu address. Signed-off-by: Masami Hiramatsu Reviewed-by: Stefano Stabellini --- Changes in v3: Update patch description to explain the mechanism of the problem. --- arch/arm/xen/enlighten.c |2 +- include/xen/arm/page.h |3 +++ 2 files changed, 4

Re: [PATCH] arm/arm64: xen: Fix to convert percpu address to gfn correctly

2020-10-08 Thread Masami Hiramatsu
On Tue, 6 Oct 2020 10:56:52 -0700 (PDT) Stefano Stabellini wrote: > On Tue, 6 Oct 2020, Masami Hiramatsu wrote: > > On Mon, 5 Oct 2020 18:13:22 -0700 (PDT) > > Stefano Stabellini wrote: > > > > > On Mon, 5 Oct 2020, Julien Grall wrote: > > > > Hi Ma

Re: [PATCH] arm/arm64: xen: Fix to convert percpu address to gfn correctly

2020-10-06 Thread Masami Hiramatsu
On Tue, 6 Oct 2020 10:56:52 -0700 (PDT) Stefano Stabellini wrote: > On Tue, 6 Oct 2020, Masami Hiramatsu wrote: > > On Mon, 5 Oct 2020 18:13:22 -0700 (PDT) > > Stefano Stabellini wrote: > > > > > On Mon, 5 Oct 2020, Julien Grall wrote: > > > > Hi Ma

[PATCH v2] arm/arm64: xen: Fix to convert percpu address to gfn correctly

2020-10-06 Thread Masami Hiramatsu
! exitcode=0x000b ]--- This issue has been introduced by commit 9a9ab3cc00dc ("xen/arm: SMP support"). Signed-off-by: Masami Hiramatsu Reviewed-by: Stefano Stabellini --- arch/arm/xen/enlighten.c |2 +- include/xen/arm/page.h |3 +++ 2 files changed, 4 insertions(+),

Re: [PATCH] arm/arm64: xen: Fix to convert percpu address to gfn correctly

2020-10-05 Thread Masami Hiramatsu
On Tue, 6 Oct 2020 11:40:58 +0900 Masami Hiramatsu wrote: > On Mon, 5 Oct 2020 18:13:22 -0700 (PDT) > Stefano Stabellini wrote: > > > On Mon, 5 Oct 2020, Julien Grall wrote: > > > Hi Masami, > > > > > > On 05/10/2020 14:39, Masami Hiramatsu wrote:

Re: [PATCH] arm/arm64: xen: Fix to convert percpu address to gfn correctly

2020-10-05 Thread Masami Hiramatsu
On Mon, 5 Oct 2020 18:13:22 -0700 (PDT) Stefano Stabellini wrote: > On Mon, 5 Oct 2020, Julien Grall wrote: > > Hi Masami, > > > > On 05/10/2020 14:39, Masami Hiramatsu wrote: > > > Use per_cpu_ptr_to_phys() instead of virt_to_phys() for pe

Re: [PATCH] arm/arm64: xen: Fix to convert percpu address to gfn correctly

2020-10-05 Thread Masami Hiramatsu
On Mon, 5 Oct 2020 19:18:47 +0100 Julien Grall wrote: > Hi Masami, > > On 05/10/2020 14:39, Masami Hiramatsu wrote: > > Use per_cpu_ptr_to_phys() instead of virt_to_phys() for per-cpu > > address conversion. > > > > In xen_starting_cpu(), per-cpu xen_vcpu_inf

[PATCH] arm/arm64: xen: Fix to convert percpu address to gfn correctly

2020-10-05 Thread Masami Hiramatsu
]--- [0.832076] Kernel panic - not syncing: Attempted to kill init! exitcode=0x000b [0.839815] ---[ end Kernel panic - not syncing: Attempted to kill init! exitcode=0x000b ]--- Fixes: 250c9af3d831 ("arm/xen: Add support for 64KB page granularity") Signed-off-by: Masami

Re: [PATCH 0/4] xen/arm: Unbreak ACPI

2020-09-28 Thread Masami Hiramatsu
Hi, I've missed the explanation of the attached patch. This prototype patch was also needed for booting up the Xen on my box (for the system which has no SPCR). Thank you, 2020年9月28日(月) 15:47 Masami Hiramatsu : > > Hello, > > This made progress with my Xen boot on DeveloperBox ( &

Re: [PATCH 0/4] xen/arm: Unbreak ACPI

2020-09-28 Thread Masami Hiramatsu
-- > xen/include/asm-arm/setup.h | 2 +- > xen/include/xen/acpi.h | 1 + > 7 files changed, 123 insertions(+), 38 deletions(-) > > -- > 2.17.1 > -- Masami Hiramatsu xen-acpi-hide-uart-address Description: Binary data

[Xen-devel] [tip: x86/core] x86/asm: Allow to pass macros to __ASM_FORM()

2019-10-18 Thread tip-bot2 for Masami Hiramatsu
The following commit has been merged into the x86/core branch of tip: Commit-ID: f7919fd943abf0c77aed4441ea9897a323d132f5 Gitweb: https://git.kernel.org/tip/f7919fd943abf0c77aed4441ea9897a323d132f5 Author:Masami Hiramatsu AuthorDate:Fri, 06 Sep 2019 22:13:48 +09:00

[Xen-devel] [tip: x86/core] x86: xen: insn: Decode Xen and KVM emulate-prefix signature

2019-10-18 Thread tip-bot2 for Masami Hiramatsu
The following commit has been merged into the x86/core branch of tip: Commit-ID: 4d65adfcd1196818659d3bd9b42dccab291e1751 Gitweb: https://git.kernel.org/tip/4d65adfcd1196818659d3bd9b42dccab291e1751 Author:Masami Hiramatsu AuthorDate:Fri, 06 Sep 2019 22:14:10 +09:00

[Xen-devel] [tip: x86/core] x86: kprobes: Prohibit probing on instruction which has emulate prefix

2019-10-18 Thread tip-bot2 for Masami Hiramatsu
The following commit has been merged into the x86/core branch of tip: Commit-ID: 004e8dce9c5595697951f7cd0e9f66b35c92265e Gitweb: https://git.kernel.org/tip/004e8dce9c5595697951f7cd0e9f66b35c92265e Author:Masami Hiramatsu AuthorDate:Fri, 06 Sep 2019 22:14:20 +09:00

[Xen-devel] [tip: x86/core] x86: xen: kvm: Gather the definition of emulate prefixes

2019-10-18 Thread tip-bot2 for Masami Hiramatsu
The following commit has been merged into the x86/core branch of tip: Commit-ID: b3dc0695fa40c3b280230fb6fb7fb7a94ce28bf4 Gitweb: https://git.kernel.org/tip/b3dc0695fa40c3b280230fb6fb7fb7a94ce28bf4 Author:Masami Hiramatsu AuthorDate:Fri, 06 Sep 2019 22:13:59 +09:00

Re: [Xen-devel] [PATCH -tip v4 0/4] x86: kprobes: Prohibit kprobes on Xen/KVM emulate prefixes

2019-10-16 Thread Masami Hiramatsu
Hi Peter, On Wed, 9 Oct 2019 14:31:06 +0200 Peter Zijlstra wrote: > On Tue, Sep 17, 2019 at 03:14:03PM +0900, Masami Hiramatsu wrote: > > Hi Peter, > > > > Could you review this version? > > These look good to me; shall I merge them or what was the plan? Thanks for

Re: [Xen-devel] [PATCH -tip v4 0/4] x86: kprobes: Prohibit kprobes on Xen/KVM emulate prefixes

2019-09-17 Thread Masami Hiramatsu
Hi Peter, Could you review this version? Thank you, On Fri, 6 Sep 2019 22:13:37 +0900 Masami Hiramatsu wrote: > Hi, > > Here is the 4th version of patches to handle Xen/KVM emulate > prefix by x86 instruction decoder. > > These patches allow x86 instruction decoder to de

[Xen-devel] [PATCH -tip v4 4/4] x86: kprobes: Prohibit probing on instruction which has emulate prefix

2019-09-06 Thread Masami Hiramatsu
Prohibit probing on instruction which has XEN_EMULATE_PREFIX or KVM's emulate prefix. Since that prefix is a marker for Xen and KVM, if we modify the marker by kprobe's int3, that doesn't work as expected. Signed-off-by: Masami Hiramatsu --- arch/x86/kernel/kprobes/core.c |4 1 file

[Xen-devel] [PATCH -tip v4 3/4] x86: xen: insn: Decode Xen and KVM emulate-prefix signature

2019-09-06 Thread Masami Hiramatsu
and 'ud2a; .ascii "kvm"', it just counts the length, set insn.emulate_prefix_size and fold it with the next instruction. In other words, the signature and the next instruction is treated as a single instruction. Reported-by: Josh Poimboeuf Signed-off-by: Masami Hiramatsu Acke

[Xen-devel] [PATCH -tip v4 2/4] x86: xen: kvm: Gather the definition of emulate prefixes

2019-09-06 Thread Masami Hiramatsu
Gather the emulate prefixes, which forcibly make the following instruction emulated on virtualization, in one place. Suggested-by: Peter Zijlstra Signed-off-by: Masami Hiramatsu --- arch/x86/include/asm/emulate_prefix.h | 14 ++ arch/x86/include/asm/xen/interface.h | 11

[Xen-devel] [PATCH -tip v4 1/4] x86/asm: Allow to pass macros to __ASM_FORM()

2019-09-06 Thread Masami Hiramatsu
Use __stringify() at __ASM_FORM() so that user can pass code including macros to __ASM_FORM(). Signed-off-by: Masami Hiramatsu --- arch/x86/include/asm/asm.h |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/arch/x86/include/asm/asm.h b/arch/x86/include/asm/asm.h

[Xen-devel] [PATCH -tip v4 0/4] x86: kprobes: Prohibit kprobes on Xen/KVM emulate prefixes

2019-09-06 Thread Masami Hiramatsu
emulate_prefix.h to sync check list. This series can be applied on -tip master branch which has merged Josh's objtool/perf sharing common x86 insn decoder series. Thank you, --- Masami Hiramatsu (4): x86/asm: Allow to pass macros to __ASM_FORM() x86: xen: kvm: Gather the definition

Re: [Xen-devel] [PATCH -tip v3 1/2] x86: xen: insn: Decode Xen and KVM emulate-prefix signature

2019-09-06 Thread Masami Hiramatsu
On Fri, 6 Sep 2019 09:34:36 +0200 Peter Zijlstra wrote: > On Fri, Sep 06, 2019 at 10:45:48AM +0900, Masami Hiramatsu wrote: > > > diff --git a/arch/x86/include/asm/xen/interface.h > > b/arch/x86/include/asm/xen/interface.h > > index 62ca03ef5c65..fe33a9798708 100644 &g

Re: [Xen-devel] [PATCH -tip v3 1/2] x86: xen: insn: Decode Xen and KVM emulate-prefix signature

2019-09-06 Thread Masami Hiramatsu
On Fri, 6 Sep 2019 17:45:19 +0900 Masami Hiramatsu wrote: > > > > How about we make this asm/virt_prefix.h or something and include: > > > > /* > > * Virt escape sequences to trigger instruction emulation; > > * ideally these would decode to

Re: [Xen-devel] [PATCH -tip v3 1/2] x86: xen: insn: Decode Xen and KVM emulate-prefix signature

2019-09-06 Thread Masami Hiramatsu
On Fri, 6 Sep 2019 09:34:36 +0200 Peter Zijlstra wrote: > On Fri, Sep 06, 2019 at 10:45:48AM +0900, Masami Hiramatsu wrote: > > > diff --git a/arch/x86/include/asm/xen/interface.h > > b/arch/x86/include/asm/xen/interface.h > > index 62ca03ef5c65..fe33a9798708 100644 &g

[Xen-devel] [PATCH -tip v3 2/2] x86: kprobes: Prohibit probing on instruction which has emulate prefix

2019-09-05 Thread Masami Hiramatsu
Prohibit probing on instruction which has XEN_EMULATE_PREFIX or KVM's emulate prefix. Since that prefix is a marker for Xen and KVM, if we modify the marker by kprobe's int3, that doesn't work as expected. Signed-off-by: Masami Hiramatsu --- arch/x86/kernel/kprobes/core.c |4 1 file

[Xen-devel] [PATCH -tip v3 1/2] x86: xen: insn: Decode Xen and KVM emulate-prefix signature

2019-09-05 Thread Masami Hiramatsu
and 'ud2a; .ascii "kvm"', it just counts the length, set insn.emulate_prefix_size and fold it with the next instruction. In other words, the signature and the next instruction is treated as a single instruction. Reported-by: Josh Poimboeuf Signed-off-by: Masami Hiramatsu Acke

[Xen-devel] [PATCH -tip v3 0/2] x86: kprobes: Prohibit kprobes on Xen/KVM emulate prefixes

2019-09-05 Thread Masami Hiramatsu
fix for it. In this 3rd version, I just fixed tools/perf/check-headers.sh so that it can ignore the difference of xen/prefix header path. Thank you, --- Masami Hiramatsu (2): x86: xen: insn: Decode Xen and KVM emulate-prefix signature x86: kprobes: Prohibit probing on instruction which has emul

Re: [Xen-devel] [PATCH -tip v2 1/2] x86: xen: insn: Decode Xen and KVM emulate-prefix signature

2019-09-05 Thread Masami Hiramatsu
On Thu, 5 Sep 2019 20:13:50 -0500 Josh Poimboeuf wrote: > On Fri, Sep 06, 2019 at 09:50:19AM +0900, Masami Hiramatsu wrote: > > --- a/tools/objtool/sync-check.sh > > +++ b/tools/objtool/sync-check.sh > > @@ -4,6 +4,7 @@ > > FILES=' > > arch/x86/include/asm/i

[Xen-devel] [PATCH -tip v2 2/2] x86: kprobes: Prohibit probing on instruction which has emulate prefix

2019-09-05 Thread Masami Hiramatsu
Prohibit probing on instruction which has XEN_EMULATE_PREFIX or KVM's emulate prefix. Since that prefix is a marker for Xen and KVM, if we modify the marker by kprobe's int3, that doesn't work as expected. Signed-off-by: Masami Hiramatsu --- arch/x86/kernel/kprobes/core.c |4 1 file

[Xen-devel] [PATCH -tip v2 1/2] x86: xen: insn: Decode Xen and KVM emulate-prefix signature

2019-09-05 Thread Masami Hiramatsu
and 'ud2a; .ascii "kvm"', it just counts the length, set insn.emulate_prefix_size and fold it with the next instruction. In other words, the signature and the next instruction is treated as a single instruction. Reported-by: Josh Poimboeuf Signed-off-by: Masami Hiramatsu --- Changes i

[Xen-devel] [PATCH -tip v2 0/2] x86: kprobes: Prohibit kprobes on Xen/KVM emulate prefixes

2019-09-05 Thread Masami Hiramatsu
you, --- Masami Hiramatsu (2): x86: xen: insn: Decode Xen and KVM emulate-prefix signature x86: kprobes: Prohibit probing on instruction which has emulate prefix arch/x86/include/asm/insn.h |6 + arch/x86/include/asm/xen/interface.h|7 -- arch/

Re: [Xen-devel] [PATCH -tip 0/2] x86: Prohibit kprobes on XEN_EMULATE_PREFIX

2019-09-05 Thread Masami Hiramatsu
emulate the following instruction". > > The name "prefix" is unfortunate.  It was named thusly because from the > programmers point of view, it was something you put before the CPUID > instruction which wanted to be emulated.  It is no

Re: [Xen-devel] [PATCH -tip 0/2] x86: Prohibit kprobes on XEN_EMULATE_PREFIX

2019-09-05 Thread Masami Hiramatsu
On Thu, 5 Sep 2019 20:32:24 +0900 Masami Hiramatsu wrote: > On Thu, 5 Sep 2019 08:54:17 +0100 > Andrew Cooper wrote: > > > On 05/09/2019 02:49, Masami Hiramatsu wrote: > > > On Wed, 4 Sep 2019 12:54:55 +0100 > > > Andrew Cooper wrote: > > > > >

[Xen-devel] [OT] Re: [PATCH -tip 0/2] x86: Prohibit kprobes on XEN_EMULATE_PREFIX

2019-09-05 Thread Masami Hiramatsu
0007 : 7: 0f 0b ud2 9: 6b 76 6d 0f imul $0xf,0x6d(%rsi),%esi d: a2 .byte 0xa2 This will disturbe decoding bytestream. Anyway, with the next version it will be fixed in x86 insn decoder. Thanks, -- Masami Hiramatsu ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH -tip 0/2] x86: Prohibit kprobes on XEN_EMULATE_PREFIX

2019-09-05 Thread Masami Hiramatsu
On Thu, 5 Sep 2019 08:54:17 +0100 Andrew Cooper wrote: > On 05/09/2019 02:49, Masami Hiramatsu wrote: > > On Wed, 4 Sep 2019 12:54:55 +0100 > > Andrew Cooper wrote: > > > >> On 04/09/2019 12:45, Masami Hiramatsu wrote: > >>> Hi, > >>> >

Re: [Xen-devel] [PATCH -tip 0/2] x86: Prohibit kprobes on XEN_EMULATE_PREFIX

2019-09-04 Thread Masami Hiramatsu
On Wed, 4 Sep 2019 12:54:55 +0100 Andrew Cooper wrote: > On 04/09/2019 12:45, Masami Hiramatsu wrote: > > Hi, > > > > These patches allow x86 instruction decoder to decode > > xen-cpuid which has XEN_EMULATE_PREFIX, and prohibit > > kprobes to probe on it. >

[Xen-devel] [PATCH -tip 0/2] x86: Prohibit kprobes on XEN_EMULATE_PREFIX

2019-09-04 Thread Masami Hiramatsu
. This series can be applied on -tip master branch which has merged Josh's objtool/perf sharing common x86 insn decoder series. Thank you, --- Masami Hiramatsu (2): x86: xen: insn: Decode XEN_EMULATE_PREFIX correctly x86: kprobes: Prohibit probing on instruction which has Xen prefix

[Xen-devel] [PATCH -tip 1/2] x86: xen: insn: Decode XEN_EMULATE_PREFIX correctly

2019-09-04 Thread Masami Hiramatsu
as just a dummy prefix, so no affect for decoding opcode and operand. Reported-by: Josh Poimboeuf Signed-off-by: Masami Hiramatsu --- arch/x86/include/asm/insn.h |2 + arch/x86/include/asm/xen/interface.h|7 - arch/x86/include/asm/xen/prefix.h | 10 +++ arch

[Xen-devel] [PATCH -tip 2/2] x86: kprobes: Prohibit probing on instruction which has Xen prefix

2019-09-04 Thread Masami Hiramatsu
Prohibit probing on instruction which has XEN_EMULATE_PREFIX (it must be cpuid.) Since that prefix is a marker for Xen, if we modify the marker by kprobe's int3, that doesn't work as expected. Signed-off-by: Masami Hiramatsu --- arch/x86/kernel/kprobes/core.c |4 1 file changed, 4

Re: [Xen-devel] [PATCH] kprobes/x86/xen: blacklist non-attachable xen interrupt functions

2018-12-11 Thread Masami Hiramatsu
On Mon, 10 Dec 2018 16:12:57 +0100 Andrea Righi wrote: > Blacklist symbols in Xen probe-prohibited areas, so that user can see > these prohibited symbols in debugfs. > > See also: a50480cb6d61. Looks good to me, thanks! Acked-by: Masami Hiramatsu > > Signed-of

Re: [Xen-devel] [PATCH v2 09/11] docs: Fix some broken references

2018-05-14 Thread Masami Hiramatsu
f the produced result is valid, removing a few > false-positives. The part of kprobes and trace_kprobe changes look good to me :) Acked-by: Masami Hiramatsu <mhira...@kernel.org> Thank you, > > Signed-off-by: Mauro Carvalho Chehab <mchehab+sams...@kernel.org> > --- > ..