On 6/7/2018 10:36 PM, Manish Jaggi wrote:
> Hi Sameer,
>
>
> On 06/08/2018 05:17 AM, Sameer Goel wrote:
>> Pull common defines for SMMU drives in a local header.
> Can add more detail in commit message?
>>
>> Signed-off-by: Sameer Goel
>> ---
>>
/html/xen-devel/2018-05/msg01693.html
The IORT support will come from [1]. The first revision of this patch
can be seen in [2].
Sameer Goel (6):
Define WARN_ON_ONCE() macro to mirror Linux functionality
passthrough/arm: Modify SMMU driver to use generic device definition
Add verbatim copy of
Pull common defines for SMMU drives in a local header.
Signed-off-by: Sameer Goel
---
xen/drivers/passthrough/arm/smmu-v3.c | 96 +---
xen/drivers/passthrough/arm/smmu.c| 104 +
xen/drivers/passthrough/arm/smmu.h| 125 ++
3
Add a new config item to control compilation for legacy arm SMMU.
Signed-off-by: Sameer Goel
---
xen/drivers/passthrough/arm/Kconfig | 6 ++
xen/drivers/passthrough/arm/Makefile | 2 +-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/xen/drivers/passthrough/arm/Kconfig
b/xen
/linux_compat: Add a Linux compat header
For porting files directly from Linux it is useful to have a function mapping
definitions from Linux to Xen. This file adds common API functions and
other defines that are needed for porting arm SMMU drivers.
Signed-off-by: Sameer Goel
---
xen/arch/arm
Based on commit 7aa8619a66aea52b145e04cbab4f8d6a4e5f3f3b
This is a verbatim snapshot of arm-smmu-v3.c from Linux kernel source
code.
No Xen code has been added and the file is not built.
Signed-off-by: Sameer Goel
---
xen/drivers/passthrough/arm/smmu-v3.c | 2885 +
1
Define WARN_ON_ONCE() macro to mirror Linux functionality.
Signed-off-by: Sameer Goel
Acked-by: Julien Grall
---
xen/arch/arm/xen.lds.S | 1 +
xen/arch/x86/xen.lds.S | 1 +
xen/include/xen/lib.h | 13 +
3 files changed, 15 insertions(+)
diff --git a/xen/arch/arm/xen.lds.S b/xen
Modify the SMMU code to use generic device instead of dt_device_node for
functions that can be used for ACPI based systems too.
Signed-off-by: Sameer Goel
Acked-by: Julien Grall
---
xen/drivers/passthrough/arm/smmu.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff
On 05/25/2018 01:07 AM, Jan Beulich wrote:
On 24.05.18 at 22:23, wrote:
--- a/xen/include/xen/lib.h
+++ b/xen/include/xen/lib.h
@@ -11,6 +11,19 @@
#define BUG_ON(p) do { if (unlikely(p)) BUG(); } while (0)
#define WARN_ON(p) do { if (unlikely(p)) WARN(); } while (0)
+#define WARN_O
On 5/31/2018 11:16 PM, Manish Jaggi wrote:
>
>
> On 05/31/2018 09:27 PM, Sameer Goel wrote:
>>
>> On 5/30/2018 10:13 PM, Manish Jaggi wrote:
>>>
>>> On 05/31/2018 04:31 AM, Sameer Goel wrote:
>>>>>>>> +
>>>>>
On 5/30/2018 10:13 PM, Manish Jaggi wrote:
>
>
> On 05/31/2018 04:31 AM, Sameer Goel wrote:
>>>>>> +
>>>>>> +static int arm_smmu_iommu_domain_init(struct domain *d)
>>>>> Where is iommu_domain initialized?
>>>>> The funct
+
+static int arm_smmu_iommu_domain_init(struct domain *d)
>>> Where is iommu_domain initialized?
>>> The function does not use a iommu_domain * variable
Please check iommu.c 2 levels up.
Thanks,
Sameer
>>>
>>
>
>
> ___
> Xen-devel mailing
> + struct arm_smmu_xen_domain *xen_domain;
>
> Why use smmu_domain at one place and xen_domain at another ?
> Intuitively xen_domain should mean a VM.
>
> Doesn't is look confusing?
>
> Please take a look, I have pointed out the other specific ones below.
>>
On 5/25/2018 1:10 AM, Jan Beulich wrote:
On 24.05.18 at 22:26, wrote:
>> On 05/24/2018 01:57 AM, Jan Beulich wrote:
>> On 24.05.18 at 02:46, wrote:
--- /dev/null
+++ b/xen/include/xen/linux_compat.h
>>> I continue to dislike the idea of having a header with these contents in
On 05/24/2018 01:58 AM, Jan Beulich wrote:
On 24.05.18 at 02:46, wrote:
Pull common defines for SMMU drives in a local header.
Signed-off-by: Sameer Goel
---
xen/drivers/passthrough/arm/arm_smmu.h | 125 +
This being a local header - why the arm_ prefix?
I'l
. I don't think that
the variable names are inappropriate. Unless there is a very specific
issue with the variable names, I think we should stick with the current
version.
On 05/24/2018 06:16 AM, Sameer Goel wrote:
This driver follows an approach similar to smmu driver. The intent here
On 05/24/2018 01:57 AM, Jan Beulich wrote:
On 24.05.18 at 02:46, wrote:
--- /dev/null
+++ b/xen/include/xen/linux_compat.h
I continue to dislike the idea of having a header with these contents in this
location.
As explained previously this header can be used for the any driver that
we want
On 05/24/2018 01:53 AM, Jan Beulich wrote:
On 24.05.18 at 02:46, wrote:
Port WARN_ON_ONCE macro from Linux.
In such a case you should justify adjustments you've made:
I can add more details, but have mostly just changed variable names. The
macro is self explanatory.
Should I just change t
specific.
On 05/24/2018 06:16 AM, Sameer Goel wrote:
This driver follows an approach similar to smmu driver. The intent here
is to reuse as much Linux code as possible.
- Glue code has been introduced to bridge the API calls.
- Called Linux functions from the Xen IOMMU function calls.
- Xen
Modify the SMMU code to use generic device instead of dt_device_node for
functions that can be used for ACPI based systems too.
Signed-off-by: Sameer Goel
Acked-by: Julien Grall
---
xen/drivers/passthrough/arm/smmu.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff
Add a new config item to control compilation for legacy arm SMMU.
Signed-off-by: Sameer Goel
---
xen/drivers/passthrough/arm/Kconfig | 6 ++
xen/drivers/passthrough/arm/Makefile | 2 +-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/xen/drivers/passthrough/arm/Kconfig
b/xen
Based on commit 7aa8619a66aea52b145e04cbab4f8d6a4e5f3f3b
This is a verbatim snapshot of arm-smmu-v3.c from Linux kernel source
code.
No Xen code has been added and the file is not built.
Signed-off-by: Sameer Goel
---
xen/drivers/passthrough/arm/smmu-v3.c | 2885 +
1
/linux_compat: Add a Linux compat header
For porting files directly from Linux it is useful to have a function mapping
definitions from Linux to Xen. This file adds common API functions and
other defines that are needed for porting arm SMMU drivers.
Signed-off-by: Sameer Goel
---
xen/arch/arm
Pull common defines for SMMU drives in a local header.
Signed-off-by: Sameer Goel
---
xen/drivers/passthrough/arm/arm_smmu.h | 125 +
xen/drivers/passthrough/arm/smmu-v3.c | 96 +--
xen/drivers/passthrough/arm/smmu.c | 104 +---
3
.
[1] https://lists.xenproject.org/archives/html/xen-devel/2018-03/msg01108.html
[2] https://lists.xenproject.org/archives/html/xen-devel/2018-02/msg00713.html
The IORT support will come from [1].
Sameer Goel (6):
Port WARN_ON_ONCE() from Linux
passthrough/arm: Modify SMMU driver to use generic
Port WARN_ON_ONCE macro from Linux.
Signed-off-by: Sameer Goel
Acked-by: Julien Grall
---
xen/arch/arm/xen.lds.S | 1 +
xen/arch/x86/xen.lds.S | 1 +
xen/include/xen/lib.h | 13 +
3 files changed, 15 insertions(+)
diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S
On 2/9/2018 4:02 AM, Roger Pau Monné wrote:
> On Fri, Feb 09, 2018 at 10:51:01AM +, Julien Grall wrote:
>> Hi,
>>
>> On 02/09/2018 10:43 AM, Roger Pau Monné wrote:
+unsigned int type;
+};
+
+#define resource_size(res) ((res)->size)
+
+#define platform_device
On 2/13/2018 2:46 AM, Jan Beulich wrote:
>>>> On 09.02.18 at 11:47, wrote:
>> On Fri, Feb 09, 2018 at 10:45:25AM +, Julien Grall wrote:
>>> Hi,
>>>
>>> On 02/09/2018 10:29 AM, Roger Pau Monné wrote:
>>>> On Thu, Feb 08, 2018 at 08
On 3/10/2018 10:53 AM, Manish Jaggi wrote:
> Hi Sameer,
>
>
> On 02/09/2018 08:40 AM, Sameer Goel wrote:
>> This driver follows an approach similar to smmu driver. The intent here
>> is to reuse as much Linux code as possible.
>> - Glue code has been intr
the series unless stated otherwise.
I am working on addressing the comments in this patch set. Please expect
something by end of next week.
>
> Cheers,
>
>>
>> -Regards
>> Manish
>>>
>>> On 03/10/2018 11:23 PM, Manish Jaggi wrote:
>>>> Hi
On 1/23/2018 8:18 AM, Julien Grall wrote:
> Hi Sameer,
>
> On 19/12/17 03:17, Sameer Goel wrote:
>> + if (!dtprop)
>> + return -EINVAL;
>> +
>> + if (!dtprop->value)
>> + return -ENODATA;
>> + }
>> +
>
On 1/23/2018 9:51 AM, Roger Pau Monné wrote:
> On Mon, Dec 18, 2017 at 08:16:58PM -0700, Sameer Goel wrote:
>> For porting files directly from Linux it is useful to have a function mapping
>> definitions from Linux to Xen. This file adds common API functions and
>> other de
On 2/9/2018 3:51 AM, Julien Grall wrote:
>
>>
>>> diff --git a/xen/drivers/passthrough/arm/smmu.c
>>> b/xen/drivers/passthrough/arm/smmu.c
>>> index ad956d5b8d..4c04391e21 100644
>>> --- a/xen/drivers/passthrough/arm/smmu.c
>>> +++ b/xen/drivers/passthrough/arm/smmu.c
>>> @@ -41,6 +41,7 @@
>>>
Add a new config item to control compilation for legacy arm SMMU.
Signed-off-by: Sameer Goel
---
xen/drivers/passthrough/arm/Kconfig | 6 ++
xen/drivers/passthrough/arm/Makefile | 2 +-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/xen/drivers/passthrough/arm/Kconfig
b/xen
Pull common defines for SMMU drives in a local header.
Signed-off-by: Sameer Goel
---
xen/drivers/passthrough/arm/arm_smmu.h | 125 +
xen/drivers/passthrough/arm/smmu-v3.c | 96 +
xen/drivers/passthrough/arm/smmu.c | 104
Changing the name of the macro from LOG_2 to ilog2.This makes the function name
similar to its Linux counterpart. Since, this is not used in multiple places,
the code churn is minimal.
This change helps in porting unchanged code from Linux.
Signed-off-by: Sameer Goel
---
xen/arch/x86/x86_64
/linux_compat: Add a Linux compat header
For porting files directly from Linux it is useful to have a function mapping
definitions from Linux to Xen. This file adds common API functions and
other defines that are needed for porting arm SMMU drivers.
Signed-off-by: Sameer Goel
---
xen/arch/arm
Based on commit 7aa8619a66aea52b145e04cbab4f8d6a4e5f3f3b
This is a verbatim snapshot of arm-smmu-v3.c from Linux kernel source
code.
No Xen code has been added and the file is not built.
Signed-off-by: Sameer Goel
---
xen/drivers/passthrough/arm/smmu-v3.c | 2885
Port WARN_ON_ONCE macro from Linux.
Signed-off-by: Sameer Goel
Acked-by: Julien Grall
---
xen/arch/arm/xen.lds.S | 1 +
xen/arch/x86/xen.lds.S | 1 +
xen/include/xen/lib.h | 13 +
3 files changed, 15 insertions(+)
diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S
Modify the SMMU code to use generic device instead of dt_device_node for
functions that can be used for ACPI based systems too.
Signed-off-by: Sameer Goel
Acked-by: Julien Grall
---
xen/drivers/passthrough/arm/smmu.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff
.html
[2] https://lists.xenproject.org/archives/html/xen-devel/2018-01/msg7.html
Sameer Goel (7):
Port WARN_ON_ONCE() from Linux
xen/bitops: Rename LOG_2 to ilog2
passthrough/arm: Modify SMMU driver to use generic device definition
Add verbatim copy of arm-smmu-v3.c from Linux
xen
On 1/2/2018 2:28 AM, manish.ja...@linaro.org wrote:
> From: Manish Jaggi
>
> Add kalloc kfree functions from linux kernel.
>
> Signed-off-by: Manish Jaggi
> ---
> xen/include/xen/kernel.h | 10 ++
> 1 file changed, 10 insertions(+)
>
> diff --git a/xen/include/xen/kernel.h b/xen/include
On 1/2/2018 2:28 AM, manish.ja...@linaro.org wrote:
> From: Manish Jaggi
>
> This patch adds to_pci_dev macro
>
> Signed-off-by: Manish Jaggi
> ---
> xen/include/xen/pci.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/xen/include/xen/pci.h b/xen/include/xen/pci.h
> index 43f21251
On 1/23/2018 9:13 AM, Wei Liu wrote:
> On Mon, Dec 18, 2017 at 08:16:56PM -0700, Sameer Goel wrote:
>> Port WARN_ON_ONCE macro from Linux.
>>
>> Signed-off-by: Sameer Goel
>> ---
>> xen/include/xen/lib.h | 11 +++
>> 1 file changed, 11 insertion
Port WARN_ON_ONCE macro from Linux.
Signed-off-by: Sameer Goel
---
xen/include/xen/lib.h | 11 +++
1 file changed, 11 insertions(+)
diff --git a/xen/include/xen/lib.h b/xen/include/xen/lib.h
index ed00ae1379..83206c0848 100644
--- a/xen/include/xen/lib.h
+++ b/xen/include/xen/lib.h
For porting files directly from Linux it is useful to have a function mapping
definitions from Linux to Xen. This file adds common API functions and
other defines that are needed for porting arm SMMU drivers.
Signed-off-by: Sameer Goel
---
xen/include/xen/linux_compat.h | 81
-by: Sameer Goel
---
xen/arch/arm/p2m.c| 1 +
xen/drivers/Kconfig | 2 +
xen/drivers/passthrough/arm/Kconfig | 8 +
xen/drivers/passthrough/arm/Makefile | 1 +
xen/drivers/passthrough/arm/smmu-v3.c | 880 --
5 files
Modify the SMMU code to use generic device instead of dt_device_node for
functions that can be used for ACPI based systems too.
Signed-off-by: Sameer Goel
---
xen/drivers/passthrough/arm/smmu.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/xen/drivers
/html/xen-devel/2017-12/msg00242.html
[2] https://www.mail-archive.com/xen-devel@lists.xen.org/msg128989.html
Sameer Goel (8):
Port WARN_ON_ONCE() from Linux
xen/bitops: Rename LOG_2 to ilog2
xen/linux_compat: Add a Linux compat header
passthrough/arm: Modify SMMU driver to use generic device
Based on commit 7aa8619a66aea52b145e04cbab4f8d6a4e5f3f3b
This is a verbatim snapshot of arm-smmu-v3.c from Linux kernel source
code.
No Xen code has been added and the file is not built.
Signed-off-by: Sameer Goel
---
xen/drivers/passthrough/arm/smmu-v3.c | 2885
Add a new config item to control compilation for legacy arm SMMU.
Signed-off-by: Sameer Goel
---
xen/drivers/passthrough/arm/Kconfig | 6 ++
xen/drivers/passthrough/arm/Makefile | 2 +-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/xen/drivers/passthrough/arm/Kconfig
b/xen
Changing the name of the macro from LOG_2 to ilog2.This makes the function name
similar to its Linux counterpart. Since, this is not used in mutiple places, so
the code churn is minimal.
This change helps in porting unchanged code from Linux.
Signed-off-by: Sameer Goel
---
xen/arch/x86/x86_64
Pull common defines for SMMU drivers in a local header.
Signed-off-by: Sameer Goel
---
xen/drivers/passthrough/arm/arm_smmu.h | 113 +
xen/drivers/passthrough/arm/smmu-v3.c | 96 ++--
xen/drivers/passthrough/arm/smmu.c | 104
.
- Addition of a common header for arm smmu defines.
- Rebase of the SMMUv3 driver to the driver in linux kernel 4.14 rc7.
[1] https://www.mail-archive.com/xen-devel@lists.xen.org/msg123077.html
[2] https://www.mail-archive.com/xen-devel@lists.xen.org/msg128989.html
Sameer Goel (4):
Port WARN_ON_ONCE
For porting files from Linux it is useful to have a Linux API to Xen API
mapping header at a common location.
This file adds common API functions and other defines that are needed for
porting arm SMMU drivers.
---
xen/include/xen/linux_compat.h | 106 +
1 f
Port WARN_ON_ONCE macro from Linux. A return value is expected from this
macro, so the implementation does not follow the Xen convention of wrapping
macros in a do..while.
---
xen/include/xen/lib.h | 11 +++
1 file changed, 11 insertions(+)
diff --git a/xen/include/xen/lib.h b/xen/includ
*/
- New config items for SMMUv3 and legacy SMMU have been defined.
Signed-off-by: Sameer Goel
---
xen/drivers/Kconfig| 2 +
xen/drivers/passthrough/arm/Kconfig| 14 +
xen/drivers/passthrough/arm/Makefile | 3 +-
xen/drivers/passthrough/arm/arm_smmu.h | 189
Based on commit 7aa8619a66aea52b145e04cbab4f8d6a4e5f3f3b
This is a verbatim snapshot of arm-smmu-v3.c from Linux kernel source
code.
No Xen code has been added and the file is not built.
---
xen/drivers/passthrough/arm/smmu-v3.c | 2885 +
1 file changed, 2885 insert
58 matches
Mail list logo
