Re: [Xen-devel] [PATCH] x86/mmcfg: Remove redundant code in pci_mmcfg_reject_broken()

[Jan Beulich]

>>> On 16.08.18 at 07:10,  wrote:
> No functional change.
> 
> Signed-off-by: Zhenzhong Duan 

Acked-by: Jan Beulich 

Albeit I would have wished you would have taken the opportunity
to, at the very least, also move cfg's declaration into the for()
scope. There's obvious further trivial cleanup potential in the
function.

Jan

> --- a/xen/arch/x86/x86_64/mmconfig-shared.c
> +++ b/xen/arch/x86/x86_64/mmconfig-shared.c
> @@ -371,8 +371,6 @@ static bool_t __init pci_mmcfg_reject_broken(void)
>  (pci_mmcfg_config[0].address == 0))
>  return 0;
>  
> -cfg = _mmcfg_config[0];
> -
>  for (i = 0; i < pci_mmcfg_config_num; i++) {
>  u64 addr, size;
>  
> -- 
> 1.7.3





___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [PATCH] x86/mmcfg: Remove redundant code in pci_mmcfg_reject_broken()

[Zhenzhong Duan]

No functional change.

Signed-off-by: Zhenzhong Duan 
---
 xen/arch/x86/x86_64/mmconfig-shared.c |2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/xen/arch/x86/x86_64/mmconfig-shared.c 
b/xen/arch/x86/x86_64/mmconfig-shared.c
index 7c3b7fd..4a6ca26 100644
--- a/xen/arch/x86/x86_64/mmconfig-shared.c
+++ b/xen/arch/x86/x86_64/mmconfig-shared.c
@@ -371,8 +371,6 @@ static bool_t __init pci_mmcfg_reject_broken(void)
 (pci_mmcfg_config[0].address == 0))
 return 0;
 
-cfg = _mmcfg_config[0];
-
 for (i = 0; i < pci_mmcfg_config_num; i++) {
 u64 addr, size;
 
-- 
1.7.3

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel