Re: [Xen-devel] [PATCH v3] xen: oprofile/nmi_int.c: Drop unwanted sexual reference

2018-07-12 Thread Jan Beulich 
>>> On 12.07.18 at 17:39,  wrote:
> Ian Jackson writes ("[PATCH v3] xen: oprofile/nmi_int.c: Drop unwanted sexual 
> reference"):
>> This is not really very nice.
>> 
>> This line doesn't have much value in itself.  The rest of this comment
>> block is pretty clear what it wants to convey.  So delete it.
>> 
>> (While we are here, adopt the CODING_STYLE-mandated formatting.)
> 
> Thanks, everyone, now committed.
> 
> Jan, can you queue this up for appropriate backports, or would you
> like me to put it on my list ?

I've queued it here.

Jan



___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v3] xen: oprofile/nmi_int.c: Drop unwanted sexual reference

2018-07-12 Thread Ian Jackson 
Ian Jackson writes ("[PATCH v3] xen: oprofile/nmi_int.c: Drop unwanted sexual 
reference"):
> This is not really very nice.
> 
> This line doesn't have much value in itself.  The rest of this comment
> block is pretty clear what it wants to convey.  So delete it.
> 
> (While we are here, adopt the CODING_STYLE-mandated formatting.)

Thanks, everyone, now committed.

Jan, can you queue this up for appropriate backports, or would you
like me to put it on my list ?

Ian.

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [PATCH v3] xen: oprofile/nmi_int.c: Drop unwanted sexual reference

2018-07-12 Thread Ian Jackson 
This is not really very nice.

This line doesn't have much value in itself.  The rest of this comment
block is pretty clear what it wants to convey.  So delete it.

(While we are here, adopt the CODING_STYLE-mandated formatting.)

Signed-off-by: Ian Jackson 
Acked-by: Wei Liu 
Acked-by: Lars Kurth 
Acked-by: George Dunlap 
---
v3: Restore erroneously-dropped tab.
v2: Delete the comment entirely.
---
 xen/arch/x86/oprofile/nmi_int.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/x86/oprofile/nmi_int.c b/xen/arch/x86/oprofile/nmi_int.c
index d8f5230..3dfb8fe 100644
--- a/xen/arch/x86/oprofile/nmi_int.c
+++ b/xen/arch/x86/oprofile/nmi_int.c
@@ -182,7 +182,7 @@ int nmi_reserve_counters(void)
if (!allocate_msrs())
return -ENOMEM;
 
-   /* We walk a thin line between law and rape here.
+   /*
 * We need to be careful to install our NMI handler
 * without actually triggering any NMIs as this will
 * break the core code horrifically.
-- 
2.1.4


___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel