Re: [Xen-devel] [PATCH] tools/kdd: silence gcc 8 warning a different way

On Tue, May 22, 2018 at 11:54:36AM +0100, Wei Liu wrote: > I have tried to revert 437e00fea04becc91c1b6bc1c0baa636b067a5cc and > reproduce the gcc 8.1 warning with Arch Linux's gcc 8.1 compiler. > Strangely it doesn't complain. > > I haven't got a Fedora 28 around (which Marek used). It will take

Re: [Xen-devel] [PATCH] tools/kdd: silence gcc 8 warning a different way

I have tried to revert 437e00fea04becc91c1b6bc1c0baa636b067a5cc and reproduce the gcc 8.1 warning with Arch Linux's gcc 8.1 compiler. Strangely it doesn't complain. I haven't got a Fedora 28 around (which Marek used). It will take some time to set that up. Wei.

Re: [Xen-devel] [PATCH] tools/kdd: silence gcc 8 warning a different way

On Mon, Apr 16, 2018 at 02:43:32PM +0200, Marek Marczykowski wrote: > On Mon, Apr 16, 2018 at 06:00:37AM -0600, Jan Beulich wrote: > > >>> On 16.04.18 at 12:33, wrote: > > > On Thu, Apr 12, 2018 at 06:04:49AM -0600, Jan Beulich wrote: > > >> Older gcc doesn't like "#pragma

Re: [Xen-devel] [PATCH] tools/kdd: silence gcc 8 warning a different way

Jan Beulich writes ("Re: [PATCH] tools/kdd: silence gcc 8 warning a different way"): > And I'm not overly happy about it, but couldn't think of a better way > without disabling said warning (or -Werror) altogether for the CU. If > Ian's sketched out approach worked, I'd be quite happy to drop the

Re: [Xen-devel] [PATCH] tools/kdd: silence gcc 8 warning a different way

On Mon, Apr 16, 2018 at 06:00:37AM -0600, Jan Beulich wrote: > >>> On 16.04.18 at 12:33, wrote: > > On Thu, Apr 12, 2018 at 06:04:49AM -0600, Jan Beulich wrote: > >> Older gcc doesn't like "#pragma GCC diagnostic" inside functions. > >> > >> Signed-off-by: Jan Beulich

Re: [Xen-devel] [PATCH] tools/kdd: silence gcc 8 warning a different way

>>> On 16.04.18 at 12:33, wrote: > On Thu, Apr 12, 2018 at 06:04:49AM -0600, Jan Beulich wrote: >> Older gcc doesn't like "#pragma GCC diagnostic" inside functions. >> >> Signed-off-by: Jan Beulich >> >> --- a/tools/debugger/kdd/kdd.c >> +++

Re: [Xen-devel] [PATCH] tools/kdd: silence gcc 8 warning a different way

Wei Liu writes ("Re: [PATCH] tools/kdd: silence gcc 8 warning a different way"): > On Thu, Apr 12, 2018 at 06:04:49AM -0600, Jan Beulich wrote: > > Older gcc doesn't like "#pragma GCC diagnostic" inside functions. Surely this commit message should refer to the previous commit ? I reviewed the

Re: [Xen-devel] [PATCH] tools/kdd: silence gcc 8 warning a different way

On Thu, Apr 12, 2018 at 06:04:49AM -0600, Jan Beulich wrote: > Older gcc doesn't like "#pragma GCC diagnostic" inside functions. > > Signed-off-by: Jan Beulich > > --- a/tools/debugger/kdd/kdd.c > +++ b/tools/debugger/kdd/kdd.c > @@ -695,10 +695,10 @@ static void

Re: [Xen-devel] [PATCH] tools/kdd: silence gcc 8 warning a different way

Cc Tim On Thu, Apr 12, 2018 at 06:04:49AM -0600, Jan Beulich wrote: > Older gcc doesn't like "#pragma GCC diagnostic" inside functions. > > Signed-off-by: Jan Beulich > > --- a/tools/debugger/kdd/kdd.c > +++ b/tools/debugger/kdd/kdd.c > @@ -695,10 +695,10 @@ static void

[Xen-devel] [PATCH] tools/kdd: silence gcc 8 warning a different way

Older gcc doesn't like "#pragma GCC diagnostic" inside functions. Signed-off-by: Jan Beulich --- a/tools/debugger/kdd/kdd.c +++ b/tools/debugger/kdd/kdd.c @@ -695,10 +695,10 @@ static void kdd_handle_read_ctrl(kdd_sta KDD_LOG(s, "Request outside of known control