Re: [Xen-devel] [PATCH] xen/arm: bootfd: Fix indentation in process_multiboot_node()

2019-09-12 Thread Stefano Stabellini 
On Wed, 11 Sep 2019, Volodymyr Babchuk wrote:
> 
> Julien Grall writes:
> 
> > One line in process_multiboot_node() is using hard tab rather than soft
> > tab. So fix it!
> >
> > Signed-off-by: Julien Grall 
> Reviewed-by: Volodymyr Babchuk 

Acked-by: Stefano Stabellini 

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] xen/arm: bootfd: Fix indentation in process_multiboot_node()

2019-09-11 Thread Julien Grall 
On Wed, 11 Sep 2019, 18:36 Volodymyr Babchuk, 
wrote:

>
> Julien Grall writes:
>
> > One line in process_multiboot_node() is using hard tab rather than soft
> > tab. So fix it!
> >
> > Signed-off-by: Julien Grall 
> Reviewed-by: Volodymyr Babchuk 
>
> So, hunting them one-by-one is the preferred way?


I usually do it while I touch code around. I found this one when debugging
a boot regression today. You are welcome to fix the rest although...

I'm asking this
> because there are more of them:
>
> % find xen/arch/arm -type f -name "*.[ch]" -exec grep -lP "\t" {} \;
> xen/arch/arm/traps.c
> xen/arch/arm/acpi/boot.c
> xen/arch/arm/arm32/lib/assembler.h
> xen/arch/arm/arm64/livepatch.c
> xen/arch/arm/arm64/lib/find_next_bit.c
> xen/arch/arm/arm64/insn.c
>

The 4 above are a copy from Linux and therefore hard tab should stay.

Cheers,


>
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] xen/arm: bootfd: Fix indentation in process_multiboot_node()

2019-09-11 Thread Volodymyr Babchuk 

Julien Grall writes:

> One line in process_multiboot_node() is using hard tab rather than soft
> tab. So fix it!
>
> Signed-off-by: Julien Grall 
Reviewed-by: Volodymyr Babchuk 

So, hunting them one-by-one is the preferred way? I'm asking this
because there are more of them:

% find xen/arch/arm -type f -name "*.[ch]" -exec grep -lP "\t" {} \;
xen/arch/arm/traps.c
xen/arch/arm/acpi/boot.c
xen/arch/arm/arm32/lib/assembler.h
xen/arch/arm/arm64/livepatch.c
xen/arch/arm/arm64/lib/find_next_bit.c
xen/arch/arm/arm64/insn.c
xen/arch/arm/alternative.c
xen/arch/arm/bootfdt.c (apparently, I don't have this patch applied)


> ---
>  xen/arch/arm/bootfdt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c
> index 258b057f00..623173bc7f 100644
> --- a/xen/arch/arm/bootfdt.c
> +++ b/xen/arch/arm/bootfdt.c
> @@ -264,7 +264,7 @@ static void __init process_multiboot_node(const void 
> *fdt, int node,
>  case 1: kind = BOOTMOD_RAMDISK; break;
>  default: break;
>  }
> - if ( kind_guess > 1 && has_xsm_magic(start) )
> +if ( kind_guess > 1 && has_xsm_magic(start) )
>  kind = BOOTMOD_XSM;
>  }


-- 
Volodymyr Babchuk at EPAM
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel