Re: [Xen-devel] [PATCH 07/13] libx86: Introduce a helper to serialise msr_{domain, vcpu}_policy objects

2018-07-05 Thread Jan Beulich
>>> On 04.07.18 at 18:56, wrote: > On 04/07/18 10:16, Jan Beulich wrote: >> >>> @@ -325,6 +325,13 @@ typedef struct xen_cpuid_leaf { >>> } xen_cpuid_leaf_t; >>> DEFINE_XEN_GUEST_HANDLE(xen_cpuid_leaf_t); >>> >>> +typedef struct xen_msr_entry { >>> +uint32_t idx; >>> +uint32_t flags;

Re: [Xen-devel] [PATCH 07/13] libx86: Introduce a helper to serialise msr_{domain, vcpu}_policy objects

2018-07-04 Thread Andrew Cooper
On 04/07/18 10:16, Jan Beulich wrote: > >> @@ -325,6 +325,13 @@ typedef struct xen_cpuid_leaf { >> } xen_cpuid_leaf_t; >> DEFINE_XEN_GUEST_HANDLE(xen_cpuid_leaf_t); >> >> +typedef struct xen_msr_entry { >> +uint32_t idx; >> +uint32_t flags; /* Reserved MBZ. */ > ... it remains unclear

Re: [Xen-devel] [PATCH 07/13] libx86: Introduce a helper to serialise msr_{domain, vcpu}_policy objects

2018-07-04 Thread Jan Beulich
>>> On 03.07.18 at 22:55, wrote: > From: Roger Pau Monné > > As with CPUID, the an architectural form is used for representing the MSR Stray "the". Apart from that same remark(s) as for the respective CPUID change, plus ... > @@ -325,6 +325,13 @@ typedef struct xen_cpuid_leaf { > }