Re: [Xen-devel] [PATCH for-4.13] x86: re-order clang no integrated assembler tests

2019-12-03 Thread Jan Beulich
On 03.12.2019 12:04, Roger Pau Monné wrote: > On Tue, Dec 03, 2019 at 11:03:31AM +0100, Jan Beulich wrote: >> Furthermore I think this moving around of logic (which imo >> would better remain at the bottom of the file, well out of >> sight) is only the second best solution to the issue. The >>

Re: [Xen-devel] [PATCH for-4.13] x86: re-order clang no integrated assembler tests

2019-12-03 Thread Roger Pau Monné
On Tue, Dec 03, 2019 at 11:03:31AM +0100, Jan Beulich wrote: > On 02.12.2019 12:29, Roger Pau Monne wrote: > > The tests to check whether the integrated assembler is capable of > > building Xen should be performed before testing any assembler > > features, or else the feature specific tests would

Re: [Xen-devel] [PATCH for-4.13] x86: re-order clang no integrated assembler tests

2019-12-03 Thread Jan Beulich
On 02.12.2019 12:29, Roger Pau Monne wrote: > The tests to check whether the integrated assembler is capable of > building Xen should be performed before testing any assembler > features, or else the feature specific tests would be stale if the > integrated assembler is disabled afterwards. > >

Re: [Xen-devel] [PATCH for-4.13] x86: re-order clang no integrated assembler tests

2019-12-02 Thread Roger Pau Monné
On Mon, Dec 02, 2019 at 11:31:55AM +, Andrew Cooper wrote: > On 02/12/2019 11:29, Roger Pau Monne wrote: > > The tests to check whether the integrated assembler is capable of > > building Xen should be performed before testing any assembler > > features, or else the feature specific tests

Re: [Xen-devel] [PATCH for-4.13] x86: re-order clang no integrated assembler tests

2019-12-02 Thread Andrew Cooper
On 02/12/2019 11:29, Roger Pau Monne wrote: > The tests to check whether the integrated assembler is capable of > building Xen should be performed before testing any assembler > features, or else the feature specific tests would be stale if the > integrated assembler is disabled afterwards. > >