Re: [PATCH] x86/pv: Drop HYPERVISOR_COMPAT_VIRT_START()

2021-04-28 Thread Jan Beulich
On 27.04.2021 20:05, Andrew Cooper wrote: > On 27/04/2021 14:18, Jan Beulich wrote: >> On 27.04.2021 15:02, Andrew Cooper wrote: >>> --- a/xen/include/asm-x86/config.h >>> +++ b/xen/include/asm-x86/config.h >>> @@ -254,21 +254,16 @@ extern unsigned char boot_edid_info[128]; >>> >>> /* This is

Re: [PATCH] x86/pv: Drop HYPERVISOR_COMPAT_VIRT_START()

2021-04-27 Thread Andrew Cooper
On 27/04/2021 14:18, Jan Beulich wrote: > On 27.04.2021 15:02, Andrew Cooper wrote: >> This is pure obfuscation (in particular, hiding the two locations where the >> variable gets set), and is longer than the code it replaces. > Obfuscation - not just; see below. > >> Also fix

Re: [PATCH] x86/pv: Drop HYPERVISOR_COMPAT_VIRT_START()

2021-04-27 Thread Jan Beulich
On 27.04.2021 15:02, Andrew Cooper wrote: > This is pure obfuscation (in particular, hiding the two locations where the > variable gets set), and is longer than the code it replaces. Obfuscation - not just; see below. > Also fix MACH2PHYS_COMPAT_VIRT_START to be expressed as a 1-parameter macro,

[PATCH] x86/pv: Drop HYPERVISOR_COMPAT_VIRT_START()

2021-04-27 Thread Andrew Cooper
This is pure obfuscation (in particular, hiding the two locations where the variable gets set), and is longer than the code it replaces. Also fix MACH2PHYS_COMPAT_VIRT_START to be expressed as a 1-parameter macro, which is how it is used. The current construct only works because