Re: [PATCH] x86/xen: fix secondary processor fpu initialization

[Juergen Gross]

On 03.07.23 19:51, Boris Ostrovsky wrote:



On 7/3/23 9:00 AM, Juergen Gross wrote:

Moving the call of fpu__init_cpu() from cpu_init() to start_secondary()
broke Xen PV guests, as those don't call start_secondary() for APs.

Fix that by adding the call of fpu__init_cpu() to cpu_bringup(), which
is the Xen PV replacement of start_secondary().

Fixes: b81fac906a8f ("x86/fpu: Move FPU initialization into 
arch_cpu_finalize_init()")

Signed-off-by: Juergen Gross 



Reviewed-by: Boris Ostrovsky 



x86 maintainers, could this please go through the tip tree? The patch is
depending on other 6.5 patches which went in via tip.


Juergen


OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key


OpenPGP_signature
Description: OpenPGP digital signature

Re: [PATCH] x86/xen: fix secondary processor fpu initialization

[Boris Ostrovsky]

On 7/3/23 9:00 AM, Juergen Gross wrote:

Moving the call of fpu__init_cpu() from cpu_init() to start_secondary()
broke Xen PV guests, as those don't call start_secondary() for APs.

Fix that by adding the call of fpu__init_cpu() to cpu_bringup(), which
is the Xen PV replacement of start_secondary().

Fixes: b81fac906a8f ("x86/fpu: Move FPU initialization into 
arch_cpu_finalize_init()")
Signed-off-by: Juergen Gross 



Reviewed-by: Boris Ostrovsky 

[PATCH] x86/xen: fix secondary processor fpu initialization

[Juergen Gross]

Moving the call of fpu__init_cpu() from cpu_init() to start_secondary()
broke Xen PV guests, as those don't call start_secondary() for APs.

Fix that by adding the call of fpu__init_cpu() to cpu_bringup(), which
is the Xen PV replacement of start_secondary().

Fixes: b81fac906a8f ("x86/fpu: Move FPU initialization into 
arch_cpu_finalize_init()")
Signed-off-by: Juergen Gross 
---
 arch/x86/xen/smp_pv.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/xen/smp_pv.c b/arch/x86/xen/smp_pv.c
index d5ae5de2daa2..cef78b8c89f4 100644
--- a/arch/x86/xen/smp_pv.c
+++ b/arch/x86/xen/smp_pv.c
@@ -63,6 +63,7 @@ static void cpu_bringup(void)
cr4_init();
cpuhp_ap_sync_alive();
cpu_init();
+   fpu__init_cpu();
touch_softlockup_watchdog();
 
/* PVH runs in ring 0 and allows us to do native syscalls. Yay! */
-- 
2.35.3