Re: [RESEND PATCH 08/12] golang/xenlight: add functional options to configure Context

2021-06-18 Thread George Dunlap
> On Jun 18, 2021, at 6:00 PM, Nick Rosbrook wrote: > > On Fri, Jun 18, 2021 at 04:18:44PM +, George Dunlap wrote: >> >> >>> On Jun 18, 2021, at 4:08 PM, Nick Rosbrook wrote: >>> >>> On Fri, Jun 18, 2021 at 02:44:15PM +, George Dunlap wrote: > On May 24, 2021, at

Re: [RESEND PATCH 08/12] golang/xenlight: add functional options to configure Context

2021-06-18 Thread Nick Rosbrook
On Fri, Jun 18, 2021 at 04:18:44PM +, George Dunlap wrote: > > > > On Jun 18, 2021, at 4:08 PM, Nick Rosbrook wrote: > > > > On Fri, Jun 18, 2021 at 02:44:15PM +, George Dunlap wrote: > >> > >> > >>> On May 24, 2021, at 9:36 PM, Nick Rosbrook wrote: > >>> > >>> Add a ContextOption

Re: [RESEND PATCH 08/12] golang/xenlight: add functional options to configure Context

2021-06-18 Thread George Dunlap
> On Jun 18, 2021, at 4:08 PM, Nick Rosbrook wrote: > > On Fri, Jun 18, 2021 at 02:44:15PM +, George Dunlap wrote: >> >> >>> On May 24, 2021, at 9:36 PM, Nick Rosbrook wrote: >>> >>> Add a ContextOption type to support functional options in NewContext. >>> Then, add a variadic

Re: [RESEND PATCH 08/12] golang/xenlight: add functional options to configure Context

2021-06-18 Thread Nick Rosbrook
On Fri, Jun 18, 2021 at 02:44:15PM +, George Dunlap wrote: > > > > On May 24, 2021, at 9:36 PM, Nick Rosbrook wrote: > > > > Add a ContextOption type to support functional options in NewContext. > > Then, add a variadic ContextOption parameter to NewContext, which allows > > callers to

Re: [RESEND PATCH 08/12] golang/xenlight: add functional options to configure Context

2021-06-18 Thread George Dunlap
> On May 24, 2021, at 9:36 PM, Nick Rosbrook wrote: > > Add a ContextOption type to support functional options in NewContext. > Then, add a variadic ContextOption parameter to NewContext, which allows > callers to specify 0 or more configuration options. > > For now, just add the

[RESEND PATCH 08/12] golang/xenlight: add functional options to configure Context

2021-05-24 Thread Nick Rosbrook
Add a ContextOption type to support functional options in NewContext. Then, add a variadic ContextOption parameter to NewContext, which allows callers to specify 0 or more configuration options. For now, just add the WithLogLevel option so that callers can set the log level of the Context's

[PATCH 08/12] golang/xenlight: add functional options to configure Context

2021-04-28 Thread Nick Rosbrook
Add a ContextOption type to support functional options in NewContext. Then, add a variadic ContextOption parameter to NewContext, which allows callers to specify 0 or more configuration options. For now, just add the WithLogLevel option so that callers can set the log level of the Context's