Re: [PATCH 2/4] x86/P2M: un-indent write_p2m_entry()

2024-04-24 Thread Jan Beulich
On 24.04.2024 11:16, Roger Pau Monné wrote: > On Tue, Apr 23, 2024 at 04:32:14PM +0200, Jan Beulich wrote: >> Drop the inner scope that was left from earlier if/else removal. Take >> the opportunity and make the paging_unlock() invocation common to >> success and error paths, though. > > TBH I'm

Re: [PATCH 2/4] x86/P2M: un-indent write_p2m_entry()

2024-04-24 Thread Roger Pau Monné
On Tue, Apr 23, 2024 at 04:32:14PM +0200, Jan Beulich wrote: > Drop the inner scope that was left from earlier if/else removal. Take > the opportunity and make the paging_unlock() invocation common to > success and error paths, though. TBH I'm not sure I prefer the fact to continue function

[PATCH 2/4] x86/P2M: un-indent write_p2m_entry()

2024-04-23 Thread Jan Beulich
Drop the inner scope that was left from earlier if/else removal. Take the opportunity and make the paging_unlock() invocation common to success and error paths, though. Signed-off-by: Jan Beulich --- a/xen/arch/x86/mm/p2m-pt.c +++ b/xen/arch/x86/mm/p2m-pt.c @@ -110,49 +110,43 @@ static int