Re: [PATCH 3/5] tools/libs/foreignmemory: Fix PAGE_SIZE redefinition error

2021-04-29 Thread Julien Grall
On 28/04/2021 19:27, Costin Lupu wrote: Hi Julien, Hi Costin, On 4/28/21 12:03 PM, Julien Grall wrote: Hi Costin, On 27/04/2021 13:05, Costin Lupu wrote:   tools/libs/foreignmemory/private.h | 6 --   1 file changed, 4 insertions(+), 2 deletions(-) diff --git

Re: [PATCH 3/5] tools/libs/foreignmemory: Fix PAGE_SIZE redefinition error

2021-04-28 Thread Costin Lupu
Hi Julien, On 4/28/21 12:03 PM, Julien Grall wrote: > Hi Costin, > > On 27/04/2021 13:05, Costin Lupu wrote: >>   tools/libs/foreignmemory/private.h | 6 -- >>   1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/tools/libs/foreignmemory/private.h >>

Re: [PATCH 3/5] tools/libs/foreignmemory: Fix PAGE_SIZE redefinition error

2021-04-28 Thread Julien Grall
Hi Costin, On 27/04/2021 13:05, Costin Lupu wrote: tools/libs/foreignmemory/private.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/libs/foreignmemory/private.h b/tools/libs/foreignmemory/private.h index 1ee3626dd2..f3c1ba2867 100644 ---

[PATCH 3/5] tools/libs/foreignmemory: Fix PAGE_SIZE redefinition error

2021-04-27 Thread Costin Lupu
If PAGE_SIZE is already defined in the system (e.g. in /usr/include/limits.h header) then gcc will trigger a redefinition error because of -Werror. This commit also protects PAGE_SHIFT and PAGE_MASK definitions for keeping consistency. Signed-off-by: Costin Lupu ---